Re: [PATCH] staging: rts5208: use temporary variable for readability

2015-05-17 Thread Gujulan Elango, Hari Prasath (H.)
On Fri, May 15, 2015 at 04:09:42PM +0300, Dan Carpenter wrote: > On Fri, May 15, 2015 at 12:09:42PM +, Gujulan Elango, Hari Prasath (H.) > wrote: > > Use a temporary value to hold the SD lock status thereby making the code > > readable.This also fixes a coding style violation with the braces a

Re: [PATCH] staging: sm750fb: fix typo in fb_videomode Array

2015-05-17 Thread Sudip Mukherjee
On Sat, May 16, 2015 at 09:31:28PM +0200, Michel von Czettritz wrote: > It appears that 'FB_SYNC_HOR_HIGH_ACT' should be assined to 'sync' > and 'FB_VMODE_NONINTERLACED' is a flag for 'vmode'. > > > diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c > index 77310ff..8

Re: [PATCH 00/25] Start of removal of lustre procfs support

2015-05-17 Thread Oleg Drokin
Hm, Actually please don't merge this one yet. I have a better one in the works that I'll hopefully send in the next couple of days. Thanks. On May 16, 2015, at 3:30 AM, gr...@linuxhacker.ru wrote: > From: Oleg Drokin > > This is beginning of work in the area. It takes a bit longer than > anti

Re: [PATCH 1/1] Staging: comedi: fix line longer than 80 chars in cb_pcidas64.c

2015-05-17 Thread Sudip Mukherjee
On Sun, May 17, 2015 at 04:47:23PM +0200, Amaury Denoyelle wrote: > This patch fixes coding style errors reported by checkpatch.pl for > cb_pcidas64.c, about too long source code lines. > > Signed-off-by: Amaury Denoyelle > --- > } > > -/* adjusts the size of hardware fifo (which determines b

Re: [PATCH] Clarify expression which uses both multiplication and pointer dereference

2015-05-17 Thread Alex Dowad
On 17/05/15 22:16, Joe Perches wrote: On Sun, 2015-05-17 at 19:18 +0200, Alex Dowad wrote: This fixes a checkpatch style error in vpfe_buffer_queue_setup. There is no checkpatch message for this style. Nor should there be. Strange. With: cd drivers/staging/media ../../../scripts/checkpatch

Re: [PATCH net-next,1/1] hv_netvsc: change member name of struct netvsc_stats

2015-05-17 Thread David Miller
From: Simon Xiao Date: Fri, 15 May 2015 02:33:03 -0700 > Currently the struct netvsc_stats has a member s_sync > of type u64_stats_sync. > This definition will break kernel build as the macro > netdev_alloc_pcpu_stats requires this member name to be syncp. > (see netdev_alloc_pcpu_stats definitio

Calvary greetings to you in the name of our lord almighty

2015-05-17 Thread Tony Bright
I, Evangelist Tony Bright under the close supervision of the lord almighty hereby write to you on behalf of the entire members of Infant Jesus Catholic Church (Foundation) in conjunction with Infant Jesus Academy Catholic Co-Educational Boarding School Asaba Delta State. We pray that this messag

Re: [PATCH] Clarify expression which uses both multiplication and pointer dereference

2015-05-17 Thread Joe Perches
On Sun, 2015-05-17 at 19:18 +0200, Alex Dowad wrote: > This fixes a checkpatch style error in vpfe_buffer_queue_setup. There is no checkpatch message for this style. Nor should there be. > diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c > b/drivers/staging/media/davinci_vpfe/vpfe_v

Re: [PATCH] staging: rtl8712: Use ether_addr_copy() instead of memcpy()

2015-05-17 Thread Larry Finger
On 05/17/2015 03:57 PM, Jagan Teki wrote: This patch fixes to use ether_addr_copy() instead of memcpy() Encounter this by applying checkpatch.pl against this file: WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) Signed-off-by: Jagan Teki Cc: Gre

Re: [PATCH] staging: rtl8712: Use ether_addr_copy() instead of memcpy()

2015-05-17 Thread Greg Kroah-Hartman
On Mon, May 18, 2015 at 02:27:01AM +0530, Jagan Teki wrote: > This patch fixes to use ether_addr_copy() instead of memcpy() > > Encounter this by applying checkpatch.pl against this file: > WARNING: Prefer ether_addr_copy() over memcpy() > if the Ethernet addresses are __aligned(2) > > Signed

[PATCH] staging: unisys: remove braces from single statement blocks

2015-05-17 Thread Isaac Assegai
Remove the braces to satisfy this checkpatch warning: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Isaac Assegai --- drivers/staging/unisys/virthba/virthba.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/unisys/virthb

[PATCH] staging: rtl8712: Use ether_addr_copy() instead of memcpy()

2015-05-17 Thread Jagan Teki
This patch fixes to use ether_addr_copy() instead of memcpy() Encounter this by applying checkpatch.pl against this file: WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2) Signed-off-by: Jagan Teki Cc: Greg Kroah-Hartman Cc: Larry Finger Cc: Florian

Re: [PATCH v3 03/33] staging: rtl8192e: Mark unaligned memcpy()

2015-05-17 Thread Mateusz Kulikowski
On 15.05.2015 01:14, Dan Carpenter wrote: > On Thu, May 14, 2015 at 10:29:39PM +0200, Mateusz Kulikowski wrote: >> On 13.05.2015 10:22, Dan Carpenter wrote: >>> On Tue, May 12, 2015 at 10:00:13PM +0200, Mateusz Kulikowski wrote: On 11.05.2015 10:26, Dan Carpenter wrote: >> (...) > > Wh

Re: [PATCH v3 1/2] staging: wilc1000: Add SDIO/SPI 802.11 driver

2015-05-17 Thread Greg KH
On Sun, May 17, 2015 at 08:53:44PM +0200, Nicolas Ferre wrote: > Le 11/05/2015 07:30, Johnny Kim a écrit : > > This driver is for the wilc1000 which is a single chip IEEE 802.11 > > b/g/n device. > > The driver works together with cfg80211, which is the kernel side of > > configuration management f

Re: [PATCH] Clarify expression which uses both multiplication and pointer dereference

2015-05-17 Thread Laurent Pinchart
Hi Alex, Thank you for the patch. On Sunday 17 May 2015 19:18:42 Alex Dowad wrote: > This fixes a checkpatch style error in vpfe_buffer_queue_setup. > > Signed-off-by: Alex Dowad Acked-by: Laurent Pinchart > --- > drivers/staging/media/davinci_vpfe/vpfe_video.c | 2 +- > 1 file changed, 1 i

[PATCH] Staging: dgnc: fixed coding style issue in digi.h

2015-05-17 Thread Buţiu Alexandru Octavian
Fixed coding style issue "warning line over 80 characters" detected by checkpatch.pl in digi.h Signed-off-by: Buţiu Alexandru Octavian --- drivers/staging/dgnc/digi.h | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/dgnc/digi.h b/drivers/staging/

Re: [PATCH v3 1/2] staging: wilc1000: Add SDIO/SPI 802.11 driver

2015-05-17 Thread Nicolas Ferre
Le 11/05/2015 07:30, Johnny Kim a écrit : > This driver is for the wilc1000 which is a single chip IEEE 802.11 > b/g/n device. > The driver works together with cfg80211, which is the kernel side of > configuration management for wireless devices because the wilc1000 > chipset is fullmac where the M

[PATCH] Remove empty branch from conditional

2015-05-17 Thread Alex Dowad
This fixes a checkpatch style warning in ft1000_ioctl. Signed-off-by: Alex Dowad --- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c b/drivers/staging/ft1000/ft1000-usb/ft1000

[PATCH] Clarify expression which uses both multiplication and pointer dereference

2015-05-17 Thread Alex Dowad
This fixes a checkpatch style error in vpfe_buffer_queue_setup. Signed-off-by: Alex Dowad --- drivers/staging/media/davinci_vpfe/vpfe_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/davinci_vpfe/vpfe_video.c b/drivers/staging/media/davinci_vpfe/

[PATCH 1/1] Staging: comedi: fix line longer than 80 chars in cb_pcidas64.c

2015-05-17 Thread Amaury Denoyelle
This patch fixes coding style errors reported by checkpatch.pl for cb_pcidas64.c, about too long source code lines. Signed-off-by: Amaury Denoyelle --- drivers/staging/comedi/drivers/cb_pcidas64.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/staging/c