On Thu, 2015-04-30 at 16:29 -0700, K. Y. Srinivasan wrote:
> Based on the information given to this driver (via the xmit_more skb flag),
> we can defer signaling the host if more packets are on the way. This will help
> make the host more efficient since it can potentially process a larger batch
>
This file is built off of a tristate Kconfig option and also contains
modular function calls so it should explicitly include module.h to
avoid compile breakage during header shuffles done in the future.
Cc: Greg Kroah-Hartman
Cc: "Arve Hj�nnev�g"
Cc: Riley Andrews
Cc: Stephen Warren
Cc: Thierr
On Thu, 30 Apr 2015 16:14:06 +0200
"gre...@linuxfoundation.org" wrote:
> On Thu, Apr 23, 2015 at 04:09:28PM +0100, Alan Cox wrote:
> > On Thu, 2015-04-23 at 13:43 +, Gujulan Elango, Hari Prasath (H.)
> > wrote:
> > > This patch removes unwanted semicolon around close braces of code blocks
> >
Based on the information given to this driver (via the xmit_more skb flag),
we can defer signaling the host if more packets are on the way. This will help
make the host more efficient since it can potentially process a larger batch of
packets. Implement this optimization.
Signed-off-by: K. Y. Srin
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Thursday, April 30, 2015 1:35 PM
> To: KY Srinivasan
> Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> jasow...@redhat.com
> Subje
From: "K. Y. Srinivasan"
Date: Wed, 29 Apr 2015 15:33:42 -0700
> @@ -772,19 +773,21 @@ static inline int netvsc_send_pkt(
> if (packet->page_buf_cnt) {
> pgbuf = packet->cp_partial ? packet->page_buf +
> packet->rmsg_pgcnt : packet->page_buf;
> -
On Thu, Apr 30, 2015 at 10:38:27AM -0700, Luis R. Rodriguez wrote:
> On Tue, Apr 21, 2015 at 1:13 PM, Luis R. Rodriguez
> wrote:
> > From: "Luis R. Rodriguez"
> >
> > The same area used for ioremap() is used for the MTRR area.
> > Convert the driver from using the x86 specific MTRR code to
> > th
On 04/30/2015 12:50 PM, Gujulan Elango, Hari Prasath (H.) wrote:
From: Larry Finger on behalf of Larry Finger
Sent: Thursday, April 30, 2015 11:03 PM
To: Gujulan Elango, Hari Prasath (H.); Dan Carpenter
Cc: de...@driverdev.osuosl.org; julia.law...@lip6.fr;
gre...@linuxfoundation.org; wlan...
From: Larry Finger on behalf of Larry Finger
Sent: Thursday, April 30, 2015 11:03 PM
To: Gujulan Elango, Hari Prasath (H.); Dan Carpenter
Cc: de...@driverdev.osuosl.org; julia.law...@lip6.fr;
gre...@linuxfoundation.org; wlan...@realtek.com; mateusz.kulikow...@gmail.com;
Babu, Viswanathan (V.)
On Tue, Apr 21, 2015 at 1:13 PM, Luis R. Rodriguez
wrote:
> From: "Luis R. Rodriguez"
>
> The same area used for ioremap() is used for the MTRR area.
> Convert the driver from using the x86 specific MTRR code to
> the architecture agnostic arch_phys_wc_add(). arch_phys_wc_add()
> will avoid MTRR
On 04/30/2015 11:59 AM, Gujulan Elango, Hari Prasath (H.) wrote:
From: Dan Carpenter
Sent: Thursday, April 30, 2015 6:33 PM
To: Gujulan Elango, Hari Prasath (H.)
Cc: de...@driverdev.osuosl.org; julia.law...@lip6.fr;
gre...@linuxfoundation.org; wlan...@realtek.com; mateusz.kulikow...@gmail.com;
struct timeval tv is used to get current time.
32-bit systems using 'struct timeval' will break in the year 2038, so
we have to replace that code with more appropriate types.
Signed-off-by: Ksenija Stanojevic
Reviewed-by: Arnd Bergmann
---
drivers/staging/rts5208/rtsx.h | 25 ++-
From: Dan Carpenter
Sent: Thursday, April 30, 2015 6:33 PM
To: Gujulan Elango, Hari Prasath (H.)
Cc: de...@driverdev.osuosl.org; julia.law...@lip6.fr;
gre...@linuxfoundation.org; wlan...@realtek.com; mateusz.kulikow...@gmail.com;
Babu, Viswanathan (V.); larry.fin...@lwfinger.net
Subject: Re: [PA
On 30 April 2015 at 19:44, gre...@linuxfoundation.org
wrote:
> On Thu, Apr 23, 2015 at 04:09:28PM +0100, Alan Cox wrote:
>> On Thu, 2015-04-23 at 13:43 +, Gujulan Elango, Hari Prasath (H.)
>> wrote:
>> > This patch removes unwanted semicolon around close braces of code blocks
>>
>>
>> The i2o
On 30 April 2015 at 19:54, gre...@linuxfoundation.org
wrote:
> On Fri, Apr 24, 2015 at 07:52:31AM +, Gujulan Elango, Hari Prasath (H.)
> wrote:
>> The fops structure is referenced only locally and hence could be made static
>>
>> Signed-off-by: Hari Prasath Gujulan Elango
>> ---
>> drivers/
drivers/staging/lustre/lustre/lov/lov_request.c:74:3-8: WARNING: NULL check
before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive
or usb_free_urb is not needed. Maybe consider reorganizing relevant code to
avoid passing NULL values.
NULL check before some freeing functi
drivers/staging/lustre/lustre/llite/llite_lib.c:989:2-7: WARNING: NULL check
before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive
or usb_free_urb is not needed. Maybe consider reorganizing relevant code to
avoid passing NULL values.
drivers/staging/lustre/lustre/llite/ll
drivers/staging/lustre/lustre/llite/dir.c:1440:3-8: WARNING: NULL check before
freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or
usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid
passing NULL values.
NULL check before some freeing functions
On Thu, Apr 16, 2015 at 01:29:19PM -0400, Garret Kelly wrote:
> fbtft uses fb_info's screen_base field to store a non-__iomem
> allocation. Cast away the __iomem qualifier when freeing the pointer to
> suppress the sparse warning.
Can't we fix this properly, to use the correct type of pointer ins
On 04/30/2015 10:36 AM, Greg KH wrote:
Because patch 08 didn't apply, this one has fuzz problems, and the reset
in the series doesn't apply. Can you refresh against my tree and resend
the rest?
Will do, thanks for taking these. :)
-- Ben
___
devel
On Fri, Apr 10, 2015 at 03:45:50PM +0200, Marcus Folkesson wrote:
> Warnings reported by sparse:
>
> drivers/staging/fbtft/fbtft-core.c:1004:4: warning: format ‘%d’ expects
> argument of type ‘int’, but argument 3 has type ‘size_t’ [-Wformat=]
> par->txbuf.len >> 10, par->txbuf.dma ? "DMA " :
On Thu, Apr 16, 2015 at 09:08:11PM +0800, weiyj...@163.com wrote:
> From: Wei Yongjun
>
> Remove including that don't need it.
>
> Signed-off-by: Wei Yongjun
> ---
> drivers/staging/unisys/virtpci/virtpci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/unisys/virtpc
On Mon, Apr 13, 2015 at 10:28:46AM -0400, jes.soren...@redhat.com wrote:
> From: Jes Sorensen
>
> Signed-off-by: Jes Sorensen
> Tested-by: Benjamin Romer
> ---
> drivers/staging/unisys/visorchipset/globals.h | 2 --
> drivers/staging/unisys/visorchipset/visorchipset.h | 2 ++
> 2 files ch
On Mon, Apr 13, 2015 at 10:28:45AM -0400, jes.soren...@redhat.com wrote:
> From: Jes Sorensen
>
> Signed-off-by: Jes Sorensen
> Tested-by: Benjamin Romer
> ---
> drivers/staging/unisys/visorchipset/globals.h | 11
> .../unisys/visorchipset/visorchipset_main.c| 33
> +
On Mon, Apr 06, 2015 at 10:27:39AM -0400, Benjamin Romer wrote:
> Fix these Camelcase constants:
>
> VISOR_CHIPSET_PC_controlvm_c => VISOR_CHIPSET_PC_CONTROLVM_C
> VISOR_CHIPSET_PC_controlvm_cm2 => VISOR_CHIPSET_PC_CONTROLVM_CM2
> VISOR_CHIPSET_PC_controlvm_direct_c =>
> VISOR_CHIPSET_PC_CON
On Fri, Apr 24, 2015 at 07:52:31AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> The fops structure is referenced only locally and hence could be made static
>
> Signed-off-by: Hari Prasath Gujulan Elango
> ---
> drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 2 +-
> 1 file changed, 1 inse
On Thu, Apr 23, 2015 at 04:09:28PM +0100, Alan Cox wrote:
> On Thu, 2015-04-23 at 13:43 +, Gujulan Elango, Hari Prasath (H.)
> wrote:
> > This patch removes unwanted semicolon around close braces of code blocks
>
>
> The i2o driver moved into staging ready to be deleted unless someone
> steps
On Thu, Apr 30, 2015 at 09:03:03PM +0800, kbuild test robot wrote:
> drivers/staging/i2o/iop.c:1065:2-3: Unneeded semicolon
>
>
> Removes unneeded semicolon.
>
> Generated by: scripts/coccinelle/misc/semicolon.cocci
>
> CC: Alan Cox
> Signed-off-by: Fengguang Wu
> ---
Someone else sent this
drivers/staging/i2o/iop.c:1065:2-3: Unneeded semicolon
Removes unneeded semicolon.
Generated by: scripts/coccinelle/misc/semicolon.cocci
CC: Alan Cox
Signed-off-by: Fengguang Wu
---
iop.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/staging/i2o/iop.c
+++ b/driver
drivers/staging/i2o/iop.c:777:1-3: WARNING: end returns can be simpified
Simplify a trivial if-return sequence. Possibly combine with a
preceding function call.
Generated by: scripts/coccinelle/misc/simple_return.cocci
CC: Alan Cox
Signed-off-by: Fengguang Wu
---
iop.c |6 +-
1 fil
On Thu, Apr 30, 2015 at 12:06:28PM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> This patch addresses a spatch warning on assigning a negative
> value to a unsigned integer.Similar patch has been submitted by
> Larry Finger earlier to silence the same spatch warning in another
> file.
What's
On Tue, Apr 28, 2015 at 12:39:10PM -0500, J. German Rivera wrote:
> /**
> - * dprc_lookup_object - Finds a given MC object in a DPRC and returns
> - * the index of the object in the DPRC
> - *
> - * @mc_bus_dev: pointer to the fsl-mc device that represents a DPRC object
> - * @child_dev: pointer t
On Tue, Apr 28, 2015 at 12:39:09PM -0500, J. German Rivera wrote:
> @@ -230,15 +235,26 @@ static inline enum mc_cmd_status
> mc_read_response(struct mc_command __iomem *
> * @cmd: command to be sent
> *
> * Returns '0' on Success; Error code otherwise.
> - *
> - * NOTE: This function cannot
On Tue, Apr 28, 2015 at 12:39:07PM -0500, J. German Rivera wrote:
> - Migrated MC bus driver to use DPRC flib 0.6.
What does this mean? What is a flib?
After reading the patch, apparently it means that we can remove all the
ifdefs from patch 1. :)
> - Changed IRQ setup infrastructure to be abl
This patch addresses a spatch warning on assigning a negative
value to a unsigned integer.Similar patch has been submitted by
Larry Finger earlier to silence the same spatch warning in another
file. The logic is the negative number to an unsigned quantity is
fixed by adding 256 to -98 to get the eq
On Tue, Apr 28, 2015 at 12:39:04PM -0500, J. German Rivera wrote:
> Change-Id: I2a986c465989c3811de19cfe9ed0b77168250cb1
> Reviewed-on: http://git.am.freescale.net:8181/33626
> Tested-by: Review Code-CDREVIEW
These things are totally useless to the rest of us. Don't add them.
> diff --git a/dr
From: gre...@linuxfoundation.org
Sent: Thursday, April 30, 2015 3:05 PM
To: Gujulan Elango, Hari Prasath (H.)
Cc: de...@driverdev.osuosl.org; julia.law...@lip6.fr; dan.carpen...@oracle.com;
larry.fin...@lwfinger.net; florian.c.schilha...@googlemail.com; Babu,
Viswanathan (V.)
Subject: Re: [PATCH
return error directly to avoid unwanted branching where no cleanup
is done.Also removes the ret variable.
Signed-off-by: Hari Prasath Gujulan Elango
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/
On Thu, Apr 30, 2015 at 08:23:08AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> Signed-off-by: Hari Prasath Gujulan Elango
>
> return error directly to avoid unwanted branching where no cleanup
> is done.Also removes the ret variable.
signed-off-by goes below the description, not above it.
On 04/30/2015 06:11 PM, Dan Carpenter wrote:
On Tue, Apr 28, 2015 at 04:58:34PM +0900, Alexandre Courbot wrote:
Gentle ping for feedback - some of our future work depends on this
and we would like to know whether this has a chance of being
accepted?
Arve wasn't CC'd on the first/usable version
On Tue, Apr 28, 2015 at 04:58:34PM +0900, Alexandre Courbot wrote:
> Gentle ping for feedback - some of our future work depends on this
> and we would like to know whether this has a chance of being
> accepted?
Arve wasn't CC'd on the first/usable version of this patch. He or Colin
need to Ack an
Signed-off-by: Hari Prasath Gujulan Elango
return error directly to avoid unwanted branching where no cleanup
is done.Also removes the ret variable.
---
drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/
The return value of memdup_user is a pointer to errno.Freeing it will cause
error.Hence set it to NULL before branching to free the pointer.smatch also
raises the same warning.
Signed-off-by: Hari Prasath Gujulan Elango
---
v2:Remove unnecessary goto and return error directly.Use goto
From: Dan Carpenter
Sent: Thursday, April 30, 2015 12:45 PM
To: Gujulan Elango, Hari Prasath (H.)
Cc: de...@driverdev.osuosl.org; julia.law...@lip6.fr;
florian.c.schilha...@googlemail.com; gre...@linuxfoundation.org; Babu,
Viswanathan (V.); larry.fin...@l
I sent a fix for this a couple weeks ago.
On Thu, Apr 30, 2015 at 06:32:01AM +, Gujulan Elango, Hari Prasath (H.)
wrote:
> The return value of memdup_user is a pointer to errno.Freeing it will cause
> error.Hence set it to NULL before branching to free the pointer.smatch also
> raises the sam
45 matches
Mail list logo
