[PATCH] hv: vmbus_free_channels(): remove the redundant free_channel()

2015-04-08 Thread Dexuan Cui
free_channel() has been invoked in vmbus_remove() -> hv_process_channel_removal(), or vmbus_remove() -> ... -> vmbus_close_internal() -> hv_process_channel_removal(). We also change to use list_for_each_entry_safe(), because the entry is removed in hv_process_channel_removal(). Thank Dan Carpente

[PATCH] staging: lustre: llite: remove obsolete conditional code

2015-04-08 Thread Andreas Dilger
Remove conditional flock/aops code that was only for out-of-tree vendor kernels but is not relevant for in-kernel code. Signed-off-by: Andreas Dilger --- drivers/staging/lustre/lustre/llite/llite_internal.h | 4 drivers/staging/lustre/lustre/llite/llite_lib.c | 8 drivers/st

Re: [PATCH 6/6] staging: fsl-mc: Changed version matching rules for MC object drivers

2015-04-08 Thread Alexander Graf
On 03/27/2015 10:01 PM, J. German Rivera wrote: Before this change, we were requiring a complete version match (major and minor version numbers) between MC objects and corresponding drivers, to allow MC objects to be bound to their drivers. We realized that a mismatch in minor version numbers sho

Re: [PATCH 0/6] staging: fsl-mc: cleanup and minor corrections

2015-04-08 Thread Alexander Graf
On 03/27/2015 10:01 PM, J. German Rivera wrote: This patch series includes some cleanup/refactoring and minor correction patches for the Freescale fsl-mc bus driver. Patch 1: Name MC object devices using decimal numbers Patch 2: Removed reordering of MC objects during bus scan Patch 3: Bind/unbi

Re: [PATCH 01/14] parport: return value of attach and parport_register_driver

2015-04-08 Thread Willy Tarreau
On Wed, Apr 08, 2015 at 03:27:37PM +0300, Dan Carpenter wrote: > On Wed, Apr 08, 2015 at 05:20:10PM +0530, Sudip Mukherjee wrote: > > On Wed, Apr 08, 2015 at 02:38:32PM +0300, Dan Carpenter wrote: > > > 1) We can't apply this patch on its own so this way of breaking up the > > > patches doesn't wor

Re: [PATCH V2 0/7] scsi: storvsc: Miscellaneous enhancements and fixes

2015-04-08 Thread James Bottomley
On Fri, 2015-03-27 at 00:26 -0700, K. Y. Srinivasan wrote: > This patch-set addresses perf issues discovered on the Azure storage stack. > These patches also fix a couple of bugs. > > As in the first version of this patch-set, some of the patches are simply a > resend. > I have bumped up the vers

[PATCH] Staging: sm750fb: Remove space after parenthesis

2015-04-08 Thread Amitoj Kaur Chawla
Fixed error by removing space after open parenthesis '(' Problem found using checkpatch.pl ERROR: space prohibited after that open parenthesis '(' Signed-off-by: Amitoj Kaur Chawla --- drivers/staging/sm750fb/ddk750_chip.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/d

Re: [PATCH 0/2] hv_netvsc: linearize SKBs bigger than MAX_PAGE_BUFFER_COUNT-2 pages

2015-04-08 Thread Vitaly Kuznetsov
David Miller writes: > From: Vitaly Kuznetsov > Date: Wed, 8 Apr 2015 17:54:04 +0200 > >> This patch series fixes the same issue which was fixed in Xen with commit >> 97a6d1bb2b658ac85ed88205ccd1ab809899884d ("xen-netfront: Fix handling >> packets on >> compound pages with skb_linearize"). > >

Re: [PATCH 0/2] hv_netvsc: linearize SKBs bigger than MAX_PAGE_BUFFER_COUNT-2 pages

2015-04-08 Thread David Miller
From: Vitaly Kuznetsov Date: Wed, 8 Apr 2015 17:54:04 +0200 > This patch series fixes the same issue which was fixed in Xen with commit > 97a6d1bb2b658ac85ed88205ccd1ab809899884d ("xen-netfront: Fix handling packets > on > compound pages with skb_linearize"). This patch series only applies on

RE: [PATCH RFCv2 00/21] Drivers: hv: utils: re-implement the kernel/userspace communication layer

2015-04-08 Thread KY Srinivasan
> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Wednesday, April 8, 2015 9:01 AM > To: KY Srinivasan > Cc: de...@linuxdriverproject.org; Haiyang Zhang; linux- > ker...@vger.kernel.org; Dexuan Cui; Radim Krcmar; Greg Kroah-Hartman; > linux-...@vger.kernel

Re: [PATCH RFCv2 00/21] Drivers: hv: utils: re-implement the kernel/userspace communication layer

2015-04-08 Thread Vitaly Kuznetsov
KY Srinivasan writes: >> -Original Message- >> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] >> Sent: Wednesday, March 11, 2015 6:29 AM >> To: KY Srinivasan; de...@linuxdriverproject.org >> Cc: Haiyang Zhang; linux-ker...@vger.kernel.org; Dexuan Cui; Radim Krcmar; >> Greg Kroah-Hart

[PATCH 1/2] hv_netvsc: use single existing drop path in netvsc_start_xmit

2015-04-08 Thread Vitaly Kuznetsov
... which validly uses dev_kfree_skb_any() instead of dev_kfree_skb(). Setting ret to -EFAULT and -ENOMEM have no real meaning here (we need to set it to anything but -EAGAIN) as we drop the packet and return NETDEV_TX_OK anyway. Signed-off-by: Vitaly Kuznetsov --- drivers/net/hyperv/netvsc_drv

[PATCH 0/2] hv_netvsc: linearize SKBs bigger than MAX_PAGE_BUFFER_COUNT-2 pages

2015-04-08 Thread Vitaly Kuznetsov
This patch series fixes the same issue which was fixed in Xen with commit 97a6d1bb2b658ac85ed88205ccd1ab809899884d ("xen-netfront: Fix handling packets on compound pages with skb_linearize"). It is relatively easy to create a packet which is small in size but occupies more than 30 (MAX_PAGE_BUFFER

[PATCH 2/2] hv_netvsc: try linearizing big SKBs before dropping them

2015-04-08 Thread Vitaly Kuznetsov
In netvsc_start_xmit() we can handle packets which are scattered around not more than MAX_PAGE_BUFFER_COUNT-2 pages. It is, however, easy to create a packet which is not big in size but occupies more pages (e.g. if it uses frags on compound pages boundaries). When we drop such packet it cases sende

Re: [PATCH 02/14] ALSA: portman2x4: return proper error values from attach

2015-04-08 Thread Sudip Mukherjee
On Wed, Apr 08, 2015 at 04:32:57PM +0300, Sergei Shtylyov wrote: > Hello. > > On 4/8/2015 2:20 PM, Sudip Mukherjee wrote: > > >now that we are monitoring the return value from attach, make the > >So you've first changed the method prototype and follow up with > the changes to the actual impl

Re: [PATCH 02/14] ALSA: portman2x4: return proper error values from attach

2015-04-08 Thread Sergei Shtylyov
Hello. On 4/8/2015 2:20 PM, Sudip Mukherjee wrote: now that we are monitoring the return value from attach, make the So you've first changed the method prototype and follow up with the changes to the actual implementations? That's backward. I'm afraid such changes can't be done piecemeal

[PATCH] staging: dgnc: remove some dead code from dgnc_tty.c

2015-04-08 Thread Giedrius Statkevičius
Remove some dead code that will never be executed or which serves no purpose Signed-off-by: Giedrius Statkevičius --- drivers/staging/dgnc/dgnc_tty.c | 16 1 file changed, 16 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_tty.c b/drivers/staging/dgnc/dgnc_tty.c index ce418

Re: [PATCH] media: cxd2099: move pre-init values out of init()

2015-04-08 Thread Luis de Bethencourt
On Wed, Apr 08, 2015 at 08:09:03AM -0300, Mauro Carvalho Chehab wrote: > Em Sun, 8 Feb 2015 20:55:36 + > luisbg escreveu: > > > Improve code readability by moving out all pre-init values from the init > > function. > > > > Signed-off-by: Luis de Bethencourt > > --- > > drivers/staging/medi

Re: [PATCH 01/14] parport: return value of attach and parport_register_driver

2015-04-08 Thread Dan Carpenter
On Wed, Apr 08, 2015 at 05:20:10PM +0530, Sudip Mukherjee wrote: > On Wed, Apr 08, 2015 at 02:38:32PM +0300, Dan Carpenter wrote: > > 1) We can't apply this patch on its own so this way of breaking up the > > patches doesn't work. > yes, if the first patch is reverted for any reason all the others

Re: [PATCH 01/14] parport: return value of attach and parport_register_driver

2015-04-08 Thread Sudip Mukherjee
On Wed, Apr 08, 2015 at 02:44:37PM +0300, Dan Carpenter wrote: > On Wed, Apr 08, 2015 at 02:38:32PM +0300, Dan Carpenter wrote: > > Then we convert one driver to use the new function pointer and see if > it simplifies the code. If so we can transition the others as well. If > not then we give up

Re: [PATCH 01/14] parport: return value of attach and parport_register_driver

2015-04-08 Thread Sudip Mukherjee
On Wed, Apr 08, 2015 at 02:38:32PM +0300, Dan Carpenter wrote: > 1) We can't apply this patch on its own so this way of breaking up the > patches doesn't work. yes, if the first patch is reverted for any reason all the others need to be reverted also. so then everything in one single patch? > > 2)

Re: [PATCH 01/14] parport: return value of attach and parport_register_driver

2015-04-08 Thread Dan Carpenter
On Wed, Apr 08, 2015 at 02:38:32PM +0300, Dan Carpenter wrote: > 1) We can't apply this patch on its own so this way of breaking up the > patches doesn't work. > The right thing is to do add an attach_ret(). static int do_attach(drv) { if (drv->attach_ret) return drv->att

Re: [PATCH 01/14] parport: return value of attach and parport_register_driver

2015-04-08 Thread Dan Carpenter
1) We can't apply this patch on its own so this way of breaking up the patches doesn't work. 2) I was thinking that all the ->attach() calls would have to succeed or we would bail. Having some of them succeed and some fail doesn't seem like it will simplify the driver code very much. But I can a

[PATCH 14/14] char: lp: return proper error values from attach

2015-04-08 Thread Sudip Mukherjee
now that we are monitoring the return value from attach, make the required changes to return proper value from its attach function. Signed-off-by: Sudip Mukherjee --- drivers/char/lp.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/char/lp.c b/drive

[PATCH 13/14] ppdev: return proper error values from attach

2015-04-08 Thread Sudip Mukherjee
now that we are monitoring the return value from attach, make the required changes to return proper value from its attach function. Signed-off-by: Sudip Mukherjee --- drivers/char/ppdev.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/char/ppdev.c b/driver

[PATCH 10/14] pps: return proper error values from attach

2015-04-08 Thread Sudip Mukherjee
now that we are monitoring the return value from attach, make the required changes to return proper value from its attach function. Signed-off-by: Sudip Mukherjee --- drivers/pps/clients/pps_parport.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/pps/clients/

[PATCH 12/14] i2c-parport: return proper error values from attach

2015-04-08 Thread Sudip Mukherjee
now that we are monitoring the return value from attach, make the required changes to return proper value from its attach function. Signed-off-by: Sudip Mukherjee --- drivers/i2c/busses/i2c-parport.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2

[PATCH 09/14] pps: return proper error values from attach

2015-04-08 Thread Sudip Mukherjee
now that we are monitoring the return value from attach, make the required changes to return proper value from its attach function. Signed-off-by: Sudip Mukherjee --- drivers/pps/generators/pps_gen_parport.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/pps

[PATCH 05/14] spi: lm70llp: return proper error values from attach

2015-04-08 Thread Sudip Mukherjee
now that we are monitoring the return value from attach, make the required changes to return proper value from its attach function. Signed-off-by: Sudip Mukherjee --- drivers/spi/spi-lm70llp.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-lm70llp.c b/

[PATCH 11/14] net: plip: return proper error values from attach

2015-04-08 Thread Sudip Mukherjee
now that we are monitoring the return value from attach, make the required changes to return proper value from its attach function. also return the proper error code in module_init. Signed-off-by: Sudip Mukherjee --- drivers/net/plip/plip.c | 16 ++-- 1 file changed, 10 insertions(+)

[PATCH 07/14] [SCSI] ppa: return proper error values from attach

2015-04-08 Thread Sudip Mukherjee
now that we are monitoring the return value from attach, make the required changes to return proper value from its attach function. Signed-off-by: Sudip Mukherjee --- drivers/scsi/ppa.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/ppa.c b/drivers/scsi/ppa.

[PATCH 04/14] staging: panel: return proper error values from attach

2015-04-08 Thread Sudip Mukherjee
now that we are monitoring the return value from attach, make the required changes to return proper value from its attach function. Signed-off-by: Sudip Mukherjee --- drivers/staging/panel/panel.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/pan

[PATCH 08/14] [SCSI] imm: return proper error values from attach

2015-04-08 Thread Sudip Mukherjee
now that we are monitoring the return value from attach, make the required changes to return proper value from its attach function. Signed-off-by: Sudip Mukherjee --- drivers/scsi/imm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/imm.c b/drivers/scsi/imm.

[PATCH 01/14] parport: return value of attach and parport_register_driver

2015-04-08 Thread Sudip Mukherjee
as of now, we are not checking if attach or parport_register_driver has succeeded or failed. But attach can fail in the places where they have been used. Lets check the return of attach, and if attach fails then parport_register_driver should also fail. We can have multiple parallel port so we only

[PATCH 06/14] spi: butterfly: return proper error values from attach

2015-04-08 Thread Sudip Mukherjee
now that we are monitoring the return value from attach, make the required changes to return proper value from its attach function. Signed-off-by: Sudip Mukherjee --- drivers/spi/spi-butterfly.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/spi/spi-butterfly.

[PATCH 00/14] parport: check success of attach call

2015-04-08 Thread Sudip Mukherjee
Currently we are not checking if attach has succeeded or not. Also parport_register_driver() always return 0 even if attach fails. But in many places where attach has been used, it can fail. So, modified the parport code to check the return value of attach and accordingly return either 0 or error c

[PATCH 03/14] ALSA: mts64: return proper error values from attach

2015-04-08 Thread Sudip Mukherjee
now that we are monitoring the return value from attach, make the required changes to return proper value from its attach function. Signed-off-by: Sudip Mukherjee --- sound/drivers/mts64.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/sound/drivers/mts64.c b/s

[PATCH 02/14] ALSA: portman2x4: return proper error values from attach

2015-04-08 Thread Sudip Mukherjee
now that we are monitoring the return value from attach, make the required changes to return proper value from its attach function. Signed-off-by: Sudip Mukherjee --- sound/drivers/portman2x4.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/sound/drivers/por

[patch] staging: rtl8712: freeing an ERR_PTR

2015-04-08 Thread Dan Carpenter
If memdup_user() fails then "pparmbuf" is an error pointer and we can't pass it to kfree(). I changed the "goto _r871x_mp_ioctl_hdl_exit" to a direct return. I changed the earlier goto to a direct return as well for consistency and removed the "pparmbuf = NULL" initializer since it's no longer ne

Re: [PATCH] media: cxd2099: move pre-init values out of init()

2015-04-08 Thread Mauro Carvalho Chehab
Em Sun, 8 Feb 2015 20:55:36 + luisbg escreveu: > Improve code readability by moving out all pre-init values from the init > function. > > Signed-off-by: Luis de Bethencourt > --- > drivers/staging/media/cxd2099/cxd2099.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff

Re: [PATCH] sdhci: rtsx: fix 64 BIT DMA quirks

2015-04-08 Thread Ulf Hansson
On 7 April 2015 at 05:32, wrote: > From: Micky Ching > > rts5250 chip failed handle 64 bit ADMA for address below 4G. > Add 64 BIT quirks to disable this feature. > > Signed-off-by: Micky Ching Thanks! Applied, with a minor updated commit message header. Kind regards Uffe > --- > drivers/mm