Removes extra parentheses around bitwise right shift operation.
The issue was detected using the following coccinelle script.
@@
expression e, e1;
constant c;
@@
e =
-(e1
+e1
<<
-c);
+c;
@@
identifier i;
constant c;
type t;
expression e;
@@
t i =
-(e
+e
<<
-c);
+c;
@@
expression e, e1;
identif
This is a patch to visorchannel/visorchannel_funcs.c that fixes a couple
of brace warnings found by checkpatch.pl.
Signed-off-by: Andreas Theodosiou
---
drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/stag
>From 0c77a8e926fecab029c88b0581ed3d6e55887066 Mon Sep 17 00:00:00 2001
From: Amaury Bouchra Pilet >
To: Greg Kroah-Hartman
Cc: de...@driverdev.osuosl.org
Date: Sat, 4 Apr 2015 21:34:38 +0200
Subject: [PATCH] staging: lustre: orthography & coding style
Orthography and coding style corrections.
S
We have RED always enabled, so eliminate the #define.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-defines.h | 2 --
drivers/staging/octeon/ethernet.c | 5 +
2 files changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-defines.h
b
Code for gmx0 and gmx1 block is identical, move it into a function.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-rgmii.c | 123 +++-
1 file changed, 41 insertions(+), 82 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-rgmii.c
b/drivers/
Make link poll generic to avoid copy paste.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-sgmii.c | 24 +---
drivers/staging/octeon/ethernet-xaui.c | 26 ++
drivers/staging/octeon/ethernet.c| 21 +
driv
This driver has drifted away from out-of-tree versions years ago
and the version string does not provide any useful information.
Instead provide the kernel version string to ethtool, so that we get
useful version information e.g. for bug reports.
Signed-off-by: Aaro Koskinen
---
drivers/staging/
Update boilerplate comments to be more terse by removing
redundant information.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-defines.h | 23 +++
drivers/staging/octeon/ethernet-mdio.c| 24
drivers/staging/octeon/ethernet-mdio.h
We have the workaround always enabled, so eliminate a redundant #define.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-defines.h | 5 -
drivers/staging/octeon/ethernet-rgmii.c | 14 +++---
drivers/staging/octeon/ethernet-rx.c | 7 ++-
3 files changed,
We always try to use skbuffs for packet buffers, so eliminate
a redundant define.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-defines.h | 5 -
drivers/staging/octeon/ethernet-mem.c | 4 ++--
drivers/staging/octeon/ethernet-rx.c | 4 ++--
3 files changed, 4 inser
Always use cvm_oct_note_carrier() to avoid copy-pasted code.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-mdio.c | 5 ++---
drivers/staging/octeon/ethernet-rgmii.c | 19 +++
drivers/staging/octeon/ethernet-sgmii.c | 20 +++-
drivers/stagin
Code for spx1 and spx0 block are identical, move it into a function.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-spi.c | 77 ++-
1 file changed, 30 insertions(+), 47 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-spi.c
b/drivers/s
HW checksum is always enabled, so delete a redundant define.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-defines.h | 6 --
drivers/staging/octeon/ethernet-tx.c | 2 +-
drivers/staging/octeon/ethernet.c | 7 ++-
3 files changed, 3 insertions(+), 12 deleti
Delete references to CONFIG_CAVIUM_RESERVE32. Kernel does not have such
option and the driver does not use it for anything.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-defines.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-de
Use a function to enable/disable HW preamble checking to avoid copy paste.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-rgmii.c | 84 ++---
1 file changed, 35 insertions(+), 49 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-rgmii.c
b/d
Add queue information to carrier note.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-mdio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-mdio.c
b/drivers/staging/octeon/ethernet-mdio.c
index ec38cb0..604fb58 100644
--
This feature is not used so eliminate it.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-defines.h | 8
drivers/staging/octeon/ethernet-mem.c | 2 +-
drivers/staging/octeon/ethernet-rx.c | 3 +--
drivers/staging/octeon/ethernet-tx.c | 2 +-
drivers/stagin
Move interrupt printouts into a common function to avoid copy paste.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-spi.c | 68 ---
1 file changed, 30 insertions(+), 38 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-spi.c
b/drivers/s
Move interrupt printouts into a common function to avoid copy paste.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-spi.c | 80 +++
1 file changed, 34 insertions(+), 46 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-spi.c
b/drivers/s
All ndo_stop functions are identical. Get rid of duplicated code.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-mdio.c | 9 -
drivers/staging/octeon/ethernet-rgmii.c | 13 -
drivers/staging/octeon/ethernet-sgmii.c | 13 -
drivers/staging/oc
Delete redundant wrappers.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-sgmii.c | 5 -
drivers/staging/octeon/ethernet-xaui.c | 5 -
drivers/staging/octeon/ethernet.c| 4 ++--
drivers/staging/octeon/octeon-ethernet.h | 2 --
4 files changed, 2 insertions(+)
ndo_open for rgmii, sgmii and xaui are almost identical. Put the common
code in a single function.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-rgmii.c | 32 +-
drivers/staging/octeon/ethernet-sgmii.c | 33 +--
drivers/staging
All init functions call ndo_stop if it's defined, so move it
to common function.
Signed-off-by: Aaro Koskinen
---
drivers/staging/octeon/ethernet-rgmii.c | 1 -
drivers/staging/octeon/ethernet-sgmii.c | 1 -
drivers/staging/octeon/ethernet-xaui.c | 1 -
drivers/staging/octeon/ethernet.c |
Hi,
Some cleanups for octeon-ethernet, mainly deleting lots of duplicated
copy-paste code.
Tested with EdgeRouter Lite (RGMII) and EdgeRouter Pro (SGMII), the basic
networking functionality works as before.
A.
Aaro Koskinen (20):
staging: octeon-ethernet: consolidate ndo_open functions
stag
On Sat, 4 Apr 2015, Nickolaus Woodruff wrote:
> This patch fixes the following sparse warning in sm7xx.h:
>
> drivers/staging/sm7xxfb/sm7xx.h:122:17: warning: symbol 'vgamode'
> was not declared. Should it be static?
>
> Signed-off-by: Nickolaus Woodruff
> ---
> drivers/staging/sm7xxfb/sm7xx.h
This patch fixes the following sparse warning in sm7xx.h:
drivers/staging/sm7xxfb/sm7xx.h:122:17: warning: symbol 'vgamode'
was not declared. Should it be static?
Signed-off-by: Nickolaus Woodruff
---
drivers/staging/sm7xxfb/sm7xx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
On Sat, Apr 04, 2015 at 07:21:51PM +0200, Julia Lawall wrote:
>
> OK. Should I update the patch to remove the test?
>
I thought Greg already applied it. If you want to send a new patch on
top which removes it that's fine. Either way someone will eventually.
:)
regards,
dan carpenter
___
On Sat, 4 Apr 2015, Dan Carpenter wrote:
> On Sat, Apr 04, 2015 at 06:20:53PM +0200, Julia Lawall wrote:
> > Couldn't one say:
> >
> > x = NULL;
> > y = &x->whatever;
> > z = container_of(y, struct blah, whatever);
> >
> > and end up with z being NULL?
>
> That is crazy person code. It looks
On Sat, Apr 04, 2015 at 06:20:53PM +0200, Julia Lawall wrote:
> Couldn't one say:
>
> x = NULL;
> y = &x->whatever;
> z = container_of(y, struct blah, whatever);
>
> and end up with z being NULL?
That is crazy person code. It looks deliberately wrong. If we start
merging deliberate mistakes th
On Sat, Apr 04, 2015 at 06:20:53PM +0200, Julia Lawall wrote:
>
>
> On Sat, 4 Apr 2015, Greg Kroah-Hartman wrote:
>
> > On Sat, Apr 04, 2015 at 04:59:30PM +0200, Julia Lawall wrote:
> > > Put NULL test on the result of the previous call instead on one of its
> > > arguments. A simplified versio
On Sat, 4 Apr 2015, Greg Kroah-Hartman wrote:
> On Sat, Apr 04, 2015 at 04:59:30PM +0200, Julia Lawall wrote:
> > Put NULL test on the result of the previous call instead on one of its
> > arguments. A simplified version of the semantic match that finds this
> > problem is as follows (http://co
On Sat, Apr 04, 2015 at 06:59:58PM +0300, Dan Carpenter wrote:
> This is a clever Coccinelle check. :)
>
> On Sat, Apr 04, 2015 at 04:59:30PM +0200, Julia Lawall wrote:
> > Put NULL test on the result of the previous call instead on one of its
> > arguments. A simplified version of the semantic
On Sat, Apr 04, 2015 at 04:59:30PM +0200, Julia Lawall wrote:
> Put NULL test on the result of the previous call instead on one of its
> arguments. A simplified version of the semantic match that finds this
> problem is as follows (http://coccinelle.lip6.fr/):
>
> //
> r@
> expression *e1;
> exp
This is a clever Coccinelle check. :)
On Sat, Apr 04, 2015 at 04:59:30PM +0200, Julia Lawall wrote:
> Put NULL test on the result of the previous call instead on one of its
> arguments. A simplified version of the semantic match that finds this
> problem is as follows (http://coccinelle.lip6.fr/
On Sat, 2015-04-04 at 16:58 +0300, Dan Carpenter wrote:
> On Sat, Apr 04, 2015 at 12:04:59AM +0300, Dan Carpenter wrote:
> > 1) It's more clear when read in English. "if not strcmp then" or
> > "if strcmp NOT EQUAL zero".
> Oops. I got that reversed. I meant "if strcmp then". Only serves to
>
Put NULL test on the result of the previous call instead on one of its
arguments. The complete semantic match that finds these problems is as
follows (http://coccinelle.lip6.fr/):
//
@r@
expression *e1;
expression *e2;
identifier f;
statement S1,S2;
position p,p2;
@@
e1 = f@p(...,e2,...);
(
if
Put NULL test on the result of the previous call instead on one of its
arguments. A simplified version of the semantic match that finds this
problem is as follows (http://coccinelle.lip6.fr/):
//
r@
expression *e1;
expression *e2;
identifier f;
statement S1,S2;
@@
e1 = f(...,e2,...);
(
if (e1 =
On Sat, Apr 04, 2015 at 12:04:59AM +0300, Dan Carpenter wrote:
> 1) It's more clear when read in English. "if not strcmp then" or
> "if strcmp NOT EQUAL zero".
Oops. I got that reversed. I meant "if strcmp then". Only serves to
emphasize my point though. :)
regards,
dan carpenter
Hi Geert,
Thank you for the patch.
On Friday 03 April 2015 14:42:02 Geert Uytterhoeven wrote:
> Add support for easy registering of one ore more platform devices that
> may:
> - need clocks that are described in DT,
> - need pin control configuration,
> - rely on a configured GPIO,
> - be
The following changes since commit bc465aa9d045feb0e13b4a8f32cc33c1943f62d6:
Linux 4.0-rc5 (2015-03-22 16:50:21 -0700)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-4.0-rc6
for you to fetch changes up to dce5bdfe8fc1e
Dear BMW Enthusiast
This is to inform you that you have been selected for a prize of a brand new
2014 Model BMW 7 Series Car and a Check of $800,000.00 United States Dollars
from international programs held at the 1st section of 2015, here in the UNITED
STATES OF AMERICA.
The selection process
Hope you are doing good today!
We are email marketing specialist.
We can increase your client base and bring the buying leads to you!
We can increase your business sales 2-4 times than now.
Pls contact for pricing and proposal in details.
Thanks,
Louis
Technical Director
Contact: cary...@aliyun.
42 matches
Mail list logo
