Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

On Sun, Mar 29, 2015 at 12:54:45AM +0100, Richard Weinberger wrote: > Am 29.03.2015 um 00:44 schrieb Shirish Gajera: > > On Sat, Mar 28, 2015 at 02:35:19PM -0700, Joe Perches wrote: > >> On Sat, 2015-03-28 at 22:22 +0100, Richard Weinberger wrote: > >>> Am 28.03.2015 um 22:18 schrieb Joe Perches: >

Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

Am 29.03.2015 um 00:44 schrieb Shirish Gajera: > On Sat, Mar 28, 2015 at 02:35:19PM -0700, Joe Perches wrote: >> On Sat, 2015-03-28 at 22:22 +0100, Richard Weinberger wrote: >>> Am 28.03.2015 um 22:18 schrieb Joe Perches: On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote: > On Sa

Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

On Sat, Mar 28, 2015 at 02:35:19PM -0700, Joe Perches wrote: > On Sat, 2015-03-28 at 22:22 +0100, Richard Weinberger wrote: > > Am 28.03.2015 um 22:18 schrieb Joe Perches: > > > On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote: > > >> On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera > >

Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

On Sat, 2015-03-28 at 22:22 +0100, Richard Weinberger wrote: > Am 28.03.2015 um 22:18 schrieb Joe Perches: > > On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote: > >> On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera > >> wrote: > >>> This patch fixes the checkpatch.pl warning: [] > >> In

Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

Am 28.03.2015 um 22:18 schrieb Joe Perches: > On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote: >> On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera >> wrote: >>> This patch fixes the checkpatch.pl warning: > > [] > >>> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/spea

Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

On Sat, 2015-03-28 at 21:40 +0100, Richard Weinberger wrote: > On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera > wrote: > > This patch fixes the checkpatch.pl warning: [] > > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c [] > > @@ -423,7 +423,8 @@ static void anno

Re: [PATCH] staging: speakup: Fix warning of line over 80 characters.

On Sat, Mar 28, 2015 at 9:21 PM, Shirish Gajera wrote: > This patch fixes the checkpatch.pl warning: > WARNING: line over 80 characters > > All line over 80 characters in driver/staging/speakup/* are fixed. > > Signed-off-by: Shirish Gajera > --- > drivers/staging/speakup/main.c | 9 ++

[PATCH] staging: speakup: Fix warning of line over 80 characters.

This patch fixes the checkpatch.pl warning: WARNING: line over 80 characters All line over 80 characters in driver/staging/speakup/* are fixed. Signed-off-by: Shirish Gajera --- drivers/staging/speakup/main.c | 9 ++--- drivers/staging/speakup/serialio.h | 3 ++- drivers/sta

[PATCH] staging: octeon-ethernet: delete cvm_oct_set_carrier()

Delete unused function cvm_oct_set_carrier(). Signed-off-by: Aaro Koskinen --- drivers/staging/octeon/ethernet-mdio.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/staging/octeon/ethernet-mdio.c b/drivers/staging/octeon/ethernet-mdio.c index ebfa9c9..40dab11 100644 -

[PATCH 1/4] staging: octeon-usb: make cvmx_fifo_setup void

Make cvmx_fifo_setup void, it does not return any value. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index feaaafc..

[PATCH 4/4] staging: octeon-usb: make CVMX_WAIT_FOR_FIELD32 to take condition expression

Make CVMX_WAIT_FOR_FIELD32 to take full condition expression. This should make the usage simpler, and the macro more readable. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/staging/

[PATCH 3/4] staging: octeon-usb: assume union type for FIELD32 macros

Assume union type for FIELD32 macros to simplify usage. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 79 +++-- 1 file changed, 36 insertions(+), 43 deletions(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octe

[PATCH 2/4] staging: octeon-usb: octeon_usb_probe: delete unused variable

"flags" is not used, delete it. Signed-off-by: Aaro Koskinen --- drivers/staging/octeon-usb/octeon-hcd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/octeon-usb/octeon-hcd.c b/drivers/staging/octeon-usb/octeon-hcd.c index ca8be66..7312597 100644 --- a/drivers/staging/octeo

[PATCH 2/2] staging: sm7xxfb: disable pci device

disable the pci device when the module exits. Signed-off-by: Sudip Mukherjee --- drivers/staging/sm7xxfb/sm7xxfb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c b/drivers/staging/sm7xxfb/sm7xxfb.c index 149286e..77f51a0 100644 --- a/drivers/staging/sm7xxf

[PATCH 1/2] staging: sm7xxfb: reserve PCI resource

before starting to access any address inside the PCI region we should reserve the resource and release the resource when the module exits. Signed-off-by: Sudip Mukherjee --- drivers/staging/sm7xxfb/sm7xxfb.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/staging/sm7xxfb/

Re: [PATCH] drivers: staging: speakup: fix sparse "warning: expression using sizeof bool"

On Sat, Mar 28, 2015 at 11:56:40AM +0530, Sudip Mukherjee wrote: > On Fri, Mar 27, 2015 at 09:36:07PM +0100, Witos wrote: > > Changed bool to u8 to get rid of sparse warning. > but i am not getting this warning. which version of sparse are you > using? sparse 0.5.0, see: http://yarchive.net/comp/l