[PATCH] staging: fbtft: Fix typo in fbtft

2015-03-20 Thread Masanari Iida
This patch fix spelling typo in comment and printk within fbtft Signed-off-by: Masanari Iida --- drivers/staging/fbtft/fb_agm1264k-fl.c | 6 +++--- drivers/staging/fbtft/fb_hx8340bn.c| 2 +- drivers/staging/fbtft/fb_hx8353d.c | 2 +- drivers/staging/fbtft/fb_ili9340.c | 2 +- drivers

[PATCH] staging: ozwpan: implement error handling in ozwpan_init()

2015-03-20 Thread Alexey Khoroshilov
Errors are correctly handled in oz_cdev_register() and oz_protocol_init(), but then they are ignored in ozwpan_init(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/staging/ozwpan/ozmain.c | 14 -- 1 file changed, 12 ins

[PATCH] Staging: rtl8188eu: remove dead code

2015-03-20 Thread Matteo Semenzato
From: Matteo Semenzato The condition pxmitpriv->hwxmit_entry == 5 is always false because HWXMIT_ENTRY is always 4. Signed-off-by: Matteo Semenzato --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/stagi

Re: [PATCH] Staging: rtl8188eu fix buffer overflow

2015-03-20 Thread Dan Carpenter
On Fri, Mar 20, 2015 at 03:21:40PM +0100, Matteo Semenzato wrote: > From: Matteo Semenzato > > This patch fixes the buffer overflow caused by accessing index 4 of hwxmits. > This is a Smatch warning? It's a false positive because the code that accesses hwxmits[4] is dead code. Just delete it

[PATCH] sm750fb: Fix indentation, spacing and switch-case

2015-03-20 Thread Amitoj Kaur Chawla
Fix the spacing problems with correct indentation and correct use of braces and spacing in switch-case statements. Signed-off-by: Amitoj Kaur Chawla --- drivers/staging/sm750fb/ddk750_chip.c | 63 +-- 1 file changed, 31 insertions(+), 32 deletions(-) diff --git a

[PATCH RESEND 1/2] Staging: fbtft: fb_pcd8544: Fix warning line over 80 characters

2015-03-20 Thread Cláudio Maia
This patch fixes the following checkpatch warning: WARNING: line over 80 characters Signed-off-by: Cláudio Maia --- drivers/staging/fbtft/fb_pcd8544.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/fbtft/fb_pcd8544.c b/drivers/staging/fbtft/fb_pcd8544.

[PATCH RESEND 2/2] Staging: fbtft: fb_pcd8544: Fix comments style

2015-03-20 Thread Cláudio Maia
This patch fixes the following errors by refactoring the comments' style: WARNING: line over 80 characters ERROR: code indent should use tabs where possible Signed-off-by: Cláudio Maia --- drivers/staging/fbtft/fb_pcd8544.c | 107 1 file changed, 59 inserti

[PATCH] staging: fbtft: Add support for ili9163 controller

2015-03-20 Thread Kozhevnikov Anatoly
Driver for ili9163-based displays (for example: Nokia 5110) Signed-off-by: Kozhevnikov Anatoly --- drivers/staging/fbtft/Kconfig| 6 + drivers/staging/fbtft/Makefile | 1 + drivers/staging/fbtft/fb_ili9163.c | 303 +++ drivers/staging/fbtft/fbt

[PATCH RESEND 2 1/5] staging: sm750fb: Use memset_io instead of memset

2015-03-20 Thread Lorenzo Stoakes
This patch takes into account that cursor->vstart, crtc->vScreen and share->pvMem are pointers to memory-mapped I/O and thus we should use memset_io to make this explicit. In addition, some architectures require special treatment of memory-mapped I/O so the previous code could actually break withou

[PATCH RESEND 2 3/5] staging: sm750fb: Remove unused function

2015-03-20 Thread Lorenzo Stoakes
This patch removes the unused hw712_fillrect function. This patch fixes the following sparse warning:- drivers/staging/sm750fb/sm750_accel.c:95:5: warning: symbol 'hw712_fillrect' was not declared. Should it be static? Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/sm750_accel.c |

[PATCH RESEND 2 4/5] staging: sm750fb: Fix __iomem pointer types

2015-03-20 Thread Lorenzo Stoakes
This patch annotates pointers as referring to I/O mapped memory where they ought to be, removes now unnecessary ugly casts, eliminates an incorrect deref on I/O mapped memory by using iowrite16 instead, and updates the pointer arithmetic accordingly to take into account that the pointers are now by

Re: [PATCH RESEND v2 4/5] staging: sm750fb: Fix __iomem pointer types

2015-03-20 Thread Lorenzo Stoakes
On 20 March 2015 at 13:03, Greg KH wrote: > I only see 2 patches in this "series", yet you refer to 5? Please > resend the whole series, I dropped your previous ones from my queue. > > thanks, > > greg k-h I have resent all the patches as RESEND 2 as well as updating them to apply against stagin

[PATCH RESEND 2 5/5] staging: sm750fb: Remove spinlock helper function

2015-03-20 Thread Lorenzo Stoakes
This patch removes the unnecessary spinlock helper function and instead calls spin_lock and spin_unlock directly. This does *not* resolve sparse warnings about context imbalances but these are spurious. Signed-off-by: Lorenzo Stoakes --- drivers/staging/sm750fb/sm750.c | 53

[PATCH RESEND 2 2/5] staging: sm750fb: Make internal functions static

2015-03-20 Thread Lorenzo Stoakes
This patch declares externally unavailable functions static. This fixes the following sparse warnings:- drivers/staging/sm750fb/ddk750_hwi2c.c:63:6: warning: symbol 'hwI2CWaitTXDone' was not declared. Should it be static? drivers/staging/sm750fb/ddk750_hwi2c.c:93:14: warning: symbol 'hwI2CWriteDa

[PATCH] staging: fbtft: Do not use binary constants

2015-03-20 Thread Geert Uytterhoeven
tant drivers/staging/fbtft/fb_hx8340bn.c:160:3: error: invalid suffix "b111" on integer constant ... Hence use hexadecimal constants (0x*) instead. Signed-off-by: Geert Uytterhoeven --- Against next-20150320 drivers/staging/fbtft/fb_hx8340bn.c | 8 drivers/staging/fbtft/fb_

Re: [PATCH] staging: fbtft: Do not use binary constants

2015-03-20 Thread Geert Uytterhoeven
Hi Greg, On Fri, Mar 20, 2015 at 1:54 PM, Greg Kroah-Hartman wrote: > On Tue, Mar 10, 2015 at 10:34:43PM +0100, Geert Uytterhoeven wrote: >> Gcc < 4.3 doesn't understand binary constants (0b*): >> >> drivers/staging/fbtft/fbtft-sysfs.c:156:19: error: invalid suffix "b111" on >> integer constant

Re: [PATCH RESEND v2 4/5] staging: sm750fb: Fix __iomem pointer types

2015-03-20 Thread Greg KH
On Wed, Mar 18, 2015 at 07:04:53PM +, Lorenzo Stoakes wrote: > This patch annotates pointers as referring to I/O mapped memory where they > ought > to be, removes now unnecessary ugly casts, eliminates an incorrect deref on > I/O > mapped memory by using iowrite16 instead, and updates the poi

Re: [PATCH] staging: fbtft: Use strcmp instead of strncmp

2015-03-20 Thread Greg Kroah-Hartman
On Wed, Mar 18, 2015 at 05:29:26PM +, Ravindran, Madhusudhanan (M.) wrote: > Since both buffers are null terminated, strncmp > is not needed. How do you know this? How do you ensure it is true? And you shouldn't be relying on a module parameter for anything, please fix the driver to do thing

Re: [PATCH] sm750fb: Fix Comment and if else braces

2015-03-20 Thread Greg KH
On Thu, Mar 19, 2015 at 08:13:20PM +0200, Giedrius Statkevičius wrote: > Hi Amitoj Kaur Chawla, > > On 2015.03.19 20:05, Amitoj Kaur Chawla wrote: > > The edits have been made to add a space before the comment and the errors in > > braces in the if-else statements. > > Previously in commit 2d34f53

Re: [PATCH] staging: fbtft: Do not use binary constants

2015-03-20 Thread Greg Kroah-Hartman
On Tue, Mar 10, 2015 at 10:34:43PM +0100, Geert Uytterhoeven wrote: > Gcc < 4.3 doesn't understand binary constants (0b*): > > drivers/staging/fbtft/fbtft-sysfs.c:156:19: error: invalid suffix "b111" on > integer constant > drivers/staging/fbtft/fb_hx8340bn.c:159:3: error: invalid suffix "b"

Re: [PATCH] staging: sm750fb: Fixed no space warnings

2015-03-20 Thread Greg KH
On Fri, Mar 13, 2015 at 08:48:21PM -0700, Ragavendra Nagraj wrote: > This patch fixes the no spaces warning identified by the checkpath.pl > script for the entire ddk750_chip.c file by using appropriate tab spaces > instead. > > Signed-off-by: Ragavendra Nagraj > --- > drivers/staging/sm750fb/dd

Re: [PATCH 3/3] Hal8188ERateAdaptive.c : Expression is always false because 'else if' condition matches previous condition at line 404.

2015-03-20 Thread Greg KH
On Wed, Feb 25, 2015 at 06:34:18PM +0200, Ameen Ali wrote: > else if at line 406 has the same condition as the else if at line 404. > i chosed 0x5 because it's half 0xb (just a rate controller) > Signed-off-by : Ameen Ali > --- > drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 2 +- > 1 f

Re: [PATCH RESEND 2/2] Staging: fbtft: fb_pcd8544: Fixed coding style errors and warnings

2015-03-20 Thread Greg KH
On Sat, Mar 07, 2015 at 05:15:35PM +, Cláudio Maia wrote: > This patch fixes the following errors by refactoring the comments' > style: > > WARNING: line over 80 characters > ERROR: code indent should use tabs where possible > > Signed-off-by: Cláudio Maia > --- > drivers/staging/fbtft/fb_p

Re: [PATCH] staging: rtl8192u: fix sparse warnings for static declaration

2015-03-20 Thread Greg KH
On Wed, Mar 18, 2015 at 10:25:29AM +, vibi sreenivasan wrote: > This patch fixes following sparse warning > drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:1924:6: warning: > symbol 'ieee80211_check_auth_response' was not declared. Should it be static? > > Signed-off-by: Vibi Sreenivas

[PATCH] sm750fb: Fix C99 comment and if-else braces

2015-03-20 Thread Amitoj Kaur Chawla
The edits have been made to fix C99 Comment and properly indent the if-else statements with the braces. Also, to use tabs instead of spaces. Signed-off-by: Amitoj Kaur Chawla --- drivers/staging/sm750fb/ddk750_chip.c | 35 ++- 1 file changed, 14 insertions(+), 21

[PATCH] Staging: rtl8188eu fix buffer overflow

2015-03-20 Thread Matteo Semenzato
From: Matteo Semenzato This patch fixes the buffer overflow caused by accessing index 4 of hwxmits. Signed-off-by: Matteo Semenzato --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/

RE: [PATCH V3 2/2 net-next] hyperv: Support batched notification

2015-03-20 Thread KY Srinivasan
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Thursday, March 19, 2015 10:58 PM > To: KY Srinivasan > Cc: da...@davemloft.net; net...@vger.kernel.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com > Subje

Re: [PATCH v2] staging: vt6655: remove deprecated use of pci api

2015-03-20 Thread Dan Carpenter
Use the --in-reply-to option. There were no responses to the first version of this email so Greg is going to apply that one. (I guess it's still possible that someone will reply to it now, I suppose). > --- > Changes since v1: >- Replaces GFP_ATOMIC by GFP_KERNEL since no lock is taken befo

[PATCH v2] staging: vt6655: remove deprecated use of pci api

2015-03-20 Thread Quentin Lambert
Replace occurences of the pci api by appropriate call to the dma api. A simplified version of the semantic patch that finds this problem is as follows: (http://coccinelle.lip6.fr) @deprecated@ idexpression id; position p; @@ ( pci_dma_supported@p ( id, ...) | pci_alloc_consistent@p ( id, ...