re

2015-03-15 Thread MARIA MORETTI
Hello, I have a letter for you. Kindly get back to me. Best Regards. Maria Moretti. For: Jack Brown. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH v4 3/5] staging: rtl8192e: fix coding style errors (macros in parentheses)

2015-03-15 Thread Joe Perches
On Sun, 2015-03-15 at 21:39 +0100, Mateusz Kulikowski wrote: > Fix checkpatch.pl errors 'Macros with complex values should be enclosed in > parentheses'. [] > diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h > b/drivers/staging/rtl8192e/rtl819x_HT.h [] > @@ -78,7 +78,7 @@ enum chnl_op { > }; >

[PATCH 1/1] X86: hyperv: Enable MSR based APIC access

2015-03-15 Thread K. Y. Srinivasan
If the hypervisor supports MSR based access to the APIC registers (EOI, TPR and ICR), implement the MSR based access. Signed-off-by: K. Y. Srinivasan --- arch/x86/include/uapi/asm/hyperv.h |5 +++ arch/x86/kernel/cpu/mshyperv.c | 69 2 files changed

[PATCH] staging: lustre: echo_client: Use kernel style spacing

2015-03-15 Thread Yogeswaran Thulasidoss
This patch fixes the code style space issues identified by checkpatch.pl in drivers/staging/lustre/lustre/obdecho/echo_client.c Signed-off-by: Yogeswaran Thulasidoss --- .../staging/lustre/lustre/obdecho/echo_client.c| 32 +++--- 1 file changed, 16 insertions(+), 16 deletion

Re: [PATCH] code style fix - fixed all spacing issues

2015-03-15 Thread Joe Perches
On Mon, 2015-03-16 at 05:47 +0530, Yogeswaran Thulasidoss wrote: > --- 3 things: o You need to use a better subject line try something like: [PATCH] staging: lustre: echo_client: Use kernel style spacing o There should be some sort of commit message o You didn't add your "Signed-off-by:

[PATCH] staging:sm750fb:Fixed no space and indent warnings

2015-03-15 Thread Ragavendra Nagraj
This patch fixes the no spaces and indent warnings identified by the checkpath.pl script for the entire ddk750_chip.c file by using appropriate tab spaces and indents accordingly. Signed-off-by: Ragavendra Nagraj --- drivers/staging/sm750fb/ddk750_chip.c | 454 -

[PATCH] code style fix - fixed all spacing issues

2015-03-15 Thread Yogeswaran Thulasidoss
--- .../staging/lustre/lustre/obdecho/echo_client.c| 32 +++--- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdecho/echo_client.c b/drivers/staging/lustre/lustre/obdecho/echo_client.c index 566e646..d542e06 100644 --- a/drivers

[PATCH v4 1/5] staging: rtl8192e: fix coding style issues (merge broken strings)

2015-03-15 Thread Mateusz Kulikowski
Fix checkpatch.pl warnings: - 'WARNING: quoted string split across lines' - 'WARNING: break quoted strings at a space character' Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8190P_rtl8256.c | 51 +++--- drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 28 +-- dr

[PATCH v4 3/5] staging: rtl8192e: fix coding style errors (macros in parentheses)

2015-03-15 Thread Mateusz Kulikowski
Fix checkpatch.pl errors 'Macros with complex values should be enclosed in parentheses'. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl819x_HT.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HT.h b/drivers/staging

[PATCH v4 4/5] staging: rtl8192e: rtllib_wx: remove duplicate messages

2015-03-15 Thread Mateusz Kulikowski
Some messages were reported with netdev_* macros and internal driver-specific macro. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtllib_wx.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_wx.c b/drivers/staging/rtl8192e/rtllib_wx.c ind

[PATCH v4 5/5] staging: rtl8192e: fix coding style warnings (printk -> netdev_*)

2015-03-15 Thread Mateusz Kulikowski
Use netdev_*, dev_* or pr_* instead of printk where possible. KERN_DEBUG messages are left intact as pr_dbg has different behaviour. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 4 +- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 53 +- dri

[PATCH v4 2/5] staging: rtl8192e: fix coding style issues (spaces before semicolon)

2015-03-15 Thread Mateusz Kulikowski
Fix checkpatch.pl warning 'space prohibited before semicolon'. Signed-off-by: Mateusz Kulikowski --- drivers/staging/rtl8192e/rtl8192e/r8192E_cmdpkt.c | 2 +- drivers/staging/rtl8192e/rtl8192e/r8192E_firmware.c | 2 +- drivers/staging/rtl8192e/rtl8192e/r8192E_hwimg.h| 14 +++---

[PATCH v4 0/5] staging: rtl8192e: fix coding style issues

2015-03-15 Thread Mateusz Kulikowski
Various coding style fixes for rtl8192e driver. This series of patches includes v3, was applied on staging-next branch Duplicate patches from v3 were removed. checkpatch.pl still complains about some of patches - this will be fixed in future (warnings were mostly already there): 1/5: - usage of

[PATCH] staging: unisys: print MAC address via %pM

2015-03-15 Thread Andy Shevchenko
This patch converts code to use %pM specifier instead of placing each byte on stack. Signed-off-by: Andy Shevchenko --- drivers/staging/unisys/virtpci/virtpci.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/unisys/virtpci/virtpci.c b/drivers/stagin

[PATCH] staging: unisys: print MAC address via %pM

2015-03-15 Thread Andy Shevchenko
This patch converts code to use %pM specifier instead of placing each byte on stack. Signed-off-by: Andy Shevchenko --- drivers/staging/unisys/virtpci/virtpci.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/unisys/virtpci/virtpci.c b/drivers/stagin

Re: [PATCH] code style fix - removed space between function name and open paranthesis

2015-03-15 Thread Joe Perches
On Sun, 2015-03-15 at 23:10 +0530, Yogeswaran Thulasidoss wrote: If you are going to fix whitespace, please fix all whitespace issues on the same line. > diff --git a/drivers/staging/lustre/lustre/obdecho/echo_client.c > b/drivers/staging/lustre/lustre/obdecho/echo_client.c [] > @@ -1274,11 +127

[PATCH] code style fix - removed space between function name and open paranthesis

2015-03-15 Thread Yogeswaran Thulasidoss
--- .../staging/lustre/lustre/obdecho/echo_client.c| 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/drivers/staging/lustre/lustre/obdecho/echo_client.c b/drivers/staging/lustre/lustre/obdecho/echo_client.c index 566e646..8c4c92e 100644 --- a/drivers

Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

2015-03-15 Thread Greg KH
On Sun, Mar 15, 2015 at 08:07:09AM -0400, Mark Hounschell wrote: > >>Greg, while I'm here, how can we get Digi firmware into the kernel firmware > >>tree? The dgap card is useless without it and I suspect the dgnc is as well. > > > >Submit a patch to the linux-firmware git tree with the firmware in

Re: [PATCH v2] dgnc: Don't save boards in memory that have failed to initialize

2015-03-15 Thread Mark Hounschell
On 03/14/2015 04:44 AM, Greg KH wrote: On Fri, Mar 13, 2015 at 04:55:55PM -0400, Mark Hounschell wrote: On 03/12/2015 12:14 PM, Giedrius Statkevičius wrote: On 2015.03.12 12:08, Greg KH wrote: On Mon, Mar 09, 2015 at 06:29:38PM +0200, Giedrius Statkevičius wrote: Remove BOARD_FAILED and don't

Re: [PATCH] staging:sm750fb:Fixed no space and indent warnings

2015-03-15 Thread Sudip Mukherjee
On Sun, Mar 15, 2015 at 01:24:24AM -0700, Ragavendra wrote: > ohh ok, is that the only fix that needs to be added. I don't mind fixing > that and sending if required. > > Anyway that brace needs to be on the same line as per the coding standards > otherwise we get "ERROR: that open brace { should

Re: [PATCH] NULL check before calling kfree() is not needed.

2015-03-15 Thread Greg KH
On Sun, Mar 15, 2015 at 02:12:28PM +0530, Aananth Chellapa Natarajan wrote: > This patch eliminates a redundant check of argument before calling > kfree() and therefore reducing kernel image size. > > Signed-off-by: Aananth Chellapa Natarajan > --- > drivers/block/skd_main.c | 3 +-- > 1 file ch

Re: [PATCH] Staging: fbtft: Fixed a coding style issue

2015-03-15 Thread Greg KH
On Sat, Mar 14, 2015 at 01:30:03AM +, Derek Robson wrote: > Fixed coding style issue, found by checkpatch What coding style issue did you fix? You need to be specific here please. thanks, greg k-h ___ devel mailing list de...@linuxdriverproject.or

[PATCH v4] staging: panel: change struct bits to a bit array

2015-03-15 Thread Isaac Lleida
This path implements a bit array representing the LCD signal states instead of the old "struct bits", which used char to represent a single bit. This will reduce the memory usage. Signed-off-by: Isaac Lleida --- v4: fixed a bug in BIT_CHK() drivers/staging/panel/panel.c | 86 +

[PATCH] NULL check before calling kfree() is not needed.

2015-03-15 Thread Aananth Chellapa Natarajan
This patch eliminates a redundant check of argument before calling kfree() and therefore reducing kernel image size. Signed-off-by: Aananth Chellapa Natarajan --- drivers/block/skd_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/skd_main.c b/drivers/blo

Re: [PATCH] staging:sm750fb:Fixed no space and indent warnings

2015-03-15 Thread Sudip Mukherjee
On Sat, Mar 14, 2015 at 02:30:51PM -0700, Ragavendra Nagraj wrote: > This patch fixes the no spaces and indent warnings identified by the > checkpath.pl > script for the entire ddk750_chip.c file by using appropriate tab spaces > and indents accordingly. > > Signed-off-by: Ragavendra Nagraj > --

Re: [PATCH v3] staging: panel: change struct bits to a bit array

2015-03-15 Thread Willy Tarreau
Hello, On Sat, Mar 14, 2015 at 11:14:43AM +0100, Isaac Lleida wrote: > This path implements a bit array representing the LCD signal states instead > of the old "struct bits", which used char to represent a single bit. This > will reduce the memory usage. > > Signed-off-by: Isaac Lleida > --- >