> -Original Message-
> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On
> Behalf Of KY Srinivasan
> Sent: Wednesday, March 11, 2015 8:32 PM
> To: Jason Wang
> Cc: o...@aepfle.de; net...@vger.kernel.org; linux-ker...@vger.kernel.org;
> gre...@linuxfoundation.org; a...
Signed-off-by: J. German Rivera
---
drivers/staging/fsl-mc/TODO | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fsl-mc/TODO b/drivers/staging/fsl-mc/TODO
index 49ebfd9..d78288b 100644
--- a/drivers/staging/fsl-mc/TODO
+++ b/drivers/staging/fsl-mc/TODO
@@ -
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Wednesday, March 11, 2015 8:09 PM
> To: KY Srinivasan
> Cc: da...@davemloft.net; net...@vger.kernel.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
> a...@canonical.com; gre...
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Wednesday, March 11, 2015 8:08 PM
> To: KY Srinivasan
> Cc: da...@davemloft.net; net...@vger.kernel.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
> a...@canonical.com; gre...
On Thu, Mar 12, 2015 at 3:04 AM, K. Y. Srinivasan
wrote:
Optimize notifying the host by deferring notification until there
are no more packets to be sent. This will help in batching the
requests
on the host.
Signed-off-by: K. Y. Srinivasan
---
drivers/net/hyperv/hyperv_net.h |2 +-
On Thu, Mar 12, 2015 at 3:04 AM, K. Y. Srinivasan
wrote:
When the caller specifies that signalling should be deferred, we need
to
address the case where we are not able to place the current packet
because
the buffer is full. In this case, we will signal the host as some
packets
may have be
On Thu, Mar 12, 2015 at 3:04 AM, K. Y. Srinivasan
wrote:
Export the vmbus_sendpacket_pagebuffer_ctl() interface. This interface
will be used in the netvsc driver to optimize signalling the host.
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/channel.c |1 +
1 files changed, 1 insertion
When a channel has been rescinded, the close operation is a noop.
Restructure the code so we deal with the rescind condition after
we properly cleanup the channel. I would like to thank
Dexuan Cui for observing this problem.
The current code leaks memory when the channel is rescinded.
The current
From: Vitaly Kuznetsov
Memory blocks can be onlined in random order. When this order is not natural
some memory pages are not onlined because of the redundant check in
hv_online_page().
Here is a real world scenario:
1) Host tries to hot-add the following (process_hot_add):
pg_start=rg_start=0
From: Vitaly Kuznetsov
When add_memory() fails the following BUG is observed:
[ 743.646107] hv_balloon: hot_add memory failed error is -17
[ 743.679973]
[ 743.680930] =
[ 743.680930] [ BUG: bad unlock balance detected! ]
[ 743.680930] 3.19.0-rc5_bug1131426
From: Nick Meier
HV_CRASH_CTL_CRASH_NOTIFY is a 64 bit number. Depending on the usage context,
the value may be truncated. This patch is in response from the following
email from Intel:
[char-misc:char-misc-testing 25/45] drivers/hv/vmbus_drv.c:67:9: sparse:
constant 0x80
From: Dexuan Cui
Without this patch, hv_fcopy_daemon's hv_copy_data() -> pwrite()
will fail for >2GB file offset.
The current Linux 4.0 RC3 tree is broken and this patch fixes the problem.
Signed-off-by: Alex Ng
Signed-off-by: Dexuan Cui
Cc: K. Y. Srinivasan
Signed-off-by: K. Y. Srinivasan
This patch is a continuation of the rescind handling cleanup work. We cannot
block in the global message handling work context especially if we are blocking
waiting for the host to wake us up. I would like to thank
Dexuan Cui for observing this problem.
The current Linux 4.0 RC3 tree is broken an
Some miscellaneous fixes to the vmbus driver and the balloon driver.
Currently the Linux 4.0 RC3 tree is broken on Hyper-V and this patch-set
fixes the issues.
Dexuan Cui (1):
tools: hv: fcopy_daemon: support >2GB files for x86_32 guest
K. Y. Srinivasan (2):
Drivers: hv: vmbus: Perform device
Hi Daniele,
On 2015.03.12 00:05, Daniele Alessandrelli wrote:
> Fix all the trivial style issues (as reported by checkpatch.pl) not requiring
> code refactoring. A following patch is expected to fix the remaining issues by
> performing some code refactoring.
>
> Signed-off-by: Daniele Alessandrel
On 11.03.2015 08:53, Greg KH wrote:
> On Wed, Mar 11, 2015 at 08:46:00AM +0100, Mateusz Kulikowski wrote:
>> Code reformatting based on checkpatch.pl:
>> - Replaced min() with min_t()
>> - Replaced printk() with netdev_*()
>> - Merged broken string
>
> That's three different things, which means th
> -Original Message-
> From: K. Y. Srinivasan [mailto:k...@microsoft.com]
> Sent: Tuesday, March 10, 2015 5:07 PM
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> vkuzn...@redhat.com
> Cc: KY Srinivasan
>
Add new function ft1000_read_dsp_timer() replacing recurring code block for
reading DSP timer. Such code refactoring solves all remaining "line over 80
characters" warnings reported by checkpatch.pl.
Signed-off-by: Daniele Alessandrelli
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 199
Fix all the trivial style issues (as reported by checkpatch.pl) not requiring
code refactoring. A following patch is expected to fix the remaining issues by
performing some code refactoring.
Signed-off-by: Daniele Alessandrelli
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 199 +
This small patchset fixes all the style problems reported by checkpatch.pl on
ft1000-pcmcia/ft1000_hw.c
* Patch 1/2 fixes all trivial issues not requiring code refactoring
* Patch 2/2 fixes all remaining "line over 80 characters" warnings by means of
some code refactoring. Specifically, the fu
On Wed, 2015-03-11 at 14:03 -0700, Janakarajan Natarajan wrote:
> Addition of blank line after declaration in ft1000_hw.c
> Minor changes to remove {} from single line if and remove extra parenthesis.
> Fixes checkpatch warning for and usage.
Most prefer separate patches for each type of change,
On 2015.03.11 23:03, Janakarajan Natarajan wrote:
> Addition of blank line after declaration in ft1000_hw.c
> Minor changes to remove {} from single line if and remove extra parenthesis.
> Fixes checkpatch warning for and usage.
>
Greg may complain that you've done too much in 1 patch.
> Signed
Addition of blank line after declaration in ft1000_hw.c
Minor changes to remove {} from single line if and remove extra parenthesis.
Fixes checkpatch warning for and usage.
Signed-off-by: Janakarajan Natarajan
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 12 ++--
drivers/stag
Marcus Folkesson writes:
> This patch fixes the following sparse warnings:
>
> CHECK drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:265:37: warning:
> cast to restricted __le16
> drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:267:
Export the vmbus_sendpacket_pagebuffer_ctl() interface. This interface
will be used in the netvsc driver to optimize signalling the host.
Signed-off-by: K. Y. Srinivasan
---
drivers/hv/channel.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/hv/channel.c b/drive
Optimize notifying the host by deferring notification until there
are no more packets to be sent. This will help in batching the requests
on the host.
Signed-off-by: K. Y. Srinivasan
---
drivers/net/hyperv/hyperv_net.h |2 +-
drivers/net/hyperv/netvsc.c | 14 +-
drivers
Take into consideration the xmit_more flag in skb to decide if we should
notify the host as we place packets in VMBUS.
The VMBUS API that would give us this control is already in Greg's tree, in this
patch-set, that API is exported so it can be used in the netvsc driver.
Also included here is a s
> -Original Message-
> From: Olaf Hering [mailto:o...@aepfle.de]
> Sent: Wednesday, March 11, 2015 2:24 AM
> To: KY Srinivasan
> Cc: da...@davemloft.net; net...@vger.kernel.org;
> gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; a...@canonical.com;
This patch fixes the following sparse warnings:
CHECK drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:265:37: warning:
cast to restricted __le16
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c:267:39: warning:
cast to restricted __l
On 2015.03.11 16:04, Quentin Lambert wrote:
> This patch introduces goto statments for error handling
> and in cases where a lock needs to be released.
>
> A simplified version of the semantic patch that finds this problem is as
> follows: (http://coccinelle.lip6.fr)
>
> @candidates exists@
> ide
On Tue, 10 Mar 2015, Krzysztof Kozlowski wrote:
> Add new structure 'power_supply_config' for holding run-time
> initialization data like of_node, supplies and private driver data.
>
> The power_supply_register() function is changed so all power supply
> drivers need updating.
>
> When registeri
On 11 March 2015 at 14:58, Sudip Mukherjee wrote:
>
> tested the whole series on hardware, looks ok.
>
Great!
> now it depends on Greg if he wants to accept patches with such big
> commit logs, and another problem he will face is to get some patches from
> this thread and some from the old threa
spin_unlock_irqrestore() is called at several
different places before exiting. This patch uses a goto statement
to factorize these calls.
Coccinelle was used to generate this patch.
Signed-off-by: Quentin Lambert
---
drivers/staging/dgnc/dgnc_tty.c | 48 -
This patch introduces goto statments for error handling
and in cases where a lock needs to be released.
A simplified version of the semantic patch that finds this problem is as
follows: (http://coccinelle.lip6.fr)
@candidates exists@
identifier f, label;
statement s;
position p1, p2, p3;
@@
f@
The first patch fix a missing call to dgnc_tty_uninit.
The other two patches focus on the TODO item:
use goto statements for error handling when appropriate
The second patch resolves cases where the improvement seems
clear.
The third patch deals with cases where the added value did
not seem as i
From: Matteo Semenzato
Check if kmalloc succeded before using the pointer in memcpy.
Signed-off-by: Matteo Semenzato
---
drivers/staging/rtl8712/rtl871x_mlme.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c
b/drivers/staging/rtl8712/rtl871x_mlme.c
KVP/VSS/FCOPY drivers work in fully serialized mode: we wait till userspace
daemon registers, wait for a message from the host, send this message to the
daemon, get the reply, send it back to host, wait for another message.
Introduce enum hvutil_device_state to represend this state in all 3 drivers
The intention is to make KVP/VSS drivers work through misc char devices.
Introduce an abstraction for kernel/userspace communication to make the
migration smoother. Transport operational mode (netlink or char device)
is determined by the first received message. To support driver upgrades
the switch
... otherwise a crash is observed when hv_utils module is being unloaded while
fcopy daemon is still running. .owner gives us an additional reference when
someone holds a descriptor for the device.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/hv_fcopy.c | 6 ++
1 file changed, 2 insertions
..., make it inline and rename it to hv_poll_channel() so it can be reused
in other hv_util modules.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/hv_kvp.c | 17 +++--
drivers/hv/hyperv_vmbus.h | 12
2 files changed, 15 insertions(+), 14 deletions(-)
diff --git a
Introduce VSS_OP_REGISTER1 to support kernel replying to the negotiation
message with its own version.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/hv_snapshot.c| 49 ++---
include/uapi/linux/hyperv.h | 5 +
tools/hv/hv_vss_daemon.c| 14
Introduce FCOPY_VERSION_1 to support kernel replying to the negotiation
message with its own version.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/hv_fcopy.c | 16 +++-
include/uapi/linux/hyperv.h | 3 ++-
tools/hv/hv_fcopy_daemon.c | 15 +++
3 files changed, 32
In theory, the host is not supposed to issue any requests before be reply to
the previous one. In KVP we, however, support the following scenarios:
1) A message was received before userspace daemon registered;
2) A message was received while the previous one is still being processed.
In VSS we supp
'fcopy_work' (and fcopy_work_func) is a misnomer as it sounds like we expect
this useful work to happen and in reality it is just an emergency escape when
timeout happens.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/hv_fcopy.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(
... to support both netlink and /dev/vmbus/hv_kvp communication methods.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/hv_kvp.c | 91 +
1 file changed, 42 insertions(+), 49 deletions(-)
diff --git a/drivers/hv/hv_kvp.c b/drivers/hv/hv_kvp.c
Unify the code with the recently introduced hv_utils_transport. Netlink
communication is disabled for fcopy.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/hv_fcopy.c | 194 --
1 file changed, 46 insertions(+), 148 deletions(-)
diff --git a/driver
Use /dev/vmbus/hv_kvp instead of netlink.
Signed-off-by: Vitaly Kuznetsov
---
tools/hv/hv_kvp_daemon.c | 166 +--
1 file changed, 31 insertions(+), 135 deletions(-)
diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
index 408bb07..0d9f48
In theory, the host is not supposed to issue any requests before be reply to
the previous one. In KVP we, however, support the following scenarios:
1) A message was received before userspace daemon registered;
2) A message was received while the previous one is still being processed.
In FCOPY we su
... from using kvp_transaction.active.
State transitions are:
-> HVUTIL_DEVICE_INIT when driver loads or on device release
-> HVUTIL_READY if the handshake was successful
-> HVUTIL_HOSTMSG_RECEIVED when there is a non-negotiation message from the host
-> HVUTIL_USERSPACE_REQ after we sent the mess
Changes in RFCv2:
- Preserve backwards compatibility with netlink-speaking daemons. [K. Y.
Srinivasan]
- Introduce transport abstraction layer. [K. Y. Srinivasan]
- Get rid of ioctls [Radim Krcmar]
- Make the series reviewable by splitting it into smaller patches.
Anatomy of the series:
Patches 0
'kvp_work' (and kvp_work_func) is a misnomer as it sounds like we expect
this useful work to happen and in reality it is just an emergency escape when
timeout happens.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/hv_kvp.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
These declarations are internal to hv_util module and hv_fcopy_* declarations
already reside there.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/hv_kvp.c | 1 +
drivers/hv/hv_snapshot.c | 2 ++
drivers/hv/hyperv_vmbus.h | 8
include/linux/hyperv.h| 8
4 files chang
... from using 2 different state variables: kvp_transaction.active and
in_hand_shake.
State transitions are:
-> HVUTIL_DEVICE_INIT when driver loads or on device release
-> HVUTIL_READY if the handshake was successful
-> HVUTIL_HOSTMSG_RECEIVED when there is a non-negotiation message from the host
... from using 3 different state variables: fcopy_transaction.active, opened,
and in_hand_shake.
State transitions are:
-> HVUTIL_DEVICE_INIT when driver loads or on device release
-> HVUTIL_READY if the handshake was successful
-> HVUTIL_HOSTMSG_RECEIVED when there is a non-negotiation message fr
We set kvp_context when we want to postpone receiving a packet from vmbus due
to the previous transaction being unfinished. We, however, never reset this
state, all consequent kvp_respond_to_host() calls will result in poll_channel()
calling hv_kvp_onchannelcallback(). This doesn't cause real issue
On Wed, Mar 11, 2015 at 10:59:41AM +, Lorenzo Stoakes wrote:
> On 11 March 2015 at 10:57, Sudip Mukherjee wrote:
> > but function prototype still remains in sm750_accel.h
>
> No it doesn't, v2 of patch 3 in the series no longer puts it there :)
oops.. i am sorry.. i still had your previous pa
On 11 March 2015 at 10:57, Sudip Mukherjee wrote:
> but function prototype still remains in sm750_accel.h
No it doesn't, v2 of patch 3 in the series no longer puts it there :)
--
Lorenzo Stoakes
https:/ljs.io
___
devel mailing list
de...@linuxdriverpr
On Wed, Mar 11, 2015 at 10:45:48AM +, Lorenzo Stoakes wrote:
> This patch removes the unused hw712_fillrect function. This patch fixes
> the following sparse warning:-
>
> drivers/staging/sm750fb/sm750_accel.c:95:5: warning: symbol 'hw712_fillrect'
> was not declared. Should it be static?
>
This patch removes the unused hw712_fillrect function. This patch fixes
the following sparse warning:-
drivers/staging/sm750fb/sm750_accel.c:95:5: warning: symbol 'hw712_fillrect'
was not declared. Should it be static?
Signed-off-by: Lorenzo Stoakes
---
drivers/staging/sm750fb/sm750_accel.c |
This patch declares externally unavailable functions static. This fixes
the following sparse warnings:-
drivers/staging/sm750fb/ddk750_swi2c.c:223:6: warning: symbol 'swI2CStart' was
not declared. Should it be static?
drivers/staging/sm750fb/ddk750_swi2c.c:234:6: warning: symbol 'swI2CStop' was
On 11 March 2015 at 10:35, Sudip Mukherjee
> i think i will better check v2 of your series on hardware
This is incoming in just a moment (though I only v2 patches in the
series I've changed which I think is the right way to make
modifications with a patch series.)
> , and while
> you are preparin
On Wed, Mar 11, 2015 at 03:18:06PM +0530, Sudip Mukherjee wrote:
> On Wed, Mar 11, 2015 at 09:11:52AM +, Lorenzo Stoakes wrote:
> > On 11 March 2015 at 08:54, Dan Carpenter wrote:
> > > Btw, do you have this hardware? Are you able to test these changes?
> >
> > Unfortunately not, I am trying
On Wed, Mar 11, 2015 at 09:11:52AM +, Lorenzo Stoakes wrote:
> On 11 March 2015 at 08:54, Dan Carpenter wrote:
> > Btw, do you have this hardware? Are you able to test these changes?
>
> Unfortunately not, I am trying to keep these changes as simple code
> fixes that ought not to affect actu
On 11 March 2015 at 09:37, Sudip Mukherjee wrote:
> in your previous patch 3/6 you made it static now you are again
> removing the static keyword. may i ask why you changed it in 3/6 if you
> again change it back to original in this patch?
There's no good reason, it's just a mistake :) I'll fix i
On 11 March 2015 at 09:30, Sudip Mukherjee
> this is introducing a build warning, better remove this from your patch
> and send a separate patch to remove the function as this function is
> not used anywhere.
Hi Sudip,
I didn't realise I'd included the move to static in this patch. In a
later pat
On Wed, Mar 11, 2015 at 01:28:43AM +, Lorenzo Stoakes wrote:
>
> diff --git a/drivers/staging/sm750fb/sm750_accel.c
> b/drivers/staging/sm750fb/sm750_accel.c
> index 4aa763b..6521c3b 100644
> --- a/drivers/staging/sm750fb/sm750_accel.c
> +++ b/drivers/staging/sm750fb/sm750_accel.c
> @@ -92,7
Telekom Malaysia Berhad
G.03B, Ground Floor, Kompleks Antarabangsa, Jln Sultan Ismail, Off Jalan Ampang
50250 Kuala Lumpur
Malaysia.
NOTIS RASMI HADIAH TELEKOM MALAYSIA
Pihak Telekom Malaysia @Program Kemenangan yang telah diadakan pada 8th March
2015 di mana alamat email anda yang disertakan be
On Wed, Mar 11, 2015 at 01:28:42AM +, Lorenzo Stoakes wrote:
> This patch declares externally unavailable functions static. This fixes the
> following sparse warnings:-
> diff --git a/drivers/staging/sm750fb/sm750_accel.c
> b/drivers/staging/sm750fb/sm750_accel.c
> index 6521c3b..4aa763b 1006
On Tue, Mar 10, K. Y. Srinivasan wrote:
> Optimize notifying the host by deferring notification until there
> are no more packets to be sent. This will help in batching the requests
> on the host.
The subjects for the network driver say "hyperv:". But all such changes
should get "netvsc:" as pref
On Wed, Mar 11, 2015 at 09:11:52AM +, Lorenzo Stoakes wrote:
> On 11 March 2015 at 08:54, Dan Carpenter wrote:
> > When I see a patch like this, then I worry, "What if the Sparse
> > annotations are wrong? The patch description doesn't say anything about
> > that." After review then I think
On 11 March 2015 at 08:54, Dan Carpenter wrote:
> When I see a patch like this, then I worry, "What if the Sparse
> annotations are wrong? The patch description doesn't say anything about
> that." After review then I think the annotations are correct so that's
> fine.
How do you mean? I was car
On Wed, Mar 11, 2015 at 01:28:45AM +, Lorenzo Stoakes wrote:
> -static inline void myspin_lock(spinlock_t * sl){
> - struct lynx_share * share;
> - share = container_of(sl,struct lynx_share,slock);
> - if(share->dual){
> - spin_lock(sl);
> - }
> -}
Yes, good. We al
On Mon, Mar 09, 2015 at 05:04:14PM +0300, Dan Carpenter wrote:
> On Mon, Mar 09, 2015 at 07:23:43PM +0530, Sudip Mukherjee wrote:
> > > Hm... That's a good question.
> > >
> > > I suspect we should just go with fb_get_mode() and do it quickly. This
> > > driver is so new in the kernel that ther
On Wed, Mar 11, 2015 at 01:28:43AM +, Lorenzo Stoakes wrote:
> This patch adds a reference to hw712_fillrect which is not used elsewhere in
> the driver,
> but appears to be an alternative to the hw_fillrect method. This patch fixes
> the following sparse warning:-
>
> drivers/staging/sm750f
On Wed, Mar 11, 2015 at 10:57:43AM +0300, Dan Carpenter wrote:
> On Tue, Mar 10, 2015 at 10:46:57PM +0530, Sudip Mukherjee wrote:
> >
> > -while((opt = strsep(&src,":")) != NULL && *opt != NULL){
> > +while((opt = strsep(&src,":")) != NULL && *opt != 0){
>
> Use '\0' for the NUL
On Wed, Mar 11, 2015 at 01:28:40AM +, Lorenzo Stoakes wrote:
> This patch uses memset_io instead of memset when using memset on __iomem
> qualified pointers. This fixes the following sparse warnings:-
>
> drivers/staging/sm750fb/sm750.c:489:17: warning: incorrect type in argument 1
> (differe
On Tue, Mar 10, 2015 at 09:29:19PM +0200, Giedrius Statkevičius wrote:
> static ssize_t dgnc_vpd_show(struct device *p, struct device_attribute
> *attr, char *buf)
> {
> - struct dgnc_board *bd;
> - int count = 0;
> - int i = 0;
> -
> - DGNC_VERIFY_BOARD(p, bd);
> + int count
On Tue, Mar 10, 2015 at 10:46:57PM +0530, Sudip Mukherjee wrote:
> fixed the build warning about comparison of pointer and integer.
> end of string was being compared to NULL.
>
> Signed-off-by: Sudip Mukherjee
> ---
> drivers/staging/sm750fb/sm750.c | 2 +-
> 1 file changed, 1 insertion(+), 1 d
On Wed, Mar 11, 2015 at 08:46:00AM +0100, Mateusz Kulikowski wrote:
> Code reformatting based on checkpatch.pl:
> - Replaced min() with min_t()
> - Replaced printk() with netdev_*()
> - Merged broken string
That's three different things, which means this should be at least 3
different patches. Pl
Code reformatting based on checkpatch.pl:
- Replaced min() with min_t()
- Replaced printk() with netdev_*()
- Merged broken string
Signed-off-by: Mateusz Kulikowski
---
Notes:
v2 changes - removed double messages (via netdev_info and RTLLIB_DEBUG_WX)
drivers/staging/rtl8192e/rtllib_wx.c |
On Wed, Mar 11, 2015 at 12:58:42PM +0530, Sudip Mukherjee wrote:
> On Tue, Mar 10, 2015 at 09:17:54PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Mar 10, 2015 at 09:11:00PM +0100, Greg Kroah-Hartman wrote:
> > > On Tue, Mar 10, 2015 at 10:46:55PM +0530, Sudip Mukherjee wrote:
> > > > we were getti
On 11.03.2015 00:01, Joe Perches wrote:
> On Tue, 2015-03-10 at 23:53 +0100, Mateusz Kulikowski wrote:
>> - Replaced printk() with netdev_*()
>
> trivia:
>
>> diff --git a/drivers/staging/rtl8192e/rtllib_wx.c
>> b/drivers/staging/rtl8192e/rtllib_wx.c
> []
>> @@ -423,11 +421,8 @@ int rtllib_wx_se
On Tue, Mar 10, 2015 at 09:17:54PM +0100, Greg Kroah-Hartman wrote:
> On Tue, Mar 10, 2015 at 09:11:00PM +0100, Greg Kroah-Hartman wrote:
> > On Tue, Mar 10, 2015 at 10:46:55PM +0530, Sudip Mukherjee wrote:
> > > we were getting build warnings about assignment of incompatible
> >
> > That's a nic
83 matches
Mail list logo
