On Mon, Mar 09, 2015 at 09:14:38PM +0100, Matteo Semenzato wrote:
> From: Matteo Semenzato
>
> The bitmask should be used on msignals since the signals variable is not
> used anywhere in the function.
>
You're probably right. I would really like to get Mark's Ack on this
though becuase it's so
On Mon, Mar 09, 2015 at 09:08:17PM +0100, Matteo Semenzato wrote:
> From: Matteo Semenzato
>
> The comedi_cmd struct has an hole after chanlist_len that could contain
> uninitialized
> memory, this struct is copied to userspace.
>
Is this a Smatch warning? If so then, I appologize because it'
> -Original Message-
> From: KY Srinivasan
> Sent: Friday, March 6, 2015 9:20 PM
> To: KY Srinivasan; gre...@linuxfoundation.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
> a...@canonical.com; vkuzn...@redhat.com
> Subject: RE: [PATCH 0/6] Drivers: hv
When a channel has been rescinded, the close operation is a noop.
Restructure the code so we deal with the rescind condition after
we properly cleanup the channel. I would like to thank
Dexuan Cui for observing this problem.
The current code leaks memory when the channel is rescinded.
Signed-off
The storage protocol informs the guest of the I/O capabilities of the storage
stack. Retrieve this information and use it in the guest.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
---
drivers/scsi/storvsc_drv.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git
Signed-off-by: K. Y. Srinivasan
---
drivers/scsi/storvsc_drv.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index a36c232..d7ebf00 100644
--- a/drivers/scsi/storvsc_drv.c
+++ b/drivers/scsi/storvsc_drv.c
@@ -1693
Set the tablesize based on what the host has informed us.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Long Li
---
drivers/scsi/storvsc_drv.c | 70 ++-
1 files changed, 55 insertions(+), 15 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers
Presently, storvsc limits the I/O size arbitrarily. Make this configurable
based on what the host advertises.
K. Y. Srinivasan (3):
scsi: storvsc: Retrieve information about the capability of the
target
scsi: storvsc: Set the tablesize based on the information given by
the host
scsi:
From: "Mario J. Rugiero"
---
drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
b/drivers/staging/lustre/include/linux/libcfs/libcfs_kernelcomm.h
inde
From: "Mario J. Rugiero"
Hi, as listed in the todo for this driver is fixing checkpatch
warnings, I wrote this patchset which fixes the following issues on all
of the driver files, one patch per issue:
trailing semicolons in macros
uses of __attribute__((format(printf,...)) instead of __printf(
From: "Mario J. Rugiero"
---
.../include/linux/libcfs/libcfs_kernelcomm.h | 2 +-
.../staging/lustre/include/linux/lnet/lib-types.h | 2 +-
.../lustre/lustre/include/lustre/lustre_idl.h | 44 +++---
.../lustre/lustre/include/lustre/lustre_user.h | 14 +++
4
From: "Mario J. Rugiero"
---
drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 2 +-
drivers/staging/lustre/include/linux/libcfs/libcfs_private.h | 4 ++--
drivers/staging/lustre/lustre/include/lprocfs_status.h | 6 +++---
3 files changed, 6 insertions(+), 6 deletions(-)
diff
From: "Mario J. Rugiero"
---
drivers/staging/lustre/include/linux/libcfs/libcfs_debug.h | 4 ++--
drivers/staging/lustre/lustre/include/lu_object.h | 2 +-
drivers/staging/lustre/lustre/include/lustre_dlm.h | 2 +-
drivers/staging/lustre/lustre/include/lustre_net.h | 2 +
On 09/03/15 20:08, Matteo Semenzato wrote:
From: Matteo Semenzato
The comedi_cmd struct has an hole after chanlist_len that could contain
uninitialized
memory, this struct is copied to userspace.
Signed-off-by: Matteo Semenato
---
drivers/staging/comedi/comedi_fops.c | 2 ++
1 file change
Hi,
On Mon, Mar 09, 2015 at 11:09:03PM +0100, Mateusz Kulikowski wrote:
> An of_device_id should be const (checkpatch.pl warning).
>
> Signed-off-by: Mateusz Kulikowski
Acked-by: Aaro Koskinen
A.
___
devel mailing list
de...@linuxdriverproject.org
h
An of_device_id should be const (checkpatch.pl warning).
Signed-off-by: Mateusz Kulikowski
---
drivers/staging/octeon-usb/octeon-hcd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
b/drivers/staging/octeon-usb/octeon-hcd.c
index 1dae
This patch fixes the following sparse warning:-
drivers/staging/sm750fb/ddk750_help.c: warning: incorrect type in assignment
(different address spaces)
Signed-off-by: Lorenzo Stoakes
---
drivers/staging/sm750fb/ddk750_chip.h | 4 +++-
drivers/staging/sm750fb/ddk750_help.c | 2 +-
2 files chang
On Mon, Mar 09, 2015 at 08:08:24PM +0530, Sudip Mukherjee wrote:
> we were returning success even if the module failed to register.
> now we are returning the actual return value, success or error.
>
> Signed-off-by: Sudip Mukherjee
Thanks for this.
Acked-by: Willy Tarreau
Willy
From: Matteo Semenzato
The bitmask should be used on msignals since the signals variable is not
used anywhere in the function.
Signed-off-by: Matteo Semenzato
---
drivers/staging/dgnc/dgnc_cls.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_cls.c
From: Matteo Semenzato
The comedi_cmd struct has an hole after chanlist_len that could contain
uninitialized
memory, this struct is copied to userspace.
Signed-off-by: Matteo Semenato
---
drivers/staging/comedi/comedi_fops.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/stagin
Hi Dmitry,
My apologies, completely missed this (new baby, parental leave, big
email backlog, sleep deprivation, blah, blah, blah) - got an email to
say that Greg's queued it, looks fine to me fwiw.
Martyn
On 26/02/15 15:53, Dmitry Kalinkin wrote:
We also make sure that user won't be able t
Remove BOARD_FAILED and don't save dgnc_boards which failed to
initialize.
Assign the result of kzalloc() to brd in dgnc_found_board() and only put
it in the dgnc_Board[] if it successfully initializes. Also, remove
BOARD_FAILED enum and all ifs that check for it. Finally, remove one
final place w
On 2015.03.09 17:27, Giedrius Statkevičius wrote:
> Remove BOARD_FAILED and don't save dgnc_boards which failed to
> initialize.
>
> Assign the result of kzalloc() to brd in dgnc_found_board() and only put
> it in the dgnc_Board[] if it successfully initializes. Also, remove
> BOARD_FAILED enum an
Remove BOARD_FAILED and don't save dgnc_boards which failed to
initialize.
Assign the result of kzalloc() to brd in dgnc_found_board() and only put
it in the dgnc_Board[] if it successfully initializes. Also, remove
BOARD_FAILED enum and all ifs that check for it. Finally, remove one
final place w
On 2015.03.09 15:06, Dan Carpenter wrote:
> Added Matteo to the CC list because he was working on this function as
> well and I remembered something I wanted to tell him.
>
> On Sun, Mar 08, 2015 at 07:46:37PM +0200, Giedrius Statkevičius wrote:
>> Currently the label is only used to return a erro
On Mon, Mar 09, 2015 at 07:05:59PM +0530, Sudip Mukherjee wrote:
> On Mon, Mar 09, 2015 at 07:30:07AM +0100, Willy Tarreau wrote:
> > On Sun, Mar 08, 2015 at 11:07:25PM +0530, Sudip Mukherjee wrote:
> > >
> > > - if (parport_register_driver(&panel_driver)) {
> > > - pr_err("could not regi
we were returning success even if the module failed to register.
now we are returning the actual return value, success or error.
Signed-off-by: Sudip Mukherjee
---
v2: added the error message if parport_register_driver() fails.
drivers/staging/panel/panel.c | 7 ---
1 file changed, 4 inser
we donot need the reboot notifier in module init section, as the
notifier is used after lcd is initialized. so lets register for the
reboot notifier only after we have successfully attached to the
parallel port. and similarly unregister at detach.
Signed-off-by: Sudip Mukherjee
Acked-by: Willy Ta
no need to monitor init_in_progress now as keypad_send_key() can only
be called after the timer is initialized. and timer is initialized
from keypad_init() which is in the attach section and can only execute
after the module has initialized.
Signed-off-by: Sudip Mukherjee
Acked-by: Willy Tarreau
On Mon, Mar 09, 2015 at 07:23:43PM +0530, Sudip Mukherjee wrote:
> On Mon, Mar 09, 2015 at 04:38:05PM +0300, Dan Carpenter wrote:
> >
> >
> > On Mon, Mar 09, 2015 at 07:00:33PM +0530, Sudip Mukherjee wrote:
> > > On Mon, Mar 09, 2015 at 04:13:43PM +0300, Dan Carpenter wrote:
> > > > On Sun, Mar 0
On Mon, Mar 09, 2015 at 04:38:05PM +0300, Dan Carpenter wrote:
>
>
> On Mon, Mar 09, 2015 at 07:00:33PM +0530, Sudip Mukherjee wrote:
> > On Mon, Mar 09, 2015 at 04:13:43PM +0300, Dan Carpenter wrote:
> > > On Sun, Mar 08, 2015 at 11:10:11PM +0530, Sudip Mukherjee wrote:
> > > > change return typ
On Mon, Mar 09, 2015 at 07:00:33PM +0530, Sudip Mukherjee wrote:
> On Mon, Mar 09, 2015 at 04:13:43PM +0300, Dan Carpenter wrote:
> > On Sun, Mar 08, 2015 at 11:10:11PM +0530, Sudip Mukherjee wrote:
> > > change return type of sm7xx_vga_setup() to void as we are not using
> > > the return type an
On Mon, Mar 09, 2015 at 07:30:07AM +0100, Willy Tarreau wrote:
> On Sun, Mar 08, 2015 at 11:07:25PM +0530, Sudip Mukherjee wrote:
> >
> > - if (parport_register_driver(&panel_driver)) {
> > - pr_err("could not register with parport. Aborting.\n");
> > - return -EIO;
> > -
On Mon, Mar 09, 2015 at 04:13:43PM +0300, Dan Carpenter wrote:
> On Sun, Mar 08, 2015 at 11:10:11PM +0530, Sudip Mukherjee wrote:
> > change return type of sm7xx_vga_setup() to void as we are not using
> > the return type anywhere. if this function fails we fall back to the
> > default configuratio
On Mon, Mar 09, 2015 at 06:25:03PM +0530, Sudip Mukherjee wrote:
> Actually I thought, since this is a vendor crude driver there will be many
> such changes, so if i can combine some changes together then atleast the
> number of patches can be kept low and also i thought of clubbing these
> chan
On Sun, Mar 08, 2015 at 11:10:11PM +0530, Sudip Mukherjee wrote:
> change return type of sm7xx_vga_setup() to void as we are not using
> the return type anywhere. if this function fails we fall back to the
> default configuration.
>
> Signed-off-by: Sudip Mukherjee
Reviewed-by: Dan Carpenter
T
Added Matteo to the CC list because he was working on this function as
well and I remembered something I wanted to tell him.
On Sun, Mar 08, 2015 at 07:46:37PM +0200, Giedrius Statkevičius wrote:
> Currently the label is only used to return a error code to the caller but more
> repeating code is b
On Mon, Mar 09, 2015 at 03:42:22PM +0300, Dan Carpenter wrote:
> On Mon, Mar 09, 2015 at 01:05:06PM +0530, Sudip Mukherjee wrote:
> > kbuild test robot reported that for microblaze-allyesconfig
> > chan_to_field() and lynxfb_ops_set_par() were not defined. These two
> > functions were defined under
On Mon, Mar 09, 2015 at 01:05:06PM +0530, Sudip Mukherjee wrote:
> kbuild test robot reported that for microblaze-allyesconfig
> chan_to_field() and lynxfb_ops_set_par() were not defined. These two
> functions were defined under CONFIG_PM, so for any archtecture if
> CONFIG_PM is not defined we wil
On Mon, Mar 09, 2015 at 02:53:37PM +0300, Dan Carpenter wrote:
> On Mon, Mar 09, 2015 at 01:05:03PM +0530, Sudip Mukherjee wrote:
> >
> > V2: Giedrius commented resource_size_t can be either u64 or u32
> > depending on if CONFIG_PHYS_ADDR_T_64BIT. based on his comments i
> > should have kept the d
On Mon, Mar 09, 2015 at 01:05:03PM +0530, Sudip Mukherjee wrote:
> mention correct format specifier while printing.
> fixes all the build warnings about incorrect argument type while
> printing.
>
> Signed-off-by: Sudip Mukherjee
> ---
>
> V2: Giedrius commented resource_size_t can be either u64
On Sun, Mar 08, 2015 at 05:54:07PM +0100, Matteo Semenzato wrote:
> From: Matteo Semenzato
>
> Return -ENOMEM if allocating brd->flipbuf fails.
>
> Signed-off-by: Matteo Semenzato
> ---
> drivers/staging/dgnc/dgnc_driver.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/s
On Mon, Mar 09, 2015 at 12:22:09PM +0300, Dan Carpenter wrote:
> On Sun, Mar 08, 2015 at 06:01:23PM +0530, Sudip Mukherjee wrote:
> > diff --git a/drivers/staging/sm750fb/sm750.h
> > b/drivers/staging/sm750fb/sm750.h
> > index 711676c..2ab7b74 100644
> > --- a/drivers/staging/sm750fb/sm750.h
> > +
On Sun, Mar 08, 2015 at 06:01:23PM +0530, Sudip Mukherjee wrote:
> diff --git a/drivers/staging/sm750fb/sm750.h b/drivers/staging/sm750fb/sm750.h
> index 711676c..2ab7b74 100644
> --- a/drivers/staging/sm750fb/sm750.h
> +++ b/drivers/staging/sm750fb/sm750.h
> @@ -59,10 +59,10 @@ struct lynx_share{
Why is it a RESEND?
RESEND is a bit rude because it implies that we messed up by ignoring
your first email so you're sending us the exact same thing again.
Sometimes rudeness is valid if people are ignoring good patches but you
send the first email 4 minutes before sending the second email.
On Sa
Michal Hocko writes:
> [Sorry for the late response]
>
> This is basically the same code posted by KY Srinivasan posted late last
> year (http://marc.info/?l=linux-mm&m=141782228129426&w=2). I had
> objections to the implementation
> http://marc.info/?l=linux-mm&m=141805109216700&w=2
Np, David's
On Mon, Mar 09, 2015 at 07:47:40AM +, Lad, Prabhakar wrote:
> On Mon, Mar 9, 2015 at 7:35 AM, Sudip Mukherjee
> wrote:
> > check if it is already defined before defining SM750LE_REVISION_ID
> > again and at the same time mention correct data type.
> >
> > Signed-off-by: Sudip Mukherjee
> > --
On Mon, Mar 09, 2015 at 07:42:53AM +, Lad, Prabhakar wrote:
> On Mon, Mar 9, 2015 at 7:35 AM, Sudip Mukherjee
> wrote:
> >
> >
> > this patch will give checkpatch warnings about use of printk.
> > this patch was mainly to fix the build warnings. printk will be
> > converted to pr_* and dev_* i
On Mon, Mar 9, 2015 at 7:35 AM, Sudip Mukherjee
wrote:
> check if it is already defined before defining SM750LE_REVISION_ID
> again and at the same time mention correct data type.
>
> Signed-off-by: Sudip Mukherjee
> ---
>
> v2: removed the redundant cast in sm750_hw.c
>
> drivers/staging/sm750f
On Mon, Mar 9, 2015 at 7:35 AM, Sudip Mukherjee
wrote:
> mention correct format specifier while printing.
> fixes all the build warnings about incorrect argument type while
> printing.
>
> Signed-off-by: Sudip Mukherjee
> ---
>
> V2: Giedrius commented resource_size_t can be either u64 or u32
> d
check if it is already defined before defining SM750LE_REVISION_ID
again and at the same time mention correct data type.
Signed-off-by: Sudip Mukherjee
---
v2: removed the redundant cast in sm750_hw.c
drivers/staging/sm750fb/ddk750_chip.h | 4 +++-
drivers/staging/sm750fb/sm750_hw.c| 2 +-
kbuild test robot reported that for microblaze-allyesconfig
chan_to_field() and lynxfb_ops_set_par() were not defined. These two
functions were defined under CONFIG_PM, so for any archtecture if
CONFIG_PM is not defined we will have this error.
while moving the lynxfb_suspend() function some very
mention correct format specifier while printing.
fixes all the build warnings about incorrect argument type while
printing.
Signed-off-by: Sudip Mukherjee
---
V2: Giedrius commented resource_size_t can be either u64 or u32
depending on if CONFIG_PHYS_ADDR_T_64BIT. based on his comments i
should
remove use of #pragma optimize which will usually be ignored by the
compiler.
Signed-off-by: Sudip Mukherjee
---
v2: same as v1
drivers/staging/sm750fb/ddk750_swi2c.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c
b/drivers/staging/sm750fb/ddk750_
54 matches
Mail list logo
