On Sun, Mar 08, 2015 at 11:07:25PM +0530, Sudip Mukherjee wrote:
> we were returning success even if the module failed to register.
> now we are returning the actual return value, success or error.
>
> Signed-off-by: Sudip Mukherjee
> ---
> drivers/staging/panel/panel.c | 7 +--
> 1 file cha
On Sun, Mar 08, 2015 at 11:07:26PM +0530, Sudip Mukherjee wrote:
> no need to monitor init_in_progress now as keypad_send_key() can only
> be called after the timer is initialized. and timer is initialized
> from keypad_init() which is in the attach section and can only execute
> after the module h
On Sun, Mar 08, 2015 at 11:07:24PM +0530, Sudip Mukherjee wrote:
> we donot need the reboot notifier in module init section, as the
> notifier is used after lcd is initialized. so lets register for the
> reboot notifier only after we have successfully attached to the
> parallel port. and similarly
This one is bad. I've accidentally sent it, sorry. Don't pull/review
this.
On 2015.03.09 01:49, Giedrius Statkevičius wrote:
> Fix comments to make lines less than 80 characters by moving them,
> breaking the lines or making them neater.
>
[...]
--
Thanks,
Giedrius
Fix comments to make lines less than 80 characters by moving them,
breaking the lines or making them neater.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_driver.h | 55 +-
1 file changed, 36 insertions(+), 19 deletions(-)
diff --git a/dr
There are a lot double of blank lines in dgnc_cls.c thus remove them to make
the file follow the CodingStyle. Also, remove one blank line at the
end of dgnc_cls.c.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_cls.c | 36
1 file changed,
Some of the lines are over 80 characters so fix that by moving the
comments before the struct definition and before #define's.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_cls.h | 40
1 file changed, 28 insertions(+), 12 deletions(-)
Some of the lines are over 80 characters in dgnc_driver.c so fix them by
moving the comments closer to the code, tidying the comments to make
them smaller, and remove a redundant space after +.
Signed-off-by: Giedrius Statkevičius
---
drivers/staging/dgnc/dgnc_driver.c | 15 ---
1 fi
Fixes quoted string split accross lines checkpatch.pl warning.
Signed-off-by: Boran Car
---
drivers/staging/media/lirc/lirc_zilog.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/lirc/lirc_zilog.c
b/drivers/staging/media/lirc/lirc_zilog.c
i
Currently the label is only used to return a error code to the caller but more
repeating code is before each "goto failed;" thus we can move that code to the
label. Also, remove some empty unneeded lines together with this patch in those
if's and at the end of dgnc_found_board().
Signed-off-by: Gi
as we start to use kernel boot parameters and fb_get_options()
we donot need to use __setup() any more.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm7xxfb/sm7xxfb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
b/drivers/staging/sm7xxfb/sm7xxfb.c
i
use module_init() and module_exit() instead of module_pci_driver
and at the same time make way for use of kernel boot parameters.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm7xxfb/sm7xxfb.c | 26 +-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/dr
change return type of sm7xx_vga_setup() to void as we are not using
the return type anywhere. if this function fails we fall back to the
default configuration.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm7xxfb/sm7xxfb.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff
no need to monitor init_in_progress now as keypad_send_key() can only
be called after the timer is initialized. and timer is initialized
from keypad_init() which is in the attach section and can only execute
after the module has initialized.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/pan
we donot need the reboot notifier in module init section, as the
notifier is used after lcd is initialized. so lets register for the
reboot notifier only after we have successfully attached to the
parallel port. and similarly unregister at detach.
Signed-off-by: Sudip Mukherjee
---
drivers/stagi
we were returning success even if the module failed to register.
now we are returning the actual return value, success or error.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/panel/panel.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/staging/panel/panel.
On Sun, 2015-03-08 at 19:42 +0300, Mike Krinkin wrote:
> The patch converts code to use %pM specifier instead of pushing
> each byte via stack.
Hello Mike.
> diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c
> b/drivers/staging/rtl8188eu/hal/usb_halinit.c
[]
> @@ -1096,10 +1096,8 @@ stati
On Sun, Mar 08, 2015 at 02:59:03PM +0200, Giedrius Statkevičius wrote:
> On 2015.03.08 14:31, Sudip Mukherjee wrote:
> > -#define SM750LE_REVISION_ID (char)0xfe
> > +#ifndef SM750LE_REVISION_ID
> > +#define SM750LE_REVISION_ID ((unsigned char)0xfe)
> > +#endif
>
> Do you need these parantheses? Al
On Sun, Mar 08, 2015 at 10:00:52AM -0700, Joe Perches wrote:
> On Sun, 2015-03-08 at 19:42 +0300, Mike Krinkin wrote:
> > The patch converts code to use %pM specifier instead of pushing
> > each byte via stack.
>
> Hello Mike.
>
> > diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c
> > b/
The patch converts code to use %pM specifier instead of pushing
each byte via stack.
Signed-off-by: Mike Krinkin
---
Changes v2 -> v3:
- actual use of %pM instead %*ph as suggested by Larry Finger.
drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 ++
1 file changed, 2 insertions(+), 4 dele
From: Matteo Semenzato
Return -ENOMEM if allocating brd->flipbuf fails.
Signed-off-by: Matteo Semenzato
---
drivers/staging/dgnc/dgnc_driver.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgnc/dgnc_driver.c
index f177d3a..711af02
The patch converts code to use %pM specifier instead of pushing
each byte via stack.
Signed-off-by: Mike Krinkin
---
Changes in v2:
- use %pM instead %*ph as suggested by Larry Finger.
drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
dif
On Sun, Mar 08, 2015 at 11:23:05AM -0500, Larry Finger wrote:
> On 03/08/2015 10:54 AM, Mike Krinkin wrote:
> >The %*ph specifier allows to pass a pointer and length instead of
> >pushing each byte via stack. The patch converts code to use it.
> >
> >Signed-off-by: Mike Krinkin
>
> Why not use %p
On 03/08/2015 10:54 AM, Mike Krinkin wrote:
The %*ph specifier allows to pass a pointer and length instead of
pushing each byte via stack. The patch converts code to use it.
Signed-off-by: Mike Krinkin
Why not use %pM as long as you are changing this code? It will format the
results in a bet
The %*ph specifier allows to pass a pointer and length instead of
pushing each byte via stack. The patch converts code to use it.
Signed-off-by: Mike Krinkin
---
drivers/staging/rtl8188eu/hal/usb_halinit.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/
On 2015.03.08 14:31, Sudip Mukherjee wrote:
> kbuild test robot reported that for microblaze-allyesconfig
> chan_to_field() and lynxfb_ops_set_par() were not defined. These two
> functions were defined under CONFIG_PM, so for any archtecture if
> CONFIG_PM is not defined we will have this error.
>
On Sun, Mar 08, 2015 at 02:40:03PM +0200, Giedrius Statkevičius wrote:
> On 2015.03.08 14:31, Sudip Mukherjee wrote:
> > mention correct format specifier while printing
> > index 711676c..2ab7b74 100644
> > --- a/drivers/staging/sm750fb/sm750.h
> > +++ b/drivers/staging/sm750fb/sm750.h
> > @@ -59,1
On 2015.03.08 14:31, Sudip Mukherjee wrote:
> check if it is already defined before defining SM750LE_REVISION_ID
> again and at the same time mention correct data type.
>
> Signed-off-by: Sudip Mukherjee
> ---
> drivers/staging/sm750fb/ddk750_chip.h | 4 +++-
> 1 file changed, 3 insertions(+), 1
The following changes since commit c517d838eb7d07bbe9507871fab3931deccff539:
Linux 4.0-rc1 (2015-02-22 18:21:14 -0800)
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/
tags/staging-4.0-rc3
for you to fetch changes up to abe46b8932dd9
On 2015.03.08 14:31, Sudip Mukherjee wrote:
> mention correct format specifier while printing
>
> Signed-off-by: Sudip Mukherjee
> ---
>
> this patch will give checkpatch warnings about use of printk.
> this patch was mainly to fix the build warnings. printk will be
> converted to pr_* and dev_*
kbuild test robot reported that for microblaze-allyesconfig
chan_to_field() and lynxfb_ops_set_par() were not defined. These two
functions were defined under CONFIG_PM, so for any archtecture if
CONFIG_PM is not defined we will have this error.
while moving the lynxfb_suspend() function some very o
check if it is already defined before defining SM750LE_REVISION_ID
again and at the same time mention correct data type.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm750fb/ddk750_chip.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/sm750fb/ddk750_
remove use of #pragma optimize which will usually be ignored by the
compiler.
Signed-off-by: Sudip Mukherjee
---
drivers/staging/sm750fb/ddk750_swi2c.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/sm750fb/ddk750_swi2c.c
b/drivers/staging/sm750fb/ddk750_swi2c.c
index b53
mention correct format specifier while printing
Signed-off-by: Sudip Mukherjee
---
this patch will give checkpatch warnings about use of printk.
this patch was mainly to fix the build warnings. printk will be
converted to pr_* and dev_* in a later patch.
drivers/staging/sm750fb/sm750.c| 24
On 15/02/15 04:32, Tolga Ceylan wrote:
> Code reformatting based on checkpatch.pl with --strict:
> Comparison to NULL rewritten as !indio_dev
>
> Signed-off-by: Tolga Ceylan
Whilst I find it hard to care on this particular fix.. what the heck.
Applied to the togreg branch of iio.git.
Thanks,
J
On 15/02/15 04:32, Tolga Ceylan wrote:
> Code reformatting based on checkpatch.pl with --strict:
> Lines over 80 characters were fixed
>
> Signed-off-by: Tolga Ceylan
You sent me a patch for this a week before this one which was applied.
So already done :)
> ---
> drivers/staging/iio/meter/ade78
On 15/02/15 04:32, Tolga Ceylan wrote:
> Code reformatting based on checkpatch.pl with --strict:
> Alignment should match open paranthesis cases corrected
>
> Signed-off-by: Tolga Ceylan
Applied to the togreg branch of iio.git - will initially be pushed
out as testing for the autobuilders to play
On 28/02/15 20:54, Marek Belisko wrote:
> Without this change file name for hmc5843 is empty in
> /sys/bus/iio/devices/iio\:device*/name
>
> With this change name is reported correctly:
> cat /sys/bus/iio/devices/iio\:device*/name
> hmc5843
>
> Signed-off-by: Marek Belisko
Good catch, thanks.
A
38 matches
Mail list logo
