On Thu, Mar 05, 2015 at 02:32:01AM +0100, Salah Triki wrote:
> Hi,
>
> I started to get involved in the driver project since February 17 :)
> Unfortunately, I was using the wrong branch :s.
> So I cloned today the branch git://git.kernel/../gregkh/staging.git and
> searched for my patches but I ha
On Tue, Mar 03, 2015 at 03:44:54AM +0100, Salah Triki wrote:
> sysfs file is not useful for anything.
You removed _all_ sysfs files, why? Are you sure that is ok?
I don't think this is ok, sorry, please only remove the ones that you
_know_ don't do anything.
thanks,
greg k-h
__
The failure code is negative. So check <0 instead of <=0.
Return the failure code instead of -ENXIO.
Signed-off-by: Salah Triki
---
drivers/staging/dgnc/dgnc_driver.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging/dgn
Without this patch, hv_fcopy_daemon's hv_copy_data() -> pwrite()
will fail for >2GB file offset.
Signed-off-by: Alex Ng
Signed-off-by: Dexuan Cui
Cc: K. Y. Srinivasan
---
I tested the patch on x86_32 and x86_64 Ubuntu 15.04 nightly build(this is
a generic issue and I think all the existing x86
Hi,
I started to get involved in the driver project since February 17 :)
Unfortunately, I was using the wrong branch :s.
So I cloned today the branch git://git.kernel/../gregkh/staging.git and
searched for my patches but I have not found them :(
Do I have to resend the patches?
Best regards
--
Sa
On Wed, 2015-03-04 at 22:11 +0300, Dan Carpenter wrote:
> Looks good to me. Thanks!
>
> regards,
> dan carpenter
>
Thank you for all the help!!! :)
-- Ben
Also, clarify the 'ring' allocation failure by returning NULL instead
of 'ring' (which would be NULL).
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/mite.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/driv
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_660x.c
b/drivers/staging/comedi/drivers/ni_660x.c
index 1e4dd82..9d756
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pci224.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/amplc_pci224.c
b/drivers/staging/comedi/drivers/amplc_pci224.c
index 88b8c
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_pcimio.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_pcimio.c
b/drivers/staging/comedi/drivers/ni_pcimio.c
index 3b2
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_labpc_common.c
b/drivers/staging/comedi/drivers/ni_labpc_common.c
in
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index e87c68c..57dcffe 100644
--- a/drivers
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c
b/drivers/staging/comedi/drivers/cb_pcidas64.c
ind
The local variable 'cmd' is a pointer to the address of a member variable
of a struct. It will always be valid. Remove the unnecessary checks.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/s626.c | 8 ++--
1 file changed, 2 insert
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/kcomedilib/kcomedilib_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/kcomedilib/kcomedilib_main.c
b/drivers/staging/comedi/kcomedilib/kcomedilib_
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_pcidio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_pcidio.c
b/drivers/staging/comedi/drivers/ni_pcidio.c
index db399fe..8
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_atmio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_atmio.c
b/drivers/staging/comedi/drivers/ni_atmio.c
index 301f154..9cb9beb
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/comedi_fops.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/comedi/comedi_fops.c
b/drivers/staging/comedi/comedi_fops.c
index 727640e
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pci230.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/amplc_pci230.c
b/drivers/staging/comedi/drivers/amplc_pci230.c
index a9771
For aesthetics, change all the NULL comparisons from (foo == NULL) to (!foo)
and (foo != NULL) to simply (foo).
In addition, remove the NULL pointer checks of the 'cmd' in the s626 driver.
The 'cmd' is the address of a member variable in a struct. It will always
be valid.
H Hartley Sweeten (15):
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_tiocmd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_tiocmd.c
b/drivers/staging/comedi/drivers/ni_tiocmd.c
index d36c3ab.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c
b/drivers/staging/comedi/drivers/ni_mio_comm
Looks good to me. Thanks!
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
From: Matteo Semenzato
This patch removes the assignment of a function parameter that has no
effect.
Signed-off-by: Matteo Semenzato
---
drivers/staging/rtl8192e/rtllib_rx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192e/rtllib_rx.c
b/drivers/staging/rtl8192e/rtll
The messages put out by these macros are for driver debugging and aren't needed
any more, so just remove all use of them, and the macros too.
Signed-off-by: Benjamin Romer
---
v2 - Fixed a mistake where some of the if statements had accidentally doubled
tabs when the then clause was only one stat
Remove the ASSERT macro from timskmod.h, and replace its single use with
WARN_ON() instead.
Signed-off-by: Benjamin Romer
---
v2 - Fixed a mistake where some of the if statements had accidentally doubled
tabs when the then clause was only one statement.
v3 - Fixed the doubled tabs missed in v2,
Remove the LOGINF, LOGINFDEV, LOGINFDEVX, LOGINFNAME, PRINTKDRV, and
INFODRV macros entirely from the driver set.
Signed-off-by: Benjamin Romer
---
v2 - Fixed a mistake where some of the if statements had accidentally doubled
tabs when the then clause was only one statement.
v3 - Fixed the doubl
This patch series removes all of the logging macros from the Unisys driver set,
as well as the ASSERT() macro, which was really just a wrapper around a log
macro.
Log and error messages deemed necessary for the user will be added back in using
standard kernel logging functions by future patches.
Remove the LOGVER macro from the drivers entirely.
Signed-off-by: Benjamin Romer
---
v2 - Fixed a mistake where some of the if statements had accidentally doubled
tabs when the then clause was only one statement.
v3 - Fixed the doubled tabs missed in v2, and added a patch for removing the
ASSERT
Remove the LOGERR, LOGERRDEV, LOGERRDEVX, LOGERRNAME, LOGORDUMPERR
macros from all the drivers.
In one case the removal of the ERRDRV() changed things such that a macro which
returned a value was needed, but the return value was no longer being used. In
this case the macro was replaced with the co
Remove the last set of macros from uniklog.h. Without LOGWRN() and
friends, uniklog.h is empty so we can delete the file itself as well.
This macro was not used a lot but the file was included in many places.
Signed-off-by: Benjamin Romer
---
v2 - Fixed a mistake where some of the if statements
On Wed, 2015-03-04 at 19:34 +0300, Dan Carpenter wrote:
> Btw, I'm these patches are quite large. You're going to have to redo
> them to fix the three behavior changes. I'm hoping I can just diff the
> two patchsets instead of reviewing everything again so please redo them
> within the next coup
On Tue, Mar 03, 2015 at 10:50:42AM -0500, Benjamin Romer wrote:
> - if (atomic_read(&vdisk->error_count) ==
> - VIRTHBA_ERROR_COUNT) {
> - LOGERR("Throtling SCSICMD errors disk
> <%d:%d:%d:%llu>\n",
> -
On Wed, 2015-03-04 at 18:59 +0300, Dan Carpenter wrote:
> I don't think you meant to delete this line.
No, I didn't, thanks for the catch. I'll fix both of these problems and
resubmit.
-- Ben
___
devel mailing list
de...@linuxdriverproject.org
http://
On Tue, Mar 03, 2015 at 10:50:38AM -0500, Benjamin Romer wrote:
> @@ -1540,10 +1499,6 @@ virthba_serverdown_complete(struct work_struct *work)
> break;
> case CMD_SCSITASKMGMT_TYPE:
> cmdrsp = (struct uiscmdrsp *)pendingdel->sent;
> -
On Tue, Mar 03, 2015 at 10:50:40AM -0500, Benjamin Romer wrote:
> #define sizeofmember(TYPE, MEMBER) (sizeof(((TYPE *)0)->MEMBER))
> /** "Covered quotient" function */
> #define COVQ(v, d) (((v) + (d) - 1) / (d))
> diff --git a/drivers/staging/unisys/visorutil/periodic_work.c
> b/drivers/stagi
Memory blocks can be onlined in random order. When this order is not natural
some memory pages are not onlined because of the redundant check in
hv_online_page().
Here is a real world scenario:
1) Host tries to hot-add the following (process_hot_add):
pg_start=rg_start=0x48000, pfn_cnt=111616, r
This patch fixes the following errors by refactoring the comments'
style:
WARNING: line over 80 characters
ERROR: code indent should use tabs where possible
Signed-off-by: Cláudio Maia
---
drivers/staging/fbtft/fb_pcd8544.c | 107
1 file changed, 59 inserti
Fixed two warnings occurring in lines that are over 80 characters
and which are not comments.
Signed-off-by: Cláudio Maia
---
drivers/staging/fbtft/fb_pcd8544.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fb_pcd8544.c
b/drivers/staging/fbtf
Ignore this I made a mistake.
My apologies,
Quentin
On 04/03/2015 11:29, Quentin Lambert wrote:
Bcc:
Subject: [PATCH 1/2] staging: rts5208: Convert non-returned local variable to
boolean when relevant
Reply-To:
This patch was produced using Coccinelle. A simplified version of the
semantic p
This patch convert local variables declared as int into booleans.
It also propagates the conversion when these variables were used
as function parameters.
Coccinelle was used to generate this patch.
Signed-off-by: Quentin Lambert
---
drivers/staging/rts5208/ms.c| 9
drivers/st
This patch was produced using Coccinelle. A simplified version of the
semantic patch is:
@r exists@
identifier f;
local idexpression u8 x;
identifier xname;
@@
f(...) {
...when any
(
x@xname = 1;
|
x@xname = 0;
)
...when any
}
@bad exists@
identifier r.f;
local idexpression u8 r.x
expression
Bcc:
Subject: [PATCH 1/2] staging: rts5208: Convert non-returned local variable to
boolean when relevant
Reply-To:
This patch was produced using Coccinelle. A simplified version of the
semantic patch is:
@r exists@
identifier f;
local idexpression u8 x;
identifier xname;
@@
f(...) {
...when a
These patches convert int variables into boolean when relevant.
The first patch only deal with cases where the variable are local,
not returned and not given as argument to a function.
The second patch depends on the first one and deal with cases where
the local variables are given as argument. I
On Tue, Mar 03, 2015 at 08:04:10PM +0100, Noralf Trønnes wrote:
> These functions are defined in fbtft-sysfs.c and internal to the
> fbtft module.
> I think it's better to put them in an 'internal.h' file.
> The fbtft.h file will eventually live in include/linux/fbtft.h or
> something like that.
T
Remove extern keyword from function prototypes to suppress warning from
checkpatch.pl with --strict option: https://lkml.org/lkml/2013/7/23/422
fbtft maintainer Noralf Tronnes advised these functions are internal to
this module & suggested moving these prototypes to new internal.h file.
He also ad
46 matches
Mail list logo
