On Fri, Feb 27, 2015 at 03:40:11AM +0100, Salah Triki wrote:
> This fixes the following checkpatch.pl warnings:
> WARNING: Macros with flow control statements should be avoided.
>
> Signed-off-by: Salah Triki
> ---
> drivers/staging/dgnc/dgnc_sysfs.c | 64
> -
For value which has size_t type, use %zu to avoid compile warning of
printk format.
Signed-off-by: Sheng Yong
---
drivers/staging/fbtft/fbtft-core.c | 2 +-
drivers/staging/fbtft/fbtft-io.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-cor
This fixes the following checkpatch.pl warnings:
WARNING: min() should probably be min_t()
Signed-off-by: Salah Triki
---
drivers/staging/dgnc/dgnc_neo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/dgnc/dgnc_neo.c b/drivers/staging/dgnc/dgnc_neo.c
index c9
This fixes the following checkpatch.pl warnings:
WARNING: Macros with flow control statements should be avoided.
Signed-off-by: Salah Triki
---
drivers/staging/dgnc/dgnc_sysfs.c | 64 ---
1 file changed, 39 insertions(+), 25 deletions(-)
diff --git a/drivers/
On Sun, Feb 08, 2015 at 12:25:53PM +0530, Vaishali Thakkar wrote:
> This patch introduces the use of function setup_timer.
>
> This is done using Coccinelle and semantic patch used is
> as follows:
>
> @@
> expression x,y,z;
> @@
>
> - init_timer (&x);
> + setup_timer (&x, y, z);
> - x.function
On Thu, Feb 26, 2015 at 06:16:51PM +, Hartley Sweeten wrote:
> On Thursday, February 26, 2015 4:04 AM, Ian Abbott wrote:
> > On 25/02/15 23:28, H Hartley Sweeten wrote:
> >> Fix the analog input subdevice single-ended/differential channel
> >> configuration and add support for the programmable
On Thu, Feb 26, 2015 at 12:04:11PM -0500, Benjamin Romer wrote:
> From: Erik Arfvidson
>
> This patch changes unsigned long long to u64 in channel.h.
Same here, why?
thanks,
greg k-h
___
devel mailing list
de...@linuxdriverproject.org
http://driverde
On Thu, Feb 26, 2015 at 12:04:12PM -0500, Benjamin Romer wrote:
> From: Erik Arfvidson
>
> This patch changes unsigned long to u32 in channel.h
Why? What is this fixing? Please describe _why_ you do something, not
what you are doing, we can all read code :)
thanks,
greg k-h
_
On Thu, Feb 26, 2015 at 12:04:10PM -0500, Benjamin Romer wrote:
> From: Erik Arfvidson
>
> This patch removes the pr_error messages so that my following
> patches build cleanly
>
> Signed-off-by: Erik Arfvidson
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/common-spar/include
On Thu, Feb 26, 2015 at 11:38:24AM -0600, Romer, Benjamin M wrote:
> On Thu, 2015-02-26 at 20:19 +0300, Dan Carpenter wrote:
> > > + wake_up_process(thrinfo->task);
>
> > Please send bug fixes separately.
> >
> > regards,
> > dan carpenter
> >
>
> Actually, I think this is a merge error on my p
On Tue, Feb 10, 2015 at 12:58:39PM -0500, Benjamin Romer wrote:
> From: Erik Arfvidson
>
> this patch changes visorchannel_signalremove from bool to int. Also modified
> signalremove_inner since the return value was bool and change it to int.
>
> Signed-off-by: Erik Arfvidson
> Signed-off-by: B
On Tue, Feb 10, 2015 at 12:58:38PM -0500, Benjamin Romer wrote:
> From: Erik Arfvidson
>
> this patch changes variable registered from bool to int
>
> Signed-off-by: Erik Arfvidson
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/visorchipset/file.c | 8
> 1 file change
On Tue, Feb 10, 2015 at 12:58:37PM -0500, Benjamin Romer wrote:
> From: Erik Arfvidson
>
> this patch changes variable 'found' from bool to int
>
> Signed-off-by: Erik Arfvidson
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/virtpci/virtpci.c | 8
> 1 file changed, 4
On Tue, Feb 10, 2015 at 12:58:36PM -0500, Benjamin Romer wrote:
> From: Erik Arfvidson
>
> This patch changes serverchangingstate variable from bool to int
>
> Signed-off-by: Erik Arfvidson
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/virthba/virthba.c | 12 ++--
> 1
On Wed, Feb 11, 2015 at 05:41:13PM +0300, Dan Carpenter wrote:
> On Wed, Feb 11, 2015 at 08:32:52AM -0600, Romer, Benjamin M wrote:
> > On Wed, 2015-02-11 at 11:36 +0300, Dan Carpenter wrote:
> > > On Tue, Feb 10, 2015 at 12:58:35PM -0500, Benjamin Romer wrote:
> > > > From: Erik Arfvidson
> > > >
This adds support for reporting the actual and maximum combined channels
count of the hv_netvsc driver via 'ethtool --show-channels'.
This required adding 'max_chn' to 'struct netvsc_device', and assigning
it 'rsscap.num_recv_que' in 'rndis_filter_device_add'. Now we can access
the combined maximu
Hyper-V allows a guest to notify the Hyper-V host that a panic
condition occured. This notification can include up to five 64
bit values. These 64 bit values are written into crash MSRs.
Once the data has been written into the crash MSRs, the host is
then notified by writing into a Crash Control
The hardware has an 8254 timer/counter. Channe; 0 is available as a
generic counter/timer with the clock, gate, and output signals all
availabe on the main 37 pin connector. Channels 1 and 2 are used for
the pacer.
Add support for the 8254 timer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
> -Original Message-
> From: Andrew Schwartzmeyer [mailto:and...@schwartzmeyer.com]
> Subject: [PATCH] Implement Hyper-V netvsc_get_channels() ethool op
Please add net-next to the subject (the patch should also be based on that
tree).
Also the "hyperv: " word should come first.
Like this:
This adds support for reporting the combined channels count of the
hv_netvsc driver via 'ethtool --show-channels'.
This required adding 'max_chn' to 'struct netvsc_device', and assigning
it 'rsscap.num_recv_que' in 'rndis_filter_device_add'. Now we can access
the combined maximum channel count via
Fix checkpatch.pl errors:
"ERROR: do not use C99 // comments"
Signed-off-by: Alex W Slater
---
drivers/staging/vt6655/device_main.c | 36 ++
1 file changed, 19 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c
b/drivers/staging/
On Thursday, February 26, 2015 4:04 AM, Ian Abbott wrote:
> On 25/02/15 23:28, H Hartley Sweeten wrote:
>> Fix the analog input subdevice single-ended/differential channel
>> configuration and add support for the programmable ranges.
>>
>> Define, and use, the register map to remove the "magic" num
On Thu, 2015-02-26 at 20:37 +0300, Dan Carpenter wrote:
> There is only one place which calls this ASSERT() macro. It should
> probably be changed to:
>
> WARN_ON(!pw->is_scheduled);
I can do that in a subsequent patch, but my intent was to remove the
logging macros, not to fix th
On Thu, 2015-02-26 at 20:19 +0300, Dan Carpenter wrote:
> > + wake_up_process(thrinfo->task);
> Please send bug fixes separately.
>
> regards,
> dan carpenter
>
Actually, I think this is a merge error on my part, I'll send a v3 of
just this specific patch if that's alright?
-- Ben
On Thu, Feb 26, 2015 at 11:47:49AM -0500, Benjamin Romer wrote:
> diff --git a/drivers/staging/unisys/include/timskmod.h
> b/drivers/staging/unisys/include/timskmod.h
> index 7ad65cc..c23cde5 100644
> --- a/drivers/staging/unisys/include/timskmod.h
> +++ b/drivers/staging/unisys/include/timskmod.h
On Thu, Feb 26, 2015 at 11:47:47AM -0500, Benjamin Romer wrote:
> diff --git a/drivers/staging/unisys/uislib/uisthread.c
> b/drivers/staging/unisys/uislib/uisthread.c
> index d54005d..8e623dd 100644
> --- a/drivers/staging/unisys/uislib/uisthread.c
> +++ b/drivers/staging/unisys/uislib/uisthread.c
From: Erik Arfvidson
This patch changes unsigned long long to u64 in channel.h.
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/common-spar/include/channels/channel.h | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/
From: Erik Arfvidson
This patch removes the pr_error messages so that my following
patches build cleanly
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/common-spar/include/channels/channel.h | 9 -
1 file changed, 9 deletions(-)
diff --git a/dr
This set of patches fixes a few spots where u32 and u64 should have been used,
but were not used.
Erik Arfvidson (3):
staging: unisys: remove pr_error from channel
staging: unisys: change unsigned long long to u64
staging: unisys: change unsigned long to u32
.../unisys/common-spar/include/
From: Erik Arfvidson
This patch changes unsigned long to u32 in channel.h
Signed-off-by: Erik Arfvidson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/common-spar/include/channels/channel.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisy
The messages put out by these macros are for driver debugging and aren't needed
any more, so just remove all use of them, and the macros too.
Signed-off-by: Benjamin Romer
---
v2 - Fixed a mistake where some of the if statements had accidentally doubled
tabs if the then clause was only one state
Remove the LOGERR, LOGERRDEV, LOGERRDEVX, LOGERRNAME, LOGORDUMPERR
macros from all the drivers.
Signed-off-by: Benjamin Romer
---
v2 - Fixed a mistake where some of the if statements had accidentally doubled
tabs if the then clause was only one statement.
drivers/staging/unisys/include/timskmod
Remove the LOGVER macro from the drivers entirely.
Signed-off-by: Benjamin Romer
---
v2 - Fixed a mistake where some of the if statements had accidentally doubled
tabs if the then clause was only one statement.
drivers/staging/unisys/include/uniklog.h | 28
drivers/
Remove the last set of macros from uniklog.h. Without LOGWRN() and
friends, uniklog.h is empty so we can delete the file itself as well.
This macro was not used a lot but the file was included in many places.
Signed-off-by: Benjamin Romer
---
v2 - Fixed a mistake where some of the if statements
This patch series removes all of the logging macros from the Unisys driver set.
Log and error messages deemed necessary for the user will be added back in using
standard kernel logging functions by future patches.
v2 - Fixed a mistake where some of the if statements had accidentally doubled
tabs
Remove the LOGINF, LOGINFDEV, LOGINFDEVX, LOGINFNAME, PRINTKDRV, and
INFODRV macros entirely from the driver set.
Signed-off-by: Benjamin Romer
---
v2 - Fixed a mistake where some of the if statements had accidentally doubled
tabs if the then clause was only one statement.
drivers/staging/unisy
Change 'disabed' and 'disabel' to 'disabled'
Change 'inviation' to 'invitation'
Change 'negoitation' to 'negotiation'
Signed-off-by: Yannick Guerrini
---
drivers/staging/rtl8188eu/include/wifi.h| 24
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 2 +-
2 files change
This implements more granular locking in vme_user_ioctl() by using separate
locks for each devfs device.
This also provides a synchronization between vme_user_read(), vme_user_write()
and vme_user_ioctl().
Signed-off-by: Dmitry Kalinkin
Cc: Igor Alekseev
---
drivers/staging/vme/devices/vme_use
We also make sure that user won't be able to reconfigure the window while it is
mmap'ed.
Signed-off-by: Dmitry Kalinkin
Cc: Igor Alekseev
---
drivers/staging/vme/devices/vme_user.c | 85 ++
drivers/vme/vme.c | 26 +++
include/linux/vm
From: Martyn Welch
The tsi148 driver is registering the slave images as supporting the "USER"
access modes and CR/CSR access mode rather than the master images as it
should.
Remove the incorrect case entries for these modes from the
tsi148_slave_set() function, stop registering slave_images as s
Dear all,
mmap() on VME bridge devices is a feature present in many existing Linux and
UNIX drivers. The proposed solution follows the approach so that mmap()
offsets are coherent with read() and write() offsets, which seems to be the
only manner compatible with the current vme_user API. It also
On Thu, 2015-02-26 at 18:07 +0300, Dan Carpenter wrote:
> Gar... Actually everything is double tabbed. What's the deal with
> that? There are other examples as well.
>
> regards,
> dan carpenter
>
I'll fix these and resubmit the patch set.
--
Ben Romer | Software Engineer |
Virtual Systems
> -Original Message-
> From: Andrew Schwartzmeyer [mailto:and...@schwartzmeyer.com]
> Sent: Thursday, February 26, 2015 1:43 AM
> To: Haiyang Zhang
> Cc: KY Srinivasan; de...@linuxdriverproject.org; hall5...@vandals.uidaho.edu;
> kei...@vandals.uidaho.edu; doma8...@vandals.uidaho.edu
> Su
From: Jes Sorensen
Hi,
A few more fixes for the rtl8723au driver for staging-next.
Cheers,
Jes
Jes Sorensen (6):
staging: rtl8723au: Use RF_AC instead of hardcoded value for RF
register write
staging: rtl8723au: rates are always set via the firmware interface
staging: rtl8723au: rtl
On Thu, Feb 26, 2015 at 09:55:06AM -0500, Benjamin Romer wrote:
> + if (ControlVm_channel)
> + visorchannel_signalinsert(ControlVm_channel,
> + CONTROLVM_QUEUE_ACK,
> +
On Thu, Feb 26, 2015 at 09:55:02AM -0500, Benjamin Romer wrote:
> + if (virthbainfo->serverdown || virthbainfo->serverchangingstate)
> + return FAILED;
> +
[ snip ]
> + if (virthbainfo->serverdown || virthbainfo->serverchangingstate)
> + return FAIL
This patch series removes all of the logging macros from the Unisys driver set.
Log and error messages deemed necessary for the user will be added back in using
standard kernel logging functions by future patches.
Benjamin Romer (5):
staging: unisys: remove DBGINF, DBGVER, DEBUGDEV, and DEBUGDR
Remove the LOGERR, LOGERRDEV, LOGERRDEVX, LOGERRNAME, LOGORDUMPERR
macros from all the drivers.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/timskmod.h | 6 +-
drivers/staging/unisys/include/uisutils.h | 2 -
drivers/staging/unisys/include/uniklog.h
Remove the LOGINF, LOGINFDEV, LOGINFDEVX, LOGINFNAME, PRINTKDRV, and
INFODRV macros entirely from the driver set.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/timskmod.h | 2 -
drivers/staging/unisys/include/uniklog.h | 29 ---
drivers/staging/unisys/u
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/usb_halinit.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c
b/drivers/staging/rtl8723au/hal/usb_halinit.c
index adbf1c2..319170d 100644
--
Remove the last set of macros from uniklog.h. Without LOGWRN() and
friends, uniklog.h is empty so we can delete the file itself as well.
This macro was not used a lot but the file was included in many places.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/procobjecttree.h|
The messages put out by these macros are for driver debugging and aren't needed
any more, so just remove all use of them, and the macros too.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/timskmod.h | 2 -
drivers/staging/unisys/include/uniklog.h | 39 ---
driv
Remove the LOGVER macro from the drivers entirely.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/uniklog.h | 28
drivers/staging/unisys/virthba/virthba.c | 4
2 files changed, 32 deletions(-)
diff --git a/drivers/staging/unisys/include/unikl
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/odm.c | 12
drivers/staging/rtl8723au/include/odm.h | 3 ---
2 files changed, 15 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/odm.c
b/drivers/staging/rtl8723au/hal/odm.c
index 523a5a5
From: Jes Sorensen
No point shifting raid right, just to shift it left again before
re-adding it.
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.
From: Jes Sorensen
The only case where fw_ractrl = false was when the firmware failed to
load, and in that case we are dead in the water anyway.
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/odm.c| 3 +--
.../staging/rtl8723au/hal/rtl8723a_bt-coexist.c| 28
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/include/hal_com.h | 30 -
1 file changed, 30 deletions(-)
diff --git a/drivers/staging/rtl8723au/include/hal_com.h
b/drivers/staging/rtl8723au/include/hal_com.h
index 7c31865..e946c4b 1006
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/include/ieee80211.h | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/rtl8723au/include/ieee80211.h
b/drivers/staging/rtl8723au/include/ieee80211.h
index cb23cd0..3caf4f5 100644
--- a/
On February 26, 2015 6:09:56 AM EST, Ian Abbott wrote:
>On 25/02/15 21:37, Nicholas Krause wrote:
>>
>>
>> On February 25, 2015 1:03:14 PM EST, Hartley Sweeten
> wrote:
>>> On Tuesday, February 24, 2015 9:13 PM, Nicholas Krause wrote:
This changes us using the incorrect error,-ETIMEOUT when
On 25/02/15 21:37, Nicholas Krause wrote:
On February 25, 2015 1:03:14 PM EST, Hartley Sweeten
wrote:
On Tuesday, February 24, 2015 9:13 PM, Nicholas Krause wrote:
This changes us using the incorrect error,-ETIMEOUT when checking if
the channel we are allocating to on the device structure p
On 25/02/15 23:28, H Hartley Sweeten wrote:
Fix the analog input subdevice single-ended/differential channel
configuration and add support for the programmable ranges.
Define, and use, the register map to remove the "magic" numbers.
Provide a range table for the analog output subdevice.
Tidy u
On czw, 2015-02-26 at 01:45 +0100, Sebastian Reichel wrote:
> Hi,
>
> On Mon, Feb 23, 2015 at 12:47:32PM +0100, Krzysztof Kozlowski wrote:
> > Change the ownership of power_supply structure from each driver
> > implementing the class to the power supply core.
> >
(...)
>
> I would like to merg
On śro, 2015-02-25 at 11:54 +, Jonathan Cameron wrote:
> On 24/02/15 09:41, Krzysztof Kozlowski wrote:
> > The regmap_access_table and regmap_config structures may be const
> > because they are not modified by the driver and regmap_init() accepts
> > pointer to const.
> >
> > Signed-off-by: Kr
On Mon, 23 Feb 2015, Krzysztof Kozlowski wrote:
> Change the ownership of power_supply structure from each driver
> implementing the class to the power supply core.
>
> The patch changes power_supply_register() function thus all drivers
> implementing power supply class are adjusted.
>
> Each dr
64 matches
Mail list logo