On Thu, Feb 12, 2015 at 11:18:50PM -0800, tolga ceylan wrote:
> Just noticed this warning in all dgnc_* files:
>
> *NOTE TO LINUX KERNEL HACKERS: DO NOT REFORMAT THIS CODE!
> *
> *This is shared code between Digi's CVS archive and the
> *Linux Kernel sources.
> *Changing the
On 02/12/2015 10:20 PM, Joe Perches wrote:
On Thu, 2015-02-12 at 21:58 -0800, Tolga Ceylan wrote:
On Wed, Feb 11, 2015 at 2:36 AM, Dan Carpenter wrote:
That looks kind of uglier than before. Please run your patch throught
scripts/checkpatch.pl --strict.
[]
Running with --strict helped, but
Code reformatting based on checkpatch.pl with --strict:
1) Lines over 80 characters were fixed
2) Alignment should match open paranthesis cases corrected
3) Comparison to NULL rewritten as !indio_dev
Signed-off-by: Tolga Ceylan
---
drivers/staging/iio/meter/ade7854-i2c.c | 39 +--
On Thu, 2015-02-12 at 21:58 -0800, Tolga Ceylan wrote:
> On Wed, Feb 11, 2015 at 2:36 AM, Dan Carpenter
> wrote:
> > That looks kind of uglier than before. Please run your patch throught
> > scripts/checkpatch.pl --strict.
[]
> Running with --strict helped, but now I'm also getting warnings for
On Wed, Feb 11, 2015 at 2:36 AM, Dan Carpenter wrote:
> That looks kind of uglier than before. Please run your patch throught
> scripts/checkpatch.pl --strict.
>
> regards,
> dan carpenter
>
Running with --strict helped, but now I'm also getting warnings for
camel case usage. If I try to fix cam
On Thu, 12 Feb 2015 23:43:17 +0100 "Rafael J. Wysocki"
wrote:
> On Thursday, February 12, 2015 10:10:30 PM KY Srinivasan wrote:
>
> [cut]
yay!
> > > > > >
> > > > > > This issue was first discovered by Andy Whitcroft:
> > > > > > https://lkml.org/lkml/2014/3/14/451
> > > > > > I had sent patc
On Thursday, February 12, 2015 10:10:30 PM KY Srinivasan wrote:
[cut]
> > > > >
> > > > > This issue was first discovered by Andy Whitcroft:
> > > > > https://lkml.org/lkml/2014/3/14/451
> > > > > I had sent patches based on Andy's analysis that did not affect
> > > > > the users of the kernel ho
> -Original Message-
> From: Rafael J. Wysocki [mailto:r...@rjwysocki.net]
> Sent: Thursday, February 12, 2015 2:28 PM
> To: KY Srinivasan
> Cc: Vitaly Kuznetsov; linux-ker...@vger.kernel.org; Greg Kroah-Hartman;
> Haiyang Zhang; Andrew Morton; Yasuaki Ishimatsu; Tang Chen; Vlastimil
> Ba
On Thursday, February 12, 2015 10:01:48 PM KY Srinivasan wrote:
>
> > -Original Message-
> > From: Rafael J. Wysocki [mailto:r...@rjwysocki.net]
> > Sent: Thursday, February 12, 2015 2:13 PM
> > To: KY Srinivasan
> > Cc: Vitaly Kuznetsov; linux-ker...@vger.kernel.org; Greg Kroah-Hartman;
>
> -Original Message-
> From: Rafael J. Wysocki [mailto:r...@rjwysocki.net]
> Sent: Thursday, February 12, 2015 2:13 PM
> To: KY Srinivasan
> Cc: Vitaly Kuznetsov; linux-ker...@vger.kernel.org; Greg Kroah-Hartman;
> Haiyang Zhang; Andrew Morton; Yasuaki Ishimatsu; Tang Chen; Vlastimil
> Ba
On Thursday, February 12, 2015 03:38:42 PM KY Srinivasan wrote:
>
> > -Original Message-
> > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> > Sent: Thursday, February 12, 2015 2:24 AM
> > To: linux-ker...@vger.kernel.org
> > Cc: Greg Kroah-Hartman; KY Srinivasan; Haiyang Zhang; Andr
Observe the line length limit to make checkpatch.pl happy.
Signed-off-by: Ivan Stankovic
---
drivers/staging/vt6655/channel.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/vt6655/channel.c b/drivers/staging/vt6655/channel.c
index 3c17725..7a71782 10
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Thursday, February 12, 2015 7:50 AM
> To: KY Srinivasan
> Cc: linux-ker...@vger.kernel.org; Greg Kroah-Hartman; Haiyang Zhang;
> Andrew Morton; Yasuaki Ishimatsu; Tang Chen; Vlastimil Babka; David
> Rientje
Joe Perches writes:
> On Wed, 2015-02-11 at 21:02 +0100, Richard Weinberger wrote:
>> On Wed, Feb 11, 2015 at 7:36 PM, Dan Carpenter
>> wrote:
>> > On Wed, Feb 11, 2015 at 10:00:29AM -0800, Joe Perches wrote:
>> >> I'm half tempted to submit some patch like this to
>> >> make it difficult to us
KY Srinivasan writes:
>> -Original Message-
>> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
>> Sent: Thursday, February 12, 2015 2:24 AM
>> To: linux-ker...@vger.kernel.org
>> Cc: Greg Kroah-Hartman; KY Srinivasan; Haiyang Zhang; Andrew Morton;
>> Yasuaki Ishimatsu; Tang Chen; Vlas
David Rientjes writes:
> On Wed, 11 Feb 2015, David Rientjes wrote:
>
>> > If newly added memory is brought online with e.g. udev rule:
>> > SUBSYSTEM=="memory", ACTION=="add", ATTR{state}="online"
>> > the following deadlock is observed (and easily reproducable):
>> >
>> > First participant, wo
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Thursday, February 12, 2015 2:24 AM
> To: linux-ker...@vger.kernel.org
> Cc: Greg Kroah-Hartman; KY Srinivasan; Haiyang Zhang; Andrew Morton;
> Yasuaki Ishimatsu; Tang Chen; Vlastimil Babka; David Rientjes;
This patch reduces the kernel size by removing error messages that duplicate
the normal OOM message.
Signed-off-by: Quentin Lambert
---
drivers/staging/lustre/lustre/llite/llite_close.c | 4 +---
drivers/staging/lustre/lustre/llite/xattr_cache.c | 5 +
2 files changed, 2 insertions(+), 7 del
If CONFIG_SYSCTL=n:
drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:84: warning:
‘proc_set_timeout’ defined but not used
drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c:95: warning:
‘proc_memory_alloc’ defined but not used
drivers/staging/lustre/lustre/obdclas
Am 2015-02-11 um 20:33 schrieb Christian Engelmayer:
> When failing to allocate buffer memory, function vnt_download_firmware() goes
> through the wrong exit path and fails to release the already requested
> firmware. Thus use the correct cleanup. Detected by Coverity CID 1269128.
>
> Signed-off-b
these functions are not being used anywhere.so we can remove them.
has been verified by "git grep" that they are not being referenced
anywhere also has been build tested.
Signed-off-by: Sudip Mukherjee
---
i am not sure if this is correct. req_handler_add() and req_handler_del() is
not being
use
On 11/02/2015 11:23, Dan Carpenter wrote:
On Wed, Feb 11, 2015 at 06:26:27AM +0800, Greg Kroah-Hartman wrote:
On Tue, Feb 10, 2015 at 02:02:14PM +0100, Quentin Lambert wrote:
This patch removes allocation from declaration line because
people are known to gloss over declarations.
Again, who are
If newly added memory is brought online with e.g. udev rule:
SUBSYSTEM=="memory", ACTION=="add", ATTR{state}="online"
the following deadlock is observed (and easily reproducable):
First participant, worker thread doing add_memory():
...
[ 725.491469] 6 locks held by kworker/0:1/27:
[ 725.505037]
RESEND (with no changes) because Rafael J. Wysocki was missing in recepients.
If newly added memory is brought online with e.g. udev rule:
SUBSYSTEM=="memory", ACTION=="add", ATTR{state}="online"
the following deadlock is observed (and easily reproducable):
First participant, worker thread doing
add_memory() is supposed to be run with device_hotplug_lock grabbed, otherwise
it can race with e.g. device_online(). Allow external modules (hv_balloon for
now) to lock device hotplug.
Signed-off-by: Vitaly Kuznetsov
---
drivers/base/core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/
add_memory() is supposed to be run with device_hotplug_lock grabbed, otherwise
it can race with e.g. device_online(). ACPI memory hotplug does that already
but e.g. Hyper-V ballooning driver doesn't.
Signed-off-by: Vitaly Kuznetsov
---
mm/memory_hotplug.c | 6 +-
1 file changed, 5 insertions
David Rientjes writes:
> On Wed, 11 Feb 2015, Vitaly Kuznetsov wrote:
>
>> If newly added memory is brought online with e.g. udev rule:
>> SUBSYSTEM=="memory", ACTION=="add", ATTR{state}="online"
>> the following deadlock is observed (and easily reproducable):
>>
>> First participant, worker thr
"Rafael J. Wysocki" writes:
> On Wednesday, February 11, 2015 12:39:47 PM Andrew Morton wrote:
>> On Wed, 11 Feb 2015 16:44:20 +0100 Vitaly Kuznetsov
>> wrote:
>>
>> > add_memory() is supposed to be run with device_hotplug_lock grabbed,
>> > otherwise
>> > it can race with e.g. device_online(
On Thu, Feb 12, 2015 at 01:43:00AM +0300, Dan Carpenter wrote:
> On Wed, Feb 11, 2015 at 12:43:03PM -0800, Joe Perches wrote:
> > Maybe some help/warning text like:
> >
> > --forceWithout --force, checkpatch will not scan files
> > using -f or --f
29 matches
Mail list logo
