Re: doubt about sm7xxfb

On Wed, Feb 11, 2015 at 11:58:18AM +0530, Sudip Mukherjee wrote: > On Wed, Feb 11, 2015 at 12:36:36PM +0800, Greg Kroah-Hartman wrote: > > On Tue, Feb 10, 2015 at 07:37:47PM +0530, Sudip Mukherjee wrote: > > > Hi Greg, > > > we have this sm7xxfb in drivers/staging now which is supporting SM710, > >

Re: doubt about sm7xxfb

On Wed, Feb 11, 2015 at 12:36:36PM +0800, Greg Kroah-Hartman wrote: > On Tue, Feb 10, 2015 at 07:37:47PM +0530, Sudip Mukherjee wrote: > > Hi Greg, > > we have this sm7xxfb in drivers/staging now which is supporting SM710, > > SM712, SM721 and SM722. I am also working on another new hardware > > SM

[PATCH v2 2/6] staging: rtl8188eu: hal: removed code indent error

This patch removed indentation with a tab error ERROR: code indent should use tabs where possible Signed-off-by: Pushpendra Singh --- drivers/staging/rtl8188eu/hal/rf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/rf.c b/drivers/staging/rtl

Re: doubt about sm7xxfb

On Tue, Feb 10, 2015 at 07:37:47PM +0530, Sudip Mukherjee wrote: > Hi Greg, > we have this sm7xxfb in drivers/staging now which is supporting SM710, > SM712, SM721 and SM722. I am also working on another new hardware > SM750, which will be ready for staging in next 1 -2 weeks. > this SM750 is entir

[PATCH] staging: lustre: resolves sparse warnings using static declaration

This patch resolves sparse warnings about non-declared symbol in staging/lustre/lustre/lov by adding static declaration. These warnings are like this: warning: symbol 'fiemap_calc_fm_end_offset' was not declared. Should it be static? Signed-off-by: Le Tan --- drivers/staging/lustre/lust

Fwd:Чем порадовать?=Классный подарок на 14 февраля=

=Чем порадовать?=Крутой подарок к 14 февраля= http://www.google.com/url?q=htt%70%3A%2F%2Fs%65%72gyv%70%6fda%72%6fk%2e%72%75su%62est%2e%72u%2F%23%30%35%34%31%322%334%362054%3122346%32&sa=D&sntz=1&usg=AFQjCNHQQm8l6YWW5otIPIOnsNAjWLwlzw ___ devel mailin

NOTIS RASMI HADIAH TELEKOM MALAYSIA

Telekom Malaysia Berhad G.03B, Ground Floor, Kompleks Antarabangsa, Jln Sultan Ismail, Off Jalan Ampang 50250 Kuala Lumpur Malaysia. NOTIS RASMI HADIAH TELEKOM MALAYSIA Pihak Telekom Malaysia @Program Kemenangan yang telah diadakan pada 9th Februari 2015 di mana alamat email anda yang disertakan

[PATCHv2 2/2] ft1000-pcmcia: ft1000_hw.c: code refactoring: add ft1000_read_dsp_timer()

Add new function ft1000_read_dsp_timer() replacing recurring code block for reading DSP timer. Such code refactoring solves all remaining "line over 80 characters" warnings reported by checkpatch.pl. Signed-off-by: Daniele Alessandrelli --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 197

[PATCHv2 0/2] staging: ft1000-pcmcia: ft1000_hw.c: fix checkpatch warnings

This small patchset fixes all the style problems reported by checkpatch.pl on ft1000-pcmcia/ft1000_hw.c * Patch 1/2 fixes all trivial issues not requiring code refactoring * Patch 2/2 fixes all remaining "line over 80 characters" warnings by means of some code refactoring. Specifically, the fu

[PATCHv2 1/2] ft1000-pcmcia: ft1000_hw.c: fix style issues not requiring code refactoring

Fix all the trivial style issues (as reported by checkpatch.pl) not requiring code refactoring. A following patch is expected to fix the remaining issues by performing some code refactoring. Signed-off-by: Daniele Alessandrelli --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 455 +

Re: [PATCH 1/1] staging: unisys: Remove allocation from declaration line

On Tue, Feb 10, 2015 at 02:02:14PM +0100, Quentin Lambert wrote: > This patch removes allocation from declaration line because > people are known to gloss over declarations. Again, who are these lazy people, and why are they reading kernel code? Please, it's ok to allocate things in the declarati

Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error

On Tue, Feb 10, 2015 at 06:32:49PM +0530, Pushpendra Singh wrote: > Removed checkpatch.pl error > ERROR: code indent should use tabs where possible Then fix the indentation with a tab, not using over 8 spaces, don't make this a new coding style issue that I will then get an additional patch for la

Re: [PATCH 1/1] staging: android: Remove allocation from declaration line

On Tue, Feb 10, 2015 at 12:09:45PM +0100, Quentin Lambert wrote: > This patch removes allocation from declaration line because > people are known to gloss over declarations. Then those people should not be reviewing kernel code :) Seriously, this is unneeded churn, the code is fine as-is. thanks

[PATCH v4 3/3] staging: lustre: fix coding style errors fix the

following coding style error in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c: missing spaces around '=' Signed-off-by: Tal Shorer --- drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lus

[PATCH v4 2/3] staging: lustre: fix coding style errors

fix the following coding style error in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c: initialization of min_watchdog_ratelimit (static int) to 0 for clarity's sake, the "= 0" is kept as part of a comment Signed-off-by: Tal Shorer --- drivers/staging/lustre/lustre/libcfs/linux/linux-

[PATCH v4 1/3] staging: lustre: fix coding style errors

fix the following coding style error in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c: initialization of lnet_table_header (static pointer) to NULL Signed-off-by: Tal Shorer --- drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[PATCH 16/30] staging: unisys: change visorchannel_funcs.c function variable from bool to int

From: Erik Arfvidson This patch changes visorchanne_funcs.c function variable from bool to int. Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

[PATCH 03/30] staging: unisys: change bool to int variable found

From: Erik Arfvidson this patch changes variable 'found' from bool to int Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/virtpci/virtpci.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/unisys/virtpci/virtpci

[PATCH 14/30] staging: unisys: remove #define bool in visorchannel.h

From: Erik Arfvidson This patche removes pound define from visorchannel.h. Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchannel/visorchannel.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/unisys/visorchannel/visorchannel.

[PATCH 11/30] staging: unisys: changes visorchipset.[ch] functions from bool to int

From: Erik Arfvidson This patch changes the following functions in visorchipset.[ch] from bool to int: visorchipset_cache_alloc visorchipset_get_bus_info visorchipset_get_device_info visorchipset_set_bus_context Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/u

[PATCH 09/30] staging: unisys: changes bool to int in sig related function

From: Erik Arfvidson This patch changes the return value from bool to int to the following sig related function: sig_read_data, sig_write_data, and sig_do_data Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 16 +++

[PATCH 06/30] staging: unisys: changes function visorchannel_signalinsert from bool to int

From: Erik Arfvidson This patch changes function from visorchannel_signalinsert from bool to int. Also, changes to signalinsert_inner had to be change since visorchannel_signalinsert call that other function which return value was bool so it was change to int as well. Signed-off-by: Erik Arfvids

[PATCH 30/30] staging: unisys: vbuschannel.h pragma

From: Jeffrey Brown Replaced pragma statements that was surrounding the structs spar_vbus_headerinfo and spar_vbus_channel_protocol with __packed Signed-off-by: Jeffrey Brown Signed-off-by: Benjamin Romer --- drivers/staging/unisys/common-spar/include/channels/vbuschannel.h | 7 ++- 1 fil

[PATCH 12/30] staging: unisys: change visorchipset/parse.[ch] from bool to int

From: Erik Arfvidson this patch changes visorchipset variables from bool to int. Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/parser.c | 24 drivers/staging/unisys/visorchipset/parser.h | 6 +++--- 2 files change

[PATCH 29/30] staging: unisys: iochannel.h pragma

From: Jeffrey Brown Replaced pragma code surrounding multiple structs at once with __packed statements for each struct Signed-off-by: Jeffrey Brown Signed-off-by: Benjamin Romer --- .../common-spar/include/channels/iochannel.h | 47 +- 1 file changed, 18 insertions(+

[PATCH 27/30] staging: unisys: vmcall_channel_version_mismatch

From: Jeffrey Brown Replaced "pragma pack(push, 1)" and "pragma pack(pop)" with __packed Signed-off-by: Jeffrey Brown Signed-off-by: Benjamin Romer --- drivers/staging/unisys/common-spar/include/vmcallinterface.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/driver

[PATCH 07/30] staging: unisys: changes sig_read_header function from bool to int

From: Erik Arfvidson This patch changes function sig_read_header return value from bool to int Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dri

[PATCH 18/30] staging: unisys: change uislib.c variables from type bool to int

From: Erik Arfvidson this patch changes uislib.c variables from type bool to int Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/uislib/uislib.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/unisys/u

[PATCH 02/30] staging: unisys: change serverchangingstate variable bool to int

From: Erik Arfvidson This patch changes serverchangingstate variable from bool to int Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/virthba/virthba.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/unisy

[PATCH 26/30] staging: unisys: vmcall_io_diag_addr_params pragma

From: Jeffrey Brown Removed pragma code in vmacallinterface.h for the struct vmcall_io_diag_addr_params, and put __packed in place of it Signed-off-by: Jeffrey Brown Signed-off-by: Benjamin Romer --- drivers/staging/unisys/common-spar/include/vmcallinterface.h | 7 +-- 1 file changed, 1 i

[PATCH 05/30] staging: unisys: fix function visorchannel_signalremove from bool to int

From: Erik Arfvidson this patch changes visorchannel_signalremove from bool to int. Also modified signalremove_inner since the return value was bool and change it to int. Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchannel/visorchannel.h |

[PATCH 20/30] staging: unisys: remove goto from sig_do_data()

The gotos in this function are unnecessary, so just return. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/staging/unisys/visorchannel/visorchannel_funcs.c b/

[PATCH 24/30] staging: unisys: vmcallintferace phys_info pragma

From: Jeffrey Brown Changed pragma code surrounding the struct phys_info with a __packed statement Signed-off-by: Jeffrey Brown Signed-off-by: Benjamin Romer --- drivers/staging/unisys/common-spar/include/vmcallinterface.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --gi

[PATCH 00/30] staging: unisys: cleanup patch series

This set of patches cleans up some more of the code by eliminating unnecessary goto statements, getting rid of the BOOL define and switching over code that used it to use int instead, and switching from using pragma(pack) to __packed. *** BLURB HERE *** Benjamin Romer (3): staging: unisys: remo

[PATCH 17/30] staging: unisys: change visorkmodutils.c variable from bool to int.

From: Erik Arfvidson this patch changes the value of variable unisys_spar_plataform from bool to int. Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorutil/visorkmodutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/

[PATCH 01/30] staging: unisys: serverdown variable change bool to int virthba

From: Erik Arfvidson This patch changes serverdown variable to int instead of bool Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/virthba/virthba.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/unisys/virthb

Re: [RFC PATCH 0/5] unisys: kthread cleanup

On Mon, 2015-01-26 at 00:39 -0500, devendra.aaru wrote: > Hello, > > Sorry for the late reply. > > Would reverting last two patches help ? > > Thanks, > Devendra Devendra, I am really sorry for how long this is taking. I don't think that there's anything wrong with your patches, but rather th

Re: [PATCH 1/2] staging: panel: register driver after checking device

On Tue, Feb 10, 2015 at 05:26:02PM +0530, Sudip Mukherjee wrote: > register the driver only if lcd or keypad has been enabled and if > both are disabled then just exit. > > Signed-off-by: Sudip Mukherjee Acked-by: Willy Tarreau Willy ___ devel maili

Re: [PATCH 2/2] staging: panel: initialize lcd if lcd enabled

On Tue, Feb 10, 2015 at 05:26:03PM +0530, Sudip Mukherjee wrote: > initialiaze lcd parameters only if lcd is enabled. > > Signed-off-by: Sudip Mukherjee One minor comment below (cosmetic), but after this it's OK. Acked-by: Willy Tarreau > + if (lcd.enabled) { > + /* > +

[PATCH 21/30] staging: unisys: remove unnecessary goto in parser_param_start()

The goto isn't necessary here so replace it with a simple return statement. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/parser.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/unisys/visorchipset/parser.c b/drivers/staging/unisy

[PATCH 19/30] staging: unisys: remove #definition from timskmod.h

From: Erik Arfvidson this patch removes #definitions from timksmod.h Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/include/timskmod.h| 5 - drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 15 +-- 2 files chan

[PATCH 25/30] staging: unisys: vmcall_io_controlvm_addr_params pragma

From: Jeffrey Brown Replaced pragma code for the struct vmcall_io_controlvm_addr_params with __packed Signed-off-by: Jeffrey Brown Signed-off-by: Benjamin Romer --- drivers/staging/unisys/common-spar/include/vmcallinterface.h | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff -

[PATCH 23/30] staging: unisys: vbusdeviceinfo pragma

From: Jeffrey Brown Replaced pragma code in vbusdeviceinfo.h with __packed for the struct ultra_vbus_deviceinfo Signed-off-by: Jeffrey Brown Signed-off-by: Benjamin Romer --- drivers/staging/unisys/common-spar/include/vbusdeviceinfo.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-)

[PATCH 22/30] staging: unisys: Remove unnecessary gotos from info_debugfs_read_helper

Get rid of all the useless gotos in info_debugfs_read_helper() and just return the correct values straight away. Signed-off-by: Benjamin Romer --- drivers/staging/unisys/uislib/uislib.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/unisys/uisli

[PATCH 04/30] staging: unisys: change variable registered from bool to int

From: Erik Arfvidson this patch changes variable registered from bool to int Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchipset/file.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/unisys/visorchips

[PATCH 10/30] staging: unisys: change periodic_work.[ch] functions from bool to int

From: Erik Arfvidson This patch changes the following functions from bool to int: visor_periodic_work_nextperiod visor_periodic_work_destroy visor_periodic_work_stop visor_periodic_work_start Also change struct periodic_work variables from bool to int Signed-off-by: Erik Arfvidson Signed-off-by

[PATCH 28/30] staging: unisys: channel.h pragma

From: Jeffrey Brown Replaced pragma code surrounding the structs signal_queue_header and channel_header with __packed for both of them Signed-off-by: Jeffrey Brown Signed-off-by: Benjamin Romer --- drivers/staging/unisys/common-spar/include/channels/channel.h | 7 ++- 1 file changed, 2 in

[PATCH 15/30] staging: unisys: change memregion_direct.c variables type bool to int.

From: Erik Arfvidson This patch changes all variable types bool to int in memregion_direct.c Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- .../staging/unisys/visorutil/memregion_direct.c| 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff

[PATCH 08/30] staging: unisys: changes needs_lock from bool to int

From: Erik Arfvidson This patch changes needs_lock from bool to int. As a result this changes variable needs_lock inside function visorchannel_create_guts. Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 12 ++-

[PATCH 13/30] staging: unisys: change charqueue.[ch] variables from bool to int

From: Erik Arfvidson This patch changes charqueue.[ch] functions and variables from bool to int including their return values. Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- drivers/staging/unisys/visorutil/charqueue.c | 4 ++-- drivers/staging/unisys/visorutil/charqueue.h |

[PATCH] staging: lustre: lustre: lov: lov_dev: fix sparse warning of static declaration

This patch adds a static keyword to cl_lov_device_mutex_class variable to suppress the warning of static declaration Signed-off-by: Mohammad Jamal --- drivers/staging/lustre/lustre/lov/lov_dev.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/

Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error

>> @@ -101,8 +101,7 @@ void rtl88eu_phy_rf6052_set_cck_txpower(struct adapter >> *adapt, u8 *powerlevel) >> ptr++; >> } >> } >> - rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv, 1, &direction, >> - &pwrtrac_value

Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error

On Tue, Feb 10, 2015 at 03:27:11PM +0100, Bas Peters wrote: > >> @@ -101,8 +101,7 @@ void rtl88eu_phy_rf6052_set_cck_txpower(struct adapter > >> *adapt, u8 *powerlevel) > >> ptr++; > >> } > >> } > >> - rtl88eu_dm_txpower_track_adjust(&hal_data->odmpriv

Re: [PATCH v2 1/1] staging: ozwpan: Remove allocation from delaration line

On Tue, 2015-02-10 at 13:13 +0300, Dan Carpenter wrote: > > diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c [] > > @@ -280,8 +280,9 @@ static void oz_free_urb_link(struct oz_urb_link *urbl) > > */ > > static struct oz_endpoint *oz_ep_alloc(int buffer_size, gfp_t mem_

Re: [PATCH 2/6] staging: rtl8188eu: hal: removed code indent error

On Tue, Feb 10, 2015 at 06:32:49PM +0530, Pushpendra Singh wrote: > Removed checkpatch.pl error > ERROR: code indent should use tabs where possible > > Signed-off-by: Pushpendra Singh > --- > drivers/staging/rtl8188eu/hal/rf.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff -

[PATCH v2 1/1] staging: unisys: Remove allocation from declaration line

This patch removes allocation from declaration line because people are known to gloss over declarations. Signed-off-by: Quentin Lambert --- The second of version of this patch fix the checkpatch warning of line over 80 char by rewriting the size argument of kmalloc as suggested by Sudip. dr

doubt about sm7xxfb

Hi Greg, we have this sm7xxfb in drivers/staging now which is supporting SM710, SM712, SM721 and SM722. I am also working on another new hardware SM750, which will be ready for staging in next 1 -2 weeks. this SM750 is entirely different hardware and these two drivers will have nothing in common

Re: [PATCH 1/1] staging: unisys: Remove allocation from declaration line

On Tue, Feb 10, 2015 at 02:02:14PM +0100, Quentin Lambert wrote: > This patch removes allocation from declaration line because > people are known to gloss over declarations. > > Signed-off-by: Quentin Lambert > --- > drivers/staging/unisys/visorchipset/visorchipset_main.c | 6 +++--- > drivers/s

[PATCH 1/1] staging: unisys: Remove allocation from declaration line

This patch removes allocation from declaration line because people are known to gloss over declarations. Signed-off-by: Quentin Lambert --- drivers/staging/unisys/visorchipset/visorchipset_main.c | 6 +++--- drivers/staging/unisys/visorutil/charqueue.c| 3 ++- drivers/staging/unisys/

[PATCH 6/6] staging: rtl8188eu: hal: removed unnecessary parentheses

Removed checkpatch.pl below warning WARNING: Unnecessary parentheses - maybe == should be = ? Signed-off-by: Pushpendra Singh --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers

[PATCH 1/6] staging: rt8188eu: hal: removed space before ','

Removed checkpatch.pl error ERROR: space prohibited before that ',' (ctx:WxW) Signed-off-by: Pushpendra Singh --- drivers/staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 4 ++-- drivers/staging/rtl8188eu/hal/odm.c | 8 drivers/staging/rtl8188eu/hal/pwrseqcmd.c

[PATCH 2/6] staging: rtl8188eu: hal: removed code indent error

Removed checkpatch.pl error ERROR: code indent should use tabs where possible Signed-off-by: Pushpendra Singh --- drivers/staging/rtl8188eu/hal/rf.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rf.c b/drivers/staging/rtl8188eu/hal/rf.c inde

[PATCH 4/6] staging: rtl8188eu: hal: added blank line after declarations

Removed checkpatch.pl below warning WARNING: Missing a blank line after declarations Signed-off-by: Pushpendra Singh --- .../staging/rtl8188eu/hal/Hal8188ERateAdaptive.c | 1 + drivers/staging/rtl8188eu/hal/hal_intf.c | 2 ++ drivers/staging/rtl8188eu/hal/odm.c| 3

[PATCH 3/6] staging: rtl8188eu: hal: removed unnecessary braces

Removed checkpatch.pl below warning WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Pushpendra Singh --- drivers/staging/rtl8188eu/hal/bb_cfg.c| 15 +++ drivers/staging/rtl8188eu/hal/fw.c| 3 +-- drivers/staging/rtl8188eu/h

[PATCH 5/6] staging: rtl8188eu: hal: removed spaces at start of line

Removed checkpatch.pl below warning WARNING: please, no spaces at the start of a line Signed-off-by: Pushpendra Singh --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging

[PATCH] staging: sm7xxfb: make vgamode static

the variable vgamode is used only in this file and hence can be safely made as static. Signed-off-by: Sudip Mukherjee --- drivers/staging/sm7xxfb/sm7xx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/sm7xxfb/sm7xx.h b/drivers/staging/sm7xxfb/sm7xx.h index 7c

[PATCH 1/2] staging: panel: register driver after checking device

register the driver only if lcd or keypad has been enabled and if both are disabled then just exit. Signed-off-by: Sudip Mukherjee --- drivers/staging/panel/panel.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/sta

[PATCH 2/2] staging: panel: initialize lcd if lcd enabled

initialiaze lcd parameters only if lcd is enabled. Signed-off-by: Sudip Mukherjee --- drivers/staging/panel/panel.c | 41 ++--- 1 file changed, 22 insertions(+), 19 deletions(-) diff --git a/drivers/staging/panel/panel.c b/drivers/staging/panel/panel.c index

[PATCH v2 2/2] staging: unisys: fix directory warning

we were getting three warnings about timskmod and sparstopdriver and channels. These warnings were about no such file or directory. These directory names were included in the Makefile, but the directories were not existing. Signed-off-by: Sudip Mukherjee --- make W=1 is showing these warnings d

[PATCH v2 1/2] staging: unisys: remove unused variable

we were getting lots of warnings about _tempresult set but not used. _tempresult was used in the macro ISSUE_IO_VMCALL_POSTCODE_SEVERITY which was again using another macro ISSUE_IO_EXTENDED_VMCALL. but the value assigned to it was never used. Signed-off-by: Sudip Mukherjee --- make W=1 is showin

Re: [PATCH] staging:lustre:libcfs: Merge linux-proc.c into module.c

module.c was previously the sole exporter of symbols from module.c This patch removes the global symbols by merging the two files. Signed-off-by: Matthew Tyler --- drivers/staging/lustre/lustre/libcfs/Makefile | 2 +- .../lustre/lustre/libcfs/linux/linux-proc.c| 577 --

Re: [PATCH 1/7] staging: rtl8188eu: core: added blank line after declarations

On Tue, Feb 10, 2015 at 03:34:09PM +0530, Pushpendra Singh wrote: > Removed following checkpatch.pl warning from mutiple files > WARNING: Missing a blank line after declarations you have not checked this patch with checkpatch. ERROR: trailing whitespace #502: FILE: drivers/staging/rtl8188eu/core/

Re: [PATCH 1/1] staging: ozwpan: Move code from success handling to error handling

On Tue, Feb 10, 2015 at 12:08:14PM +0100, Quentin Lambert wrote: > > On 10/02/2015 12:04, Dan Carpenter wrote: > >On Tue, Feb 10, 2015 at 11:42:08AM +0100, Quentin Lambert wrote: > >>The original version was success handling rather than error handling, > >>therefore this patch reduces nesting. > >

[PATCH 1/1] staging: android: Remove allocation from declaration line

This patch removes allocation from declaration line because people are known to gloss over declarations. Signed-off-by: Quentin Lambert --- drivers/staging/android/ion/ion_page_pool.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/android/ion/ion_page_po

Re: [PATCH 1/1] staging: ozwpan: Move code from success handling to error handling

On 10/02/2015 12:04, Dan Carpenter wrote: On Tue, Feb 10, 2015 at 11:42:08AM +0100, Quentin Lambert wrote: The original version was success handling rather than error handling, therefore this patch reduces nesting. Signed-off-by: Quentin Lambert Fantastic. :) Thanks! regards, dan carpente

Re: [PATCH 1/1] staging: ozwpan: Move code from success handling to error handling

On Tue, Feb 10, 2015 at 11:42:08AM +0100, Quentin Lambert wrote: > The original version was success handling rather than error handling, > therefore this patch reduces nesting. > > Signed-off-by: Quentin Lambert Fantastic. :) Thanks! regards, dan carpenter ___

[PATCH 1/1] staging: ozwpan: Move code from success handling to error handling

The original version was success handling rather than error handling, therefore this patch reduces nesting. Signed-off-by: Quentin Lambert --- drivers/staging/ozwpan/ozhcd.c | 18 +++--- drivers/staging/ozwpan/ozpd.c | 53 +- 2 files changed, 37 i

Re: [PATCH v2 1/1] staging: ozwpan: Remove allocation from delaration line

Looks good. Thanks! > diff --git a/drivers/staging/ozwpan/ozhcd.c b/drivers/staging/ozwpan/ozhcd.c > index 8543bb2..96e95bf 100644 > --- a/drivers/staging/ozwpan/ozhcd.c > +++ b/drivers/staging/ozwpan/ozhcd.c > @@ -280,8 +280,9 @@ static void oz_free_urb_link(struct oz_urb_link *urbl) > */ > s

Re: [PATCH 1/1] staging: ozwpan: Remove allocation from delaration line

On Tue, Feb 10, 2015 at 09:55:03AM +0100, Quentin Lambert wrote: > static struct oz_endpoint *oz_ep_alloc(int buffer_size, gfp_t mem_flags) > { > - struct oz_endpoint *ep = > - kzalloc(sizeof(struct oz_endpoint)+buffer_size, mem_flags); > + struct oz_endpoint *ep; > + > +

[PATCH 7/7] staging: rtl8188eu: core : remove space before tabs

remove below checkpatch.pl warning WARNING: please, no space before tabs Signed-off-by: Pushpendra Singh --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_xmit.c b/drivers/staging/rtl

[PATCH 5/7] staging: rtl8188eu: core: remove indentation warning

remove checckpatch.pl warning WARNINGROR: switch and case should be at the same indent Signed-off-by: Pushpendra Singh --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 32 +-- 1 files changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/staging/rtl8188eu/co

[PATCH 6/7] staging: rtl8188eu: core: removed unnecessary braces

remove checkpatch.pl warning WARNING: braces {} are not necessary for single statement blocks Signed-off-by: Pushpendra Singh --- drivers/staging/rtl8188eu/core/rtw_efuse.c| 3 +-- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 14 +- drivers/staging/rtl8188eu/core/rtw_pwrctrl.

[PATCH 1/7] staging: rtl8188eu: core: added blank line after declarations

Removed following checkpatch.pl warning from mutiple files WARNING: Missing a blank line after declarations Signed-off-by: Pushpendra Singh --- drivers/staging/rtl8188eu/core/rtw_debug.c | 3 ++- drivers/staging/rtl8188eu/core/rtw_efuse.c | 12 drivers/staging/rtl8188eu/cor

[PATCH 4/7] staging: rtl8188eu: core: remove unnecessary parentheses

remove checkpatch.pl warning WARNING: Unnecessary parentheses - maybe == should be = ? Signed-off-by: Pushpendra Singh --- drivers/staging/rtl8188eu/core/rtw_ioctl_set.c | 4 ++-- drivers/staging/rtl8188eu/core/rtw_mlme.c | 2 +- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +- driver

[PATCH 2/7] staging: rtl8188eu: core: removing unnecessary space

Removed unnecessary space before that ',' ERROR: space prohibited before that ',' (ctx:WxE) Signed-off-by: Pushpendra Singh --- drivers/staging/rtl8188eu/core/rtw_ieee80211.c | 8 +++--- drivers/staging/rtl8188eu/core/rtw_mlme.c | 18 ++-- drivers/staging/rtl8188eu/core/rtw_mlme_ex

[PATCH 3/7] staging: rtl8188eu: core: remove spaces at start of line

remove checkpatch.pl warning WARNING: please, no spaces at the start of a line Signed-off-by: Pushpendra Singh --- drivers/staging/rtl8188eu/core/rtw_led.c | 2 +- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 2 +- drivers/staging/rtl8188eu/core/rtw_recv.c | 6 +- drivers/stagi

Re: Ralink 6570 / Mediatek MT7601STA (was Re: Addition of a wifi kernel module to the linux source tree)

Hello everone! A few months earlier I had requested addition of the MT7601 WiFi dongle module into the kernel. I was told that the needful would be done in the rt2x00 driver. Could you guys update me with the status? Thanks a lot! -Parth Sane On 4 December 2014 at 20:06, Stanislaw Gruszka wrote:

[PATCH v2 1/1] staging: ozwpan: Remove allocation from delaration line

This patch removes allocation from declaration line because people are known to gloss over declarations. Signed-off-by: Quentin Lambert --- Changes since v1: - Remove the blank line between allocation and NULL check drivers/staging/ozwpan/ozhcd.c | 5 +++-- drivers/staging/ozwpan/ozpd.c | 8

[PATCH 1/1] staging: ozwpan: Remove allocation from delaration line

This patch removes allocation from declaration line because people are known to gloss over declarations. Signed-off-by: Quentin Lambert --- This patch was inspired by http://www.spinics.net/lists/linux-usb/msg44389.html and https://lkml.org/lkml/2015/2/7/47 but I am not sure the argument is val