Re: [PATCH v3 04/20] power_supply: sysfs: Use power_supply_*() API for accessing function attrs

2015-02-09 Thread Krzysztof Kozlowski
On pon, 2015-02-09 at 20:02 +0100, Stefan Wahren wrote: > Hi Krzysztof, > > > Krzysztof Kozlowski hat am 30. Januar 2015 um > > 15:47 > > geschrieben: > > > > > > Replace direct calls to power supply function attributes with wrappers. > > Wrappers provide safe access in case of unregistering the

Re: [PATCH 1/2] staging: unisys: remove unused variable

2015-02-09 Thread Sudip Mukherjee
On Tue, Feb 10, 2015 at 02:34:15PM +0800, Greg Kroah-Hartman wrote: > On Tue, Feb 10, 2015 at 10:50:06AM +0530, Sudip Mukherjee wrote: > > Nothing to do on your side, I am on the road this week and will move > those to my -next branch right now, thanks for reminding me. welcome sir. If you ever n

NOTIS RASMI HADIAH TELEKOM MALAYSIA

2015-02-09 Thread Telekom Malaysia Berhad
Telekom Malaysia Berhad G.03B, Ground Floor, Kompleks Antarabangsa, Jln Sultan Ismail, Off Jalan Ampang 50250 Kuala Lumpur Malaysia. NOTIS RASMI HADIAH TELEKOM MALAYSIA Pihak Telekom Malaysia @Program Kemenangan yang telah diadakan pada 9th Februari 2015 di mana alamat email anda yang disertakan

Re: [PATCH 1/2] staging: unisys: remove unused variable

2015-02-09 Thread Greg Kroah-Hartman
On Tue, Feb 10, 2015 at 10:50:06AM +0530, Sudip Mukherjee wrote: > > > if you want I can add an extra From: line, but Dan has already given his > > > commments for that at https://lkml.org/lkml/2014/9/3/135 > > > quoting him : > > > > > > "If everyone starts using From headers like this then it b

Re: [PATCH 1/2] staging: unisys: remove unused variable

2015-02-09 Thread Sudip Mukherjee
On Tue, Feb 10, 2015 at 05:35:40AM +0800, Greg Kroah-Hartman wrote: > On Sun, Feb 08, 2015 at 04:31:07PM +0530, Sudip Mukherjee wrote: > > On Sat, Feb 07, 2015 at 05:22:16PM +0800, Greg Kroah-Hartman wrote: > > > On Fri, Feb 06, 2015 at 06:13:21PM +0530, Sudip Mukherjee wrote: > > > > we were getti

Re: [PATCH v3] staging: lustre: fix coding style errors

2015-02-09 Thread
On Tue, Feb 10, 2015 at 12:34:07AM +, Drokin, Oleg wrote: > > On Feb 9, 2015, at 4:34 PM, wrote: > >> There's a third coding style error in this file which I've chosen to > >> not fix for clarity's sake. It is: initializing min_watchdog_ratelimit > >> (static int) to 0 > > > > Please fix tha

Re: [PATCH v3] staging: lustre: fix coding style errors

2015-02-09 Thread Drokin, Oleg
On Feb 9, 2015, at 4:34 PM, wrote: >> There's a third coding style error in this file which I've chosen to >> not fix for clarity's sake. It is: initializing min_watchdog_ratelimit >> (static int) to 0 > > Please fix that too, it's not correct. Drop the comment there if you > think that's confu

Re: [PATCH] Staging: lustre: Added missing __user keyword to several struct fields

2015-02-09 Thread Greg Kroah-Hartman
On Mon, Feb 09, 2015 at 11:56:58PM +0100, Adrian Remonda wrote: > This is a patch that fixes up missing __user warnings found by the sparse > > modified: drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h > modified: drivers/staging/lustre/include/linux/lnet/lnetst.h >

Re: Question regarding sparse warning in staging/lustre

2015-02-09 Thread Greg Kroah-Hartman
On Tue, Feb 10, 2015 at 12:07:17AM +0100, AdrianRemonda wrote: > On Mon, Feb 09, 2015 at 07:40:23AM +0800, Greg Kroah-Hartman wrote: > > On Sun, Feb 08, 2015 at 10:27:23PM +0100, Adrian Remonda wrote: > > > Hello, > > > > > > I'm cleaning the drivers/staging/lustre driver. > > > I have got the nex

Re: Question regarding sparse warning in staging/lustre

2015-02-09 Thread AdrianRemonda
On Mon, Feb 09, 2015 at 07:40:23AM +0800, Greg Kroah-Hartman wrote: > On Sun, Feb 08, 2015 at 10:27:23PM +0100, Adrian Remonda wrote: > > Hello, > > > > I'm cleaning the drivers/staging/lustre driver. > > I have got the next warning from sparse: > > > > drivers/staging/lustre/lnet/selftest//conct

[PATCH] Staging: lustre: Added missing __user keyword to several struct fields

2015-02-09 Thread Adrian Remonda
This is a patch that fixes up missing __user warnings found by the sparse modified: drivers/staging/lustre/include/linux/libcfs/libcfs_ioctl.h modified: drivers/staging/lustre/include/linux/lnet/lnetst.h modified: drivers/staging/lustre/lnet/selftest/conctl.c

[PATCH 1/6] staging: rtl8723au: Use RF_AC instead of hardcoded value for RF register write

2015-02-09 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_halinit.c index adbf1c2..319170d 100644 --

[PATCH 6/6] staging: rtl8723au: Firmware always handles adaptive rates

2015-02-09 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c | 12 drivers/staging/rtl8723au/include/odm.h | 3 --- 2 files changed, 15 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm.c b/drivers/staging/rtl8723au/hal/odm.c index 523a5a5

[PATCH 2/6] staging: rtl8723au: rates are always set via the firmware interface

2015-02-09 Thread Jes . Sorensen
From: Jes Sorensen The only case where fw_ractrl = false was when the firmware failed to load, and in that case we are dead in the water anyway. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm.c| 3 +-- .../staging/rtl8723au/hal/rtl8723a_bt-coexist.c| 28

[PATCH 5/6] staging: rtl8723au: hal_com.h: Remove some unused #defines

2015-02-09 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/hal_com.h | 30 - 1 file changed, 30 deletions(-) diff --git a/drivers/staging/rtl8723au/include/hal_com.h b/drivers/staging/rtl8723au/include/hal_com.h index 7c31865..e946c4b 1006

[PATCH 4/6] staging: rtl8723au: Remove more unused #defines

2015-02-09 Thread Jes . Sorensen
From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/include/ieee80211.h | 14 -- 1 file changed, 14 deletions(-) diff --git a/drivers/staging/rtl8723au/include/ieee80211.h b/drivers/staging/rtl8723au/include/ieee80211.h index cb23cd0..3caf4f5 100644 --- a/

[PATCH 0/6] staging: rtl8723au: Further cleanups

2015-02-09 Thread Jes . Sorensen
From: Jes Sorensen Hi, A couple more cleanups for the rtl8723au driver. Cheers, Jes Jes Sorensen (6): staging: rtl8723au: Use RF_AC instead of hardcoded value for RF register write staging: rtl8723au: rates are always set via the firmware interface staging: rtl8723au: rtl8723a_add_r

[PATCH 3/6] staging: rtl8723au: rtl8723a_add_rateatid() simplyfy code

2015-02-09 Thread Jes . Sorensen
From: Jes Sorensen No point shifting raid right, just to shift it left again before re-adding it. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_cmd.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_cmd.

Re: [PATCH 1/2] staging: unisys: remove unused variable

2015-02-09 Thread Greg Kroah-Hartman
On Sun, Feb 08, 2015 at 04:31:07PM +0530, Sudip Mukherjee wrote: > On Sat, Feb 07, 2015 at 05:22:16PM +0800, Greg Kroah-Hartman wrote: > > On Fri, Feb 06, 2015 at 06:13:21PM +0530, Sudip Mukherjee wrote: > > > we were getting lots of warnings about _tempresult set but not used. > > > _tempresult wa

Re: [PATCH v3] staging: lustre: fix coding style errors

2015-02-09 Thread
On Mon, Feb 09, 2015 at 07:20:30PM +0200, Tal Shorer wrote: > Fix the following coding style errors in > drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c: > 1. initializing lnet_table_header (static pointer) to NULL > 2. missing spaces around '=' Those are two different things, and should b

[PATCH fix for v3.20] staging: vt6655: vnt_tx_packet fix dma_idx selection.

2015-02-09 Thread Malcolm Priestley
There is still a problem that dma_idx is causing packets to go onto the wrong tx path. Protect dma_idx fully with the present first lock and use pTDInfo->byFlags TD_FLAGS_NETIF_SKB to set MACvTransmit. Signed-off-by: Malcolm Priestley --- drivers/staging/vt6655/device_main.c | 16 +-

Re: [PATCH v3 04/20] power_supply: sysfs: Use power_supply_*() API for accessing function attrs

2015-02-09 Thread Stefan Wahren
Hi Krzysztof, > Krzysztof Kozlowski hat am 30. Januar 2015 um 15:47 > geschrieben: > > > Replace direct calls to power supply function attributes with wrappers. > Wrappers provide safe access in case of unregistering the power > supply (e.g. by removing the driver). Replace: > - get_property -> p

Re: [PATCH v3] staging: lustre: fix coding style errors

2015-02-09 Thread Tal Shorer
Fix the following coding style errors in drivers/staging/lustre/lustre/libcfs/linux/linux-proc.c: 1. initializing lnet_table_header (static pointer) to NULL 2. missing spaces around '=' There's a third coding style error in this file which I've chosen to not fix for clarity's sake. It is: initiali

Re: [PATCH] staging: lustre: lnet: lnet: lip-ptl:fix sparse warning of static declaration

2015-02-09 Thread Joe Perches
On Mon, 2015-02-09 at 21:45 +0530, Mohammad Jamal wrote: > This patch adds a static keyword to variable portal_rotor to > suppress the sparse warning of static declaration Do please compile the subsystem before sending patches. > diff --git a/drivers/staging/lustre/lnet/lnet/lib-ptl.c > b/driver

[PATCH] staging: lustre: lnet: lnet: lip-ptl:fix sparse warning of static declaration

2015-02-09 Thread Mohammad Jamal
This patch adds a static keyword to variable portal_rotor to suppress the sparse warning of static declaration Signed-off-by: Mohammad Jamal --- drivers/staging/lustre/lnet/lnet/lib-ptl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/lnet/lib-

Re: [PATCH] staging:lustre:libcfs:linux: Define insert_proc and remove_proc in separate header file

2015-02-09 Thread Greg KH
On Mon, Feb 09, 2015 at 07:47:48PM +0800, Matt Tyler wrote: > On Sun, Feb 08, 2015 at 09:44:43PM +0800, Greg KH wrote: > > On Sun, Feb 08, 2015 at 09:26:15PM +0800, Matthew Tyler wrote: > > > Sparse is currently throwing warnings as insert_proc and remove_proc > > > are not defined. > > > > > > T

Re: [PATCH] staging:lustre:libcfs:linux: Define insert_proc and remove_proc in separate header file

2015-02-09 Thread Matt Tyler
On Sun, Feb 08, 2015 at 09:44:43PM +0800, Greg KH wrote: > On Sun, Feb 08, 2015 at 09:26:15PM +0800, Matthew Tyler wrote: > > Sparse is currently throwing warnings as insert_proc and remove_proc > > are not defined. > > > > The patch adds definitions for these files in a suitable header file. > >

Re: [PATCH v3 20/20] arm: mach-pxa: Decrement the power supply's device reference counter

2015-02-09 Thread Krzysztof Kozlowski
On pią, 2015-02-06 at 15:59 +0100, Pavel Machek wrote: > On Fri 2015-02-06 15:43:08, Krzysztof Kozlowski wrote: > > On pią, 2015-02-06 at 14:49 +0100, Pavel Machek wrote: > > > On Fri 2015-01-30 15:47:58, Krzysztof Kozlowski wrote: > > > > Use power_supply_put() to decrement the power supply's devi

[PATCH] staging: lustre: use linux headers

2015-02-09 Thread Asaf Vertz
WARNING: Use #include instead of WARNING: Use #include instead of WARNING: Use #include instead of Signed-off-by: Asaf Vertz --- .../staging/lustre/lnet/klnds/o2iblnd/o2iblnd.h|2 +- .../lustre/lnet/klnds/socklnd/socklnd_lib-linux.h |2 +- .../lustre/lustre/libcfs/linux/linux-

Re: [PATCH] media: bcm2048: remove unused return of function

2015-02-09 Thread Pali Rohár
On Sunday 08 February 2015 23:29:11 Luis de Bethencourt wrote: > Integer return of bcm2048_parse_rds_rt () is never used, > changing the return type to void. > > Signed-off-by: Luis de Bethencourt > --- > drivers/staging/media/bcm2048/radio-bcm2048.c | 4 +--- > 1 file changed, 1 insertion(+), 3