On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote:
> make ARCH=i386 allyesconfig fails with
>
> drivers/staging/built-in.o: In function `reset':
> (.text+0x2ae89d): multiple definition of `reset'
> drivers/isdn/built-in.o:(.text+0x185dc2): first defined here
> make[1]: *** [drivers/built-i
On 25 January 2015 at 04:39, Greg KH wrote:
> On Sat, Jan 17, 2015 at 07:04:23PM -0700, mathieu.poir...@linaro.org wrote:
>> From: Mathieu Poirier
>>
>> mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/
>> LD drivers/staging/vt6655/built-in.o
>> CHECK drivers/staging/vt6
3.14-stable review patch. If anyone has any objections, please let me know.
--
From: "K. Y. Srinivasan"
commit 32c6590d126836a062b3140ed52d898507987017 upstream.
The Hyper-V clocksource is continuous; mark it accordingly.
Signed-off-by: K. Y. Srinivasan
Acked-by: jasow...@re
3.10-stable review patch. If anyone has any objections, please let me know.
--
From: "K. Y. Srinivasan"
commit 32c6590d126836a062b3140ed52d898507987017 upstream.
The Hyper-V clocksource is continuous; mark it accordingly.
Signed-off-by: K. Y. Srinivasan
Acked-by: jasow...@re
3.18-stable review patch. If anyone has any objections, please let me know.
--
From: "K. Y. Srinivasan"
commit 32c6590d126836a062b3140ed52d898507987017 upstream.
The Hyper-V clocksource is continuous; mark it accordingly.
Signed-off-by: K. Y. Srinivasan
Acked-by: jasow...@re
On Tuesday, January 27, 2015 at 11:23:33 PM, Rickard Strandqvist wrote:
> Wrong type in printf format string, requires 'int'
> but the argument type is 'unsigned int'
>
> This was found using a static code analysis program called cppcheck
>
> Signed-off-by: Rickard Strandqvist
Makes sense, than
From: Vitaly Kuznetsov <[mailto:vkuzn...@redhat.com]>
SynIC has to be switched off when we unload the module, otherwise registered
memory pages can get corrupted after (as Hyper-V host still writes there) and
we see the following crashes for random processes:
[ 89.116774] BUG: Bad page map in p
From: Vitaly Kuznetsov <[mailto:vkuzn...@redhat.com]>
Newly introduced clockevent devices made it impossible to unload hv_vmbus
module as clockevents_config_and_register() takes additional reverence to
the module. To make it possible again we do the following:
- avoid setting dev->owner for clocke
From: Vitaly Kuznetsov <[mailto:vkuzn...@redhat.com]>
We need to destroy hv_vmbus_con on module shutdown, otherwise the following
crash is sometimes observed:
[ 76.569845] hv_vmbus: Hyper-V Host Build:9600-6.3-17-0.17039; Vmbus
version:3.0
[ 82.598859] BUG: unable to handle kernel paging req
From: Vitaly Kuznetsov <[mailto:vkuzn...@redhat.com]>
On driver shutdown device_obj is being freed twice:
1) In vmbus_free_channels()
2) vmbus_device_release() (which is being triggered by device_unregister() in
vmbus_device_unregister().
This double kfree leads to the following sporadic crash
From: Vitaly Kuznetsov <[mailto:vkuzn...@redhat.com]>
It looks like clockevents_unbind is being exported by mistake as:
- it is static;
- it is not listed in include/linux/clockchips.h;
- EXPORT_SYMBOL_GPL(clockevents_unbind) follows clockevents_unbind_device()
implementation.
I think clockeven
From: Vitaly Kuznetsov
When an SMP Hyper-V guest is running on top of 2012R2 Server and secondary
cpus are sent offline (with echo 0 > /sys/devices/system/cpu/cpu$cpu/online)
the system freeze is observed. This happens due to the fact that on newer
hypervisors (Win8, WS2012R2, ...) vmbus channel
From: Vitaly Kuznetsov <[mailto:vkuzn...@redhat.com]>
All channel work queues are named 'hv_vmbus_ctl', this makes them
indistinguishable in ps output and makes it hard to link to the corresponding
vmbus device. Rename them to hv_vmbus_ctl/N and make vmbus device names match,
e.g. now vmbus_1 devi
From: Jake Oshins <[mailto:ja...@microsoft.com]>
This set of changes finds the _CRS object in the ACPI namespace
that contains memory address space descriptors, intended to convey
to VMBus which ranges of memory-mapped I/O space are available for
child devices, and then builds a resource list that
Windows hosts starting with Ws2012 R2 permit re-establishing the vmbus
connection from the guest. This patch-set includes patches from Vitaly
to cleanup the VMBUS unload path so we can potentially reload the driver.
This set also includes a patch from Jake to correctly extract MMIO
information on
Wrong type in printf format string, requires 'int'
but the argument type is 'unsigned int'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/iio/adc/mxs-lradc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
Wrong type in printf format string, requires 'int'
but the argument type is 'unsigned int'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/iio/resolver/ad2s1210.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions
Wrong type in printf format string, requires 'int'
but the argument type is 'unsigned int'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/iio/magnetometer/hmc5843_core.c |2 +-
1 file changed, 1 insertion(+), 1 dele
Wrong type in printf format string, requires 'int'
but the argument type is 'unsigned int'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/iio/light/tsl2x7x_core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Wrong type in printf format string, requires 'int'
but the argument type is 'unsigned int'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/iio/light/tsl2583.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
Wrong type in printf format string, requires 'int'
but the argument type is 'unsigned int'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/iio/impedance-analyzer/ad5933.c |4 ++--
1 file changed, 2 insertions(+), 2 d
Wrong type in printf format string, requires 'unsigned int'
but the argument type is 'int'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/lustre/lustre/libcfs/nidstrings.c | 10 +-
1 file changed, 5 insertions
Wrong type in printf format string, requires 'unsigned int'
but the argument type is 'int'
This was found using a static code analysis program called cppcheck
Signed-off-by: Rickard Strandqvist
---
drivers/staging/iio/trigger/iio-trig-periodic-rtc.c |2 +-
1 file changed, 1 insertion(+), 1
On Tue, 2015-01-27 at 22:30 +0200, Heba Aamer wrote:
> This patch set fixes most of the checkpatch.pl coding
> style errors found in drivers/staging/fbtft/fb_pcd8544.c
>
> Heba Aamer (6):
> staging: fbtft: fix space required after that ';'
> staging: fbtft: fix spaces required around that '='
This patch fixes the following checkpatch.pl error:
fix trailing whitespace
Signed-off-by: Heba Aamer
---
drivers/staging/fbtft/fb_pcd8544.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft/fb_pcd8544.c
b/drivers/staging/fbtft/fb_pcd8544.c
index
This patch fixes the following checkpatch.pl error:
fix do not initialise statics to 0 or NULL
Signed-off-by: Heba Aamer
---
drivers/staging/fbtft/fb_pcd8544.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_pcd8544.c
b/drivers/staging/fbtft/fb_pc
This patch fixes the following checkpatch.pl error:
fix Macros with complex values should be enclosed in parentheses
Signed-off-by: Heba Aamer
---
drivers/staging/fbtft/fb_pcd8544.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fbtft/fb_pcd8544.c
b/drive
On Tuesday, January 27, 2015 11:17 AM, Ian Abbott wrote:
> Fix a bug in the handling of the 32-bit compatible version of the
> COMEDI_CMD ioctl and tidy up the rest of the 32-bit compatible ioctl
> handling code a bit.
>
> v2: fix minor niggle in patch 1 and drop patch 7.
>
> 1) staging: comedi: co
This patch fixes the following checkpatch.pl error:
fix spaces required around that '<'
Signed-off-by: Heba Aamer
---
drivers/staging/fbtft/fb_pcd8544.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft/fb_pcd8544.c
b/drivers/staging/fbtft/fb_pcd
This patch fixes the following checkpatch.pl error:
fix spaces required around that '='
Signed-off-by: Heba Aamer
---
drivers/staging/fbtft/fb_pcd8544.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft/fb_pcd8544.c
b/drivers/staging/fbtft/fb_pcd
This patch fixes the following checkpatch.pl error:
fix space required after that ';'
Signed-off-by: Heba Aamer
---
drivers/staging/fbtft/fb_pcd8544.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/fbtft/fb_pcd8544.c
b/drivers/staging/fbtft/fb_pcd85
This patch set fixes most of the checkpatch.pl coding
style errors found in drivers/staging/fbtft/fb_pcd8544.c
Heba Aamer (6):
staging: fbtft: fix space required after that ';'
staging: fbtft: fix spaces required around that '='
staging: fbtft: fix spaces required around that '<'
staging:
On Tuesday, January 27, 2015 10:49 AM, Ian Abbott wrote:
> "comedidev.h" includes USB-specific stuff that gets included by all
> comedi drivers including non-USB ones. Separate it out into its own
> header "comedi_usb.h". Make the new header include and
> "comedidev.h" so that comedi USB drivers
Use the usual block comment style.
Signed-off-by: Ian Abbott
---
v2: no change
v3: corrected commit summary line
---
drivers/staging/comedi/comedi_compat32.c | 38
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/comedi/comedi_compa
Bugger! That should be "comedi_compat32.c", not "comedi_compat.c".
--
-=( Ian Abbott @ MEV Ltd.E-mail: )=-
-=( Web: http://www.mev.co.uk/ )=-
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdrive
On Sun, 2015-01-25 at 19:48 +0800, Greg KH wrote:
> On Sat, Jan 17, 2015 at 10:39:53PM +1100, Zachary Warren wrote:
> > Avoids the following warnings from sparse:
> > visorchannel_funcs.c:457:9: warning:
> > context imbalance in 'visorchannel_signalremove' - different lock contexts
> > for basic
Fix a bug in the handling of the 32-bit compatible version of the
COMEDI_CMD ioctl and tidy up the rest of the 32-bit compatible ioctl
handling code a bit.
v2: fix minor niggle in patch 1 and drop patch 7.
1) staging: comedi: comedi_compat32.c: fix COMEDI_CMD copy back
2) staging: comedi: comedi_
`do_cmd_ioctl()` in "comedi_fops.c" handles the `COMEDI_CMD` ioctl.
This returns `-EAGAIN` if it has copied a modified `struct comedi_cmd`
back to user-space. (This occurs when the low-level Comedi driver's
`do_cmdtest()` handler returns non-zero to indicate a problem with the
contents of the `str
`comedi_compat_ioctl()` just calls static inline function `raw_ioctl()`
with the same parameters (although the former returns a `long` and the
latter returns an `int`). Since `raw_ioctl()` is not called from
anywhere else, just absorb its body into `comedi_compat_ioctl()`.
Signed-off-by: Ian Abbo
Use the usual block comment style. Combine some consecutive comments
into block comments. Also remove part of a comment referring to
`ptr_to_compat()` not being implemented until kernel version 2.6.11 as
it's irrelevant.
Signed-off-by: Ian Abbott
---
v2: no change
---
drivers/staging/comedi/co
Use the usual block comment style.
Signed-off-by: Ian Abbott
---
v2: no change
---
drivers/staging/comedi/comedi_compat32.h | 38
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/comedi/comedi_compat32.h
b/drivers/staging/comedi/co
Use the usual block comment style.
Signed-off-by: Ian Abbott
---
v2: no change
---
drivers/staging/comedi/comedi_compat32.c | 38
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/comedi/comedi_compat32.c
b/drivers/staging/comedi/co
Align some comments attached to members of the 32-bit compatibility
structure definitions. These comments describe the original pointer
types that are being represented by a `compat_uptr_t`.
Signed-off-by: Ian Abbott
---
v2: no change
---
drivers/staging/comedi/comedi_compat32.c | 10 +-
This patch introduces the use of function put_unaligned_le16.
This is done using Coccinelle and semantic patch used is as follows:
@a@
typedef u16, __le16, uint16_t;
{u16,__le16,uint16_t} e16;
identifier tmp;
expression ptr;
expression y,e;
type T;
type T;
@@
- tmp = cpu_to_le16(y);
<+... when
On 27/01/15 17:20, Hartley Sweeten wrote:
On Tuesday, January 27, 2015 8:59 AM, Ian Abbott wrote:
On 27/01/15 15:50, Ian Abbott wrote:
`do_cmd_ioctl()` in "comedi_fops.c" handles the `COMEDI_CMD` ioctl.
This returns `-EAGAIN` if it has copied a modified `struct comedi_cmd`
back to user-space.
Include the new "../comedi_usb.h" header instead of and
"../comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/dt9812.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt9812.c
Add a new header that Comedi USB drivers can include instead of
"comedidev.h". Currently, it just pulls in and
"comedidev.h", but the plan is to migrate the USB-specific stuff from
"comedidev.h" here.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedi_usb.h | 30 ++
Include the new "../comedi_usb.h" header instead of and
"../comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/usbduxsigma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/usbdu
Include the new "comedi_usb.h" header instead of and
"comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedi_usb.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/comedi_usb.c
b/drivers/stag
Include the new "../comedi_usb.h" header instead of and
"../comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/vmk80xx.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/vmk80xx.c
"comedidev.h" includes USB-specific stuff that gets included by all
comedi drivers including non-USB ones. Separate it out into its own
header "comedi_usb.h". Make the new header include and
"comedidev.h" so that comedi USB drivers do not need to include them
explicitly.
1) staging: comedi: add
Include the new "../comedi_usb.h" header instead of and
"../comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/usbduxfast.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/usbdux
Include the new "../comedi_usb.h" header instead of and
"../comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/usbdux.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/usbdux.c
Move the USB-specific stuff out of "comedidev.h" into "comedi_usb.h".
Comedi USB drivers now include "comedi_usb.h" instead of "comedidev.h",
which now gets pulled in indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedi_usb.h | 24 ++--
drivers/staging/come
Include the new "../comedi_usb.h" header instead of and
"../comedidev.h", which will now get included indirectly.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/ni_usb6501.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_usb
On Tuesday, January 27, 2015 8:59 AM, Ian Abbott wrote:
> On 27/01/15 15:50, Ian Abbott wrote:
>> `do_cmd_ioctl()` in "comedi_fops.c" handles the `COMEDI_CMD` ioctl.
>> This returns `-EAGAIN` if it has copied a modified `struct comedi_cmd`
>> back to user-space. (This occurs when the low-level Com
SynIC has to be switched off when we unload the module, otherwise registered
memory pages can get corrupted after (as Hyper-V host still writes there) and
we see the following crashes for random processes:
[ 89.116774] BUG: Bad page map in process sh pte:4989c716 pmd:36f81067
[ 89.159454] add
We need to destroy hv_vmbus_con on module shutdown, otherwise the following
crash is sometimes observed:
[ 76.569845] hv_vmbus: Hyper-V Host Build:9600-6.3-17-0.17039; Vmbus
version:3.0
[ 82.598859] BUG: unable to handle kernel paging request at a0003480
[ 82.599287] IP: [] 0xff
It looks like clockevents_unbind is being exported by mistake as:
- it is static;
- it is not listed in include/linux/clockchips.h;
- EXPORT_SYMBOL_GPL(clockevents_unbind) follows clockevents_unbind_device()
implementation.
I think clockevents_unbind_device should be exported instead. This is go
Newly introduced clockevent devices made it impossible to unload hv_vmbus
module as clockevents_config_and_register() takes additional reverence to
the module. To make it possible again we do the following:
- avoid setting dev->owner for clockevent devices;
- implement hv_synic_clockevents_cleanup(
Changes since v1:
- '[PATCH 2/3] Drivers: hv: vmbus: introduce vmbus_acpi_remove' was dropped in
favor of Jake's '[PATCH v2 1/1] drivers:hv:vmbus drivers:hv:vmbus Allow for
more than one MMIO range for children'. It is required to make unload/load
work on Gen2 instances.
- Added '[PATCH v2 3
On driver shutdown device_obj is being freed twice:
1) In vmbus_free_channels()
2) vmbus_device_release() (which is being triggered by device_unregister() in
vmbus_device_unregister().
This double kfree leads to the following sporadic crash on driver unload:
[ 23.469876] general protection fa
On 26/01/15 16:59, Simon Guo wrote:
Correct one coding style problem(detected by checkpatch.pl) in pcl818.c.
- line over 80 characters
Signed-off-by: Simon Guo
---
drivers/staging/comedi/drivers/pcl818.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
Reviewed-by: Ia
On 27/01/15 15:50, Ian Abbott wrote:
`do_cmd_ioctl()` in "comedi_fops.c" handles the `COMEDI_CMD` ioctl.
This returns `-EAGAIN` if it has copied a modified `struct comedi_cmd`
back to user-space. (This occurs when the low-level Comedi driver's
`do_cmdtest()` handler returns non-zero to indicate
[Stripped a non-fully-qualified 'To:' address from the reply.]
On 26/01/15 16:58, Simon Guo wrote:
Correct one coding style problem(detected by checkpatch.pl) in pcl818.c.
- code indent should use tabs where possible
It is fixed by reformatting the comment block to usual comment style.
And wit
Use the usual block comment style. Combine some consecutive comments
into block comments. Also remove part of a comment referring to
`ptr_to_compat()` not being implemented until kernel version 2.6.11 as
it's irrelevant.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedi_compat32.c |
`comedi_compat_ioctl()` just calls static inline function `raw_ioctl()`
with the same parameters (although the former returns a `long` and the
latter returns an `int`). Since `raw_ioctl()` is not called from
anywhere else, just absorb its body into `comedi_compat_ioctl()`.
Signed-off-by: Ian Abbo
The `unlocked_ioctl` and `compat_ioctl` file operations are both defined
to return a `long` (I don't know why). Comedi's `compat_ioctl` handler
`comedi_compat_ioctl()` and its helper functions currently assume the
`unlocked_ioctl` handler return value will fit in an `int` (which it
does, in fact).
Align some comments attached to members of the 32-bit compatibility
structure definitions. These comments describe the original pointer
types that are being represented by a `compat_uptr_t`.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedi_compat32.c | 10 +-
1 file changed,
Fix a bug in the handling of the 32-bit compatible version of the
COMEDI_CMD ioctl and tidy up the rest of the 32-bit compatible ioctl
handling code a bit.
1) staging: comedi: comedi_compat32.c: fix COMEDI_CMD copy back
2) staging: comedi: comedi_compat32.h: reformat copyright comment
3) staging:
Use the usual block comment style.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedi_compat32.c | 38
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/comedi/comedi_compat32.c
b/drivers/staging/comedi/comedi_compat32.c
in
Use the usual block comment style.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/comedi_compat32.h | 38
1 file changed, 19 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/comedi/comedi_compat32.h
b/drivers/staging/comedi/comedi_compat32.h
in
`do_cmd_ioctl()` in "comedi_fops.c" handles the `COMEDI_CMD` ioctl.
This returns `-EAGAIN` if it has copied a modified `struct comedi_cmd`
back to user-space. (This occurs when the low-level Comedi driver's
`do_cmdtest()` handler returns non-zero to indicate a problem with the
contents of the `str
Correct one coding style problem(detected by checkpatch.pl) in pcl818.c.
- line over 80 characters
Signed-off-by: Simon Guo
---
drivers/staging/comedi/drivers/pcl818.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl818.c
b/
Correct one coding style problem(detected by checkpatch.pl) in pcl818.c.
- code indent should use tabs where possible
It is fixed by reformatting the comment block to usual comment style.
And with the reformatting, following coding style problem is also fixed:
- please, no space before tabs
Sign
On 26/01/15 23:01, Jonathan Cameron wrote:
> On 25/01/15 18:47, Marek Vasut wrote:
>> On Sunday, January 25, 2015 at 05:28:18 PM, Kristina Martšenko wrote:
>>> These patches fix some issues with using the touchscreen and reading
>>> other ADC channels at the same time.
>>
>> Entire series
>>
>> Rev
Am 27.01.2015 um 03:42 schrieb Guenter Roeck:
> On 01/26/2015 02:46 PM, Greg Kroah-Hartman wrote:
>> On Mon, Jan 26, 2015 at 01:59:59PM -0800, Guenter Roeck wrote:
>>> On Thu, Jan 22, 2015 at 12:10:33PM -0700, Jim Davis wrote:
make ARCH=i386 allyesconfig fails with
drivers/staging/bu
On 26/01/15 23:17, H Hartley Sweeten wrote:
This series was originally submitted as:
[PATCH 0/5] staging: comedi: das16: tidy up ai command operation
Ian Abbott pointed out some issues in that series with my changes to the
analog input (*do_cmdtest) and (*do_cmd) functions.
This series drops
On 26/01/15 17:25, Hartley Sweeten wrote:
On Monday, January 26, 2015 3:29 AM, Ian Abbott wrote:
On 23/01/15 23:12, H Hartley Sweeten wrote:
The analog input (*do_cmdtest) in this driver currently validates that the
scan_begin_src is TRIG_FOLLOW or, if the board can_burst, TRIG_TIMER or
TRIG_E
On 26/01/15 21:20, H Hartley Sweeten wrote:
commit 92afc2b229038d7b962ae69de5b07bc6c1cf51bf inroduced a logic error
in the DMA size calculation.
If the 'nsamples' is greater than the 'unread_samples' then DMA needs to
be restarted. The current code checks it agains the 'max_samples'.
Signed-off
The subject line is too long.
> - printk(KERN_INFO "r8712u: Staging version\n");
> + pr_info("r8712u: Staging version\n");
This is a dumb thing to print. Just delete this line.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverp
From: Nicholas Mc Guire
Date: Sun, 25 Jan 2015 19:08:37 +0100
> As the if completes with a unconditional goto the else branch
> is not needed here.
>
> Signed-off-by: Nicholas Mc Guire
> ---
>
> v2: added missing subsystem string in subject line - patch unchanged
The feedback you were given w
82 matches
Mail list logo
