On Tue, 20 Jan 2015, Ulf Hansson wrote:
> On 20 January 2015 at 15:47, Lee Jones wrote:
> > On Tue, 23 Dec 2014, micky_ch...@realsil.com.cn wrote:
> >
> >> From: Micky Ching
> >>
> >> Add helper function to write u32 to registers, if we want to put u32
> >> value to 4 continuous register, this c
On Wed, 21 Jan 2015, Roger Tseng wrote:
> On Tue, 2015-01-20 at 16:07 +, Lee Jones wrote:
> > On Tue, 20 Jan 2015, Roger Tseng wrote:
> >
> > > On Mon, 2015-01-19 at 09:45 +, Lee Jones wrote:
> > > > On Thu, 15 Jan 2015, Roger Tseng wrote:
> > > >
> > > > > sd_set_power_mode() in derived
On Tue, 2015-01-20 at 16:07 +, Lee Jones wrote:
> On Tue, 20 Jan 2015, Roger Tseng wrote:
>
> > On Mon, 2015-01-19 at 09:45 +, Lee Jones wrote:
> > > On Thu, 15 Jan 2015, Roger Tseng wrote:
> > >
> > > > sd_set_power_mode() in derived module drivers/mmc/host/rtsx_usb_sdmmc.c
> > > > acqui
On Tue, Jan 20, 2015 at 11:45 PM, Vitaly Kuznetsov
wrote:
Commit 4b2f9abea52a ("staging: hv: convert channel_mgmt.c to not call
osd_schedule_callback")' was written under an assumption that we
never receive
Rescind offer while we're still processing the initial Offer request.
However,
the i
On Tue, Jan 20, 2015 at 11:45 PM, Vitaly Kuznetsov
wrote:
sc_lock spinlock in struct vmbus_channel is being used to not only
protect the
sc_list field, e.g. vmbus_open() function uses it to implement
test-and-set
access to the state field. Rename it to the more generic 'lock' and
add the
d
On Tue, Jan 20, 2015 at 11:45 PM, Vitaly Kuznetsov
wrote:
vmbus_device_create() result is not being checked in
vmbus_process_offer() and
it can fail if kzalloc() fails. Add the check and do minor cleanup to
avoid
additional duplication of "free_channel(); return;" block.
Reported-by: Jason
This set of changes finds the _CRS object in the ACPI namespace
that contains memory address space descriptors, intended to convey
to VMBus which ranges of memory-mapped I/O space are available for
child devices, and then builds a resource list that contains all
those ranges. Without this change,
ARCH_BCM2708 is not present in mainline so remove optimization.
Signed-off-by: Noralf Trønnes
---
drivers/staging/fbtft/fbtft-io.c | 170 ---
1 file changed, 170 deletions(-)
diff --git a/drivers/staging/fbtft/fbtft-io.c b/drivers/staging/fbtft/fbtft-io.c
ind
commit 6e3f62f079 (mfd: core: Fix platform-device id generation) modified
the computation of the mfd cell id. Negative numbers forbit the specification
of cell ids as we do. Fix this for now by specifying a base of 0 instead. In
the long run, this may be changed to automatic cell ids (base -2).
Re
For aesthetics, rename this function and tidy it up.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 35 ++--
1 file changed, 17 insertions(+), 18 deletions(-)
diff --git a/drivers/staging/comedi
Some of the boards supported by this driver have analog outputs. The pci1720
board has 4 analog output channels and the others have 2.
For aesthetics, change the 'n_aochan' member to a bit-field flag 'has_ao' and
refactor the board attach accordingly. Remove the unnecessary initialization
of the s
This function is only called by pci1710_handle_fifo(). Absorb it and clean up
pci1710_handle_fifo().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 64 +---
1 file changed, 29 insertions(+), 35 d
The two step process to transfer the ai samples in pci1710_handle_fifo() doesn't
make any sense. If the async buffer does not have enough room for the samples
the
core will set the async event COMEDI_CB_OVERFLOW which will cause the async
command
to cancel. Splitting the transfer doesn't add any
The analog output resolution is always 12-bits in this driver. Remove the
unnecessary boardinfo.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/dri
The pci1710_handle_every_sample() and pci1710_handle_fifo() helpers, called by
the interrupt handler, both have multiple comedi_handle_events() calls. Remove
these and just do a single comedi_handle_events() at the end of the interrupt
handler.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc:
For aesthetics, add some whitespace to the digital input and output subdevice
init and rename the support functions. Also remove the unnecessary comment.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 34 +--
The boards supported by this driver have a 4K or 1K FIFO that is used when
reading
analog input samples when running an async command. The maximum number of
samples
in the FIFO is half the FIFO size due to the 2 bytes/sample (12-bit resolution).
For aesthetics, change the 'fifo_half_size' member
Use the new comedi_subdevice 'readback' member and the core provided
(*insn_read) for the readback of the analog output subdevice channels.
The board is "reset" prior to the subdevice init. Part of this reset
sets all the analog output channels to 0V. Move the initialization of
the 'readback' valu
The 'cardtype' in the boardinfo is only used to:
1) determine if the board is a pci1720 during the attach of the driver
and when reseting the board
2) determine is the board is not a pci1713 when checking for analog input
data dropout
There is also an unnecessary use of the 'cardtype' w
For aesthetics, rename this function and tidy it up.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 45 +++-
1 file changed, 17 insertions(+), 28 deletions(-)
diff --git a/drivers/staging/comedi
The 'n_counter' member of the boardinfo is actually a flag indicating that the
board exposes a single channel counter subdevice.
For aesthetics, change the 'n_counter' member to a bit-field flag 'has_counter'
and refactor the board attach accordingly.
Remove the unnecessary initialization of the
For aesthetics, add some whitespace to the counter subdevice init and
rename the support functions. Also remove the unnecessary comments.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 31 ++--
1
Rename this function so it has namespace associated with the driver.
Tidy up the code to clarify the function. Remove the unnecessary static const
array muxonechan[].
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 51 +
Remove the remaining, unnecessary, function separation comments.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 15 ---
1 file changed, 15 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci171
For aesthetics, add some whitespace to the analog output subdevice init.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/
For aesthetics, rename all the 'this_board' local variables to simply
'board'. That's more common in comed drivers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 58 ++--
1 file changed, 29 inse
The boards that have digital inputs and outputs always have 16 input channels
and
16 output channels.
Replace the 'n_dichan' and 'n_dochan' members of the boardinfo with the
fit-field
flag 'has_di_do' and refactor the board attach accordingly.
Remove the unnecessary initialization of the subdev
Change the MODULE_DESCRIPTION to something more useful than the generic
"Comedi low-level driver".
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
This parameter is not used in the function. It was only used in some debug
messages that were previously removed. Remove the parameter.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 6 +++---
1 file changed, 3 insertio
For aesthetics, add some whitespace to the analog input subdevice init and
rename the (*insn_read) support function. Also remove the unnecessary comments.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 35 --
For aesthetics, rename this member of the boardinfo to 'has_irq' and change
it to a bit-field flag.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff
The analog input resolution is always 12-bits in this driver. Remove the
unnecessary boardinfo.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/dri
This boardinfo is not necessary. All the boards with analog outputs have
the same range options except for the pci1720 board. That board type is
already handled specially during the driver attach.
Remove the boardinfo and add the subdevice range_table initialization in
the cardtype switch.
Rename
This driver saves the channel list of a scan in the private data and uses
that list to check analog input samples for data dropout.
Currently the channel numbers are shifted 12 bits so that they match the
channel number in the samples that are read from the board. All of the
shifts make the driver
Introduce a helper function to read an analog input sample, check for
channel dropout, and mask the sample to the maxdata of the subdevice.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 68 ++--
The 'n_aichand' member of the boardinfo is actually a flag indicating that the
board supports differential analog inputs. The number of channels is always
half the single-ended number of channels.
For aesthetics, change the 'n_aichand' member to a bit-field flag 'has_diff_ai'.
Signed-off-by: H Ha
The minimum analog input conversion time is 1 ns for all board types. Remove
this unnecessary boardinfo.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
Following is the initial cleanup of the comedi adv_pci1710 driver.
H Hartley Sweeten (28):
staging: comedi: adv_pci1710: change boardinfo 'n_counter' to 'has_counter'
staging: comedi: adv_pci1710: simplify digital input and output boardinfo
staging: comedi: adv_pci1710: rename boardinfo 'hav
On 20 January 2015 at 15:47, Lee Jones wrote:
> On Tue, 23 Dec 2014, micky_ch...@realsil.com.cn wrote:
>
>> From: Micky Ching
>>
>> Add helper function to write u32 to registers, if we want to put u32
>> value to 4 continuous register, this can help us reduce tedious work.
>>
>> Signed-off-by: Mi
On Tue, Jan 20, 2015 at 12:34:43PM -0800, Brian Norris wrote:
> On Thu, Jan 15, 2015 at 07:47:24PM +0900, Masanari Iida wrote:
> > This patch fix a spelling typo in Kconfig.
> >
> > Signed-off-by: Masanari Iida
>
> Acked-by: Brian Norris
>
> Greg, do you take these patches, or should they go t
> -Original Message-
> From: Jake Oshins [mailto:ja...@microsoft.com]
> Sent: Tuesday, January 20, 2015 2:00 PM
> To: gre...@linuxfoundation.org; KY Srinivasan; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de;
> a...@canonical.com; vkuzn...@redhat.com
> Cc: J
On Tue, Jan 20, 2015 at 01:59:40PM -0800, Jake Oshins wrote:
> Signed-off-by: Jake Oshins
No changelog body explaining why this is needed and what it fixes?
Please redo.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverpr
Signed-off-by: Jake Oshins
---
drivers/hv/vmbus_drv.c | 85 +
drivers/video/fbdev/hyperv_fb.c | 2 +-
include/linux/hyperv.h | 2 +-
3 files changed, 72 insertions(+), 17 deletions(-)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmb
On 20/01/15 08:52, Lars-Peter Clausen wrote:
> On 01/20/2015 08:25 AM, Asaf Vertz wrote:
>> Fixed the following warnings (reported by cppcheck):
>> [drivers/staging/iio/impedance-analyzer/ad5933.c:363]: (warning) %d in
>> format string (no. 1)
>> requires 'int' but the argument type is 'unsigned i
On 20/01/15 10:43, Asaf Vertz wrote:
> Fixed the following warnings (reported by cppcheck):
> [drivers/staging/iio/light/tsl2583.c:695]: (warning) %d in format string (no.
> 1)
> requires 'int' but the argument type is 'unsigned int'.
> [drivers/staging/iio/light/tsl2583.c:695]: (warning) %d in fo
On Thu, Jan 15, 2015 at 07:47:24PM +0900, Masanari Iida wrote:
> This patch fix a spelling typo in Kconfig.
>
> Signed-off-by: Masanari Iida
Acked-by: Brian Norris
Greg, do you take these patches, or should they go through me?
FWIW, we have high hopes to kill and replace this driver soon, as
This patch fixes the following sparse warnings:
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:51:3:warning:
symbol 'll_rpc_opcode_table' was not declared. Should it be static?
drivers/staging/lustre/lustre/ptlrpc/lproc_ptlrpc.c:142:3: warning:
symbol 'll_eopcode_table' was not declared. Sh
Applies against next-20150120.
Add __acquires() and __releases() function annotations, to fix sparse warnings
related to lock context imbalance.
This patch fixes the following warnings:
drivers/staging/lustre//lustre/libcfs/linux/linux-tracefile.c:153:5: warning:
context imbalance in
On Tue, Jan 20, 2015 at 07:50:31PM +0100, Noralf Trønnes wrote:
> Hi,
>
> I can't get my name: Noralf Trønnes, to come out correctly in From when I
> format and send a patch. The 'ø' becomes a question mark when received
> in my email client.
>
> This is the head of the patch generated by git for
These "polling" functions are not implemented in the comedi core. Remove the
unnecessary prototypes.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/comedidev.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/comedi/come
This driver can acquire analog input samples during the async command with
DMA, by using the FIFO, or sample-by-sample using the End-Of-Conversion
interrupt. All three methods do the following sequence:
1) check for channel dropout
2) add the sample to the async buffer
3) advance the channel
Hardware errors should be reported with the COMEDI_CB_ERROR event. This event
will cause the async command to cancel. It's not necessary to also set the
COMEDI_CB_EOA event. Remove these events.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/d
Following are a couple random comedi cleanup patches that I have had
hanging around.
H Hartley Sweeten (6):
staging: comedi: comedidev.h: remove unused "minor bits" information
staging: comedi: comedidev.h: remove unused "polling" function prototypes
staging: comedi: comedidev.h: add namespa
The enum comedi_minor_bits and the COMEDI_SUBDEVICE_MINOR_{SHIFT,OFFSET}
defines are not used. Remove them.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/comedidev.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/stag
Tidy up and document the subdevice "runflags". Rename them so they have
comedi namespace.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/comedi_fops.c | 30 ++
drivers/staging/comedi/comedidev.h | 25 +
In das16_interrupt(), use COMEDI_CB_CANCEL_MASK to determine if the async
command is still running and the dma needs to be re-enabled. This will
cause the driver not re-enable the dma if the async buffer overflows
(COMEDI_CB_OVERFLOW), a hardware error occurs (COMEDI_CB_ERROR), or the
command compl
This driver is a mess. It violates the comedi API so much that I doubt
anything actually works.
Drop the addi-data/hwdrv_apci1500.c file and rewrite the subdevice support
functions.
This board has 16 digital inputs (subdevice 0) and 16 digital outputs
(subdevice 1).
It also has three 16-bit time
Modify the sample data returned by the async command to include the current
state of the digital inputs. Otherwise the command needs to be canceled in
order for the user to do an (*insn_bits) operation to check the digital
inputs.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Ha
Hi,
I can't get my name: Noralf Trønnes, to come out correctly in From when I
format and send a patch. The 'ø' becomes a question mark when received
in my email client.
This is the head of the patch generated by git format-patch:
From b2a4f6abdb097c4dc092b56995a2af8e42fbea79 Mon Sep 17 00:00:00
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Tuesday, January 20, 2015 7:45 AM
> To: KY Srinivasan; de...@linuxdriverproject.org
> Cc: Haiyang Zhang; linux-ker...@vger.kernel.org; Dexuan Cui; Jason Wang;
> Radim Krčmář; Dan Carpenter
> Subject: [PATCH
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Tuesday, January 20, 2015 7:45 AM
> To: KY Srinivasan; de...@linuxdriverproject.org
> Cc: Haiyang Zhang; linux-ker...@vger.kernel.org; Dexuan Cui; Jason Wang;
> Radim Krčmář; Dan Carpenter
> Subject: [PATCH
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Tuesday, January 20, 2015 7:45 AM
> To: KY Srinivasan; de...@linuxdriverproject.org
> Cc: Haiyang Zhang; linux-ker...@vger.kernel.org; Dexuan Cui; Jason Wang;
> Radim Krčmář; Dan Carpenter
> Subject: [PATCH
On Tue, 2015-01-20 at 16:08 +0200, Mohamed Lotfy Hammad wrote:
> This patch fixes the following checkpatch.pl warning:
> fix line over 80 characters
[]
> diff --git a/drivers/staging/dgnc/dgnc_driver.c
> b/drivers/staging/dgnc/dgnc_driver.c
[]
> @@ -54,14 +54,14 @@ MODULE_SUPPORTED_DEVICE("dgnc")
Hi,
Thanks for the patch.
On Wed, Jan 14, 2015 at 9:46 PM, Aya Mahfouz
wrote:
> This patch fixes the following checkpatch.pl warning:
>
> space prohibited before semicolon
>
> Signed-off-by: Aya Mahfouz
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
> ---
> v1: This patch applies to Greg
Hi,
On Wed, Jan 21, 2015 at 4:52 AM, Ahmad Hassan wrote:
> This patch fixes the following checkpatch.pl error:
> fix space prohibited before that ',' at line 904
Thanks for the patch, but there already exists a patch [1] fixing this.
[1] https://patchwork.linuxtv.org/patch/27912/
Thanks,
--Pra
This patch fixes the following checkpatch.pl error:
fix space prohibited before that ',' at line 904
Signed-off-by: Ahmad Hassan
---
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.
On Tue, 20 Jan 2015, Roger Tseng wrote:
> On Mon, 2015-01-19 at 09:45 +, Lee Jones wrote:
> > On Thu, 15 Jan 2015, Roger Tseng wrote:
> >
> > > sd_set_power_mode() in derived module drivers/mmc/host/rtsx_usb_sdmmc.c
> > > acquires dev_mutex and then calls pm_runtime_get_sync() to make sure th
vmbus_device_create() result is not being checked in vmbus_process_offer() and
it can fail if kzalloc() fails. Add the check and do minor cleanup to avoid
additional duplication of "free_channel(); return;" block.
Reported-by: Jason Wang
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/channel_mg
This patch series is a renamed successor of "[PATCH] Drivers: hv: vmbus:
serialize Offer and Rescind offer processing".
Changes from v2:
- Rename labels in vmbus_process_offer() ("out" -> "done_init_rescind" in
PATCH 3/3, "error" -> "err_free_chan" in PATCH 1/3) [Dan Carpenter]
- Invert conditio
sc_lock spinlock in struct vmbus_channel is being used to not only protect the
sc_list field, e.g. vmbus_open() function uses it to implement test-and-set
access to the state field. Rename it to the more generic 'lock' and add the
description.
Signed-off-by: Vitaly Kuznetsov
---
drivers/hv/chann
Commit 4b2f9abea52a ("staging: hv: convert channel_mgmt.c to not call
osd_schedule_callback")' was written under an assumption that we never receive
Rescind offer while we're still processing the initial Offer request. However,
the issue we fixed in 04a258c162a8 could be caused by this assumption n
From: Ken Depro
This patch fixes checkpatch checks where the logical operator should be at the
end of the line above, not beginning the next line.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c | 38
1 file
From: Ken Depro
This patch fixes CamelCase function names in virthba.c, reported by the
checkpatch script:
doDiskAddRemove --> do_disk_add_remove
SendDiskAddRemove --> send_disk_add_remove
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c
Fix CamelCase local variable name:
pChannelHeader => channel_header
Update references to use the new name.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/unisys/virthba/virth
From: Ken Depro
This patch fixes a warning generated during the checkpatch script that stated
"else not useful after return". I modified the code to return a designated
status at the end of the function, and replaced the return statement in the
"else if" to set the status accordingly.
Signed-of
From: Ken Depro
This patch removes all unnecessary spaces after casts, as reported by the
checkpatch script.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c | 130 +++
1 file changed, 65 insertions(+), 65 deletion
From: Ken Depro
This patch removes unnecessary blank lines either before opening braces or
after closing braces, as reported by the checkpatch script.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c | 4
1 file changed, 4 deletions(-)
From: Ken Depro
This patch fixes the remaining CamelCase global variables in virthba.c reported
by the checkpatch script:
MaxBuffLen --> max_buff_len
VirtHbasOpen --> virthbas_open
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c | 25 +++
From: Ken Depro
This patch fixes the Disk Add/Remove (DAR) related CamelCase global
variables in virthba.c, reported by the checkpatch script:
DARWorkQ --> dar_work_queue
DARWorkQHead --> dar_work_queue_head
DARWorkQLock --> dar_work_queue_lock
DARWorkQSched --> dar_work_queue_sched
Sign
Fix CamelCase names:
virthba_ISR => virthba_isr
pChannelHeader => channel_header
Update all references to the modified names.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/driver
From: Ken Depro
This patch changes a couple of kzalloc calls to pass the variable name to the
call, rather than the variable struct type. This is a result of checks
generated during the checkpatch script.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virth
This patch set cleans up warnings, errors, and strict checks generated by
checkpatch.pl against the virthba driver.
Some of these patches were submitted as part of a larger set, but they were not
considered due to an earlier patch in the set not being accepted. Those patches
have been reworked sli
From: Ken Depro
This patch fixes warnings generated by checkpatch script regarding lines
over 80 characters long.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/s
From: Ken Depro
This patch fixes the "alignment should match open parenthesis" checks from the
checkpatch script.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c | 43
1 file changed, 22 insertions(+), 21 del
From: Ken Depro
This patch fixes a couple small issues reported by the checkpatch script:
Adds a blank line after a struct definition.
Removes unnecessary parentheses surrounding a dereference of a struct member.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/u
From: Ken Depro
This patch fixes a couple checkpatch checks where alignment of the parameters
did not match the open parenthesis of the function.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c | 6 --
1 file changed, 4 insertions(+), 2
Fix CamelCase variable name:
Features_addr => features_addr
Update references to use the new name.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/unisys/virthba/virthba.
On Tue, 23 Dec 2014, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> Add helper function to write u32 to registers, if we want to put u32
> value to 4 continuous register, this can help us reduce tedious work.
>
> Signed-off-by: Micky Ching
> Acked-by: Lee Jones
> ---
> include/lin
This patch fixes the following checkpatch.pl warning:
fix line over 80 characters
Signed-off-by: Mohamed Lotfy Hammad
---
drivers/staging/dgnc/dgnc_driver.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drivers/staging
Den 20.01.2015 09:46, skrev Paul Bolle:
Thomas, Noralf,
Your commit c296d5f9957c ("staging: fbtft: core support") is included in
today's linux-next (ie, next-20150120). I noticed because a script I use
to check linux-next spotted a problem in it.
See, that commit adds
On Mon, 2015-01-19 at 09:45 +, Lee Jones wrote:
> On Thu, 15 Jan 2015, Roger Tseng wrote:
>
> > sd_set_power_mode() in derived module drivers/mmc/host/rtsx_usb_sdmmc.c
> > acquires dev_mutex and then calls pm_runtime_get_sync() to make sure the
> > device is awake while initializing a newly in
On 20/01/15 02:42, Chase Southwood wrote:
Checkpatch doesn't like kmalloc with multiply very much:
drivers/staging/comedi/drivers/das1800.c:1377: WARNING: Prefer kmalloc_array
over kmalloc with multiply
So this patch swaps that use out for kmalloc_array instead.
Signed-off-by: Chase Southwood
Fine. Fine. I saw the 3/3 patch after I wrote the email. Anyway I
hope that my ranting has planted a seed of doubt and from now you will
begin to view "out" labels with suspicion which will eventually flourish
into the flower of hatred.
regards,
dan carpenter
__
Fixed the following warnings (reported by cppcheck):
[drivers/staging/iio/light/tsl2583.c:695]: (warning) %d in format string (no. 1)
requires 'int' but the argument type is 'unsigned int'.
[drivers/staging/iio/light/tsl2583.c:695]: (warning) %d in format string (no. 2)
requires 'int' but the argum
On Tue, 20 Jan 2015, 敬锐 wrote:
> On 01/19/2015 03:47 PM, Lee Jones wrote:
> > On Mon, 19 Jan 2015, 敬锐 wrote:
> >> >On 01/18/2015 08:29 PM, Lee Jones wrote:
> >>> > >On Thu, 15 Jan 2015,micky_ch...@realsil.com.cn wrote:
> >>> > >
> > >>From: Micky Ching
> > >>
> > >>update phy regist
Dan Carpenter writes:
> On Mon, Jan 19, 2015 at 05:56:11PM +0100, Vitaly Kuznetsov wrote:
>> vmbus_device_create() result is not being checked in vmbus_process_offer()
>> and
>> it can fail if kzalloc() fails. Add the check and do minor cleanup to avoid
>> additional duplication of "free_channel
Fixed the following warnings (reported by cppcheck):
[drivers/staging/iio/light/tsl2x7x_core.c:1150]: (warning) %d in format string
(no. 1)
requires 'int' but the argument type is 'unsigned int'.
[drivers/staging/iio/light/tsl2x7x_core.c:1150]: (warning) %d in format string
(no. 2)
requires 'int'
On 01/20/2015 08:25 AM, Asaf Vertz wrote:
Fixed the following warnings (reported by cppcheck):
[drivers/staging/iio/impedance-analyzer/ad5933.c:363]: (warning) %d in format
string (no. 1)
requires 'int' but the argument type is 'unsigned int'.
[drivers/staging/iio/impedance-analyzer/ad5933.c:367
Thomas, Noralf,
Your commit c296d5f9957c ("staging: fbtft: core support") is included in
today's linux-next (ie, next-20150120). I noticed because a script I use
to check linux-next spotted a problem in it.
See, that commit adds two checks for CONFIG_ARCH_BCM2708. But there'
99 matches
Mail list logo
