On Monday, January 19, 2015 at 08:20:31 AM, Juergen Borleis wrote:
> Hi Kristina,
Hi all,
> On Saturday 17 January 2015 01:22:10 Kristina Martšenko wrote:
> > Reading a channel through sysfs, or starting a buffered capture, can
> > occasionally turn off the touchscreen.
> > [...]
>
> I have my o
On Mon, 19 Jan 2015, 敬锐 wrote:
>
> On 01/18/2015 08:39 PM, Lee Jones wrote:
> > On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
> >
> >> From: Micky Ching
> >>
> >> Re-format coding-style, using uniform SPC after "#define" keyword
> >> instead of mixing using TAB and SPC.
> > Tabs and spa
On Mon, 19 Jan 2015, 敬锐 wrote:
> On 01/18/2015 08:29 PM, Lee Jones wrote:
> > On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
> >
> >> From: Micky Ching
> >>
> >> update phy register value and using direct value instead of macros.
> >> It is much easier to debug using constant value than a
On Mon, 19 Jan 2015, 敬锐 wrote:
>
> On 01/18/2015 07:13 PM, Lee Jones wrote:
> >> @@ -97,7 +97,7 @@ static void rts5249_force_power_down(struct rtsx_pcr
> >> *pcr, u8 pm_state)
> >> > rtsx_pci_write_register(pcr, AUTOLOAD_CFG_BASE + 3, 0x01, 0);
> >> >
> >> > if (pm_state == H
On Mon, 19 Jan 2015, 敬锐 wrote:
>
> On 01/18/2015 08:20 PM, Lee Jones wrote:
> >> +static int rts524a_optimize_phy(struct rtsx_pcr *pcr)
> >> >+{
> >> >+ int err;
> >> >+
> >> >+ err = rtsx_pci_write_register(pcr, RTS524A_PM_CTRL3,
> >> >+ D3_DELINK_MODE_EN, 0x00);
> >> >+ if (err < 0)
> >
On Mon, 19 Jan 2015, 敬锐 wrote:
>
> On 01/18/2015 08:20 PM, Lee Jones wrote:
> >> +};
> >> >+
> >> >+void rts524a_init_params(struct rtsx_pcr *pcr)
> >> >+{
> >> >+ rts5249_init_params(pcr);
> >> >+
> >> >+ pcr->ops = &rts524a_pcr_ops;
> >> >+}
> > I see a couple of these now. Why don't you make
This is only an API consolidation and should make things more readable
Signed-off-by: Nicholas Mc Guire
---
Converting milliseconds to jiffies by val * HZ / 1000 is technically
not wrong but msecs_to_jiffies(val) is the cleaner solution and handles
corner cases correctly.
This patch was only co
Hi Kristina,
On Saturday 17 January 2015 01:22:10 Kristina Martšenko wrote:
> Reading a channel through sysfs, or starting a buffered capture, can
> occasionally turn off the touchscreen.
> [...]
I have my old ChumbyOne around (i.MX23). How to test this buffered capture
while using the touchscre
On 01/18/2015 08:20 PM, Lee Jones wrote:
>> +};
>> >+
>> >+void rts524a_init_params(struct rtsx_pcr *pcr)
>> >+{
>> >+ rts5249_init_params(pcr);
>> >+
>> >+ pcr->ops = &rts524a_pcr_ops;
>> >+}
> I see a couple of these now. Why don't you make 'ops' a parameter of
> *_init_params().
>
*_init_p
On 01/18/2015 07:13 PM, Lee Jones wrote:
>> @@ -97,7 +97,7 @@ static void rts5249_force_power_down(struct rtsx_pcr *pcr,
>> u8 pm_state)
>> >rtsx_pci_write_register(pcr, AUTOLOAD_CFG_BASE + 3, 0x01, 0);
>> >
>> >if (pm_state == HOST_ENTER_S3) {
>> >- if (PCI_PID(pcr) == 0x524A
On 01/18/2015 08:20 PM, Lee Jones wrote:
>> +static int rts524a_optimize_phy(struct rtsx_pcr *pcr)
>> >+{
>> >+ int err;
>> >+
>> >+ err = rtsx_pci_write_register(pcr, RTS524A_PM_CTRL3,
>> >+ D3_DELINK_MODE_EN, 0x00);
>> >+ if (err < 0)
>> >+ return err;
> if (err)
>
err
On 01/18/2015 08:20 PM, Lee Jones wrote:
>> @@ -72,8 +72,10 @@ static void rts5249_fetch_vendor_settings(struct rtsx_pcr
>> *pcr)
>> >rtsx_pci_read_config_dword(pcr, PCR_SETTING_REG1, ®);
>> >dev_dbg(&(pcr->pci->dev), "Cfg 0x%x: 0x%x\n", PCR_SETTING_REG1, reg);
>> >
>> >- if (!rtsx_ve
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Sun, Jan 18, 2015 at 07:47:50PM +0530, jitendra kumar khasdev wrote:
> Will you give reason for not apply my patch on your tree. I have
> tested by appling on linux main tree.
Probably because some
On Sun, Jan 18, 2015 at 01:00:31PM +0100, Noralf Tronnes wrote:
> Den 18.01.2015 03:54, skrev Greg KH:
> >On Sun, Jan 18, 2015 at 03:26:56AM +0100, Noralf Tronnes wrote:
> >>When I started this rewrite I didn't anticipate fbtft entering the kernel,
> >>and to me it was easier to just start from scr
On 01/18/2015 08:29 PM, Lee Jones wrote:
> On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
>
>> From: Micky Ching
>>
>> update phy register value and using direct value instead of macros.
>> It is much easier to debug using constant value than a lot of macros.
>> We usually need compare th
On 01/18/2015 08:39 PM, Lee Jones wrote:
> On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
>
>> From: Micky Ching
>>
>> Re-format coding-style, using uniform SPC after "#define" keyword
>> instead of mixing using TAB and SPC.
> Tabs and spaces in this context usually have different meaning
On 01/18/2015 08:28 PM, Lee Jones wrote:
> On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
>
>> From: Micky Ching
>>
>> To enable/disable ASPM we should find LINK CONTROL register
>> in PCI config space. All old chip use 0x80 address, but new
>> chip may use another address, so we using pc
2015-01-17 22:58 GMT+01:00 Greg Kroah-Hartman :
> On Sun, Dec 21, 2014 at 01:59:39PM +0100, Rickard Strandqvist wrote:
>> Removes some functions that are not used anywhere:
>> rtl8723au_DeInitSwLeds() rtl8723au_InitSwLeds()
>>
>> This was partially found by using a static code analysis program call
Dear Greg Kroah-Hartman,
On Sat, 17 Jan 2015 16:42:45 -0800, Greg Kroah-Hartman wrote:
> > diff --git a/drivers/staging/fbtft/NOTES b/drivers/staging/fbtft/NOTES
> > new file mode 100644
> > index 000..d57c6ef
> > --- /dev/null
> > +++ b/drivers/staging/fbtft/NOTES
> > @@ -0,0 +1,6 @@
> > +Th
Greg Kroah-Hartman writes:
> On Sun, Dec 07, 2014 at 03:37:20PM +0100, Emil Renner Berthing wrote:
>> This also fixes a sparse warning.
>
> What sparse warning? What's wrong with the original code? Unless Jes
> resends this to me, I don't see the need to apply it, sorry.
I agree, I cannot see w
On 2015.01.19 01:38, Ahmadposten wrote:
> ---
> drivers/staging/vt6655/device_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/device_main.c
> b/drivers/staging/vt6655/device_main.c
> index f5cc78e..34e3a76 100644
> --- a/drivers/staging/vt66
Will you give reason for not apply my patch on your tree. I have
tested by appling on linux main tree.
On Sat, Jan 10, 2015 at 10:20:03AM +0530, jitendra kumar khasdev wrote:
> This is patch to pcl812.c that fix line over 80 characters warning
> which is found by checkpatch.pl tool. Reduce the ex
Fixes sparse warnings like:
warning: symbol '...' was not declared. Should it be static?
Signed-off-by: Luca Ceresoli
Cc: Peng Tao
Cc: Jinshan Xiong
Cc: Srikrishan Malik
Cc: hpdd-disc...@lists.01.org
Cc: de...@driverdev.osuosl.org
Cc: linux-ker...@vger.kernel.org
---
drivers/staging/lustre/
Fixes sparse warnings like:
warning: symbol '...' was not declared. Should it be static?
Signed-off-by: Luca Ceresoli
Cc: Peng Tao
Cc: Jinshan Xiong
Cc: Srikrishan Malik
Cc: hpdd-disc...@lists.01.org
Cc: de...@driverdev.osuosl.org
Cc: linux-ker...@vger.kernel.org
---
drivers/staging/lustre/
Fixes sparse warnings like:
warning: symbol '...' was not declared. Should it be static?
Signed-off-by: Luca Ceresoli
Cc: Peng Tao
Cc: Jinshan Xiong
Cc: Srikrishan Malik
Cc: hpdd-disc...@lists.01.org
Cc: de...@driverdev.osuosl.org
Cc: linux-ker...@vger.kernel.org
---
drivers/staging/lustre/
Fixes sparse warnings like:
warning: symbol '...' was not declared. Should it be static?
Signed-off-by: Luca Ceresoli
Cc: Peng Tao
Cc: Jinshan Xiong
Cc: Srikrishan Malik
Cc: hpdd-disc...@lists.01.org
Cc: de...@driverdev.osuosl.org
Cc: linux-ker...@vger.kernel.org
---
drivers/staging/lustre/
Fixes sparse warnings like:
warning: symbol '...' was not declared. Should it be static?
Signed-off-by: Luca Ceresoli
Cc: Peng Tao
Cc: Jinshan Xiong
Cc: Srikrishan Malik
Cc: hpdd-disc...@lists.01.org
Cc: de...@driverdev.osuosl.org
Cc: linux-ker...@vger.kernel.org
---
drivers/staging/lustre/
Fixes sparse warnings like:
warning: symbol '...' was not declared. Should it be static?
Signed-off-by: Luca Ceresoli
Cc: Peng Tao
Cc: Jinshan Xiong
Cc: Srikrishan Malik
Cc: hpdd-disc...@lists.01.org
Cc: de...@driverdev.osuosl.org
Cc: linux-ker...@vger.kernel.org
---
drivers/staging/lustre/
Hi,
this small patch series fixes dozens of sparse warnings like:
warning: symbol '...' was not declared. Should it be static?
I previously sent it as one larger patch [1], but Greg couldn't apply it to his
staging-next because other patches had fixed some of the same issues in the
meantime. So
Dear Greg,
Greg Kroah-Hartman wrote:
On Tue, Jan 13, 2015 at 11:33:03PM +0100, Luca Ceresoli wrote:
Fixes dozens of sparse warnings like:
warning: symbol 'cfs_tracefile_sem' was not declared. Should it be static?
Signed-off-by: Luca Ceresoli
Cc: Peng Tao
Cc: Jinshan Xiong
Cc: Srikrishan
This patch fixes the following checkpatch.pl error:
fix space prohibited before that ','
---
drivers/staging/vt6655/mac.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/mac.c b/drivers/staging/vt6655/mac.c
index 63c9c7e..3653a2b 100644
--- a/drivers/
On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> Re-format coding-style, using uniform SPC after "#define" keyword
> instead of mixing using TAB and SPC.
Tabs and spaces in this context usually have different meanings
i.e. space after #define usually denotes that t
---
drivers/staging/vt6655/device_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/device_main.c
b/drivers/staging/vt6655/device_main.c
index f5cc78e..34e3a76 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_mai
The if and the else branch code are identical - so the condition has no
effect on the effective code - this patch removes the condition and the
duplicated code.
Signed-off-by: Nicholas Mc Guire
---
Patch is against 3.19.0-rc4 -next-20150116
This patch was only compile tested with x86_64_defconf
On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> It is more readable to place register address and values define
> togather. The values define add two leading space indicate belong
> to the register address defined above.
>
> Signed-off-by: Micky Ching
> ---
> in
On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> Add debug info when access register failed, this is useful for
> debug.
Pull the creation of the macro into another patch. I'm happy to apply
that, but I don't really want dbg prints scattered everywhere. Feel
free
On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> update card drive settings, This setting can be used for rts5249
> rts524A and rts525A.
>
> Signed-off-by: Micky Ching
> ---
> drivers/mfd/rts5249.c | 12 ++--
> 1 file changed, 6 insertions(+), 6 deletions
On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> PETXCFG is defined at 0xFF03, the old 0xFE49 not used any more.
>
> Signed-off-by: Micky Ching
> ---
> drivers/mfd/rts5227.c| 6 ++
> drivers/mfd/rts5249.c| 6 ++
> include/linux/mfd/rtsx_pc
On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> update phy register value and using direct value instead of macros.
> It is much easier to debug using constant value than a lot of macros.
> We usually need compare the value directly to check the configure.
NACK.
On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> To enable/disable ASPM we should find LINK CONTROL register
> in PCI config space. All old chip use 0x80 address, but new
> chip may use another address, so we using pci_find_capability()
> to get LINK CONTROL address
On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> add support for new chip rts524A.
>
> Signed-off-by: Micky Ching
> ---
> drivers/mfd/rts5249.c| 112
> +++
> drivers/mfd/rtsx_pcr.c | 5 ++
> drivers/mfd/rts
Den 18.01.2015 03:54, skrev Greg KH:
On Sun, Jan 18, 2015 at 03:26:56AM +0100, Noralf Tronnes wrote:
When I started this rewrite I didn't anticipate fbtft entering the kernel,
and to me it was easier to just start from scratch. However I'd much
rather go with proven practices, so I will do as yo
Hi Kristina,
> Kristina Martšenko hat am 17. Januar 2015 um
> 01:22 geschrieben:
>
>
> Hi,
>
> These patches fix some issues with using the touchscreen and reading
> other ADC channels at the same time.
>
> The main issue is that the "virtual" channels the touchscreen uses can
> overlap with the
On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> add support for new chip rts525A.
>
> Signed-off-by: Micky Ching
> ---
> drivers/mfd/rts5249.c | 93
> +-
> drivers/mfd/rtsx_pcr.c | 13 +--
> drivers/mfd/rtsx_
On Thu, 15 Jan 2015, micky_ch...@realsil.com.cn wrote:
> From: Micky Ching
>
> pcr_dbg is a wrapper of dev_dbg, which can save some code,
> and help to enable/disable debug message static.
>
> Signed-off-by: Micky Ching
> ---
> drivers/mfd/rtl8411.c | 11 +--
> drivers/mfd/rts5209.c
This patch fixes warnings/errors raised by checkpatch.pl relating to whitespace
in r8192U_dm.c, removes inconsistent whitespace, and additionally fixes some
vertical alignment issues.
Signed-off-by: Lorenzo Stoakes
---
drivers/staging/rtl8192u/r8192U_dm.c | 1697 +
This patch fixes errors raised by checkpatch.pl relating to use of C99 comments
in r8192U_dm.c, and cleans up existing ANSI C comments.
Signed-off-by: Lorenzo Stoakes
---
drivers/staging/rtl8192u/r8192U_dm.c | 811 ++-
1 file changed, 420 insertions(+), 391 deleti
This patch fixes warnings/errors raised by checkpatch.pl relating to redundant
code in r8192U_dm.c.
Signed-off-by: Lorenzo Stoakes
---
drivers/staging/rtl8192u/r8192U_dm.c | 165 ---
1 file changed, 74 insertions(+), 91 deletions(-)
diff --git a/drivers/staging/r
This patch fixes warnings raised by checkpatch.pl relating to heavily indented
lines in r8192U_dm.c by refactoring code to achieve the same outcome indented by
one less tab.
Signed-off-by: Lorenzo Stoakes
---
drivers/staging/rtl8192u/r8192U_dm.c | 27 ---
1 file changed,
On Sat, 2015-01-17 at 23:57 -0800, Shirish Gajera wrote:
> This patch fixes the checkpatch.pl warning:
>
> WARNING: line over 80 characters
>
> All line over 80 characters in driver/staging/speakup/* are fixed
[...]
It is not important to fix all such warnings. The code seems perfectly
readable
On Sat, Jan 17, 2015 at 11:57:53PM -0800, Shirish Gajera wrote:
> diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c
> index e9f0c15..141abb7 100644
> --- a/drivers/staging/speakup/main.c
> +++ b/drivers/staging/speakup/main.c
> @@ -422,8 +422,10 @@ static void announce_ed
51 matches
Mail list logo
