[PATCH] staging: speakup: Fix warning of line over 80 characters.

2015-01-17 Thread Shirish Gajera
This patch fixes the checkpatch.pl warning: WARNING: line over 80 characters All line over 80 characters in driver/staging/speakup/* are fixed Signed-off-by: Shirish Gajera --- drivers/staging/speakup/main.c | 12 drivers/staging/speakup/serialio.h | 3 ++- driver

[PATCH] staging: lustre: remove kmalloc from fld_proc_hash_seq_write

2015-01-17 Thread Tristan Lelong
This patch simplifies the fld_proc_hash_seq_write function by removing the dynamic memory allocation. The longest fh_name used so far in lustre is 4 characters. We use a 8 bytes variable to be on the safe side. Signed-off-by: Tristan Lelong --- Hi Greg, This patch is a rework of "staging: lustr

[PATCH] MAINTAINERS: add Android driver entries

2015-01-17 Thread Greg KH
Put down me, Arve, and Riley as maintainers for the android drivers. Cc: Arve Hjønnevåg Cc: Riley Andrews Signed-off-by: Greg Kroah-Hartman diff --git a/MAINTAINERS b/MAINTAINERS index 3589d67437f8..95fd5c66ba09 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -708,6 +708,16 @@ X: drivers/iio/*/

[PATCH] staging: wlan-ng: hfa384x_usb: fix sparse endianness warnings

2015-01-17 Thread Asaf Vertz
Fixed the following warnings (reported by sparse): drivers/staging/wlan-ng/hfa384x_usb.c:3828:36: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3229:16: warning: cast to restricted __le16 drivers/staging/wlan-ng/hfa384x_usb.c:3430:18: warning: cast to restricted __le16

Re: [PATCH v3] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2015-01-17 Thread Greg KH
On Sat, Jan 17, 2015 at 10:41:44PM -0800, Tristan Lelong wrote: > Hi Greg, > > On Sat, Jan 17, 2015 at 03:28:27PM -0800, Greg KH wrote: > > > > I took your v2 version, please send me the difference as this is a > > mess... > > Not sure I understand what you meant here. > Do you want me to submi

Re: [PATCH v3] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2015-01-17 Thread Tristan Lelong
Hi Greg, On Sat, Jan 17, 2015 at 03:28:27PM -0800, Greg KH wrote: > > I took your v2 version, please send me the difference as this is a > mess... Not sure I understand what you meant here. Do you want me to submit a new patch that contains only the differences between v2 and v3? Thanks, Reg

Re: [PATCH 00/29] staging: add drivers from the fbtft project

2015-01-17 Thread Greg KH
On Sun, Jan 18, 2015 at 03:26:56AM +0100, Noralf Tronnes wrote: > > When I started this rewrite I didn't anticipate fbtft entering the kernel, > and to me it was easier to just start from scratch. However I'd much > rather go with proven practices, so I will do as you suggest. > > At least the lc

Re: [PATCH 00/29] staging: add drivers from the fbtft project

2015-01-17 Thread Noralf Tronnes
Den 18.01.2015 02:42, skrev Greg KH: On Sun, Jan 18, 2015 at 02:30:17AM +0100, Noralf Tronnes wrote: Den 18.01.2015 01:39, skrev Greg KH: On Mon, Jan 12, 2015 at 06:06:44PM +0100, Noralf Tronnes wrote: Here is a proposal to include in the staging tree the drivers from the fbtft project at http

Re: [PATCH v2] staging: skein: Remove all do{} while (0) loop from single statement.

2015-01-17 Thread Greg KH
On Sat, Jan 17, 2015 at 05:53:23PM -0800, shirish gajera wrote: > On Sat, Jan 17, 2015 at 3:09 PM, Greg KH wrote: > > > > Doesn't apply to my tree :( > > > > > Can I know the reason ? > > So next time it will be helpful, before I submit any new patch Probably because someone else sent the same

[PATCH 1/4] staging: vt6655: correcting function declaration sparse error

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/ LD drivers/staging/vt6655/built-in.o CHECK drivers/staging/vt6655/device_main.c drivers/staging/vt6655/device_main.c:1672:5: warning: symbol 'vnt_init' was not declared. Should it be static? CC [M

[PATCH 4/4] staging: vt6655: correcting parameter related sparse error

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/ LD drivers/staging/vt6655/built-in.o CHECK drivers/staging/vt6655/device_main.c drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 1 (different address spaces) drivers

[PATCH 0/4] staging: vt6655: fixing various sparse problems

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier >From a v3.19-rc4 baseline sparse finds the following errors: LD drivers/staging/vt6655/built-in.o CHECK drivers/staging/vt6655/device_main.c drivers/staging/vt6655/device_main.c:1503:25: warning: incorrect type in argument 1 (different address spaces) drivers/s

[PATCH 3/4] staging: vt6655: fix wrong parameter as reported by sparse

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/ LD drivers/staging/vt6655/built-in.o CHECK drivers/staging/vt6655/device_main.c CC [M] drivers/staging/vt6655/device_main.o CHECK drivers/staging/vt6655/card.c CC [M] drivers/staging/vt6655

[PATCH 2/4] staging: vt6655: removing dead function as reported by sparse

2015-01-17 Thread mathieu . poirier
From: Mathieu Poirier mpoirier@t430:~/work/kernel1$ make C=1 M=drivers/staging/vt6655/ CHECK drivers/staging/vt6655/mac.c drivers/staging/vt6655/mac.c:162:6: warning: symbol 'MACvGetShortRetryLimit' was not declared. Should it be static? CC [M] drivers/staging/vt6655/mac.o Commit: 87299d

Re: [PATCH 00/29] staging: add drivers from the fbtft project

2015-01-17 Thread Greg KH
On Sun, Jan 18, 2015 at 02:30:17AM +0100, Noralf Tronnes wrote: > Den 18.01.2015 01:39, skrev Greg KH: > >On Mon, Jan 12, 2015 at 06:06:44PM +0100, Noralf Tronnes wrote: > >>>Here is a proposal to include in the staging tree the drivers from the > >>>fbtft project at https://github.com/notro/fbtft.

Re: [PATCH 00/29] staging: add drivers from the fbtft project

2015-01-17 Thread Noralf Tronnes
Den 18.01.2015 01:39, skrev Greg KH: On Mon, Jan 12, 2015 at 06:06:44PM +0100, Noralf Tronnes wrote: Here is a proposal to include in the staging tree the drivers from the fbtft project at https://github.com/notro/fbtft. This project contains a number of drivers small TFT LCD display modules, wh

[PATCH v2] staging: rtl8188eu: core: rtw_wlan_util: Remove unused functions

2015-01-17 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: CAM_empty_entry() get_bsstype() rtw_get_oper_choffset() rtw_get_oper_bw() is_ap_in_wep() should_forbid_n_rate() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/st

[PATCH v2] staging: rtl8712: recv_linux: Remove unused function

2015-01-17 Thread Rickard Strandqvist
Remove the function r8712_os_read_port() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8712/recv_linux.c | 14 -- drivers/staging/rtl8712/recv_osdep.h |1 -

[PATCH v2] staging: rtl8723au: core: rtw_cmd: Remove unused functions

2015-01-17 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: rtw_set_ch_cmd23a() rtw_cmd_clr_isr23a() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8723au/core/rtw_cmd.c| 61 --- d

Re: [PATCH 00/29] staging: add drivers from the fbtft project

2015-01-17 Thread Greg Kroah-Hartman
On Wed, Dec 31, 2014 at 10:11:08AM +0100, Thomas Petazzoni wrote: > Hello Greg, > > Here is a proposal to include in the staging tree the drivers from the > fbtft project at https://github.com/notro/fbtft. This project contains > a number of drivers small TFT LCD display modules, which are not > o

Re: [PATCH 29/29] staging: fbtft: add NOTES file

2015-01-17 Thread Greg Kroah-Hartman
On Wed, Dec 31, 2014 at 10:11:37AM +0100, Thomas Petazzoni wrote: > Add a NOTES file that documents which version of the original fbtft > was used, and how the import was done. > > Signed-off-by: Thomas Petazzoni > --- > drivers/staging/fbtft/NOTES | 6 ++ > 1 file changed, 6 insertions(+) >

Re: [PATCH 00/29] staging: add drivers from the fbtft project

2015-01-17 Thread Greg Kroah-Hartman
On Wed, Dec 31, 2014 at 10:11:08AM +0100, Thomas Petazzoni wrote: > Hello Greg, > > Here is a proposal to include in the staging tree the drivers from the > fbtft project at https://github.com/notro/fbtft. This project contains > a number of drivers small TFT LCD display modules, which are not > o

Re: [PATCH 00/29] staging: add drivers from the fbtft project

2015-01-17 Thread Greg KH
On Mon, Jan 12, 2015 at 06:06:44PM +0100, Noralf Tronnes wrote: > > Here is a proposal to include in the staging tree the drivers from the > > fbtft project at https://github.com/notro/fbtft. This project contains > > a number of drivers small TFT LCD display modules, which are not > > otherwise su

[PATCH v2] staging: rtl8723au: os_dep: usb_intf: Remove unused functions

2015-01-17 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: rtw_hw_resume23a() rtw_hw_suspend23a() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8723au/include/osdep_intf.h |3 - drivers/staging/rtl8723au/

Re: [PATCH 1/4] iio: mxs-lradc: separate touchscreen and buffer virtual channels

2015-01-17 Thread Marek Vasut
On Saturday, January 17, 2015 at 01:22:08 AM, Kristina Martšenko wrote: Hi! Good stuff, thank you! Just minor nitpicks below. [...] > diff --git a/drivers/staging/iio/adc/mxs-lradc.c > b/drivers/staging/iio/adc/mxs-lradc.c index e0e91836eec1..fc65cd311be9 > 100644 > --- a/drivers/staging/iio/ad

Re: [PATCH 3/4] iio: mxs-lradc: make ADC reads not unschedule touchscreen conversions

2015-01-17 Thread Marek Vasut
On Saturday, January 17, 2015 at 01:22:10 AM, Kristina Martšenko wrote: > Reading a channel through sysfs, or starting a buffered capture, can > occasionally turn off the touchscreen. > > This is because the read_raw() and buffer preenable()/postdisable() > callbacks unschedule current conversions

Re: [PATCH] Fixed else following return statement warning

2015-01-17 Thread Greg KH
On Wed, Jan 14, 2015 at 05:08:31PM +0530, Asheesh Ranjan wrote: > Fixed an else block following a if block containing return statement warning > found using checkpatch.pl > > Signed-off-by: Asheesh Ranjan > --- > drivers/staging/rtl8192e/rtl819x_HTProc.c | 36 > ++---

Re: [PATCH 4/4] iio: mxs-lradc: only update the buffer when its conversions have finished

2015-01-17 Thread Marek Vasut
On Saturday, January 17, 2015 at 01:22:11 AM, Kristina Martšenko wrote: > Using the touchscreen while running buffered capture results in the > buffer reporting lots of wrong values, often just zeros. This is because > we push readings to the buffer every time a touchscreen interrupt > arrives, inc

Re: [PATCH 2/4] iio: mxs-lradc: make ADC reads not disable touchscreen interrupts

2015-01-17 Thread Marek Vasut
On Saturday, January 17, 2015 at 01:22:09 AM, Kristina Martšenko wrote: > Reading a channel through sysfs, or starting a buffered capture, will > currently turn off the touchscreen. This is because the read_raw() and > buffer preenable()/postdisable() callbacks disable interrupts for all > LRADC ch

Re: [PATCH 3/3] staging: android: struct sizeof coding style in logger.c

2015-01-17 Thread Greg Kroah-Hartman
On Mon, Jan 05, 2015 at 03:25:37PM +0100, Guillaume Vercoutere wrote: > Replace sizeof struct > > Signed-off-by: Guillaume Vercoutere Doesn't apply as I didn't take patch 2, please fix up and resend. thanks, greg k-h ___ devel mailing list de...@linu

Re: [PATCH 2/3] staging: android: Correct NULL comparison style in logger.c

2015-01-17 Thread Greg Kroah-Hartman
On Mon, Jan 05, 2015 at 03:25:23PM +0100, Guillaume Vercoutere wrote: > Replace explicit NULL comparison with ! Not a good idea, you just lost typechecking :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/ma

Re: [PATCH] Staging: slicoss: Fix long line issues in slicoss.c

2015-01-17 Thread Greg KH
On Wed, Dec 03, 2014 at 01:53:18PM +, Sean Cleator wrote: > A patch to the slicoss.c file to fix some of the long line issues found by the > checkpath.pl tool > > Signed-off-by: Sean Cleator > > --- > drivers/staging/slicoss/slicoss.c | 39 > ++- > 1 fi

Re: [PATCH] Staging: wlan-ng: hfa384x_usb: Fix else is not useful warning

2015-01-17 Thread Greg KH
On Thu, Jan 08, 2015 at 03:01:17PM +0100, Sven Dziadek wrote: > This fixes the following checkpatch.pl warning: > WARNING: else is not generally useful after a break or return > > Signed-off-by: Sven Dziadek > --- > drivers/staging/wlan-ng/hfa384x_usb.c | 9 - > 1 file changed, 4 inserti

Re: [PATCH 1/3] Revert "staging: sm7xxfb: remove driver"

2015-01-17 Thread Greg Kroah-Hartman
On Wed, Dec 31, 2014 at 05:56:43PM +0530, Sudip Mukherjee wrote: > This reverts commit "dc93c85235efa5201e9a3c116bc3fbd1afc1a182" > > Signed-off-by: Sudip Mukherjee > --- > > Hi Greg K-H > With reference to our discussion at https://lkml.org/lkml/2014/11/22/54 , > now I have the hardware and I w

Re: [PATCH v3] staging: writeboost: Add dm-writeboost

2015-01-17 Thread Greg KH
On Thu, Jan 01, 2015 at 05:44:39PM +0900, Akira Hayakawa wrote: > This patch adds dm-writeboost to staging tree. > > dm-writeboost is a log-structured SSD-caching driver. > It caches data in log-structured way on the cache device > so that the performance is maximized. > > The merit of putting th

Re: [PATCH] staging: rts5208: Delete unnecessary whitespaces

2015-01-17 Thread Greg KH
On Mon, Jan 05, 2015 at 11:40:01PM +0100, Ana Rey Botello wrote: > Delete unnecessary whitespaces and fix coding style in these lines when > It is necessary. > > Fix checkpatch.pl error: > ERROR: space prohibited before that ',' > > Signed-off-by: Ana Rey Botello > --- > drivers/staging/rts5208

Re: [PATCH] Staging: rts5208: fix space prohibited before ',' error in ms.c

2015-01-17 Thread Greg KH
On Tue, Jan 06, 2015 at 01:29:01AM +1100, Emrys Bayliss wrote: > Fix the checkpatch.pl errors: > ERROR: space prohibited before that ',' (ctx:WxW) > > Signed-off-by: Emrys Bayliss > --- > drivers/staging/rts5208/ms.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) Someone els

Re: [PATCH] Staging: clocking-wizard: Added a blank line after declaration

2015-01-17 Thread Greg KH
On Sat, Dec 20, 2014 at 10:11:56PM -0800, Sören Brinkmann wrote: > Hi Mohammad, > > On Sun, 2014-12-21 at 08:03AM +0530, Mohammad Jamal wrote: > > Fix the coding style issue by adding blank line after declaration > > > > Signed-off-by: Mohammad Jamal > > --- > > .../clocking-wizard/clk-xlnx-clo

Re: [PATCH 2/2] staging: lustre: declare internal symbols as static

2015-01-17 Thread Greg Kroah-Hartman
On Tue, Jan 13, 2015 at 11:33:03PM +0100, Luca Ceresoli wrote: > Fixes dozens of sparse warnings like: > warning: symbol 'cfs_tracefile_sem' was not declared. Should it be static? > > Signed-off-by: Luca Ceresoli > Cc: Peng Tao > Cc: Jinshan Xiong > Cc: Srikrishan Malik > Cc: hpdd-disc...@li

Re: [PATCH] staging: lustre: Fix spacing error in libcfs_string.c

2015-01-17 Thread Greg KH
On Sun, Jan 11, 2015 at 01:44:03PM -0500, Nickolaus Woodruff wrote: > This patch fixes the following checkpatch.pl error in libcfs_string.c: > > ERROR: spaces required around that '=' > > Signed-off-by: Nickolaus Woodruff > --- > drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 2 +- > 1

Re: lustre/lnet/lnet/lib-move.c: memcpy with (struct iovec*)->iov_base, which is __user

2015-01-17 Thread Greg KH
On Wed, Jan 07, 2015 at 02:28:12PM +0200, Andrey Utkin wrote: > 2015-01-07 13:32 GMT+02:00 Dilger, Andreas : > > On 2015/01/07, 1:36 AM, "Dan Carpenter" wrote: > >> Didn't Al change these to kvec instead of iovec? You have to look at > >> the callers to figure out if it's actually a user space po

Re: [PATCH] staging: lustre: do not ignore try_module_get() fail in obd_class_open()

2015-01-17 Thread Greg Kroah-Hartman
On Sat, Dec 27, 2014 at 02:26:53AM +0300, Alexey Khoroshilov wrote: > obd_class_open() ignores error code of try_module_get(), > while it can lead to race with module unload. > > Found by Linux Driver Verification project (linuxtesting.org). > > Signed-off-by: Alexey Khoroshilov > --- > drivers

Re: [PATCH] Staging: lustre: Fix sparse non-static symbol warnings

2015-01-17 Thread Greg KH
On Mon, Dec 08, 2014 at 10:06:28PM +, Tom Wales wrote: > Fixes the following sparse warnings: > > drivers/staging/lustre/lnet/lnet/lib-move.c:565:1: warning: > symbol 'lnet_ni_recv' was not declared. Should it be static? > drivers/staging/lustre/lnet/lnet/lib-move.c:603:1: warning: > symbol 'l

Re: [PATCH v3] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros

2015-01-17 Thread Greg KH
On Sat, Dec 06, 2014 at 04:03:22PM -0800, Tristan Lelong wrote: > This patch fix a sparse warning in lustre sources > > warning: incorrect type in argument 1 (different address spaces) > expected void [noderef] *to > got char * > > This is done by adding the missing __user attribute on us

Re: [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance

2015-01-17 Thread Greg KH
On Sat, Dec 13, 2014 at 03:58:46PM +0100, Loïc Pefferkorn wrote: > > >>> Don't hide "implementation of locks" in functions like this, it only > > >>> causes problems. This code has layers of layers of layers of > > >>> abstractions due to it wanting to be originally ported to other > > >>> operati

Re: [PATCH v2 ] staging: ft1000: fix else style error

2015-01-17 Thread Greg KH
On Tue, Jan 13, 2015 at 10:34:00PM +0100, Bilel DRIRA wrote: > This patch fix the checkpatch.pl error: > > ERROR: else should follow close brace '}' > > Signed-off-by: Bilel DRIRA > --- > v2: remove braces instead of just putting else after close brace. (suggested > by Joe Perches). > >

Re: [PATCH] staging: ft1000: Fix code style issue

2015-01-17 Thread Greg KH
On Wed, Jan 07, 2015 at 12:57:05PM +0530, Arjun AK wrote: > Remove unnecessary braces from single statement blocks. > > Signed-off-by: Arjun AK > --- > drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 101 > --- > 1 file changed, 35 insertions(+), 66 deletions(-) Doesn't

Re: [PATCH v2] staging: skein: Remove all do{} while (0) loop from single statement.

2015-01-17 Thread Greg KH
On Sun, Jan 11, 2015 at 03:41:05PM -0800, Shirish Gajera wrote: > This patch fixes the checkpatch.pl warning: > > WARNING: Single statement macros should not use a do {} while (0) loop > > I remove do while from the single statement macro. > > Signed-off-by: Shirish Gajera > --- > drivers/stag

Re: [PATCH] staging: skein: Fix checkpatch warnings

2015-01-17 Thread Greg KH
On Sat, Jan 10, 2015 at 04:00:47PM +0100, Arno Tiemersma wrote: > Remove do {} while (0) loops around single statements in > skein/skein_block.c > > Signed-off-by: Arno Tiemersma > --- > drivers/staging/skein/skein_block.c | 16 > 1 file changed, 4 insertions(+), 12 deletions(-)

Re: [PATCH] staging: dgnc: fix long lines

2015-01-17 Thread Greg Kroah-Hartman
On Wed, Dec 03, 2014 at 09:17:04AM +0100, Krzysztof Adamski wrote: > This patch fixes checkpatch complains about lines over 80 characters. > > No code was modified, only whitespace changes and comments editing. > > Signed-off-by: Krzysztof Adamski > --- > drivers/staging/dgnc/dgnc_cls.h| 2

Re: [PATCH 3/6] dgnc/dpacompat.h: checkpatch: fixed long lines bei moving comments

2015-01-17 Thread Greg KH
On Mon, Dec 22, 2014 at 02:17:31AM +0100, Simone Weiss wrote: > > Signed-off-by: Simone Weiss > Signed-off-by: Helene Gsaenger > --- > drivers/staging/dgnc/dpacompat.h | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/dgnc/dpacompat.h > b/drivers/s

Re: [PATCH] staging: octeon: Fix checkpatch line spacing warnings

2015-01-17 Thread Greg Kroah-Hartman
On Mon, Jan 12, 2015 at 06:27:38PM +0200, Tero Marttila wrote: > Fix missing blank lines after declarations in octeon/ethernet-rx.c > > Signed-off-by: Tero Marttila > --- > drivers/staging/octeon/ethernet-rx.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/staging/octeon/eth

Re: [PATCH] Staging : gdm724x: Remove space before , in function arguments

2015-01-17 Thread Greg KH
On Sun, Dec 21, 2014 at 08:18:19AM +0530, Mohammad Jamal wrote: > This patch solves space prohibited before , warning in gdm_mux.c > > Signed-off-by: Mohammad Jamal > --- > drivers/staging/gdm724x/gdm_mux.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/stag

Re: [PATCH] Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c

2015-01-17 Thread Greg KH
On Sun, Dec 21, 2014 at 11:44:43AM +0100, Robert Nachlinger wrote: > This is a patch to the gdm_mux.c file that fixes a space before comma > coding style issue found by the checkpatch.pl tool. > > Signed-off-by: Robert Nachlinger > --- > drivers/staging/gdm724x/gdm_mux.c | 2 +- > 1 file changed

Re: [PATCH] Replacing simple_strtoul with kstrtoul

2015-01-17 Thread Greg KH
On Wed, Jan 14, 2015 at 12:00:42PM +0530, Asheesh Ranjan wrote: > Added code to move pointer till end of parsed string as being done by > simple_strtoul. Not checking return value of kstrtoul > Signed-off-by: Asheesh Ranjan > --- > drivers/staging/speakup/varhandlers.c | 17 +++-- >

Re: [PATCH] staging: gdm724x: fix space coding style issue in gdm_mux.c

2015-01-17 Thread Greg KH
On Sun, Jan 04, 2015 at 09:23:44AM +0100, Ning Zhou wrote: > This is a patch to fix a space error found by the checkpatch.pl in > file gdm_mux.c. > > Signed-off-by: Ning Zhou > --- > drivers/staging/gdm724x/gdm_mux.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drive

Re: [PATCH] Fixed else statement following a return statement in if block in hfa384x_usb.c

2015-01-17 Thread Greg KH
On Wed, Jan 14, 2015 at 10:09:04AM +0530, Asheesh Ranjan wrote: > This fixes a else after if block containing return statement warning as found > by checkpatch.pl > > Signed-off-by: Asheesh Ranjan > --- > drivers/staging/wlan-ng/hfa384x_usb.c |9 - > 1 file changed, 4 insertions(+),

Re: [PATCH v3] Staging: vt6656: Checkpatch fix: else after break or return

2015-01-17 Thread Greg KH
On Wed, Jan 14, 2015 at 04:12:58AM +1100, Emrys Bayliss wrote: > This patch fixes the following checkpatch.pl error: > rxtx.c:558: WARNING: else is not generally useful after a break or return > > Signed-off-by: Emrys Bayliss > --- > The else statement was replaced with a block to avoid the follo

Re: [PATCH v7] Staging: comedi: patch to fix line over 80 characters warning

2015-01-17 Thread Greg KH
On Sat, Jan 10, 2015 at 10:20:03AM +0530, jitendra kumar khasdev wrote: > This is patch to pcl812.c that fix line over 80 characters warning > which is found by checkpatch.pl tool. Reduce the extra space around > equal sign that fix warning. > > Signed-off-by: Jitendra kumar khasdev > --- > driv

Re: [PATCH RESEND 1/4] staging: rtl8192u: fix comments

2015-01-17 Thread Greg KH
On Sat, Jan 10, 2015 at 02:19:11PM +, Lorenzo Stoakes wrote: > This patch fixes errors raised by checkpatch.pl relating to use of C99 > comments > in r8192U_dm.c, and cleans up existing ANSI C comments. > > Signed-off-by: Lorenzo Stoakes > --- > drivers/staging/rtl8192u/r8192U_dm.c | 811 >

Re: [PATCH] staging: rtl8712: recv_linux.c: Remove unused function

2015-01-17 Thread Greg Kroah-Hartman
On Sat, Dec 20, 2014 at 03:58:32PM +0100, Rickard Strandqvist wrote: > Remove the function r8712_os_read_port() that is not used anywhere. > > This was partially found by using a static code analysis program called > cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/rtl8

Re: [PATCH] staging: rtl8188eu: core: rtw_wlan_util.c: Remove some unused functions

2015-01-17 Thread Greg Kroah-Hartman
On Sat, Dec 20, 2014 at 05:24:11PM +0100, Rickard Strandqvist wrote: > Removes some functions that are not used anywhere: > CAM_empty_entry() get_bsstype() rtw_get_oper_choffset() > rtw_get_oper_bw() is_ap_in_wep() should_forbid_n_rate() > > This was partially found by using a static code analysis

Re: [PATCH] staging: rtl8723au: hal: rtl8723au_led.c: Remove some unused functions

2015-01-17 Thread Greg Kroah-Hartman
On Sun, Dec 21, 2014 at 01:59:39PM +0100, Rickard Strandqvist wrote: > Removes some functions that are not used anywhere: > rtl8723au_DeInitSwLeds() rtl8723au_InitSwLeds() > > This was partially found by using a static code analysis program called > cppcheck. > > Signed-off-by: Rickard Strandqvi

Re: [PATCH] staging: rtl8723au: core: rtw_cmd.c: Remove some unused functions

2015-01-17 Thread Greg Kroah-Hartman
On Sat, Dec 20, 2014 at 06:10:13PM +0100, Rickard Strandqvist wrote: > Removes some functions that are not used anywhere: > rtw_set_ch_cmd23a() rtw_cmd_clr_isr23a() > > This was partially found by using a static code analysis program called > cppcheck. > > Signed-off-by: Rickard Strandqvist > -

Re: [PATCH] staging: rtl8723au: os_dep: usb_intf.c: Remove some unused functions

2015-01-17 Thread Greg Kroah-Hartman
On Wed, Dec 17, 2014 at 09:36:54PM +0100, Rickard Strandqvist wrote: > Removes some functions that are not used anywhere: > rtw_hw_resume23a() rtw_hw_suspend23a() > > This was partially found by using a static code analysis program called > cppcheck. > > Signed-off-by: Rickard Strandqvist > Sig

Re: [PATCH] drivers: staging: rtl8723au: get rid of unneeded memset/memcpy

2015-01-17 Thread Greg Kroah-Hartman
On Sun, Dec 07, 2014 at 03:37:20PM +0100, Emil Renner Berthing wrote: > This also fixes a sparse warning. What sparse warning? What's wrong with the original code? Unless Jes resends this to me, I don't see the need to apply it, sorry. greg k-h ___ de

Re: [PATCH v8 2/4] fpga manager: add sysfs interface document

2015-01-17 Thread Pavel Machek
Hi! > I'm looking into moving the sysfs interface to debugfs. Doesn't look too > hard and you and Alan are making lots of sense about this. Debugfs: please don't. That's meant for debugging, not for production use. Pavel --

Re: [PATCH] staging: vt6655: mac.c: Remove unused function

2015-01-17 Thread Rickard Strandqvist
2015-01-13 4:34 GMT+01:00 Greg Kroah-Hartman : > On Sun, Dec 07, 2014 at 11:02:44PM +0100, Rickard Strandqvist wrote: >> Remove the function MACbCompareContext() that is not used anywhere. >> >> This was partially found by using a static code analysis program called >> cppcheck. >> >> Signed-off-b

Re: [PATCH] staging: vt6655: mib.c: Remove some unused functions

2015-01-17 Thread Rickard Strandqvist
2015-01-13 4:43 GMT+01:00 Greg Kroah-Hartman : > On Thu, Jan 01, 2015 at 06:18:32PM +0100, Rickard Strandqvist wrote: >> Removes some functions that are not used anywhere: >> STAvClearAllCounter() STAvClear802_11Counter() >> STAvUpdateTDStatCounterEx() STAvUpdateRDStatCounterEx() >> >> This was par

Re: [PATCH] staging: vt6655: srom.c: Remove some unused functions

2015-01-17 Thread Rickard Strandqvist
2015-01-13 4:42 GMT+01:00 Greg Kroah-Hartman : > On Sun, Dec 21, 2014 at 07:03:03PM +0100, Rickard Strandqvist wrote: >> Removes some functions that are not used anywhere: >> SROMbAutoLoad() SROMvReadSubSysVenId() SROMvWriteEtherAddress() >> SROMvWriteAllContents() SROMbIsRegBitsOff() SROMbIsRegBit

Re: [PATCH] Staging: rtl8723au: fix space coding style issue in os_intfs.c

2015-01-17 Thread Greg KH
On Sat, Jan 17, 2015 at 03:52:45PM +0100, Peter Poklop wrote: > From: Peter This name doesn't match up with: > > This patch fixes the checkpatch.pl warning: > > WARNING: space prohibited before semicolon > > Signed-off-by: Peter Poklop this name, why? Please fix up and resend. Or better y

[PATCH] Staging: rtl8723au: fix space coding style issue in os_intfs.c

2015-01-17 Thread Peter Poklop
From: Peter This patch fixes the checkpatch.pl warning: WARNING: space prohibited before semicolon Signed-off-by: Peter Poklop --- drivers/staging/rtl8723au/os_dep/os_intfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8723au/os_dep/os_intfs.c b/dri

Re: [PATCH] staging: unisys: rework signal remove/insert to avoid sparse lock warnings

2015-01-17 Thread zach
On 17/01/15 20:37, Dan Carpenter wrote: > No one wants to follow a link to read the changelog. Just say explain > like "I made a new wrapper around the function that does the locking if > needed and removed the locking from inside the function." > > Otherwise the patch looks good. Could you re-w

[PATCH v2] staging: unisys: rework signal remove/insert to avoid sparse lock warnings

2015-01-17 Thread Zachary Warren
Avoids the following warnings from sparse: visorchannel_funcs.c:457:9: warning: context imbalance in 'visorchannel_signalremove' - different lock contexts for basic block visorchannel_funcs.c:512:9: warning: context imbalance in 'visorchannel_signalinsert' - different lock contexts for basic T

Re: [PATCH] staging: unisys: rework signal remove/insert to avoid sparse lock warnings

2015-01-17 Thread Dan Carpenter
On Sat, Jan 17, 2015 at 08:00:09PM +1100, Zachary Warren wrote: > Avoids the following warnings from sparse: > visorchannel_funcs.c:457:9: warning: > context imbalance in 'visorchannel_signalremove' - different lock contexts > for basic block > visorchannel_funcs.c:512:9: warning: > context imba

[PATCH] staging: unisys: rework signal remove/insert to avoid sparse lock warnings

2015-01-17 Thread Zachary Warren
Avoids the following warnings from sparse: visorchannel_funcs.c:457:9: warning: context imbalance in 'visorchannel_signalremove' - different lock contexts for basic block visorchannel_funcs.c:512:9: warning: context imbalance in 'visorchannel_signalinsert' - different lock contexts for basic T