Re: [PATCH] staging: r8188eu: Fix memory leak in firmware loading

On 01/02/2015 12:17 PM, Larry Finger wrote: The driver allocates memory to store the firmware image; however, that memory is never released. The kmemleak facility was used to find this error. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/hal/fw.c | 1 + 1 file changed, 1 insertio

RE: [PATCH v2] tools: hv: kvp_daemon: make IPv6-only-injection work

> -Original Message- > From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com] > Sent: Friday, January 2, 2015 22:51 PM > To: Dexuan Cui > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redh

Re: [PATCH 1/2] Staging: comedi: tab space coding style issue in pcl818.c

On Sat, 2015-01-03 at 00:04 +0530, jitendra kumar khasdev wrote: > This is patch to the pcl818.c that fix up a use tab error > found by the checkpatch.pl tool [] > diff --git a/drivers/staging/comedi/drivers/pcl818.c > b/drivers/staging/comedi/drivers/pcl818.c [] > @@ -45,7 +45,7 @@ A word or two

RE: [HPDD-discuss] [PATCH] staging: lustre: lustre: include: lustre_update.h: Fix for possible null pointer dereference

Ashley, I sort of understand your larger point, but in this case, I think the purpose of the assert is much better served by the move Rickard is suggesting. Otherwise only one of its conditions will ever trigger. It's not that different to die on the assertion or from a null dereference, but

Re: [PATCH] staging: gs_fpgaboot: io.c: Remove unused function

Reviewed-by: Insop Song Thank you, ISS On Thu, Jan 01, 2015 at 05:23:13PM +0100, Rickard Strandqvist wrote: > Remove the function bitswap() that is not used anywhere. > > This was partially found by using a static code analysis program called > cppcheck. > > Signed-off-by: Rickard Strandqvis

Re: [PATCH] staging: rtl8723au: changes stop ap mode to use reset function

On Fri, Jan 02, 2015 at 10:51:38AM -0500, Jes Sorensen wrote: > Matthew Emerson writes: > > Changes stop_ap_mode23a() to use rtw_reset_securitypriv23a. This makes > > the code cleaner and fixes two checkpatch.pl errors, one line over 80 > > characters, and one spacing issue. > > > > Signed-off-by:

[PATCH 1/2] Staging: comedi: tab space coding style issue in pcl818.c

This is patch to the pcl818.c that fix up a use tab error found by the checkpatch.pl tool Signed-off-by: Jitendra kumar khasdev --- drivers/staging/comedi/drivers/pcl818.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/stagi

Re: [PATCH 2/2] Staging: comedi: fix tab style issue

Jitendra, This is patch 2/2 but there is no 1/2. Or was it that patch you sent earlier? On Fri, Jan 02, 2015 at 09:45:43PM +0530, jitendra kumar khasdev wrote: > This is a patch to pcl818 that fix tab style error which is > found by the checkpatch tool > > Signed-off-by: Jitendra Kumar Khasdev

Re: [PATCH] Staging: comedi: tab space coding style issue in pcl818.c

Jitendra, On Fri, Jan 02, 2015 at 09:37:44PM +0530, jitendra kumar khasdev wrote: > This is patch to the pcl818.c that fix up a use tab error > found by the checkpatch.pl tool > --- Your Signed-off-by is missing. > drivers/staging/comedi/drivers/pcl818.c | 2 +- > 1 file changed, 1 insertion(+),

[PATCH] staging: r8188eu: Fix memory leak in firmware loading

The driver allocates memory to store the firmware image; however, that memory is never released. The kmemleak facility was used to find this error. Signed-off-by: Larry Finger --- drivers/staging/rtl8188eu/hal/fw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/rtl8188eu/hal

[PATCH] cptm1217: check if interrupts are masked at probe

the function cp_tm1217_mask_interrupt can return failure. added the check and the failure path. Cc: Ramesh Agarwal Signed-off-by: Devendra Naga --- build tested only on x86_64. config is allmodconfig. drivers/staging/cptm1217/clearpad_tm1217.c | 6 ++ 1 file changed, 6 insertions(+) dif

Re: [HPDD-discuss] [PATCH] staging: lustre: lustre: include: lustre_update.h: Fix for possible null pointer dereference

Rickard, > On 21 Dec 2014, at 22:43, Rickard Strandqvist > wrote: > > The NULL check was done to late, and there it was a risk > of a possible null pointer dereference. > > This was partially found by using a static code analysis program called > cppcheck. > > Signed-off-by: Rickard Strandq

[PATCH 2/2] Staging: comedi: fix tab style issue

This is a patch to pcl818 that fix tab style error which is found by the checkpatch tool Signed-off-by: Jitendra Kumar Khasdev --- drivers/staging/comedi/drivers/pcl818.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/stagin

[PATCH] Staging: comedi: tab space coding style issue in pcl818.c

This is patch to the pcl818.c that fix up a use tab error found by the checkpatch.pl tool --- drivers/staging/comedi/drivers/pcl818.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c index 8edea35

Re: [PATCH] staging: rtl8723au: changes stop ap mode to use reset function

Matthew Emerson writes: > Changes stop_ap_mode23a() to use rtw_reset_securitypriv23a. This makes > the code cleaner and fixes two checkpatch.pl errors, one line over 80 > characters, and one spacing issue. > > Signed-off-by: Matthew Emerson > --- > drivers/staging/rtl8723au/core/rtw_ap.c | 6 ++-

Re: [PATCH v2] tools: hv: kvp_daemon: make IPv6-only-injection work

Dexuan Cui writes: >> -Original Message- >> From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On >> Behalf Of Dexuan Cui >> Sent: Wednesday, December 10, 2014 19:33 PM >> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; driverdev- >> de...@linuxdriverproject

Re: [PATCH v7 2/4] fpga manager: add sysfs interface document

Hi Pavel, > On Jan 2, 2015, at 07:12 , Pavel Machek wrote: > > >> +What: /sys/class/fpga_manager//firmware >> +Date: October 2014 >> +KernelVersion: 3.18 >> +Contact:Alan Tull >> +Description:Name of the FPGA image file to load using firmware >> cl

[PATCH V2 1/2] iio: meter: ade7754: add error handling in _reset and _stop_device

This patch adds the error handling for the value returned from ade7754_spi_read_reg_8. With this patch, the following randconfig warnings get fixed automatically. drivers/staging/iio/meter/ade7754.c:222:6: warning: ‘val’ may be used uninitialized in this function [-Wmaybe-uninitialized] drivers/st

[PATCH V2 2/2] iio: meter: ade7759: add error handling in _reset and _stop_device

This patch adds the error handling for the value returned from ade7759_spi_read_reg_16. With this patch, the following randconfig warnings get fixed automatically. drivers/staging/iio/meter/ade7759.c:224:6: warning: ‘val’ may be used uninitialized in this function [-Wmaybe-uninitialized] drivers/s

[PATCH] staging: rtl8712: remove spaces before commas

checkpatch.pl fix for ERROR: space prohibited before that ',' (ctx:WxE) Signed-off-by: Max Perepelitsyn --- drivers/staging/rtl8712/rtl8712_cmd.h | 12 ++-- drivers/staging/rtl8712/rtl8712_event.h | 2 +- drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 4 ++-- drivers/sta