Re: [PATCH 3/3] Staging: comedi: fix space and 80 char coding style issue

2014-12-28 Thread Sudip Mukherjee
On Mon, Dec 29, 2014 at 03:14:45AM +0530, jitendra kumar khasdev wrote: > This is a patch to the s626.c file that fixes up spcae and maximum > character limit warning found by the checkpatch.pl tool you are doing two different kind of changes in this patch. it should be in two different patches.

Re: [PATCH] Staging: line6: remove spaces before commas.

2014-12-28 Thread Sudip Mukherjee
On Sun, Dec 28, 2014 at 09:30:44PM +0100, Jonas Lundqvist wrote: > Hi Jeremiah, > > On 12/28/2014 04:44 PM, Jeremiah Mahler wrote: > > Jonas, > > > > On Sun, Dec 28, 2014 at 02:26:46PM +0100, Jonas Lundqvist wrote: > >> Fixed three errors in pcm.h found by checkpatch.pl. > > > > What type of err

Re: [PATCH] staging: ft1000: ft1000-usb: ft1000_hw.c: Fix a potential memory leak.

2014-12-28 Thread Sudip Mukherjee
On Sat, Dec 27, 2014 at 07:45:07PM +0100, Rickard Strandqvist wrote: > Avoid allocate memory if we will exit the function. > > Was found by using a static code analysis program called cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > drivers/staging/ft1000/ft1000-usb/ft1000_hw.c |8 +

Re: [PATCH] staging: rtl8188eu: rtw_mlme.c: fix sparse warning

2014-12-28 Thread Larry Finger
On 12/28/2014 11:47 PM, Serguey Parkhomovsky wrote: Fixes the following sparse warning for rtw_mlme.c: drivers/staging/rtl8188eu/core/rtw_mlme.c:810:9: warning: context imbalance in 'rtw_free_assoc_resources' - different lock contexts for basic block Signed-off-by: Serguey Parkhomovsky ---

[PATCH] staging: rtl8188eu: rtw_mlme.c: fix sparse warning

2014-12-28 Thread Serguey Parkhomovsky
Fixes the following sparse warning for rtw_mlme.c: drivers/staging/rtl8188eu/core/rtw_mlme.c:810:9: warning: context imbalance in 'rtw_free_assoc_resources' - different lock contexts for basic block Signed-off-by: Serguey Parkhomovsky --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 37

[PATCH] staging: rtl8723au: changes stop ap mode to use reset function

2014-12-28 Thread Matthew Emerson
Changes stop_ap_mode23a() to use rtw_reset_securitypriv23a. This makes the code cleaner and fixes two checkpatch.pl errors, one line over 80 characters, and one spacing issue. Signed-off-by: Matthew Emerson --- drivers/staging/rtl8723au/core/rtw_ap.c | 6 ++ 1 file changed, 2 insertions(+),

[PATCH 3/3] Staging: comedi: fix space and 80 char coding style issue

2014-12-28 Thread jitendra kumar khasdev
This is a patch to the s626.c file that fixes up spcae and maximum character limit warning found by the checkpatch.pl tool Signed-off-by: Jitendra Kumar Khasdev --- drivers/staging/comedi/drivers/s626.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/com

Re: [PATCH] Staging: line6: remove spaces before commas.

2014-12-28 Thread Jonas Lundqvist
Hi Jeremiah, On 12/28/2014 04:44 PM, Jeremiah Mahler wrote: > Jonas, > > On Sun, Dec 28, 2014 at 02:26:46PM +0100, Jonas Lundqvist wrote: >> Fixed three errors in pcm.h found by checkpatch.pl. > > What type of errors did you fix? These errors: drivers/staging/line6/pcm.h:148: ERROR: space prohi

Andoid Binder sneaking in [was Re: [GIT PULL] Staging driver patches for 3.19-rc1]

2014-12-28 Thread Pavel Machek
On Mon 2014-12-15 10:41:03, Greg KH wrote: > On Mon, Dec 15, 2014 at 10:39:15AM -0800, Christoph Hellwig wrote: > > On Mon, Dec 15, 2014 at 07:23:35PM +0100, Richard Weinberger wrote: > > > I don't understand this kind of logic. > > > a) Binder is considered a piece of shite. > > > b) Google is wor

Re: [GIT PULL] Staging driver patches for 3.19-rc1

2014-12-28 Thread Pavel Machek
Hi! On Mon 2014-12-15 11:32:22, Greg KH wrote: > On Mon, Dec 15, 2014 at 08:04:53PM +0100, Richard Weinberger wrote: > > > Fact is, this is useful code, in this area. In the domain it is used > > > in, it works properly, and the abi is sufficient. Yes, it's ugly in > > > spaces, and insecure if

Re: [PATCH] Staging: line6: remove spaces before commas.

2014-12-28 Thread Jeremiah Mahler
Jonas, On Sun, Dec 28, 2014 at 02:26:46PM +0100, Jonas Lundqvist wrote: > Fixed three errors in pcm.h found by checkpatch.pl. What type of errors did you fix? > > Signed-off-by: Jonas Lundqvist > --- > drivers/staging/line6/pcm.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) >

[PATCH] tools: hv: Makefile: Add hv_fcopy_daemon to Makefile

2014-12-28 Thread Matej Muzila
hv_fcopy_daemon is not mentioned in Makefile so it must be built manually. Add hv_fcopy_daemon to Makefile. Signed-off-by: Matej Muzila --- tools/hv/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/hv/Makefile b/tools/hv/Makefile index bd22f78..99ffe61 10064

[PATCH] Staging: line6: remove spaces before commas.

2014-12-28 Thread Jonas Lundqvist
Fixed three errors in pcm.h found by checkpatch.pl. Signed-off-by: Jonas Lundqvist --- drivers/staging/line6/pcm.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/line6/pcm.h b/drivers/staging/line6/pcm.h index 6aa0d46..5d87934 100644 --- a/drivers/stagi