[PATCH v3] staging: rtl8723au: fix sparse warning

2014-12-23 Thread Alexey Tulia
drivers/staging/rtl8723au/core/rtw_xmit.c:2375 warning: symbol 'rtw_ack_tx_done23a' was not declared. Should it be static? Function 'rtw_ack_tx_done23a' seems to be unused in current staging code. Signed-off-by: Alexey Tulia --- drivers/staging/rtl8723au/core/rtw_xmit.c | 9 - 1 file ch

Re: [PATCH v2] staging: rtl8723au: fix sparse warning

2014-12-23 Thread Greg Kroah-Hartman
On Wed, Dec 24, 2014 at 08:55:21AM +0300, Aliaskei Tulia wrote: > drivers/staging/rtl8723au/core/rtw_xmit.c:2375 warning: symbol > 'rtw_ack_tx_done23a' was not declared. Should it be static? > > Function 'rtw_ack_tx_done23a' seems to be unused in current staging > code. > > Signed-off-by: Aliaske

[PATCH v2] staging: rtl8723au: fix sparse warning

2014-12-23 Thread Aliaskei Tulia
drivers/staging/rtl8723au/core/rtw_xmit.c:2375 warning: symbol 'rtw_ack_tx_done23a' was not declared. Should it be static? Function 'rtw_ack_tx_done23a' seems to be unused in current staging code. Signed-off-by: Aliaskei Tulia --- drivers/staging/rtl8723au/core/rtw_xmit.c | 9 - 1 file

[PATCH 2/2] staging: speakup: Combine the consecutive string

2014-12-23 Thread Panir.Nyan
Combine the consecutive string Signed-off-by: Panir Nyan --- drivers/staging/speakup/kobjects.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/speakup/kobjects.c b/drivers/staging/speakup/kobjects.c index b12c76d..3708bc1 100644 --- a/drivers/staging/spea

[PATCH 1/2] staging: speakup: Split the comment to fit the length

2014-12-23 Thread Panir.Nyan
Split the comment to fit the length. Signed-off-by: Panir Nyan --- drivers/staging/speakup/synth.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/speakup/synth.c b/drivers/staging/speakup/synth.c index f3aa423..01eddab 100644 --- a/drivers/staging/sp

[PATCH 1/2] vino: Fix media dependencies

2014-12-23 Thread Mauro Carvalho Chehab
Changeset c1d9e03d4ef4 moved the driver to staging, but it forgot to preserve the existing dependency. fixes: c1d9e03d4ef4 ("[media] vino/saa7191: move to staging in preparation for removal") Cc: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/staging/media/vino/Kconfig

[PATCH 2/2] tlg2300: Fix media dependencies

2014-12-23 Thread Mauro Carvalho Chehab
Changeset ea2e813e8cc3 moved the driver to staging, but it forgot to preserve the existing dependency. Fixes: ea2e813e8cc3 ("[media] tlg2300: move to staging in preparation for removal") Cc: Hans Verkuil Cc: Jim Davis Signed-off-by: Mauro Carvalho Chehab diff --git a/drivers/staging/media/tlg

Re: [PATCH 1/2] vino: Fix media dependencies

2014-12-23 Thread Hans Verkuil
Acked-by: Hans Verkuil On 12/23/2014 06:02 PM, Mauro Carvalho Chehab wrote: > Changeset c1d9e03d4ef4 moved the driver to staging, but it forgot to > preserve the existing dependency. > > fixes: c1d9e03d4ef4 ("[media] vino/saa7191: move to staging in preparation > for removal") > > Cc: Hans Ver

Re: [PATCH 2/2] tlg2300: Fix media dependencies

2014-12-23 Thread Hans Verkuil
Acked-by: Hans Verkuil On 12/23/2014 06:02 PM, Mauro Carvalho Chehab wrote: > Changeset ea2e813e8cc3 moved the driver to staging, but it forgot to > preserve the existing dependency. > > Fixes: ea2e813e8cc3 ("[media] tlg2300: move to staging in preparation for > removal") > Cc: Hans Verkuil >

Re: [PATCH] media: tlg2300: disable building the driver

2014-12-23 Thread Mauro Carvalho Chehab
Em Mon, 22 Dec 2014 13:25:45 -0700 Jim Davis escreveu: > This driver doesn't build with the current kernel, as reported in > linux-next (https://lkml.org/lkml/2014/12/18/483) and by the 0-day > build system > (https://www.mail-archive.com/linux-media@vger.kernel.org/msg83501.html). > Since it's s

Re: [PATCH v2] Redone: dgnc/digi.h: checkpatch: Macros in enclosed

2014-12-23 Thread Greg KH
On Tue, Dec 23, 2014 at 03:11:11PM +0100, Simone Weiss wrote: > I've redone the previous patch as I have also forgotten a macro. That's a horrible changelog entry, what does it mean? And why the "redone" in the subject, that would force me to edit it by hand, right? Please don't do that, you wan

Re: [PATCH 1/1] staging: skein: Delete a useless white space line

2014-12-23 Thread Greg KH
On Wed, Dec 24, 2014 at 12:18:53AM +0800, Gmail wrote: > I found no one using the words like Chinese, Japanese here. Not true, feel free to do so, there is no reason not to. greg k-h ___ devel mailing list de...@linuxdriverproject.org http://driverdev.l

Re: [PATCH 1/1] staging: skein: Delete a useless white space line

2014-12-23 Thread Gmail
I found no one using the words like Chinese, Japanese here. > On Dec 24, 2014, at 12:14 AM, Greg KH wrote: > > On Wed, Dec 24, 2014 at 12:06:10AM +0800, Gmail wrote: >> Thanks for your tip. People say this is not a legal name, but I really >> use this for all my English profile. I create another

Re: [PATCH 1/1] staging: skein: Delete a useless white space line

2014-12-23 Thread Greg KH
On Wed, Dec 24, 2014 at 12:06:10AM +0800, Gmail wrote: > Thanks for your tip. People say this is not a legal name, but I really > use this for all my English profile. I create another name sound like > my real name and it cause this "From" display. So sorry bothering you. > I will really check it a

Re: [PATCH 1/1] staging: skein: Delete a useless white space line

2014-12-23 Thread Gmail
I am not in English, French or else, means I don't have a English name. I uses the Email's name and people said it is illegal. And then I made up Ben Chan, which really sounds like my real name. > On Dec 24, 2014, at 12:04 AM, Jeremiah Mahler wrote: > > On Wed, Dec 24, 2014 at 12:01:10AM +0800

Re: [PATCH 1/1] staging: skein: Delete a useless white space line

2014-12-23 Thread Gmail
Thanks for your tip. People say this is not a legal name, but I really use this for all my English profile. I create another name sound like my real name and it cause this "From" display. So sorry bothering you. I will really check it and send in the future. > On Dec 24, 2014, at 12:00 AM, Dan

Re: [PATCH 1/1] staging: skein: Delete a useless white space line

2014-12-23 Thread Jeremiah Mahler
On Tue, Dec 23, 2014 at 03:48:16PM +, Ben Chan wrote: > From: Kroderia > > Delete a useless white space line according to the coding style. > > Signed-off-by: Ben Chan Sigh. Same problem :( > --- > drivers/staging/skein/skein_generic.c |1 - > 1 file changed, 1 deletion(-) > > diff

Re: [PATCH 1/1] staging: skein: Delete a useless white space line

2014-12-23 Thread Jeremiah Mahler
On Wed, Dec 24, 2014 at 12:01:10AM +0800, Gmail wrote: > People say that is not a legal name, therefore I create this English name > sound like my real name. > I'm confused. So Ben Chan isn't your real name, just one you made up? > > On Dec 23, 2014, at 11:57 PM, Jeremiah Mahler wrote: > > >

Re: [PATCH 1/1] staging: skein: Delete a useless white space line

2014-12-23 Thread Dan Carpenter
On Tue, Dec 23, 2014 at 03:48:16PM +, Ben Chan wrote: > From: Kroderia So very very close to being correct. Also I think someone may have already sent this one but it just hasn't been applied because the merge window is open. I've definitely seen this line before... regards, dan carpenter

Re: [PATCH 1/1] staging: skein: Delete a useless white space line

2014-12-23 Thread Jeremiah Mahler
On Tue, Dec 23, 2014 at 03:37:53PM +, Kroderia wrote: > Signed-off-by: Ben Chan Your Signed-off-by doesn't match your From: line. > --- > drivers/staging/skein/skein_generic.c |1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/skein/skein_generic.c > b/drivers/stag

[PATCH 1/1] staging: skein: Delete a useless white space line

2014-12-23 Thread Ben Chan
From: Kroderia Delete a useless white space line according to the coding style. Signed-off-by: Ben Chan --- drivers/staging/skein/skein_generic.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c index 85bd7d0..

[PATCH 1/1] staging: skein: Delete a useless white space line

2014-12-23 Thread Kroderia
Signed-off-by: Ben Chan --- drivers/staging/skein/skein_generic.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c index 85bd7d0..899078f 100644 --- a/drivers/staging/skein/skein_generic.c +++ b/drivers/staging/sk

Re: [PATCH v5 0/6] mmc: rtsx: add support for sdio card

2014-12-23 Thread Ulf Hansson
On 23 December 2014 at 02:19, wrote: > From: Micky Ching > > v5: > fix patch(5) building error, no code change diff v4. > > v4: > split patch in more detailed patches. no code changes diff v3. > > v3: > rtsx_pci_sdmmc.c: > - dump_reg_range > - remove unused pointer check >

Re: [PATCH 1/1] staging: skein: Delete a useless white space line

2014-12-23 Thread Dan Carpenter
On Tue, Dec 23, 2014 at 02:37:53PM +, Kroderia wrote: > Delete a useless white space line according to the coding style. > > PS: I also found some one-line macros using do {} while (0) loop, > feel like they are useless should be delete. Don't put this useless information in the permanent gi

[PATCH 1/1] staging: skein: Delete a useless white space line

2014-12-23 Thread Kroderia
Delete a useless white space line according to the coding style. PS: I also found some one-line macros using do {} while (0) loop, feel like they are useless should be delete. Signed-off-by: Kroderia --- drivers/staging/skein/skein_generic.c |1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH v2] Redone: dgnc/digi.h: checkpatch: Macros in enclosed

2014-12-23 Thread Dan Carpenter
On Tue, Dec 23, 2014 at 03:11:11PM +0100, Simone Weiss wrote: > I've redone the previous patch as I have also forgotten a macro. Please compile your patches at least. regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://dr

[PATCH] staging: lustre: cleanup align switch and case

2014-12-23 Thread samuel kihahu
Align switch and case to be at the same indent. Signed-off-by: Samuel Kihahu --- drivers/staging/lustre/lnet/selftest/module.c | 50 +-- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/staging/lustre/lnet/selftest/module.c b/drivers/staging/lustre

Re: [PATCH] staging: lustre: cleanup align switch and case

2014-12-23 Thread Jeremiah Mahler
samuel, This patch is corrupt and won't apply. I suspect it is due to missing spaces at the start of each line in the diff. I recommend using 'git send-email'. But if you are using a different client have a look at Documentation/email-clients.txt for tips on how to avoid these problems. On Tue

Re: [PATCH] staging: lustre: cleanup align switch and case

2014-12-23 Thread Dan Carpenter
On Tue, Dec 23, 2014 at 10:57:46AM +0300, samuel kihahu wrote: > From: samuel kihahu Don't include this unless you are forwarding a patch on behalf of the original author. Also the capitalization isn't correct. These things are intended to be a bit formal like signing a legal document. regards