Re: [PATCH] Staging: comedi: fix spacing issues in ni_stc.h

2014-12-20 Thread Jeremiah Mahler
Sage, On Sat, Dec 20, 2014 at 09:01:54PM -0500, Sage Vaillancourt wrote: > Patch to the ni_stc.h file that removes spaces before tabs, and adds blank > lines > after declarations. > Signed-off-by: Sage Vaillancourt Format your log message so it is no more than 80 characters wide (I like 7

Re: [PATCH] Staging: clocking-wizard: Added a blank line after declaration

2014-12-20 Thread Sören Brinkmann
Hi Mohammad, On Sun, 2014-12-21 at 08:03AM +0530, Mohammad Jamal wrote: > Fix the coding style issue by adding blank line after declaration > > Signed-off-by: Mohammad Jamal > --- > .../clocking-wizard/clk-xlnx-clock-wizard.c|1 + > 1 file changed, 1 insertion(+) > > diff --git a/d

[PATCH] staging: vt6655: fix sparse warning: argument type

2014-12-20 Thread Eddie Kovsky
Fixes following warning generated by sparse: drivers/staging/vt6655/baseband.c:2180:45: warning: incorrect type in argument 1 (different address spaces) drivers/staging/vt6655/baseband.c:2180:45:expected struct vnt_private *priv drivers/staging/vt6655/baseband.c:2180:45:got void [noderef]

[PATCH] staging: rtl8192e: fixed a space coding style issue

2014-12-20 Thread Gangadhar Vukkesala
Fixed a space coding style issue in 3-dimensional array initialization which was found when running checkpatch.pl script on rtl819x_HTProc.c. Signed-off-by: Gangadhar Vukkesala --- drivers/staging/rtl8192e/rtl819x_HTProc.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] Staging : gdm724x: Remove space before , in function arguments

2014-12-20 Thread Mohammad Jamal
This patch solves space prohibited before , warning in gdm_mux.c Signed-off-by: Mohammad Jamal --- drivers/staging/gdm724x/gdm_mux.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c index b5b063a..d1ab99

[PATCH] Staging: clocking-wizard: Added a blank line after declaration

2014-12-20 Thread Mohammad Jamal
Fix the coding style issue by adding blank line after declaration Signed-off-by: Mohammad Jamal --- .../clocking-wizard/clk-xlnx-clock-wizard.c|1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c b/drivers/staging/clocking-wizard

[PATCH] Staging: comedi: fix spacing issues in ni_stc.h

2014-12-20 Thread Sage Vaillancourt
Patch to the ni_stc.h file that removes spaces before tabs, and adds blank lines after declarations. Signed-off-by: Sage Vaillancourt --- drivers/staging/comedi/drivers/ni_stc.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_s

[PATCH] lustre: ptlrpc: add "ptlrpc_internal.h" to sec_gc.c

2014-12-20 Thread Spencer Baugh
ptlrpc_internal.h contains the prototypes for sptlrpc_gc_init() and sptlrpc_gc_fini(), which are defined in sec_gc.c. This removes the following sparse warnings: drivers/staging/lustre/lustre/ptlrpc/sec_gc.c:217:5: warning: symbol 'sptlrpc_gc_init' was not declared. Should it be static? drivers/

Re: [PATCH] lustre: ptlrpc: add "ptlrpc_internal.h" to sec_gc.c

2014-12-20 Thread Greg Kroah-Hartman
On Sat, Dec 20, 2014 at 03:27:31PM -0500, sbaugh wrote: > ptlrpc_internal.h contains the prototypes for sptlrpc_gc_init() and > sptlrpc_gc_fini(), which are defined in sec_gc.c. > > This removes the following sparse warnings: > > drivers/staging/lustre/lustre/ptlrpc/sec_gc.c:217:5: warning: symbo

[PATCH] lustre: ptlrpc: add "ptlrpc_internal.h" to sec_gc.c

2014-12-20 Thread sbaugh
ptlrpc_internal.h contains the prototypes for sptlrpc_gc_init() and sptlrpc_gc_fini(), which are defined in sec_gc.c. This removes the following sparse warnings: drivers/staging/lustre/lustre/ptlrpc/sec_gc.c:217:5: warning: symbol 'sptlrpc_gc_init' was not declared. Should it be static? drivers/

Re: [PATCH] Staging: gdm724x: fix space before comma coding style issue in gdm_mux.c

2014-12-20 Thread Greg KH
On Sat, Dec 20, 2014 at 12:51:00PM +0100, Robert N wrote: > I already sent you the patch line-wrapped at column 69, so it says: > > > This is a patch to the gdm_mux.c file that fixes a space before comma > > coding style issue found by the checkpatch.pl tool. > > Do i have to wrap it exactly at c

[PATCH] staging: rtl8723au: core: rtw_cmd.c: Remove some unused functions

2014-12-20 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: rtw_set_ch_cmd23a() rtw_cmd_clr_isr23a() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8723au/core/rtw_cmd.c| 61 --- d

[PATCHv2 1/1] staging: rtl8723au: Fix sparse invalid assignment warnings

2014-12-20 Thread Yannis Damigos
This is a patch to the hal/rtl8723au_xmit.c file that fixes the following warnings found by sparse tool: drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:88:22: warning: invalid assignment: |= drivers/staging/rtl8723au//hal/rtl8723au_xmit.c:88:22:left side has type unsigned int drivers/stagin

[PATCH] staging: rtl8723au: hal: odm.c: Remove some unused functions

2014-12-20 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: odm_1R_CCA23a() odm_TXPowerTrackingCheckAP() odm_TXPowerTrackingCheckMP() odm_RSSIMonitorCheck23aAP() odm_RSSIMonitorCheck23aMP() odm_RSSIMonitorInit() odm_RefreshRateAdaptiveMask23aAPADSL23a() odm_RefreshRateAdaptiveMask23aMP23a() This was partia

Re: [PATCH v4] staging: rtl8188eu: Fixed a space coding style issue.

2014-12-20 Thread Jeremiah Mahler
On Sat, Dec 20, 2014 at 09:29:47PM +0530, Gangadhar Vukkesala wrote: > Fixed a space coding style issue which was found when running checkpatch.pl > script on rtw_ap.c. > > Signed-off-by: Gangadhar Vukkesala > --- > drivers/staging/rtl8188eu/core/rtw_ap.c |2 +- > 1 file changed, 1 insertion

[PATCH] staging: rtl8188eu: core: rtw_wlan_util.c: Remove some unused functions

2014-12-20 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: CAM_empty_entry() get_bsstype() rtw_get_oper_choffset() rtw_get_oper_bw() is_ap_in_wep() should_forbid_n_rate() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/st

[PATCH v4] staging: rtl8188eu: Fixed a space coding style issue.

2014-12-20 Thread Gangadhar Vukkesala
Fixed a space coding style issue which was found when running checkpatch.pl script on rtw_ap.c. Signed-off-by: Gangadhar Vukkesala --- drivers/staging/rtl8188eu/core/rtw_ap.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers

Re: [PATCH v3] Staging:rtl8188eu:Fixed a space coding style issue.

2014-12-20 Thread Jeremiah Mahler
Gangadhar, It is looking much better. Just a few more nit picks though :) In the subject line, tags usually have ':' next to the tag with a space between. Also, I usually keep them lowercase. staging: rtl8188eu: (then your description) On Sat, Dec 20, 2014 at 08:17:02PM +0530, Gangadhar Vuk

[PATCH] staging: rtl8712: recv_linux.c: Remove unused function

2014-12-20 Thread Rickard Strandqvist
Remove the function r8712_os_read_port() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8712/recv_linux.c | 14 -- drivers/staging/rtl8712/recv_osdep.h |1 -

[PATCH] staging: iio: accel: sca3000_core.c: Remove unused function

2014-12-20 Thread Rickard Strandqvist
Remove the function sca3000_check_status() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/iio/accel/sca3000_core.c | 27 --- 1 file changed, 27 deletio

[PATCH v3] Staging:rtl8188eu:Fixed a space coding style issue.

2014-12-20 Thread Gangadhar Vukkesala
Fixed a Space Coding style issue which was found when running checkpatch.pl script on rtw_ap.c. Signed-off-by: Gangadhar Vukkesala --- drivers/staging/rtl8188eu/core/rtw_ap.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_ap.c b/drivers

[PATCH] staging: rtl8192e: rtl8192e: rtl_pm.c: Remove some unused functions

2014-12-20 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: rtl8192E_save_state() rtl8192E_enable_wake() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8192e/rtl8192e/rtl_pm.c | 14 -- drivers/sta

[PATCH] staging: rtl8188eu: core: rtw_mlme_ext.c: Remove unused function

2014-12-20 Thread Rickard Strandqvist
Remove the function NULL_hdl() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c|5 - drivers/staging/rtl8188eu/include/rtw_mlme_ext.h |

[PATCH] staging: rtl8712: rtl871x_mp_ioctl.c: Remove some unused functions

2014-12-20 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: oid_rt_pro_h2c_get_rate_table_hdl() oid_rt_pro_h2c_set_rate_table_hdl() oid_rt_pro_set_pwrstate_hdl() oid_rt_pro_qry_pwrstate_hdl() oid_rt_pro_set_basic_rate_hdl() oid_rt_pro_set_power_tracking_hdl() oid_rt_pro_set_data_rate_ex_hdl() oid_rt_pro_cfg