This patch replace the value '80' used in several files in the lustre source
code
with a define LUSTRE_MDT_MAXNAMELEN.
This value is used in 4 different structures as the maximum len for a service
name.
According to the comments, these names follow a convention which make it
possible
to use the
This patch fix a sparse warning in lustre sources
warning: incorrect type in argument 1 (different address spaces)
expected void [noderef] *to
got char *
This is done by adding the missing __user attribute on userland pointers inside
the LPROC_SEQ_FOPS like macros:
- LPROC_SEQ_FOPS
- LPR
On Fri, Dec 05, 2014 at 07:58:44PM -0800, K. Y. Srinivasan wrote:
> Implement a clockevent device based on the timer support available on
> Hyper-V.
> In this version of the patch I have addressed Jason's review comments.
>
> Signed-off-by: K. Y. Srinivasan
> Reviewed-by: Jason Wang
> ---
Why d
Implement a clockevent device based on the timer support available on
Hyper-V.
In this version of the patch I have addressed Jason's review comments.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Jason Wang
---
arch/x86/include/uapi/asm/hyperv.h | 11 +
drivers/hv/hv.c|
> -Original Message-
> From: Long Li [mailto:lon...@microsoft.com]
> Sent: Friday, December 5, 2014 7:38 PM
> To: linux-s...@vger.kernel.org
> Cc: KY Srinivasan; Haiyang Zhang; jbottom...@parallels.com;
> de...@linuxdriverproject.org; linux-ker...@vger.kernel.org; Long Li
> Subject: drive
> -Original Message-
> From: K. Y. Srinivasan [mailto:k...@microsoft.com]
> Sent: Friday, December 5, 2014 4:27 PM
> To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
> jasow...@redhat.com
> Cc: KY Srinivasan
When ring buffer returns an error indicating retry, storvsc may not return a
proper error code to SCSI when bounce buffer is not used. This has introduced
I/O freeze on RAID running atop storvsc devices. This patch fixes it by always
returning a proper error code.
Signed-off-by: Long Li
Review
Em Fri, 05 Dec 2014 12:35:25 +
Luis de Bethencourt escreveu:
> On 5 December 2014 at 12:28, Dan Carpenter wrote:
>
> > On Thu, Dec 04, 2014 at 10:35:24PM +, Luis de Bethencourt wrote:
> > > The previous patch switched some dev functions to move the string to a
> > second
> > > line. Doi
The Hyper-V balloon driver does memory hot-add. The device_hotplug_lock
is designed to address AB BA deadlock issues between the hot-add path
and the sysfs path. Export the APIs to acquire and release the
device_hotplug_lock for use by loadable modules that want to
hot-add memory or CPU.
Signed-of
Andy Whitcroft initially saw this deadlock. We
have seen this as well. Here is the original description of the
problem (and a potential solution) from Andy:
https://lkml.org/lkml/2014/3/14/451
Here is an excerpt from that mail:
"We are seeing machines lockup with what appears to be an ABBA
dead
Fix a deadlock in the hot-add path in the Hyper-V balloon driver.
K. Y. Srinivasan (2):
Drivers: base: core: Export functions to lock/unlock device hotplug
lock
Drivers: hv: balloon: Fix the deadlock issue in the memory hot-add
code
drivers/base/core.c |2 ++
drivers/hv/hv_ba
Implement a clockevent device based on the timer support available on
Hyper-V.
In This version of the patch I have addressed Jason's review comments.
Signed-off-by: K. Y. Srinivasan
Reviewed-by: Jason Wang
---
arch/x86/include/uapi/asm/hyperv.h | 11 +
drivers/hv/hv.c|
On Fri, Dec 05, 2014 at 10:10:43PM +0100, Mariusz Gorski wrote:
> Get rid of magic numbers in LCD commands and replace them with defined
> values, so that it's more obvious that the commands are doing.
>
> Signed-off-by: Mariusz Gorski
I didn't remember I wrote something that awful! Obvious ack.
On Fri, Dec 5, 2014 at 5:08 PM, Benjamin Romer
wrote:
> Fix the missing braces and logical continuation problems in create_bus().
>
> Signed-off-by: Ken Depro
> Signed-off-by: Benjamin Romer
> ---
> drivers/staging/unisys/uislib/uislib.c | 14 --
> 1 file changed, 8 insertions(+), 6
> static BOOL
> -Initialize_incoming_thread(void)
> +initialize_incoming_thread(void)
> {
> if (incoming_started)
> return TRUE;
> if (!uisthread_start(&incoming_ti,
> &process_incoming, NULL, "dev_incoming")) {
> - LOGERR
> -Original Message-
> From: Jason Wang [mailto:jasow...@redhat.com]
> Sent: Thursday, December 4, 2014 10:52 PM
> To: KY Srinivasan
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; KY
> Srinivasan
> Subjec
On Fri, Dec 05, 2014 at 01:27:23PM -0800, Greg KH wrote:
> On Fri, Dec 05, 2014 at 12:03:47AM -0800, Tristan Lelong wrote:
> > static ssize_t
> > -fld_proc_hash_seq_write(struct file *file, const char *buffer,
> > - size_t count, loff_t *off)
> > +fld_proc_hash_seq_write(struct f
On Fri, Dec 05, 2014 at 12:44:07AM -0800, Joe Perches wrote:
> On Fri, 2014-12-05 at 00:37 -0800, Tristan Lelong wrote:
> > On Fri, Dec 05, 2014 at 12:28:11AM -0800, Joe Perches wrote:
> > > On Fri, 2014-12-05 at 00:03 -0800, Tristan Lelong wrote:
> []
> > > > diff --git a/drivers/staging/lustre/lu
From: Ken Depro
This patch fixes the remaining CamelCase global variables in virthba.c reported
by the checkpatch script:
MaxBuffLen --> max_buff_len
VirtHbasOpen --> virthbas_open
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c | 25 +++
Remove the entire set of LOGINFO() macros and replace them with calls to
pr_info() instead.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/timskmod.h | 5 --
drivers/staging/unisys/include/uniklog.h | 29
drivers/staging/un
Remove the ERRDRV() macro family and use pr_err directly everywhere it was used.
Completely remove any error messages that used the macro but are redundant, for
example, several of the messages were from memory allocation failures.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
driv
From: Ken Depro
This patch fixes checkpatch checks where the logical operator should be at the
end of the line above, not beginning the next line.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c | 38
1 file
From: Ken Depro
This patch fixes the Disk Add/Remove (DAR) related CamelCase global
variables in virthba.c, reported by the checkpatch script:
DARWorkQ --> dar_work_queue
DARWorkQHead --> dar_work_queue_head
DARWorkQLock --> dar_work_queue_lock
DARWorkQSched --> dar_work_queue_sched
Sign
From: Ken Depro
This patch fixes the "alignment should match open parenthesis" checks from the
checkpatch script.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c | 120 ---
1 file changed, 61 insertions(+), 59 del
From: Ken Depro
This patch fixes a warning generated during the checkpatch script that stated
"else not useful after return". I modified the code to return a designated
status at the end of the function, and replaced the return statement in the
"else if" to set the status accordingly.
Signed-of
From: Ken Depro
This patch fixes CamelCase function names in virthba.c, reported by the
checkpatch script:
doDiskAddRemove --> do_disk_add_remove
SendDiskAddRemove --> send_disk_add_remove
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c
Get rid of the unnecessary goto statement and just return directly.
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uisutils.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/unisys/uislib/uisutils.c
b
Fix the function declaration so it is on a single line. Fix CamelCase local
variables:
busNo => bus_no
devNo => dev_no
Fix use of uuid_le_cmp() to check for 0 instead of using !uuid_le_cmp().
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.
Fix almost all of the parenthesis alignment problems in uislib.c. The 2
remaining issues are in create_device(), which is heavily indented and needs
to be refactored entirely anyway.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 48 +
From: Ken Depro
This patch fixes a couple small issues reported by the checkpatch script:
Adds a blank line after a struct definition.
Removes unnecessary parentheses surrounding a dereference of a struct member.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/u
From: Bryan Thompson
Rename channelBytes to channel_bytes in the series of visorchannel_create
functions provided by visorchannel.
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchannel/visorchannel.h | 10 -
.../unisys/visorchannel/visorch
From: Ken Depro
This patch removes all unnecessary spaces after casts, as reported by the
checkpatch script.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c | 130 +++
1 file changed, 65 insertions(+), 65 deletion
This goto uses CamelCase and was completely unnecessary.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/file.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/file.c
b/drivers/stagi
Rename CamelCase global variable names:
ReqHandlerInfo_list => req_handler_info_list
ReqHandlerInfo_list_lock => req_handler_info_list_lock
Update all references to use the new name.
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uisutils.c | 24
Remove the DBGINF() group of logging macros and use pr_debug() instead. Fix
places that used the DBGINF() macro so they actually print the expected value,
because they were not being compiled at all before the switchover.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/stagin
From: Ken Depro
This patch fixes checkpatch warnings that resulted from the else portion of
if-else statements missing braces, so that it conforms with the rest of the
statement.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c | 6 --
1
From: Ken Depro
This patch fixes the CamelCase local variables in virthba.c, reported by the
checkpatch script:
pChannelHeader --> pchhdr
Features_addr --> features_addr
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c | 40 ++
Get rid of LOGWRN() and all related macros, and call pr_warn() directly instead.
Removing the LOGWRN() macro set makes uisklog.h empty, so remove the file too.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/procobjecttree.h| 1 -
drivers/staging/
Delete these entirely as the only place that was using it had existing
pr_info() statements with the exact same content.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/uniklog.h | 28
drivers/staging/unisys/virthba/virthba.
Add a comment to the charqueue's spinlock to explain that it is a lock for the
structure.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorutil/charqueue.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/visorutil/
Fix the function declaration so it is a single line, and fix CamelCase
function parameter names:
busNo => bus_no
devNo => dev_no
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 11 +--
1 file changed, 5 insertions(+), 6 deletions
From: Ken Depro
This patch fixes warnings generated by checkpatch script regarding lines
over 80 characters long.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/s
From: Ken Depro
This patch changes a couple of kzalloc calls to pass the variable name to the
call, rather than the variable struct type. This is a result of checks
generated during the checkpatch script.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virth
From: Ken Depro
This patch removes unnecessary blank lines either before opening braces or
after closing braces, as reported by the checkpatch script.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c | 4
1 file changed, 4 deletions(-)
Remove another completely unnecessary goto and just return the values
directly.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/file.c | 18 +-
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/unisys/vi
The if statement in info_debugfs_read() needs another set of brackets for the
else clause.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/uislib/uislib
Fix the CamelCase function name:
Process_Incoming => process_incoming
Update all references to use the new name.
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --g
Just remove the couple of extra blank lines.
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uisutils.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/uislib/uisutils.c
b/drivers/staging/unisys/uislib/uisutils.c
index 4
Fix CamelCase local variable name:
pReqHandlerInfo => req_handler
Get rid of the useless goto and just return straight away on an error.
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uisutils.c | 39 +++-
1 file chang
From: Ken Depro
This patch fixes a couple checkpatch checks where alignment of the parameters
did not match the open parenthesis of the function.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/virthba/virthba.c | 6 --
1 file changed, 4 insertions(+), 2
We definitely have it, so there's no point in keeping the older stuff
around. Get rid of the #ifdefs and old code.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/file.c | 18 +-
1 file changed, 1 insertion(+), 17 deletions(-)
diff
Fix the function declaration so it is a single line. Fix CamelCase local
variable names:
busNo => bus_no
devNo => dev_no
Fix use of uuid_le_cmp() to check for 0 instead of using !uuid_le_cmp().
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uisli
From: Bryan Thompson
Remove the VISORCHANNEL typedef and rename the base VISORCHANNEL_Tag
structure to visorchannel to follow consistent naming. The longer
struct visorchannel type required additional line wrapping to remain
less than 81 characters.
Signed-off-by: Bryan Thompson
Signed-off-by:
Fix the function definition so that it is a single line. Fix CamelCase
parameter names:
busNo => bus_no
devNo => dev_no
Get rid of the goto and just break out of the for loop, since that does
the exact same thing.
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging
Add the missing brackets to the last if statement in this function.
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uisutils.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/uislib/uisutils.c
b/driver
OK, lets clean up this messy function. The entire thing is reflowed so spacing
and indentation is correct. Tests that created extra indentation were swapped
for equivalent negative tests that did not create extra indentation. Use of
cmp_uuid_le() were fixed to test specifically for the zero case, a
Fix CamelCase name:
physAddr => physaddr
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/file.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/file.c
b/drivers/staging/unisys/visorc
Fix the declaration so it is a single line. Fix CamelCase parameter
names:
MajorDev => major_dev
pControlVm_channel => controlvm_channel
Remove the unnecessary gotos and just return directly in error cases.
Fix the last error condition so it returns the result of cdev_add()
instead of always zero
Fix the function declaration so it is a single line. Rename CamelCase local
variable names:
busNo => bus_no
devNo => dev_no
Fix use of uuid_le_cmp() to check for 0 instead of using !uuid_le_cmp(). Fix
spelling error DESTORY to correctly read DESTROY.
Signed-off-by: Bryan Thompson
Signed-off-by:
Fix CamelCase name:
Work_wakeup_polling_device_channels => work_wakeup_polling_device_channels
Update references to use the new name.
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-
Fix the CamelCase local variable:
busNo => bus_no
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/unisys/uislib/uislib.c
b/drivers/staging/un
Fix CamelCase names:
ProcReadBufferValid => debug_buf_valid
ProcReadBuffer => debug_buf
BusListHead => bus_list
BusListLock => bus_list_lock
BusListCount => bus_list_count
MaxBusCount => max_bus_count
PhysicalDataChan => phys_data_chan
PlatformNumber => platform_no
Incoming_ThreadInfo => incoming_
Fix the CamelCase parameter names:
Server_Channel_Ok => server_channel_ok
Server_Channel_Init => server_channel_init
clientStr => clientstr
clientStrLen => clientstr_len
And remove the extra parenthesis in the list_add_tail() call at the end.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Rom
From: Bryan Thompson
Rename the visorchannel_debug parameter nQueues to num_queues.
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchannel/visorchannel.h | 2 +-
drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 4 ++--
2 files chang
Fix CamelCase names:
pSignal => signal
Remove unused parameters issueInterruptIfEmpty and interruptHandle, and update
callers of this function.
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uisqueue.c | 14 ++
1 file changed, 6 inser
Remove all extraneous spaces from typecasts in uislib.c.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 42 +-
1 file changed, 21 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/unisys/uislib/uisli
Fix the function declaration so the type is on the same line as the name,
and fix the CamelCase local variable name:
TotalBytes => total_bytes
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 13 ++---
1 file changed, 6 insertions
From: Bryan Thompson
Add comments indicating the requirements and use of the insert_lock and
remove_lock in the VISORCHANNEL_Tag structure.
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchannel/visorchannel_funcs.c | 7 ---
1 file changed, 4 i
Fix CamelCase names:
Cdev => file_cdev
PControlVm_channel => file_controlvm_channel
MajorDev => majordev
Registered => registered
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/file.c | 54 +++---
1 file changed, 27 insert
Correct alignment for a couple of functions and remove the space between
a typecast and its target.
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uisqueue.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/
Fix as many spacing problems as possible by indenting lines properly and
getting rid of spaces between typecasts and their targets.
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uisutils.c | 14 +++---
1 file changed, 7 insertions(+), 7 de
Fix the CamelCase name of this function:
Initialize_incoming_thread => initialize_incoming_thread
Update all references to use the new name.
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 6 +++---
1 file changed, 3 insertions(+), 3 de
Fix the function declaration to be a single line, and rename the CamelCase
parameter:
busNo => bus_no
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/stagin
Just remove the one extra blank line.
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uisthread.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/unisys/uislib/uisthread.c
b/drivers/staging/unisys/uislib/uisthread.c
index c0fc812
Nobody is using this file so remove it and the reference to it in
visorchipset_main.c.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/testing.h | 43 --
.../unisys/visorchipset/visorchipset_main.c| 1 -
2 files ch
Delete the following unused types, and unused function prototypes:
VISORCHIPSET_SWITCH_INFO
VISORCHIPSET_EXTERNALPORT_INFO
VISORCHIPSET_INTERNALPORT_INFO
visorchipset_get_switch_info()
visorchipset_get_externalport_info()
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/stagi
Just get rid of the extra blank lines in this file.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/visorchipset_umode.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/visorchipset_umode.h
b/drivers/stagin
Get rid of the extra parenthesis in uislib_enable_channel_interrupts().
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/uislib/uislib.c
b/drivers/st
Fix the missing braces and logical continuation problems in create_bus().
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/unisys/uislib/uislib.c
The functions in channels/* aren't used in a lot of places. In fact, the
functions in channel.c can be moved to uislib/uisqueue.c, and the rest
of the files in channels can be eliminated.
This patch deletes the channels directory and files, removes it from all
Kconfigs that referenced them, remove
Fix CamelCase local variable names:
busNo => bus_no
deviceCount => dev_count
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 26 +-
1 file changed, 13 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/u
Get rid of the extra blank lines in globals.h.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/globals.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/globals.h
b/drivers/staging/unisys/visorchipset/globa
Split the doubled assignment in uislib_mod_init() into two separate assignments.
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/uislib/uislib.c
b
This patch series contains all of the previously-submitted patches in order and
reviewed individually. The patches contain fixes based on errors, warnings,
and checks generated by checkpatch.pl, removal of log message macros, and fixes
to remove unnecessary goto statements.
Benjamin Romer (51):
Clean up the function definition so it's a single line. Remove the unnecessary
goto statements and just return directly. Remove the unneeded local variable
for the return result. Fix CamelCase parameters and local variable names:
channelAddr => ch_addr
channelBytes => ch_bytes
pChan => ch
Signed-
Fix the brackets in the else clause in Process_Incoming().
Signed-off-by: Bryan Thompson
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/unisys/uislib/uislib.c
b/drivers/staging/unisy
Fix the line spacing errors in uislib.c.
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/staging/unisys/uislib/uislib.c
b/drivers/staging/unisys/uislib/uislib.c
index 8a48091..e2
Use the variable name rather than the type, and add a set of missing brackets
to the if statement in create_device().
Signed-off-by: Ken Depro
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/uislib/uislib.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drive
Get rid of magic numbers in LCD commands and replace them with defined
values, so that it's more obvious that the commands are doing.
Signed-off-by: Mariusz Gorski
---
v2: Found and got rid of two more magic number usages
drivers/staging/panel/panel.c | 96 +-
On Fri, Dec 05, 2014 at 12:03:47AM -0800, Tristan Lelong wrote:
> This patch fix a sparse warning in lustre sources
>
> warning: incorrect type in argument 1 (different address spaces)
> expected void [noderef] *to
> got char *
>
> This is done by adding the missing __user attribute on us
Get rid of magic numbers in LCD commands and replace them with defined
values, so that it's more obvious that the commands are doing.
Signed-off-by: Mariusz Gorski
---
drivers/staging/panel/panel.c | 83 +--
1 file changed, 57 insertions(+), 26 deletions(-
The spinan_read_status can fail, check for the return value and
fail if the spinand_read_status fails.
Cc: Kamlakant Patel
Signed-off-by: Devendra Naga
---
compile tested only with make allmodconfig (platform X86_64 )
drivers/staging/mt29f_spinand/mt29f_spinand.c | 17 -
1 fi
Hi Philipp:
On 2014年12月05日 21:55, Philipp Zabel wrote:
Hi Andy,
Am Freitag, den 05.12.2014, 14:22 +0800 schrieb Andy Yan:
We found Freescale imx6 and Rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS)
use the interface compatible Designware HDMI IP, but they also have some
lightly differences, su
This patch fix the checkpatch.pl warning:
WARNING: space before semicolon prohibited
Signed-off-by: Anjana Sasindran
---
drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c
b
This patch fix the checkpatch.pl warning:
WARNING: Missing blank line after declaration
Signed-off-by: Anjana Sasindran
---
drivers/staging/rtl8723au/hal/odm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/rtl8723au/hal/odm.c
b/drivers/staging/rtl8723au/hal/odm.c
index
Hello,
My name is Ms.Maria McCaner; I work with the Track You Service, a consulting
Firm in London , UK . We are conducting a standard process investigation
involving
a client who shares the same name with you and also the circumstances
surrounding investments made by this client at HSBC Bank P
Hi Andy,
Am Freitag, den 05.12.2014, 14:22 +0800 schrieb Andy Yan:
> We found Freescale imx6 and Rockchip rk3288 and Ingenic JZ4780 (Xburst/MIPS)
> use the interface compatible Designware HDMI IP, but they also have some
> lightly differences, such as phy pll configuration, register width(imx hdmi
Am Freitag, den 05.12.2014, 14:27 +0800 schrieb Andy Yan:
> Signed-off-by: Andy Yan
This binding is mostly a copy of the existing
Documentation/devicetree/bindings/drm/imx/hdmi.txt, but there is a new
reg-io-width property to configure the register access bus width and we
have added new compatibl
On Thu, Dec 04, 2014 at 10:35:24PM +, Luis de Bethencourt wrote:
> The previous patch switched some dev functions to move the string to a second
> line. Doing this for all similar functions because it makes the driver easier
> to read if all similar lines use the same criteria.
>
> Signed-off-
On Fri, Dec 05, 2014 at 04:25:22PM +0530, Athira Lekshmi wrote:
> Fixed the checkpatch warning:
> Missing a blank line after declarations
this is not applying to next-20141204.
sudip
>
> Signed-off-by: Athira Lekshmi
> ---
> drivers/staging/octeon/ethernet-rx.c |1 +
> 1 file changed, 1 i
1 - 100 of 106 matches
Mail list logo
