Re: [PATCH v2] Staging: rtl8188eu: {core, hal, include}: Removed inline function

2014-12-02 Thread Abel Moyo
On Tue, Dec 02, 2014 at 04:30:51PM -0800, Greg KH wrote: > On Sat, Nov 29, 2014 at 11:48:07AM +0100, Abel Moyo wrote: > > Removed inline function get_my_bssid and open coded all its references > > > > Signed-off-by: Abel Moyo > > --- > > Changes in v2: > > - Remove inline function entirely an

[PATCH v2] staging: rt8192u: fix sparse warnings in r8192U_core.c

2014-12-02 Thread Fred Chou
From: Fred Chou v2: alignment to match open parenthesis Fixed the following warnings in sparse: drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: symbol 'dump_eprom' was not declared. Should it be static? drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning: symbol

Re: [PATCH] Staging: slicoss: Fix long line issues in slicoss.c

2014-12-02 Thread Sudip Mukherjee
On Tue, Dec 02, 2014 at 11:45:00PM +, Sean Cleator wrote: > > A patch to the slicoss.c file to fix some of the long line issues found by > the > checkpath.pl tool > Signed-off-by: Sean Cleator do not use whitespace before Signed-off-by thanks sudip > > --- > drivers/staging/slicoss/

Re: [PATCH] Staging: ft1000: fix spaces around operators in ft1000_debug.c

2014-12-02 Thread Sudip Mukherjee
On Tue, Dec 02, 2014 at 07:30:40PM -0600, Paul Hedman wrote: > Fixes spacing issues around operators, e.g. i=0 to i = 0, as > found by the checkpatch.pl tool. no Signed-off-by ??? please run your patch through checkpatch before sending. thanks sudip > --- > drivers/staging/ft1000/ft1000-usb/ft

Re: [PATCH] staging: rt8192u: fix sparse warnings in r8192U_core.c

2014-12-02 Thread Sudip Mukherjee
On Wed, Dec 03, 2014 at 10:38:27AM +0800, Fred Chou wrote: > From: Fred Chou > > Fixed the following warnings in sparse: > drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: > symbol 'dump_eprom' was not declared. > Should it be static? > drivers/staging/rtl8192u/r8192U_core.c:148

Re: [PATCH 1/1] Staging: ft1000: fix whitespace and brace coding style issues

2014-12-02 Thread Greg Kroah-Hartman
On Tue, Dec 02, 2014 at 11:25:22PM -0500, Kevin Pietsch wrote: > Removed braces from single line if, else, for statements. > Replaced space indents with tabs. Fixed whitespace errors around operators. That's a whole lot of different things to do in one patch. Please, one patch per "thing" you do,

[PATCH 1/1] Staging: ft1000: fix whitespace and brace coding style issues

2014-12-02 Thread Kevin Pietsch
Removed braces from single line if, else, for statements. Replaced space indents with tabs. Fixed whitespace errors around operators. Signed-off-by: Kevin Pietsch --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 225 +-- 1 file changed, 90 insertions(+), 135 deletions(-

Re: [PATCH] staging: rt8192u: fix sparse warnings in r8192U_core.c

2014-12-02 Thread Greg KH
On Wed, Dec 03, 2014 at 10:31:55AM +0800, Fred Chou wrote: > From: Fred One word name, and then: > Signed-off-by: Fred Chou Two word name. Unacceptable, you know this... ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdrive

[PATCH] staging: rt8192u: fix sparse warnings in r8192U_core.c

2014-12-02 Thread Fred Chou
From: Fred Chou Fixed the following warnings in sparse: drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: symbol 'dump_eprom' was not declared. Should it be static? drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning: symbol 'ComputeTxTime' was not declared.

[PATCH] Staging: rtl8712: Fixes brace coding style in rtl871x_sta_mgt.c

2014-12-02 Thread Paul Hedman
This patch fixes a brace warning in rtl871x_sta_mgt.c found by the checkpatch.pl tool. Signed-off-by: Paul Hedman --- drivers/staging/rtl8712/rtl871x_sta_mgt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl871x_sta_mgt.c b/drivers/staging/rtl87

[PATCH] staging: rt8192u: fix sparse warnings in r8192U_core.c

2014-12-02 Thread Fred Chou
From: Fred Fixed the following warnings in sparse: drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: symbol 'dump_eprom' was not declared. Should it be static? drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning: symbol 'ComputeTxTime' was not declared. Sho

Re: [PATCH] Staging: ft1000: fix spaces around comparisons in ft1000_debug.c

2014-12-02 Thread Paul H
Well shoot, please ignore what I just sent in then, I thought I had it. -Paul On Tue, Dec 2, 2014 at 7:31 PM, Greg KH wrote: > On Tue, Dec 02, 2014 at 07:10:41PM -0600, Paul H wrote: >> A tutorial I read suggested using a different branch for applying the >> patches; I named it "fix-spaces". It

Re: [PATCH] Staging: ft1000: fix spaces around comparisons in ft1000_debug.c

2014-12-02 Thread Greg KH
On Tue, Dec 02, 2014 at 07:10:41PM -0600, Paul H wrote: > A tutorial I read suggested using a different branch for applying the > patches; I named it "fix-spaces". It would appear it is mistaken > then? You have to make your patch against the linux-next tree, not Linus's tree, so as to not duplic

[PATCH] Staging: ft1000: fix spaces around operators in ft1000_debug.c

2014-12-02 Thread Paul Hedman
Fixes spacing issues around operators, e.g. i=0 to i = 0, as found by the checkpatch.pl tool. --- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 28 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_debug.c b/driv

Re: [PATCH] Staging: ft1000: fix spaces around comparisons in ft1000_debug.c

2014-12-02 Thread Paul H
A tutorial I read suggested using a different branch for applying the patches; I named it "fix-spaces". It would appear it is mistaken then? Thanks again, hope I'm not bothering at all, first time trying to give back. -Paul On Tue, Dec 2, 2014 at 6:48 PM, Greg KH wrote: > On Tue, Dec 02, 2014

Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi

2014-12-02 Thread Andy Yan
Hi Philipp: On 2014年12月03日 02:23, Philipp Zabel wrote: Hi Andy, Am Dienstag, den 02.12.2014, 15:42 +0800 schrieb Andy Yan: diff --git a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt new file mode 100644 index 000..107c1c

Re: [PATCH] staging: rt8192u: fix sparse warnings in r8192U_core.c

2014-12-02 Thread Greg KH
On Mon, Dec 01, 2014 at 09:54:45AM +0800, Fred wrote: > Fixed the following warnings in sparse: > drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: > symbol 'dump_eprom' was not declared. > Should it be static? > drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning: > symbo

Re: [PATCH] Staging: ft1000: fix spaces around comparisons in ft1000_debug.c

2014-12-02 Thread Greg KH
On Tue, Dec 02, 2014 at 09:11:15AM -0600, Paul Hedman wrote: > This fix fixes spacing issues around operators, e.g. i=0 to i = 0, found by > the checkpatch.pl tool. Please wrap your changelog at the correct column. > > Signed-off-by: Paul Hedman > --- > drivers/staging/ft1000/ft1000-usb/ft100

Re: [PATCH] staging:drivers:staging:clocking-wizard:clk-xlnx-clock-wizard.c: Added a line after declaration

2014-12-02 Thread Greg KH
On Sat, Nov 29, 2014 at 06:25:30PM +0530, Anjana Sasindran wrote: > This patch fix the checkpatch.pl warning > > WARNING:Missing a blank line after declaration > > Signed-off-by: Anjana Sasindran > --- > drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 + > 1 file changed, 1 insertio

Re: [PATCH] Drivers:staging:octeon: Fixed checkpatch warning

2014-12-02 Thread Greg KH
On Sat, Nov 29, 2014 at 11:04:00AM +0530, Athira Lekshmi wrote: > Fixed the checkpatch warning: > Missing a blank line after declarations > > Signed-off-by: Athira Lekshmi > --- > drivers/staging/octeon/ethernet-rx.c |1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/oc

Re: [PATCH v2] Staging: rtl8188eu: {core, hal, include}: Removed inline function

2014-12-02 Thread Greg KH
On Sat, Nov 29, 2014 at 11:48:07AM +0100, Abel Moyo wrote: > Removed inline function get_my_bssid and open coded all its references > > Signed-off-by: Abel Moyo > --- > Changes in v2: > - Remove inline function entirely and open code the > implementation instead of replacing __inlin

RE: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being continuous

2014-12-02 Thread Jeff Leung
> We have had the Hyper-V clocksource for sometime now and this patch just marks this > clocksource as being continuous. Nothing has changed with regards to timesynch. Alright, that cleared up that question. Gleaning around from the source tree, I don't seem to comprehend what changes are being m

RE: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being continuous

2014-12-02 Thread KY Srinivasan
> -Original Message- > From: Jeff Leung [mailto:jle...@v10networks.ca] > Sent: Tuesday, December 2, 2014 3:58 PM > To: KY Srinivasan; x...@kernel.org; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; de...@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; jasow...@

RE: [PATCH 1/1] X86: Mark the Hyper-V clocksource as being continuous

2014-12-02 Thread Jeff Leung
Does this mean that host-to guest timesync now works properly with Linux guests? -- Jeff > -Original Message- > From: linux-kernel-ow...@vger.kernel.org [mailto:linux-kernel-ow...@vger.kernel.org] > On Behalf Of K. Y. Srinivasan > Sent: Tuesday, December 2, 2014 17:04 > To: x...@kernel.or

[PATCH 1/1] X86: Mark the Hyper-V clocksource as being continuous

2014-12-02 Thread K. Y. Srinivasan
The clocksource based on Hyper-V per-partition reference count MSR is continuous. Mark it accordingly. Signed-off-by: K. Y. Srinivasan cc: sta...@vger.kernel.org --- arch/x86/kernel/cpu/mshyperv.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/arch/x86/kernel/cpu/mshype

[PATCH] Staging: slicoss: Fix long line issues in slicoss.c

2014-12-02 Thread Sean Cleator
A patch to the slicoss.c file to fix some of the long line issues found by the checkpath.pl tool Signed-off-by: Sean Cleator --- drivers/staging/slicoss/slicoss.c | 39 ++- 1 file changed, 26 insertions(+), 13 deletions(-) diff --git a/drivers/staging/sl

[PATCH] staging: rtl8188eu: hal: hal_intf.c: Cleaning up functions that are not used anywhere

2014-12-02 Thread Rickard Strandqvist
Removes some functions that are not used anywhere. rtw_hal_interrupt_handler() rtw_hal_sreset_get_wifi_status() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/staging/rtl8188eu/hal/hal_intf.c | 16 -

[PATCH] drivers: staging: rtl8192e: Include "asm/unaligned.h" instead of "access_ok.h" in "rtl819x_BAProc.c"

2014-12-02 Thread Chen Gang
"asm/unaligned.h" is more generic than "access_ok.h", and it may include "access_ok.h", so need use it instead of "access_ok.h". During building, "rtllib.h" has already include "asm/unaligned.h", so will cause building issue. The related error (with allmodconfig under parisc): CC [M] drivers

RE: [PATCH 1/3] Drivers: hv: hv_balloon: Make adjustments in computing the floor

2014-12-02 Thread KY Srinivasan
> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Tuesday, December 2, 2014 1:51 PM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com; > jasow...@redhat.

Re: [PATCH 1/3] Drivers: hv: hv_balloon: Make adjustments in computing the floor

2014-12-02 Thread Dan Carpenter
On Tue, Dec 02, 2014 at 02:29:13PM -0800, K. Y. Srinivasan wrote: > Make adjustments in computing the balloon floor. > The changelog should say what the user visible effects of the bug are. regards, dan carpenter ___ devel mailing list de...@linuxdriv

Re: [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance

2014-12-02 Thread Andreas Dilger
On Nov 28, 2014, at 11:50 AM, Greg KH wrote: > On Thu, Nov 27, 2014 at 07:34:10PM +0100, Loïc Pefferkorn wrote: >> Hello Greg, >> >> After some investigation, I think that removing these wrappers is not going >> to improve the code readability: >> >> On Wed, Nov 26, 2014 at 12:54:43PM -0800, Gr

[PATCH 3/3] Drivers: hv: hv_balloon: Don't post pressure status from interrupt context

2014-12-02 Thread K. Y. Srinivasan
We currently release memory (balloon down) in the interrupt context and we also post memory status while releasing memory. Rather than posting the status in the interrupt context, wakeup the status posting thread to post the status. This will address the inconsistent lock state that Sitsofe Wheeler

[PATCH 2/3] Drivers: hv: hv_balloon: Fix a locking bug in the balloon driver

2014-12-02 Thread K. Y. Srinivasan
We support memory hot-add in the Hyper-V balloon driver by hot adding an appropriately sized and aligned region and controlling the on-lining of pages within that region based on the pages that the host wants us to online. We do this because the granularity and alignment requirements in Linux are

[PATCH 1/3] Drivers: hv: hv_balloon: Make adjustments in computing the floor

2014-12-02 Thread K. Y. Srinivasan
Make adjustments in computing the balloon floor. Signed-off-by: K. Y. Srinivasan --- drivers/hv/hv_balloon.c |9 + 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c index b958ded..9cbbb83 100644 --- a/drivers/hv/hv_balloo

[PATCH 0/3] Drivers: hv: hv_balloon

2014-12-02 Thread K. Y. Srinivasan
Some bug fixes for the balloon driver. K. Y. Srinivasan (3): Drivers: hv: hv_balloon: Make adjustments in computing the floor Drivers: hv: hv_balloon: Fix a locking bug in the balloon driver Drivers: hv: hv_balloon: Don't post pressure status from interrupt context drivers/hv/hv_balloo

Re: [PATCH v15 06/12] dt-bindings: add document for dw_hdmi

2014-12-02 Thread Philipp Zabel
Hi Andy, Am Dienstag, den 02.12.2014, 15:42 +0800 schrieb Andy Yan: > diff --git a/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt > b/Documentation/devicetree/bindings/drm/bridge/dw_hdmi.txt > new file mode 100644 > index 000..107c1ca > --- /dev/null > +++ b/Documentation/devicetree

Re: [PATCH] Staging: bcm: Fix tab between spaces in InterfaceMacros.h This is a patch to the InterfaceMacros.h file that fixes an added tab instead of a space. Found by the checkpatch.pl tool.

2014-12-02 Thread 1Ago - Pieter Waegeman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Matthias, Thanks for your feedback! That's weird. I can still see the driver in the 'master' branch on https://github.com/torvalds/linux/tree/master/drivers/staging/bcm I've cloned from git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux

Re: [PATCH] Staging: bcm: Fix tab between spaces in InterfaceMacros.h This is a patch to the InterfaceMacros.h file that fixes an added tab instead of a space. Found by the checkpatch.pl tool.

2014-12-02 Thread Matthias Beyer
Hi Pieter, On 02-12-2014 19:04:31, 1Ago - Pieter Waegeman wrote: > That's weird. I can still see the driver in the 'master' branch on > https://github.com/torvalds/linux/tree/master/drivers/staging/bcm > I've cloned from > git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > Or am

Re: [PATCH] Staging: bcm: Fix tab between spaces in InterfaceMacros.h This is a patch to the InterfaceMacros.h file that fixes an added tab instead of a space. Found by the checkpatch.pl tool.

2014-12-02 Thread Matthias Beyer
Hi Pieter, as far as I know, this driver was removed from the source tree. Please update your local copy of the kernel. -- Mit freundlichen Grüßen, Kind regards, Matthias Beyer Proudly sent with mutt. Happily signed with gnupg. On 02-12-2014 18:25:49, Pieter Waegeman wrote: > --- > drivers/st

[PATCH] Staging: bcm: Fix tab between spaces in InterfaceMacros.h This is a patch to the InterfaceMacros.h file that fixes an added tab instead of a space. Found by the checkpatch.pl tool.

2014-12-02 Thread Pieter Waegeman
--- drivers/staging/bcm/InterfaceMacros.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/bcm/InterfaceMacros.h b/drivers/staging/bcm/InterfaceMacros.h index fedb794..67e7b62 100644 --- a/drivers/staging/bcm/InterfaceMacros.h +++ b/drivers/staging/bcm/Interface

[PATCH 10/11] staging: comedi: addi_apci_1500: remove APCI1500_ADDRESS_RANGE

2014-12-02 Thread H Hartley Sweeten
This define is not used by the driver. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci1500.c

[PATCH 01/11] staging: comedi: hwdrv_apci1500: introduce z8536_read()

2014-12-02 Thread H Hartley Sweeten
The Z8536 CIO registers are indirectly read by writing the register value to the control register then reading the control register. Introduce a helper function to read the Z8536 CIO registers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- .../comedi/drivers/addi-d

[PATCH 03/11] staging: comedi: hwdrv_apci1500: introduce z8536_reset()

2014-12-02 Thread H Hartley Sweeten
Introduce a helper function to reset the Z8536 CIO device. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- .../comedi/drivers/addi-data/hwdrv_apci1500.c | 185 - 1 file changed, 69 insertions(+), 116 deletions(-) diff --git a/drivers/staging

[PATCH 11/11] staging: comedi: addi_apci_1500: handle shared interrupt

2014-12-02 Thread H Hartley Sweeten
The interrupt used by this driver is shared. If the board did not cause the interrupt the driver should return IRQ_NONE so that another driver can handle it. Fix the interrupt handler so this happens. Tidy up the interrupt handler a bit. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg

[PATCH 07/11] staging: comedi: addi_apci_1500: use amcc_s5933.h defines

2014-12-02 Thread H Hartley Sweeten
PCI Bar 0 accesses the AMCC S5933 PCI controller used on this board. Use the defines from amcc_35933.h and remove the "magic" numbers. Rename the CamelCase private data member 'i_IobaseAmcc' used to hold the address for PCI Bar 0. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-H

[PATCH 05/11] staging: comedi: addi_apci_1500: remove private data 'iobase'

2014-12-02 Thread H Hartley Sweeten
This member of the private data is the same as the comedi_device 'iobase'. Remove the private data member and use that instead. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- .../comedi/drivers/addi-data/hwdrv_apci1500.c | 28 +- drivers/sta

[PATCH 04/11] staging: comedi: addi_apci_1500: tidy up PCI Bar 1 register map

2014-12-02 Thread H Hartley Sweeten
For aesthetics, convert the enum for the PCI Bar 1 register map to defines and move them to the main driver source file. Rename the registers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- .../comedi/drivers/addi-data/hwdrv_apci1500.c | 35

[PATCH 02/11] staging: comedi: hwdrv_apci1500: introduce z8536_write()

2014-12-02 Thread H Hartley Sweeten
The Z8536 CIO registers are indirectly written by writing the register value to the control register then writing the value to the control register. Introduce a helper function to write the Z8536 CIO registers. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- .../come

[PATCH 09/11] staging: comedi: addi_apci_1500: tidy up PCI Bar 2 register map

2014-12-02 Thread H Hartley Sweeten
Move the PCI Bar 1 register map defines to the main driver source file. For aesthetics, rename the defines. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- .../comedi/drivers/addi-data/hwdrv_apci1500.c | 21 - drivers/staging/comedi/drivers/

[PATCH 00/11] staging: comedi: addi_apci_1500: initial cleanup

2014-12-02 Thread H Hartley Sweeten
This driver is pretty broken but in the current state its difficult to figure out where to fix it. Introduce a couple helper functions to handle the read/write and reset of the Z8536 CIO chip. This removes quite a bit of lines of code and makes the driver a _bit_ easier to follow. Tidy up the reg

[PATCH 06/11] staging: comedi: addi_apci_1500: remove private data 'i_IobaseReserved'

2014-12-02 Thread H Hartley Sweeten
This member of the private data is set but not used by the driver. Remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/addi_apci_1500.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/addi_apci

[PATCH 08/11] staging: comedi: addi_apci_1500: rename private data 'i_IobaseAddon'

2014-12-02 Thread H Hartley Sweeten
Rename this CamelCase member of the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- .../comedi/drivers/addi-data/hwdrv_apci1500.c| 20 drivers/staging/comedi/drivers/addi_apci_1500.c | 4 ++-- 2 files changed, 10 inser

Re: [PATCH] staging:lustre:lnet: Incorrect type in assignment

2014-12-02 Thread Al Viro
On Mon, Dec 01, 2014 at 02:53:52PM +0800, sunwxg wrote: > From: Sun Wang > > Incorrect type when assign value to varible iov_base. Oh, for pity sake... Folks, these struct iovec in there are bloody wrong. It's not iovec at all. There are exactly two declarations in the whole drivers/staging/lu

Re: [PATCH v2] staging: unisys: remove duplicate header

2014-12-02 Thread Romer, Benjamin M
On Tue, 2014-12-02 at 16:20 +0530, Sudip Mukherjee wrote: > these header files were included multiple times > > Signed-off-by: Sudip Mukherjee Looks good to me, thanks for the help. :) Signed-off-by: Benjamin Romer ___ devel mailing list de...@linuxd

[PATCH] Staging: ft1000: fix spaces around comparisons in ft1000_debug.c

2014-12-02 Thread Paul Hedman
This fix fixes spacing issues around operators, e.g. i=0 to i = 0, found by the checkpatch.pl tool. Signed-off-by: Paul Hedman --- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 28 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/staging/ft10

[PATCH] Staging: ft1000: fix various checkpatch.pl issues in ft1000_debug.c

2014-12-02 Thread Paul Hedman
From: Paul This patch fixes various coding standards violations found by the checkpatch.pl tool Signed-off-by: Paul Hedman --- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 948 --- 1 file changed, 478 insertions(+), 470 deletions(-) diff --git a/drivers/staging/ft10

Re: [PATCH] Staging: ft1000: fix various checkpatch.pl issues in ft1000_debug.c

2014-12-02 Thread Sudip Mukherjee
On Tue, Dec 02, 2014 at 08:27:46AM -0600, Paul Hedman wrote: > From: Paul > > This patch fixes various coding standards violations found by the > checkpatch.pl tool > > Signed-off-by: Paul Hedman > --- 1) you are doing multiple things in this patch. please do only one type of fix in a patch.

Re: [PATCH v15 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-12-02 Thread Philipp Zabel
Hi Andy, Am Dienstag, den 02.12.2014, 20:34 +0800 schrieb Andy Yan: > Hi Philipp: > On 2014年12月02日 18:24, Philipp Zabel wrote: > > Hi Andy, > > > > Am Dienstag, den 02.12.2014, 15:45 +0800 schrieb Andy Yan: > > [...] > >> +static int dw_hdmi_rockchip_bind(struct device *dev, struct device > >> *m

Re: [PATCH v15 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-12-02 Thread Andy Yan
Hi Philipp: On 2014年12月02日 18:24, Philipp Zabel wrote: Hi Andy, Am Dienstag, den 02.12.2014, 15:45 +0800 schrieb Andy Yan: [...] +static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master, +void *data) +{ + struct platform_device *pdev = to

[PATCH] staging: rtl8712: remove unnecessary else after return

2014-12-02 Thread Mike Krinkin
Fixes checkpatch warning: WARNING: else is not generally useful after a break or return Signed-off-by: Mike Krinkin --- drivers/staging/rtl8712/rtl8712_recv.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rt

[PATCH] staging: rtl8712: remove unnecessary else after return

2014-12-02 Thread Mike Krinkin
Fixes checkpatch warning: WARNING: else is not generally useful after a break or return Signed-off-by: Mike Krinkin --- drivers/staging/rtl8712/rtl8712_recv.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rt

[PATCH 1/1] lustre: Deletion of unnecessary checks before three function calls

2014-12-02 Thread SF Markus Elfring
From: Markus Elfring Date: Tue, 2 Dec 2014 11:40:33 +0100 The functions free_ll_remote_perm(), free_rmtperm_hash() and iput() test whether their argument is NULL and then return immediately. Thus the test around their calls is not needed. This issue was detected by using the Coccinelle software.

[PATCH v2] staging: unisys: remove duplicate header

2014-12-02 Thread Sudip Mukherjee
these header files were included multiple times Signed-off-by: Sudip Mukherjee --- change in v2: missed seeing that linux/uuid.h is included 3 times drivers/staging/unisys/include/timskmod.h | 1 - drivers/staging/unisys/uislib/uisutils.c | 2 -- 2 files changed, 3 deletions(-) diff --git a/

Re: [PATCH] staging: unisys: remove duplicate header

2014-12-02 Thread Sudip Mukherjee
On Tue, Dec 02, 2014 at 01:46:54AM -0800, Jeremiah Mahler wrote: > Sudip, > > On Tue, Dec 02, 2014 at 02:34:58PM +0530, Sudip Mukherjee wrote: > > these header files were included two times > > > > Signed-off-by: Sudip Mukherjee > > --- > > drivers/staging/unisys/include/timskmod.h | 1 - > > d

Re: [PATCH v15 12/12] drm: bridge/dw_hdmi: add rockchip rk3288 support

2014-12-02 Thread Philipp Zabel
Hi Andy, Am Dienstag, den 02.12.2014, 15:45 +0800 schrieb Andy Yan: [...] > +static int dw_hdmi_rockchip_bind(struct device *dev, struct device *master, > + void *data) > +{ > + struct platform_device *pdev = to_platform_device(dev); > + const struct dw_hdmi_pl

Re: [PATCH 1/2] staging: android: ion: Deletion of unnecessary checks before two function calls

2014-12-02 Thread Thierry Reding
On Sun, Nov 23, 2014 at 07:39:23PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 23 Nov 2014 18:48:15 +0100 > > The functions ion_heap_destroy() and vfree() perform also input > parameter validation. Thus the test around the call is not needed. > > This issue was detected b

Re: [PATCH] staging: unisys: remove duplicate header

2014-12-02 Thread Jeremiah Mahler
Sudip, On Tue, Dec 02, 2014 at 02:34:58PM +0530, Sudip Mukherjee wrote: > these header files were included two times > > Signed-off-by: Sudip Mukherjee > --- > drivers/staging/unisys/include/timskmod.h | 1 - > drivers/staging/unisys/uislib/uisutils.c | 1 - > 2 files changed, 2 deletions(-) >

[PATCH] staging: unisys: remove duplicate header

2014-12-02 Thread Sudip Mukherjee
these header files were included two times Signed-off-by: Sudip Mukherjee --- drivers/staging/unisys/include/timskmod.h | 1 - drivers/staging/unisys/uislib/uisutils.c | 1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/unisys/include/timskmod.h b/drivers/staging/unisys/includ