Re: [PATCH] Revert "staging: sm7xxfb: remove driver"

On Sat, Nov 22, 2014 at 09:50:20PM +0530, Sudip Mukherjee wrote: > On Sat, Nov 22, 2014 at 06:00:40AM -0800, Greg Kroah-Hartman wrote: > > On Sat, Nov 22, 2014 at 12:32:02PM +0530, Sudip Mukherjee wrote: > > > 2) most important - I do not have the hardware. So from the TODO list > > > dual head and

[PATCH] staging:lustre:lnet: Incorrect type in assignment

From: Sun Wang Incorrect type when assign value to varible iov_base. Signed-off-by: Sun Wang --- .../drivers => drivers}/staging/lustre/lnet/lnet/lib-move.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c b/drivers/s

Re: [PATCH] staging:lustre:lnet: Incorrect type in assignment

On Mon, 2014-12-01 at 14:18 +0800, sunwxg wrote: > Incorrect type when assign value to varible iov_base. [] > diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c > b/drivers/staging/lustre/lnet/lnet/lib-move.c [] > @@ -256,7 +256,8 @@ lnet_extract_iov(int dst_niov, struct iovec *dst, >

[PATCH] staging:lustre:lnet: Incorrect type in assignment

From: Sun Wang Incorrect type when assign value to varible iov_base. Signed-off-by: Sun Wang --- .../drivers => drivers}/staging/lustre/lnet/lnet/lib-move.c| 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lnet/lnet/lib-move.c b/drivers/s

Re: PATCH

Hi Greg, I have looked at the patches and documentation on how to proceed forward. But I have a doubt. Was hoping you could make it clear for me. You have said that you don't want unnecessary binary firmware files in the source which is really good. But if I how do I know which binary files are req

[PATCH] staging: comedi: change some printk calls to pr_err

There are a handful of calls to printk in ni_stc.h without specified log levels, as well as one in ni_mio_common.c. This patch converts these calls to pr_err() instead, so that they are now explicitly log level ERR. Signed-off-by: Chase Southwood --- I tacked the change to ni_mio_common.c on to

Re: Possible memory leak in function (reserve_range) not freeing pointer (regionid)

On Sun, Nov 30, 2014 at 8:51 PM, Greg KH wrote: > On Sun, Nov 30, 2014 at 02:00:45PM -0600, Ahmed Tamrawi wrote: >> Bug Report: https://bugzilla.kernel.org/show_bug.cgi?id=89101 >> Linux Version [3.17-rc1] > > That's a very old kernel version. It does exist on the latest version (v3.18-rc7) > >> C

Re: Possible memory leak in function (reserve_range) not freeing pointer (regionid)

On Sun, Nov 30, 2014 at 02:00:45PM -0600, Ahmed Tamrawi wrote: > Bug Report: https://bugzilla.kernel.org/show_bug.cgi?id=89101 > Linux Version [3.17-rc1] That's a very old kernel version. > Configuration: Default configuration for x86 > > > Function (reserve_range) in file (drivers/pnp/system.c

Re: PATCH

On Sun, Nov 30, 2014 at 08:54:08PM +, Parth Sane wrote: > Hi, > Please find the attached patch file. I hope it's OK. > -Parth > > From 3a429077981db3a7cf96d1e503c0bbbc932cab32 Mon Sep 17 00:00:00 2001 > From: Parth Sane > Date: Mon, 1 Dec 2014 01:55:47 +0530 > Subject: [PATCH] added_missing_

[PATCH] staging: rt8192u: fix sparse warnings in r8192U_core.c

Fixed the following warnings in sparse: drivers/staging/rtl8192u/r8192U_core.c:670:6: warning: symbol 'dump_eprom' was not declared. Should it be static? drivers/staging/rtl8192u/r8192U_core.c:1489:5: warning: symbol 'ComputeTxTime' was not declared. Should it be sta

[PATCH] staging: lustre: fix sparse warnings: static function declaration

Signed-off-by: Vincenzo Scotti --- drivers/staging/lustre/lustre/ptlrpc/layout.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/ptlrpc/layout.c b/drivers/staging/lustre/lustre/ptlrpc/layout.c index 252f3e1..dc5ceb5 100644 --- a/drivers/staging/l

[PATCH 25/28] staging: rtl8723au: _ResetDigitalProcedure1_92C() reduce code obfuscation

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 62 +++ 1 file changed, 30 insertions(+), 32 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init

[PATCH 18/28] staging: rtl8723au: rtl8723au_read_interrupt() addr argument wasn't used

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 4 ++-- drivers/staging/rtl8723au/hal/usb_ops_linux.c | 2 +- drivers/staging/rtl8723au/include/rtl8723a_recv.h | 2 -- drivers/staging/rtl8723au/include/usb_ops_linux.h | 2 +- 4 files ch

[PATCH 13/28] staging: rtl8723au: Do not write garbage to REG_SPS0_CTRL

From: Jes Sorensen Use a separate variable to hold the value of REG_SPS0_CTRL to avoid it getting clobbered and writing out garbage to it, for the case of eRFPowerState == rf_sleep/rf_off && bRegSSPwrLvl == 1. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 19 +++

[PATCH 26/28] staging: rtl8723au: Remove unnecessary wrapper _ResetDigitalProcedure1()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c index 222dcd

[PATCH 22/28] staging: rtl8723au: _DisableRFAFEAndResetBB8192C(): Use correct enum value

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c index 267a80b..d2b4

[PATCH 07/28] staging: rtl8723au: Remove unused rtw_sctx_done23a() function

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_xmit.c| 5 - drivers/staging/rtl8723au/include/rtw_xmit.h | 1 - 2 files changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b/drivers/staging/rtl8723au/core/rtw_xmit.c ind

[PATCH 15/28] staging: rtl8723au: phy_SsPwrSwitch92CU() was never called with bRegSSPwrLvl != 1

From: Jes Sorensen Get rid of the alternate code paths since these weren't used and have never been tested according to the in-code comments. Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 322 1 file changed, 84 insertions(+), 238 de

[PATCH 08/28] staging: rtl8723au: Remove write only struct hal_data_8723a.interfaceIndex

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 2 -- drivers/staging/rtl8723au/include/rtl8723a_hal.h | 3 --- 2 files changed, 5 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_ha

[PATCH 16/28] staging: rtl8723au: Use a local variable to state if MAC was already powered on

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 15 --- drivers/staging/rtl8723au/include/rtl8723a_hal.h | 2 -- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drive

[PATCH 27/28] staging: rtl8723au: _DisableAnalog(): Avoid zero-init variables unnecessarily

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c index b2048b

[PATCH 19/28] staging: rtl8723au: Remove unused slimcombo debug flag

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 11 --- drivers/staging/rtl8723au/include/rtl8723a_hal.h | 4 2 files changed, 15 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723

[PATCH 03/28] staging: rtl8723au: Fold ODM_PhyStatusQuery23a_92CSeries() into ODM_PhyStatusQuery23a()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/odm_HWConfig.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/odm_HWConfig.c b/drivers/staging/rtl8723au/hal/odm_HWConfig.c index 29d844d..fb3cc87

[PATCH 04/28] staging: rtl8732au: Partial clean up of rtl8723a_rf6052.c

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c | 229 +--- 1 file changed, 123 insertions(+), 106 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c b/drivers/staging/rtl8723au/hal/rtl8723a_rf6052.c

[PATCH 21/28] staging: rtl8723au: Fold _BlockWrite() into _PageWrite()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c ind

[PATCH 05/28] staging: rtl8723au: Fold rtw_ack_tx_done23a() into rtw23a_sctx_done_err()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/Makefile| 1 - drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 15 +++ drivers/staging/rtl8723au/hal/rtl8723a_xmit.c | 31 --- drivers/staging/rtl8723au/include/rtw_

[PATCH 12/28] staging: rtl8723au: Remove no-op _InitHWLed() function

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_halinit.c index 4cc0a0f..762c514 100644 --- a/drivers/staging/

[PATCH 28/28] staging: rtl8723au: Hal_InitPGData() avoid unnecessary typecasts

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c index 2e1d

[PATCH 09/28] staging: rtl8723au: Fold rtl8723au_set_queue_pipe_mapping into rtl8723au_chip_configure()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 27 --- drivers/staging/rtl8723au/include/usb_ops.h | 2 +- drivers/staging/rtl8723au/os_dep/usb_intf.c | 3 ++- 3 files changed, 11 insertions(+), 21 deletions(-) diff --

[PATCH 17/28] staging: rtl8723au: rtl8723au_read_port() addr argument wasn't used

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 3 +-- drivers/staging/rtl8723au/hal/usb_ops_linux.c | 19 --- drivers/staging/rtl8723au/include/rtl8723a_recv.h | 1 - drivers/staging/rtl8723au/include/usb_ops_linux.h

[PATCH 00/28] staging: rtl8723au: Lazy Sunday fixes

From: Jes Sorensen Hi, Pleased find attached a couple of fixes and cleanups for the rtl8723au staging driver. One serious bug fixe in 13/28, but follow-on changes showed the code was never actually called. Should be good for staging-next, don't think any of it is more urgent than that. Cheers,

[PATCH 24/28] staging: rtl8723au: Remove unnecessary wrapper _DisableRFAFEAndResetBB()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c index 3aa20f6.

[PATCH 10/28] staging: rtl8723au: _InitPowerOn(): Don't zero init variables unnecessarily

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_halinit.c index b8d5040..3b09dc2 100644 ---

[PATCH 02/28] staging: rtl8723au: recv_priv->rssi is not used for anything

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_mlme.c| 6 ++ drivers/staging/rtl8723au/core/rtw_recv.c| 10 -- drivers/staging/rtl8723au/include/rtw_recv.h | 1 - 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers

[PATCH 20/28] staging: rtl8723au: rtl8723a_update_ramask(): Fix up some bad formatting

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 37 ++--- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_halinit.c index b15

[PATCH 11/28] staging: rtl8723au: Fold _InitNormalChipQueuePriority() into _InitQueuePriority()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_halinit.c index 3b09dc2..4cc0a0f 100644 --- a

[PATCH 23/28] staging: rtl8723au: _DisableRFAFEAndResetBB8192C(): Reduce code obfuscation

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c index d2b4fb0..3

[PATCH 06/28] staging: rtl8723au: Eliminate do_queue_select() functions

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_xmit.c | 14 +- drivers/staging/rtl8723au/hal/rtl8723au_xmit.c | 14 +- 2 files changed, 2 insertions(+), 26 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_xmit.c b

[PATCH 14/28] staging: rtl8723au: Fold _ps_open_RF23a() into rtl8723au_hal_init()

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 16 +++- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/staging/rtl8723au/hal/usb_halinit.c index 6c66013..cd3f8ba 1

[PATCH 01/28] staging: rtl8723au: recv_priv.is_signal_dbg is never set

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/core/rtw_recv.c| 104 --- drivers/staging/rtl8723au/include/rtw_recv.h | 2 - 2 files changed, 46 insertions(+), 60 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_recv.c b/

Possible memory leak in function (reserve_range) not freeing pointer (regionid)

Bug Report: https://bugzilla.kernel.org/show_bug.cgi?id=89101 Linux Version [3.17-rc1] Configuration: Default configuration for x86 Function (reserve_range) in file (drivers/pnp/system.c) allocates pointer (regionid) on line (32) and passes it to function (__request_region) through the macros: (r

Re: [PATCH] staging: lustre: fix sparse warnings related to lock context imbalance

On Fri, Nov 28, 2014 at 02:22:07PM -0800, Greg KH wrote: > > That's even worse than I imagined. Putting sparse markings on these > function calls is just papering over nonsense. Please work on unwinding > the mess so that you don't need callbacks for locks, that is an > abstraction that isn't ne

[PATCH 3/4] staging: unisys: remove unneeded structure

From: Julia Lawall Delete a local structure that is only used to be initialized by memset. A semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ identifier x,i; @@ { ... when any -struct i x; <+... when != x - memset(&x,...); ...+> } // Signed-off-by: Jul

[PATCH 0/4] remove unneeded array

Remove an array or structure that only serves as the first argument to memset. The complete semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ identifier x; type T; @@ { ... when any -T x[...]; <+... when != x - memset(x,...); ...+> } @@ identifier x,i; @@

Re: [PATCH v3] Drivers:staging:clocking-wizard: Added a newline

On Sun, 2014-11-30 at 02:16PM +0530, Athira Sharikkal wrote: > Fixed checkpatch warning: > Missing a newline after declarations There are two such warnings. If we gonna fix them, please fix them all. > > Signed-off-by: Athira Sharikkal Acked-by: Soren Brinkmann Thanks, Sören _

Re: [PATCH] staging:drivers:staging:clocking-wizard:clk-xlnx-clock-wizard.c: Added a line after declaration

On Sat, 2014-11-29 at 06:25PM +0530, Anjana Sasindran wrote: > This patch fix the checkpatch.pl warning > > WARNING:Missing a blank line after declaration There are two such warnings. If we gonna fix them, please fix them all. > > Signed-off-by: Anjana Sasindran Acked-by: Soren Brinkmann

Re: [PATCH] staging: clocking-wizard: check for a valid clk_name pointer

On Sat, 2014-11-29 at 05:48PM -0500, Devendra Naga wrote: > The clk_name gets the return value from kasprintf (part of which does the > allocation of the returned buffer). So check the return pointer > before using it for clk_register_fixed_factor. > > Cc: Soren Brinkmann > Signed-off-by: Devendr

[PATCH] staging: rtl8723au: hal: Removed the extra semicolon

This patch fix the checkpatch.pl warning: WARNING: Statement terminations use 1 semicolon Signed-off-by: Anjana Sasindran --- drivers/staging/rtl8723au/hal/rtl8723a_bt-coexist.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_bt-c

Re: [PATCH] drivers:staging:octeon:ethernet-rx.c: Added blank line after declarations

On 11/30, Anjana Sasindran wrote: > This patch fixes the checkpatch.pl warnings: Your subject line is somewhat broken as it does not really follow the canonical patch format. You can read up on it here (section 15) https://www.kernel.org/doc/Documentation/SubmittingPatches and this is the short ve

[PATCH] drivers:staging:octeon:ethernet-rx.c: Added blank line after declarations

This patch fixes the checkpatch.pl warnings: WARNING: Missing blank line after declaration Signed-off-by: Anjana Sasindran --- drivers/staging/octeon/ethernet-rx.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.

[PATCH] drivers:staging:media:omap24xx:v4l2-int-device.h: Added a '*' before ')'--(parenthesis closing)

This patch fix a checkpatch.pl error: ERROR: space prohibited before ')' parenthesis closing Signed-off-by: Anjana Sasindran --- drivers/staging/media/omap24xx/v4l2-int-device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/media/omap24xx/v4l2-int-device.h

[PATCHv1] staging: lustre: fixed sparse warnings related to static declarations

drivers/staging/lustre/lustre/mdc/mdc_request.c:63:5: warning: symbol 'mdc_unpack_capa' was not declared. Should it be static? drivers/staging/lustre/lustre/mdc/mdc_request.c:150:5: warning: symbol 'mdc_getstatus' was not declared. Should it be static? drivers/staging/lustre/lustre/mdc/mdc_reques

[PATCH v3] Drivers:staging:clocking-wizard: Added a newline

Fixed checkpatch warning: Missing a newline after declarations Signed-off-by: Athira Sharikkal --- drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c b/drivers/staging/clocking-wizar

[PATCH] Drivers:staging:clocking-wizard: Added a newline

From: Athira S Fixed checkpatch warning: Missing a newline after declarations Signed-off-by: Athira S --- drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/clocking-wizard/clk-xlnx-clock-wizard.c b/drivers/staging/clock