RE: [PATCH] hv: hv_balloon: avoid memory leak on alloc_error of 2MB memory block

2014-11-23 Thread Dexuan Cui
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Monday, November 24, 2014 15:28 PM > To: Dexuan Cui; gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > driverdev-devel@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; KY Srinivasan > Cc: Hai

Re: [PATCH] hv: hv_balloon: avoid memory leak on alloc_error of 2MB memory block

2014-11-23 Thread Jason Wang
On 11/24/2014 02:08 PM, Dexuan Cui wrote: >> -Original Message- >> > From: Jason Wang [mailto:jasow...@redhat.com] >> > Sent: Monday, November 24, 2014 13:18 PM >> > To: Dexuan Cui; gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; >> > driverdev-devel@linuxdriverproject.org; o...@a

RE: [PATCH] hv: hv_balloon: avoid memory leak on alloc_error of 2MB memory block

2014-11-23 Thread Dexuan Cui
> -Original Message- > From: Jason Wang [mailto:jasow...@redhat.com] > Sent: Monday, November 24, 2014 13:18 PM > To: Dexuan Cui; gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > driverdev-devel@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; KY Srinivasan > Cc: Hai

Re: [PATCH] hv: hv_balloon: avoid memory leak on alloc_error of 2MB memory block

2014-11-23 Thread Jason Wang
On 11/24/2014 01:56 PM, Dexuan Cui wrote: > If num_ballooned is not 0, we shouldn't neglect the already-allocated 2MB > memory block(s). > > Cc: K. Y. Srinivasan > Cc: > Signed-off-by: Dexuan Cui > --- > drivers/hv/hv_balloon.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff

[PATCH] hv: hv_balloon: avoid memory leak on alloc_error of 2MB memory block

2014-11-23 Thread Dexuan Cui
If num_ballooned is not 0, we shouldn't neglect the already-allocated 2MB memory block(s). Cc: K. Y. Srinivasan Cc: Signed-off-by: Dexuan Cui --- drivers/hv/hv_balloon.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/hv/hv_balloon.c b/drivers/hv/hv_balloon.c ind

[PATCH] staging: rtl8192e: add missing tasklet_kill on remove path

2014-11-23 Thread Devendra Naga
The powersave tasklet is created in rtllib_softmac_init and it is not removed while unloading the module. Cc: Larry Finger Signed-off-by: Devendra Naga --- Compile tested only on top the linux-next for : 20141121 drivers/staging/rtl8192e/rtllib_softmac.c | 1 + 1 file changed, 1 insertion(+)

[PATCH] staging: lustre: Fix sparse warnings for lnet/lnet/router.c

2014-11-23 Thread Giedrius Statkevicius
Fix the following sparse errors: drivers/staging/lustre/lnet/lnet/router.c:756:1: warning: symbol 'lnet_wait_known_routerstate' was not declared. Should it be static? drivers/staging/lustre/lnet/lnet/router.c:788:1: warning: symbol 'lnet_update_ni_status_locked' was not declared. Should it be sta

[PATCH 2/2] staging: android: ion: One function call less in ion_buffer_create() after error detection

2014-11-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 23 Nov 2014 19:12:29 +0100 The jump label "err1" was used by the ion_buffer_create() function in case of a memory allocation failure just to pass a null pointer to a vfree() function call by a data structure element. This implementation detail could be improved by

[PATCH 1/2] staging: android: ion: Deletion of unnecessary checks before two function calls

2014-11-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 23 Nov 2014 18:48:15 +0100 The functions ion_heap_destroy() and vfree() perform also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/sta

Re: net: Hyper-V: Deletion of an unnecessary check before the function call "vfree"

2014-11-23 Thread David Miller
From: SF Markus Elfring Date: Sun, 23 Nov 2014 08:18:31 +0100 >> Whereas if you learn how to base your changes cleanly on the correct >> base now, all of your future submissions will go quickly and smoothly >> into my tree. > > My reluctance to work with more Linux repositories will evolve > ove

[PATCH 0/2] staging: android: ion: Deletion of a few unnecessary checks

2014-11-23 Thread SF Markus Elfring
From: Markus Elfring Date: Sun, 23 Nov 2014 19:13:56 +0100 Another update suggestion was taken into account after a patch was applied from static source code analysis. Markus Elfring (2): Deletion of unnecessary checks before two function calls One function call less in ion_buffer_create() a

Re: [PATCH] Drivers:staging:wlan-ng: Fixed line over 80 characters warning

2014-11-23 Thread Greg KH
On Sun, Nov 23, 2014 at 03:26:54PM +0530, Lekshmi wrote: > The following chaeckpatch warning was fixed: > WARNING: line over 80 characters > > Signed-off-by: Lekshmi I need a "full and real" name here in order to be able to accept any patch. ___ devel

Re: [PATCH] Drivers:staging:wlan-ng: Fixed line over 80 characters warning

2014-11-23 Thread Sudip Mukherjee
On Sun, Nov 23, 2014 at 03:26:54PM +0530, Lekshmi wrote: > The following chaeckpatch warning was fixed: > WARNING: line over 80 characters > > Signed-off-by: Lekshmi > --- > drivers/staging/wlan-ng/prism2fw.c |6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/driv

[PATCH 09/10] staging: lustre: ldlm: Remove space before braces for defined() check

2014-11-23 Thread Andreas Ruprecht
checkpatch complains about two places where a space is prohibited before the braces for in "#if defined()" check. This patch removes these warnings. Signed-off-by: Andreas Ruprecht --- drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 2 +- drivers/staging/lustre/lustre/ldlm/ldlm_resource.c |

[PATCH 04/10] staging: lustre: ldlm: Fix indentation errors for switch-case

2014-11-23 Thread Andreas Ruprecht
checkpatch complains about two indentation errors where the case statements are on a higher indentation level than the corresponding switch statement. This patch removes these errors. Signed-off-by: Andreas Ruprecht --- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c| 36 +++--

[PATCH 00/10] staging: lustre: ldlm: Fix some checkpatch warnings and errors

2014-11-23 Thread Andreas Ruprecht
This patch series removes warnings generated by scripts/checkpatch.pl in the lustre/ldlm/ subdirectory of the driver. Not all warnings are covered by this, especially the ones about quoted strings being split across lines, but I currently don't see a checkpatch.pl-conform way to reformat those. So

[PATCH 01/10] staging: lustre: ldlm: Add missing newlines after declarations

2014-11-23 Thread Andreas Ruprecht
checkpatch.pl complains about a number of missing newlines after declarations. This patch gets rid of these warnings. Signed-off-by: Andreas Ruprecht --- drivers/staging/lustre/lustre/ldlm/interval_tree.c | 5 + drivers/staging/lustre/lustre/ldlm/ldlm_extent.c | 4 +++- drivers/staging/lus

[PATCH 03/10] staging: lustre: ldlm: Fix warning about missing spaces

2014-11-23 Thread Andreas Ruprecht
checkpatch.pl complains about a number of places where spaces were missing. This patch fixes all of these errors. For better readability, the warning of hitting the 80 character per line limit in line 1349 introduced by this change is ignored deliberately. Signed-off-by: Andreas Ruprecht --- dr

[PATCH 08/10] staging: lustre: ldlm: Remove unnecessary braces at ifs

2014-11-23 Thread Andreas Ruprecht
checkpatch complains about three places where braces are not necessary. This patch removes the braces. Signed-off-by: Andreas Ruprecht --- drivers/staging/lustre/lustre/ldlm/ldlm_pool.c| 8 +++- drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 3 +-- 2 files changed, 4 insertions(+),

[PATCH 10/10] staging: lustre: ldlm: Add a space in debug output

2014-11-23 Thread Andreas Ruprecht
A space which was forgotten in a CDEBUG output is added by this patch. Signed-off-by: Andreas Ruprecht --- drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_request.c b/drivers/staging/lu

[PATCH 02/10] staging: lustre: ldlm: Fix overlong lines

2014-11-23 Thread Andreas Ruprecht
checkpatch complains about a number of lines which are over the 80 character line limit. This patch changes most of them to comply, the few remaining lines with warnings are not changed for readability reasons. Signed-off-by: Andreas Ruprecht --- drivers/staging/lustre/lustre/ldlm/ldlm_flock.c

[PATCH 05/10] staging: lustre: ldlm: Fix initialization of static variables

2014-11-23 Thread Andreas Ruprecht
checkpatch complains about static variables being initialized to 0 which is unnecessary. This patch removes the initialization. Signed-off-by: Andreas Ruprecht --- drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 2 +- drivers/staging/lustre/lustre/ldlm/ldlm_request.c | 2 +- 2 files changed,

[PATCH 07/10] staging: lustre: ldlm: Remove unnecessary line continuations

2014-11-23 Thread Andreas Ruprecht
checkpatch finds two unnecessary line continuations in ldlm_lockd.c which are removed by this patch. Signed-off-by: Andreas Ruprecht --- drivers/staging/lustre/lustre/ldlm/ldlm_lockd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm

[PATCH 06/10] staging: lustre: ldlm: Fix warning about unneeded return statement

2014-11-23 Thread Andreas Ruprecht
checkpatch complains about an unneeded return statement in the function search_granted_lock(), which is removed by this patch. Signed-off-by: Andreas Ruprecht --- drivers/staging/lustre/lustre/ldlm/ldlm_lock.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/ldlm/

[PATCH] Drivers:staging:wlan-ng: Fixed line over 80 characters warning

2014-11-23 Thread Lekshmi
The following chaeckpatch warning was fixed: WARNING: line over 80 characters Signed-off-by: Lekshmi --- drivers/staging/wlan-ng/prism2fw.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/wlan-ng/prism2fw.c b/drivers/staging/wlan-ng/prism2fw.c index