Re: [PATCH] Staging:skein: Fix trailing whitespace error

On Fri, Nov 21, 2014 at 05:11:27AM +0530, Anjana Sasindran wrote: > This patch fixes the checkpatch.pl error: > > ERROR: trailing whitespace > > Signed-off-by: Anjana Sasindran > --- > arch/arm/boot/dts/include/dt-bindings | 1 - > arch/metag/boot/dts/include/dt-bindings | 1 - > arch/mips/bo

RE: [PATCH] hv: hv_fcopy: drop the obsolete message on transfer failure

> -Original Message- > From: KY Srinivasan > Sent: Friday, November 21, 2014 1:58 AM > To: Dexuan Cui; gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > driverdev-devel@linuxdriverproject.org; o...@aepfle.de; > a...@canonical.com; jasow...@redhat.com > Cc: Haiyang Zhang > Subject:

Is the list moderated or not?

On Thu, 2014-11-20 at 15:43 -0800, hpdd-discuss-ow...@lists.01.org wrote: > You must be a subscriber to post to this list. Please make sure you > are sending from a subscribed email address. The linux-kernel MAINTAINERS file has this as a moderated list. If it's not moderated, this entry should b

[PATCH] Staging:skein: Fix trailing whitespace error

This patch fixes the checkpatch.pl error: ERROR: trailing whitespace Signed-off-by: Anjana Sasindran --- drivers/staging/skein/skein_generic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/skein/skein_generic.c b/drivers/staging/skein/skein_generic.c index 7096d5a..86

Re: [PATCH] Revert "staging: sm7xxfb: remove driver"

On Thu, 2014-11-20 at 17:09 -0500, Steven Rostedt wrote: > Someone reported a bug in the function graph tracer for MIPS. As I'm > still waiting on my USB serial for my Imagination MIPS board, I decided > to bring my Lemote Yeeloong laptop back up to the latest kernel. This > is where I noticed that

[PATCH] Staging:skein: Fix trailing whitespace error

This patch fixes the checkpatch.pl error: ERROR: trailing whitespace Signed-off-by: Anjana Sasindran --- arch/arm/boot/dts/include/dt-bindings | 1 - arch/metag/boot/dts/include/dt-bindings | 1 - arch/mips/boot/dts/include/dt-bindings | 1 - drivers/staging/skein/skein_generic.c | 2 -- 4

Re: [PATCH] Revert "staging: sm7xxfb: remove driver"

On Thu, Nov 20, 2014 at 05:09:25PM -0500, Steven Rostedt wrote: > > Someone reported a bug in the function graph tracer for MIPS. As I'm > still waiting on my USB serial for my Imagination MIPS board, I decided > to bring my Lemote Yeeloong laptop back up to the latest kernel. This > is where I no

[PATCH 04/19] staging: comedi: adv_pci1724: remove NUM_AO_CHANNELS define

This define is now only used to set each of the subdevice 'n_chan'. For clarity, remove the define and open code the values. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1724.c | 8 +++- 1 file changed, 3 insertions(+), 5

[PATCH 00/19] staging: comedi: adv_pci1724: cleanup driver

Following is the big cleanup for the adv_pci1724 driver. H Hartley Sweeten (19): staging: comedi: adv_pci1724: use subdevice readback for 'ao_value' staging: comedi: adv_pci1724: use subdevice readback for 'offset_value' staging: comedi: adv_pci1724: use subdevice readback for 'gain_value'

[PATCH 11/19] staging: comedi: adv_pci1724: define the sync output control/status reg

Define the bits for the synchronous output control/status register and remove the enum. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1724.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/dr

[PATCH 14/19] staging: comedi: adv_pci1724: absorb setup_subdevices()

For aesthetics, absorb this function into the (*auto_attach). Add some whitespace to the subdevice init. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1724.c | 83 1 file changed, 35 insertions(+),

[PATCH 10/19] staging: comedi: adv_pci1724: define the dac control register bits

Define the bits for the DAC control register and remove the enum along with the helper functions. Simplify adv_pci1724_insn_write() a bit. The 'ctrl' bits are based on the 'chan' and 'mode' and do not need to be recalculated for each 'val'. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Gr

[PATCH 07/19] staging: comedi: adv_pci1724: absorb set_dac()

Absorb this simple function into adv_pci1724_insn_write(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1724.c | 20 +--- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/staging/comedi/dr

[PATCH 18/19] staging: comedi: adv_pci1724: tidy up multi-line comments

Tidy up the multi-line comments to follow the CodingStyle. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1724.c | 94 +--- 1 file changed, 44 insertions(+), 50 deletions(-) diff --git a/drivers/staging/

[PATCH 19/19] staging: comedi: adv_pci1724: rename ao_ranges_1724

For aesthetics, rename the analog output comedi_lrange table so it has namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1724.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff -

[PATCH 17/19] staging: comedi: adv_pci1724: tidy up the comedi_driver declaration

For aesthetics, add some whitespace to the comedi_driver declaration. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1724.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drive

[PATCH 15/19] staging: comedi: adv_pci1724: remove unnecessary dev_info()

Remove the unnecessary noise at the end of the (*auto_attach). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1724.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/adv_pci1724.c b/drivers/st

[PATCH 16/19] staging: comedi: adv_pci1724: tidy up the pci_driver declaration

For aesthetics, add some whitespace to the pci_driver declaration. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1724.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/comedi/drivers

[PATCH 05/19] staging: comedi: adv_pci1724: introduce adv_pci1724_insn_write()

The analog output, offset calib, and gain calib subdevices all use similar (*insn_write) functions. The onyl difference is the 'mode' that is passed to the set_dac() helper. Introduce a new (*insn_write) function that can be used by all the subdevices. Use the s->private member to pass the 'mode'

[PATCH 12/19] staging: comedi: adv_pci1724: remove enum sync_output_trigger_contents

This enum is not used in the driver. Remove it. For aesthetics, rename the register define and move the comment that any value will trigger the sync output. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1724.c | 6 +- 1 fi

[PATCH 03/19] staging: comedi: adv_pci1724: use subdevice readback for 'gain_value'

Use the comedi_subdevice 'readback' member and the core provided (*insn_read) to handle the readback of the write-only gain calib subdevice. Remove the then unused 'gain_value' member from the private data. The private data is now unnecessary. Remove it and the allocation. Signed-off-by: H Hartle

[PATCH 09/19] staging: comedi: adv_pci1724: tidy up the register I/O map

For aesthetics, convert the enum board_registers into defines and rename them so they have namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1724.c | 24 1 file changed

[PATCH 13/19] staging: comedi: adv_pci1724: define the board id register bits

For aesthetics, remove the enum and define the bits for this register. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1724.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/comedi/d

[PATCH 08/19] staging: comedi: adv_pci1724: remove PCI_VENDOR_ID_ADVANTECH define

This define is already in pci_ids.h. Remove the duplicate in this driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1724.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/adv_pci1724.c b

[PATCH 02/19] staging: comedi: adv_pci1724: use subdevice readback for 'offset_value'

Use the comedi_subdevice 'readback' member and the core provided (*insn_read) to handle the readback of the write-only offset calib subdevice. Remove the then unused 'offset_value' member from the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/

[PATCH 01/19] staging: comedi: adv_pci1724: use subdevice readback for 'ao_value'

Use the comedi_subdevice 'readback' member and the core provided (*insn_read) to handle the readback of the write-only analog output subdevice. Remove the then unused 'ao_value' member from the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/sta

[PATCH 06/19] staging: comedi: adv_pci1724: use comedi_timeout() to wait for DAC idle state

Use the comedi_timeout() helper to wait for the DAC to be idle before writing to it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1724.c | 33 +++- 1 file changed, 13 insertions(+), 20 deletions(-) dif

[PATCH 01/19] staging: comedi: drivers: have core hook up default (*insn_read) for readback

Most of the comedi drivers that provide readback for write only subdevices now use the comedi core comedi_alloc_subdev_readback() helper to allocate the subdevice 'reaback' member instead of using some member in their private data. These drivers also hook up the (*insn_read) callback to the comed

[PATCH 19/19] staging: comedi: ni_labpc_common: use comedi_timeout() when writing to eeprom

Use the comedi_timeout() helper to wait for the eeprom to be ready to accept writes and remove the timeout loop in labpc_eeprom_write(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_labpc_common.c | 37 1

[PATCH] Revert "staging: sm7xxfb: remove driver"

Someone reported a bug in the function graph tracer for MIPS. As I'm still waiting on my USB serial for my Imagination MIPS board, I decided to bring my Lemote Yeeloong laptop back up to the latest kernel. This is where I noticed that the screen no longer displays anything. I ran a bisect, which

[PATCH 10/19] staging: comedi: cb_pcidas: use subdevice readback for 'trimpot_value'

Use the comedi_subdevice 'readback' member and the core provided (*insn_read) to handle the readback of the write-only trimpot calib subdevice. Remove the then unused 'trimpot_value' member from the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- driver

[PATCH 03/19] staging: comedi: cb_pcidas64: fix calib_write_insn()

The comedi core expects the (*insn_write) functions to write 'insn->n' values to the hardware and return the number of values written. Currently this function only writes the first value. For this subdevice it only makes sense to write the final data value. Fix the function to work like the core e

[PATCH 09/19] staging: comedi: cb_pcidas: fix trimpot_write_insn()

The comedi core expects the (*insn_write) functions to write 'insn->n' values to the hardware and return the number of values written. Currently this function only writes the first value. For this subdevice it only makes sense to write the final data value. Fix the function to work like the core e

[PATCH 18/19] staging: comedi: ni_labpc_common: use subdevice readback for eeprom

Use the comedi_subdevice 'readback' member and the core provided (*insn_read) to handle the readback of the eeprom subdevice. Remove the then unused 'eeprom_data' member from the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/dri

[PATCH 17/19] staging: comedi: ni_labpc_common: use subdevice readback for analog outputs

Use the comedi_subdevice 'readback' member and the core provided (*insn_read) to handle the readback of the analog output subdevice. Remove the then unused 'ao_value' member from the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi

[PATCH 04/19] staging: comedi: cb_pcidas64: use subdevice readback for 'ad8402_state'

Use the comedi_subdevice 'readback' member and the core provided (*insn_read) to handle the readback of the write-only calibration subdevice. Remove the then unused 'ad8402_state' member from the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/s

[PATCH 13/19] staging: comedi: ni_at_ao: use subdevice readback for 'caldac'

Use the comedi_subdevice 'readback' member and the core provided (*insn_read) to handle the readback of the write-only caldac subdevice. Remove the then unused 'caldac' member from the private data. Tidy up atao_calib_insn_write(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah

[PATCH 14/19] staging: comedi: ni_labpc_common: move calib readback value check/save to (*insn_write)

Move the check/save of the calib subdevice value to the (*insn_write) function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_labpc_common.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/d

[PATCH 07/19] staging: comedi: cb_pcidas: fix caldac_write_insn()

The comedi core expects the (*insn_write) functions to write 'insn->n' values to the hardware and return the number of values written. Currently this function only writes the first value. For this subdevice it only makes sense to write the final data value. Fix the function to work like the core e

[PATCH 02/19] staging: comedi: cb_pcidas64: use subdevice readback for 'caldac_state'

Use the comedi_subdevice 'readback' member and the core provided (*insn_read) to handle the readback of the write-only calibration subdevice. Remove the then unused 'caldac_state' member from the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/s

[PATCH 12/19] staging: comedi: cb_pcidas: use subdevice readback for 'dac08_value'

Use the comedi_subdevice 'readback' member and the core provided (*insn_read) to handle the readback of the write-only dac08 calib subdevice. Remove the then unused 'dac08_value' member from the private data. The dac08 calib subdevice only has one channel. For consistency in the driver, modify the

[PATCH 08/19] staging: comedi: cb_pcidas: use subdevice readback for 'caldac_value'

Use the comedi_subdevice 'readback' member and the core provided (*insn_read) to handle the readback of the write-only caldac subdevice. Remove the then unused 'caldac_value' member from the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/stagin

[PATCH 16/19] staging: comedi: ni_labpc_common: introduce labpc_ao_write()

Introduce a helper function to write a value to a given DAC channel. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_labpc_common.c | 32 +++- 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/driver

[PATCH 15/19] staging: comedi: ni_labpc_common: use subdevice readback for 'caldac'

Use the comedi_subdevice 'readback' member and the core provided (*insn_read) to handle the readback of the write-only caldac subdevice. Remove the then unused 'caldac' member from the private data. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/com

[PATCH 06/19] staging: comedi: cb_pcidas: remove unnecessary check in caldac_8800_write()

The 'address' passed to this function is actually the comedi channel. This value will always be less than the subdevice n_chan (which is 8). Remove the unnecessary sanity check in caldac_8800_write(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/co

[PATCH 05/19] staging: comedi: cb_pcidas64: fix ad8402_write_insn()

The comedi core expects the (*insn_write) functions to write 'insn->n' values to the hardware and return the number of values written. Currently this function only writes the first value. For this subdevice it only makes sense to write the final data value. Fix the function to work like the core e

[PATCH 11/19] staging: comedi: cb_pcidas: tidy up dac08_write_insn()

For consistency with the other calib subdevices, refactor this (*insn_write) function so that it only writes the final data value to the hardware., For aesthetics, rename the function so it has namespace associated with the driver. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-

[PATCH 00/19] staging: comedi: more comedi_subdevice 'readback' cleanup

Most of the comedi drivers that use the comedi_subdevice 'readback' use the core provided (*insn_read) function, comedi_readback_insn_read(). Modify comedi_alloc_subdev_readback() to automatically default the subdevice (*insn_read) to this function after allocating the 'readback' memory. A couple

RE: [PATCH 1/1] net: Hyper-V: Deletion of an unnecessary check before the function call "vfree"

> -Original Message- > From: SF Markus Elfring [mailto:elfr...@users.sourceforge.net] > Sent: Thursday, November 20, 2014 9:25 AM > To: Haiyang Zhang; KY Srinivasan; de...@linuxdriverproject.org; > net...@vger.kernel.org > Cc: LKML; kernel-janit...@vger.kernel.org; Julia Lawall > Subject:

[PATCH] Drivers:staging:dgap: Added a blank line after declaration

This patch fixes the checkpatch.pl warning: WARNING:Missing a blank line after declaration Signed-off-by: Anjana Sasindran --- drivers/staging/dgap/dgap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index f38354f..bdb5317 100644

[PATCH] Drivers:Staging:octeon: Fixed missing a blank line warning

The following checkpatch warning was fixed: WARNING: Missing a blank line after declarations Signed-off-by: Lekshmi --- drivers/staging/octeon/ethernet-rx.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/octeon/ethernet-rx.c b/drivers/staging/octeon/ethernet-rx.c index 4

RE: [PATCH] hv: hv_fcopy: drop the obsolete message on transfer failure

> -Original Message- > From: Dexuan Cui > Sent: Wednesday, November 19, 2014 11:48 PM > To: KY Srinivasan; gre...@linuxfoundation.org; linux- > ker...@vger.kernel.org; driverdev-devel@linuxdriverproject.org; > o...@aepfle.de; a...@canonical.com; jasow...@redhat.com > Cc: Haiyang Zhang > S

[PATCH] Staging: rtl8188eu: core: rtw_wlan_util: replaced __inline with inline

Changed return type of function get_my_bssid from __inline to inline Signed-off-by: Abel Moyo --- drivers/staging/rtl8188eu/core/rtw_wlan_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_wlan_util.c b/drivers/staging/rtl8188eu/core/rt

[PATCH 1/1] net: Hyper-V: Deletion of an unnecessary check before the function call "vfree"

From: Markus Elfring Date: Thu, 20 Nov 2014 15:15:21 +0100 The vfree() function performs also input parameter validation. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/net/hyperv/netvsc.c | 3 +-

Re: [PATCH v5 0/4] Correct vendor-prefix and document device isl29028

On Saturday 08 November 2014, Darshana Padmadas wrote: > Patchset documents correct and the deprecated vendor-prefix found by > checkpatch > warning and also documents information of device isl29028 for compatibility. > Patchset also includes corrected vendor-prefix and device name in compatible >

Re: [PATCH] staging: fwserial: remove multiple blank lines

Hi Dan, 2014-11-20 17:48 GMT+08:00 Dan Carpenter : > > Chill. Wait for two weeks minimum before asking these questions, and > longer than two weeks if Greg is traveling or there is a merge window > open. Got it! Thanks very much for your advice! I will keep waiting for Greg's reply. :) Regards,

Re: [PATCH] staging: fwserial: remove multiple blank lines

Chill. Wait for two weeks minimum before asking these questions, and longer than two weeks if Greg is traveling or there is a merge window open. (The patch is fine, btw). regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http:

Re: [PATCH v2] tools: hv: ignore ENOBUFS and ENOMEM in the KVP daemon

Dexuan Cui writes: > Under high memory pressure and very high KVP R/W test pressure, the netlink > recvfrom() may transiently return ENOBUFS to the daemon -- we found this > during a 2-week stress test. > > We'd better not terminate the daemon on the failure, because a typical KVP > user will re-