it's pretty
> > expected to have more checkpatch errors.
> >
> > It's a process, don't worry about most intermediate
> > warnings when doing checkpatch cleanups.
> >
> > Adding trailing spaces is not good, nearly every
> > other type of me
it's pretty
> > expected to have more checkpatch errors.
> >
> > It's a process, don't worry about most intermediate
> > warnings when doing checkpatch cleanups.
> >
> > Adding trailing spaces is not good, nearly every
> > other type of mess
e
> warnings when doing checkpatch cleanups.
>
> Adding trailing spaces is not good, nearly every
> other type of message can be ignored.
>
ok, just to verify, i thought of trying to generate a similar patch which will
not give checkpatch errors.
but
On Sat, 2014-11-01 at 10:35 +0530, Sudip Mukherjee wrote:
> On Sat, Nov 01, 2014 at 10:47:22AM +0800, Chen Weixiang wrote:
> > Remove following code style errors from ft1000/ft1000-usb/ft1000_debug.c
> > and ft1000/ft1000-pcmcia/ft1000_hw.c:
> > ERROR: spaces required around that '=' (ctx:VxV)
> >
On Sat, Nov 01, 2014 at 10:47:27AM +0800, Chen Weixiang wrote:
> Remove following code style error from ft1000/ft1000-usb/ft1000_debug.c:
> ERROR: space required after that ',' (ctx:VxV)
>
from checkpatch:
total: 11 errors, 15 warnings, 46 lines checked
NOTE: whitespace errors detected, you may w
On Sat, Nov 01, 2014 at 10:47:26AM +0800, Chen Weixiang wrote:
> Remove code style error from ft1000/ft1000-pcmcia/ft1000_hw.c:
> ERROR: else should follow close brace '}'
>
from checkpatch:
total: 1 errors, 2 warnings, 44 lines checked
NOTE: whitespace errors detected, you may wish to use scrip
On Sat, Nov 01, 2014 at 10:47:23AM +0800, Chen Weixiang wrote:
> Remove following code style errors from ft1000/ft1000-pcmcia/ft1000_hw.c:
> ERROR: space prohibited after that open parenthesis '('
> ERROR: space prohibited before that close parenthesis ')'
> ERROR: space prohibited after that '&' (
On Sat, Nov 01, 2014 at 10:47:24AM +0800, Chen Weixiang wrote:
> Remove following code style error from ft1000/ft1000-usb/ft1000_debug.c:
> ERROR: "(foo*)" should be "(foo *)"
>
again checkpatch gives total: 4 errors, 3 warnings, 16 lines checked.
this includes whitespace errors.
thanks
sudip
>
On Sat, Nov 01, 2014 at 10:47:22AM +0800, Chen Weixiang wrote:
> Remove following code style errors from ft1000/ft1000-usb/ft1000_debug.c
> and ft1000/ft1000-pcmcia/ft1000_hw.c:
> ERROR: spaces required around that '=' (ctx:VxV)
> ERROR: spaces required around that '<' (ctx:VxV)
> ERROR: spaces req
On Fri, Oct 31, 2014 at 11:08:34PM +0100, Konrad Zapalowicz wrote:
> On 10/31, Mariusz Gorski wrote:
> > Remove Lindent and checkpatch.pl tasks from TODO file as the first one
> > is obsolete and the other one is already done.
> >
when i checked panel.c with checkpatch and with --strict option, i
On Fri, Oct 31, 2014 at 10:06:46PM +0100, Mariusz Gorski wrote:
> Remove Lindent and checkpatch.pl tasks from TODO file as the first one
> is obsolete and the other one is already done.
when i checked panel.c with checkpatch and with --strict option, i got 20
checks.
thanks
sudip
>
> Signed-of
Remove code style error from ft1000/ft1000-pcmcia/ft1000_hw.c:
ERROR: else should follow close brace '}'
Signed-off-by: Chen Weixiang
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/ft1000/f
Remove following code style error from ft1000/ft1000-usb/ft1000_debug.c:
ERROR: space required after that ',' (ctx:VxV)
Signed-off-by: Chen Weixiang
---
drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 22 +-
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/dr
Remove following code style error from ft1000/ft1000-pcmcia/ft1000_hw.c:
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Chen Weixiang
---
drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/ft1000/ft1000-pcm
Remove following code style errors from ft1000/ft1000-pcmcia/ft1000_hw.c:
ERROR: space prohibited after that open parenthesis '('
ERROR: space prohibited before that close parenthesis ')'
ERROR: space prohibited after that '&' (ctx:WxW)
Signed-off-by: Chen Weixiang
---
drivers/staging/ft1000/ft1
Remove following code style error from ft1000/ft1000-usb/ft1000_debug.c:
ERROR: "(foo*)" should be "(foo *)"
Signed-off-by: Chen Weixiang
---
drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/ft1000/ft1000-usb
Remove following code style errors from ft1000/ft1000-usb/ft1000_debug.c
and ft1000/ft1000-pcmcia/ft1000_hw.c:
ERROR: spaces required around that '=' (ctx:VxV)
ERROR: spaces required around that '<' (ctx:VxV)
ERROR: spaces required around that '==' (ctx:VxV)
Signed-off-by: Chen Weixiang
---
driv
This is the version 2 of the patch series. The following code style error is
removed from the patch because it was already merged into Greg K-H staging.tree:
ERROR: do not initialise statics to 0 or NULL
This patch series are removing following code style errors from
drivers/staging/ft1000:
ERRO
From: Tristan Lelong
s/comming/coming/ in drivers/staging/android/ion/ion.c
s/specfic/specific/ in drivers/staging/android/ion/ion.h
s/peformance/performance/ in drivers/staging/android/ion/ion_priv.h
Signed-off-by: Tristan Lelong
---
v2: update changelog message per Randy Dunlap suggestion.
--
On 31/10/14 22:53, Ian Abbott wrote:
I like the idea of the core comedi module being separated from all the
various buses. And other buses can be added easily without pulling extra
dependencies into the core (e.g. for platform or spi devices).
And if this get's accepted, I'd like to complete th
On 31/10/14 22:18, Hartley Sweeten wrote:
On Friday, October 31, 2014 3:09 PM, Ian Abbott wrote:
On 31/10/14 18:19, Hartley Sweeten wrote:
On Friday, October 31, 2014 10:48 AM, Ian Abbott wrote:
The Comedi core module doesn't need support for PCI, USB or PCMCIA.
Only the low-level Comedi drive
On Friday, October 31, 2014 3:09 PM, Ian Abbott wrote:
> On 31/10/14 18:19, Hartley Sweeten wrote:
>> On Friday, October 31, 2014 10:48 AM, Ian Abbott wrote:
>>> The Comedi core module doesn't need support for PCI, USB or PCMCIA.
>>> Only the low-level Comedi drivers need it. Split the support for
On 10/31, Mariusz Gorski wrote:
> Remove Lindent and checkpatch.pl tasks from TODO file as the first one
> is obsolete and the other one is already done.
>
> Signed-off-by: Mariusz Gorski
> ---
> v3: Fixed commit summary
Great. Thanks.
regards,
konrad
> drivers/staging/panel/TODO | 2 --
> 1
On 31/10/14 18:19, Hartley Sweeten wrote:
On Friday, October 31, 2014 10:48 AM, Ian Abbott wrote:
The Comedi core module doesn't need support for PCI, USB or PCMCIA.
Only the low-level Comedi drivers need it. Split the support for these
bus types out of the core "comedi" module and into new mod
Remove Lindent and checkpatch.pl tasks from TODO file as the first one
is obsolete and the other one is already done.
Signed-off-by: Mariusz Gorski
---
v3: Fixed commit summary
drivers/staging/panel/TODO | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/panel/TODO b/drivers/s
On 10/31, Mariusz Gorski wrote:
> Remove Lindent and checkpatch.pl tasks from TODO file as the first one
> is obsolete and the other one is already done.
>
> v2: Fixed commit summary
This is something that should not be a part of the commit message. This
kind of extra information shall be placed
Remove Lindent and checkpatch.pl tasks from TODO file as the first one
is obsolete and the other one is already done.
v2: Fixed commit summary
Signed-off-by: Mariusz Gorski
---
drivers/staging/panel/TODO | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/panel/TODO b/drivers/s
On 10/31, Mariusz Gorski wrote:
> Remove Lindent and checkpatch.pl tasks from TODO file as the first one
> is obsolete and the other one is already done.
Great however your topic is ill formated. It should contain the "staging:
panel:" prefix.
thanks,
konrad
>
> Signed-off-by: Mariusz Gorski
>
Remove Lindent and checkpatch.pl tasks from TODO file as the first one
is obsolete and the other one is already done.
Signed-off-by: Mariusz Gorski
---
drivers/staging/panel/TODO | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/panel/TODO b/drivers/staging/panel/TODO
index a4
Use the recently added sample manipulation helpers to remove the hardcoded
assumption of the sample size.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-
Use the recently added sample manipulation helpers to remove the hardcoded
assumption of the sample size.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --
Use the recently added sample manipulation helpers to remove the hardcoded
assumption of the sample size.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 37 +++---
1 file changed, 21 insertions(+),
Use the recently added sample manipulation helpers to remove the hardcoded
assumption of the sample size.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-
This inline helper function has been replaced with comedi_bytes_per_sample().
The same commit (bf33eb4b4f57) introduced a couple other related helper
functions a manipulate the sample size.
Use the new helper functions to remove the use of 'bytes_per_sample()' and
remove it.
Signed-off-by: H Hart
Use the recently added sample manipulation helpers to remove the hardcoded
assumption of the sample size.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
d
Use the recently added sample manipulation helpers to remove the hardcoded
assumption of the sample size.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das16.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/driv
Commit (bf33eb4b4f57) introduced a some new helper functions to manipulate
the sample size.
This series removes the old 'bytes_per_sample()' helper and updates some
of the drivers to use the new helper functions to remove the hardcoded
assumption of the sample size.
H Hartley Sweeten (9):
stag
Use the recently added sample manipulation helpers to remove the hardcoded
assumption of the sample size.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Use the recently added sample manipulation helpers to remove the hardcoded
assumption of the sample size.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
On Friday, October 31, 2014 10:48 AM, Ian Abbott wrote:
> The Comedi core module doesn't need support for PCI, USB or PCMCIA.
> Only the low-level Comedi drivers need it. Split the support for these
> bus types out of the core "comedi" module and into new modules,
> "comedi_pci", "comedi_usb", and
On Fri, 31 Oct 2014, SF Markus Elfring wrote:
> >> The functions kfree(), rtw_free_netdev() and vfree() test whether their
> >> argument is NULL and then return immediately. Thus the test around the call
> >> is not needed.
> >>
> >> This issue was detected by using the Coccinelle software.
> >>
>
>> The functions kfree(), rtw_free_netdev() and vfree() test whether their
>> argument is NULL and then return immediately. Thus the test around the call
>> is not needed.
>>
>> This issue was detected by using the Coccinelle software.
>>
>> Signed-off-by: Markus Elfring
>> ---
>> drivers/staging
On Fri, 31 Oct 2014, SF Markus Elfring wrote:
> The functions kfree(), rtw_free_netdev() and vfree() test whether their
> argument is NULL and then return immediately. Thus the test around the call
> is not needed.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Ma
The functions kfree(), rtw_free_netdev() and vfree() test whether their
argument is NULL and then return immediately. Thus the test around the call
is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring
---
drivers/staging/rtl8188eu/core/rtw_efuse
The Comedi core module doesn't need support for PCI, USB or PCMCIA.
Only the low-level Comedi drivers need it. Split the support for these
bus types out of the core "comedi" module and into new modules,
"comedi_pci", "comedi_usb", and "comedi_pcmcia".
1) staging: comedi: comedidev.h: remove dummy
Setting the `CONFIG_COMEDI_USB_DRIVERS` kernel configuration option
makes the main "comedi" module depend on the "usbcore" module. But
perhaps the machine has no USB controllers (or they have been disabled),
in which case the "usbcore" module may have been pulled in
unnecessarily. Only a few low-
Setting the `CONFIG_COMEDI_PCMCIA_DRIVERS` kernel configuration option
makes the main "comedi" module depend on the "pcmcia" module, but many
machines don't have PCMCIA slots and only a few low-level Comedi drivers
need PCMCIA support. The Comedi PCMCIA support functions are all in
"comedi_pcmcia.
Some declarations and macro definitions in "comedidev.h" are protected
by various `#ifdef`s for kernel configuration options, but the header
file compiles fine without the `#ifdef`s regardless of whether those
config option macros are defined or not. Remove the `#ifdef`s and
compile the affected c
Some low-level Comedi driver modules used to handle PCI devices and ISA
devices in the same module with some conditional compilation. To reduce
the amount of conditional compilation, some dummy inline versions of
`comedi_to_pci_dev()`, `comedi_pci_enable()`, `comedi_pci_disable()`,
and `comedi_pci
Setting the `CONFIG_COMEDI_PCI_DRIVERS` kernel configuration option
makes the main "comedi" module depend on the PCI support in the kernel.
That's not that big a deal since PCI support in the kernel is either
built into the kernel or is absent, and is not in a separate module.
Still, not all low-le
On 10/30/14 23:43, Tristan Lelong wrote:
> Fix some coding style warnings detected by checkpatch.pl in ion.
$Subject is correct but the changelog above is not -- needs to be changed.
>
> Signed-off-by: Tristan Lelong
> ---
> drivers/staging/android/ion/ion.c | 2 +-
> drivers/staging/and
On 31/10/14 16:49, H Hartley Sweeten wrote:
This member of the private data is replicating what the comedi_async
'cur_chan' member is used for. Use that instead and remove the private
data member.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/com
On 31/10/14 16:49, H Hartley Sweeten wrote:
The commedi_async 'cur_chan' member is used to track the current position
in the chanlist for a scan. Currently only a couple comedi drivers use
this member.
For aeshtetics, move the 'cur_chan' tracking into the core for non-SDF_PACKED
subdevices. The
On Friday, October 31, 2014 7:32 AM, Ian Abbott wrote:
> For some unfathomable reason, the Comedi `insn_bits` handler for the
> digital output subdevice (`icp_multi_insn_bits_do()`) writes the digital
> output register and reads back the unrelated digital input register.
> Read back the current sta
The local variable 'range' is set but never used. Remove it.
Signed-off-by: H Hartley Sweeten
Reviewed-by: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ni_mio_common.c
Move the tracking of the comedi_async 'cur_chan' into the core.
V2: fix patches 2 and 3
Ian Abbott pointed out that checking for the COMEDI_CB_EOS event
when counting scans does not work when samples are added in a loop.
H Hartley Sweeten (3):
staging: comedi: ni_mio_common: remove unus
The commedi_async 'cur_chan' member is used to track the current position
in the chanlist for a scan. Currently only a couple comedi drivers use
this member.
For aeshtetics, move the 'cur_chan' tracking into the core for non-SDF_PACKED
subdevices. The 'cur_chan' will be updated after reading or wr
This member of the private data is replicating what the comedi_async
'cur_chan' member is used for. Use that instead and remove the private
data member.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pci230.c | 15 ---
On Wednesday, October 29, 2014 10:35 AM, Ian Abbott wrote:
> "das16" uses a kernel timer but never removes it from the queue
> synchronously at the moment. Patch 1 makes sure this is done before it
> is destroyed. Patch 2 uses the comedi device's main spin-lock to ensure
> some state shared with
For some unfathomable reason, the Comedi `insn_bits` handler for the
digital output subdevice (`icp_multi_insn_bits_do()`) writes the digital
output register and reads back the unrelated digital input register.
Read back the current state of the outputs (held in `s->state`) instead.
Signed-off-by:
Remove the typedef and use struct visorchipset_device_info instead. Fix
CamelCase names:
busNo => bus_no
devNo => dev_no
devInstGuid => dev_inst_guid
chanInfo => chan_info
Reserved1 => reserved1
Reserved2 => reserved2
switchNo => switch_no
internalPortNo => internal_port_no
pendingMsgHdr => pendin
Remove the typedef and use struct visorchipset_switch_info instead. Fix all
CamelCase member names:
switchNo => switch_no
switchTypeGuid => switch_type_uuid
authService1 => authservice1
authService2 => authservice2
authService3 => authservice3
securityContext => security_context
Reserved => reserv
Fix CamelCase parameter:
busNo => bus_no
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/visorchipset.h | 2 +-
drivers/staging/unisys/visorchipset/visorchipset_main.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/unisys/vi
Delete the macros and related preprocessor code for DBG_GETFILE_PAYLOAD(),
DBG_GETFILE(), and DBG_PUTFILE().
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/visorchipset.h | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/
Fix CamelCase names:
busNo => bus_no
busInfo => bus_info
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/visorchipset.h | 4 ++--
drivers/staging/unisys/visorchipset/visorchipset_main.c | 8
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drive
Fix CamelCase names:
busNo => bus_no
devNo => dev_no
devInfo => dev_info
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/visorchipset.h | 4 ++--
drivers/staging/unisys/visorchipset/visorchipset_main.c | 10 +-
2 files changed, 7 insertions(+), 7 deletions(-)
Get rid of the typedef and use struct visorchipset_internalport_info and fix
CamelCase member names:
switchNo => switch_no
internalPortNo => internal_port_no
busNo => bus_no
devNo => dev_no
Reserved1 => reserved1
Reserved2 => reserved2
pendingMsgHdr => pending_msg_hdr
procObject => proc_object
Si
Fix CamelCase names in finddevice():
busNo => bus_no
devNo => dev_no
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/visorchipset.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/visorchipset.h
b/drivers/stagi
Delete visorchipset_get_switch_info() and visorchipset_get_externalport_info()
as these functions were declared but not defined, or used.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/visorchipset.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/u
Remove the typedef from this type and use struct visorchipset_channel_info
instead. Fix CamelCase member names:
addrType => addr_type
channelAddr => channel_addr
nChannelBytes => n_channel_bytes
channelTypeGuid => channel_type_uuid
channelInstGuid => channel_inst_uuid
Signed-off-by: Benjamin Rome
Fix the CamelCase parameter in delbusdevices() in visorchipset.h:
busNo => bus_no
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/visorchipset.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/visorchipset.h
b/dr
Get rid of the typedef and just use struct visorchipset_busdev_responders
instead. Fix CamelCase parameter names in the function pointer definitions for
the structure:
busNo => bus_no
devNo => dev_no
Update references to changed names.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/v
No one is using this definition so remove it.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/visorchipset.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/visorchipset.h
b/drivers/staging/unisys/visorchipset/visorchipset.h
index 5
Fix CamelCase parameter names:
busNo => bus_no
devNo => dev_no
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/visorchipset.h | 2 +-
drivers/staging/unisys/visorchipset/visorchipset_main.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/dri
Remove the typedef and just use struct visorchipset_externalport_info instead.
Fix all CamelCase names:
switchNo => switch_no
externalPortNo => external_port_no
networkZoneGuid => network_zone_uuid
pdPort => pd_port
ipNetmask => ip_netmask
ipBroadcast => ip_broadcast
ipNetwork => ip_network
ipGate
Fix CamelCase name:
driverInfo => driver_info
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/visorchipset.h | 2 +-
drivers/staging/unisys/visorchipset/visorchipset_main.c | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/unis
Fix CamelCase parameters:
busNo => bus_no
devNo => dev_no
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/visorchipset.h | 3 ++-
drivers/staging/unisys/visorchipset/visorchipset_main.c | 4 ++--
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/s
Fix the CamelCase parameter name in findbus() in visorchipset.h.
busNo => bus_no
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/visorchipset.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/visorchipset.h
b/dri
Get rid of the typedef and just use struct visorchipset_busdev_notifiers
instead. Fix CamelCase names in parameters for the function pointers:
busNo => bus_no
devNo => dev_no
typeGuid => type_uuid
minSize => min_size
maxSize => max_size
Update references.
Signed-off-by: Benjamin Romer
---
driv
Get rid of VISORCHIPSET_ADDRESSTYPE and replace it with enum
visorchipset_addresstype. Fix CamelCase names:
ADDRTYPE_localPhysical => ADDRTYPE_LOCALPHYSICAL
ADDRTYPE_localTest => ADDRTYPE_LOCALTEST
Update all references to changed names.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys
Fix CamelCase parameter:
driverInfo => driver_info
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/visorchipset.h | 2 +-
drivers/staging/unisys/visorchipset/visorchipset_main.c | 8
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/stagi
Remove the typedef and use the name struct visorchipset_bus_info instead.
Fix CamelCase member names in the structure:
busNo => bus_no
chanInfo => chan_info
partitionGuid => partition_uuid
partitionHandle => partition_handle
Reserved1 => reserved1
Reserved2 => reserved2
procObject => proc_object
Remove the typedef for VISORCHIPSET_STATE and replace it with enum
visorchipset_state.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/visorchipset.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/visor
Remove the typedef from the enumeration and replace references to it with
enum crash_obj_type. Fix CamelCase names:
CRASH_dev => CRASH_DEV
CRASH_bus => CRASH_BUS
Update all references to changed names.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/visorchipset.h |
This patch series eliminates all checkpatch.pl errors, warnings, and strict
checks from the file visorchipset/visorchipset.h.
Benjamin Romer (24):
staging: unisys: get rid of VISORCHIPSET_STATE typedef
staging: unisys: refactor VISORCHIPSET_ADDRESSTYPE
staging: unisys: refactor CRASH_OBJ_TYP
On 30/10/14 18:19, H Hartley Sweeten wrote:
The SDF_READABLE flag is not necessary for digital output subdevices. For
consistency, remove this flag from the comedi drivers that set it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/
On 31/10/14 10:25, Ian Abbott wrote:
On 30/10/14 18:19, H Hartley Sweeten wrote:
The SDF_READABLE flag is not necessary for digital output subdevices. For
consistency, remove this flag from the comedi drivers that set it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
On 30/10/14 18:38, H Hartley Sweeten wrote:
This member of the private data is replicating what the comedi_async
'cur_chan' member is used for. Use that instead and remove the private
data member.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/com
On 30/10/14 18:38, H Hartley Sweeten wrote:
The commedi_async 'cur_chan' member is used to track the current position
in the chanlist for a scan. Currently only a couple comedi drivers use
this member.
For aeshtetics, move the 'cur_chan' tracking into the core for non-SDF_PACKED
subdevices. The
On 30/10/14 18:37, H Hartley Sweeten wrote:
The local variable 'range' is set but never used. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 3 ---
1 file changed, 3 deletions(-)
Reviewed-by: Ian Abbo
1) We can tighten up the code a little by returning directly and it
makes the code more future proof and easier to read.
2) "free" is a better name than "exit".
3) sizeof(priv_cmd) is shorter and more clear than sizeof(struct
android_wifi_priv_cmd).
Signed-off-by: Dan Carpenter
diff --git
The original code had two bugs:
1) It didn't check if the string was zero length so it could oops when
it tried to dereference the ZERO_SIZE_PTR.
2) It didn't enforce that the string was NUL terminated.
It was also messy as pants.
Signed-off-by: Dan Carpenter
---
I assume that hopefully the u
On 30/10/14 18:32, H Hartley Sweeten wrote:
Currently this driver uses a bitmap in the private data to keep track of
the unipolar/bipolar range for each channel. This is needed to determine
if the data needs to be munged for bipolar samples.
Remove this member from the private data and use the c
On 30/10/14 18:32, H Hartley Sweeten wrote:
This functions uses the async->cur_chan to determine if the current channel
is using a bipolar range and the sample needs to be munged. The cur_chan is
never incremented so all the samples are munged based on the fist channel
in the cmd->chanlist.
Bump
On 30/10/14 18:19, H Hartley Sweeten wrote:
The SDF_READABLE flag is not necessary for digital output subdevices. For
consistency, remove this flag from the comedi drivers that set it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/
On 30/10/14 18:19, H Hartley Sweeten wrote:
The SDF_GROUND, SDF_COMMON, SDF_DIFF, and SDF_OTHER flags are only useful
with the analog input and output subdevices.
Remove these flags from the other subdevice types in the comedi drivers.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg
On 30/10/14 18:19, H Hartley Sweeten wrote:
As indicated in the comedi.h uapi header, SDF_WRITEABLE was a spelling
error in the API, SDF_WRITABLE is prefered.
For aesthetics, replace all the SDF_WRITEABLE uses with SDF_WRITABLE.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-H
On 30/10/14 18:21, H Hartley Sweeten wrote:
The comedi core calls comedi_buf_reset() before starting an async command
(*do_cmd) and after returning a subdevice to an idle state (*cancel).
The drivers do not need to reset the async->cur_chan in those functions.
Signed-off-by: H Hartley Sweeten
On 30/10/14 18:10, H Hartley Sweeten wrote:
This function currently fails if the number of samples to add would
overflow the async buffer. Modify it to add the samples that fit so
at least some of the sample data is returned to the user.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg
99 matches
Mail list logo
