Re: [PATCH 00/15] staging: rtl8723au: Fixes and cleanups

2014-10-19 Thread Greg KH
On Sun, Oct 12, 2014 at 10:09:04AM +0200, Jes Sorensen wrote: > Greg KH writes: > > On Fri, Oct 10, 2014 at 09:41:23PM +0200, jes.soren...@redhat.com wrote: > >> From: Jes Sorensen > >> > >> Hi, > >> > >> Please find attached a couple of fixes and cleanups for the rtl8723au > >> driver. This in

Re: [PATCH] staging: android: binder: move to the "real" part of the kernel

2014-10-19 Thread Greg Kroah-Hartman
On Fri, Oct 17, 2014 at 12:26:01PM +0300, Dan Carpenter wrote: > The code isn't very beautiful and there are lots of details wrong like > the error codes. Really, what is wrong with the existing error code usages? > Al had some critical things to say about it but it looks like most of > those iss

Re: [PATCH] staging: android: binder: move to the "real" part of the kernel

2014-10-19 Thread Greg Kroah-Hartman
On Fri, Oct 17, 2014 at 02:43:29AM -0700, Christoph Hellwig wrote: > On Thu, Oct 16, 2014 at 02:47:41PM +0200, Greg Kroah-Hartman wrote: > > From: Greg Kroah-Hartman > > > > The Android binder code has been "stable" for many years now. No matter > > what comes in the future, we are going to have

Re: [PATCH] staging: android: binder: move to the "real" part of the kernel

2014-10-19 Thread Greg Kroah-Hartman
On Sat, Oct 18, 2014 at 10:36:30PM +0100, One Thousand Gnomes wrote: > > Do we really need someone to do more work that has been done on it in > > the past as an official "maintainer"? I'll be glad to do it, as I doubt > > it will require any time at all. > > Well every time in the past that Al V

[PATCH v2 2/2] Staging: rts5208: helper function to enable interrupts during reset

2014-10-19 Thread Fabio Falzoi
Define the helper function rtsx_enable_pcie_intr to shorten the rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx_chip.c | 95 +++-- 1 file changed, 48 insertions(+), 47 deletions(-)

[PATCH v2 1/2] Staging: rts5208: helper function to manage aspm during reset

2014-10-19 Thread Fabio Falzoi
Define the helper function rtsx_reset_aspm to shorten the rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx_chip.c | 70 + 1 file changed, 39 insertions(+), 31 deletions(-) diff

[PATCH v2 0/2] Staging: rts5208: rtsx_reset_chip style clean up

2014-10-19 Thread Fabio Falzoi
Clean up the code in rtsx_reset_chip function defining two new helper functions rtsx_reset_aspm and rtsx_enable_pcie_intr. Specifically, the following checkpatch warnings are corrected: * PARENTHESIS_ALIGNMENT at rows 271, 302, 343 and 346 * LONG_LINE at rows 294, 313 and 315 * BRACES at rowa 320 a

Re: [PATCH] Staging: dgnc: Makefile: replaced EXTRA_CFLAGS with ccflags-y

2014-10-19 Thread Greg KH
On Sun, Oct 19, 2014 at 06:28:16PM +0200, Abel Moyo wrote: > Replaced EXTRA_CFLAGS which is deprecated with ccflags-y > > Signed-off-by: Abel Moyo > --- > drivers/staging/dgnc/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/dgnc/Makefile b/drive

[PATCH] Staging: dgnc: Makefile: replaced EXTRA_CFLAGS with ccflags-y

2014-10-19 Thread Abel Moyo
Replaced EXTRA_CFLAGS which is deprecated with ccflags-y Signed-off-by: Abel Moyo --- drivers/staging/dgnc/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/dgnc/Makefile b/drivers/staging/dgnc/Makefile index b69f7b6..d70323e 100644 --- a/drivers/stagin

Re: [PATCH v2] Fix error handling in dgnc_start()

2014-10-19 Thread Dan Carpenter
On Sun, Oct 19, 2014 at 02:37:28AM +0530, Devendra Naga wrote: > The error_handling for class_create, device_create are taken care > by the respective goto statements. The failure code from class_create and > device_create are assigned to the variable rc to return a proper value. > > Also removed

Re: [PATCH 3/7] staging: ft1000: space required after that ','

2014-10-19 Thread Konrad Zapalowicz
On 10/19, Chen Weixiang wrote: > Remove code style error from ft1000/ft1000-usb/ft1000_debug.c: > ERROR: space required after that ',' (ctx:VxV) > > Signed-off-by: Chen Weixiang > --- > drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 18 +- > 1 file changed, 9 insertions(+), 9

[PATCH 2/7] staging: ft1000: spaces required around that '=', '<' and '=='

2014-10-19 Thread Chen Weixiang
Remove code style errors from ft1000/ft1000-usb/ft1000_debug.c and ft1000/ft1000-pcmcia/ft1000_hw.c: ERROR: spaces required around that '=' (ctx:VxV) ERROR: spaces required around that '<' (ctx:VxV) ERROR: spaces required around that '==' (ctx:VxV) Signed-off-by: Chen Weixiang --- drivers/stagin

[PATCH 1/7] staging: ft1000: do not initialise statics to 0 or NULL

2014-10-19 Thread Chen Weixiang
Remove following checkpatch.pl error from ft1000/ft1000-usb/ft1000_debug.c ERROR: do not initialise statics to 0 or NULL Signed-off-by: Chen Weixiang --- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ft1000/ft

[PATCH 5/7] staging: ft1000: space prohibited after '(' and '&', before ')'

2014-10-19 Thread Chen Weixiang
Remove code style error from ft1000/ft1000-pcmcia/ft1000_hw.c: ERROR: space prohibited after that open parenthesis '(' ERROR: space prohibited before that close parenthesis ')' ERROR: space prohibited after that '&' (ctx:WxW) Signed-off-by: Chen Weixiang --- drivers/staging/ft1000/ft1000-pcmcia/

[PATCH 3/7] staging: ft1000: space required after that ','

2014-10-19 Thread Chen Weixiang
Remove code style error from ft1000/ft1000-usb/ft1000_debug.c: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: Chen Weixiang --- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/f

[PATCH 4/7] staging: ft1000: else should follow close brace '}'

2014-10-19 Thread Chen Weixiang
Remove code style error from ft1000/ft1000-pcmcia/ft1000_hw.c: ERROR: else should follow close brace '}' Signed-off-by: Chen Weixiang --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/staging/ft1000/f

[PATCH 0/7] Remove checkpatch.pl errors from drivers/staging/ft1000

2014-10-19 Thread Chen Weixiang
This patches remove following code style errors from drivers/staging/ft1000: ERROR: do not initialise statics to 0 or NULL ERROR: spaces required around that '=' (ctx:VxV) ERROR: spaces required around that '<' (ctx:VxV) ERROR: spaces required around that '==' (ctx:VxV) ERROR: space required after

[PATCH 7/7] staging: ft1000: "foo * bar" should be "foo *bar"

2014-10-19 Thread Chen Weixiang
Remove code style error form ft1000/ft1000-pcmcia/ft1000_hw.c: ERROR: "foo * bar" should be "foo *bar" Signed-off-by: Chen Weixiang --- drivers/staging/ft1000/ft1000-pcmcia/ft1000_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ft1000/ft1000-pcmcia/ft1000

[PATCH 6/7] staging: ft1000: "(foo*)" should be "(foo *)"

2014-10-19 Thread Chen Weixiang
Remove code style error from ft1000/ft1000-usb/ft1000_debug.c: ERROR: "(foo*)" should be "(foo *)" Signed-off-by: Chen Weixiang --- drivers/staging/ft1000/ft1000-usb/ft1000_debug.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/ft1000/ft1000-usb/ft1000_de

Re: [PATCH 0/2] Staging: rts5208: rtsx_reset_chip style clean up

2014-10-19 Thread Giedrius Statkevicius
On 2014.10.19 12:55, Fabio Falzoi wrote: > Clean up the code in rtsx_reset_chip function defining two new helper > functions rtsx_reset_aspm and rtsx_enable_pcie_intr. > Specifically, the following checkpatch warnings are corrected: > * PARENTHESIS_ALIGNMENT at rows 271, 302, 343 and 346 > * LONG_L

[PATCH 2/2] Staging: rts5208: helper function to enable interrupts during reset

2014-10-19 Thread Fabio Falzoi
Define the helper function rtsx_enable_pcie_intr to shorten the rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx_chip.c | 96 ++--- 1 file changed, 48 insertions(+), 48 deletions(-)

[PATCH 0/2] Staging: rts5208: rtsx_reset_chip style clean up

2014-10-19 Thread Fabio Falzoi
Clean up the code in rtsx_reset_chip function defining two new helper functions rtsx_reset_aspm and rtsx_enable_pcie_intr. Specifically, the following checkpatch warnings are corrected: * PARENTHESIS_ALIGNMENT at rows 271, 302, 343 and 346 * LONG_LINE at rows 294, 313 and 315 * BRACES at rowa 320 a

[PATCH 1/2] Staging: rts5208: helper function to manage aspm during reset

2014-10-19 Thread Fabio Falzoi
Define the helper function rtsx_reset_aspm to shorten the rtsx_reset_chip code and get rid of the LONG_LINE checkpatch warnings. Signed-off-by: Fabio Falzoi --- drivers/staging/rts5208/rtsx_chip.c | 72 - 1 file changed, 39 insertions(+), 33 deletions(-) diff