Re: [PATCHv2] staging: rtl8188eu: Fix coding style space related ERROR problems

2014-10-16 Thread Dan Carpenter
On Fri, Oct 17, 2014 at 01:31:18PM +0800, hejianet wrote: > Hi Greg > Just ping it, coz this is a practising patch for Eudyptula Challenge task 10. > Any comment is welcome, thank you :) > The merge window is open. And anyway, you shouldn't ping people about patches if it has been less than two

Re: [PATCHv2] staging: rtl8188eu: Fix coding style space related ERROR problems

2014-10-16 Thread hejianet
Hi Greg Just ping it, coz this is a practising patch for Eudyptula Challenge task 10. Any comment is welcome, thank you :) On Tue, 14 Oct 2014 11:28:32 +0800 from hejia...@gmail.com wrote: > This fixes space related ERROR reports by checkpatch.pl > Generated by $ git ls-files "drivers/staging/rtl

Re: [PATCH] staging: android: binder: move to the "real" part of the kernel

2014-10-16 Thread John Stultz
On Thu, Oct 16, 2014 at 4:12 PM, Greg Kroah-Hartman wrote: > On Thu, Oct 16, 2014 at 10:09:04AM -0700, John Stultz wrote: >> On Thu, Oct 16, 2014 at 5:47 AM, Greg Kroah-Hartman >> wrote: >> > From: Greg Kroah-Hartman >> > >> > The Android binder code has been "stable" for many years now. No mat

[PATCH] Staging: rts5208: rtsx_scsi: Fixed a brace coding style issue

2014-10-16 Thread Mike Roocroft
Fixed a coding style issue. Signed-off-by: Mike Roocroft --- drivers/staging/rts5208/rtsx_scsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rts5208/rtsx_scsi.c b/drivers/staging/rts5208/rtsx_scsi.c index bbbf796..1161082 100644 --- a/drivers/staging/rt

Re: [PATCH] staging: android: binder: move to the "real" part of the kernel

2014-10-16 Thread Greg Kroah-Hartman
On Thu, Oct 16, 2014 at 04:18:02PM +0200, Michael Kerrisk (man-pages) wrote: > On Thu, Oct 16, 2014 at 2:47 PM, Greg Kroah-Hartman > wrote: > > From: Greg Kroah-Hartman > > > > The Android binder code has been "stable" for many years now. No matter > > what comes in the future, we are going to h

Re: [PATCH] staging: android: binder: move to the "real" part of the kernel

2014-10-16 Thread Greg Kroah-Hartman
On Thu, Oct 16, 2014 at 10:09:04AM -0700, John Stultz wrote: > On Thu, Oct 16, 2014 at 5:47 AM, Greg Kroah-Hartman > wrote: > > From: Greg Kroah-Hartman > > > > The Android binder code has been "stable" for many years now. No matter > > Well, ignoring the ABI break that landed in the last year.

[PATCH net-next, v3] hyperv: Add handling of IP header with option field in netvsc_set_hash()

2014-10-16 Thread Haiyang Zhang
In case that the IP header has optional field at the end, this patch will get the port numbers after that field, and compute the hash. The general parser skb_flow_dissect() is used here. Signed-off-by: Haiyang Zhang Reviewed-by: K. Y. Srinivasan --- drivers/net/hyperv/netvsc_drv.c | 26 ++

Re: [PATCH] staging: android: binder: move to the "real" part of the kernel

2014-10-16 Thread John Stultz
On Thu, Oct 16, 2014 at 5:47 AM, Greg Kroah-Hartman wrote: > From: Greg Kroah-Hartman > > The Android binder code has been "stable" for many years now. No matter Well, ignoring the ABI break that landed in the last year. :) > what comes in the future, we are going to have to support this API,

Re: [PATCH] staging: android: binder: move to the "real" part of the kernel

2014-10-16 Thread Michael Kerrisk (man-pages)
On Thu, Oct 16, 2014 at 2:47 PM, Greg Kroah-Hartman wrote: > From: Greg Kroah-Hartman > > The Android binder code has been "stable" for many years now. No matter > what comes in the future, we are going to have to support this API, so > might as well move it to the "real" part of the kernel as t

Re: [PATCH] staging: comedi: ii_pci20kc: add CONFIG_HAS_IOMEM dependence

2014-10-16 Thread Greg KH
On Wed, Oct 15, 2014 at 03:06:54PM -0700, David Cohen wrote: > On Wed, Oct 15, 2014 at 10:57:00PM +0100, Ian Abbott wrote: > > On 15/10/14 22:25, David Cohen wrote: > > >ii_pci20kc uses io memory which makes it not compilable on architectures > > >without HAS_IOMEM such as UML: > > > > > > CC

[PATCH] staging: android: binder: move to the "real" part of the kernel

2014-10-16 Thread Greg Kroah-Hartman
From: Greg Kroah-Hartman The Android binder code has been "stable" for many years now. No matter what comes in the future, we are going to have to support this API, so might as well move it to the "real" part of the kernel as there's no real work that needs to be done to the existing code. Sign

Re: [PATCH] bcm_wimax: remove driver support

2014-10-16 Thread Greg KH
On Wed, Oct 15, 2014 at 03:53:27PM -0700, Jeff Kirsher wrote: > The Beceem WiMAX driver was barely function in its current state > and was non-functional on 64 bit systems. Based on repeated > statements from Greg KH that he wanted the driver removed, I am > removing the driver. > > CC: Matthias

Re: [PATCH v2] bcm/CmHost.c: Fix noisy compile warnings

2014-10-16 Thread Greg KH
On Wed, Oct 15, 2014 at 03:59:21PM -0700, Jeff Kirsher wrote: > On Wed, 2014-10-15 at 12:01 -0700, Jeff Kirsher wrote: > > From: Fabio Estevam > > > > The Beceem WIMAX was generating compile warnings on 64bit machines, > > which were: > > > > drivers/staging/bcm/CmHost.c: In function ‘StoreCmCon

Re: [PATCH v2] bcm/CmHost.c: Fix noisy compile warnings

2014-10-16 Thread Dan Carpenter
COMPILE_TEST is just so that you can view build warnings. We would say: depends on USB && NET && (!64BIT || COMPILE_TEST) of depends on USB && NET && (X86_32 || (X86 && COMPILE_TEST)) If you don't have USB or NET, you're get build errors but they don't indicate bugs. If you build on X86_64 th

Re: [PATCH v2] bcm/CmHost.c: Fix noisy compile warnings

2014-10-16 Thread Jeff Kirsher
On Thu, 2014-10-16 at 10:52 +0300, Dan Carpenter wrote: > On Wed, Oct 15, 2014 at 01:26:07PM -0700, Jeff Kirsher wrote: > > On Wed, 2014-10-15 at 22:55 +0300, Dan Carpenter wrote: > > > On Wed, Oct 15, 2014 at 12:01:41PM -0700, Jeff Kirsher wrote: > > > > From: Fabio Estevam > > > > > > > > The B

[patch] staging: lustre: silence a static checker warning

2014-10-16 Thread Dan Carpenter
Static checkers warn that if cfs_cpt_table_print() returns an error other than -EFBIG, then it would lead to a double free. This is true but cfs_cpt_table_print() only returns -EFBIG on error so it also won't happen in real life. Signed-off-by: Dan Carpenter diff --git a/drivers/staging/lustre

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-16 Thread Jeff Kirsher
On Thu, 2014-10-16 at 10:48 +0300, Dan Carpenter wrote: > On Wed, Oct 15, 2014 at 01:03:49PM -0700, Joe Perches wrote: > > On Wed, 2014-10-15 at 22:53 +0300, Dan Carpenter wrote: > > > On Wed, Oct 15, 2014 at 09:11:36AM -0700, Joe Perches wrote: > > > > On Wed, 2014-10-15 at 06:03 -0700, Jeff Kirsh

Re: [PATCH v2] bcm/CmHost.c: Fix noisy compile warnings

2014-10-16 Thread Dan Carpenter
On Wed, Oct 15, 2014 at 01:26:07PM -0700, Jeff Kirsher wrote: > On Wed, 2014-10-15 at 22:55 +0300, Dan Carpenter wrote: > > On Wed, Oct 15, 2014 at 12:01:41PM -0700, Jeff Kirsher wrote: > > > From: Fabio Estevam > > > > > > The Beceem WIMAX was generating compile warnings on 64bit machines, > > >

Re: [PATCH] bcm/CmHost.c: Fix noisy compile warnings

2014-10-16 Thread Dan Carpenter
On Wed, Oct 15, 2014 at 01:03:49PM -0700, Joe Perches wrote: > On Wed, 2014-10-15 at 22:53 +0300, Dan Carpenter wrote: > > On Wed, Oct 15, 2014 at 09:11:36AM -0700, Joe Perches wrote: > > > On Wed, 2014-10-15 at 06:03 -0700, Jeff Kirsher wrote: > > > [] > > > > I thought I remember Greg saying some