From: Micky Ching
Fix rts5227&5249 failed send buffer cmd after suspend,
PM_CTRL3 should reset before send any buffer cmd after suspend.
Otherwise, buffer cmd will failed, this will lead resume fail.
Signed-off-by: Micky Ching
---
drivers/mfd/Makefile | 2 +-
drivers/mfd/rts5227.c
On 10/09/14 at 05:58pm, Sudip Mukherjee wrote:
> On Thu, Oct 09, 2014 at 06:25:10PM +0800, WANG Chao wrote:
> > This fixes the following sparse error:
> >
> > drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c:393:9: error:
> > incompatible types in comparison expression (different addr
It's never enabled, so we can safely remove it.
Signed-off-by: Vladimir A. Nazarenko
---
drivers/staging/vt6655/device_main.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c
b/drivers/staging/vt6655/device_main.c
index 6a77f0d.
On Thu, Oct 09, 2014 at 03:38:55PM +1100, Vladimir A. Nazarenko wrote:
> It's never enabled, so we can safely remove it.
>
> Signed-off-by: Vladimir A. Nazarenko
> ---
> drivers/staging/vt6655/device_main.c | 10 ++
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/driv
Hi!
> >>@@ -184,6 +179,8 @@ machine_halt(void)
> >> void
> >> machine_power_off(void)
> >> {
> >>+ do_kernel_poweroff();
> >>+
> >
> >poweroff -> power_off for consistency.
> >
> Dunno; matter of personal preference. I started with that, but ultimately went
> with poweroff to distinguish powe
Wrapping two too long lines in two files of the imx-drm driver.
Signed-off-by: Rene Kolarik
---
drivers/staging/imx-drm/imx-drm-core.c | 3 ++-
drivers/staging/imx-drm/imx-tve.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-drm-core.c
b
On Thu, Oct 09, 2014 at 11:49:27AM +0100, Lee Jones wrote:
> On Thu, 09 Oct 2014, Catalin Marinas wrote:
>
> > On Tue, Oct 07, 2014 at 09:00:48AM +0100, Lee Jones wrote:
> > > On Mon, 06 Oct 2014, Guenter Roeck wrote:
> > > > --- a/drivers/mfd/ab8500-sysctrl.c
> > > > +++ b/drivers/mfd/ab8500-sysc
A: No.
Q: Should I include quotations after my reply?
http://daringfireball.net/2007/07/on_top
On Thu, Oct 09, 2014 at 09:00:58PM +0530, Nitin Kuppelur wrote:
> Hi Greg,
>
> Sorry for noob question. I am still new to Kernel development.
>
> I understood from your comment that the patch did no
On Thu, Oct 09, 2014 at 02:33:55PM +0100, Lee Jones wrote:
> On Thu, 09 Oct 2014, Guenter Roeck wrote:
>
> > On 10/09/2014 03:49 AM, Lee Jones wrote:
> > >On Thu, 09 Oct 2014, Catalin Marinas wrote:
> > >
> > >>On Tue, Oct 07, 2014 at 09:00:48AM +0100, Lee Jones wrote:
> > >>>On Mon, 06 Oct 2014,
On Thu, Oct 09, 2014 at 12:31:43PM +0200, Pavel Machek wrote:
> Hi!
>
> > +/**
> > + * register_poweroff_handler_simple - Register function to be called to
> > power off
> > + *the system
> > + * @handler: Function to be called to power off the system
> >
Hi Greg,
Sorry for noob question. I am still new to Kernel development.
I understood from your comment that the patch did not apply cleanly to
your tree (may be due to change in the code which I have modified)
But what should I do after this?
1) Send patch on rebased file to same mail chain with
On Thu, Oct 09, 2014 at 10:30:06AM +0400, Igor Bogomazov wrote:
> checkpatch.pl tiny fix
> get rid of 2 warnings and 2 errors for hal/fw.c
What warnings? What errors? Be specific please.
>
Trailing whitespace :(
___
devel mailing list
de...@linu
This fixes the following checkpatch.pl errors:
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:1290 error: "foo* bar"
should be "foo *bar"
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c:1305 error: "foo * bar"
should be "foo *bar"
Signed-off-by: John Ledbetter
---
drivers/staging/rtl8192e/rtl81
On Thu, 2014-10-09 at 21:53 +0800, Jia He wrote:
> This fixes space missing problems,eg. before '-', after ',', around
> '|'
I'd just say horizontal whitespace.
You can mostly update these style defect more comprehensively by using:
$ git checkout drivers/staging/rtl8188eu/
$ git ls-files "driver
Dear Sir/Madam, Here is a pdf attachment of my proposal to you. Please
read and reply I would be grateful. Jose Calvache
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
This fixes space missing problems,eg. before '-', after ',', around
'|'
Signed-off-by: Jia He
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/hal/bb_cfg.c | 4 ++--
drivers/staging/rtl8188eu/hal/fw.c | 4 ++--
drivers/staging/rtl8188eu/hal/phy.c| 2 +-
drivers/staging/rtl8188eu/hal
This fixes "ERROR: code indent should use tabs where possible"
Signed-off-by: Jia He
Cc: Greg Kroah-Hartman
---
drivers/staging/rtl8188eu/hal/rf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/hal/rf.c
b/drivers/staging/rtl8188eu/hal/rf.c
index e
This fixes all coding style error problems at rtl8188eu which
makes checkpatch.pl unhappy
Jia He (2):
staging: rtl8188eu: Fix coding style space missing problems
staging: rtl8188eu: Fix coding style not using tab problem
drivers/staging/rtl8188eu/hal/bb_cfg.c | 4 ++--
drivers/staging/rtl818
On 10/09/2014 03:38 AM, Pavel Machek wrote:
Hi!
@@ -184,6 +179,8 @@ machine_halt(void)
void
machine_power_off(void)
{
+ do_kernel_poweroff();
+
poweroff -> power_off for consistency.
Dunno; matter of personal preference. I started with that, but ultimately went
with poweroff to
On Thu, 09 Oct 2014, Guenter Roeck wrote:
> On 10/09/2014 03:49 AM, Lee Jones wrote:
> >On Thu, 09 Oct 2014, Catalin Marinas wrote:
> >
> >>On Tue, Oct 07, 2014 at 09:00:48AM +0100, Lee Jones wrote:
> >>>On Mon, 06 Oct 2014, Guenter Roeck wrote:
> --- a/drivers/mfd/ab8500-sysctrl.c
> +++ b
On Sun, Oct 05, 2014 at 09:11:29PM -0400, David Miller wrote:
> From: "K. Y. Srinivasan"
> Date: Sun, 5 Oct 2014 10:42:51 -0700
>
> > After the packet is successfully sent, we should not touch the packet
> > as it may have been freed. This patch is based on the work done by
> > Long Li .
> >
>
On 10/09/2014 04:31 AM, Geert Uytterhoeven wrote:
On Tue, Oct 7, 2014 at 7:28 AM, Guenter Roeck wrote:
+int register_poweroff_handler_simple(void (*handler)(void), int priority)
+{
+ char symname[KSYM_NAME_LEN];
+
+ if (poweroff_handler_data.handler) {
+ lookup_symbol_
On 10/09/2014 03:49 AM, Lee Jones wrote:
On Thu, 09 Oct 2014, Catalin Marinas wrote:
On Tue, Oct 07, 2014 at 09:00:48AM +0100, Lee Jones wrote:
On Mon, 06 Oct 2014, Guenter Roeck wrote:
--- a/drivers/mfd/ab8500-sysctrl.c
+++ b/drivers/mfd/ab8500-sysctrl.c
@@ -6,6 +6,7 @@
[...]
+static int
On 10/09/2014 03:32 AM, Pavel Machek wrote:
On Mon 2014-10-06 22:28:05, Guenter Roeck wrote:
Poweroff handlers may now be installed with register_poweroff_handler.
Use the new API function have_kernel_poweroff to determine if a poweroff
handler has been installed.
Cc: Rafael J. Wysocki
Cc: Pav
As long as only IPUv3 is supported in imx-drm, hide the separate
DRM_IMX_IPUV3 option and make DRM_IMX depend on IMX_IPUV3_CORE.
Reported-by: Michael Olbrich
Signed-off-by: Philipp Zabel
---
drivers/staging/imx-drm/Kconfig | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
On Thu, Oct 09, 2014 at 06:25:10PM +0800, WANG Chao wrote:
> This fixes the following sparse error:
>
> drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c:393:9: error:
> incompatible types in comparison expression (different address spaces)
>
> Signed-off-by: WANG Chao
> ---
> drive
On Tue, Oct 7, 2014 at 7:28 AM, Guenter Roeck wrote:
> +int register_poweroff_handler_simple(void (*handler)(void), int priority)
> +{
> + char symname[KSYM_NAME_LEN];
> +
> + if (poweroff_handler_data.handler) {
> + lookup_symbol_name((unsigned
> long)poweroff_handler_d
On Thu, 09 Oct 2014, Catalin Marinas wrote:
> On Tue, Oct 07, 2014 at 09:00:48AM +0100, Lee Jones wrote:
> > On Mon, 06 Oct 2014, Guenter Roeck wrote:
> > > --- a/drivers/mfd/ab8500-sysctrl.c
> > > +++ b/drivers/mfd/ab8500-sysctrl.c
> > > @@ -6,6 +6,7 @@
> >
> > [...]
> >
> > > +static int ab850
On Tue, Oct 07, 2014 at 06:28:34AM +0100, Guenter Roeck wrote:
> Register with kernel poweroff handler instead of setting pm_power_off
> directly.
>
> Cc: Catalin Marinas
> Cc: Will Deacon
> Signed-off-by: Guenter Roeck
> ---
> arch/arm64/kernel/psci.c | 2 +-
> 1 file changed, 1 insertion(+),
Hi!
> @@ -184,6 +179,8 @@ machine_halt(void)
> void
> machine_power_off(void)
> {
> + do_kernel_poweroff();
> +
poweroff -> power_off for consistency.
> index c4f50a3..1da27d1 100644
> --- a/arch/blackfin/kernel/reboot.c
> +++ b/arch/blackfin/kernel/reboot.c
> @@ -106,6 +107,7 @@ void ma
On Tue, Oct 07, 2014 at 06:28:10AM +0100, Guenter Roeck wrote:
> diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c
> index e0ef8ba..db396bb 100644
> --- a/arch/arm64/kernel/process.c
> +++ b/arch/arm64/kernel/process.c
> @@ -94,8 +94,6 @@ void soft_restart(unsigned long addr)
>
On Tue, Oct 07, 2014 at 09:00:48AM +0100, Lee Jones wrote:
> On Mon, 06 Oct 2014, Guenter Roeck wrote:
> > --- a/drivers/mfd/ab8500-sysctrl.c
> > +++ b/drivers/mfd/ab8500-sysctrl.c
> > @@ -6,6 +6,7 @@
>
> [...]
>
> > +static int ab8500_power_off(struct notifier_block *this, unsigned long
> > unu
On Tuesday 07 October 2014 11:01 AM, Guenter Roeck wrote:
diff --git a/arch/arc/kernel/reset.c b/arch/arc/kernel/reset.c
index 2768fa1..8a4fc47 100644
--- a/arch/arc/kernel/reset.c
+++ b/arch/arc/kernel/reset.c
@@ -26,9 +26,6 @@ void machine_restart(char *__unused)
void machine_power_off(void)
On Mon 2014-10-06 22:28:05, Guenter Roeck wrote:
> Poweroff handlers may now be installed with register_poweroff_handler.
> Use the new API function have_kernel_poweroff to determine if a poweroff
> handler has been installed.
>
> Cc: Rafael J. Wysocki
> Cc: Pavel Machek
> Cc: Len Brown
> Signe
Hi!
> +/**
> + * register_poweroff_handler_simple - Register function to be called to
> power off
> + * the system
> + * @handler: Function to be called to power off the system
> + * @priority: Handler priority. For priority guidelines see
> +
Hi,
2014-10-09 19:23 GMT+09:00 Dan Carpenter :
> On Thu, Oct 09, 2014 at 03:19:03PM +0530, Sudip Mukherjee wrote:
>> On Thu, Oct 09, 2014 at 01:40:11PM +0900, Daeseok Youn wrote:
>> > The dgap_init_module() need to unwind for cleanup variables properly.
>> > Because dgap_init_module() calls dgap_c
This fixes the following sparse error:
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c:393:9: error:
incompatible types in comparison expression (different address spaces)
Signed-off-by: WANG Chao
---
drivers/staging/lustre/lnet/klnds/socklnd/socklnd_lib-linux.c | 2 +-
1 file cha
On Thu, Oct 09, 2014 at 03:19:03PM +0530, Sudip Mukherjee wrote:
> On Thu, Oct 09, 2014 at 01:40:11PM +0900, Daeseok Youn wrote:
> > The dgap_init_module() need to unwind for cleanup variables properly.
> > Because dgap_init_module() calls dgap_cleanup_module() for freeing
> > variables but this fu
On Thu, Oct 09, 2014 at 05:03:07PM +0800, Jia He wrote:
> Signed-off-by: Jia He
> This fixes all coding style error problems at rtl8188eu which
> makes checkpatch.pl unhappy
your commit message should be above your Signed-off line.
mention what type of error you are fixing.
you are doing multip
On Thu, Oct 09, 2014 at 01:40:11PM +0900, Daeseok Youn wrote:
> The dgap_init_module() need to unwind for cleanup variables properly.
> Because dgap_init_module() calls dgap_cleanup_module() for freeing
> variables but this function is possible to free variables
> which are not allocated.
>
> Sign
On 09/10/14 00:13, Hartley Sweeten wrote:
On Wednesday, October 08, 2014 8:09 AM, Ian Abbott wrote:
`do_cmd_ioctl()`, the handler for the `COMEDI_CMD` ioctl can incorrectly
call the Comedi subdevice's `do_cmd()` handler with a NULL channel list
pointer. This is a regression as the `do_cmd()` ha
Signed-off-by: Jia He
This fixes all coding style error problems at rtl8188eu which
makes checkpatch.pl unhappy
---
drivers/staging/rtl8188eu/hal/bb_cfg.c | 4 ++--
drivers/staging/rtl8188eu/hal/fw.c | 4 ++--
drivers/staging/rtl8188eu/hal/phy.c| 2 +-
drivers/staging/rtl8188eu/hal/rf.c
Fix "out of memory" error handling
Signed-off-by: Dzmitry Sledneu
---
drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
b/drivers/staging/gs_fpgaboot/gs_fpgaboot.c
index cbf70ce..0c18c4c
On 10/09/2014 12:48 AM, Greg Kroah-Hartman wrote:
> On Tue, Oct 07, 2014 at 05:54:48PM +0200, Dzmitry Sledneu wrote:
>> Fix "Possible unnecessary 'out of memory' message" checkpatch.pl warning
>>
>> Signed-off-by: Dzmitry Sledneu
>>
>> ---
>> drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 7 ++-
44 matches
Mail list logo
