you are right, would be wise to do that, added
On Thu, 9 Oct 2014 10:32:37 +0400
Denis Kirjanov wrote:
> But you haven't CCed people in the CC list
>
> On 10/9/14, Igor Bogomazov wrote:
> > checkpatch.pl tiny fix
> > get rid of 2 warnings and 2 errors for hal/fw.c
> >
> > Signed-off-by: Igor B
But you haven't CCed people in the CC list
On 10/9/14, Igor Bogomazov wrote:
> checkpatch.pl tiny fix
> get rid of 2 warnings and 2 errors for hal/fw.c
>
> Signed-off-by: Igor Bogomazov
> Cc: Greg Kroah-Hartman
> Cc: navin patidar
> Cc: Stephen Rothwell
> ---
> for linux-next 3.17.0
>
> this
checkpatch.pl tiny fix
get rid of 2 warnings and 2 errors for hal/fw.c
Signed-off-by: Igor Bogomazov
Cc: Greg Kroah-Hartman
Cc: navin patidar
Cc: Stephen Rothwell
---
for linux-next 3.17.0
this is an updated version of the patch I've sent two days ago, that one
did not apply cleanly
diff
There is code encapsulated in #if 1, let's remove it.
Signed-off-by: Vladimir A. Nazarenko
---
drivers/staging/vt6655/device_main.c | 4
drivers/staging/vt6655/wpactl.c | 3 ---
2 files changed, 7 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c
b/drivers/staging/vt6655
The dgap_init_module() need to unwind for cleanup variables properly.
Because dgap_init_module() calls dgap_cleanup_module() for freeing
variables but this function is possible to free variables
which are not allocated.
Signed-off-by: Daeseok Youn
---
V2: change ulong which is non-standard to "un
It's never enabled, so we can safely remove it.
Signed-off-by: Vladimir A. Nazarenko
---
drivers/staging/vt6655/device_main.c | 10 ++
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c
b/drivers/staging/vt6655/device_main.c
index de5378e.
This variable unused, so remove it.
Signed-off-by: Vladimir A. Nazarenko
---
drivers/staging/vt6655/device_main.c | 8
drivers/staging/vt6655/ioctl.c | 4
2 files changed, 12 deletions(-)
diff --git a/drivers/staging/vt6655/device_main.c
b/drivers/staging/vt6655/device_main
Custom ioctl 0xff is legacy code that was used for
patched version of wpa_supplicant, where function
wpa_authen_Status_transfer() called this ioctl to
tell authentication status to the driver. While
from upstream was added only driver code to the
kernel but not patches to the wpa_supplic
Hi, Dan
2014-10-08 20:37 GMT+09:00 Dan Carpenter :
> All three of these patches are good and a nice improvement. This one is
> a good bugfix. I have some notes for later, though below.
>
> On Wed, Oct 08, 2014 at 08:13:56PM +0900, Daeseok Youn wrote:
>> diff --git a/drivers/staging/dgap/dgap.c b
On Wednesday, October 08, 2014 8:09 AM, Ian Abbott wrote:
> `do_cmd_ioctl()`, the handler for the `COMEDI_CMD` ioctl can incorrectly
> call the Comedi subdevice's `do_cmd()` handler with a NULL channel list
> pointer. This is a regression as the `do_cmd()` handler has never been
> expected to deal
On Wed, Oct 08, 2014 at 08:34:48PM +0200, Rene Kolarik wrote:
> Wrapping two too long lines in two files of the imx-drm driver.
>
> Signed-off-by: Rene Kolarik
> ---
> drivers/staging/imx-drm/imx-drm-core.c | 3 ++-
> drivers/staging/imx-drm/imx-tve.c | 3 ++-
> 2 files changed, 4 insertion
On Tue, Oct 07, 2014 at 01:11:42PM +0400, Igor Bogomazov wrote:
> checkpatch.pk tiny fix
> get rid of 2 warnings and 2 errors for hal/fw.c
>
> Signed-off-by: Igor Bogomazov
> Cc: Greg Kroah-Hartman
> Cc: navin patidar
> Cc: Stephen Rothwell
> ---
> linux-next 3.17.0
I think someone else a
On Sat, Oct 04, 2014 at 10:24:28AM +0800, Cheng-wei Lee wrote:
> This patch fix the sparse warnings in wlan-ng/cfg80211.c
> The following functions were only used in this file, so done by
> declaring them into static.
>
> drivers/staging/wlan-ng/cfg80211.c:710:6: warning: symbol
> 'prism2_connect_
On Fri, Oct 03, 2014 at 10:19:44PM +0200, Abel Moyo wrote:
> Replaced memcpy with ether_addr_copy in slic_mcast_add_list.
> Addresses are _aligned(2) as the struct mcast_address has only
> single field of type unsigned char.
>
> Signed-off-by: Abel Moyo
> ---
> Changes in v2:
> - Indicate h
On Tue, Oct 07, 2014 at 05:54:48PM +0200, Dzmitry Sledneu wrote:
> Fix "Possible unnecessary 'out of memory' message" checkpatch.pl warning
>
> Signed-off-by: Dzmitry Sledneu
>
> ---
> drivers/staging/gs_fpgaboot/gs_fpgaboot.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
>
On Thu, Oct 02, 2014 at 02:32:26PM +0200, Nitin Kuppelur wrote:
> Removed unnecessary else after return to solve
> checkpatch.pl warning
>
> Signed-off-by: Nitin Kuppelur
> ---
> drivers/staging/rtl8712/hal_init.c | 7 ++-
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/d
On Tue, Sep 30, 2014 at 11:29:00PM +0530, Karthik Nayak wrote:
> Removed the else statement occurring after an if statement with a
> return value as per checkpatch warning.
>
> Signed-off-by: Karthik Nayak
> ---
> drivers/staging/bcm/InterfaceMisc.c | 9 -
> 1 file changed, 4 insertions(
On Tue, Sep 30, 2014 at 10:56:17PM +0530, Karthik Nayak wrote:
> 1. WARNING: else is not generally useful after a break or return
>
> 2. WARNING: quoted string split across lines
>
> 3. WARNING: break quoted strings at a space character
>
> Signed-off-by: Karthik Nayak
> ---
> drivers/staging/
On 14-10-08 04:52 PM, Aaro Koskinen wrote:
> Hi,
>
> On Wed, Oct 08, 2014 at 09:46:55PM +0200, Roberto Medina wrote:
>> Thank you very much for your feedback. I just want to let you know that I
>> didn't ignore that annotation from the last patch. I actually added the
>> white line because checkpa
Hi,
On Wed, Oct 08, 2014 at 09:46:55PM +0200, Roberto Medina wrote:
> Thank you very much for your feedback. I just want to let you know that I
> didn't ignore that annotation from the last patch. I actually added the
> white line because checkpatch shows a warning there.
>
> WARNING: Missing a b
On 10/08/2014 09:39 PM, Paul Gortmaker wrote:
On 14-10-08 03:18 PM, Roberto Medina wrote:
From: Roberto Medina
Fixed coding style warnings due to missing blank lines.
Dubious additions removed.
Signed-off-by: Roberto Medina
---
@@ -550,6 +559,7 @@ int cvm_oct_xmit_pow(struct sk_buff *skb, s
>
> This sort of test is generally better where the
> individual tests are written on separate lines like:
>
> if ((data[idx] != pktdata[i]) ||
> (data[idx+1] != pktdata[i+1])) {
>
Thanks for all the suggestions, Joe. I'll upload a revised patch s
On 14-10-08 03:18 PM, Roberto Medina wrote:
> From: Roberto Medina
>
> Fixed coding style warnings due to missing blank lines.
> Dubious additions removed.
>
> Signed-off-by: Roberto Medina
>
> ---
> drivers/staging/octeon/ethernet-tx.c | 11 +++
> 1 file changed, 11 insertions(+)
>
From: Roberto Medina
Fixed coding style warnings due to missing blank lines.
Dubious additions removed.
Signed-off-by: Roberto Medina
---
drivers/staging/octeon/ethernet-tx.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/drivers/staging/octeon/ethernet-tx.c
b/drivers/stagi
On 14-10-08 01:51 PM, Roberto Medina wrote:
> From: Roberto Medina
>
> Fixed coding style warnings due to missing blank lines.
Seems some dubious additions -- annotated below
>
> Signed-off-by: Roberto Medina
>
> ---
> drivers/staging/octeon/ethernet-tx.c | 13 +
> 1 file ch
Am Montag 06 Oktober 2014, 22:28:31 schrieb Guenter Roeck:
> Register with kernel poweroff handler instead of setting pm_power_off
> directly. Register with default priority value of 128 since we don't know
> any better.
I just tested this change and it seems to break power off. What the driver
d
Wrapping two too long lines in two files of the imx-drm driver.
Signed-off-by: Rene Kolarik
---
drivers/staging/imx-drm/imx-drm-core.c | 3 ++-
drivers/staging/imx-drm/imx-tve.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-drm-core.c
b
From: Roberto Medina
Fixed coding style warnings due to missing blank lines.
Signed-off-by: Roberto Medina
---
drivers/staging/octeon/ethernet-tx.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/drivers/staging/octeon/ethernet-tx.c
b/drivers/staging/octeon/ethernet-tx.c
i
On Tue, 2014-10-07 at 20:42 -0700, Serguey Parkhomovsky wrote:
> This patch fixes two unnecessary else conditions that were found by
> checkpatch.pl.
[]
> diff --git a/drivers/staging/rtl8712/rtl8712_efuse.c
> b/drivers/staging/rtl8712/rtl8712_efuse.c
[]
> @@ -541,15 +540,16 @@ u8 r8712_efuse_map
For the overlay plane scanning out a framebuffer with an alpha component,
enable the DP local alpha feature on the partial plane.
Signed-off-by: Philipp Zabel
---
drivers/staging/imx-drm/ipuv3-plane.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/drivers/stagi
While the DMA channel is running, it is not allowed to change anything
but the inactive (double) buffer base address, so resizing a plane or
changing to a frame buffer with different pixel format is not possible.
Signed-off-by: Philipp Zabel
---
drivers/staging/imx-drm/ipuv3-plane.c | 15 +++
This allows to update the buffer base address while the DMA
channel is running. It is needed to flip the frame buffer of
an active plane.
Signed-off-by: Philipp Zabel
---
Changes since v2:
- Rebased onto 7d2691da901d (gpu: ipu-v3: Add ipu-cpmem unit)
---
drivers/staging/imx-drm/ipuv3-plane.c |
Setting the stride can only be done on inactive channels, while
the buffer base address can also be updated for running channels
using the hardware double buffering feature.
Signed-off-by: Philipp Zabel
---
Changes since v2:
- Rebased onto 7d2691da901d (gpu: ipu-v3: Add ipu-cpmem unit)
---
driv
This patch fixes two unnecessary else conditions that were found by
checkpatch.pl.
Signed-off-by: Serguey Parkhomovsky
---
v2: use negation instead of comparing to false in if statement (suggested by
Joe Perches)
drivers/staging/rtl8712/rtl8712_efuse.c | 40 -
1
`do_cmd_ioctl()`, the handler for the `COMEDI_CMD` ioctl can incorrectly
call the Comedi subdevice's `do_cmd()` handler with a NULL channel list
pointer. This is a regression as the `do_cmd()` handler has never been
expected to deal with that, leading to a kernel OOPS when it tries to
dereference
Joe Perches writes:
> On Wed, 2014-10-08 at 16:33 +0200, Jes Sorensen wrote:
>> Joe Perches writes:
>> > On Wed, 2014-10-08 at 15:46 +0300, Dan Carpenter wrote:
>> >> On Wed, Oct 08, 2014 at 05:26:11AM -0700, Joe Perches wrote:
>> >> > On Wed, 2014-10-08 at 13:40 +0300, Dan Carpenter wrote:
>> >>
On Wed, 2014-10-08 at 16:33 +0200, Jes Sorensen wrote:
> Joe Perches writes:
> > On Wed, 2014-10-08 at 15:46 +0300, Dan Carpenter wrote:
> >> On Wed, Oct 08, 2014 at 05:26:11AM -0700, Joe Perches wrote:
> >> > On Wed, 2014-10-08 at 13:40 +0300, Dan Carpenter wrote:
> >> > > The return from myid()
Joe Perches writes:
> On Wed, 2014-10-08 at 15:46 +0300, Dan Carpenter wrote:
>> On Wed, Oct 08, 2014 at 05:26:11AM -0700, Joe Perches wrote:
>> > On Wed, 2014-10-08 at 13:40 +0300, Dan Carpenter wrote:
>> > > The return from myid() isn't aligned correctly for ether_addr_copy().
>> >
>> > Hey Dan
Dan Carpenter writes:
> On Wed, Oct 08, 2014 at 03:59:33PM +0200, Jes Sorensen wrote:
>> Dan Carpenter writes:
>> > The return from myid() isn't aligned correctly for ether_addr_copy().
>> >
>> > Signed-off-by: Dan Carpenter
>>
>> Sorry, this makes no sense, just fix it properly!
>>
>> drivers
On Wed, 2014-10-08 at 15:46 +0300, Dan Carpenter wrote:
> On Wed, Oct 08, 2014 at 05:26:11AM -0700, Joe Perches wrote:
> > On Wed, 2014-10-08 at 13:40 +0300, Dan Carpenter wrote:
> > > The return from myid() isn't aligned correctly for ether_addr_copy().
> >
> > Hey Dan.
> >
> > Actual evidence s
On Wed, Oct 08, 2014 at 03:59:33PM +0200, Jes Sorensen wrote:
> Dan Carpenter writes:
> > The return from myid() isn't aligned correctly for ether_addr_copy().
> >
> > Signed-off-by: Dan Carpenter
>
> Sorry, this makes no sense, just fix it properly!
>
> drivers/staging/rtl8723au/include/rtw_ee
On Wed, Oct 08, 2014 at 06:53:02AM -0700, Greg Kroah-Hartman wrote:
> On Thu, Oct 09, 2014 at 12:17:06AM +1100, Vladimir A. Nazarenko wrote:
> > This patch fixes the following sparse warning:
> > drivers/staging/vt6655/ioctl.c:44:12: warning: symbol 'wpa_Result'
> > was not declared. Should it
Dan Carpenter writes:
> The return from myid() isn't aligned correctly for ether_addr_copy().
>
> Signed-off-by: Dan Carpenter
Sorry, this makes no sense, just fix it properly!
drivers/staging/rtl8723au/include/rtw_eeprom.h:
struct eeprom_priv {
u8 bautoload_fail_flag;
On Thu, Oct 09, 2014 at 12:17:06AM +1100, Vladimir A. Nazarenko wrote:
> This patch fixes the following sparse warning:
> drivers/staging/vt6655/ioctl.c:44:12: warning: symbol 'wpa_Result'
> was not declared. Should it be static?
>
> There is no sense to set up all fields of wpa_Result to ze
On Wed, Oct 08, 2014 at 02:50:50PM +0200, Julia Lawall wrote:
> Couldn't you just use your favorite matching tool, collect the file names,
> compile them, run pahole, and process the output in some way? It doesn't
> give a complete analysis (you don't find all problems), but if you find a
> proble
This patch fixes the following sparse warning:
drivers/staging/vt6655/ioctl.c:44:12: warning: symbol 'wpa_Result'
was not declared. Should it be static?
There is no sense to set up all fields of wpa_Result to zero when
interface set up (in device_open()), because wpa_Result is used
only in
On Wed, 8 Oct 2014, Dan Carpenter wrote:
> On Wed, Oct 08, 2014 at 05:26:11AM -0700, Joe Perches wrote:
> > On Wed, 2014-10-08 at 13:40 +0300, Dan Carpenter wrote:
> > > The return from myid() isn't aligned correctly for ether_addr_copy().
> >
> > Hey Dan.
> >
> > Actual evidence showing ether_a
Hello.
On 10/8/2014 1:15 PM, Dan Carpenter wrote:
These probably should have been sent to devicet...@vger.kernel.org. Use
the maintainer.pl script.
You surely meant scripts/get_maintainer.pl. :-)
regards,
dan carpenter
WBR, Sergei
___
devel
On Wed, Oct 08, 2014 at 05:26:11AM -0700, Joe Perches wrote:
> On Wed, 2014-10-08 at 13:40 +0300, Dan Carpenter wrote:
> > The return from myid() isn't aligned correctly for ether_addr_copy().
>
> Hey Dan.
>
> Actual evidence showing ether_addr_copy conversions
> may not always be wise.
>
> How
On Wed, 2014-10-08 at 13:40 +0300, Dan Carpenter wrote:
> The return from myid() isn't aligned correctly for ether_addr_copy().
Hey Dan.
Actual evidence showing ether_addr_copy conversions
may not always be wise.
How did you find them?
Is there a new alignment capability in smatch?
__
All three of these patches are good and a nice improvement. This one is
a good bugfix. I have some notes for later, though below.
On Wed, Oct 08, 2014 at 08:13:56PM +0900, Daeseok Youn wrote:
> diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c
> index 7c79fe6..00f34b5 100644
- Guenter Roeck 写道：
> pm_power_off is defined for all architectures. Move it to common code.
>
> Have all architectures call do_kernel_poweroff instead of pm_power_off.
> Some architectures point pm_power_off to machine_power_off. For those,
> call do_kernel_poweroff from machine_power_off i
The dgap_init_module() need to unwind for cleanup variables properly.
Because dgap_init_module() calls dgap_cleanup_module() for freeing
variables but this function is possible to free variables
which are not allocated.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 27 +
dgap_do_remap() and dgap_release_remap() names could be
changed to dgap_remap() and dgap_unmap().
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 14 +++---
1 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/d
dgap_release_remap() function is only called after the memory
has been remapped so if statement for checking NULL doesn't
need.
And also release_mem_region() calls are moved after iounmap() calls.
Signed-off-by: Daeseok Youn
---
drivers/staging/dgap/dgap.c | 13 -
1 files changed,
The return from myid() isn't aligned correctly for ether_addr_copy().
Signed-off-by: Dan Carpenter
diff --git a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
b/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
index 3eb77de..c8f7890 100644
--- a/drivers/staging/rtl8723au/core/rtw_mlme_ext.c
+++ b/d
These probably should have been sent to devicet...@vger.kernel.org. Use
the maintainer.pl script.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Oct 07, 2014 at 07:28:10AM +0200, Guenter Roeck wrote:
> pm_power_off is defined for all architectures. Move it to common code.
>
> Have all architectures call do_kernel_poweroff instead of pm_power_off.
> Some architectures point pm_power_off to machine_power_off. For those,
> call do_ker
58 matches
Mail list logo
