With respect to the upper case lower case issue, does the thing need to be
a macro? I think that the lowercase is more or less fine, but only if
what is behind it is a function.
I say more or less fine, because normally in the kernel the special
allocators have special purposes, eg allocating and
On 2014.09.19 01:57, Rene Kolarik wrote:
> Hello,
>
> I've fixed coding style issues in drivers/staging/imx-drm directory. This is
> a part of Eudyptula Challenge.
Please submit your patches "inline" (look at /Documentation/SubmittingPatches
section 7). Also, think about if it's worth seperating
On Sep 18, 2014, at 10:57 PM, Drokin, Oleg wrote:
> would not be easy to do. Perhaps registered callbacks for pools that could be
> called on alloc and on free - though such pools would also need to allow to
> allocate different sized chunks too).
Come think of it - we don't even need callback
Hello!
On Sep 18, 2014, at 7:43 PM, Dan Carpenter wrote:
> On Thu, Sep 18, 2014 at 10:24:02PM +0200, Julia Lawall wrote:
>> From: Julia Lawall
>>
>> This patch removes some kzalloc-related macros and rewrites the
>> associated null tests to use !x rather than x == NULL.
> This is sort of exactl
On 09/19/2014 08:21 AM, Lee Jones wrote:
On Thu, 18 Sep 2014, micky wrote:
On 09/18/2014 12:53 PM, Lee Jones wrote:
On Thu, 18 Sep 2014, micky_ch...@realsil.com.cn wrote:
From: Micky Ching
Fix rts5227&5249 failed send buffer cmd after suspend,
PM_CTRL3 should reset before send any buffer c
On Thu, 18 Sep 2014, micky wrote:
> On 09/18/2014 12:53 PM, Lee Jones wrote:
> >On Thu, 18 Sep 2014, micky_ch...@realsil.com.cn wrote:
> >
> >>From: Micky Ching
> >>
> >>Fix rts5227&5249 failed send buffer cmd after suspend,
> >>PM_CTRL3 should reset before send any buffer cmd after suspend.
> >>
On Thu, Sep 18, 2014 at 10:24:02PM +0200, Julia Lawall wrote:
> From: Julia Lawall
>
> This patch removes some kzalloc-related macros and rewrites the
> associated null tests to use !x rather than x == NULL.
>
This is sort of exactly what Oleg asked us not to do in his previous
email. ;P
I th
Hello,
I've fixed coding style issues in drivers/staging/imx-drm directory. This is a
part of Eudyptula Challenge.
Rene Kolarik
Signed-off-by: Rene Kolarik
diff --git a/Documentation/devicetree/bindings/arm/fsl.txt b/Documentation/devicetree/bindings/arm/fsl.txt
index e935d7d..4004bb8 100644
-
On Thu, Sep 18, 2014 at 09:57:17PM +0200, Rickard Strandqvist wrote:
>
> Should I add this as a patch in lib/string.c or email him first.. What
> is customary in these situations?
>
Just write up a normal patch and try to merge it through the normal
methods.
It's not that controversial to do:
Hello,
I'm sending this as a part of Eudyptula Challenge.
Rene Kolarik
diff --git a/Documentation/devicetree/bindings/arm/fsl.txt b/Documentation/devicetree/bindings/arm/fsl.txt
index e935d7d..4004bb8 100644
--- a/Documentation/devicetree/bindings/arm/fsl.txt
+++ b/Documentation/devicetree/bindi
[...]
>>
>> In that case, don't forget to enable MMC_CAP2_FULL_PWR_CYCLE.
>>
>> >
>> > if MMC_CAP2_NO_PRESCAN_POWERUP enable, will call mmc_power_off() at start,
>> > then it will check ios.power_mode, but the state is MMC_POWER_OFF and just
>> > return.
>>
>> Uhh, that's right! So, I wonder why w
The following patch removes some kzalloc-related macros and rewrites the
associated null tests to use !x rather than x == NULL. The complete
semantic patch used for this transformation is as follows:
//
@disable unlikely@
expression ptr;
statement S,S1;
@@
\(OBD_ALLOC\|OBD_ALLOC_WAIT\|OBD_ALL
From: Julia Lawall
This patch removes some kzalloc-related macros and rewrites the
associated null tests to use !x rather than x == NULL.
A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/)
//
@@
expression ptr;
statement S,S1;
@@
\(
2014-09-18 10:51 GMT+02:00 Dan Carpenter :
> On Thu, Sep 18, 2014 at 12:12:42AM +0200, Rickard Strandqvist wrote:
>> Hi Dan
>>
>> Ok, I have made two suggestions for strncpy function that also
>> guarantees a terminating null character.
>> 1) retunerar number of characters to be copied, it can be g
Added error checking for alloc_tx_struct in do_tx()
Signed-off-by: Abel Moyo
---
Changes in v2:
- Added spin_unlock
- Removed print error message
drivers/staging/gdm724x/gdm_usb.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/staging/gdm724x/gdm_usb.c
b/drivers/staging/
This inline function is no longer used. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_fc.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/comedi_fc.h
b/drivers/staging/comedi
This inline function is just a wrapper around comedi_inc_scan_progress().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/mite.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/mite.c
The inline function cfc_inc_scan_progress() is just a wrapper around
the comedi core function comedi_inc_scan_progress(). Convert all the
drivers to use the core function directly and remove the wrapper.
This series applies after:
PATCH 00/11] staging: comedi: move comedi_fc functionality into co
This inline function is just a wrapper around comedi_bytes_per_scan().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das16.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/das16.c
b
This inline function is just a wrapper around comedi_bytes_per_scan().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl816.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl816.c
This inline function is just a wrapper around comedi_bytes_per_scan().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pci230.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/amp
This inline function is just a wrapper around comedi_bytes_per_scan().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl812.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl
This inline function is just a wrapper around comedi_bytes_per_scan().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pci224.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/amp
The inline function cfc_bytes_per_scan() is just a wrapper around the
comedi core function comedi_bytes_per_scan(). Convert all the drivers
to use the core function directly and remove the wrapper.
This series applies after:
PATCH 00/11] staging: comedi: move comedi_fc functionality into core
H
This inline function is just a wrapper around comedi_bytes_per_scan().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl818.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl818.c
This inline function is just a wrapper around comedi_bytes_per_scan().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/mite.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/mite.c
b/d
This inline function is no longer used. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_fc.h | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/comedi/drivers/comedi_fc.h
b/drivers/staging/comedi/
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl726.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_atmio16d.c | 2 +-
1 file changed, 1 insertion(+), 1 de
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
Also, comedi_handle_events() does nothing if no events are set so the
local variable 'oldevents' can be removed.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc:
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c | 3 +--
1 file changed, 1 inse
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pc236_common.c | 2 +-
1 file changed, 1 insertion(+
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
Also, comedi_handle_events() does nothing if no events are set so the
local variable 'do_event' can be removed.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: G
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt2814.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi_apci_1032.c | 2 +-
1 file changed, 1 insertion(+), 1
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
Also, comedi_handle_events() does nothing if no events are set so the
local variable 'oldevents' can be removed.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc:
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dmm32at.c | 3 +--
1 file changed, 1 insertion(+), 2 delet
Clear the A/D FIFO as part of the analog input (*cancel) to help with
cleaning up the async command.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/rtd520.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/comedi/dri
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_6527.c | 2 +-
1 file changed, 1 insertion(+), 1 deleti
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
Also, comedi_handle_events() does nothing if no events are set so the
local variable 'oldevents' can be removed.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc:
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
For aesthetics, add a local variable for the comedi_subdevice pointer.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/c
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
The s626_mc_disable() call when the end-of-acquisition is detected can
then be removed. The (*cancel) does the same thing.
For aesthetics, also remove the 'finished' l
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pci230.c | 48 ++-
1 file ch
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
The code to cancel the async command can then be removed from rtd_interrupt().
Since the (*cancel) will also clear the FIFO, the ai_read_dregs() function
can also be r
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_65xx.c | 2 +-
1 file changed, 1 insertion(+), 1 deleti
The comedi async commands should stop if an error/overflow happens or when
the end-of-acquisition for the command is detected. Some of the drivers
do this correctly but many don't.
The comedi_handle_events() function automatically detects the events that
would terminate a command. If the events ar
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
Also, comedi_handle_events() does nothing if no events are set so the
check can be removed.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
-
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_parport.c | 2 +-
1 file changed, 1 insertion(+), 1
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
The pcl711_ai_set_mode() call when the end-of-acquisition is detected
can then be removed. The (*cancel) does the same thing.
Signed-off-by: H Hartley Sweeten
Cc: Ian
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 13 -
1 file chan
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi_apci_3xxx.c | 2 +-
1 file changed, 1 insertion(+), 1
Currently comedi_handle_events() is done by both the DMA and non-DMA helper
functions that are called by the interrupt handler. For aesthetics, move
the comedi_handle_events() to the end of the interrupt handler and do it in
one place.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kro
Use comedi_handle_events() to automatically (*cancel) the async command
for an end-of-acquisition or if an error/overflow occurs.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/addi_apci_1564.c | 2 +-
1 file changed, 1 insertion(+), 1
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl812.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl812.c
b
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt282x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/dt282x.
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl818.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/pcl818.c
b
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/qu
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9111.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/ad
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/amplc_pci224.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/a
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/gsc_hpdi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/gsc_hpdi.
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das800.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das800.
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adl_pci9118.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/adl_pc
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_pcidio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_pcidi
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das16m1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/das16m1.c
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/pcl816.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl816.
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das1800.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/das180
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/dt3000.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/dt3000.c
b
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_labpc_common.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/driv
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb_p
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_mio_common.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/comedi
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_660x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_660x.c
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/das16.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/das16.c
b/d
The inline function cfc_handle_events() is just a wrapper around the
comedi core function comedi_handle_events(). Convert all the drivers
to use the core function directly and remove the wrapper.
This series applies after:
PATCH 00/11] staging: comedi: move comedi_fc functionality into core
H Ha
This inline function is no longer used. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/comedi_fc.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/comedi/drivers/comedi_fc.h
b/drivers/staging/comedi
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_at_a2150.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/
cfc_handle_events() is just a wrapper around comedi_handle_events().
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/adv_pci1710.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/comedi
> -Original Message-
> From: Christoph Hellwig [mailto:h...@infradead.org]
> Sent: Thursday, September 18, 2014 9:43 AM
> To: Olaf Hering
> Cc: KY Srinivasan; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; jbottom...@parallels.com; linux-
> s...@vger.kernel.org
> Subject: R
On Thu, Sep 18, 2014 at 01:50:17PM +0200, Olaf Hering wrote:
> On Wed, Sep 17, Christoph Hellwig wrote:
>
> > Also the two patches at
> > http://thread.gmane.org/gmane.linux.drivers.driver-project.devel/56242/
>
> Wasnt the outcome that this was a bad idea? Or at least doing it
> globally is bad.
On Tue, Sep 02, K. Y. Srinivasan wrote:
> Get rid of the warning messages since they will clutter up various system logs
> and are of questionable value to the end user. For debugging purposes, this
> information can be gotten by setting the scsi log level appropriately.
>
> Signed-off-by: K. Y.
Fix the sparse warning: symbol 'CAM_read_entry' was not declared. Should it be
static?
The function CAM_read_entry is not used and therefore deleted.
Signed-off-by: Benedict Boerger
---
changes in v2:
add Signed-off-by line
drivers/staging/rtl8192u/r8192U_core.c | 28 -
On Thu, Sep 18, 2014 at 02:33:25PM +, Ragnar B. Johannsson wrote:
> Move ieee80211_crypto*_init and _exit prototype declarations from
> r8192U_core.c to ieee80211/ieee80211.h. This fixes the following sparse
> warnings:
>
> drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c:203:12: warning
Move ieee80211_crypto*_init and _exit prototype declarations from r8192U_core.c
to ieee80211/ieee80211.h. This fixes the following sparse warnings:
drivers/staging/rtl8192u/ieee80211/ieee80211_crypt.c:203:12: warning: symbol
'ieee80211_crypto_init' was not declared. Should it be static?
drivers/
On 17/09/2014 18:10, Hartley Sweeten wrote:
On Tuesday, September 16, 2014 4:40 AM, Luca Ellero wrote:
This series of patches add counter support for NI USB-6501. I tested it on my
device and it works fine.
Hartley, Ian,
thank you for your comments.
I'll collect them all and I'll resend a "v
On Wed, Sep 17, Christoph Hellwig wrote:
> Also the two patches at
> http://thread.gmane.org/gmane.linux.drivers.driver-project.devel/56242/
Wasnt the outcome that this was a bad idea? Or at least doing it
globally is bad. In any case, its not something I can help with.
Olaf
___
On 2014-09-17 17:57, Hartley Sweeten wrote:
On Tuesday, September 16, 2014 4:40 AM, Luca Ellero wrote:
Add function for counter subdevice configuration.
Signed-off-by: Luca Ellero
---
drivers/staging/comedi/drivers/ni_usb6501.c | 28 +++
1 file changed, 28 insertio
On Thu, Sep 18, 2014 at 12:12:42AM +0200, Rickard Strandqvist wrote:
> Hi Dan
>
> Ok, I have made two suggestions for strncpy function that also
> guarantees a terminating null character.
> 1) retunerar number of characters to be copied, it can be good to
> have, but was not really satisfied.
str
On 2014-09-17 at 21:17:29 +0200, Benedict Boerger
wrote:
> Fix the sparse warning: symbol 'CAM_read_entry' was not declared. Should it
> be static?
>
> The function CAM_read_entry is not used and therefore deleted.
Your patch is missing a Signed-off-by line. Please check
Documentation/Submitti
On Wed, 2014-09-17 at 21:29 +0200, Ulf Hansson wrote:
> On 17 September 2014 11:11, micky wrote:
> > On 09/17/2014 02:01 AM, Ulf Hansson wrote:
> >>
> >> On 12 September 2014 03:39, wrote:
> >>>
> >>> From: Roger Tseng
> >>>
> >>> Some platform have both UEFI driver and MFD/mmc driver, if enter
89 matches
Mail list logo
