- add line after declaration
- allignment should match open parenthesis
- remove unnecessary new line
Signed-off-by: Purnendu Kapadia
---
drivers/staging/android/sw_sync.c | 9 +
drivers/staging/android/sw_sync.h | 2 +-
2 files changed, 6 insertions(+), 5 deletions(-)
diff --g
This patch fixes the following sparse warnings:
CHECK drivers/staging/rtl8188eu/hal/fw.c
drivers/staging/rtl8188eu/hal/fw.c:219:13: warning: cast to restricted
__le16
drivers/staging/rtl8188eu/hal/fw.c:219:13: warning: cast to restricted
__le16
drivers/staging/rtl8188eu/hal/fw.c:219:13: warnin
On Wednesday, September 10, 2014 3:56 AM, Ian Abbott wrote:
> On 2014-09-10 00:15, H Hartley Sweeten wrote:
>> The validation of the cmd->stop_arg when the cmd->stop_src == TRIG_EXT
>> is a bit over thought. The comments state that the stop_arg is validated
>> to force an external trigger of 0 and
On Wed, Sep 10, 2014 at 11:35:29AM +0200, Philipp Zabel wrote:
> Hi Greg,
>
> I have asked Dave to pull Steve Longerbeam's preparation series for
> capture support. It starts off with the following two commits that also
> touch the staging driver. Could you pull this into the staging tree to
> avo
On Wednesday, September 10, 2014 4:27 AM, Ian Abbott wrote:
> On 2014-09-10 00:15, H Hartley Sweeten wrote:
>> The cmd->stop_src is used to determine how an async command is terminated.
>> Typically the following sources are used:
>>
>>TRIG_NONE: command must be stopped with a (*cancel) operat
On Wed, Sep 10, 2014 at 04:20:27PM +0200, Adrien PEYROUTY wrote:
> Hello all,
>
> I am currently working on a UART driver for linux.
For what specific UART and platform?
> I am developping a new architecture on which I have 3 uart ports.
3 different uarts on what type of bus?
> In this archite
HDMI currently stops working after a system suspend/resume cycle. The
cause is that the mode setting states in hardware gets lost and isn't
restored across the suspend/resume cycle.
The patch adds a very basic suspend/resume support to imx-drm driver,
and calls drm_helper_resume_force_mode() in .
Hello!
On Sep 10, 2014, at 10:36 AM, Joe Perches wrote:
> On Wed, 2014-09-10 at 16:06 +0200, Julia Lawall wrote:
>> On Wed, 10 Sep 2014, Joe Perches wrote:
>>> On Wed, 2014-09-10 at 11:43 +0300, Dan Carpenter wrote:
On Tue, Sep 09, 2014 at 01:38:13PM -0700, Joe Perches wrote:
> Macros wi
On Wed, 2014-09-10 at 16:06 +0200, Julia Lawall wrote:
> On Wed, 10 Sep 2014, Joe Perches wrote:
> > On Wed, 2014-09-10 at 11:43 +0300, Dan Carpenter wrote:
> > > On Tue, Sep 09, 2014 at 01:38:13PM -0700, Joe Perches wrote:
> > > > Macros with flow control statements (goto and return) are
> > > > n
All those ipu_*_put() calls in ipu_plane_dpms() are unnecessary,
because the only occurrence of ipu_plane_dpms() with 'mode' not being
DRM_MODE_DPMS_ON is in function ipu_disable_plane(), which already
has a ipu_plane_put_resources() call to put those ipu resources right
after ipu_plane_dpms().
So
Hello all,
I am currently working on a UART driver for linux.
I am developping a new architecture on which I have 3 uart ports.
In this architecture, I know that there will be 3 UARTs, and this driver has to
be compiled with the kernel, it mustn't be a module driver.
The exact thing I want to do
On Wed, 10 Sep 2014, Joe Perches wrote:
> On Wed, 2014-09-10 at 11:43 +0300, Dan Carpenter wrote:
> > On Tue, Sep 09, 2014 at 01:38:13PM -0700, Joe Perches wrote:
> > > Macros with flow control statements (goto and return) are
> > > not very nice to read as any flow movement is unexpected.
>
> bre
On Wed, 2014-09-10 at 11:43 +0300, Dan Carpenter wrote:
> On Tue, Sep 09, 2014 at 01:38:13PM -0700, Joe Perches wrote:
> > Macros with flow control statements (goto and return) are
> > not very nice to read as any flow movement is unexpected.
break and continue are also flow control statements
but
On Wed, Sep 10, 2014 at 08:29:26AM -0500, Romer, Benjamin M wrote:
> On Tue, 2014-09-09 at 16:11 +0530, Sudip Mukherjee wrote:
> > fixed sparse warning : context imbalance in 'resume_device'
> > unexpected unlock
> > this patch will generate warning from checkpatch for
> > l
On Tue, 2014-09-09 at 16:11 +0530, Sudip Mukherjee wrote:
> fixed sparse warning : context imbalance in 'resume_device'
> unexpected unlock
> this patch will generate warning from checkpatch for
> lines over 80 character , but since those are user-visible strings
> so it was
On 2014-09-10 00:15, H Hartley Sweeten wrote:
The cmd->stop_src is used to determine how an async command is terminated.
Typically the following sources are used:
TRIG_NONE: command must be stopped with a (*cancel) operation
cmd->stop_arg is always 0
TRIG_COUNT: command t
On 2014-09-10 00:15, H Hartley Sweeten wrote:
When the cmd->stop_src == TRIG_COUNT, the 'ao_stop_count' is the cmd->stop_arg.
For any other stop_src the 'ao_stop_count' is 0, which is also the
cmd->stop_arg.
Simplify the 'ao_stop_count' initialization.
Signed-off-by: H Hartley Sweeten
Cc: Ian
In preparation for the following patch, stop decrementing the endpoint node
refcount in the loop. This temporarily leaks a reference to the endpoint node,
which will be fixed by having of_graph_get_next_endpoint decrement the refcount
of its prev argument instead.
Signed-off-by: Philipp Zabel
---
Using the for_each_... macro should make the code a bit shorter and
easier to read.
Signed-off-by: Philipp Zabel
Acked-by: Laurent Pinchart
---
drivers/gpu/drm/drm_of.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_of.c b/drivers/gpu/drm/drm_of.
Note that while of_graph_get_next_endpoint decrements the reference count
of the child node passed to it, of_node_put(child) still has to be called
manually when breaking out of the loop.
Signed-off-by: Philipp Zabel
---
Changes since v1:
- Added a comment about the child node reference count wh
Using the for_each_... macro should make the code bit shorter and
easier to read.
Signed-off-by: Philipp Zabel
---
drivers/staging/imx-drm/imx-drm-core.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/imx-drm/imx-drm-core.c
b/drivers/stagi
In preparation for a following patch, stop decrementing the endpoint node
refcount in the loop. This temporarily leaks a reference to the endpoint node,
which will be fixed by having of_graph_get_next_endpoint decrement the refcount
of its prev argument instead.
Signed-off-by: Philipp Zabel
---
Hi,
this series converts all existing users of of_graph_get_next_endpoint that pass
a non-NULL prev argument to the function and decrement its refcount themselves
to stop doing that. The of_node_put is moved into of_graph_get_next_endpoint
instead.
This allows to add a for_each_endpoint_of_node he
This patch adds a function to get a port device tree node by port id,
or reg property value.
Signed-off-by: Philipp Zabel
---
Changes since v1:
- Fixed whitespace in comment
- Changed id parameter to of_graph_get_port_by_id to u32
- Simplified of_graph_get_port_by_id as suggested by Laurent,
Using the for_each_... macro should make the code bit shorter and
easier to read. This patch also properly decrements the endpoint node
reference count before returning out of the loop.
Signed-off-by: Philipp Zabel
---
drivers/staging/imx-drm/imx-drm-core.c | 9 +++--
1 file changed, 3 inser
Decrementing the reference count of the previous endpoint node allows to
use the of_graph_get_next_endpoint function in a for_each_... style macro.
Prior to this patch, all current users of this function that actually pass
a non-NULL prev parameter should be changed to not decrement the passed
prev
On 2014-09-10 00:15, H Hartley Sweeten wrote:
The validation of the cmd->stop_arg when the cmd->stop_src == TRIG_EXT
is a bit over thought. The comments state that the stop_arg is validated
to force an external trigger of 0 and allow the CR_EDGE flag, which is
ignored. In reality the stop_arg is
On 2014-09-09 21:05, H Hartley Sweeten wrote:
Start cleaning up the async command support in this comedi driver.
This is a repost of the series. I missed the first patch last time.
H Hartley Sweeten (30):
staging: comedi: adl_pci9118: factor out DMA alloc/free
staging: comedi: adl_pci9118
Hi Greg,
I have asked Dave to pull Steve Longerbeam's preparation series for
capture support. It starts off with the following two commits that also
touch the staging driver. Could you pull this into the staging tree to
avoid conflicts later on?
The following changes since commit 7d1311b93e58ed55
On 2014-09-10 07:03, Chase Southwood wrote:
This patchset begins by cleaning up the mess of the comments in
this driver, then follows that with three very small and trivial
checkpatch warning fixes.
Chase Southwood (4):
staging: comedi: hwdrv_apci3120: clean up comments
staging: comedi: hw
On Tue, Sep 09, 2014 at 01:38:13PM -0700, Joe Perches wrote:
> Macros with flow control statements (goto and return) are
> not very nice to read as any flow movement is unexpected.
>
> Try to highlight them and emit a warning on their definition.
>
> Avoid warning on macros that use argument conc
Attn:
This is to inform you that I have tried my best here to ensure that your Fund
is released back to you with the help of the Governor General of BLU Financial
securities West African states for the release of your fund, we discovered
that it only remain 48hrs Hours to its expiration date.
The pci_state member of struct vnt_private is used nowhere in the code,
so remove it. Supposedly it was used to save the PCI configuration space
which is now done using pci_save_state().
Signed-off-by: Tobias Klauser
---
drivers/staging/vt6655/device.h | 4
1 file changed, 4 deletions(-)
d
ethtool (and SIOCETHTOOL in particular) is part of Linux since the
pre-git era, it thus makes no sense no sense to make the include of
linux/ethtool.h conditional. Also remove the unused define
DEVICE_ETHTOOL_IOCTL_SUPPORT.
Signed-off-by: Tobias Klauser
---
drivers/staging/vt6655/device.h | 5 --
Instead of using an own copy of struct net_device_stats in struct
vnt_private, use stats from struct net_device. Also remove the thus
unnecessary device_get_stats(), as it would now just return
netdev->stats, which is the default in dev_get_stats().
Signed-off-by: Tobias Klauser
---
drivers/stag
35 matches
Mail list logo
