[PATCH v2] drivers: staging: dgap: fix the checkpatch.pl issue "Warning: line over 80 characters"

Break lines exceeding 80 characters Signed-off-by: Piotr Witoslawski --- drivers/staging/dgap/dgap.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 8929dbf..67da1d5 100644 --- a/drivers/staging

[PATCH] staging: lustre: lmv: lmv_internal.h: fix checkpatch.pl spacing errors

lmv_internal.h:96: ERROR: space prohibited after that open parenthesis '(' lmv_internal.h:96: ERROR: space required before the open parenthesis '(' lmv_internal.h:147: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: Juston Li --- drivers/staging/lustre/lu

For A Long Term Business Relationship,

Dear Sir/Madam, We are interested in purchasing your products , and we sincerely hope to establish a long-term business relationship with your esteemed company. Please kindly send me your catalog. Also, inform me about the Minimum Order Quantity,Delivery time or FOB /CIF, and payment terms

RE: [PATCH] staging: comedi: hwdrv_apci1500: use dev->class_dev in calls to dev_warn()

On Wednesday, September 03, 2014 4:59 PM, Chase Southwood wrote: > git-grep reveals that hwdrv_apci1500.c is the only file in comedi that uses > dev->hw_dev in calls to dev_{err,warn}(). The rest of the drivers pass > dev->class_dev to these macros instead. Switch the dev_warn() calls in > this d

[PATCH] staging: comedi: hwdrv_apci1500: use dev->class_dev in calls to dev_warn()

git-grep reveals that hwdrv_apci1500.c is the only file in comedi that uses dev->hw_dev in calls to dev_{err,warn}(). The rest of the drivers pass dev->class_dev to these macros instead. Switch the dev_warn() calls in this driver to use dev->class_dev as well, for consistency. Signed-off-by: Cha

[PATCH] Staging: rtl8821ae: base: add missing blank line after declaration

Add a missing blank line after declaration to fix coding style issue. Signed-off-by: An Ha --- drivers/staging/rtl8821ae/base.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8821ae/base.c b/drivers/staging/rtl8821ae/base.c index 4a36da0..dbf28ce 100644 --- a/drivers/st

[PATCH 4/4] staging: et131x: Fix whitespace - alignment matching open parenthesis

Fix occurrences in et131x.c of: CHECK: Alignment should match open parenthesis Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 130 +--- 1 file changed, 67 insertions(+), 63 deletions(-) diff --git a/drivers/staging/et131x/et131x.c b/drivers/

[PATCH 3/4] staging: et131x: Add auto-negotiation and 1000BT_Half as supported protocols

The driver supports auto-negotiation and 100BaetT_Half but doesn't advertise or list it in it's phydev. Fix that. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/staging/et131x/et131x.c

[PATCH 1/4] staging: et131x: Remove dead code in isr

Dan Carpenter reports: The patch c2ebf58ba089: "staging: et131x: Implement NAPI support" from Aug 21, 2014, leads to the following static checker warning: drivers/staging/et131x/et131x.c:4004 et131x_isr() warn: we tested 'status' before and it was 'true' We don't actually need the

[PATCH 2/4] staging: et131x: Remove spinlock fbr_lock

The spinlock fbr_lock is only used in a single call sequence staring from et131x_poll. As this call is already locked by napi->poll_lock, we can remove it. Signed-off-by: Mark Einon --- drivers/staging/et131x/et131x.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/et131

Greetings

Greetings How are you doing today? i hope all is well with you and your family. Please i am contacting you for good and betterment of us. I am a staff of a financial firm here in Asia and you are my first contact, and I am contacting you because I need to do this deal with someone outside my cou

[PATCH v2 2/6] staging: goldfish: remove useless space after a cast

Coding style: remove useless space after a cast Signed-off-by: Loic Pefferkorn --- drivers/staging/goldfish/goldfish_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/goldfish/goldfish_nand.c b/drivers/staging/goldfish/goldfish_nand.c index 092604c..aac8

[PATCH v2 5/6] staging: goldfish: document mutex usage

Coding style: document mutex usage Signed-off-by: Loic Pefferkorn --- drivers/staging/goldfish/goldfish_nand.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/goldfish/goldfish_nand.c b/drivers/staging/goldfish/goldfish_nand.c index 3f13ef0..c6c85d3 100644 --- a/drivers/stag

[PATCH v2 6/6] staging: goldfish: avoid multiple assignments

Coding style: avoid multiple assignments Signed-off-by: Loic Pefferkorn --- drivers/staging/goldfish/goldfish_nand.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/goldfish/goldfish_nand.c b/drivers/staging/goldfish/goldfish_nand.c index c6c85d3..d68f216 1

[PATCH v2 1/6] staging: goldfish: suppress consecutive blank lines

Coding style: suppress consecutive blank lines Signed-off-by: Loic Pefferkorn --- drivers/staging/goldfish/goldfish_audio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c index c89d0b8..23a206d 100644 --

[PATCH v2 4/6] staging: goldfish: fix alignment to match open parenthesis

Coding style: fix alignment to match open parenthesis Signed-off-by: Loic Pefferkorn --- drivers/staging/goldfish/goldfish_audio.c | 21 +- drivers/staging/goldfish/goldfish_nand.c | 36 +++ 2 files changed, 28 insertions(+), 29 deletions(-) diff --g

[PATCH v2 0/6] staging: goldfish: fix coding style

Hi, This patchset fixes several coding style warnings detected by checkpatch.pl: -CHECK: Please don't use multiple blank lines -CHECK: No space is necessary after a cast -CHECK: spinlock_t definition without comment -CHECK: Alignment should match open parenthesis -CHECK: struct mutex definition wi

[PATCH v2 3/6] staging: goldfish: document spinlock usage

Coding style: document spinlock usage Signed-off-by: Loic Pefferkorn --- drivers/staging/goldfish/goldfish_audio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c index 23a206d..b360d07 100644 --- a/driver

FROM: Husam Al Sayed.

FROM: Husam Al Sayed. EMAIL:alsayedh...@hotmail.com Hello, I decided to write you this proposal in good faith, believing that you will not betray me. I am Mr. Husam Al Sayed, a Bank officer here in U.A.E. One Mr. Peter Adams, a citizen of your country and Crude Oil dealer made a fixed depos

RE: [PATCH 00/37] staging: comedi: rename command flags for consistency

On Wednesday, September 03, 2014 5:45 AM, Ian Abbott wrote: > > The various macros in "comedi.h" used to construct values for the > `flags` member of `struct comedi_cmd` are named inconsistently. Some of > the macros with the `TRIG_` prefix are from a long defunct Comedi > trigger interface that w

RE: [PATCH] staging: comedi: ni_at_a2150: range check board index

On Monday, September 01, 2014 6:14 AM, Ian Abbott wrote: > The "ni_at_a2150" driver determines the board type by calling > `a2150_probe()`. This reads a register and converts it to a board index > in the range 0 to 3. However, the board table array it indexes into > (`a2150_boards[]`) only has 2

Re: [PATCH v2] staging: unisys: uislib: uisqueue.c: rewrite of do_locked_client_insert

On Wed, Sep 03, 2014 at 06:41:30PM +0300, Dan Carpenter wrote: > On Wed, Sep 03, 2014 at 08:13:25PM +0530, Sudip Mukherjee wrote: > > On Wed, Sep 03, 2014 at 02:29:44PM +0530, Sudip Mukherjee wrote: > > > On Wed, Sep 03, 2014 at 11:40:38AM +0300, Dan Carpenter wrote: > > > > On Tue, Sep 02, 2014 at

Re: [PATCH 3/6] staging: goldfish: document spinlock usage

On Wed, Sep 03, 2014 at 01:13:19PM +0100, One Thousand Gnomes wrote: > > This tells the reader nothing. It's good to document locking models but > > - you lock data not code (which is a detail a lot of programmers get wrong > in th design stage too) > - you need to documen

Re: [PATCH v2] staging: unisys: uislib: uisqueue.c: rewrite of do_locked_client_insert

On Wed, Sep 03, 2014 at 08:13:25PM +0530, Sudip Mukherjee wrote: > On Wed, Sep 03, 2014 at 02:29:44PM +0530, Sudip Mukherjee wrote: > > On Wed, Sep 03, 2014 at 11:40:38AM +0300, Dan Carpenter wrote: > > > On Tue, Sep 02, 2014 at 11:46:35PM +0530, Sudip Mukherjee wrote: > > > > From: Sudip Mukherjee

Re: [PATCH] drivers: staging: dgap: fix the checkpatch.pl issue "Warning: line over 80 characters"

On Wed, Sep 03, 2014 at 04:09:59PM +0200, Piotr Witoslawski wrote: > Done as Eudyptula task 10. use proper commit message mentioning what changes you have done. and you have not sent the patch to all the people who were supposed to be sent. thanks sudip > Signed-off-by: Piotr Witoslawski > ---

Re: [PATCH v2] staging: unisys: uislib: uisqueue.c: rewrite of do_locked_client_insert

On Wed, Sep 03, 2014 at 02:29:44PM +0530, Sudip Mukherjee wrote: > On Wed, Sep 03, 2014 at 11:40:38AM +0300, Dan Carpenter wrote: > > On Tue, Sep 02, 2014 at 11:46:35PM +0530, Sudip Mukherjee wrote: > > > From: Sudip Mukherjee > > > > I really would prefer if you just figured out your email setti

[PATCH] drivers: staging: dgap: fix the checkpatch.pl issue "Warning: line over 80 characters"

Done as Eudyptula task 10. Signed-off-by: Piotr Witoslawski --- drivers/staging/dgap/dgap.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c index 8929dbf..67da1d5 100644 --- a/drivers/staging/dgap/dgap

[PATCH 32/37] staging: comedi: ni_at_a2150: use CMDF_ROUND_...

Replace use of the `TRIG_ROUND_...` macros with the new names `CMDF_ROUND_...`. The numeric values are unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/ni_at_a2150.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers

[PATCH 36/37] staging: comedi: rtd520: use CMDF_ROUND_...

Replace use of the `TRIG_ROUND_...` macros with the new names `CMDF_ROUND_...`. The numeric values are unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/rtd520.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/drivers/stag

[PATCH 35/37] staging: comedi: ni_pcidio: use CMDF_ROUND_...

Replace use of the `TRIG_ROUND_...` macros with the new names `CMDF_ROUND_...`. The numeric values are unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/ni_pcidio.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/comedi/driver

[PATCH 22/37] staging: comedi: add CMDF_ROUND_... as synonyms for TRIG_ROUND_...

The `TRIG_ROUND_...` macros are some of the values that can be OR-ed into the `flags` member of `struct comedi_cmd`. They may influence the rounding of sample timings during operation of the asynchronous command. The names are a bit of a left-over from earlier times. It would be better to use th

[PATCH 37/37] staging: comedi: s626: use CMDF_ROUND_...

Replace use of the `TRIG_ROUND_...` macros with the new names `CMDF_ROUND_...`. The numeric values are unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/s626.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/s626.c

[PATCH 34/37] staging: comedi: ni_mio_common: use CMDF_ROUND_...

Replace use of the `TRIG_ROUND_...` macros with the new names `CMDF_ROUND_...`. The numeric values are unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/ni_mio_common.c | 38 +- 1 file changed, 19 insertions(+), 19 deletions(-) diff --git a/drivers

[PATCH 33/37] staging: comedi: ni_labpc_common: use CMDF_ROUND_...

Replace use of the `TRIG_ROUND_...` macros with the new names `CMDF_ROUND_...`. The numeric values are unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/ni_labpc_common.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/dri

[PATCH 29/37] staging: comedi: dt282x: use CMDF_ROUND_...

Replace use of the `TRIG_ROUND_...` macros with the new names `CMDF_ROUND_...`. The numeric values are unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/dt282x.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt28

[PATCH 31/37] staging: comedi: me4000: use CMDF_ROUND_...

Replace use of the `TRIG_ROUND_...` macros with the new names `CMDF_ROUND_...`. The numeric values are unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/me4000.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/comedi/drive

[PATCH 28/37] staging: comedi: das1800: use CMDF_ROUND_...

Replace use of the `TRIG_ROUND_...` macros with the new names `CMDF_ROUND_...`. The numeric values are unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/das1800.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/das

[PATCH 30/37] staging: comedi: dt3000: use CMDF_ROUND_...

Replace use of the `TRIG_ROUND_...` macros with the new names `CMDF_ROUND_...`. The numeric values are unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/dt3000.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/dt30

[PATCH 06/37] staging: comedi: add CMDF_WAKE_EOS as synonym for TRIG_WAKE_EOS

`TRIG_WAKE_EOS` is one of the values that can be OR-ed into the `flags` member of `struct comedi_cmd`. It's intended action is tune the asynchronous command to interrupt at the end of every "scan". The name is a bit of a left-over from earlier times. A better name would be `CMDF_WAKE_EOS` to mat

[PATCH 27/37] staging: comedi: cb_pcidas64: use CMDF_ROUND_...

Replace use of the `TRIG_ROUND_...` macros with the new names `CMDF_ROUND_...`. The numeric values are unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/cb_pcidas64.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers

[PATCH 26/37] staging: comedi: amplc_pci230: use CMDF_ROUND_...

Replace use of the `TRIG_ROUND_...` macros with the new names `CMDF_ROUND_...`. The numeric values are unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci230.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/comedi/d

[PATCH 18/37] staging: comedi: pcl812: use CMDF_WAKE_EOS

Replace use of `TRIG_WAKE_EOS` command flag with the new name `CMDF_WAKE_EOS`. The numeric value is unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/pcl812.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/pcl812.c b/dri

[PATCH 24/37] staging: comedi: addi_apci_3xxx: use CMDF_ROUND_...

Replace use of the `TRIG_ROUND_...` macros with the new names `CMDF_ROUND_...`. The numeric values are unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/addi_apci_3xxx.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/driv

[PATCH 09/37] staging: comedi: adl_pci9118: use CMDF_WAKE_EOS

Replace use of `TRIG_WAKE_EOS` command flag with the new name `CMDF_WAKE_EOS`. The numeric value is unchanged. Also change diagnostic messages to use "CMDF_WAKE_EOS" instead of "TRIG_WAKE_EOS" and change the Comedi driver description comment to use "CMDF_WAKE_EOS". Signed-off-by: Ian Abbott ---

[PATCH 13/37] staging: comedi: cb_pcidas64: use CMDF_WAKE_EOS

Replace use of `TRIG_WAKE_EOS` command flag with the new name `CMDF_WAKE_EOS`. The numeric value is unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/cb_pcidas64.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/comedi/drivers

[PATCH 11/37] staging: comedi: amplc_pci230: use CMDF_WAKE_EOS

Replace use of `TRIG_WAKE_EOS` command flag with the new name `CMDF_WAKE_EOS`. The numeric value is unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pci230.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/amplc_pci

[PATCH 19/37] staging: comedi: rtd520: use CMDF_WAKE_EOS

Replace use of `TRIG_WAKE_EOS` command flag with the new name `CMDF_WAKE_EOS`. The numeric value is unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/rtd520.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/rtd520.c b/dri

[PATCH 23/37] staging: comedi: 8253.h: use CMDF_ROUND_...

Replace use of the `TRIG_ROUND_...` macros with the new names `CMDF_ROUND_...`. The numeric values are unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/8253.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/8253.h

[PATCH 17/37] staging: comedi: ni_tiocmd: use CMDF_WAKE_EOS

Replace use of `TRIG_WAKE_EOS` command flag with the new name `CMDF_WAKE_EOS`. The numeric value is unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/ni_tiocmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_tiocmd.c

[PATCH 16/37] staging: comedi: ni_mio_common: use CMDF_WAKE_EOS

Replace use of `TRIG_WAKE_EOS` command flag with the new name `CMDF_WAKE_EOS`. The numeric value is the same. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/ni_mio_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_mio_co

[PATCH 12/37] staging: comedi: cb_pcidas: use CMDF_WAKE_EOS

Replace use of `TRIG_WAKE_EOS` command flag with the new name `CMDF_WAKE_EOS`. The numeric value is unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/cb_pcidas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/cb_pcidas.c

[PATCH 14/37] staging: comedi: das1800: use CMDF_WAKE_EOS

Replace use of `TRIG_WAKE_EOS` command flag with the new name `CMDF_WAKE_EOS`. The numeric value is unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/das1800.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/das180

[PATCH 25/37] staging: comedi: adl_pci9118: use CMDF_ROUND_...

Replace use of the `TRIG_ROUND_...` macros with the new names `CMDF_ROUND_...`. The numeric values are unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/adl_pci9118.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/adl_pci

[PATCH 15/37] staging: comedi: ni_labpc_common: use CMDF_WAKE_EOS

Replace use of `TRIG_WAKE_EOS` command flag with the new name `CMDF_WAKE_EOS`. The numeric value is the same. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/ni_labpc_common.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/n

[PATCH 10/37] staging: comedi: adv_pci1710: use CMDF_WAKE_EOS

Replace use of `TRIG_WAKE_EOS` command flag with the new name `CMDF_WAKE_EOS`. The numeric value is unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/adv_pci1710.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/adv_pc

[PATCH 21/37] staging: comedi: use CMDF_BOGUS in do_cmd_ioctl()

`TRIG_BOGUS` is now just a synonym for `CMDF_BOGUS`. Change `do_cmd_ioctl()` to use the new name. Signed-off-by: Ian Abbott --- drivers/staging/comedi/comedi_fops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi

[PATCH 20/37] staging: comedi: add CMDF_BOGUS as synonym for TRIG_BOGUS

`TRIG_BOGUS` is one of the values that can be OR-ed into the `flags` member of `struct comedi_cmd`. It causes the comedi core to go through some of the motions of setting up an asynchronous command without actually setting it up. If all goes well, it causes the command set-up to fail with an `EAG

[PATCH 07/37] staging: comedi: use CMDF_WAKE_EOS in do_cmd_ioctl()

`TRIG_WAKE_EOS` is now just a synonym for `CMDF_WAKE_EOS`. Change `do_cmd_ioctl()` to use the new name. Signed-off-by: Ian Abbott --- drivers/staging/comedi/comedi_fops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/

[PATCH 04/37] staging: comedi: ni_at_a2150: use CMDF_PRIORITY

Replace use of `TRIG_RT` command flag with the equivalent flag `CMDF_PRIORITY`. The numeric value is unchanged. Also replace "TRIG_RT" with "CMDF_PRIORITY" in the kernel messages. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/ni_at_a2150.c | 4 ++-- 1 file changed, 2 insertions(

[PATCH 01/37] staging: comedi: comedi_test: use CMDF_PRIORITY

Replace use of `TRIG_RT` command flag with the equivalent flag `CMDF_PRIORITY`. The numeric value is unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/comedi_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/comedi_te

[PATCH 02/37] staging: comedi: das16: use CMDF_PRIORITY

Replace use of `TRIG_RT` command flag with the equivalent flag `CMDF_PRIORITY`. The numeric value is unchanged. Also replace "TRIG_RT" with "CMDF_PRIORITY" in kernel log messages. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/das16.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 00/37] staging: comedi: rename command flags for consistency

The various macros in "comedi.h" used to construct values for the `flags` member of `struct comedi_cmd` are named inconsistently. Some of the macros with the `TRIG_` prefix are from a long defunct Comedi trigger interface that was replaced with the current Comedi asynchronous command interface man

[PATCH 05/37] staging: comedi: ni_labpc_common: use CMDF_PRIORITY

Replace use of `TRIG_RT` command flag with the equivalent flag `CMDF_PRIORITY`. The numeric value is unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/ni_labpc_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_la

[PATCH 03/37] staging: comedi: das1800: use CMDF_PRIORITY

Replace use of `TRIG_RT` command flag with the equivalent flag `CMDF_PRIORITY`. The numeric value is unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/das1800.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/das1800.c

[PATCH 08/37] staging: comedi: addi_apci_3120: use CMDF_WAKE_EOS

Replace use of `TRIG_WAKE_EOS` command flag with the new name `CMDF_WAKE_EOS`. The numeric value is unchanged. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/d

Re: [PATCH 3/6] staging: goldfish: document spinlock usage

On Wed, 3 Sep 2014 13:13:44 +0200 Loic Pefferkorn wrote: > Coding style: document spinlock usage > > Signed-off-by: Loic Pefferkorn > --- > drivers/staging/goldfish/goldfish_audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/goldfish/goldfish_aud

[PATCH] staging: rtl8723au: Remove write-only variables hal_data_8723a.EEPROM[VP]ID

From: Jes Sorensen Signed-off-by: Jes Sorensen --- drivers/staging/rtl8723au/hal/usb_halinit.c | 22 -- drivers/staging/rtl8723au/include/rtl8723a_hal.h | 4 2 files changed, 26 deletions(-) diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c b/drivers/stag

Re: [PATCH] staging: rtl8723au: type casting corrections

Greg KH writes: > On Sun, Aug 17, 2014 at 10:19:28AM -0300, Raphael Silva wrote: >> Type casting corrections in order to solve warnings of the sparce static >> analyser. >> >> Signed-off-by: Raphael Silva >> --- >> drivers/staging/rtl8723au/hal/usb_halinit.c | 4 ++-- >> drivers/staging

[PATCH 5/6] staging: goldfish: document mutex usage

Coding style: document mutex usage Signed-off-by: Loic Pefferkorn --- drivers/staging/goldfish/goldfish_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/goldfish/goldfish_nand.c b/drivers/staging/goldfish/goldfish_nand.c index 3f13ef0..f177911 100644 --

[PATCH 3/6] staging: goldfish: document spinlock usage

Coding style: document spinlock usage Signed-off-by: Loic Pefferkorn --- drivers/staging/goldfish/goldfish_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c index 23a206d..ab723ab 100

[PATCH 0/6] staging: goldfish: fix coding style warnings

Hi, This patchset (for next-20140902) fixes several coding style warnings found by checkpatch.pl: -CHECK: Please don't use multiple blank lines -CHECK: No space is necessary after a cast -CHECK: spinlock_t definition without comment -CHECK: Alignment should match open parenthesis -CHECK: struct m

[PATCH 2/6] staging: goldfish: remove useless space after a cast

Coding style: remove useless space after a cast Signed-off-by: Loic Pefferkorn --- drivers/staging/goldfish/goldfish_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/goldfish/goldfish_nand.c b/drivers/staging/goldfish/goldfish_nand.c index 092604c..aac8

[PATCH 1/6] staging: goldfish: suppress consecutive blank lines

Coding style: suppress consecutive blank lines Signed-off-by: Loic Pefferkorn --- drivers/staging/goldfish/goldfish_audio.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/goldfish/goldfish_audio.c b/drivers/staging/goldfish/goldfish_audio.c index c89d0b8..23a206d 100644 --

[PATCH 4/6] staging: goldfish: fix alignment to match open parenthesis

Coding style: fix alignment to match open parenthesis Signed-off-by: Loic Pefferkorn --- drivers/staging/goldfish/goldfish_audio.c | 21 +- drivers/staging/goldfish/goldfish_nand.c | 36 +++ 2 files changed, 28 insertions(+), 29 deletions(-) diff --g

[PATCH 6/6] staging: goldfish: avoid multiple assignments

Coding style: avoid multiple assignments Signed-off-by: Loic Pefferkorn --- drivers/staging/goldfish/goldfish_nand.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/goldfish/goldfish_nand.c b/drivers/staging/goldfish/goldfish_nand.c index f177911..17cd439 1

Re: [PATCH v3] staging: unisys: uislib: uisqueue.c: rewrite of do_locked_client_insert

hi, please do not consider this patch. v4 has been sent with some changes as suggested by Dan Carpenter. thanks sudip ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/1] Drivers: hv: util: Properly pack the data for file copy functionality

On 09/03/2014 10:21 AM, K. Y. Srinivasan wrote: > Properly pack the data for file copy functionality. Patch based on > investigation done by Matej Muzila > > Signed-off-by: K. Y. Srinivasan > Reported-by: q...@redhat.com > Cc: > --- > include/uapi/linux/hyperv.h |2 +- > 1 files changed, 1

Re: [PATCH v4] staging: unisys: uislib: uisqueue.c: rewrite of do_locked_client_insert

On Wed, Sep 03, 2014 at 02:59:21PM +0530, Sudip Mukherjee wrote: > 1) removed unused variables > 2) fixed sparse warning of context imbalance in 'do_locked_client_insert' > different lock contexts for basic block > 3) removed the call to visor_signalqueue_empty() , this fun

[PATCH v4] staging: unisys: uislib: uisqueue.c: rewrite of do_locked_client_insert

1) removed unused variables 2) fixed sparse warning of context imbalance in 'do_locked_client_insert' different lock contexts for basic block 3) removed the call to visor_signalqueue_empty() , this function is checking whether a signal queue is empty, but the return valu

Re: [PATCH v2] staging: unisys: uislib: uisqueue.c: rewrite of do_locked_client_insert

On Wed, Sep 03, 2014 at 02:29:44PM +0530, Sudip Mukherjee wrote: > > This patch is much better and more interesting, but I still want some > > more changes. > > > I have already sent v3 of the patch just before your mail , based on > what greg k-h has suggested about the commnent. Please discard

Re: [PATCH] staging: comedi: skel: remove driver

On 2014-09-02 18:01, H Hartley Sweeten wrote: The comedi skeleton driver is one of the few "hybrid" drivers with both legacy and PCI attach mechanisms. Instead of splitting this driver, just remove it. There are many other comedi drivers that provide better examples. Signed-off-by: H Hartley Swe

Re: [PATCH v2] staging: unisys: uislib: uisqueue.c: rewrite of do_locked_client_insert

On Wed, Sep 03, 2014 at 11:40:38AM +0300, Dan Carpenter wrote: > On Tue, Sep 02, 2014 at 11:46:35PM +0530, Sudip Mukherjee wrote: > > From: Sudip Mukherjee > > I really would prefer if you just figured out your email settings so > this isn't needed. The From: header is mostly used for people > f

[PATCH v3] staging: unisys: uislib: uisqueue.c: rewrite of do_locked_client_insert

From: Sudip Mukherjee removed unused variables fixed sparse warning of context imbalance in 'do_locked_client_insert' different lock contexts for basic block Signed-off-by: Sudip Mukherjee --- v1 of the patch of the patch just fixed the sparse warning. On suggestion o

Re: [PATCH v2] staging: unisys: uislib: uisqueue.c: rewrite of do_locked_client_insert

On Tue, Sep 02, 2014 at 11:46:35PM +0530, Sudip Mukherjee wrote: > From: Sudip Mukherjee I really would prefer if you just figured out your email settings so this isn't needed. The From: header is mostly used for people forwarding patches from other people. We have allowed people to use the Fro

re: staging: et131x: Implement NAPI support

Hello Mark Einon, The patch c2ebf58ba089: "staging: et131x: Implement NAPI support" from Aug 21, 2014, leads to the following static checker warning: drivers/staging/et131x/et131x.c:4004 et131x_isr() warn: we tested 'status' before and it was 'true' drivers/staging/et131x/et131x.