Fix the checkpatch complaint regarding unnecessary line continuation.
WARNING: Avoid unnecessary line continuations
#143: FILE: ad7606_core.c:143:
Signed-off-by: Sören Brinkmann
---
drivers/staging/iio/adc/ad7606_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/driv
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/Makefile |2 +-
drivers/staging/rtl8188eu/hal/HalHWImg8188E_BB.c | 715 --
drivers/staging/rtl8188eu/hal/bb_cfg.c | 715 ++
3 files changed, 716 insertions(+), 716 del
Rename CamelCase variables and function name.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |2 +-
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c| 27 +---
drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h |2 --
drivers/stagi
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/Makefile|2 +-
drivers/staging/rtl8188eu/hal/HalHWImg8188E_MAC.c | 134 -
drivers/staging/rtl8188eu/hal/mac_cfg.c | 134 +
3 files changed, 135 insertions(+), 135 de
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/Makefile |2 +-
drivers/staging/rtl8188eu/hal/HalHWImg8188E_RF.c | 320 --
drivers/staging/rtl8188eu/hal/rf_cfg.c | 320 ++
3 files changed, 321 insertions(+), 321 del
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/Makefile |2 +-
drivers/staging/rtl8188eu/hal/phy.c | 381 +++
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 381 ---
3 files changed, 382 insertions(+), 382 dele
Rename CamelCase variables and function name.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |2 +-
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c| 33 ++--
drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h |4 ---
drivers/stag
Rename CamelCase variables and function name.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c |2 +-
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c| 44 ++--
drivers/staging/rtl8188eu/hal/usb_halinit.c|2 +-
drivers/stagi
Rename CamelCase variables and function name.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/HalHWImg8188E_RF.c |2 +-
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 32 +++
drivers/staging/rtl8188eu/hal/odm.c|2 +-
drivers/staging/rt
Rename CamelCase variables and function name.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
b/drivers/staging/rtl8188eu/hal/
Rename CamelCase variables and function name.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
b/drivers/staging/rtl8188
Rename CamelCase variables and function name.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 98 +--
1 file changed, 37 insertions(+), 61 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
b/drivers/staging/rtl818
Rename CamelCase variables and function name.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 105 ++-
1 file changed, 45 insertions(+), 60 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
b/drivers/staging/rtl818
Rename CamelCase variables and function name.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/HalHWImg8188E_BB.c |6 +-
drivers/staging/rtl8188eu/hal/HalHWImg8188E_RF.c | 16 +-
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 176 ++--
drivers/stagi
Rename CamelCase variables and function name.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 10 +++
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |4 +--
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c| 31 +---
drivers
Rename CamelCase variables and function name.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 99 ---
1 file changed, 34 insertions(+), 65 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
b/drivers/staging/rtl818
Rename CamelCase variables and function name.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 85 +++
1 file changed, 11 insertions(+), 74 deletions(-)
diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c
b/drivers/staging/rtl818
Rename CamelCase variables and function name.
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/HalHWImg8188E_RF.c |8 +--
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 69 ++--
drivers/staging/rtl8188eu/hal/odm.c| 31 -
drive
Signed-off-by: navin patidar
---
drivers/staging/rtl8188eu/hal/hal_intf.c |7 ---
drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |1 -
drivers/staging/rtl8188eu/include/hal_intf.h |4
3 files changed, 12 deletions(-)
diff --git a/drivers/staging/rtl8188eu/h
Fixed a C99 comment issue in InterfaceMisc.h.
Signed-off-by: Anh Le
---
drivers/staging/bcm/InterfaceMisc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm/InterfaceMisc.h
b/drivers/staging/bcm/InterfaceMisc.h
index efb6860..0e5e38b 100644
--- a/drivers/s
After changing the comments format, the other error disappears.
So silences two checkpatch errors:
ERROR: do not use C99 // comments
ERROR: trailing statements should be on next line
Signed-off-by: Janet Liu
---
drivers/staging/lustre/lnet/lnet/lib-md.c |6 +++---
1 file changed, 3 inser
Reduce the following checkpatch warnings:
WARNING: line over 80 characters
Signed-off-by: Janet Liu
---
drivers/staging/lustre/lnet/lnet/lib-md.c |9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib-md.c
b/drivers/staging/lustre/
On Sun, Aug 31, 2014 at 03:16:48AM +0300, Ramon Fried wrote:
> This patch fixes the following checkpatch.pl warnings:
>
> WARNING: Possible unnecessary 'out of memory' message
> #146: FILE: ./xlr_net.c:146:
> + if (!skb) {
> + pr_err("SKB allocation failed\n");
>
> WARNING: Mi
This patch fixes the following checkpatch.pl warnings:
WARNING: Possible unnecessary 'out of memory' message
#146: FILE: ./xlr_net.c:146:
+ if (!skb) {
+ pr_err("SKB allocation failed\n");
WARNING: Missing a blank line after declarations
#1107: FILE: ./xlr_net.c:1107:
+
On Sat, Aug 30, 2014 at 11:22:56PM +0200, Miguel Oliveira wrote:
> > Same comments as the previous ones, please redo all of these patches.
> >
> Should all the alterations be in one big single patch, insted of small ones?
I don't know, I don't remember what this patch even contained given that
it
On Thu, Jul 03, 2014 at 12:26:39AM +0900, Inki Dae wrote:
> 2014-07-01 23:22 GMT+09:00 Russell King - ARM Linux :
> > On Thu, Jun 26, 2014 at 03:46:01PM +0100, Russell King - ARM Linux wrote:
> >> On Thu, Jun 26, 2014 at 02:34:17PM +0200, Philipp Zabel wrote:
> >> > Hi Russell,
> >> >
> >> > On Tue
>
> How does this change relate to what you said you were going to do above?
>
> confused,
>
That was a fix for a sparse warning that went on this patch acidenttly.
Sorry about that.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.lin
> Same comments as the previous ones, please redo all of these patches.
>
Should all the alterations be in one big single patch, insted of small ones?
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/list
From: "John L. Hammond"
In mdc_iocontrol() remove the handlers for the obsolete llog ioctls
OBD_IOC_PARSE, OBD_IOC_LLOG_INFO, and OBD_IOC_LLOG_PRINT.
Signed-off-by: John L. Hammond
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/mdc/mdc_request.c | 15 ---
1 file chan
From: "John L. Hammond"
llog_osd_ops is not used so remove it and its supporting methods.
Signed-off-by: John L. Hammond
---
drivers/staging/lustre/lustre/include/lustre_log.h |9 -
drivers/staging/lustre/lustre/obdclass/Makefile|2 +-
drivers/staging/lustre/lustre/obdclass/llog_os
From: "John L. Hammond"
The llog_test module requires server support (it needs a local MGS to
function) and should not have been included.
Signed-off-by: John L. Hammond
---
drivers/staging/lustre/lustre/obdclass/Makefile|2 +-
drivers/staging/lustre/lustre/obdclass/llog_test.c | 1072
These structures are only used server-side to parse relevant
attributes.
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/include/lustre/lustre_idl.h | 37 -
drivers/staging/lustre/lustre/ptlrpc/wiretest.c| 48 --
2 files changed, 85 deletions(-)
dif
From: "John L. Hammond"
The declarations from lustre/include/md_object.h are not used so
remove them.
Signed-off-by: John L. Hammond
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/fid/lproc_fid.c | 1 -
drivers/staging/lustre/lustre/fld/fld_cache.c | 1 -
drivers/sta
This series of patches continues removal of unused code in
lustre client tree.
John L. Hammond (9):
staging/lustre/obdecho: remove #if 0-ed out regions
staging/lustre/obdclass: remove idmap.c
staging/lustre/obdclass: remove lu_ucred.c
staging/lustre/obdclass: remove mea.c
staging/lustre:
From: "John L. Hammond"
Remove the server specific set_info handlers (KEY_REGISTER_TARGET,
KEY_SET_FS, KEY_CLEAR_FS) and supporting functions.
Signed-off-by: John L. Hammond
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/mgc/mgc_request.c | 177
1 file c
From: Peng Tao
The metadata echo client requires server support and should not have
been included.
Signed-off-by: Liu Xuezhao
Signed-off-by: Peng Tao
Signed-off-by: John L. Hammond
Reviewed-on: http://review.whamcloud.com/2674
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-1330
Reviewed-
With removal of libcfs/heap.c, it's header can also go away now.
Signed-off-by: Oleg Drokin
---
.../staging/lustre/include/linux/libcfs/libcfs.h | 1 -
.../lustre/include/linux/libcfs/libcfs_heap.h | 200 -
drivers/staging/lustre/lustre/include/lustre_net.h | 1 -
From: "John L. Hammond"
The landing of clio #if 0-ed out some regions of echo_client.c. Just
remove these regions entirely.
Signed-off-by: John L. Hammond
Reviewed-on: http://review.whamcloud.com/5580
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-2675
Reviewed-by: James Simmons
Reviewed-
From: "John L. Hammond"
The functions defined in lustre/include/lustre_idmap.h are not used so
remove them.
Signed-off-by: John L. Hammond
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lustre_idmap.h | 104 -
drivers/staging/lustre/lustre/obdclass/Makefile| 2 +-
From: "John L. Hammond"
The functions exported by lustre/obdclass/mea.c are not used so remove
them.
Signed-off-by: John L. Hammond
---
drivers/staging/lustre/lustre/include/obd_class.h | 4 -
drivers/staging/lustre/lustre/obdclass/Makefile | 2 +-
drivers/staging/lustre/lustre/obdclass/
From: "John L. Hammond"
The functions exported by lustre/obdclass/lu_ucred.c are not used so
remove that file.
Signed-off-by: John L. Hammond
---
drivers/staging/lustre/lustre/obdclass/Makefile | 3 +-
drivers/staging/lustre/lustre/obdclass/lu_ucred.c | 107 --
2 files
On Mon, Aug 25, 2014 at 08:35:31PM +0100, Koray Gulcu wrote:
> Add two new lines that are missing after declerations as detected by
> checkpatch.pl
>
> Signed-off-by: Koray Gulcu
> ---
> drivers/staging/android/sw_sync.c |2 ++
> 1 file changed, 2 insertions(+)
2 other people sent this sam
On Wed, Aug 20, 2014 at 04:19:19PM +0100, Purnendu Kapadia wrote:
> Signed-off-by: Purnendu Kapadia
> ---
> drivers/staging/android/sync.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
> index e7b2e02..0d37495 100644
> --
On Sun, Aug 17, 2014 at 04:39:16PM +0300, Andreea-Cristina Bernat wrote:
> The "rcu_dereference()" call is used directly in a condition.
> Since its return value is never dereferenced it is recommended to use
> "rcu_access_pointer()" instead of "rcu_dereference()".
> Therefore, this patch makes the
On Sat, Aug 30, 2014 at 02:10:52PM -0400, An Ha wrote:
> Fix coding style issues, these changes include:
> -Add space between "if" and brackets
> -Add space after comma in an argument
> -Add space between equal sign to separate the variable and the assignment
> -Remove unnecessary curly braces arou
On Mon, Aug 25, 2014 at 12:55:27PM +0530, Sanjeev Sharma wrote:
> This is a patch to the r8190_rtl8256.c file that fixes
> commenting style Error
>
> Signed-off-by: Sanjeev Sharma
> ---
> drivers/staging/rtl8192u/r8190_rtl8256.c | 59
> +---
> 1 file changed, 31 inse
On Sat, Aug 23, 2014 at 10:55:51AM +0800, Hoang Tran wrote:
> This patch fixes the following sparse warnings in rtl8821ae/stats.c
>
> drivers/staging/rtl8821ae/stats.c:62:6: warning: symbol 'rtl_translate_todbm'
> was not declared. Should it be static?
> drivers/staging/rtl8821ae/stats.c:101:6: w
On Sun, Aug 17, 2014 at 10:19:28AM -0300, Raphael Silva wrote:
> Type casting corrections in order to solve warnings of the sparce static
> analyser.
>
> Signed-off-by: Raphael Silva
> ---
> drivers/staging/rtl8723au/hal/usb_halinit.c | 4 ++--
> drivers/staging/rtl8723au/os_dep/ioctl_cf
On Sat, Aug 23, 2014 at 07:48:24PM +0530, navin patidar wrote:
> Rename CamelCase variables and function name.
>
> Signed-off-by: navin patidar
This patch fails to apply:
checking file drivers/staging/rtl8188eu/hal/HalHWImg8188E_RF.c
checking file drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c
On Sun, Aug 17, 2014 at 02:43:37PM +0300, Andreea-Cristina Bernat wrote:
> The "rcu_dereference()" call is used directly in a condition.
> Since its return value is never dereferenced it is recommended to use
> "rcu_access_pointer()" instead of "rcu_dereference()".
> Therefore, this patch makes the
On Fri, Aug 22, 2014 at 11:33:20AM +0100, Miguel Oliveira wrote:
> Convert all rtw_proc_xxx references to rtw_sys_xxx
Again, your subject: is not understandable.
And what are you doing here?
> Code with 62 WARNING: line over 80 characters, I'll write another patch
> to clean the whole file.
Wha
On Fri, Aug 22, 2014 at 11:33:52AM +0100, Miguel Oliveira wrote:
> Convert all rtw_proc_xxx references to rtw_sys_xxx in file
> include/rtw_debug.h
That's interesting, but:
>
> Signed-off-by: Miguel Oliveira
> ---
> drivers/staging/rtl8188eu/include/rtw_debug.h | 227
> +++---
On Fri, Aug 22, 2014 at 11:33:37AM +0100, Miguel Oliveira wrote:
> Convert all rtw_proc_xxx references to rtw_sys_xxx in files
> include/osdep_intf.h and os_dep/usb_intf.c
Same comments as the previous ones, please redo all of these patches.
greg k-h
__
Your subject does not say what is going on in this patch, only the file
being modified :(
On Fri, Aug 22, 2014 at 11:32:38AM +0100, Miguel Oliveira wrote:
> void rtw_proc_remove_one(struct net_device *dev)
> {
> }
> void rtw_proc_init_one(struct net_device *dev)
> /* TODO: Convert these to /sys
From: Bill Pemberton
The Digi Neo cards are supported by the jsm driver. Remove support
for these cards from dgnc.
Signed-off-by: Bill Pemberton
---
drivers/staging/dgnc/dgnc_driver.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drive
From: Bill Pemberton
Add device ids for additional Neo cards. The ids come from the dgnc
driver.
Signed-off-by: Bill Pemberton
---
drivers/tty/serial/jsm/jsm.h| 10 ++
drivers/tty/serial/jsm/jsm_driver.c | 38 +
2 files changed, 44 insertion
From: Bill Pemberton
The jsm driver (drivers/tty/serial/jsm) already supports the Digi Neo
cards that dgnc (staging) supports. In fact, it appears that jsm was
based on dgnc. The dgnc driver has PCI ids for more cards than jsm,
this patch moves support for all the Neo cards to jsm.
The result
On Wed, Aug 20, 2014 at 11:17:53PM +0100, Mark Einon wrote:
> Replace a long list of contiguous writel() calls with a for loop iterating
> over the same values.
>
> Signed-off-by: Mark Einon
> ---
> drivers/staging/et131x/et131x.c | 27 +++
> 1 file changed, 3 insertions(
From: Julia Lawall
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@
type T;
expression e;
@@
(
- T *
+ T *
)
e
//
This semantic patch just removes the cast and adds it back, but when it
does so, it follows the spacing conventions of Linux.
Signed
On Sat, Aug 30, 2014 at 07:14:51PM +0100, Andrew Plummer wrote:
> Remove empty return at end of function.
>
> Signed-off-by: Andrew Plummer
> ---
> drivers/staging/nokia_h4p/nokia_fw.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/staging/nokia_h4p/nokia_fw.c
> b/drivers/st
On 08/30/2014 02:59 PM, Greg KH wrote:
On Sat, Aug 30, 2014 at 02:54:36PM -0400, wf...@worldbroken.com wrote:
From: Bill Pemberton
Add device ids for additional Neo cards. The ids come from the dgnc
driver.
Signed-off-by: Bill Pemberton
---
drivers/tty/serial/jsm/jsm_driver.c | 38 +++
On Wed, Aug 27, 2014 at 01:11:19PM +0200, Matthias Beyer wrote:
>
> -int FreeAdapterDsxBuffer(struct bcm_mini_adapter *Adapter)
> +int FreeadDsxBuffer(struct bcm_mini_adapter *ad)
This change breaks the build:
ERROR: "FreeAdapterDsxBuffer" [drivers/staging/bcm/bcm_wimax.ko] undefined!
_PLEASE_
On Sat, Aug 30, 2014 at 02:57:33PM +0800, Janet Liu wrote:
> After changing the comments format, the other error disappears.
> So silences two checkpatch errors:
> ERROR: do not use C99 // comments
> ERROR: trailing statements should be on next line
>
> Signed-off-by: Janet Liu
> ---
> drive
On Sat, Aug 30, 2014 at 02:56:09PM +0800, Janet Liu wrote:
> Silences the following checkpatch warning:
> WARNING: space prohibited between function name and open parenthesis '('
>
> Signed-off-by: Janet Liu
> ---
> drivers/staging/lustre/lnet/lnet/lib-md.c | 18 +-
> 1 file
From: Bill Pemberton
Add device ids for additional Neo cards. The ids come from the dgnc
driver.
Signed-off-by: Bill Pemberton
---
drivers/tty/serial/jsm/jsm_driver.c | 38 +
include/linux/pci_ids.h | 8
2 files changed, 42 insertions(
From: Bill Pemberton
The jsm driver (drivers/tty/serial/jsm) already supports the Digi Neo
cards that dgnc (staging) supports. In fact, it appears that jsm was
based on dgnc. The dgnc driver has PCI ids for more cards than jsm,
this patch moves support for all the Neo cards to jsm.
The result
From: Bill Pemberton
The Digi Neo cards are supported by the jsm driver. Remove support
for these cards from dgnc.
Signed-off-by: Bill Pemberton
---
drivers/staging/dgnc/dgnc_driver.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c
b/drive
On Fri, Aug 22, 2014 at 07:57:40PM -0400, Spencer Baugh wrote:
> This patch fixes style errors and warnings reported by
> scripts/checkpatch.pl
Which errors and warnings does it fix?
Please always be specific.
And only do one type of "fix" per patch, you do a few different ones
here, right?
Can
On Sat, Aug 30, 2014 at 02:54:36PM -0400, wf...@worldbroken.com wrote:
> From: Bill Pemberton
>
> Add device ids for additional Neo cards. The ids come from the dgnc
> driver.
>
> Signed-off-by: Bill Pemberton
> ---
> drivers/tty/serial/jsm/jsm_driver.c | 38
> +++
On Thu, Aug 21, 2014 at 06:59:07PM +0530, Hema Prathaban wrote:
> This patch fixes the checkpatch.pl issue
> Error: Required space after " '+' ',' '=' '(' ' if' "
>
> Signed-off-by: Hema Prathaban
> ---
> drivers/staging/lustre/lustre/ptlrpc/client.c | 2 +-
> drivers/staging/lustre/lustr
On Sun, Aug 17, 2014 at 12:47:57PM -0400, Oleg Drokin wrote:
>
> On Aug 17, 2014, at 12:37 PM, Greg Kroah-Hartman wrote:
>
> > On Fri, Aug 15, 2014 at 12:48:14PM -0400, Oleg Drokin wrote:
> >> Just add the entry with some info.
> >>
> >> Signed-off-by: Oleg Drokin
> >> ---
> >> MAINTAINERS | 8
Remove spaces before semicolons to remove checkpatch warnings.
Signed-off-by: Andrew Plummer
---
drivers/staging/emxx_udc/emxx_udc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/emxx_udc/emxx_udc.c
b/drivers/staging/emxx_udc/emxx_udc.c
index b2eaf0
Fix coding style issues, these changes include:
-Add space between "if" and brackets
-Add space after comma in an argument
-Add space between equal sign to separate the variable and the assignment
-Remove unnecessary curly braces around one-line if statements
-Remove unnecessary whitespace between
Remove empty return at end of function.
Signed-off-by: Andrew Plummer
---
drivers/staging/nokia_h4p/nokia_fw.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/nokia_h4p/nokia_fw.c
b/drivers/staging/nokia_h4p/nokia_fw.c
index 14ba219..18953ae 100644
--- a/drivers/staging/nok
From: Julia Lawall
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@
identifier lbl;
identifier rc;
constant c;
@@
- GOTO(lbl,\(rc\|c\));
+ goto lbl;
@@
identifier lbl;
expression rc;
@@
- GOTO(lbl,rc);
+ rc;
+ goto lbl;
//
Signed-off-by: Julia Law
From: Julia Lawall
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
//
@@
identifier lbl;
@@
if (...)
GOTO(lbl,...);
+else
GOTO(lbl,...);
@@
identifier lbl,rc;
constant c;
expression e,e1;
@@
if (
- e
+ !e
)
- GOTO(lbl,\(rc\|c\));
-else GOTO(lbl
This fixes the following sparse warning:
drivers/staging/rtl8188eu/hal/HalHWImg8188E_MAC.c:119:6: warning: symbol
'rtl88e_phy_mac_config' was not declared. Should it be static?
Signed-off-by: Max Vozeler
---
drivers/staging/rtl8188eu/hal/HalHWImg8188E_MAC.c | 1 +
1 file changed, 1 insertion(+)
On Sat, Aug 30, 2014 at 02:52:55PM +0800, Janet Liu wrote:
> @@ -121,7 +123,7 @@ lnet_md_build(lnet_libmd_t *lmd, lnet_md_t *umd, int
> unlink)
>
> lmd->md_length = total_length;
>
> - if ((umd->options & LNET_MD_MAX_SIZE) != 0 && /* max size used
> */
> +
On 30/08/14 06:55, Chase Southwood wrote:
Signed-off-by: Chase Southwood
Cc: Ian Abbott
Cc: H Hartley Sweeten
---
.../comedi/drivers/addi-data/hwdrv_apci1564.c | 23 --
drivers/staging/comedi/drivers/addi_apci_1564.c| 23 ++
2 files changed,
On 30/08/14 02:40, Chase Southwood wrote:
Sparse has many warnings like:
drivers/staging/comedi/drivers/usbduxsigma.c:293:21: warning: cast to
restricted __be32
on lines on which devpriv->in_buf is passed to be32_to_cpu(). This
suggests that this variable should actually be of type __be32.
Si
On 30/08/14 02:40, Chase Southwood wrote:
Sparse has many warnings like:
drivers/staging/comedi/drivers/usbdux.c:366:32: warning: cast to
restricted __le16
on lines on which devpriv->in_buf or devpriv->insn_buf are passed to
le16_to_cpu(). This suggests that both of these variables should actu
On 29/08/14 15:26, Laurentiu Palcu wrote:
> Add support for enumerating the device through ACPI.
>
> Signed-off-by: Laurentiu Palcu
Mostly fine, but I'm unclear on why we have a cast to a char * for name.
Maybe I just haven't had enough coffee this morning :)
Jonathan
> ---
> drivers/staging/ii
On 29/08/14 15:26, Laurentiu Palcu wrote:
> Intersil chips ISL29018, ISL29023 and ISL29035 are very similar. They're
> all ambience light sensors. The ISL29018, however, is also a proximity
> sensor. The registers are similar too:
>
> -+--+--
> AVAILABLE IN | ADDR REG |
On 29/08/14 15:26, Laurentiu Palcu wrote:
> isl29108 was used, instead of isl29018.
>
> Signed-off-by: Laurentiu Palcu
Applied to the togreg branch of iio.git - initially pushed out as testing for
the
autobuilders to play.
Thanks,
Jonathan
> ---
> drivers/staging/iio/light/isl29018.c | 8
On 29-08-2014 21:50:16, Andrew Plummer wrote:
> Remove insignificant spaces before tabs in comments.
>
> Signed-off-by: Andrew Plummer
> ---
> drivers/staging/bcm/LeakyBucket.c | 81
> ---
> 1 file changed, 33 insertions(+), 48 deletions(-)
>
> diff --git a/
Silences the following error:
ERROR: space prohibited before that close parenthesis ')'
Signed-off-by: Janet Liu
---
drivers/staging/lustre/lnet/lnet/lib-md.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lnet/lnet/lib-md.c
b/drivers/staging/lus
86 matches
Mail list logo
