Re: [PATCH 0/9] use c99 initializers in structures

2014-08-23 Thread Josh Triplett
On Sat, Aug 23, 2014 at 01:20:22PM +0200, Julia Lawall wrote: > These patches add labels in the initializations of structure fields (c99 > initializers). The complete semantic patch thta makes this change is shown > below. This rule ignores cases where the initialization is just 0 or NULL, > wher

[PATCH 18/20] staging: rtl8188eu: Rename HalHWImg8188E_BB.c to bb_cfg.c

2014-08-23 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/Makefile |2 +- drivers/staging/rtl8188eu/hal/HalHWImg8188E_BB.c | 715 -- drivers/staging/rtl8188eu/hal/bb_cfg.c | 715 ++ 3 files changed, 716 insertions(+), 716 del

[PATCH 17/20] staging: rtl8188eu: Rename rtl8188e_phycfg.c to phy.c

2014-08-23 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/Makefile |2 +- drivers/staging/rtl8188eu/hal/phy.c | 381 +++ drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 381 --- 3 files changed, 382 insertions(+), 382 dele

[PATCH 19/20] staging: rtl8188eu: Rename HalHWImg8188E_RF.c to rf_cfg.c

2014-08-23 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/Makefile |2 +- drivers/staging/rtl8188eu/hal/HalHWImg8188E_RF.c | 320 -- drivers/staging/rtl8188eu/hal/rf_cfg.c | 320 ++ 3 files changed, 321 insertions(+), 321 del

[PATCH 20/20] staging: rtl8188eu: Rename HalHWImg8188E_MAC.c to mac_cfg.c

2014-08-23 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/Makefile|2 +- drivers/staging/rtl8188eu/hal/HalHWImg8188E_MAC.c | 133 - drivers/staging/rtl8188eu/hal/mac_cfg.c | 133 + 3 files changed, 134 insertions(+), 134 de

[PATCH 16/20] staging: rtl8188eu: Rework function PHY_SwChnl8188E()

2014-08-23 Thread navin patidar
Rename CamelCase variables and function name. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |2 +- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c| 27 +--- drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h |2 -- drivers/stagi

[PATCH 13/20] staging: rtl8188eu: Rework function _PHY_SwChnl8192C()

2014-08-23 Thread navin patidar
Rename CamelCase variables and function name. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188

[PATCH 05/20] staging: rtl8188eu: Rework function PHY_SetBBReg()

2014-08-23 Thread navin patidar
Rename CamelCase variables and function name. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/HalHWImg8188E_BB.c |6 +- drivers/staging/rtl8188eu/hal/HalHWImg8188E_RF.c | 16 +- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 176 ++-- drivers/stagi

[PATCH 15/20] staging: rtl8188eu: Rework function PHY_SetBWMode8188E()

2014-08-23 Thread navin patidar
Rename CamelCase variables and function name. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |2 +- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c| 33 ++-- drivers/staging/rtl8188eu/include/Hal8188EPhyCfg.h |4 --- drivers/stag

[PATCH 12/20] staging: rtl8188eu: Rework function _PHY_SetBWMode92C()

2014-08-23 Thread navin patidar
Rename CamelCase variables and function name. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 98 +-- 1 file changed, 37 insertions(+), 61 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl818

[PATCH 11/20] staging: rtl8188eu: Rework function phy_PowerIndexCheck88E()

2014-08-23 Thread navin patidar
Rename CamelCase variables and function name. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188eu/hal/

[PATCH 08/20] staging: rtl8188eu: Rework function PHY_QueryRFReg()

2014-08-23 Thread navin patidar
Rename CamelCase variables and function name. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 10 +++ drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |4 +-- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c| 31 +--- drivers

[PATCH 10/20] staging: rtl8188eu: Rework function getTxPowerIndex88E()

2014-08-23 Thread navin patidar
Rename CamelCase variables and function name. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 105 ++- 1 file changed, 45 insertions(+), 60 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl818

[PATCH 14/20] staging: rtl8188eu: Rework function PHY_SetTxPowerLevel8188E()

2014-08-23 Thread navin patidar
Rename CamelCase variables and function name. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c |2 +- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c| 44 ++-- drivers/staging/rtl8188eu/hal/usb_halinit.c|2 +- drivers/stagi

[PATCH 09/20] staging: rtl8188eu: Rework function rtl8188e_PHY_SetRFReg()

2014-08-23 Thread navin patidar
Rename CamelCase variables and function name. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/HalHWImg8188E_RF.c |2 +- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 32 +++ drivers/staging/rtl8188eu/hal/odm.c|2 +- drivers/staging/rt

[PATCH 06/20] staging: rtl8188eu: Rework function phy_RFSerialRead()

2014-08-23 Thread navin patidar
Rename CamelCase variables and function name. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 99 --- 1 file changed, 34 insertions(+), 65 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl818

[PATCH 07/20] staging: rtl8188eu: Rework function phy_RFSerialWrite()

2014-08-23 Thread navin patidar
Rename CamelCase variables and function name. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 85 +++ 1 file changed, 11 insertions(+), 74 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl818

[PATCH 02/20] staging: rtl8188eu: Remove unused wrapper function rtw_hal_read_bbreg()

2014-08-23 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/hal_intf.c |9 - drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |1 - drivers/staging/rtl8188eu/include/hal_intf.h |4 3 files changed, 14 deletions(-) diff --git a/drivers/staging/rtl8188eu

[PATCH 01/20] staging: rtl8188eu: Rework function phy_CalculateBitShift()

2014-08-23 Thread navin patidar
Rename CamelCase variables and function name. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c | 42 --- 1 file changed, 6 insertions(+), 36 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_phycfg.c b/drivers/staging/rtl8188

[PATCH 04/20] staging: rtl8188eu: Remove unused wrapper function rtw_hal_write_bbreg()

2014-08-23 Thread navin patidar
Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/hal_intf.c |7 --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |1 - drivers/staging/rtl8188eu/include/hal_intf.h |4 3 files changed, 12 deletions(-) diff --git a/drivers/staging/rtl8188eu/h

[PATCH 03/20] staging: rtl8188eu: Rework function PHY_QueryBBReg()

2014-08-23 Thread navin patidar
Rename CamelCase variables and function name. Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/HalHWImg8188E_RF.c |8 +-- drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c | 69 ++-- drivers/staging/rtl8188eu/hal/odm.c| 31 - drive

[PATCH 5/9] lustre: obdclass: use c99 initializers in structures

2014-08-23 Thread Julia Lawall
From: Julia Lawall Use c99 initializers for structures. A simplified version of the semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @decl@ identifier i1,fld; type T; field list[n] fs; @@ struct i1 { fs T fld; ...}; @bad@ identifier decl.i1,i2; express

[PATCH 0/9] use c99 initializers in structures

2014-08-23 Thread Julia Lawall
These patches add labels in the initializations of structure fields (c99 initializers). The complete semantic patch thta makes this change is shown below. This rule ignores cases where the initialization is just 0 or NULL, where some of the fields already use labels, and where there are nested st