On 2014-08-13 at 21:11:19 +0200, Jeshwanth Kumar N K
wrote:
> On Wed, Aug 13, 2014 at 12:06 PM, Tobias Klauser
> wrote:
>
> > On 2014-08-12 at 20:54:48 +0200, Jeshwanth Kumar N K <
> > jeshkumar...@gmail.com> wrote:
> > > removed goto label, and directly returning 0 not through goto.
> > >
> >
This patch fixes the 'quoted string split across lines' checkpatch.pl
warning in prism2fw.c.
Signed-off-by: Artemiy Volkov
---
drivers/staging/wlan-ng/prism2fw.c | 60 --
1 file changed, 25 insertions(+), 35 deletions(-)
diff --git a/drivers/staging/wlan-ng/p
> -Original Message-
> From: Dmitry Torokhov
> > How about this:
> > in libps2.c let's add and export a function pointer
> > i8042_lock_chip_if_port_owner: it is used to replace the current
> > if (i8042_check_port_owner(ps2dev->serio))
> > i8042_lock_chip();
> > The functi
On Wed, 2014-08-13 at 17:09 +0200, Ulf Hansson wrote:
> On 11 August 2014 10:32, wrote:
> > From: Roger Tseng
> >
> > Current code erroneously fill the last byte of R2 response with an undefined
> > value. In addition, it is impossible to obtain the real values since the
> > controller actually
> -Original Message-
> From: Dan Williams
> > > e.g., on a bare metal host with Ubuntu 14.04, when I plug the RJ45 cable
> > > out of the network card and then plug the cable back into the network card
> > > quickly -- in ~3 seconds, networkd doesn't trigger DHCP renew request: in
> > > /va
Signed-off-by: Son Le
---
drivers/staging/nokia_h4p/nokia_fw.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/nokia_h4p/nokia_fw.c
b/drivers/staging/nokia_h4p/nokia_fw.c
index 14ba219..18953ae 100644
--- a/drivers/staging/nokia_h4p/nokia_fw.c
+++ b/drivers/staging/nokia
Signed-off-by: Son Le
---
drivers/staging/nokia_h4p/nokia_core.c |2 +-
drivers/staging/nokia_h4p/nokia_fw-csr.c |2 +-
drivers/staging/nokia_h4p/nokia_uart.c |2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/nokia_h4p/nokia_core.c
b/drivers/s
Summary follows:
Son Le (2):
staging/nokia_h4p: replace short sleep using msleep with usleep_range
staging/nokia_h4p: remove unwanted returns
drivers/staging/nokia_h4p/nokia_core.c |2 +-
drivers/staging/nokia_h4p/nokia_fw-csr.c |2 +-
drivers/staging/nokia_h4p/nokia_fw.c |
On Wed, Aug 13, 2014 at 08:53:59PM -0400, Ramesh Basukala wrote:
> From: rbasukala
This doesn't match up with your signed-off-by: line, or your name up
there in the mail header. Please fix this up and resend.
thanks,
greg k-h
___
devel mailing list
d
From: rbasukala
This is a patch to the vendorspecificextn.c that fixes coding style
warning message line over 80 characters found by checkpatch.pl script.
I am submitting this patch as required by Eudyptula Challenge.
Signed-off-by: Ramesh Basukala
---
drivers/staging/bcm/vendorspecificextn.c
On Wed, Aug 13, 2014 at 11:36:59AM -0400, rbasukala wrote:
> This a a patch to the vendorspecificextn.c that fixes coding style warning
> found by checkpatch.pl script. I am submitting this patch as required by
> Eudyptula Challenge.
That's a very long line for a changelog entry, please wrap the
On Thu, Aug 14, 2014 at 12:43 AM, Jeshwanth Kumar N K
wrote:
> On Wed, Aug 13, 2014 at 12:06 PM, Tobias Klauser wrote:
>> On 2014-08-12 at 20:54:48 +0200, Jeshwanth Kumar N K
>> wrote:
>>> removed goto label, and directly returning 0 not through goto.
>>>
>>> Signed-off-by: Jeshwanth Kumar N K
On Wed, Aug 13, 2014 at 12:06 PM, Tobias Klauser wrote:
> On 2014-08-12 at 20:54:48 +0200, Jeshwanth Kumar N K
> wrote:
>> removed goto label, and directly returning 0 not through goto.
>>
>> Signed-off-by: Jeshwanth Kumar N K
>> ---
>> drivers/staging/wlan-ng/prism2mgmt.c | 14 --
This patch fixes the following checkpatch.pl issue in client.c:
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Hema Prathaban
---
drivers/staging/lustre/lustre/ptlrpc/client.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/c
From: Holger Paradies
The stick is not recognized.
This dongle uses r8188eu but usb-id is missing.
3.16.0
Signed-off-by: Holger Paradies
Signed-off-by: Larry Finger
---
drivers/staging/rtl8188eu/os_dep/usb_intf.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/rtl8188eu/os
This patch fixes the following checkpatch.pl issue in client.c:
ERROR: "foo * bar" should be "foo *bar"
Signed-off-by: Hema Prathaban
---
drivers/staging/lustre/lustre/ptlrpc/client.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ptlrpc/c
When the buffer is too small for a packet from VMBus, a bigger buffer will be
allocated in netvsc_channel_cb() and retry reading the packet from VMBus.
Increasing this buffer size will reduce the retry overhead.
Signed-off-by: Haiyang Zhang
Reviewed-by: Dexuan Cui
---
drivers/net/hyperv/hyperv_
On Thu, Aug 14, 2014 at 02:02:48AM +0900, Seunghun Lee wrote:
> Memory allocated by kstrdup should be freed.
>
> CC: Brian Swetland
> Signed-off-by: Seunghun Lee
Looks good.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
Memory allocated by kstrdup should be freed.
CC: Brian Swetland
Signed-off-by: Seunghun Lee
---
drivers/staging/android/logger.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c
index 9b47e66..0bf0d24
On Wed, Aug 13, 2014 at 05:24:35AM +, Dexuan Cui wrote:
> > -Original Message-
> > From: Dmitry Torokhov
> > Sent: Wednesday, August 13, 2014 1:55 AM
> > > > > To decouple the dependency between the hyperv-keyboard and i8042
> > > > > modules, I suppose we probably have to re-implement
This a a patch to the vendorspecificextn.c that fixes coding style warning
found by checkpatch.pl script. I am submitting this patch as required by
Eudyptula Challenge.
Signed-off-by: Ramesh Basukala
---
drivers/staging/bcm/vendorspecificextn.c | 19 +++
1 files changed, 11 i
On 11 August 2014 10:32, wrote:
> From: Roger Tseng
>
> Current code erroneously fill the last byte of R2 response with an undefined
> value. In addition, it is impossible to obtain the real values since the
> controller actually 'offloads' the last byte(CRC7, end bit) while receiving R2
> respo
Fixes the following checkpatch warning:
WARNING: quoted string split across lines
Signed-off-by: Srikrishan Malik
---
Changes in v3: Removed leading space from debug message.
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 9 +++
drivers/staging/lustre/lustre/mdc/mdc_reint.c | 3 +--
This patch fix checkpatch.pl warning
Tested by compilation only.
Signed-off-by: Phong Tran
---
drivers/staging/android/ion/ion.c | 1 -
drivers/staging/android/ion/ion_carveout_heap.c | 1 -
drivers/staging/android/ion/ion_chunk_heap.c| 1 -
drivers/staging/android/ion/ion_dumm
This patch fix checkpatch.pl warning
Tested by compilation only.
Signed-off-by: Phong Tran
---
drivers/staging/android/ion/ion_dummy_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_dummy_driver.c
b/drivers/staging/android/ion/ion_dumm
This patch fix checkpatch.pl warning
Tested by compilation only.
Signed-off-by: Phong Tran
---
drivers/staging/android/ion/ion.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index 2703609..cad76ae 100644
--- a/drivers/
On Wed, 2014-08-13 at 15:15 +0200, Tom Gundersen wrote:
> On Tue, Aug 12, 2014 at 10:29 AM, Dexuan Cui wrote:
> >> From: Tom Gundersen
> >> > Unluckily this logic doesn't work because the user-space daemons
> >> > like ifplugd, usually don't renew the DHCP immediately as long as they
> >> > receiv
On Tue, Aug 12, 2014 at 10:29 AM, Dexuan Cui wrote:
>> From: Tom Gundersen
>> > Unluckily this logic doesn't work because the user-space daemons
>> > like ifplugd, usually don't renew the DHCP immediately as long as they
>> > receive a link-down message: they usually wait for some seconds and if
>
On Wed, Aug 13, 2014 at 08:09:38PM +0700, Phong Tran wrote:
> This patch fix checkpatch.pl warning
> - Replace kzalloc() by kcalloc()
> Tested by compilation.
>
The patches look ok, but can you resend with better subject lines?
kzalloc() -> kcalloc().
add blank.
remove returns.
Something like th
This patch fix checkpatch.pl warning
- Remove the return of void function
Tested by compilation.
Signed-off-by: Phong Tran
---
drivers/staging/android/ion/ion.c | 1 -
drivers/staging/android/ion/ion_carveout_heap.c | 1 -
drivers/staging/android/ion/ion_chunk_heap.c| 1 -
driv
This patch fix checkpatch.pl warning
- Replace kzalloc() by kcalloc()
Tested by compilation.
Signed-off-by: Phong Tran
---
drivers/staging/android/ion/ion_dummy_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_dummy_driver.c
b/drivers/
This patch fix checkpatch.pl warning
- Add a new line after decleration
Tested by compilation.
Signed-off-by: Phong Tran
---
drivers/staging/android/ion/ion.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
index 2703609.
Just fold all these "- return;" patches into one patch.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
The subject will just get changed to "Coding style".
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On 2014-08-12 19:41, H Hartley Sweeten wrote:
The drivers that use this module with memory mapped io all have the
ioremap'ed base address stored in the comedi_device 'mmio' member.
Introduce a default (*io) function that does 8-bit memory mapped io.
Modify subdev_8255_init() so that it takes a
On 2014-08-12 19:41, H Hartley Sweeten wrote:
The async command support in this module is incomplete and nothing
has ever used it. Just remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/8255.c | 95 --
On Tue, Aug 12, 2014 at 09:28:13AM +0900, DaeSeok Youn wrote:
> Hi, Dan
>
> 2014-08-11 19:56 GMT+09:00 Dan Carpenter :
> > On Sat, Aug 09, 2014 at 02:36:44PM +0900, Daeseok Youn wrote:
> >> dgap_major_serial_registered and dgap_major_transparent_print_registered
> >> could be checked whether a boa
On 2014-08-12 19:17, H Hartley Sweeten wrote:
This exported function just does a free_irq() to release the interrupt
handler for the legacy and PCI dio200 drivers.
The legacy driver also calls comedi_legacy_detach() which would also
do the free_irq(). For that driver the just use comedi_legacy_d
On Tue, Aug 12, 2014 at 03:19:12PM +0800, Roger wrote:
> I can remove the unused rsp_len in this function. But I'm afraid the
> loop is still required. The destination cmd->resp is cpu-endian, but
> the raw response from SD card in the buffer (pointed by ptr) is
> big-endian.
Oh, yes. Of course.
39 matches
Mail list logo
