On Mon, 11 Aug 2014, Greg KH wrote:
On Sun, Aug 10, 2014 at 10:56:38PM +1000, Artemiy Volkov wrote:
On Sat, 9 Aug 2014, Greg KH wrote:
On Thu, Aug 07, 2014 at 01:21:25PM +1000, Artemiy Volkov wrote:
This patch fixes the checkpatch.pl 'Missing a blank line after declarations'
warning in
dgap_major_serial_registered and dgap_major_transparent_print_registered
could be checked whether a board is initialized.
But it doesn't need to check that variables becasue dgap_board
as global is managed for boards which are initialized completely.
So when it called dgap_cleanup_tty() function, v
This commit fixes the following checkpatch warnings:
WARNING: externs should be avoided in .c files
#80: FILE: drivers/staging/dgnc/dgnc_driver.c:80:
+intdgnc_init_module(void);
#81: FILE: drivers/staging/dgnc/dgnc_driver.c:81:
+void dgnc_cleanup_modul
On Tue, Aug 12, 2014 at 05:51:28AM +, Dexuan Cui wrote:
> > -Original Message-
> > From: Greg KH [mailto:gre...@linuxfoundation.org]
> > > Decoupling the dependency between hyperv_keyboard and i8042 needs
> > > non-trivial efforts and is hence a long term goal.
> > >
> > > For now, let'
> -Original Message-
> From: Greg KH [mailto:gre...@linuxfoundation.org]
> > Decoupling the dependency between hyperv_keyboard and i8042 needs
> > non-trivial efforts and is hence a long term goal.
> >
> > For now, let's make the dependency explicit so people can beware of this.
>
> You did
On Mon, Aug 11, 2014 at 08:30:40PM -0700, Dexuan Cui wrote:
> hyperv_keyboard invokes serio_interrupt(), which needs a valid serio driver
> like atkbd.c.
> atkbd.c depends on libps2.c because it invokes ps2_command().
> libps2.c depends on i8042.c because it invokes i8042_check_port_owner().
> As a
El 11/08/14 a las 17:32, Greg Kroah-Hartman escibió:
> On Mon, Aug 11, 2014 at 03:15:54PM -0700, Jeremiah Mahler wrote:
>> A sparse warning is generated about 'ieee80211_debug_init' and
>> 'ieee80211_debug_exit' not being declared.
>>
>> drivers/staging/rtl8192u/ieee80211/ieee80211_module.c:275:1
On Mon, Aug 11, 2014 at 09:44:47PM -0400, Oleg Drokin wrote:
>
> On Aug 9, 2014, at 11:47 AM, Greg Kroah-Hartman wrote:
>
> > On Sat, Aug 09, 2014 at 10:34:36AM -0400, Oleg Drokin wrote:
> >>
> >>> Because maybe these stats preceed the introduction of perf and other
> >>> tracing/debug tools? I
hyperv_keyboard invokes serio_interrupt(), which needs a valid serio driver
like atkbd.c.
atkbd.c depends on libps2.c because it invokes ps2_command().
libps2.c depends on i8042.c because it invokes i8042_check_port_owner().
As a result, hyperv_keyboard actually depends on i8042.c.
For a Generatio
Greg reports that with one of the patches in his queue
there's now an unused variable warning in lnet_parse_ip2nets
for ipaddrs variable.
Apparently the warning is a false positive as in all cases where
lnet_ipaddr_enumerate can return without setting ipaddrs to something
a negative return value is
On Aug 11, 2014, at 2:27 PM, Srikrishan Malik wrote:
> Fixes the following checkpatch warning:
>
> WARNING: quoted string split across lines
> diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request.c
> b/drivers/staging/lustre/lustre/mdc/mdc_request.c
> index 57d903156917..6c691a4763b5 100
Starting with commit 1496e5961113 ("staging: comedi: addi_apci_1564: use
addi_watchdog module to init watchdog subdevice"), this driver uses the
addi_watchdog module to provide support for the watchdog subdevice. Any
remaining watchdog code in-driver can and should be removed.
This will also make
This commit performs a final tidying of the register map defines, bringing
them to a state that is ready for merging into addi_apci_1564.c when the
time comes. Actions performed include:
*Removes the APCI1564_ADDRESS_RANGE macro, which is no longer needed/used.
*Renames the APCI1564_DIGITAL_OP_{V
The DO config function served the purpose of configuring the diagnostic
interrupts for the board. As the driver currently does not support
diagnostic interrupts, the digital output subdevice does not need an
insn_config operation and this function can be safely removed.
Signed-off-by: Chase South
On Aug 11, 2014, at 9:58 PM, Oleg Drokin wrote:
>
> On Aug 10, 2014, at 12:34 AM, Greg KH wrote:
>> Very odd, with this patch applied, I now get a build warning:
>>
>> drivers/staging/lustre/lnet/lnet/config.c: In function ‘lnet_parse_ip2nets’:
>> drivers/staging/lustre/lnet/lnet/config.c:1193:
This patchset removes an uncorrect and unneeded insn_config operation,
strips out remaining in-driver watchdog subdevice code, and cleans up the
driver's register map defines.
Chase Southwood (3):
staging: comedi: addi_apci_1564: remove apci1564_do_config
staging: comedi: addi_apci_1564: Remov
On Aug 10, 2014, at 12:34 AM, Greg KH wrote:
> Very odd, with this patch applied, I now get a build warning:
>
> drivers/staging/lustre/lnet/lnet/config.c: In function ‘lnet_parse_ip2nets’:
> drivers/staging/lustre/lnet/lnet/config.c:1193:2: warning: ‘ipaddrs’ may be
> used uninitialized in this
A sparse warning is generated about 'ieee80211_debug_init' and
'ieee80211_debug_exit' not being declared.
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c:275:12: warning:
symbol 'ieee80211_debug_init' was not declared. Should it be static?
drivers/staging/rtl8192u/ieee80211/ieee80211_m
On Aug 9, 2014, at 11:47 AM, Greg Kroah-Hartman wrote:
> On Sat, Aug 09, 2014 at 10:34:36AM -0400, Oleg Drokin wrote:
>>
>>> Because maybe these stats preceed the introduction of perf and other
>>> tracing/debug tools? I don't know, it's really low down on the list of
>>> reasons why lustre can
Hi, Dan
2014-08-11 19:56 GMT+09:00 Dan Carpenter :
> On Sat, Aug 09, 2014 at 02:36:44PM +0900, Daeseok Youn wrote:
>> dgap_major_serial_registered and dgap_major_transparent_print_registered
>> could be checked whether a board is initialized.
>> But it doesn't need to check that variables becasue
On Mon, Aug 11, 2014 at 7:12 PM, Nicholas Krause wrote:
> I am fixing the bug entry , https://bugzilla.kernel.org/show_bug.cgi?id=60461.
> This entry states that we are not checking the skb allocated in
> fw_download_code
> for NULL and after checking it ,I fixed it to check for the NULL value be
I am fixing the bug entry , https://bugzilla.kernel.org/show_bug.cgi?id=60461.
This entry states that we are not checking the skb allocated in fw_download_code
for NULL and after checking it ,I fixed it to check for the NULL value before
returning false and exiting fw_download_code cleanly. In addi
On Mon, Aug 11, 2014 at 03:15:54PM -0700, Jeremiah Mahler wrote:
> A sparse warning is generated about 'ieee80211_debug_init' and
> 'ieee80211_debug_exit' not being declared.
>
> drivers/staging/rtl8192u/ieee80211/ieee80211_module.c:275:12: warning:
> symbol 'ieee80211_debug_init' was not decl
On Mon Aug 11 14, Nicholas Krause wrote:
> I am fixing the bug entry , https://bugzilla.kernel.org/show_bug.cgi?id=60461.
> This entry states that we are not checking the skb allocated in
> fw_download_code
> and after checking I fixed it to check for the NULL value before using the
> allocate
>
A sparse warning is generated about 'ieee80211_debug_init' and
'ieee80211_debug_exit' not being declared.
drivers/staging/rtl8192u/ieee80211/ieee80211_module.c:275:12: warning:
symbol 'ieee80211_debug_init' was not declared. Should it be static?
drivers/staging/rtl8192u/ieee80211/ieee80211_m
On Mon, Aug 11, 2014 at 5:48 PM, Jerry Snitselaar wrote:
> On Mon Aug 11 14, Nicholas Krause wrote:
>> I am fixing the bug entry ,
>> https://bugzilla.kernel.org/show_bug.cgi?id=60461.
>> This entry states that we are not checking the skb allocated in
>> fw_download_code
>> and after checking I
2014-08-11 12:58 GMT+02:00 Dan Carpenter :
> On Sun, Aug 10, 2014 at 01:49:12AM +0200, Rickard Strandqvist wrote:
>> Added a guaranteed null-terminate after call to strncpy.
>
> No. This is a problem in the static checker and not in the code.
>
> Look at the start of the function. This stuff shou
I am fixing the bug entry , https://bugzilla.kernel.org/show_bug.cgi?id=60461.
This entry states that we are not checking the skb allocated in fw_download_code
and after checking I fixed it to check for the NULL value before using the
allocate
skb.
Signed-off-by: Nicholas Krause
---
drivers/sta
Thanks Randy for checking this I am going to resend as a v2 patch.
Regards Nick
On Mon, Aug 11, 2014 at 3:40 PM, Randy Dunlap wrote:
> On 08/11/14 12:18, Nick Krause wrote:
>>
>> Thanks Randy for your help otherwise is my patch good? Please let me
>> known if there our any other issues.
>> Regard
On 08/11/14 12:18, Nick Krause wrote:
>
> Thanks Randy for your help otherwise is my patch good? Please let me
> known if there our any other issues.
> Regards Nick
I didn't notice any other issues with it.
--
~Randy
___
devel mailing list
de...@linux
On Mon, Aug 11, 2014 at 3:04 PM, Randy Dunlap wrote:
> On 08/11/14 11:55, Nick Krause wrote:
>> On Mon, Aug 11, 2014 at 2:45 PM, Randy Dunlap wrote:
>>> On 08/11/14 11:26, Nick Krause wrote:
On Mon, Aug 11, 2014 at 2:07 PM, Randy Dunlap
wrote:
> On 08/11/14 11:04, Nick Krause wrot
On 08/11/14 11:55, Nick Krause wrote:
> On Mon, Aug 11, 2014 at 2:45 PM, Randy Dunlap wrote:
>> On 08/11/14 11:26, Nick Krause wrote:
>>> On Mon, Aug 11, 2014 at 2:07 PM, Randy Dunlap wrote:
On 08/11/14 11:04, Nick Krause wrote:
> On Mon, Aug 11, 2014 at 2:02 PM, Nicholas Krause
>
On Mon, Aug 11, 2014 at 2:45 PM, Randy Dunlap wrote:
> On 08/11/14 11:26, Nick Krause wrote:
>> On Mon, Aug 11, 2014 at 2:07 PM, Randy Dunlap wrote:
>>> On 08/11/14 11:04, Nick Krause wrote:
On Mon, Aug 11, 2014 at 2:02 PM, Nicholas Krause
wrote:
> I am fixing the bug entry ,
>>>
On Mon, Aug 11, 2014 at 11:26:32PM +0530, Avinash kumar wrote:
> corrected C99 style comment format related error
>
> Signed-off-by: Avinash Kumar
> ---
> drivers/staging/vt6655/wpactl.h |4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/vt6655/wpact
On 08/11/14 11:26, Nick Krause wrote:
> On Mon, Aug 11, 2014 at 2:07 PM, Randy Dunlap wrote:
>> On 08/11/14 11:04, Nick Krause wrote:
>>> On Mon, Aug 11, 2014 at 2:02 PM, Nicholas Krause
>>> wrote:
I am fixing the bug entry ,
https://bugzilla.kernel.org/show_bug.cgi?id=60461.
Thi
On 08/11, Greg KH wrote:
> On Sun, Aug 10, 2014 at 09:19:15PM +0200, Konrad Zapalowicz wrote:
> > On 08/10, Greg KH wrote:
> > > On Sat, Aug 09, 2014 at 08:16:37PM +0200, Konrad Zapalowicz wrote:
> > > > This commit binds global variables of dgnc driver in a structure so
> > > > that it is logicall
On Mon, Aug 11, 2014 at 05:09:49PM +, Hartley Sweeten wrote:
> On Saturday, August 09, 2014 9:15 PM, Greg KH wrote:
> > On Fri, Aug 01, 2014 at 01:07:05PM -0700, H Hartley Sweeten wrote:
> >> For aesthetics, add some whitespace to the declaration.
> >>
> >> Signed-off-by: H Hartley Sweeten
>
Changes:
- move const union vars to the top
- move rc to bottom
- do not initialize req
- set lvb_type to enum member instead of 0
- change __u64 to u64
- fix inconsistant columnization
Signed-off-by: Srikrishan Malik
---
These changes were suggested by Dan Carpenter .
drivers/staging/lustre/l
Fix the following checkpatch error:
ERROR: else should follow close brace '}'
Signed-off-by: Srikrishan Malik
---
drivers/staging/lustre/lustre/mdc/mdc_request.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request.c
b/drivers/stag
Fixes the following checkpatch error:
ERROR: that open brace { should be on the previous line
Signed-off-by: Srikrishan Malik
---
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 18 +++---
drivers/staging/lustre/lustre/mdc/mdc_reint.c | 3 +--
drivers/staging/lustre/lustre/mdc/
Fixes the following checkpatch warning:
WARNING: line over 80 characters
Signed-off-by: Srikrishan Malik
---
drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 6 --
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 9 ++---
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 7 ---
d
Fixes the following checkpatch errors:
ERROR: space required after that ',' (ctx:VxV)
ERROR: space required after that close brace '}'
Signed-off-by: Srikrishan Malik
---
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 25 +
drivers/staging/lustre/lustre/mdc/mdc_locks.
Fixes the following checkpatch error:
ERROR: "(foo*)" should be "(foo *)"
Signed-off-by: Srikrishan Malik
---
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/mdc/mdc_locks.c
b/drivers/staging/lustre
Fix the following checkpatch error:
ERROR: return is not a function, parentheses are not required
Signed-off-by: Srikrishan Malik
---
drivers/staging/lustre/lustre/mdc/mdc_request.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/mdc/mdc_request
Fixes the following checkpatch error:
ERROR: do not use C99 // comments
Signed-off-by: Srikrishan Malik
---
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/mdc/mdc_lib.c
b/drivers/staging/lustre
Fixes the following checkpatch warning:
WARNING: Missing a blank line after declarations
Signed-off-by: Srikrishan Malik
---
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 1 +
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 3 +++
drivers/staging/lustre/lustre/mdc/mdc_request.c | 5 +
Fixes the following checkpatch warning:
WARNING: quoted string split across lines
Signed-off-by: Srikrishan Malik
---
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 9 +++
drivers/staging/lustre/lustre/mdc/mdc_reint.c | 3 +--
drivers/staging/lustre/lustre/mdc/mdc_request.c | 36
Fixes the following checkpatch error:
ERROR: open brace '{' following function declarations go on the next line
Signed-off-by: Srikrishan Malik
---
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 3 ++-
drivers/staging/lustre/lustre/mdc/mdc_request.c | 3 ++-
2 files changed, 4 insertions(+),
Fixes the following checkpatch warning:
WARNING: please, no spaces at the start of a line
Signed-off-by: Srikrishan Malik
---
drivers/staging/lustre/lustre/mdc/lproc_mdc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/mdc/lproc_mdc.c
b/dr
Fixes following checkpatch warning:
WARNING: space prohibited between function name and open parenthesis '('
Signed-off-by: Srikrishan Malik
---
drivers/staging/lustre/lustre/mdc/mdc_internal.h | 2 +-
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 4 ++--
drivers/staging/lustre/lustre/md
On Mon, Aug 11, 2014 at 2:07 PM, Randy Dunlap wrote:
> On 08/11/14 11:04, Nick Krause wrote:
>> On Mon, Aug 11, 2014 at 2:02 PM, Nicholas Krause wrote:
>>> I am fixing the bug entry ,
>>> https://bugzilla.kernel.org/show_bug.cgi?id=60461.
>>> This entry states that we are not checking the skb al
On 08/11/14 11:04, Nick Krause wrote:
> On Mon, Aug 11, 2014 at 2:02 PM, Nicholas Krause wrote:
>> I am fixing the bug entry ,
>> https://bugzilla.kernel.org/show_bug.cgi?id=60461.
>> This entry states that we are not checking the skb allocated in
>> fw_download_code
>> and after checking I fixe
On Mon, Aug 11, 2014 at 2:02 PM, Nicholas Krause wrote:
> I am fixing the bug entry , https://bugzilla.kernel.org/show_bug.cgi?id=60461.
> This entry states that we are not checking the skb allocated in
> fw_download_code
> and after checking I fixed it to check for the NULL value before using th
I am fixing the bug entry , https://bugzilla.kernel.org/show_bug.cgi?id=60461.
This entry states that we are not checking the skb allocated in fw_download_code
and after checking I fixed it to check for the NULL value before using the
allocate
skb.
Signed-off-by: Nicholas Krause
---
drivers/sta
corrected C99 style comment format related error
Signed-off-by: Avinash Kumar
---
drivers/staging/vt6655/wpactl.h |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/vt6655/wpactl.h b/drivers/staging/vt6655/wpactl.h
index f7638ba..2ff42c5 100644
--- a/drive
On Saturday, August 09, 2014 9:15 PM, Greg KH wrote:
> On Fri, Aug 01, 2014 at 01:07:05PM -0700, H Hartley Sweeten wrote:
>> For aesthetics, add some whitespace to the declaration.
>>
>> Signed-off-by: H Hartley Sweeten
>> Reviewed-by: Ian Abbott
>> ---
>> drivers/staging/comedi/drivers/amplc_d
Fixes up warning, break is not useful after a goto or return statement
Signed-off-by: Jeshwanth Kumar N K
---
drivers/staging/wlan-ng/prism2mgmt.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/wlan-ng/prism2mgmt.c
b/drivers/staging/wlan-ng/prism2mgmt.c
index e6a82d3..583
On Mon, 11 Aug 2014, Joe Perches wrote:
> On Mon, 2014-08-11 at 16:27 +0530, Srikrishan Malik wrote:
> > On Thu, Aug 07, 2014 at 09:35:43AM -0700, Joe Perches wrote:
> > > On Thu, 2014-08-07 at 19:01 +0300, Dan Carpenter wrote:
> > > > On Thu, Aug 07, 2014 at 09:01:36PM +0530, Srikrishan Malik w
On Mon, Aug 11, 2014 at 04:32:16PM +0800, rogera...@realtek.com wrote:
> From: Roger Tseng
>
> Current code erroneously fill the last byte of R2 response with an undefined
> value. In addition, it is impossible to obtain the real values since the
> controller actually 'offloads' the last byte(CRC
On Mon, Aug 11, 2014 at 04:27:06PM +0530, Srikrishan Malik wrote:
> This patch set is aimed at removing checkpatch issues from files in
> lustre/lustre/mdc.
>
> Is it ok if I just fix those in this set and post another patch set
> to take care of other issues identified in review?
checkpatch fixe
On Mon, 2014-08-11 at 16:27 +0530, Srikrishan Malik wrote:
> On Thu, Aug 07, 2014 at 09:35:43AM -0700, Joe Perches wrote:
> > On Thu, 2014-08-07 at 19:01 +0300, Dan Carpenter wrote:
> > > On Thu, Aug 07, 2014 at 09:01:36PM +0530, Srikrishan Malik wrote:
> > > > On Wed, Aug 06, 2014 at 11:18:13PM +0
On Sun, Aug 10, 2014 at 01:49:12AM +0200, Rickard Strandqvist wrote:
> Added a guaranteed null-terminate after call to strncpy.
No. This is a problem in the static checker and not in the code.
Look at the start of the function. This stuff should be obvious for the
static checker.
regards,
dan
On Thu, Aug 07, 2014 at 09:35:43AM -0700, Joe Perches wrote:
> On Thu, 2014-08-07 at 19:01 +0300, Dan Carpenter wrote:
> > On Thu, Aug 07, 2014 at 09:01:36PM +0530, Srikrishan Malik wrote:
> > > On Wed, Aug 06, 2014 at 11:18:13PM +0300, Dan Carpenter wrote:
> > > > That looks silly before and after
On Sat, Aug 09, 2014 at 02:36:44PM +0900, Daeseok Youn wrote:
> dgap_major_serial_registered and dgap_major_transparent_print_registered
> could be checked whether a board is initialized.
> But it doesn't need to check that variables becasue dgap module
> isn't calling the dgap_cleanup_tty() withou
On Sun, Aug 10, 2014 at 01:48:00AM +0200, Rickard Strandqvist wrote:
> Added a guaranteed null-terminate after call to strncpy.
>
No. This one isn't needed. The static checker *should* know this so it
is a problem with the static checker and not with the code.
Don't change code, just because t
On Mon, Aug 11, 2014 at 5:23 AM, Dexuan Cui wrote:
>> -Original Message-
>> From: Greg KH [mailto:gre...@linuxfoundation.org]
>> > > >
>> > > > IMO the most feasible and need-the-least-change solution may be:
>> > > > the hyperv network VSC driver passes the event
>> > > > RNDIS_STATUS_NET
On Mon, Aug 11, 2014 at 02:06:14AM +, Zengtao (B) wrote:
> From: Zeng Tao
Just fix your email client to reflect your full name.
> Date: Tue, 5 Aug 2014 17:58:10 +0800
> Subject: [PATCH] drivers: android: fix watermark when cma enabled
>
Don't add these lines. Read the first paragraph of
D
From: Roger Tseng
Current code erroneously fill the last byte of R2 response with an undefined
value. In addition, it is impossible to obtain the real values since the
controller actually 'offloads' the last byte(CRC7, end bit) while receiving R2
response. This could cause mmc stack to obtain inc
On Mon, Aug 11, 2014 at 07:04:20AM +, Ganesan Ramalingam wrote:
> Hello Greg,
>
> The function nlm_cop2_enable() and nlm_cop2_restore() in
> arch/mips/netlogic/xlr/fmn.c are changed in commit "64f6ebe MIPS: Netlogic:
> rename nlm_cop2_save/restore", these functions are used in
> driver/stag
On Mon, Aug 11, 2014 at 01:39:59PM +0800, gre...@linuxfoundation.org wrote:
> On Mon, Aug 11, 2014 at 12:32:55AM +0300, Anca Emanuel wrote:
> > Do you have this hardware ? And did you test this ?
>
> Mark is the maintainer of this driver, I assume he has the hardware, if
> not, I don't care, I tru
On Sat, Aug 09, 2014 at 09:39:17PM -0700, Greg KH wrote:
> On Tue, Aug 05, 2014 at 11:57:06PM +0100, Mark Einon wrote:
> > Fix two reported bugs, caused by et131x_adapter->phydev->addr being accessed
> > before it is initialised, by:
> >
> > - letting et131x_mii_write() take a phydev address, inste
71 matches
Mail list logo
