Re: [PATCH] drivers/staging/rtl8192u/r8192U_wx.c: fix warnings issued by sparse

2014-08-09 Thread Joe Perches
On Sat, 2014-08-09 at 00:05 -0700, Ovidiu Toader wrote: > This minor patch motivated by eudyptula challenge fixes the following > warnings issued > by `sparse' in drivers/staging/rtl8192u/r8192U_wx.c: > .../r8192U_wx.c:27:5: warning: symbol 'rtl8180_rates' was not declared. > Should it be stati

[PATCH] staging: lustre: lustre: ptlrpc: nrs.c: Cleaning up missing null-terminate after strncpy call

2014-08-09 Thread Rickard Strandqvist
Added a guaranteed null-terminate after call to strncpy. Signed-off-by: Rickard Strandqvist --- drivers/staging/lustre/lustre/ptlrpc/nrs.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/lustre/ptlrpc/nrs.c b/drivers/staging/lustre/lustre/ptlrpc/nrs.c index 12151aa

[PATCH] staging: lustre: lustre: obdclass: genops.c: Cleaning up missing null-terminate after strncpy call

2014-08-09 Thread Rickard Strandqvist
Added a guaranteed null-terminate after call to strncpy. Signed-off-by: Rickard Strandqvist --- drivers/staging/lustre/lustre/obdclass/genops.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/lustre/obdclass/genops.c b/drivers/staging/lustre/lustre/obdclass/genops.

[PATCH] staging: lustre: lustre: libcfs: workitem.c: Cleaning up missing null-terminate after strncpy call

2014-08-09 Thread Rickard Strandqvist
Added a guaranteed null-terminate after call to strncpy. Signed-off-by: Rickard Strandqvist --- drivers/staging/lustre/lustre/libcfs/workitem.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/lustre/lustre/libcfs/workitem.c b/drivers/staging/lustre/lustre/libcfs/workitem.

Re: [PATCH] [next-20140808] [staging] [lustre] Fix coding style in llite/remote_perm.c

2014-08-09 Thread Aaro Koskinen
On Sat, Aug 09, 2014 at 08:22:48PM +, Junien Fridrick wrote: > Sorry for the noise, this is part of task 10 of the Eudyptula Challenge. Nothing wrong with the patch itself, but maybe in the future you could put such comments after the "---" line so that they won't be included in the git commit

[PATCH] [next-20140808] [staging] [lustre] Fix coding style in llite/remote_perm.c

2014-08-09 Thread Junien Fridrick
Sorry for the noise, this is part of task 10 of the Eudyptula Challenge. Signed-off-by: Junien Fridrick --- drivers/staging/lustre/lustre/llite/remote_perm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre/lustre/llite/remote_perm.c b/drivers/staging/l

[PATCH] staging: dgnc: Encapsulate global variables in a structure

2014-08-09 Thread Konrad Zapalowicz
This commit binds global variables of dgnc driver in a structure so that it is logically consistent. The structure is accessed via getter function and as a result the externing of globals is removed. The names of the variables are also changed to be more eye friendly. Signed-off-by: Konrad Zapalow

Re: [PATCH] staging/lustre: use rcu_dereference to access rcu protected current->real_parent field

2014-08-09 Thread Greg Kroah-Hartman
On Sat, Aug 09, 2014 at 10:34:36AM -0400, Oleg Drokin wrote: > > > Because maybe these stats preceed the introduction of perf and other > > tracing/debug tools? I don't know, it's really low down on the list of > > reasons why lustre can't be merged out of staging at the moment, you all > > have

Re: [PATCH] staging/lustre: use rcu_dereference to access rcu protected current->real_parent field

2014-08-09 Thread Oleg Drokin
> Because maybe these stats preceed the introduction of perf and other > tracing/debug tools? I don't know, it's really low down on the list of > reasons why lustre can't be merged out of staging at the moment, you all > have much bigger issues to address first. I wonder what is the prioritized

Re: [PATCH] staging/lustre: use rcu_dereference to access rcu protected current->real_parent field

2014-08-09 Thread Greg Kroah-Hartman
On Sat, Aug 09, 2014 at 07:05:46PM +0800, Peng Tao wrote: > On Fri, Aug 8, 2014 at 1:32 PM, Greg Kroah-Hartman > wrote: > > On Fri, Aug 08, 2014 at 01:06:15AM -0400, Oleg Drokin wrote: > >> > >> On Aug 8, 2014, at 12:42 AM, Greg Kroah-Hartman wrote: > >> > >> > On Fri, Aug 08, 2014 at 12:03:20AM -

Re: [PATCH] staging/lustre: use rcu_dereference to access rcu protected current->real_parent field

2014-08-09 Thread Peng Tao
On Fri, Aug 8, 2014 at 1:32 PM, Greg Kroah-Hartman wrote: > On Fri, Aug 08, 2014 at 01:06:15AM -0400, Oleg Drokin wrote: >> >> On Aug 8, 2014, at 12:42 AM, Greg Kroah-Hartman wrote: >> >> > On Fri, Aug 08, 2014 at 12:03:20AM -0400, Oleg Drokin wrote: >> >> Hello! >> >> >> >> On Aug 7, 2014, at 11:

[PATCH] drivers/staging/rtl8192u/r8192U_wx.c: fix warnings issued by sparse

2014-08-09 Thread Ovidiu Toader
This minor patch motivated by eudyptula challenge fixes the following warnings issued by `sparse' in drivers/staging/rtl8192u/r8192U_wx.c: .../r8192U_wx.c:27:5: warning: symbol 'rtl8180_rates' was not declared. Should it be static? .../r8192U_wx.c:961:22: warning: symbol 'r8192_get_wireless_st