On Wed, 2014-08-06 at 03:53 +0300, Dzonatans Melgalvis wrote:
> Fixing checkpatch warning - blank line missing after declaration.
[]
> diff --git a/drivers/staging/comedi/drivers.c
> b/drivers/staging/comedi/drivers.c
[]
> @@ -440,6 +440,7 @@ static void *comedi_recognize(struct comedi_driver *dri
On Wed, 2014-08-06 at 02:29 +0300, Dzonatans Melgalvis wrote:
> Fixing checkpatch warning - blank line missing after declaration.
These are false positives from a previous version
of checkpatch. Please use the version in -next
instead. No errors are reported with that version.
> Signed-off-by:
Fixing checkpatch warning - blank line missing after declaration.
Signed-off-by: Dzonatans Melgalvis
---
drivers/staging/comedi/drivers.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/comedi/drivers.c b/drivers/staging/comedi/drivers.c
index 9ada130..00e01d0 100644
--- a/dr
On Wed, Aug 06, 2014 at 02:29:45AM +0300, Dzonatans Melgalvis wrote:
> Fixing checkpatch warning - blank line missing after declaration.
>
> Signed-off-by: Dzonatans Melgalvis
> ---
> drivers/staging/comedi/comedidev.h | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/stagi
Fixing checkpatch warning - blank line missing after declaration.
Signed-off-by: Dzonatans Melgalvis
---
drivers/staging/comedi/comedidev.h | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/staging/comedi/comedidev.h
b/drivers/staging/comedi/comedidev.h
index 58e58a3..c9b7978 10
Fix two reported bugs, caused by et131x_adapter->phydev->addr being accessed
before it is initialised, by:
- letting et131x_mii_write() take a phydev address, instead of using the one
stored in adapter by default. This is so et131x_mdio_write() can use it's own
addr value.
- removing implement
Use dev_dbg with %*ph format specifier and print_hex_dump_bytes to dump memory
instead of relying on custom macro.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/ms.c| 5 +++--
drivers/staging/rts5208/rtsx_chip.c | 6 --
drivers/staging/rts5208/rtsx_scsi.c | 7 +++
drive
Use standard debug features instead of relying on the custom
configuration option CONFIG_RTS5208_DEBUG and a series of home grown
macros.
This new version contains the remaining two chunks of the v5 patchset:
the first two chunks have already been merged.
Changes in v6:
* Use print_hex_dump_bytes
CONFIG_RTS5208_DEBUG is no more needed, we rely on dynamic debug config options
instead.
Signed-off-by: Fabio Falzoi
---
drivers/staging/rts5208/Kconfig | 7 ---
drivers/staging/rts5208/sd.c| 5 +
2 files changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/rts5208/
On Tue, Aug 05, 2014 at 10:58:03PM +0200, Niklas Svensson wrote:
> Fixed checkpatch.pl warnings
_which_ checkpatch warnings? Be specific, and descriptive, and explain
what you are doing and why you are doing it.
greg k-h
___
devel mailing list
de...@li
Fixed checkpatch.pl warnings
Signed-off-by: Niklas Svensson
---
drivers/staging/comedi/drivers/comedi_test.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/comedi_test.c
b/drivers/staging/comedi/drivers/comedi_test.c
index 845a679..7aa
> -Original Message-
> From: David Miller [mailto:da...@davemloft.net]
> Sent: Tuesday, August 5, 2014 4:04 PM
> To: thomas1...@gmail.com
> Cc: net...@vger.kernel.org; Haiyang Zhang; KY Srinivasan; o...@aepfle.de;
> jasow...@redhat.com; linux-ker...@vger.kernel.org; driverdev-
> de...@lin
From: Haiyang Zhang
Date: Fri, 1 Aug 2014 15:55:30 +
> When the buffer is too small for a packet from VMBus, a bigger buffer will be
> allocated in netvsc_channel_cb() and retry reading the packet from VMBus.
> Increasing this buffer size will reduce the retry overhead.
>
> Signed-off-by: H
Please note, this also fixes the following build error on sparc64
http://kisskb.ellerman.id.au/kisskb/buildresult/11607883/
On Tue, Aug 5, 2014 at 12:27 PM, Pranith Kumar wrote:
> The following patch fixes a build error on sparc32. I think it should go to
> stable 3.16.
>
> Remove a circular dep
From: Fernando Apesteguia
Remove ComputeTxTime since it is not used.
Signed-off-by: Fernando Apesteguia
---
drivers/staging/rtl8192u/r8192U_core.c | 22 --
1 file changed, 22 deletions(-)
diff --git a/drivers/staging/rtl8192u/r8192U_core.c
b/drivers/staging/rtl8192u/r81
Two functions were missing space between declarations and code.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/common-spar/include/channels/channel.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/unisys/common-spar/include/channels/channel.h
b/drivers/staging/u
Correct a couple of missing blank lines in uisutils.h.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/uisutils.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/unisys/include/uisutils.h
b/drivers/staging/unisys/include/uisutils.h
index a1c193c..f1a1b0d 1
This patch series removes unused macros, replaces redundant macros, fixes
spacing and other formatting issues, and eliminates checkpatch warnings from
the header files in the include and common-spar directories, other than
volatile and new typedef warnings.
The volatile warnings will be addressed
The comments for the large union CONTROLVM_MESSAGE_PACKET were inconsistently
placed and one extended past the 80 char limit. These are cleaned up.
Signed-off-by: Benjamin Romer
---
.../include/channels/controlvmchannel.h| 41 --
1 file changed, 30 insertions(+),
Remove the do blocks around several macros and fix spacing and trailing
semicolons.
Signed-off-by: Benjamin Romer
---
.../unisys/common-spar/include/channels/iochannel.h| 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/unisys/common-spar/i
Clean up the format of the vmcall functions in iovmcall_gnuc.h. These functions
are rewritten for clarity and to correct the indention, without changing any
functionality.
Signed-off-by: Benjamin Romer
---
.../unisys/common-spar/include/iovmcall_gnuc.h | 26 +-
1 file cha
Remove all of the semaphore macros from timskmod.h and switch all uses of those
types to the correct function names.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/timskmod.h | 28 --
drivers/staging/unisys/uislib/uislib.c | 16 ++---
The controlVM status file had comments going over the 80 character limit. These
are moved to the next line and the spacing is fixed.
Signed-off-by: Benjamin Romer
---
.../common-spar/include/controlvmcompletionstatus.h | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
Remove the uiscmpxchg64 macro from uisqueue.h and uisqueue.c.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/uisqueue.h | 15 ---
drivers/staging/unisys/uislib/uisqueue.c | 6 ++
2 files changed, 2 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/u
There are spacing errors in the functions in iovmcall_gnuc. Fix these.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/common-spar/include/iovmcall_gnuc.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/unisys/common-spar/include/iovmcall_gnuc.h
There was a missing line between declarations and code in vbusdeviceinfo.h.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/common-spar/include/vbusdeviceinfo.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/unisys/common-spar/include/vbusdeviceinfo.h
b/drivers/sta
Several macros in timskmod.h are unused. Remove them.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/timskmod.h | 14 --
1 file changed, 14 deletions(-)
diff --git a/drivers/staging/unisys/include/timskmod.h
b/drivers/staging/unisys/include/timskmod.h
index 8e0ae4
Delete the unused common VMMIO types in timskmod.h.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/timskmod.h | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/staging/unisys/include/timskmod.h
b/drivers/staging/unisys/include/timskmod.h
index ecf1a6f..b2
Fix all whitespace formatting issues in timskmod.h.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/include/timskmod.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/unisys/include/timskmod.h
b/drivers/staging/unisys/include/timskmod.h
index b20fc9d..59144ba 100644
The CHANNEL_*_MISMATCH error message macros should not be inside of do blocks.
Signed-off-by: Benjamin Romer
---
.../staging/unisys/common-spar/include/channels/channel.h| 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/unisys/common-spar/includ
On Tuesday, August 05, 2014 9:54 AM, Ian Abbott wrote:
> On 2014-08-05 17:12, Hartley Sweeten wrote:
>> On Tuesday, August 05, 2014 2:59 AM, Ian Abbott wrote:
>>> It still has a race condition between the interrupt handler and
>>> iounmap(devpriv->main_iobase) though. (Even though you've disabled
Fix sparse warning:
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c:25:4: warning: symbol
'ODM_GetRightChnlPlaceforIQK' was not declared. Should it be static?
by making it static since it's only used once.
Signed-off-by: Miguel Oliveira
---
drivers/staging/rtl8188eu/hal/HalPhyRf_8188e.c |2 +
It was a git miss configuration in a new host, that was fixed.
Sorry for the inconvenient.
Regards,
Miguel Oliveira
2014-08-05 18:56 GMT+02:00 Dan Carpenter :
> On Tue, Aug 05, 2014 at 07:49:54PM +0100, Miguel Oliveira wrote:
>> From: Miguel
>
> Leave this line out, git should get this from your
On Tue, Aug 05, 2014 at 07:49:54PM +0100, Miguel Oliveira wrote:
> From: Miguel
Leave this line out, git should get this from your email unless you are
sending on someone else's behalf. Also this name is wrong and your
email header has the correct full name.
regards,
dan carpenter
On 2014-08-05 17:12, Hartley Sweeten wrote:
On Tuesday, August 05, 2014 2:59 AM, Ian Abbott wrote:
On 2014-08-04 23:55, H Hartley Sweeten wrote:
Use comedi_pci_detach() to handle the boilerplate part of the (*detach)
for this PCI driver.
This also fixes a race condition where the interrupt han
On Tue, Aug 5, 2014 at 3:49 PM, Miguel Oliveira wrote:
> From: Miguel
Please use your full name in the From field.
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
From: Miguel
Fix sparse warning:
drivers/staging/rtl8188eu/core/rtw_cmd.c:52:5: warning: symbol
'_rtw_enqueue_cmd' was not declared. Should it be static?
by making it static since it's only used once.
Signed-off-by: Miguel Oliveira
---
drivers/staging/rtl8188eu/core/rtw_cmd.c |2 +-
1 fil
The following patch fixes a build error on sparc32. I think it should go to
stable 3.16.
Remove a circular dependency on atomic.h header file which leads to compilation
failure on sparc32 as reported here:
http://kisskb.ellerman.id.au/kisskb/buildresult/11340509/
The specific dependency is as fol
On Tuesday, August 05, 2014 2:59 AM, Ian Abbott wrote:
> On 2014-08-04 23:55, H Hartley Sweeten wrote:
>> Use comedi_pci_detach() to handle the boilerplate part of the (*detach)
>> for this PCI driver.
>>
>> This also fixes a race condition where the interrupt handler is released
>> before the inte
On 2014-08-05 15:22, Luca Ellero wrote:
This is a preliminary version, some features are not implemented yet:
GPIO: works
counter: doesn't work
Signed-off-by: Luca Ellero
---
This is a preliminary version of the NI USB-6501 driver.
Every comment/suggestion is welcome.
I plan to
Renamed variable "uiOperation" -> "operation" in
bcm_char_ioctl_gpio_set_request().
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index 6ae95d
Renamed variable "sRdmBuffer" -> "rdm_buff" in
bcm_char_ioctl_reg_read_private()
bcm_char_ioctl_reg_write_private()
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/stag
Renamed variable "uiTempVar" -> "tmp" in
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_eeprom_reg_read()
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging
Renamed variable "sWrmBuffer" -> "wrm_buff" in
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_eeprom_reg_read()
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 32
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drive
Renamed variable "ucResetValue" -> "reset_val" in
bcm_char_ioctl_gpio_set_request().
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index 062
Renamed variable "Bufflen" -> "buff_len" in
bcm_char_ioctl_reg_read_private().
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index 7eac
Renamed variable "IoBuffer" -> "io_buff" in
bcm_char_ioctl_reg_read_private()
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_eeprom_reg_read()
bcm_char_ioctl_gpio_set_request()
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmcha
Renamed variable "uiBit" -> "bit" in bcm_char_ioctl_gpio_set_request().
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index c63eb37..6a
Renamed variable "Packet" -> "packet" in bcm_char_read().
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index 36c7b27..40433da 1006
Renamed variable "PktLen" -> "pkt_len" in bcm_char_read().
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index 1481074..36c7b27 100644
--
Renamed variable "ulDSDMagicNumInUsrBuff" ->
"dsd_magic_num_in_usr_buff" in handle_flash2x_adapter().
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmc
Renamed variable "pTarang" -> "tarang" in
bcm_char_open()
bcm_char_release()
bcm_char_read()
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 46 +--
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/drivers/stag
Renamed variable "stNVMReadWrite" -> "nvm_rw" in
bcm_handle_nvm_read_cmd()
handle_flash2x_adapter()
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drive
Hi,
as Dan suggested, I squashed the patches with the same subjects.
Please note, as always: As I do not have the appropriate hardware, I'm
not able to test these patches. I compiled them at least.
Kind regards,
Matthias Beyer
Matthias Beyer (17):
Staging: bcm: Bcmchar.c: Fixed indentation of
Renamed variable "pReadData" -> "read_data" in
bcm_handle_nvm_read_cmd()
handle_flash2x_adapter()
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/dr
Renamed variable "Status" -> "status" in
bcm_handle_nvm_read_cmd()
handle_flash2x_adapter()
bcm_char_ioctl_reg_read_private()
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_eeprom_reg_read()
bcm_char_ioctl_gpio_set_request()
Signed
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/Bcmchar.c | 56 ---
1 file changed, 31 insertions(+), 25 deletions(-)
diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c
index c1e01f7..aff21d0 100644
--- a/drivers/staging/bcm/B
Renamed variable "Adapter" -> "ad" in
bcm_handle_nvm_read_cmd()
handle_flash2x_adapter()
bcm_char_open()
bcm_char_release()
bcm_char_read()
bcm_char_ioctl_reg_read_private()
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_reg_write_private()
bcm_char_ioctl_eep
On Mon, Aug 04, 2014 at 02:54:53PM +0200, Christoph Jaeger wrote:
> @@ -2341,6 +2289,11 @@ int oz_hcd_init(void)
>
> if (usb_disabled())
> return -ENODEV;
> +
> + oz_urb_link_cache = KMEM_CACHE(oz_urb_link, 0);
> + if (unlikely(!oz_urb_link_cache))
> + retu
On Mon, Aug 04, 2014 at 02:54:52PM +0200, Christoph Jaeger wrote:
> Simplify the somewhat overcomplicated application interface; improves
> readability and saves a bunch of lines.
>
> Use designated struct initializers for clarity.
I was worried this would change the API but it doesn't. The patc
Yes, Zeng Tao is my real name.
-邮件原件-
发件人: Dan Carpenter [mailto:dan.carpen...@oracle.com]
发送时间: 2014年8月5日 18:36
收件人: Zengtao (B)
抄送: de...@driverdev.osuosl.org; gre...@linuxfoundation.org
主题: Re: [PATCH] drivers: android: fix watermark when cma enabled
On Tue, Aug 05, 2014 at 09:43:48AM
Combine all the patches which have the same subjects.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
On Tue, Aug 05, 2014 at 09:43:48AM +, Zengtao (B) wrote:
> From: zengtao
This is for when you are sending patches on behalf of someone else.
Just fix your from header. Use your real name. Zeng Tao?
>
> when cma is enabled, the watermark caculation will
> include the cma pages, while it ca
On 2014-08-04 23:55, H Hartley Sweeten wrote:
Use comedi_pci_detach() to handle the boilerplate part of the (*detach)
for this PCI driver.
Remove the unnecessary read/write of the PLC_INTRCS_REG. The rtd_reset()
function writes '0' to this register.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abb
Could you fold all the "blank line" patches into a single patch and do
the other stuff in a different patch?
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-de
On 2014-08-04 23:55, H Hartley Sweeten wrote:
Use comedi_pci_detach() to handle the boilerplate part of the (*detach)
for this PCI driver.
This also fixes a race condition where the interrupt handler is released
before the interrupts are disabled in the hardware.
Signed-off-by: H Hartley Sweete
On 2014-08-04 23:55, H Hartley Sweeten wrote:
Use comedi_pci_detach() to handle the boilerplate part of the (*detach)
for this PCI driver.
This also fixes a race condition where the interrupt handler is released
before the interrupts are disabled in the hardware.
Signed-off-by: H Hartley Sweete
When the buffer is too small for a packet from VMBus, a bigger buffer will be
allocated in netvsc_channel_cb() and retry reading the packet from VMBus.
Increasing this buffer size will reduce the retry overhead.
Signed-off-by: Haiyang Zhang
Reviewed-by: Dexuan Cui
---
drivers/net/hyperv/hyperv_
From: zengtao
when cma is enabled, the watermark caculation will
include the cma pages, while it can't use cma pages.
this will cause oom while lowmemory killer don't work.
Signed-off-by: zengtao
---
drivers/staging/android/lowmemorykiller.c |4 +++-
1 files changed, 3 insertions(+), 1 del
69 matches
Mail list logo
