Re: [PATCH] Staging: android: timed_gpio.c: remove else statement after return

On Mon, 2014-07-28 at 20:11 -0300, Murilo Opsfelder Araujo wrote: > This patch makes checkpatch.pl script happy by fixing the following > warning: > > WARNING: else is not generally useful after a break or return > > Signed-off-by: Murilo Opsfelder Araujo > --- > drivers/staging/android/timed_g

Re: [PATCH] Staging: bcm: Bcmchar.c: remove else statement after return

On Mon, 2014-07-28 at 21:09 -0300, Murilo Opsfelder Araujo wrote: > This patch makes checkpatch.pl script happier by fixing all warnings > related to else statement after break or return. [] > diff --git a/drivers/staging/bcm/Bcmchar.c b/drivers/staging/bcm/Bcmchar.c [] > @@ -561,10 +561,10 @@ stat

[PATCH] Staging: bcm: Bcmchar.c: remove else statement after return

This patch makes checkpatch.pl script happier by fixing all warnings related to else statement after break or return. Signed-off-by: Murilo Opsfelder Araujo --- drivers/staging/bcm/Bcmchar.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/sta

[PATCH] Staging: android: timed_output.c: use kstrtoint() instead of sscanf()

This patch makes checkpatch.pl happy by fixing the following warning: WARNING: Prefer kstrto to single variable sscanf Signed-off-by: Murilo Opsfelder Araujo --- drivers/staging/android/timed_output.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/staging/andr

[PATCH] Staging: android: timed_gpio.c: remove else statement after return

This patch makes checkpatch.pl script happy by fixing the following warning: WARNING: else is not generally useful after a break or return Signed-off-by: Murilo Opsfelder Araujo --- drivers/staging/android/timed_gpio.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/

[PATCH] Staging: android: sync.c: fix missing blank line after declaration

Fix coding style issue. Signed-off-by: Murilo Opsfelder Araujo --- drivers/staging/android/sync.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c index e7b2e02..69c16cb 100644 --- a/drivers/staging/android/syn

[PATCH] Staging: android: sw_sync.c: fix missing blank line after declaration

Fix coding style issue. Signed-off-by: Murilo Opsfelder Araujo --- drivers/staging/android/sw_sync.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c index a76db3f..863d4b1 100644 --- a/drivers/staging/android/sw_sync

[PATCH] Staging: android: Missing a blank line after declarations in sw_sync.c This is a patch to the sw_sync.c file that fixes up a missing a blank warning found by the checkpatch.pl tool

From: Adrian Remonda Signed-off-by: Adrian Remonda --- drivers/staging/android/sw_sync.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/android/sw_sync.c b/drivers/staging/android/sw_sync.c index a76db3ff87cb..863d4b17387a 100644 --- a/drivers/staging/android/sw_sync

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

> -Original Message- > From: James Bottomley [mailto:jbottom...@parallels.com] > Sent: Monday, July 28, 2014 1:03 PM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; h...@infradead.org; sits...@gmail.com; > de...@linuxdriverproject.org; a...@canonical.com; > martin.peter...@oracle.

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

On Mon, 2014-07-28 at 19:05 +, KY Srinivasan wrote: > > > -Original Message- > > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > > Sent: Monday, July 28, 2014 12:03 PM > > To: KY Srinivasan > > Cc: Martin K. Petersen; Sitsofe Wheeler; Christoph Hellwig; > > gre...@linuxf

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Monday, July 28, 2014 12:03 PM > To: KY Srinivasan > Cc: Martin K. Petersen; Sitsofe Wheeler; Christoph Hellwig; > gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproje

Re: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

> "KY" == KY Srinivasan writes: KY, KY> "At the time thin-provisioning was defined, the discovery KY> information was first proposed in READ CAPACITY 16 command. And then KY> moved into the new dedicated VPD page - B2h. You can see the KY> information reported in this VPD page is richer than

RE: [PATCH v2 3/3] [SCSI] Make LBP quirk skip lbpme checks tests

> -Original Message- > From: Martin K. Petersen [mailto:martin.peter...@oracle.com] > Sent: Saturday, July 26, 2014 12:25 PM > To: KY Srinivasan > Cc: Martin K. Petersen; Sitsofe Wheeler; Christoph Hellwig; > gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverpro

[PATCH 4/9] staging: rtl8188eu: Remove wrapper function _dynamic_check_timer_handlder()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mlme.c | 13 - drivers/staging/rtl8188eu/include/rtw_mlme.h |2 +- drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 12 +--- 3 files changed, 10 insertions(+), 17 deletions(-) diff --git a/driver

[PATCH 5/9] staging: rtl8188eu: Remove wrapper function _survey_timer_hdl()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c|3 ++- drivers/staging/rtl8188eu/include/rtw_mlme_ext.h |2 +- drivers/staging/rtl8188eu/os_dep/mlme_linux.c|9 + 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/sta

[PATCH 6/9] staging: rtl8188eu: Remove wrapper function _link_timer_hdl()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c|3 ++- drivers/staging/rtl8188eu/include/rtw_mlme_ext.h |2 +- drivers/staging/rtl8188eu/os_dep/mlme_linux.c|8 +--- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/stagi

[PATCH 3/9] staging: rtl8188eu: Remove wrapper function _rtw_scan_timeout_handler()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mlme.c |3 ++- drivers/staging/rtl8188eu/include/rtw_mlme.h |3 +-- drivers/staging/rtl8188eu/os_dep/mlme_linux.c |9 + 3 files changed, 4 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl

[PATCH 7/9] staging: rtl8188eu: Remove wrapper function _addba_timer_hdl()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c|3 ++- drivers/staging/rtl8188eu/include/rtw_mlme_ext.h |2 +- drivers/staging/rtl8188eu/os_dep/mlme_linux.c|8 +--- 3 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/stagi

[PATCH 8/9] staging: rtl81888eu: Remove unused function rtw_os_read_port()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/include/recv_osdep.h |2 -- drivers/staging/rtl8188eu/os_dep/recv_linux.c | 12 2 files changed, 14 deletions(-) diff --git a/drivers/staging/rtl8188eu/include/recv_osdep.h b/drivers/staging/rtl8188eu/include/recv_o

[PATCH 9/9] staging:rtl8188eu:Remove wrapper function _rtw_reordering_ctrl_timeout_handler()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/os_dep/recv_linux.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/staging/rtl8188eu/os_dep/recv_linux.c b/drivers/staging/rtl8188eu/os_dep/recv_linux.c index f7d53dd..05427c4 100644 --- a/driver

[PATCH 2/9] staging: rtl8188eu: Remove wrapper function rtw_join_timeout_handler()

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/core/rtw_mlme.c |3 ++- drivers/staging/rtl8188eu/include/rtw_mlme.h |3 +-- drivers/staging/rtl8188eu/os_dep/mlme_linux.c | 10 +- 3 files changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/staging/rt

[PATCH 1/9] staging: rtl8188eu: Remove unused member MultiFunc from struct hal_data_8188e

Signed-off-by: navin patidar --- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c |1 - drivers/staging/rtl8188eu/include/rtl8188e_hal.h |1 - 2 files changed, 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/rtl8188eu/hal/rtl8188e_hal_i

[PATCH 03/19] staging: comedi: ni_tio: tidy up Gi_Command_Reg_Bits

Convert this enum into defines and rename all the CamelCase symbols. For aesthetics, move the new defines so they are associated with the register define. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 20 ++---

[PATCH 11/19] staging: comedi: ni_tio: tidy up Gi_DMA_Config_Reg_Bits

Convert this enum into defines and rename the CamelCase symbols. For aesthetics, move the new defines so they are associated with the register define. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_stc.h | 8 dri

[PATCH 01/19] staging: comedi: ni_tio: tidy up ni_tio_read_sw_save_reg()

Remove the need for some of the local variables. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/

[PATCH 02/19] staging: comedi: ni_tio: tidy up Gi_Counting_Mode_Reg_Bits

Convert this enum into defines and rename all the CamelCase symbols. For aesthetics, move the new defines so they are associated with the register define. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 99 +

[PATCH 13/19] staging: comedi: ni_tio: tidy up Gxx_Interrupt_Acknowledge_Bits

Convert this enum and the others related to it into defines and rename the CamelCase symbols. For aesthetics, move the new defines so they are associated with the register define. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio_

[PATCH 07/19] staging: comedi: ni_tio: tidy up Gi_Second_Gate_Bits

Convert this enum into defines and rename the CamelCase symbols. For aesthetics, move the new defines so they are associated with the register define. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 44 ++---

[PATCH 15/19] staging: comedi: ni_tio: tidy up G{02, 12}_Interrupt_Enable_Bits

Convert these enums into defines and rename the CamelCase symbols. For aesthetics, move the new defines so they are associated with the register define. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio_internal.h | 21 ++-

[PATCH 00/19] staging: comedi: ni_tio: cleanup CamelCase issues

Fix the CamelCase issues by replacing the enums used for the register bits with simple defines/macros and renaming the symbols. Remove some unnecessary BUG() checks and tidy up some of the functions in ni_tiocmd. H Hartley Sweeten (19): staging: comedi: ni_tio: tidy up ni_tio_read_sw_save_reg()

[PATCH 10/19] staging: comedi: ni_tio: tidy up Gxx_Joint_Status2_Bits

Convert this enum into defines and rename the CamelCase symbols. For aesthetics, move the new defines so they are associated with the register define. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio_internal.h | 19 +++--

[PATCH 08/19] staging: comedi: ni_tio: tidy up Gxx_Status_Bits

Convert this enum into defines and rename the CamelCase symbols. For aesthetics, move the new defines so they are associated with the register define. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 6 +-- drivers/

[PATCH 12/19] staging: comedi: ni_tio: tidy up Gi_DMA_Status_Reg_Bits

Convert this enum into defines and rename the CamelCase symbols. For aesthetics, move the new defines so they are associated with the register define. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio_internal.h | 9 +++-- dri

[PATCH 14/19] staging: comedi: ni_tio: tidy up Gi_Status_Bits

Convert this enum into defines and rename the CamelCase symbols. For aesthetics, move the new defines so they are associated with the register define. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio_internal.h | 9 +++-- dri

[PATCH 05/19] staging: comedi: ni_tio: tidy up Gi_Input_Select_Bits

Convert this enum into defines and rename the CamelCase symbols. For aesthetics, move the new defines so they are associated with the register define. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 86 +++--

[PATCH 06/19] staging: comedi: ni_tio: tidy up Gi_Mode_Bits

Convert this enum into defines and rename the CamelCase symbols. For aesthetics, move the new defines so they are associated with the register define. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 30 ++--

[PATCH 18/19] staging: comedi: ni_tiocmd: tidy up ni_tio_input_cmd()

The cmd->start_src is validated in the (*do_cmdtest) before this function is called. All valid trigger sources are handled so the default BUG() case can never occure. For aesthetics, refactor the switch into if/else tests and remove the BUG(). For aesthetics, rename the local variable 'retval' to

[PATCH 17/19] staging: comedi: ni_tiocmd: tidy up ni_tio_input_inttrig()

Remove the BUG_ON(counter == NULL). If this can never happen and it if did the driver should have died long before this function is called. For aesthetics, rename the local variable 'retval' to simply 'ret'. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/st

[PATCH 19/19] staging: comedi: ni_tiocmd: introduce ni_tio_acknowledge()

The external callers of ni_tio_acknowledge_and_confirm() only call this function to ack any pending errors or interrupts before starting a new async command. Only the internal code in ni_tiocmd uses the data that is optionally returned by this function. Remove the export from ni_tio_acknowledge_an

[PATCH 16/19] staging: comedi: ni_tiocmd: tidy up ni_tio_configure_dma()

The 'enable' and 'read_not_write' parameters are true/false flags. For aesthetics, change their types to bool. Rename the local variable 'input_select_bits' to simply 'bits' and reuse it when enabling the dma on the m series and 660x counter variants. Add a local variable for the 'mask' that is p

[PATCH 04/19] staging: comedi: ni_tio: tidy up Gi_Auto_Increment_Reg_Bits

Convert this enum into defines and rename the CamelCase symbols. For aesthetics, move the new defines so they are associated with the register define. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio_internal.h | 5 + 1 file

[PATCH 09/19] staging: comedi: ni_tio: tidy up Gi_Reset_Bit

Convert this inline CamelCase function into a define. For aesthetics, move the new define so it is associated with the register define. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 2 +- drivers/staging/comedi/dr

[PATCH 6/6] Staging: bcm: IPv6Protocol.c: Line length fixes

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/IPv6Protocol.c | 93 -- 1 file changed, 60 insertions(+), 33 deletions(-) diff --git a/drivers/staging/bcm/IPv6Protocol.c b/drivers/staging/bcm/IPv6Protocol.c index 75eb1d7..9abdbb7 100644 --- a/drivers/st

[PATCH 5/6] Staging: bcm: IPv6Protocol.c: Whitespace cleanup

Removes whitespace before semicolons and add blank line after declaration. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/IPv6Protocol.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/staging/bcm/IPv6Protocol.c b/drivers/staging/bcm/IPv6Protocol.c

[PATCH 4/6] Staging: bcm: IPv6Protocol.c: Replaced member accessing with variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/IPv6Protocol.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/IPv6Protocol.c b/drivers/staging/bcm/IPv6Protocol.c index c5bbb14..c1b0367 100644 --- a/drivers/staging/bcm/IPv6Protocol.c +++ b

[PATCH 2/6] Staging: bcm: IPv6Protocol.c: Removed unnecessary if-else blocks

This patch simplifies if (a) { x = false; } else { if (b) { x = false; } } to if (a || b) { x = false; } Signed-off-by: Matthias Beyer --- drivers/staging/bcm/IPv6Protocol.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletion

[PATCH 3/6] Staging: bcm: IPv6Procotol.c: Replaced member accessing with variable

Signed-off-by: Matthias Beyer --- drivers/staging/bcm/IPv6Protocol.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/bcm/IPv6Protocol.c b/drivers/staging/bcm/IPv6Protocol.c index 5bcdaf9..c5bbb14 100644 --- a/drivers/staging/bcm/IPv6Protocol.c +++ b

[PATCH 1/6] Staging: bcm: IPv6Protocol.c: Reindented switch-case

This patch removes the unneccessary blocks inside the case statements and fixes the indentation of their content. Signed-off-by: Matthias Beyer --- drivers/staging/bcm/IPv6Protocol.c | 88 +- 1 file changed, 40 insertions(+), 48 deletions(-) diff --git a/driv

[PATCH 0/6] drivers/staging/bcm/IPIv6Protocol.c: cleanup patches

Hi, these are my patches for the drivers/staging/bcm/IPv6Protocol.c file. Please note: I'm not able to test these patches as I do not have the appropriate hardware, I compiled them at least. Kind regards, Matthias Beyer Matthias Beyer (6): Staging: bcm: IPv6Protocol.c: Reindented switch

RE: [PATCH 1/3] staging: comedi: amplc_dio200_common: prevent extra free_irq()

On Sunday, July 27, 2014 11:45 AM, Greg Kroah-Hartman wrote: > On Fri, Jul 25, 2014 at 06:23:10PM +, Hartley Sweeten wrote: >> On Friday, July 25, 2014 10:07 AM, Ian Abbott wrote: >>> `dio200_detach()` in "amplc_dio200.c" calls >>> `amplc_dio200_common_detach()` in "amplc_dio200_common.c", foll

[PATCH 1/1] staging: rtl8192u: mark some functions as static.

Some functions defined in r8192U_core.c and only used locally are marked as static. This fixes some warnings issued by sparse. Signed-off-by: Antoine Schweitzer-Chaput --- drivers/staging/rtl8192u/r8192U_core.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drive

Re: Eudyptula Challenge (Task 10)

On Mon, Jul 28, 2014 at 05:53:19AM -0700, Christoph Hellwig wrote: > Can you folks please stop this challenge Bullshit? More checkpatch > fixes is not something we'll need at all. Greg and Dan have previously said that the staging tree is a good place for newcomers to submit checkpatch cleanup pa

Re: Eudyptula Challenge (Task 10)

On 7/28/14, Lucas Tanure wrote: > Hi Christoph, > > What kind of things that you think a newbie can fix ? You can start working on fixing the pci_map_* and dma_map_* return value checks with CONFIG_DMA_API_DEBUG enabled. A lot of drivers still missing that... > Thanks > -- > Lucas Tanure > +55 (

Re: [PATCH 1/1 linux-next] staging: ion: vm_insert_pfn and zap_page_range rely on CONFIG_MMU

> On 25 July 2014 at 00:02 Greg Kroah-Hartman > wrote: > > > On Wed, Jul 23, 2014 at 09:04:38PM +0200, Fabian Frederick wrote: > > Fix following sh-allmodconfig errors reported on kisskb > > " > > drivers/built-in.o: In function `ion_vm_fault': > > ion.c:(.text+0x1f2d8f8): undefined reference to

Re: Eudyptula Challenge (Task 10)

Hi Christoph, What kind of things that you think a newbie can fix ? Thanks -- Lucas Tanure +55 (19) 988176559 On Mon, Jul 28, 2014 at 9:53 AM, Christoph Hellwig wrote: > Can you folks please stop this challenge Bullshit? More checkpatch > fixes is not something we'll need at all. > > Thanks y

[PATCH] staging: dgnc: removes unused if defined code

DGNC_TRACER and TRC_TO_KMEM are never defined. This patch removes if defined DGNC_TRACER and TRC_TO_KMEM code. CC: Lidza Louina CC: Mark Hounschell Signed-off-by: Seunghun Lee --- drivers/staging/dgnc/dgnc_driver.c |4 --- drivers/staging/dgnc/dgnc_driver.h | 53

[PATCH v5] staging: unisys: move parahotplug to sysfs

Move the /proc/visorchipset/parahotplug interface to sysfs under /sys/devices/platform/visorchipset/parahotplug/deviceenabled and /sys/devices/platform/visorchipset/parahotplug/devicedisabled. The parahotplug interface is used to deal with SR-IOV recovery situations on s-Par guest partitions. The

Re: Eudyptula Challenge (Task 10)

Can you folks please stop this challenge Bullshit? More checkpatch fixes is not something we'll need at all. Thanks you! ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 6/7] staging: comedi: amplc_pc236: split into ISA, PCI and common module

The "amplc_pc236" driver currently handles both ISA and PCI devices and uses a small amount of conditional compilation depending which are enabled. Move most of the functionality into a new module, "amplc_pc236_common", and split off support for PCI devices into a new module, "amplc_pci236". Retai

[PATCH 3/7] staging: comedi: amplc_pc236: add callback to enable/disable interrupt

Add an optional callback function pointer to the board data to be called when interrupts are logically enabled or disabled to update the hardware registers. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pc236.c | 18 ++ 1 file changed, 14 insertions(+), 4 del

[PATCH 2/7] staging: comedi: amplc_pc236: don't disable h/w interrupt on detach()

If an asynchronous command was running when the device is being detached, the comedi core would have called the subdevice `cancel` handler (`pc236_intr_cancel()`) before calling the `detach` handler (`pc236_detach()`). Since the cancel handler disables hardware interrupts (at least for the PCI236

[PATCH 4/7] staging: comedi: amplc_pc236: combine interrupt enable/disable functions

`pc236_intr_enable()` and `pc236_intr_disable()` are very similar. Combine them into a single function `pc236_intr_update()` with a parameter to indicate whether interrupts are being enabled or disabled. Change type type of the `enable_irq` member of the private data to `bool` to match the paramet

[PATCH 0/7] staging: comedi: amplc_pc236: split into separate ISA and PCI drivers

The "amplc_pc236" module is a low-level comedi driver that handles both ISA boards (Amplicon PC36AT) and PCI boards (Amplicon PCI236). Since support for each is controlled by two separate kernel configuration options, the module needs a small number of CPP conditionals to handle the three differen

[PATCH 5/7] staging: comedi: amplc_pc236: add callback to check and clear interrupt

Add an optional callback function pointer to the board data to be called when checking if an interrupt has occurred and to clear it if it has. Since the callback returns `bool`, change a few other `int` values to `bool` to match. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/ampl

[PATCH 1/7] staging: comedi: amplc_pc236: move static board data

Move the static board data in `pc236_isa_boards[]` and `pc236_pci_board` closer to where they are used. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pc236.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/staging/comedi

[PATCH 7/7] staging: comedi: amplc_pc236, amplc_pci236: get rid of bustype

The `bustype` member of `struct pc236_board` variables is initialized, but never used. Remove it along with the enumerated constants associated with it. Signed-off-by: Ian Abbott --- drivers/staging/comedi/drivers/amplc_pc236.c | 1 - drivers/staging/comedi/drivers/amplc_pc236.h | 3 --- driv

[PATCH] staging: usbip: remove redundant return statements

Remove redundant return statements at the end of void functions. This addresses the checkpatch.pl warnings: WARNING: void function return statements are not generally useful #533: FILE: stub_rx.c:533: + return; +} #1125: FILE: vhci_hcd.c:1125: + return; +} #116: FILE: vhci_rx.c:116: +

经济动作的三不原则

经济动作的三不原则mP.xls Description: Binary data ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Re: [PATCH 1/3] staging: comedi: amplc_dio200_common: prevent extra free_irq()

On 2014-07-27 19:45, Greg Kroah-Hartman wrote: On Fri, Jul 25, 2014 at 06:23:10PM +, Hartley Sweeten wrote: On Friday, July 25, 2014 10:07 AM, Ian Abbott wrote: `dio200_detach()` in "amplc_dio200.c" calls `amplc_dio200_common_detach()` in "amplc_dio200_common.c", followed by `comedi_legacy_

[PATCH 1/1] drivers: staging: vt6655: ioctl.c - missing __user annotation

From: Anil Belur - private_ioctl() the internally calls copy_{to,from}_user() and does not use '__user' while refrencing user space pointers. - this patch passes __user annotation as a cast, when the pointer is being refernced. - this patch fixes the following sparse errors: drivers/staging/vt

Re: Eudyptula Challenge (Task 10)

Fix your From header and read paragraph 1 of Documentation/email-clients.txt regards, dan carpenter ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

Eudyptula Challenge (Task 10)

Hello Kernel Developers! I've attached a small patch to fix a coding style problem and make checkpatch happy, as part of challenge 10 of Eudyptula. Signed-off-by: Liviu Itoafa Thank you --- drivers/staging/lustre/lustre/ldlm/ldlm_extent.c.orig 2014-07-27 20:26:53.714161698 +0100 +++ dri