On Fri, Jul 25, 2014 at 03:37:41PM +0530, Arjun AK wrote:
> >From 8e7748dd81cf63c62dbef8f102e97da1d4d5d90a Mon Sep 17 00:00:00 2001
> From: Arjun AK
> Date: Fri, 25 Jul 2014 15:09:11 +0530
> Subject: [PATCH] Staging: unisys: Fix code style
Why is all of this here in this message?
>
> Fixes code
On Fri, Jul 25, 2014 at 10:08:06PM +0400, Denis Kirjanov wrote:
> On 7/25/14, Benjamin Romer wrote:
> > This patch cleans up the style, error handling, and string handling in the
> > sysfs
> > functions recently added to visorchipset:
>
> Split your changes and send one logical change per patch
On Fri, Jul 25, 2014 at 10:54:47PM +0100, Alan Cox wrote:
> On Fri, 2014-07-25 at 20:17 +0300, Kristina Martšenko wrote:
> > On 23/06/14 23:32, Kristina Martšenko wrote:
> > > Hi Mark,
> > >
> > > I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
> > > nobody seems to have w
Hi Guillaume
On 25/07/14 13:47, Guillaume Clement wrote:
Sparse reported that the data from tagSCmdRequest is given by
userspace, so it should be tagged as such.
extra is not in user space
All Wireless Extensions ioctl extra calls originate from
ioctl_standard_iw_point in wext-core.
Either
Hi Guillaume
On 25/07/14 13:47, Guillaume Clement wrote:
Sparse reported that the data from tagSCmdRequest is given by
userspace, so it should be tagged as such.
extra is not in user space
All Wireless Extensions ioctl extra calls originate from
ioctl_standard_iw_point in wext-core.
Either
On Fri, 2014-07-25 at 20:17 +0300, Kristina Martšenko wrote:
> On 23/06/14 23:32, Kristina Martšenko wrote:
> > Hi Mark,
> >
> > I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
> > nobody seems to have worked towards moving sep out of staging in over a
> > year. Are there
On Friday, July 25, 2014 10:07 AM, Ian Abbott wrote:
> `dio200_detach()` in "amplc_dio200.c" calls
> `amplc_dio200_common_detach()` in "amplc_dio200_common.c", followed by
> `comedi_legacy_detach()` in "../drivers.c". Both of those functions
> call `free_irq()` if `dev->irq` is non-zero. The seco
On Friday, July 25, 2014 10:07 AM, Ian Abbott wrote:
> Fix a double free_irq() and do a bit more cleaning up of the "detach"
> routines.
>
> 1) staging: comedi: amplc_dio200_common: prevent extra free_irq()
> 2) staging: comedi: amplc_dio200_common: remove some tests from
>amplc_dio200_common_d
On 7/25/14, Benjamin Romer wrote:
> This patch cleans up the style, error handling, and string handling in the
> sysfs
> functions recently added to visorchipset:
Split your changes and send one logical change per patch
>
> - Use of sscanf() was changed to type-appropriate kstrto*() functions
>
On Friday, July 25, 2014 10:37 AM, Hartley Sweeten wrote:
> On Friday, July 25, 2014 2:05 AM, Ian Abbott wrote:
>> The "amplc_pc236" driver supports both ISA cards (Amplicon PC36AT) and PCI
>> cards (PCI236). I plan to split it into separate drivers with a module for
>> common code, but let's reor
This patch cleans up the style, error handling, and string handling in the sysfs
functions recently added to visorchipset:
- Use of sscanf() was changed to type-appropriate kstrto*() functions
- error handling was simplified
- the error return value of visorchannel_write() was corrected
- switch u
On Friday, July 25, 2014 2:05 AM, Ian Abbott wrote:
> The "amplc_pc236" driver supports both ISA cards (Amplicon PC36AT) and PCI
> cards (PCI236). I plan to split it into separate drivers with a module for
> common code, but let's reorganise it a bit first.
>
> The driver still supports manual a
On 23/06/14 23:32, Kristina Martšenko wrote:
> Hi Mark,
>
> I'm helping Greg do a bit of cleanup in the staging tree. I noticed that
> nobody seems to have worked towards moving sep out of staging in over a
> year. Are there any plans to clean it up and move it out soon?
No response from Mark her
On Friday, July 25, 2014 2:05 AM, Ian Abbott wrote:
> Use preferred style for copyright and driver description comments.
>
> Signed-off-by: Ian Abbott
> ---
> drivers/staging/comedi/drivers/amplc_pc236.c | 92
> ++--
> 1 file changed, 46 insertions(+), 46 deletions(-)
>
>
On Fri, 2014-07-25 at 16:47 +, KY Srinivasan wrote:
>
> > -Original Message-
> > From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> > Sent: Thursday, July 24, 2014 8:54 AM
> > To: Sitsofe Wheeler
> > Cc: Martin K. Petersen; Christoph Hellwig; KY Srinivasan;
> > gre...@linux
`amplc_dio200_common_detach()` doesn't do much apart from freeing the
IRQ handler that was requested by `amplc_dio200_common_attach()` if
`dev->irq` is non-zero. There is no need to check if the pointer to
the constant board data or the pointer to private per-device data
exist, so remove those tes
`dio200_detach()` in "amplc_dio200.c" calls
`amplc_dio200_common_detach()` in "amplc_dio200_common.c", followed by
`comedi_legacy_detach()` in "../drivers.c". Both of those functions
call `free_irq()` if `dev->irq` is non-zero. The second call produces a
warning message because the handler has al
`dio200_pci_detach()` doesn't need to check if the pointer to constant
board data (`thisboard`) and the pointer to private per-device data
(`devpriv`) are valid before calling `amplc_dio200_common_detach()`. It
has no further need to check `thisboard` so remove the variable
altogether. Move the t
Fix a double free_irq() and do a bit more cleaning up of the "detach"
routines.
1) staging: comedi: amplc_dio200_common: prevent extra free_irq()
2) staging: comedi: amplc_dio200_common: remove some tests from
amplc_dio200_common_detach()
3) staging: comedi: amplc_dio200_pci: no need to test bo
> "KY" == KY Srinivasan writes:
KY> For the pass through case, the host validates the request and passes
KY> the request to the device. However, not all scsi commands are
KY> passed through even though the device it is being passed through may
KY> support the command. WRITE_SAME is one such
Removed redundant comments from power.h header file.
Signed-off-by: Igor Bezukh
---
drivers/staging/vt6655/power.h |9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/vt6655/power.h b/drivers/staging/vt6655/power.h
index ce56124..936f171 100644
--- a/drivers/staging/vt
Removed redundant comments from michael.h header file.
Signed-off-by: Igor Bezukh
---
drivers/staging/vt6655/michael.h |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/vt6655/michael.h b/drivers/staging/vt6655/michael.h
index f6c2c15..86cb140 100644
--- a/drivers/stagi
Removed redundant comments from mib.h header file.
Signed-off-by: Igor Bezukh
---
drivers/staging/vt6655/mib.h | 45 +++---
1 file changed, 16 insertions(+), 29 deletions(-)
diff --git a/drivers/staging/vt6655/mib.h b/drivers/staging/vt6655/mib.h
index c0a5
This patch removes commented code in dgnc driver.
CC: Lidza Louina
CC: Mark Hounschell
Signed-off-by: Seunghun Lee
---
drivers/staging/dgnc/dgnc_cls.c |5 +-
drivers/staging/dgnc/dgnc_trace.c | 123 -
drivers/staging/dgnc/dgnc_trace.h | 10 ---
driv
> -Original Message-
> From: Martin K. Petersen [mailto:martin.peter...@oracle.com]
> Sent: Thursday, July 24, 2014 8:54 AM
> To: Sitsofe Wheeler
> Cc: Martin K. Petersen; Christoph Hellwig; KY Srinivasan;
> gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproj
Removed redundant comments from mac.h header file.
Signed-off-by: Igor Bezukh
---
drivers/staging/vt6655/mac.h | 388 --
1 file changed, 188 insertions(+), 200 deletions(-)
diff --git a/drivers/staging/vt6655/mac.h b/drivers/staging/vt6655/mac.h
index 73
Removed redundant comments from key.h header file.
Signed-off-by: Igor Bezukh
---
drivers/staging/vt6655/key.h | 26 +++---
1 file changed, 7 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/vt6655/key.h b/drivers/staging/vt6655/key.h
index 4b8b4b6..f0cbd75 1006
Removed redundant comments from iwctl.h header file.
Signed-off-by: Igor Bezukh
---
drivers/staging/vt6655/iwctl.h | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/staging/vt6655/iwctl.h b/drivers/staging/vt6655/iwctl.h
index 871bd7c..83a5a2d 100644
---
Removed redundant comments from iowpa.h header file.
Signed-off-by: Igor Bezukh
---
drivers/staging/vt6655/iowpa.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/vt6655/iowpa.h b/drivers/staging/vt6655/iowpa.h
index b7bd190..772bc4c 100644
--- a/drivers/staging/
Removed redundant comments from ioctl.h header file.
Signed-off-by: Igor Bezukh
---
drivers/staging/vt6655/ioctl.h |8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/vt6655/ioctl.h b/drivers/staging/vt6655/ioctl.h
index 2f0db92..187fc91 100644
--- a/drivers/staging/vt6
Removed redundant comments from iocmd.h header file.
Signed-off-by: Igor Bezukh
---
drivers/staging/vt6655/iocmd.h | 23 +--
1 file changed, 1 insertion(+), 22 deletions(-)
diff --git a/drivers/staging/vt6655/iocmd.h b/drivers/staging/vt6655/iocmd.h
index e499f1b..ae037ec
Removed redundant comments from IEEE11h.h header file.
Signed-off-by: Igor Bezukh
---
drivers/staging/vt6655/IEEE11h.h | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/staging/vt6655/IEEE11h.h b/drivers/staging/vt6655/IEEE11h.h
index 8819fa1..5519220 100644
--- a/drivers/
Removed redundant comments from hostap.h header file.
Signed-off-by: Igor Bezukh
---
drivers/staging/vt6655/hostap.h |8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/vt6655/hostap.h b/drivers/staging/vt6655/hostap.h
index f1a4f2ef..6e801a4 100644
--- a/drivers/stagin
Removed redundant comments from dpc.h header file.
Signed-off-by: Igor Bezukh
---
drivers/staging/vt6655/dpc.h |8
1 file changed, 8 deletions(-)
diff --git a/drivers/staging/vt6655/dpc.h b/drivers/staging/vt6655/dpc.h
index 0ce3155..0c7e0e7 100644
--- a/drivers/staging/vt6655/dpc.
Removed redundant comments from device.h header file.
Signed-off-by: Igor Bezukh
---
drivers/staging/vt6655/device.h | 82 ++-
1 file changed, 21 insertions(+), 61 deletions(-)
diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
i
Removed redundant comments from device_cfg.h header file.
Signed-off-by: Igor Bezukh
---
drivers/staging/vt6655/device_cfg.h |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/vt6655/device_cfg.h
b/drivers/staging/vt6655/device_cfg.h
index 1137ade..6adc0dd 100644
--- a/dri
Removed redundant comments from desc.h header file.
Signed-off-by: Igor Bezukh
C99 style comments will be fixed in further patches.
---
drivers/staging/vt6655/desc.h | 185 +++--
1 file changed, 87 insertions(+), 98 deletions(-)
diff --git a/drivers/staging/
Removed redundant comments from datarate.h header file.
Signed-off-by: Igor Bezukh
---
drivers/staging/vt6655/datarate.h | 28 +---
1 file changed, 9 insertions(+), 19 deletions(-)
diff --git a/drivers/staging/vt6655/datarate.h
b/drivers/staging/vt6655/datarate.h
inde
Removed redundant comments from country.h header file
Signed-off-by: Igor Bezukh
---
drivers/staging/vt6655/country.h |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/vt6655/country.h b/drivers/staging/vt6655/country.h
index 415e767..2365fb1 100644
--- a/drivers/staging/vt66
Removed redundant comments from channel.h header file.
Signed-off-by: Igor Bezukh
---
drivers/staging/vt6655/channel.h |4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/vt6655/channel.h b/drivers/staging/vt6655/channel.h
index c9931d7..4f44c8a 100644
--- a/drivers/staging
Removed redundant comments from card.h header file.
Signed-off-by: Igor Bezukh
---
v2 changes: fixed diffstat output and fixed the
diff itself.
drivers/staging/vt6655/card.h | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/staging/vt6655/card.h b/driver
Signed-off-by: Sudip Mukherjee
---
drivers/staging/bcm/DDRInit.c | 59 ---
1 file changed, 39 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/bcm/DDRInit.c b/drivers/staging/bcm/DDRInit.c
index 4564f40..4226c93 100644
--- a/drivers/staging/bcm
On 07/17/2014 01:59 AM, Ben Chan wrote:
>
> From what I read from the user-space code, the custom ioctl is to read
> the following information from the driver:
>
> enum {
> SIOC_DATA_FSM, // Device/Connection State
> SIOC_DATA_NETLIST, // Network list
> SIOC_DATA_CONNN
On Fri, 2014-07-25 at 14:05 +0300, Dan Carpenter wrote:
> visorchannel_write() returns either 0 or -EFAULT so this condition is
> never true. This bug occurs in several places.
Thank you for catching my mistake. I'll fix this and change
visorchannel_write() to return -EIO as you suggested.
> Lo
Sparse reported that the data from tagSCmdRequest is given by
userspace, so it should be tagged as such.
Later, we were memcomparing and dereferencing it without first copying
it, fix that as well.
Signed-off-by: Guillaume Clement
---
drivers/staging/vt6655/iocmd.h | 2 +-
drivers/staging/vt66
On Fri, Jul 25, 2014 at 02:25:06PM +0200, Guillaume CLÉMENT wrote:
> On Fri, Jul 25, 2014 at 02:52:34PM +0300, Dan Carpenter wrote:
> > On Fri, Jul 25, 2014 at 01:07:40AM +0200, Guillaume Clement wrote:
> > > diff --git a/drivers/staging/vt6655/iwctl.c
> > > b/drivers/staging/vt6655/iwctl.c
> > >
On Fri, Jul 25, 2014 at 02:52:34PM +0300, Dan Carpenter wrote:
> On Fri, Jul 25, 2014 at 01:07:40AM +0200, Guillaume Clement wrote:
> > diff --git a/drivers/staging/vt6655/iwctl.c b/drivers/staging/vt6655/iwctl.c
> > index 501cd64..9291259 100644
> > --- a/drivers/staging/vt6655/iwctl.c
> > +++ b/d
On Fri, Jul 25, 2014 at 01:07:40AM +0200, Guillaume Clement wrote:
> diff --git a/drivers/staging/vt6655/iwctl.c b/drivers/staging/vt6655/iwctl.c
> index 501cd64..9291259 100644
> --- a/drivers/staging/vt6655/iwctl.c
> +++ b/drivers/staging/vt6655/iwctl.c
> @@ -1621,14 +1621,17 @@ int iwctl_giwauth
On 2014-07-24 18:14, H Hartley Sweeten wrote:
Start cleaning up this driver by:
1) fix all the checkpatch.pl warnings
WARNING: line over 80 characters
WARNING: Unnecessary space before function pointer arguments
WARNING: Prefer [foo]_err to printk(KERN_ERR ...
2) remove a
On Fri, Jul 25, 2014 at 01:06:14AM +0200, Guillaume Clement wrote:
> This patchset fixes a lot of minor checkpatch and sparse warnings.
These look nice.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdr
On Thu, Jul 24, 2014 at 02:08:46PM -0400, Benjamin Romer wrote:
> + if (kstrtouint(buf, 10, &id) != 1)
> return -EINVAL;
Obviously this doesn't work. Btw, you should update your test suite to
prevent this kind of embarassing typo in the future. ;)
Also I was reviewing enable_i
On Thu, Jul 24, 2014 at 02:08:42PM -0400, Benjamin Romer wrote:
> +static ssize_t error_store(struct device *dev, struct device_attribute *attr,
> + const char *buf, size_t count)
> +{
> + u32 error;
> +
> + if (sscanf(buf, "%i\n", &error) == 1) {
> + if (visorchanne
On Fri, Jul 25, 2014 at 12:26:51AM +0900, Seunghun Lee wrote:
> This patch fixes a checkpatch errors
> "Macros with complex values should be enclosed in parenthesis"
>
> Signed-off-by: Seunghun Lee
> ---
> drivers/staging/dgnc/dgnc_driver.h | 40
> drivers/staging/dgnc
On Fri, Jul 25, 2014 at 03:37:41PM +0530, Arjun AK wrote:
> >From 8e7748dd81cf63c62dbef8f102e97da1d4d5d90a Mon Sep 17 00:00:00 2001
> From: Arjun AK
> Date: Fri, 25 Jul 2014 15:09:11 +0530
> Subject: [PATCH] Staging: unisys: Fix code style
>
> Fixes code style in multiple files
>
> Signed-off-by
>From 8e7748dd81cf63c62dbef8f102e97da1d4d5d90a Mon Sep 17 00:00:00 2001
From: Arjun AK
Date: Fri, 25 Jul 2014 15:09:11 +0530
Subject: [PATCH] Staging: unisys: Fix code style
Fixes code style in multiple files
Signed-off-by: Arjun AK
---
drivers/staging/unisys/channels/chanstub.c | 2
The `PCI_DEVICE_ID_AMPLICON_PCI236` macro is only used once, in the
module device table, so remove it and expand the macro in the table.
`The `PCI_DEVICE_ID_INVALID` macro is no longer used, so remove it.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/amplc_pc236.c | 8 ++--
1
Split `pc236_boards[]` into `pc236_isa_boards[]` for ISA cards and
`pc236_pci_boards[]` for PCI cards (there is only one of each). Only
initialize the board name look-up members of `struct comedi_driver
amplc_pc236_driver` if the ISA part of the driver is enabled in the
kernel config (`CONFIG_COME
Since only a single PCI board is supported by the driver, there is no
need to call `pc236_find_pci_board()` to find the a board entry with
matching PCI device ID in `pc236_pci_boards[]`. Just point to the entry
directly and remove the look-up function. In fact, there is no reason
for `pc236_pci_b
Absorb `pc236_pci_common_attach()` into `pc236_auto_attach()` since
that's the only place it is called from.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/amplc_pc236.c | 26 +-
1 file changed, 9 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/
Remove the code that allows PCI boards to be manually attached by the
`COMEDI_DEVCONFIG` ioctl (or the "comedi_config" application).
Supported PCI boards (PCI236) will be attached automatically at probe
time via `comedi_pci_auto_config()` and the `auto_attach` hook in the
`struct comedi_driver`.
T
The call to `comedi_set_hw_dev()` from `pc236_pci_common_attach()` is
now unnecessary since `pc236_pci_common_attach()` is now only called
from this driver's `auto_attach` hook `pc236_auto_attach()` and the
comedi core now calls `comedi_set_hw_dev()` before calling that. Remove
the unnecessary cal
The "amplc_pc236" driver supports both ISA cards (Amplicon PC36AT) and PCI
cards (PCI236). I plan to split it into separate drivers with a module for
common code, but let's reorganise it a bit first.
The driver still supports manual attachment of PCI devices via the
`COMEDI_DEVCONFIG` ioctl and t
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/amplc_pc236.c | 21 -
1 file changed, 21 deletions(-)
diff --git a/drivers/staging/comedi/drivers/amplc_pc236.c
b/drivers/staging/comedi/drivers/amplc_pc236.c
index 9d64e45..7600319 100644
--- a/drivers/staging/com
The `model` member of `struct pc236_board` is no longer used since the
code to remove manual configuration of PCI devices was removed. Get rid
of it.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/amplc_pc236.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging
Since the legacy attach routine `pc236_attach()` is only called for
board names matching an entry in our array of ISA boards
`pc236_isa_boards[]`, and it is reasonable to expect all elements of
`pc236_isa_boards[]` to have their `bustype` member initialized
correctly to `isa_bustype`, don't bother
For PCI boards, the `auto_attach` handler, `pc236_auto_attach()`,
initializes `dev->board_ptr` to point to a `struct pc236_board`, but
leaves `dev->board_name` unchanged. The Comedi core will have
initialized `dev->board_name` to the `driver_name` string member of
`amplc_pc236_driver`. For consis
Now that this driver no longer supports "manual" attachment of PCI
devices in its `attach` hook (`pc236_attach()`), it no longer has code
that searches for a suitable PCI device and increments its reference
count. Since the driver no longer has any reason for incrementing and
decrementing the PCI
Use preferred style for copyright and driver description comments.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/amplc_pc236.c | 92 ++--
1 file changed, 46 insertions(+), 46 deletions(-)
diff --git a/drivers/staging/comedi/drivers/amplc_pc236.c
b/drivers
> -Original Message-
> From: gre...@linuxfoundation.org [mailto:gre...@linuxfoundation.org]
> Sent: Thursday, July 24, 2014 11:53 AM
> > So, hi Greg and all,
> > If you think the patch itself is OK, may I know if it's OK for the patch to
> > go
> > into Greg's char-misc.git tree, as some o
69 matches
Mail list logo
