Re: [PATCH] staging: Change kzalloc to kcalloc

On 07/25/2014 11:39 AM, Nick Krause wrote: > On Thu, Jul 24, 2014 at 11:34 PM, Chen Gang wrote: >> >> >> On 07/25/2014 11:30 AM, Nick Krause wrote: >>> On Thu, Jul 24, 2014 at 11:21 PM, Chen Gang >>> wrote: On 07/25/2014 11:13 AM, Nick Krause wrote: > On Thu, Jul 24, 2014 at

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 11:34 PM, Chen Gang wrote: > > > On 07/25/2014 11:30 AM, Nick Krause wrote: >> On Thu, Jul 24, 2014 at 11:21 PM, Chen Gang wrote: >>> >>> >>> On 07/25/2014 11:13 AM, Nick Krause wrote: On Thu, Jul 24, 2014 at 11:09 PM, Chen Gang wrote: > > > On 07/2

Re: [PATCH] staging: Change kzalloc to kcalloc

On 07/25/2014 11:30 AM, Nick Krause wrote: > On Thu, Jul 24, 2014 at 11:21 PM, Chen Gang wrote: >> >> >> On 07/25/2014 11:13 AM, Nick Krause wrote: >>> On Thu, Jul 24, 2014 at 11:09 PM, Chen Gang >>> wrote: On 07/25/2014 10:53 AM, Nick Krause wrote: > On Thu, Jul 24, 2014 at

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 11:21 PM, Chen Gang wrote: > > > On 07/25/2014 11:13 AM, Nick Krause wrote: >> On Thu, Jul 24, 2014 at 11:09 PM, Chen Gang wrote: >>> >>> >>> On 07/25/2014 10:53 AM, Nick Krause wrote: On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang wrote: > > > On 07/2

Re: [PATCH] staging: Change kzalloc to kcalloc

On 07/25/2014 11:13 AM, Nick Krause wrote: > On Thu, Jul 24, 2014 at 11:09 PM, Chen Gang wrote: >> >> >> On 07/25/2014 10:53 AM, Nick Krause wrote: >>> On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang >>> wrote: On 07/25/2014 10:20 AM, Nick Krause wrote: > On Thu, Jul 24, 2014 at

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 11:09 PM, Chen Gang wrote: > > > On 07/25/2014 10:53 AM, Nick Krause wrote: >> On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang wrote: >>> >>> >>> On 07/25/2014 10:20 AM, Nick Krause wrote: On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang wrote: > > Excuse me, I

Re: [PATCH] staging: Change kzalloc to kcalloc

On 07/25/2014 10:53 AM, Nick Krause wrote: > On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang wrote: >> >> >> On 07/25/2014 10:20 AM, Nick Krause wrote: >>> On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang >>> wrote: Excuse me, I did not see the patch details, but I guess it is about whet

[PATCH 0/2 v4] staging: unisys: visorchipset proc fixes

This patch set moves the parahotplug interface in the visorchipset module from procfs to sysfs, and removes the visorchipset/partition tree from proc. It also includes some code cleanup in the new sysfs handler functions. In version 4 of the set, the accidental inclusion of a change to the Makefil

[PATCH 1/2 v4] staging: unisys: remove partition information from proc

Debugging information for the guest's channels was being exposed in proc. Remove the code that creates these entries, which are no longer needed. Signed-off-by: Benjamin Romer --- v4: this patch accidentally picked up a Makefile change intended only for testing. The change was removed. v3: patch

[PATCH 2/2 v4] staging: unisys: move parahotplug to sysfs

Move the /proc/visorchipset/parahotplug interface to sysfs under /sys/devices/platform/visorchipset/parahotplug/deviceenabled and /sys/devices/platform/visorchipset/parahotplug/devicedisabled. The parahotplug interface is used to deal with SR-IOV recovery situations on s-Par guest partitions. The

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 10:47 PM, Chen Gang wrote: > > > On 07/25/2014 10:20 AM, Nick Krause wrote: >> On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang wrote: >>> >>> Excuse me, I did not see the patch details, but I guess it is about >>> whether welcome a new member to upstream kernel. For me, I have

Re: [PATCH] staging: Change kzalloc to kcalloc

On 07/25/2014 10:20 AM, Nick Krause wrote: > On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang wrote: >> >> Excuse me, I did not see the patch details, but I guess it is about >> whether welcome a new member to upstream kernel. For me, I have 3 ideas >> about it if I am a newbie or a normal kernel dev

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 10:15 PM, Chen Gang wrote: > > Excuse me, I did not see the patch details, but I guess it is about > whether welcome a new member to upstream kernel. For me, I have 3 ideas > about it if I am a newbie or a normal kernel developer: > > - Do I have enough basic skills for it

Re: [PATCH] staging: Change kzalloc to kcalloc

Excuse me, I did not see the patch details, but I guess it is about whether welcome a new member to upstream kernel. For me, I have 3 ideas about it if I am a newbie or a normal kernel developer: - Do I have enough basic skills for it? - Do I developed one or more another real world project

[PATCH] staging: rtl8188eu: Fix static symbol sparse warnings

Fix sparse warnings: drivers/staging/rtl8188eu/core/rtw_cmd.c:52:5: warning: symbol '_rtw_enqueue_cmd' was not declared. Should it be static? drivers/staging/rtl8188eu/core/rtw_wlan_util.c:1225:5: warning: symbol 'wifirate2_ratetbl_inx' was not declared. Should it be static? drivers/staging/rtl

[PATCH 07/14] staging: vt6655: Use pr_* functions instead of printk

Lots of printk are used in vt6655, replace them with the pr_* equivalent. Signed-off-by: Guillaume Clement --- drivers/staging/vt6655/card.c| 12 +++--- drivers/staging/vt6655/device_cfg.h | 2 +- drivers/staging/vt6655/device_main.c | 71 ++-- drivers/s

[PATCH 08/14] staging: vt6655: break single line if statements

This fixes the "trailing statements should be on next line" checkpatch warning. Signed-off-by: Guillaume Clement --- drivers/staging/vt6655/card.c| 6 -- drivers/staging/vt6655/device_main.c | 6 -- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/staging/vt

[PATCH 03/14] staging: vt6655: Remove spaces before quoted newlines

This fixes several spaces added just before a newline in debug strings, reported by checkpatch. Signed-off-by: Guillaume Clement --- drivers/staging/vt6655/card.c| 2 +- drivers/staging/vt6655/device_main.c | 53 - drivers/staging/vt6655/dpc.c | 13 --

[PATCH 11/14] staging: vt6655: remove braces for single statements if

This fixes several "braces {} are not necessary for single statement blocks" checkpatch warnings. Signed-off-by: Guillaume Clement --- drivers/staging/vt6655/power.c | 3 +-- drivers/staging/vt6655/vntwifi.c | 3 +-- drivers/staging/vt6655/wmgr.c| 3 +-- 3 files changed, 3 insertions(+), 6

[PATCH] staging: vt6655: tag data as __user in struct tagSCmdRequest

Sparse reported that the data from tagSCmdRequest is given by userspace, so it should be tagged as such. Later, we were memcomparing and dereferencing it without first copying it, fix that as well. Signed-off-by: Guillaume Clement --- drivers/staging/vt6655/iocmd.h | 2 +- drivers/staging/vt66

[PATCH 10/14] staging: vt6655: add missing whitespace

Some whitespace were missing, causing checkpatch warnings and altering readability. Signed-off-by: Guillaume Clement --- drivers/staging/vt6655/device_main.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6

[PATCH 14/14] staging: vt6655: Remove NULL pointer sparse warning

We were using 0 instead of NULL to initialize a pointer, which caused a sparse warning. Signed-off-by: Guillaume Clement --- drivers/staging/vt6655/device_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/dev

[PATCH 09/14] staging: vt6655: Remove unreachable break statements

This fixes break "break is not useful after a goto or return" checkpatch warnings. Signed-off-by: Guillaume Clement --- drivers/staging/vt6655/rf.c | 2 -- drivers/staging/vt6655/wpa.c | 1 - 2 files changed, 3 deletions(-) diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c

[PATCH 04/14] staging: vt6655: fix function braces not on the proper line

Function braces should be on a separate line. Reported by checkpatch. Signed-off-by: Guillaume Clement --- drivers/staging/vt6655/device_main.c | 90 drivers/staging/vt6655/rxtx.c| 6 ++- 2 files changed, 64 insertions(+), 32 deletions(-) diff --git

[PATCH 13/14] staging: vt6655: remove unused macro

The MAC_MAX_CONTEXT_SIZE macro was not enclosed into parenthesis, which might have caused hard to debug errors, and caused a sparse warning. Since it is unused, we might as well remove it. Signed-off-by: Guillaume Clement --- drivers/staging/vt6655/mac.h | 1 - 1 file changed, 1 deletion(-) di

[PATCH 12/14] staging: vt6655: fix braces at newline in if statements

Braces should not be in a separate line for multi-line if statements. This fixes warnings reported by checkpatch. Signed-off-by: Guillaume Clement --- drivers/staging/vt6655/wcmd.c | 5 +++-- drivers/staging/vt6655/wpa.c | 8 2 files changed, 7 insertions(+), 6 deletions(-) diff --git

[PATCH 02/14] staging: vt6655: Add missing blank lines after declarations

This patch fixes the missing blank lines after declarations in vt6655 reported by checkpatch. Signed-off-by: Guillaume Clement --- drivers/staging/vt6655/80211mgr.c| 1 + drivers/staging/vt6655/baseband.c| 1 + drivers/staging/vt6655/bssdb.c | 7 +++ drivers/staging/vt6655/c

[PATCH 00/14] staging: vt6655: Sparse and checkpatch fixes

This patchset fixes a lot of minor checkpatch and sparse warnings. ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH 06/14] staging: vt6655: fix static position in inline function

This should be "static inline", not "inline static". Reported by checkpatch. Signed-off-by: Guillaume Clement --- drivers/staging/vt6655/device.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h index 7c7fec

[PATCH 05/14] staging: vt6655: fix braces at newline for structs

For structs definitions, the braces should be at the end of the line. Reported by checkpatch. Signed-off-by: Guillaume Clement --- drivers/staging/vt6655/bssdb.h | 3 +-- drivers/staging/vt6655/device.h | 15 +-- drivers/staging/vt6655/key.h| 9 +++-- drivers/staging/vt665

[PATCH 01/14] staging: vt6655: remove useless return statements

Many return statements in void function were present at the end of functions, with no effect. They now are removed. This fixes a bunch of checkpatch warnings. Signed-off-by: Guillaume Clement --- drivers/staging/vt6655/80211mgr.c| 36 --- drivers/staging/vt6655/b

Re: [PATCH 4/6 v3] staging: unisys: remove partition information from proc

Greg KH wrote: > > Really > Obviously not, I'm sorry. :( ___ devel mailing list de...@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

[PATCH] staging/lustre: Fix sparse error (signature mismatch)

lprocfs_wr_atomic is defined in drivers/staging/lustre/lustre/obdclass/lprocfs_status.c with its second argument with the __user attribute: int lprocfs_wr_atomic(struct file *file, const char __user *buffer, unsigned long count, void *data) but its declaration in drivers/staging/lus

Re: [PATCH] Staging: vt6655: remove redundant comments from card.h

On Thu, Jul 24, 2014 at 09:50:14PM +0300, Igor Bezukh wrote: > Removed redundant comments from card.h header file. > > Signed-off-by: Igor Bezukh > --- > drivers/staging/vt6655/80211hdr.h |7 --- > drivers/staging/vt6655/80211mgr.h | 38 > - > drive

Re: [PATCH 0/6 v3] staging: unisys: visorchipset proc fixes

On Thu, Jul 24, 2014 at 02:08:41PM -0400, Benjamin Romer wrote: > This patch set moves several interfaces in the visorchipset module from procfs > to sysfs, and removes the remaining proc interfaces from the module. It > includes > documentation for the new interfaces in Documentation/ABI, and som

Re: [PATCH 4/6 v3] staging: unisys: remove partition information from proc

On Thu, Jul 24, 2014 at 02:08:45PM -0400, Benjamin Romer wrote: > Debugging information for the guest's channels was being exposed in proc. > Remove the code that creates these entries, which are no longer needed. > > Signed-off-by: Benjamin Romer > --- > v3: patch location changed due to prior p

Re: [PATCH 1/1 linux-next] staging: ion: vm_insert_pfn and zap_page_range rely on CONFIG_MMU

On Wed, Jul 23, 2014 at 09:04:38PM +0200, Fabian Frederick wrote: > Fix following sh-allmodconfig errors reported on kisskb > " > drivers/built-in.o: In function `ion_vm_fault': > ion.c:(.text+0x1f2d8f8): undefined reference to `vm_insert_pfn' > drivers/built-in.o: In function `ion_buffer_sync_for_

Re: [PATCH] staging: Change kzalloc to kcalloc

Am 24.07.2014 21:05, schrieb Nick Krause: > On Thu, Jul 24, 2014 at 2:55 PM, Nick Krause wrote: >> On Thu, Jul 24, 2014 at 2:49 PM, Richard Weinberger >> wrote: >>> On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause wrote: Steve, I have programming a lot in other areas just not the kernel. >

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 2:55 PM, Nick Krause wrote: > On Thu, Jul 24, 2014 at 2:49 PM, Richard Weinberger > wrote: >> On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause wrote: >>> Steve, >>> I have programming a lot in other areas just not the kernel. >>> You are right through I need to test my code b

[PATCH] Staging: vt6655: remove redundant comments from card.h

Removed redundant comments from card.h header file. Signed-off-by: Igor Bezukh --- drivers/staging/vt6655/80211hdr.h |7 --- drivers/staging/vt6655/80211mgr.h | 38 - drivers/staging/vt6655/aes_ccmp.h |9 - drivers/staging/vt6655/baseband

[PATCH] staging: quickstart: remove driver

The driver hasn't been cleaned up and it doesn't look like anyone is working on it anymore (including the original author). So remove the driver from the kernel. If someone wants to work on cleaning it up and moving it out of staging, this commit can be reverted. Signed-off-by: Kristina Martšenko

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 2:49 PM, Richard Weinberger wrote: > On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause wrote: >> Steve, >> I have programming a lot in other areas just not the kernel. >> You are right through I need to test my code better through. > > Nick, > > let's make a deal. > Take the ch

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 8:41 PM, Nick Krause wrote: > Steve, > I have programming a lot in other areas just not the kernel. > You are right through I need to test my code better through. Nick, let's make a deal. Take the challenge at http://eudyptula-challenge.org. After you've solved all tasks

[PATCH] Staging: vt6655: remove redundant comments from bssdb.h

Removed redundant comments from bssdb.h header file. Signed-off-by: Igor Bezukh --- drivers/staging/vt6655/bssdb.h | 25 ++--- 1 file changed, 2 insertions(+), 23 deletions(-) diff --git a/drivers/staging/vt6655/bssdb.h b/drivers/staging/vt6655/bssdb.h index a0938b7..9337a

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 1:48 PM, Steven Rostedt wrote: > On Thu, 24 Jul 2014 10:30:51 -0700 > Harvey Harrison wrote: > >> On Thu, Jul 24, 2014 at 10:18 AM, Steven Rostedt wrote: >> > On Thu, 24 Jul 2014 12:50:31 -0400 >> > Nick Krause wrote: >> >> > >> >> I am have this discussion with other ke

[PATCH] Staging: vt6655: remove redundant comments from baseband.h

Removed redundant comments in baseband.h header file. Signed-off-by: Igor Bezukh --- drivers/staging/vt6655/baseband.h | 12 1 file changed, 12 deletions(-) diff --git a/drivers/staging/vt6655/baseband.h b/drivers/staging/vt6655/baseband.h index e31bb76..d90c7f9 100644 --- a/dri

Re: Subject: [PATCH 6/6 v3] staging: unisys: ABI documentation for new sysfs entries

Please disregard this specific email - "Subject: [PATCH 6/6 v3] staging: unisys: ABI documentation for new sysfs entries" - the subject was corrected and this individual patch was resent. Sorry for any confusion. -- Ben ___ devel mailing list de...@linu

[PATCH 6/6 v3] staging: unisys: ABI documentation for new sysfs entries

This patch adds a documentation file for all of the interfaces that were moved to sysfs by the other patches in this set. Signed-off-by: Benjamin Romer --- v3: documentation was revised based on changes in earlier patches. v2: whitespace errors were corrected. .../Documentation/ABI/sysfs-platfo

[PATCH 0/6 v3] staging: unisys: visorchipset proc fixes

This patch set moves several interfaces in the visorchipset module from procfs to sysfs, and removes the remaining proc interfaces from the module. It includes documentation for the new interfaces in Documentation/ABI, and some code cleanup in the new sysfs handler functions. In version 3 of the s

[PATCH 4/6 v3] staging: unisys: remove partition information from proc

Debugging information for the guest's channels was being exposed in proc. Remove the code that creates these entries, which are no longer needed. Signed-off-by: Benjamin Romer --- v3: patch location changed due to prior patches being revised. v2: patch location changed due to prior patches being

[PATCH 2/6 v3] staging: unisys: move chipsetready to sysfs

Move the chipsetready proc entry to sysfs under a new directory guest. This entry is used by Unisys application software on the guest to acknowledge completion of specific events for integration purposes, but these acknowledgements are not required for the guest to operate correctly. The store fun

[PATCH 1/6 v3] staging: unisys: move installer to sysfs and split fields

The installer entry in /proc/visorchipset/installer was composed of three separate fields as one entry. This patch removes the proc entry and associated functions, and creates new fields with distinct entries under sysfs in the visorchipset/install directory. The fields are: textid: used t

[PATCH 5/6 v3] staging: unisys: move parahotplug to sysfs

Move the /proc/visorchipset/parahotplug interface to sysfs under /sys/devices/platform/visorchipset/parahotplug/deviceenabled and /sys/devices/platform/visorchipset/parahotplug/devicedisabled. The parahotplug interface is used to deal with SR-IOV recovery situations on s-Par guest partitions. The

Subject: [PATCH 6/6 v3] staging: unisys: ABI documentation for new sysfs entries

This patch adds a documentation file for all of the interfaces that were moved to sysfs by the other patches in this set. Signed-off-by: Benjamin Romer --- v3: documentation was revised based on changes in earlier patches. v2: whitespace errors were corrected. .../Documentation/ABI/sysfs-platfo

[PATCH 3/6 v3] staging: unisys: clean up diagdump proc entry code

Remove remnant code left over from the diagdump proc entry. Signed-off-by: Benjamin Romer --- v3: patch locations changed due to prior patches being revised. v2: patch locations changed due to prior patches being revised. drivers/staging/unisys/visorchipset/visorchipset_main.c | 8 +--- 1 f

Re: [PATCH 2/3] [SCSI] storvsc: Add Hyper-V logical block provisioning tests

On Thu, Jul 24, 2014 at 02:09:11PM +, James Bottomley wrote: > On Thu, 2014-07-24 at 08:56 +0100, Sitsofe Wheeler wrote: > > Microsoft Hyper-V targets currently only claim SPC-2 compliance / no > > compliance indicated even though they implement post SPC-2 features > > which means those feature

[PATCH] staging: phison: remove driver

The driver hasn't been cleaned up and it doesn't look like anyone is working on it anymore (including the original author). So remove the driver from the kernel. If someone wants to work on cleaning it up and moving it out of staging, this commit can be reverted. Signed-off-by: Kristina Martšenko

Re: [PATCH 1/3] staging: dgng: Fix Macros with complex values should be enclosed in parenthesis

On Fri, 2014-07-25 at 00:26 +0900, Seunghun Lee wrote: > This patch fixes a checkpatch errors > "Macros with complex values should be enclosed in parenthesis" [] > diff --git a/drivers/staging/dgnc/dgnc_driver.h > b/drivers/staging/dgnc/dgnc_driver.h > @@ -111,32 +111,32 @@ > #endif > > #if d

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, 24 Jul 2014 10:30:51 -0700 Harvey Harrison wrote: > On Thu, Jul 24, 2014 at 10:18 AM, Steven Rostedt wrote: > > On Thu, 24 Jul 2014 12:50:31 -0400 > > Nick Krause wrote: > > > > >> I am have this discussion with other kernel developers and just > >> because I send out one patch as a ne

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, Jul 24, 2014 at 10:18 AM, Steven Rostedt wrote: > On Thu, 24 Jul 2014 12:50:31 -0400 > Nick Krause wrote: > >> I am have this discussion with other kernel developers and just >> because I send out one patch as a newbie like this doesn't mean I >> don't known C. > > It's not just one patc

Re: [PATCH] staging: Change kzalloc to kcalloc

On Thu, 24 Jul 2014 12:50:31 -0400 Nick Krause wrote: \ > > Most kernel devs most certainly did NOT get started by spamming lkml > > with unnecessary and incorrect patches despite being repeatedly told to > > go away and stop wasting everybody's time. Mans, shut up! That is uncalled for. > > >

[PATCH 22/40] staging: comedi: ni_tio: tidy up enum ni_660x_gate_select

These values are not used as an enum. For aesthetics, rename the CamelCase values and convert them into defines. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 27 +-- 1 file changed, 13 insertions(+)

[PATCH 35/40] staging: comedi: ni_tio: tidy up ni_tio_set_gate_src() and helpers

Do some renaming of local vars, parameters, etc. to tidy up the ugly line breaks to improve the readability of the code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 68 ++--- 1 file changed, 29

[PATCH 27/40] staging: comedi: ni_tio: tidy up ni_tio_init_counter()

This function is called to initialize/reset a gpct counter during a comedi drivers (*attach). For aesthetics, move this exported function toward the end of the file. Tidy up the functions a bit by just open coding the '0x0' values used to initialize some of the registers. Signed-off-by: H Hartle

[PATCH 38/40] staging: comedi: ni_tio: tidy up ni_tio_set_clock_src() and helpers

Do some renaming of local vars, etc. to tidy up the ugly line breaks to improve the readability of the code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 38 + 1 file changed, 15 insertions(

[PATCH 23/40] staging: comedi: ni_tio: tidy up enum ni_m_series_clock_source

These values are not used as an enum. For aesthetics, rename the CamelCase values and convert them into defines. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 62 - 1 file changed, 31 inserti

[PATCH 15/40] staging: comedi: ni_tio: convert NI_660x_RTSI_Clock() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 10 +++--- 1 file changed, 3 inser

[PATCH 05/40] staging: comedi: ni_tio: tidy up ni_660x_set_second_gate()

Rename some of the local vars and tidy up this function to fix to fix a couple > 80 char line issues. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 39 - 1 file changed, 14 insertions(+), 25

[PATCH 24/40] staging: comedi: ni_tio: tidy up enum ni_660x_clock_source

These values are not used as an enum. For aesthetics, rename the CamelCase values and convert them into defines. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 49 - 1 file changed, 23 inserti

[PATCH 07/40] staging: comedi: ni_tio: tidy up ni_660x_set_first_gate()

Rename some of the local vars and tidy up this function to fix to fix a couple > 80 char line issues. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 25 ++--- 1 file changed, 10 insertions(+), 15 deletion

[PATCH 30/40] staging: comedi: ni_tio: tidy up ni_660x_source_select_bits()

Rename a local variable to fix the > 80 char line issues. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_tio.c b

[PATCH 08/40] staging: comedi: ni_tio: convert NI_M_Series_RTSI_Clock() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 11 +++ 1 file changed, 3 inse

[PATCH 04/40] staging: comedi: ni_tio: remove unnecessary ni_gpct_variant BUG() cases

The enum ni_gpct_variant is used to handle hardware variations in the gpct timers handled by this driver. This enum is defined as: enum ni_gpct_variant { ni_gpct_variant_e_series, ni_gpct_variant_m_series, ni_gpct_variant_660x }; For all the switch statements where all thr

[PATCH 40/40] staging: comedi: ni_tio: convert printk to pr_err

Convert the printk(KERN_ERR ...) in ni_m_clk_src() to a pr_err(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/dr

[PATCH 12/40] staging: comedi: ni_tio: convert NI_M_Series_RTSI_Gate_Select() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 12 ++-- 1 file changed, 2 ins

[PATCH 02/40] staging: comedi: ni_tio: fix > 80 char comments

Tidy up some of the comments to fix some fo the the checkpatch.pl warnings: WARNING: line over 80 characters Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 44 - 1 file changed, 32 insertions

[PATCH 25/40] staging: comedi: ni_tio: move defines to head of file

For aesthetics, move all the defines to the head of the file. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 131 1 file changed, 67 insertions(+), 64 deletions(-) diff --git a/drivers/stagi

[PATCH 33/40] staging: comedi: ni_tio: tidy up ni_tio_get_gate_src() and helpers

Do some renaming of local vars, parameters, etc. to tidy up the ugly line breaks to improve the readability of the code. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 90 ++--- 1 file changed, 37

[PATCH 13/40] staging: comedi: ni_tio: convert NI_M_Series_PFI_Gate_Select() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 13 ++--- 1 file changed, 2 in

[PATCH 34/40] staging: comedi: ni_tio: tidy up ni_tio_set_other_src()

Invert the counter_dev->variant test to reduce the indent level of this function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 50 - 1 file changed, 24 insertions(+), 26 deletions(-) diff -

[PATCH 39/40] staging: comedi: ni_tio: remove forward declarations

Move some of the functions to remove the need for the forward declarations. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 392 1 file changed, 194 insertions(+), 198 deletions(-) diff --git

[PATCH 20/40] staging: comedi: ni_tio: tidy up enum ni_660x_second_gate_select

These values are not used as an enum. For aesthetics, rename the CamelCase values and convert them into defines. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 31 +++ 1 file changed, 15 insertion

[PATCH 37/40] staging: comedi: ni_tio: tidy up ni_tio_get_clock_src()

Remove the static const local variable and add a blank line after the declarations. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/

[PATCH 21/40] staging: comedi: ni_tio: tidy up enum ni_m_series_gate_select

These values are not used as an enum. For aesthetics, rename the CamelCase values and convert them into defines. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 37 - 1 file changed, 18 inserti

[PATCH 19/40] staging: comedi: ni_tio: remove counter_status_mask

For aesthetics, remove this global static const varaible. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/driver

[PATCH 01/40] staging: comedi: ni_tio: fix ni_tio_insn_read()

The comedi core expects the (*insn_read) operations to read insn->n values and return the number of values read. Fix this function to work line the core expects. For aesthetics, factor out the code that reads the SM_Save_Reg. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartm

[PATCH 06/40] staging: comedi: ni_tio: tidy up ni_m_series_set_first_gate()

Rename some of the local vars and tidy up this function to fix to fix a couple > 80 char line issues. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 23 +-- 1 file changed, 9 insertions(+), 14 deletions(-

[PATCH 11/40] staging: comedi: ni_tio: convert NI_660x_RTSI_Gate_Select() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 9 ++--- 1 file changed, 2 inserti

[PATCH 17/40] staging: comedi: ni_tio: convert NI_660x_Up_Down_Pin_Second_Gate_Select() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 11 ++- 1 file changed, 2 inse

[PATCH 14/40] staging: comedi: ni_tio: convert NI_660x_Source_Pin_Clock() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 10 +++--- 1 file changed, 3 inser

[PATCH 26/40] staging: comedi: ni_tio: tidy up ni_gpct_device_{construct, destroy)()

For aesthetics, move these exported functions to the end of the file. Tidy up the functions a bit and remove the BUG_ON when (num_counters == 0). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 101 +-

[PATCH 29/40] staging: comedi: ni_tio: tidy up ni_m_series_source_select_bits()

Rename a local variable to fix the > 80 char line issues. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_tio.c b

[PATCH 36/40] staging: comedi: ni_tio: absorb ni_tio_set_first_gate_modifiers()

This function is only called by ni_tio_set_gate_src(). For aesthetics, absorb the code into that function.. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 28 ++-- 1 file changed, 10 insertions(+), 18

[PATCH 09/40] staging: comedi: ni_tio: convert NI_M_Series_PFI_Clock() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 11 +++ 1 file changed, 3 inse

[PATCH 32/40] staging: comedi: ni_tio: absorb ni_tio_counter_status()

This function is only called to handle the INSN_CONFIG_GET_COUNTER_STATUS instruction. For aesthetics, absorb the code into ni_tio_insn_config(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 25 + 1

[PATCH 31/40] staging: comedi: ni_tio: tidy up ni_tio_set_sync_mode()

Fix the > 80 char line issues in this function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/drivers/

[PATCH 00/40] staging: comedi: ni_tio: clean up driver

Start cleaning up this driver by: 1) fix all the checkpatch.pl warnings WARNING: line over 80 characters WARNING: Unnecessary space before function pointer arguments WARNING: Prefer [foo]_err to printk(KERN_ERR ... 2) remove a bunch of unreachable BUG() code 3) tidy up some of

[PATCH 10/40] staging: comedi: ni_tio: convert NI_660x_Gate_Pin_Gate_Select() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 9 ++--- 1 file changed, 2 inserti

[PATCH 03/40] staging: comedi: ni_tio: tidy up some function declarations

Fix the whitespace in some of the function declarations to avoid the ugly line breaks and fix a couple checkpatch.pl issues: WARNING: line over 80 characters WARNING: Unnecessary space before function pointer arguments Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman ---

[PATCH 16/40] staging: comedi: ni_tio: convert NI_660x_RTSI_Second_Gate_Select() to a macro

The BUG_ON() in this function can never happen. For aesthetics, rename this CamelCase inline function and convert it into a simple macro. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 10 ++ 1 file changed, 2 inser

  1   2   >