On 07/22/2014 01:06 AM, K. Y. Srinivasan wrote:
Add blist flags to permit the reading of the VPD pages even when
the target may claim SPC-2 compliance. MSFT targets currently
claim SPC-2 compliance while they implement post SPC-2 features.
With this patch we can correctly handle WRITE_SAME_16 iss
On Thu, Jul 24, 2014 at 01:54:58AM +, Dexuan Cui wrote:
> Ping again -- any one has further comment for the v3 version?
>
> It looks the framebuffer layer's Tomi and Jean-Christophe are out recently?
> Recently I don't see mail from them since Jul 1 and Jul 8 in the lists.
>
> Though the patc
This removes the two errors I get when running checkpatch on this
file. The first being not to use C99 comments and the second to
remove spacing issues with the define statement on line 7.
Signed-off-by: Nicholas Krause
---
drivers/staging/bcm/InterfaceMacros.h | 4 ++--
1 file changed, 2 insert
This joins two lines that need to be joined as this improves
the coding style and makes it much easier to read.
Signed-off-by: Nicholas Krause
---
drivers/staging/bcm/InterfaceIdleMode.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/bcm/InterfaceIdleMode.c
This patch fixes the space errors checkpatch gives on this file
for the header of this file.
Signed-off-by: Nicholas Krause
---
drivers/staging/bcm/headers.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm/headers.h b/drivers/staging/bcm/headers.h
index 6f
This patch adds a blank line after line 708 as declared when
running checkpatch on this file.
Signed-off-by: Nicholas Krause
---
drivers/staging/android/sync.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/sync.c b/drivers/staging/android/sync.c
index e7b2e02..0d374
This adds two blank lines as stated by checkpatch before lines,
100 and 159 respectively.
Signed-off-by: Nicholas Krause
---
drivers/staging/android/sw_sync.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/android/sw_sync.c
b/drivers/staging/android/sw_sync.c
index a76db3
This patch removes a checkpatch error by adding a line below
the definitions of the character array buf and the pointer path.
Signed-off-by: Nicholas Krause
---
drivers/staging/android/ion/ion.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/stag
Ping again -- any one has further comment for the v3 version?
It looks the framebuffer layer's Tomi and Jean-Christophe are out recently?
Recently I don't see mail from them since Jul 1 and Jul 8 in the lists.
Though the patch belongs to driver/video/fbdev/, it only changes hyper-v stuff
and only
On Tue, Jul 22, 2014 at 08:34:55PM -0400, Jeff Oczek wrote:
> Changed names of ambiguous sounding variable names as follows
>
> error_flag -> cxt1e1_error_flag
> max_mtu_default -> cxt1e1_max_mtu_default
> max_txdesc_used -> cxt1e1_max_txdesc_used
> max_txdesc_default -> cxt1
On Wed, Jul 23, 2014 at 07:23:43PM +0400, Andrey Skvortsov wrote:
> Signed-off-by: Andrey Skvortsov
> ---
> .../lustre/lustre/obdclass/linux/linux-sysctl.c| 28
> ++--
> 1 file changed, 14 insertions(+), 14 deletions(-)
You obviously did not build with your patch applied,
On Wed, Jul 23, 2014 at 05:06:28AM +0300, Sam Asadi wrote:
> A 'Missing a blank line after declarations' warning fixed by inserting
> a blank line after struct pointer declaration.
>
> Signed-off-by: Sam Asadi
> ---
> drivers/staging/comedi/drivers/amplc_pc236.c |1 +
> 1 file changed, 1 ins
On Thu, Jul 24, 2014 at 1:03 AM, Nicholas Krause wrote:
> This changes the call to kzalloc to kcalloc in ion_dummy_driver
> for allocating the heap.
>
> Signed-off-by: Nicholas Krause
> ---
> drivers/staging/android/ion/ion_dummy_driver.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions
This changes the call to kzalloc to kcalloc in ion_dummy_driver
for allocating the heap.
Signed-off-by: Nicholas Krause
---
drivers/staging/android/ion/ion_dummy_driver.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/android/ion/ion_dummy_driver.c
b/dr
From: weiyj...@163.com
Date: Wed, 23 Jul 2014 09:00:35 +0800
> From: Wei Yongjun
>
> Fix to return -ENOMEM from the kalloc error handling
> case instead of 0.
>
> Signed-off-by: Wei Yongjun
Applied, thank you.
___
devel mailing list
de...@linuxdrive
On 22/07/14 16:03, Josef Gajdusek wrote:
This patch adds support for the hmc5983 spi interface.
This chip is almost identical to the hmc5883. The difference being added
temperature compensation, additional available sample rate (220Hz) and an SPI
interface.
Signed-off-by: Josef Gajdusek
Applie
On 22/07/14 16:02, Josef Gajdusek wrote:
Changed structure of struct hmc5843_chip_info to include length of translation
arrays. Code previously using #defined constant has been changed accordingly.
This allows to integrate devices which do have different amounts of available
rates/scales.
Signed
On 22/07/14 16:02, Josef Gajdusek wrote:
This patch adds support for the hmc5983 i2c interface.
This chip is almost identical to the hmc5883. The difference being added
temperature compensation, additional available sample rate (220Hz) and an SPI
interface.
Signed-off-by: Josef Gajdusek
Applie
On 22/07/14 16:01, Josef Gajdusek wrote:
This patch splits hmc5843.c to multiple files - the interface-agnostic
hmc5843_core.c, i2c specific hmc5843_i2c.c and header file hmc5843.h. This is
another step to add support of SPI-enabled hmc5983.
Signed-off-by: Josef Gajdusek
Applied to the togreg
On 22/07/14 16:00, Josef Gajdusek wrote:
This patch changes hmc5843.c to use regmap. This provides transparent caching
to the code as well as abstraction necessary to add support for SPI-based
hmc5983.
Signed-off-by: Josef Gajdusek
Applied to the togreg branch of iio.git - initially pushed out
On Wed, Jul 23, 2014 at 4:10 PM, Colin Cross wrote:
> On Wed, Jul 23, 2014 at 1:04 PM, Nick Krause wrote:
>> Hey Greg and others.
>> Sorry for another email but it seems the function,
>> ion_carveout_heap_unmap_dma is
>> just returning and not doing anything useful. Furthermore I am new so
>> I d
On Wed, Jul 23, 2014 at 07:15:58AM -0700, Christoph Hellwig wrote:
> On Wed, Jul 23, 2014 at 03:10:28PM +0100, Sitsofe Wheeler wrote:
> > I'm not sure this alone will work - won't sdev_bflags/bflags have
> > already been built at this point?
>
> They've been built up, but we can still or new value
On Wed, Jul 23, 2014 at 1:04 PM, Nick Krause wrote:
> Hey Greg and others.
> Sorry for another email but it seems the function,
> ion_carveout_heap_unmap_dma is
> just returning and not doing anything useful. Furthermore I am new so
> I don't known how
> to write this function but this may be cau
Hey Greg and others.
Sorry for another email but it seems the function,
ion_carveout_heap_unmap_dma is
just returning and not doing anything useful. Furthermore I am new so
I don't known how
to write this function but this may be causing some rather serious
bugs as if the dma heap
is not unmaped
This patch removes a few errors that checkpatch gives when run
on ion.c. I didn't remove the warning from returning in a void
function as we need to write ion_dma_buf_kunmap and I have no
idea how to do this as all we are doing in this function as of now
is returning and leaking the memory allocate
Fix following sh-allmodconfig errors reported on kisskb
"
drivers/built-in.o: In function `ion_vm_fault':
ion.c:(.text+0x1f2d8f8): undefined reference to `vm_insert_pfn'
drivers/built-in.o: In function `ion_buffer_sync_for_device':
ion.c:(.text+0x1f316bc): undefined reference to `zap_page_range'
ma
Fix checkpatch warning of void function return statements, found under
drivers/staging/android/ion.
Signed-off-by: WANG Chao
---
drivers/staging/android/ion/ion.c | 1 -
drivers/staging/android/ion/ion_carveout_heap.c | 1 -
drivers/staging/android/ion/ion_chunk_heap.c| 1 -
dr
Fix checkpatch warning of prefer kcalloc over kzalloc with multiply,
found under drivers/staging/android/ion/.
Signed-off-by: WANG Chao
---
drivers/staging/android/ion/ion_dummy_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/android/ion/ion_dummy_dri
On 07/24/14 at 02:26am, WANG Chao wrote:
> Fix checkpatch warning of missing a blank line after declarations,
> found under drivers/staging/android/ion/.
Sorry I forgot to mention this is for linux-next.
>
> Signed-off-by: WANG Chao
> ---
> drivers/staging/android/ion/ion.c | 1 +
> 1 file cha
Fix checkpatch warning of missing a blank line after declarations,
found under drivers/staging/android/ion/.
Signed-off-by: WANG Chao
---
drivers/staging/android/ion/ion.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/android/ion/ion.c
b/drivers/staging/android/ion/ion.c
i
vme_user.c contained unnecessary breaks after gotos, which increased
code size and caused code style warning. This is now fixed.
Signed-off-by: Tom Jorquera
---
drivers/staging/vme/devices/vme_user.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/vme/devices/vme_user.c
b
> -Original Message-
> From: Christoph Hellwig [mailto:h...@infradead.org]
> Sent: Wednesday, July 23, 2014 7:10 AM
> To: Sitsofe Wheeler
> Cc: KY Srinivasan; gre...@linuxfoundation.org; linux-
> ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com;
> a...@canonical.com;
> -Original Message-
> From: Sitsofe Wheeler [mailto:sits...@gmail.com]
> Sent: Wednesday, July 23, 2014 3:05 AM
> To: KY Srinivasan
> Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org;
> de...@linuxdriverproject.org; oher...@suse.com; a...@canonical.com;
> jasow...@redhat.com;
On Wed, Jul 23, 2014 at 07:10:14AM -0700, Christoph Hellwig wrote:
> On Wed, Jul 23, 2014 at 01:54:43PM +0100, Sitsofe Wheeler wrote:
> > That's good to know (I was worried the device would not be detected as
> > supporting discard because it doesn't report lbpme and doesn't declare a
> > conforman
On Wed, Jul 23, 2014 at 10:08:44AM +, Sharma, Sanjeev wrote:
> Thanks, so this is also available in next kernel release version.
I don't understand the question. You should have gotten an automated
email when the patch was applied that explained where the patch was now
located, and when it wo
> -Original Message-
> From: weiyj...@163.com [mailto:weiyj...@163.com]
> Sent: Tuesday, July 22, 2014 9:01 PM
> To: KY Srinivasan; Haiyang Zhang
> Cc: Wei Yongjun; de...@linuxdriverproject.org; net...@vger.kernel.org
> Subject: [PATCH] hyperv: Fix error return code in netvsc_init_buf()
>
Signed-off-by: Sudip Mukherjee
---
drivers/staging/bcm/Transmit.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/bcm/Transmit.c b/drivers/staging/bcm/Transmit.c
index 05fae92..622a482 100644
--- a/drivers/staging/bcm/Transmit.c
+++ b/drivers/stagin
On Wed, Jul 23, 2014 at 03:10:28PM +0100, Sitsofe Wheeler wrote:
> I'm not sure this alone will work - won't sdev_bflags/bflags have
> already been built at this point?
They've been built up, but we can still or new values into it. It looks
fine to me from review, but if you can test it on an act
On Mon, Jul 21, 2014 at 04:06:01PM -0700, K. Y. Srinivasan wrote:
> Add blist flags to permit the reading of the VPD pages even when
> the target may claim SPC-2 compliance. MSFT targets currently
> claim SPC-2 compliance while they implement post SPC-2 features.
> With this patch we can correctly
On Wed, Jul 23, 2014 at 01:54:43PM +0100, Sitsofe Wheeler wrote:
> That's good to know (I was worried the device would not be detected as
> supporting discard because it doesn't report lbpme and doesn't declare a
> conformance version (see below)).
Ok, that makes things worse - you might be able t
Subject is too general. Which coding style issue did you fix?
On Wed, Jul 23, 2014 at 07:22:30PM +0530, sudip wrote:
Use your full name. "Sudip Mukherjee" not just "sudip".
> applies to next-20140723
Leave this out.
>
>
> Signed-off-by: sudip
Use your re
applies to next-20140723
Signed-off-by: sudip
---
drivers/staging/bcm/Transmit.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/bcm/Transmit.c b/drivers/staging/bcm/Transmit.c
index 05fae92..10586f8 100644
--- a/drivers/staging/bcm/Transmit.c
+++ b
On Tue, 2014-07-22 at 16:14 -0700, Greg KH wrote:
> What is the format of the chipsetready file? It looks like you want to
> write 2 values to it? Please describe it better, for all of these.
>
I think the intent was to pass in a tuple from a script started by a
udev event, as an indication of
On Wed, 23 Jul 2014 08:16:39 +0200
Robin Schroer wrote:
> Fix a pointer check to use NULL instead of 0
>
> Warning:
> drivers/staging/goldfish/goldfish_audio.c:300:34: warning: Using plain
> integer as NULL pointer
>
> Signed-off-by: Robin Schroer
Acked-by: Alan Cox
On Wed, Jul 23, 2014 at 04:51:28AM -0700, Christoph Hellwig wrote:
> On Wed, Jul 23, 2014 at 11:04:48AM +0100, Sitsofe Wheeler wrote:
> > OK I've just seen this as I was about to post a similar patch to get
> > discard going on Hyper-V. Will your patches handle Hyper-V pass through
> > devices
> >
On Wed, Jul 23, 2014 at 11:04:48AM +0100, Sitsofe Wheeler wrote:
> OK I've just seen this as I was about to post a similar patch to get
> discard going on Hyper-V. Will your patches handle Hyper-V pass through
> devices
> that support discard? The SSD I have here reports the following in the Linux
On 07/23/2014 07:30 PM, Dan Carpenter wrote:
> On Wed, Jul 23, 2014 at 07:09:22PM +0800, Chen Gang wrote:
>>
>>
>> On 07/17/2014 05:19 PM, Chen Gang wrote:
>>>
>>>
>>> On 07/17/2014 05:16 PM, Dan Carpenter wrote:
On Thu, Jul 17, 2014 at 04:59:09PM +0800, Chen Gang wrote:
>>> + retu
The variable 'i' does not need to be passed, as we set it to 0 (zero)
anyways when starting the iteration here.
Suggested-by: Dan Carpenter
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/nvm.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/bcm/
The variable type of the local variable 'j' should be 'int' instead of
'unsigned int'.
Suggested-by: Dan Carpenter
Signed-off-by: Matthias Beyer
---
drivers/staging/bcm/nvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/bcm/nvm.c b/drivers/staging/bcm/nvm.
Hi,
these are some folloup cleanup patches for the
drivers/staging/bcm/nvm.c
file, suggested by Dan Carpenter.
As always, please note that I'm only able to compile these patches, but not able
to test them as I do not have the appropriate hardware!
Kind regards,
Matthias Beyer
Matthias Bey
On Wed, Jul 23, 2014 at 07:09:22PM +0800, Chen Gang wrote:
>
>
> On 07/17/2014 05:19 PM, Chen Gang wrote:
> >
> >
> > On 07/17/2014 05:16 PM, Dan Carpenter wrote:
> >> On Thu, Jul 17, 2014 at 04:59:09PM +0800, Chen Gang wrote:
> > + return (__force void __iomem *)ERR_PTR(-ENXIO);
> >>
Signed-off-by: Andrey Skvortsov
---
.../lustre/lustre/obdclass/linux/linux-sysctl.c| 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/lustre/lustre/obdclass/linux/linux-sysctl.c
b/drivers/staging/lustre/lustre/obdclass/linux/linux-sys
On 07/17/2014 05:19 PM, Chen Gang wrote:
>
>
> On 07/17/2014 05:16 PM, Dan Carpenter wrote:
>> On Thu, Jul 17, 2014 at 04:59:09PM +0800, Chen Gang wrote:
> + return (__force void __iomem *)ERR_PTR(-ENXIO);
There's apparently an IOMEM_ERR_PTR() for this nowadays...
>>>
>>> IOM
On Wed, Jul 23, 2014 at 12:52:37PM +0200, Matthias Beyer wrote:
> On 23-07-2014 13:48:11, Dan Carpenter wrote:
> > On Sun, Jul 20, 2014 at 03:14:10PM +0200, Matthias Beyer wrote:
> > > This patch outsources a chunk of code into an own function. It also
> > > refactors the variable names which are u
On 23-07-2014 13:48:11, Dan Carpenter wrote:
> On Sun, Jul 20, 2014 at 03:14:10PM +0200, Matthias Beyer wrote:
> > This patch outsources a chunk of code into an own function. It also
> > refactors the variable names which are used within this function.
> >
> > The function name may be not appropri
The issue was reported by static analysis.
The value holding flags was &-ed with 0x02, being compared to 0x01
(TRUE) after that. Such comparsion is always false.
Resolution: drop the comparsion to TRUE in the condition.
&-ing with 0x02 is right, according to result variable name
(reporting_mode)
On Sun, Jul 20, 2014 at 03:14:10PM +0200, Matthias Beyer wrote:
> This patch outsources a chunk of code into an own function. It also
> refactors the variable names which are used within this function.
>
> The function name may be not appropriate.
>
> Signed-off-by: Matthias Beyer
> ---
> drive
Thanks, so this is also available in next kernel release version.
Regards
Sanjeev Sharma
-Original Message-
From: Greg KH [mailto:gre...@linuxfoundation.org]
Sent: Saturday, July 19, 2014 4:46 AM
To: Sharma, Sanjeev
Cc: de...@driverdev.osuosl.org; way...@gmail.com; swetl...@google.com;
On Mon, Jul 21, 2014 at 04:06:01PM -0700, K. Y. Srinivasan wrote:
> Add blist flags to permit the reading of the VPD pages even when
> the target may claim SPC-2 compliance. MSFT targets currently
> claim SPC-2 compliance while they implement post SPC-2 features.
> With this patch we can correctly
Add a function to return the total number of digital I/O, digital input,
and digital output ports on the board. Each port has 8 channels (bits).
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/ni_65xx.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --gi
Refactor the code that updates the rising and falling edge detection
registers into new function `ni_65xx_update_edge_detection()`. This
updates the rising and falling edge detection registers for up to 32
channels starting at an arbitrary channel. Call it from the code that
handles the `INSN_CON
When the hardware is being initialized, the edge detection interrupts
are cleared and disabled. Also disable edge detection for all channels
at this time so they start off in a known state.
Signed-off-by: Ian Abbott
---
drivers/staging/comedi/drivers/ni_65xx.c | 1 +
1 file changed, 1 insertion
The "edge detection interrupt" subdevice supports the
`INSN_CONFIG_CHANGE_NOTIFY` comedi instruction which is only supported
by one other driver. It is limited to the first 32 channels, but boards
supported by this driver support edge detection on all digital I/O,
digital input and digital output
Add partial support for INSN_CONFIG_DIGITAL_TRIG as an alternative to
INSN_CONFIG_CHANGE_NOTIFY (with the advantage that more than the first 32
channels are supported), and initialize the edge detection registers.
1) staging: comedi: ni_65xx: add ni_65xx_num_ports()
2) staging: comedi: ni_65xx: re
64 matches
Mail list logo
