Le 19/07/2014 20:00, Joe Perches a écrit :
> (Adding Mark Allyn and Jayant Mangalampalli)
>
> Is this still project still active?
I do not know
>
> On Sat, 2014-07-19 at 19:34 +0200, LABBE Corentin wrote:
>> Signed-off-by: LABBE Corentin
>> ---
>> drivers/staging/sep/sep_main.c | 5 ++---
>>
Clean redundant comments in the code.
Since I perform single fix type per patch, I've ignored the 80 line warning
when checking the patch against checkpatch.
I will fix the 80 line warnings on further patches.
Signed-off-by: Igor Bezukh
---
drivers/staging/vt6655/wcmd.c | 46 --
On Sat, Jul 19, 2014 at 09:34:56PM +0200, Riccardo Lucchese wrote:
> It is silly to go through an if statement to set a single boolean
> value in function of a single boolean expression. In the function
> lov_check_set, assign the return value directly.
>
> Signed-off-by: Riccardo Lucchese
> ---
a line over 80 issue fixed by removing the cross-lined comment
to the previous line.
Signed-off-by: Sam Asadi
---
drivers/staging/comedi/drivers/adv_pci1710.c |5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c
b/drivers/stagi
This patch fix coding style:
- Remove "fail memory allocation" waring
- Remove return of void function
Tested by compilation only
Signed-off-by: Phong Tran
---
drivers/staging/android/ion/ion_cma_heap.c | 9 ++---
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/drivers/stagin
On Sun, Jul 20, 2014 at 04:15:50AM +0300, Sam Asadi wrote:
> A line over 80 issue fixed, which is a comment.
>
> Signed-off-by: Sam Asadi
> ---
> drivers/staging/comedi/drivers/adv_pci1710.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/driver
(Adding Mark Allyn and Jayant Mangalampalli)
Is this still project still active?
On Sat, 2014-07-19 at 19:34 +0200, LABBE Corentin wrote:
> Signed-off-by: LABBE Corentin
> ---
> drivers/staging/sep/sep_main.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers
On Sun, 2014-07-20 at 03:43 +0300, Sam Asadi wrote:
> A 'Missing a blank line after declarations' issue fixed and also tested
> by 'make M=...'. It seems that after 'unsigned long iobase' declaration
> a blank line is desperately needed.
[]
> diff --git a/drivers/staging/comedi/drivers/8255.c
> b/
A line over 80 issue fixed, which is a comment.
Signed-off-by: Sam Asadi
---
drivers/staging/comedi/drivers/adv_pci1710.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/adv_pci1710.c
b/drivers/staging/comedi/drivers/adv_pci1710.c
index 602b7
A 'Missing a blank line after declarations' issue fixed and also tested
by 'make M=...'. It seems that after 'unsigned long iobase' declaration
a blank line is desperately needed.
Signed-off-by: Sam Asadi
---
drivers/staging/comedi/drivers/8255.c | 1 +
1 file changed, 1 insertion(+)
diff --git
On Sat, Jul 19, 2014 at 5:14 AM, Dan Carpenter wrote:
> On Sat, Jul 19, 2014 at 12:09:53PM +0300, Dan Carpenter wrote:
>> On Sat, Jul 19, 2014 at 01:26:52AM -0400, Nicholas Krause wrote:
>> > This patch add a atomic lock in usb_tranzport_usb for preventing
>> > a tiny race in this function.
>> >
>
On Sat, 19 Jul 2014, Jonathan Cameron wrote:
> On 19/07/14 21:46, Julia Lawall wrote:
> >
> >
> > On Sat, 19 Jul 2014, Jonathan Cameron wrote:
> >
> > > On 19/07/14 11:33, Himangi Saraogi wrote:
> > > > This patch moves data allocated using unmanaged interfaces to managed
> > > > interfaces l
On 19/07/14 21:46, Julia Lawall wrote:
On Sat, 19 Jul 2014, Jonathan Cameron wrote:
On 19/07/14 11:33, Himangi Saraogi wrote:
This patch moves data allocated using unmanaged interfaces to managed
interfaces like devm_kzalloc, devm_iio_device_register, devm_kasprintf,
devm_request_threaded_ir
On Sat, 19 Jul 2014, Jonathan Cameron wrote:
> On 19/07/14 11:33, Himangi Saraogi wrote:
> > This patch moves data allocated using unmanaged interfaces to managed
> > interfaces like devm_kzalloc, devm_iio_device_register, devm_kasprintf,
> > devm_request_threaded_irq and does away with the call
On 19/07/14 11:33, Himangi Saraogi wrote:
This patch moves data allocated using unmanaged interfaces to managed
interfaces like devm_kzalloc, devm_iio_device_register, devm_kasprintf,
devm_request_threaded_irq and does away with the calls to free the
allocated memory in the probe and remove funct
On Sat, 2014-07-19 at 21:34 +0200, Riccardo Lucchese wrote:
> It is silly to go through an if statement to set a single boolean
> value in function of a single boolean expression. In the function
> lov_check_set, assign the return value directly.
[]
> diff --git a/drivers/staging/lustre/lustre/lov/
On Sat, Jul 19, 2014 at 10:26:57AM -0400, Benjamin Romer wrote:
> +ssize_t store_chipsetready(struct device *dev, struct device_attribute *attr,
> + const char *buf, size_t count)
> {
> - char buf[512];
> - char *token, *p;
> -
> - if (count > sizeof(buf) - 1) {
> -
On Sat, Jul 19, 2014 at 10:26:56AM -0400, Benjamin Romer wrote:
> The installer entry in /proc/visorchipset/installer was composed of three
> separate fields as one entry. This patch removes the proc entry and associated
> functions, and creates new fields with distinct entries under sysfs in the
>
On Sat, Jul 19, 2014 at 10:26:54AM -0400, Benjamin Romer wrote:
> +ssize_t show_toolaction(struct device *dev, struct device_attribute *attr,
> + char *buf)
> +{
> + if (ControlVm_channel) {
> + U8 toolAction;
> +
> + visorchannel_read(ControlVm_channel,
> +
On Sat, Jul 19, 2014 at 02:26:48PM -0400, Ben Romer wrote:
> Greg KH wrote:
>
> > What happened to the idea of only creating the sysfs files _if_ it is
> > needed? You are always creating these files, and then can return
> > -ENODEV if the device really isn't there, that's not what you should do
Fix the following checkpatch.pl issue in lov_request.c:
ERROR: space required before the open brace '{'
Signed-off-by: Riccardo Lucchese
---
drivers/staging/lustre/lustre/lov/lov_request.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lov
It is silly to go through an if statement to set a single boolean
value in function of a single boolean expression. In the function
lov_check_set, assign the return value directly.
Signed-off-by: Riccardo Lucchese
---
drivers/staging/lustre/lustre/lov/lov_request.c | 11 +--
1 file chang
Fix the following checkpatch.pl issue in lov_request.c:
WARNING: Missing a blank line after declarations
Signed-off-by: Riccardo Lucchese
---
drivers/staging/lustre/lustre/lov/lov_request.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/l
Hello,
This patch series fixes two coding style issues and removes an unneeded
'if' statement in lov_request.c.
Thanks,
riccardo
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-deve
Greg KH wrote:
> What happened to the idea of only creating the sysfs files _if_ it is
> needed? You are always creating these files, and then can return
> -ENODEV if the device really isn't there, that's not what you should do
> for a sysfs file. If the file is present, it should return data,
Signed-off-by: LABBE Corentin
---
drivers/staging/sep/sep_main.c | 47 --
1 file changed, 4 insertions(+), 43 deletions(-)
diff --git a/drivers/staging/sep/sep_main.c b/drivers/staging/sep/sep_main.c
index 6f98881..89a1d53 100644
--- a/drivers/staging/sep/
Hello
The drivers/staging/sep/sep_main.c have lots of checkpatch issue.
This patch series solves them and since there are many, I have splitted
corrections in 4 patch.
Note that this work is done for the Eudyptulla Challenge.
Best regards
___
devel m
Signed-off-by: LABBE Corentin
---
drivers/staging/sep/sep_main.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sep/sep_main.c b/drivers/staging/sep/sep_main.c
index 177e4b9..1580d95f 100644
--- a/drivers/staging/sep/sep_main.c
+++ b/drivers/staging/sep/s
Signed-off-by: LABBE Corentin
---
drivers/staging/sep/sep_main.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sep/sep_main.c b/drivers/staging/sep/sep_main.c
index 1580d95f..6f98881 100644
--- a/drivers/staging/sep/sep_main.c
+++ b/drivers/staging/sep/s
Signed-off-by: LABBE Corentin
---
drivers/staging/sep/sep_main.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/sep/sep_main.c b/drivers/staging/sep/sep_main.c
index 75ca15e..177e4b9 100644
--- a/drivers/staging/sep/sep_main.c
+++ b/drivers/sta
On Sat, Jul 19, 2014 at 10:26:54AM -0400, Benjamin Romer wrote:
> Move the proc entry for controlling the toolaction field to sysfs. The field
> appears in /sys/devices/platform/visorchipset/install/toolaction.
>
> This field is used to tell s-Par which type of recovery tool action to perform
> on
On Sat, Jul 19, 2014 at 10:26:53AM -0400, Benjamin Romer wrote:
> This patch set moves several interfaces in the visorchipset module from procfs
> to sysfs, and removes the remaining proc interfaces from the module. It
> includes
> documentation for the new interfaces in Documentation/ABI, and som
Debugging information for the guest's channels was being exposed in proc.
Remove the code that creates these entries, which are no longer needed.
Signed-off-by: Benjamin Romer
---
.../unisys/visorchipset/visorchipset_main.c| 100 -
1 file changed, 100 deletions(-)
di
The installer entry in /proc/visorchipset/installer was composed of three
separate fields as one entry. This patch removes the proc entry and associated
functions, and creates new fields with distinct entries under sysfs in the
visorchipset/install directory. The fields are:
textid: used t
Move the proc entry for controlling the toolaction field to sysfs. The field
appears in /sys/devices/platform/visorchipset/install/toolaction.
This field is used to tell s-Par which type of recovery tool action to perform
on the next guest boot-up. The meaning of the value is dependent on the type
Remove remnant code left over from the diagdump proc entry.
Signed-off-by: Benjamin Romer
---
drivers/staging/unisys/visorchipset/visorchipset_main.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/unisys/visorchipset/visorchipset_main.c
b/drivers/stag
This patch set moves several interfaces in the visorchipset module from procfs
to sysfs, and removes the remaining proc interfaces from the module. It includes
documentation for the new interfaces in Documentation/ABI, and some code cleanup
in the new sysfs handler functions.
Benjamin Romer (8):
Move the proc entry controlling the boottotool flag to procfs. The field
appears in /sys/devices/platform/visorchipset/install/boottotool.
The boottotool flag controls s-Par behavior on the next boot of this guest.
Setting the flag will cause the guest to boot from the utility and installation
ima
Move the chipsetready proc entry to sysfs under a new directory guest. This
entry is used by Unisys application software on the guest to acknowledge
completion of specific events for integration purposes, but these
acknowledgements are not required for the guest to operate correctly.
The store fun
This patch adds a documentation file for all of the interfaces that were moved
to sysfs by the other patches in this set.
Signed-off-by: Benjamin Romer
---
.../Documentation/ABI/sysfs-platform-visorchipset | 74 ++
1 file changed, 74 insertions(+)
create mode 100644
driver
Move the /proc/visorchipset/parahotplug interface to sysfs under
/sys/devices/platform/visorchipset/guest/parahotplug.
The parahotplug interface is used to deal with recovery situations on s-Par
guest partitions. The command service partition will send a message to a guest
when a device that guest
Introductory comments organized according to Linux's comment
coding style.
Signed-off-by: Sam Asadi
---
drivers/staging/comedi/drivers/adl_pci9118.c | 109 +-
1 file changed, 55 insertions(+), 54 deletions(-)
diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c
b/
This patch moves data allocated using unmanaged interfaces to managed
interfaces like devm_kzalloc, devm_iio_device_register, devm_kasprintf,
devm_request_threaded_irq and does away with the calls to free the
allocated memory in the probe and remove functions. Some labels in the
probe function are
Signed-off-by: LABBE Corentin
---
drivers/staging/sep/sep_main.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sep/sep_main.c b/drivers/staging/sep/sep_main.c
index 177e4b9..1580d95f 100644
--- a/drivers/staging/sep/sep_main.c
+++ b/drivers/staging/sep/s
Signed-off-by: LABBE Corentin
---
drivers/staging/sep/sep_main.c | 47 --
1 file changed, 4 insertions(+), 43 deletions(-)
diff --git a/drivers/staging/sep/sep_main.c b/drivers/staging/sep/sep_main.c
index 6f98881..89a1d53 100644
--- a/drivers/staging/sep/
Signed-off-by: LABBE Corentin
---
drivers/staging/sep/sep_main.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/sep/sep_main.c b/drivers/staging/sep/sep_main.c
index 1580d95f..6f98881 100644
--- a/drivers/staging/sep/sep_main.c
+++ b/drivers/staging/sep/s
Hello
The drivers/staging/sep/sep_main.c have lots of checkpatch issue.
This patch series solves them and since there are many, I have splitted
corrections in 4 patch.
Note that this work is done for the Eudyptulla Challenge.
Best regards
___
devel m
Signed-off-by: LABBE Corentin
---
drivers/staging/sep/sep_main.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/sep/sep_main.c b/drivers/staging/sep/sep_main.c
index 75ca15e..177e4b9 100644
--- a/drivers/staging/sep/sep_main.c
+++ b/drivers/sta
On Sat, Jul 19, 2014 at 12:09:53PM +0300, Dan Carpenter wrote:
> On Sat, Jul 19, 2014 at 01:26:52AM -0400, Nicholas Krause wrote:
> > This patch add a atomic lock in usb_tranzport_usb for preventing
> > a tiny race in this function.
> >
> > Signed-off-by: Nicholas Krause
>
> Is this a guess work
On Sat, Jul 19, 2014 at 01:26:52AM -0400, Nicholas Krause wrote:
> This patch add a atomic lock in usb_tranzport_usb for preventing
> a tiny race in this function.
>
> Signed-off-by: Nicholas Krause
Is this a guess work patch or have you tested it?
regards,
dan carpenter
_
50 matches
Mail list logo
