[PATCH] staging: Fix a Fix me in tranzport.c

2014-07-18 Thread Nicholas Krause
This patch add a atomic lock in usb_tranzport_usb for preventing a tiny race in this function. Signed-off-by: Nicholas Krause --- drivers/staging/frontier/tranzport.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/frontier/tranzport.c b/drivers/staging/fro

[PATCH] staging: comedi: drivers: remove unnecessary *_{IO, MEM}SIZE defines

2014-07-18 Thread H Hartley Sweeten
Some of the legacy comedi drivers have a *_{IO,MEM}SIZE define that is only passed to comedi_request_region() to specify the size of the region. For aesthetics, remove these defines. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dmm3

RE: [BISECTED][REGRESSION] Loading Hyper-V network drivers is racy in 3.14+ on Hyper-V 2012 R2

2014-07-18 Thread Haiyang Zhang
> -Original Message- > From: Sitsofe Wheeler [mailto:sits...@gmail.com] > Sent: Tuesday, July 15, 2014 1:09 AM > To: Haiyang Zhang > Cc: KY Srinivasan; David S. Miller; de...@linuxdriverproject.org; linux- > ker...@vger.kernel.org; net...@vger.kernel.org > Subject: Re: [BISECTED][REGRESSI

[PATCH 2/9] staging: comedi: ni_at_a2150: remove forward declarations

2014-07-18 Thread H Hartley Sweeten
Move some of the functions to remove the need for the forward declarations. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_at_a2150.c | 229 +-- 1 file changed, 111 insertions(+), 118 deletions(-) diff --git

[PATCH 3/9] staging: comedi: ni_pcidio: remove forward declarations

2014-07-18 Thread H Hartley Sweeten
Move some of the functions to remove the need for the forward declarations. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_pcidio.c | 124 + 1 file changed, 57 insertions(+), 67 deletions(-) diff --git a

[PATCH 8/9] staging: comedi: drivers: remove unnecessary DRIVER_NAME defines

2014-07-18 Thread H Hartley Sweeten
These defines are usually only used to initialize the driver_name member of the comedi_driver struct. Some of the drivers also use the define as part of dev_{level}() messages and/or when doing a request_irq(). The addition of the DRIVER_NAME to the messages is just added noise and the dev->board_

[PATCH 7/9] staging: comedi: drivers: remove unnecessary *_SIZE defines

2014-07-18 Thread H Hartley Sweeten
Some of the legacy comedi drivers have a *_SIZE define that is only passed to comedi_request_region() to specify the size of the region. Some of the pnp drivers (pci, etc.) also have a *_SIZE define which is unused. For aesthetics, remove these defines. Signed-off-by: H Hartley Sweeten Cc: Ian

[PATCH 1/9] staging: comedi: drivers: cleanup cmd->flags use

2014-07-18 Thread H Hartley Sweeten
Most of the comedi drivers that support async commands have some sort of timer to control the acquisition timing. For these drivers, Step 4 of the (*do_cmdtest) operations calls a ns_to_timer() function that converts the desired ns time of the command into a value used to set the timer. These ns_to

[PATCH 6/9] staging: comedi: drivers: remove unnecessary PCI_DEVICE_ID_* defines

2014-07-18 Thread H Hartley Sweeten
These defines are only used once in the pci_device_id tables. Remove them and just open code the values. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_dio200_pci.c | 28 --- drivers/staging/comedi/drivers/amp

[PATCH 0/9] staging: comedi: misc. cleanup

2014-07-18 Thread H Hartley Sweeten
Some misc. cleanup for comedi that I have had sitting around... H Hartley Sweeten (9): staging: comedi: drivers: cleanup cmd->flags use staging: comedi: ni_at_a2150: remove forward declarations staging: comedi: ni_pcidio: remove forward declarations staging: comedi: pcm3724: use default (*

[PATCH 5/9] staging: comedi: pcl816: remove forward declaration

2014-07-18 Thread H Hartley Sweeten
Move check_channel_list() to remove the need for the forward declaration. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl816.c | 116 +++- 1 file changed, 56 insertions(+), 60 deletions(-) diff --git a/d

[PATCH 4/9] staging: comedi: pcm3724: use default (*io) callback from 8255 module

2014-07-18 Thread H Hartley Sweeten
The private (*io) callback used by this driver is identical to the default one provided by the 8255 module. Use the default one instead. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcm3724.c | 15 +-- 1 file changed, 1 i

[PATCH 9/9] staging: comedi: drivers: use dev->board_name in request_irq()

2014-07-18 Thread H Hartley Sweeten
Most of the comedi drivers use the dev->board_name for the id string passed to request_irq(). Fix the couple that still pass something else. Also, propogate the errno from request_irq(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/

Re: [PATCH] Staging: vt6655: apply kernel coding style to wCommandTimerWait function

2014-07-18 Thread Greg KH
On Fri, Jul 18, 2014 at 09:35:13PM +0300, Igor Bezukh wrote: > Since there is a lot of stuff that need to be changed in order to meet the > kernel > coding style in wcmd.c file, I've decided to fix function-per-patch. > The following changes were made in vCommandTimerWait function: > > - Camel ca

Re: [PATCH] staging: android: Fixed missing blank line

2014-07-18 Thread Greg KH
On Fri, Jul 18, 2014 at 10:17:54AM +0530, Sanjeev Sharma wrote: > This patch will add an blank line after > declaration reported by checkpatch.pl script. > > Signed-off-by: Sanjeev Sharma > --- > drivers/staging/android/sw_sync.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/driver

Re: [PATCH 1/2] Staging: comedi: adl_pci9118: commenting style issue fixed

2014-07-18 Thread Greg KH
On Fri, Jul 18, 2014 at 11:13:07PM +0300, Sam Asadi wrote: > A 'quoted string split across lines' issue fixed, while a better use of > language applied to the comment. > > Signed-off-by: Sam Asadi > --- > drivers/staging/comedi/drivers/adl_pci9118.c |3 +-- > 1 file changed, 1 insertion(+),

Re: [PATCH 0/7] staging: comedi: core: checkpatch.pl --strict cleanup

2014-07-18 Thread Greg KH
On Fri, Jul 18, 2014 at 02:28:09PM -0700, H Hartley Sweeten wrote: > This series fixes most of the checkpatch.pl --strict issues in the comedi > core files. > > comedidev.h still has a couple: > > CHECK: spinlock_t definition without comment > CHECK: struct mutex definition without comment > CHEC

[PATCH 7/7] staging: comedi: comedi_compat32.h: checkpatch.pl --strict cleanup

2014-07-18 Thread H Hartley Sweeten
Fix the checkpatch.pl --strict issues: CHECK: extern prototypes should be avoided in .h files Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/comedi_compat32.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/stagi

[PATCH 2/7] staging: comedi: drivers.c: checkpatch.pl --strict cleanup

2014-07-18 Thread H Hartley Sweeten
Fix the checkpatch.pl --strict issues: CHECK: DEFINE_MUTEX definition without comment CHECK: braces {} should be used on all arms of this statement Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers.c | 4 +++- 1 file changed, 3 insertion

[PATCH 4/7] staging: comedi: comedi.h: checkpatch.pl --strict cleanup

2014-07-18 Thread H Hartley Sweeten
Fix the checkpatch.pl --strict issues: CHECK: Please use a blank line after function/struct/union/enum declarations For aesthetics, convert the inline functions into simple macros. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/comedi.h | 11

[PATCH 1/7] staging: comedi: comedi_compat32: checkpatch.pl --strict cleanup

2014-07-18 Thread H Hartley Sweeten
Fix the checkpatch.pl --strict issues: CHECK: Logical continuations should be on the previous line Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/comedi_compat32.c | 28 ++-- 1 file changed, 14 insertions(+), 14 deleti

[PATCH 5/7] staging: comedi: comedi_fops: checkpatch.pl --strict cleanup

2014-07-18 Thread H Hartley Sweeten
Fix the checkpatch.pl --strict issues: CHECK: braces {} should be used on all arms of this statement CHECK: Alignment should match open parenthesis CHECK: Prefer kzalloc(sizeof(*dev)...) over kzalloc(sizeof(struct comedi_device)...) Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroa

[PATCH 0/7] staging: comedi: core: checkpatch.pl --strict cleanup

2014-07-18 Thread H Hartley Sweeten
This series fixes most of the checkpatch.pl --strict issues in the comedi core files. comedidev.h still has a couple: CHECK: spinlock_t definition without comment CHECK: struct mutex definition without comment CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid CamelCase: CHECK: Avoid

[PATCH 6/7] staging: comedi: comedidev.h: checkpatch.pl --strict cleanup

2014-07-18 Thread H Hartley Sweeten
Fix the checkpatch.pl --strict issues: CHECK: Please use a blank line after function/struct/union/enum declarations CHECK: Alignment should match open parenthesis Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/comedidev.h | 5 +++-- 1 file ch

[PATCH 3/7] staging: comedi: comedi_internal.h: checkpatch.pl --strict cleanup

2014-07-18 Thread H Hartley Sweeten
Fix the checkpatch.pl --strict issues: CHECK: Please use a blank line after function/struct/union/enum declarations Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/comedi_internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/s

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread Greg KH
On Sat, Jul 19, 2014 at 07:14:12AM +1000, Dave Airlie wrote: > > > > We have almost 1000 more uses of the non-macro version than the "macro" > > version in the kernel today: > > $ git grep -w DEFINE_PCI_DEVICE_TABLE | wc -l > > 262 > > $ git grep "const struct pci_device_id" | wc -l > > 1254 > > d

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread Dave Airlie
> > We have almost 1000 more uses of the non-macro version than the "macro" > version in the kernel today: > $ git grep -w DEFINE_PCI_DEVICE_TABLE | wc -l > 262 > $ git grep "const struct pci_device_id" | wc -l > 1254 did you check for non-const ones? just to see if we have any of the broken case

[PATCH 02/11] staging: comedi: ni_mio_common: consolidate call to ni_mseries_get_pll_parameters()

2014-07-18 Thread H Hartley Sweeten
All cases of the switch call ni_mseries_get_pll_parameters() with the same parameters. Move the call out of the switch. Also, move the printk from ni_mseries_get_pll_parameters() so that it can be converted into a dev_err(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman

[PATCH 03/11] staging: comedi: ni_atmio: remove board attach noise

2014-07-18 Thread H Hartley Sweeten
Remove the printk messages in the (*attach) of this driver. These are just added noise. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_atmio.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/drivers/s

[PATCH 10/11] staging: comedi: hwdrv_apci3200: remove commented out printk messages

2014-07-18 Thread H Hartley Sweeten
The commented out printk() messages all apear to be development noise. Just remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c | 14 -- 1 file changed, 14 deletions(-) diff --git a/drive

[PATCH 05/11] staging: comedi: ni_at_a2150: convert printk to dev_err

2014-07-18 Thread H Hartley Sweeten
Convert the printk() message to dev_err(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_at_a2150.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_at_a2150.c b/drivers/sta

[PATCH 04/11] staging: comedi: ni_atmio: convert printk to dev_err in ni_getboardtype()

2014-07-18 Thread H Hartley Sweeten
Convert these printk() messages to dev_err(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_atmio.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni_atmio.c b/drivers/st

[PATCH 00/11] staging: comedi: more printk() cleanup

2014-07-18 Thread H Hartley Sweeten
Convert or remove more of the printk() messages in comedi. H Hartley Sweeten (11): staging: comedi: ni_mio_common: convert printk messages to dev_err staging: comedi: ni_mio_common: consolidate call to ni_mseries_get_pll_parameters() staging: comedi: ni_atmio: remove board attach noise st

[PATCH 11/11] staging: comedi: hwdrv_apci3120: cleanup printk messages

2014-07-18 Thread H Hartley Sweeten
Remove the printk messages that are just driver development debug noise and convert the rest to dev_err(). Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- .../staging/comedi/drivers/addi-data/hwdrv_apci3120.c | 18 -- 1 file changed, 4 insertions(+),

[PATCH 06/11] staging: comedi: das1800: tidy up das1800_probe()

2014-07-18 Thread H Hartley Sweeten
The (*attach) of driver calls this function to probe the 'id' of the hardware to verify that a valid boardinfo has been selected by the user. The dev_dbg() messages when the boardinfo is valid is just added noise. The printk messages when the id does not match the boardinfo does have some value.

[PATCH 07/11] staging: comedi: comedi_fops: remove commented out debug messages

2014-07-18 Thread H Hartley Sweeten
Remove the commented out printk() debug. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/comedi_fops.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index 9670b

[PATCH 09/11] staging: comedi: ni_atmio: remove printk noise in ni_isapnp_find_board()

2014-07-18 Thread H Hartley Sweeten
The printk() messages in this function a just added noise. Remove them. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_atmio.c | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/staging/comedi/

[PATCH 01/11] staging: comedi: ni_mio_common: convert printk messages to dev_err

2014-07-18 Thread H Hartley Sweeten
Where possible, convert the printk() messages in this file to dev_err(). Remove a couple commented out printk() messages. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 137 - 1 file changed,

[PATCH 08/11] staging: comedi: hwdrv_apci3200: remove disabled PRINT_INFO debug

2014-07-18 Thread H Hartley Sweeten
Remove all the PRINT_INFO debug. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- .../comedi/drivers/addi-data/hwdrv_apci3200.c | 85 -- 1 file changed, 85 deletions(-) diff --git a/drivers/staging/comedi/drivers/addi-data/hwdrv_apci3200.c b

[PATCH 2/2] Staging: comedi: adl_pci9118: line over 80 fixed

2014-07-18 Thread Sam Asadi
A 'line over 80 characters' issue fixed. Signed-off-by: Sam Asadi --- drivers/staging/comedi/drivers/adl_pci9118.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c index 7365f31..a7

[PATCH 1/2] Staging: comedi: adl_pci9118: commenting style issue fixed

2014-07-18 Thread Sam Asadi
A 'quoted string split across lines' issue fixed, while a better use of language applied to the comment. Signed-off-by: Sam Asadi --- drivers/staging/comedi/drivers/adl_pci9118.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread James Bottomley
On Fri, 2014-07-18 at 11:17 -0700, Greg KH wrote: > On Fri, Jul 18, 2014 at 09:54:32AM -0700, James Bottomley wrote: > > On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote: > > > On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: > > > > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit

[PATCH] Staging: vt6655: apply kernel coding style to wCommandTimerWait function

2014-07-18 Thread Igor Bezukh
Since there is a lot of stuff that need to be changed in order to meet the kernel coding style in wcmd.c file, I've decided to fix function-per-patch. The following changes were made in vCommandTimerWait function: - Camel case change: - MSecond ---> msec - hDdeviceContext ---> private -

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-18 Thread Douglas Gilbert
On 14-07-18 07:41 AM, James Bottomley wrote: On Fri, 2014-07-18 at 17:17 +, Elliott, Robert (Server Storage) wrote: From: James Bottomley [mailto:jbottom...@parallels.com] On Fri, 2014-07-18 at 00:51 +, Elliott, Robert (Server Storage) wrote: ... Also, in both sd_setup_flush_cmnd

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread Greg KH
On Fri, Jul 18, 2014 at 09:54:32AM -0700, James Bottomley wrote: > On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote: > > On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: > > > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote: > > > > We should prefer `const struct pci_d

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread Joe Perches
On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote: > On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: > > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote: > > > We should prefer `const struct pci_device_id` over > > > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding styl

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-18 Thread Chen Gang
On 07/18/2014 11:37 PM, Lennox Wu wrote: > Score can provide dummy functions if HAS_IOMEM and NO_IOMEM will be > removed, even if we indeed have no IOMEM. > Thank you for your reply, for score, your ideas is OK to me. And for the COMPILE_TEST needs still discussing below: > 2014-07-18 18:51 G

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-18 Thread James Bottomley
On Fri, 2014-07-18 at 17:17 +, Elliott, Robert (Server Storage) wrote: > > > > From: James Bottomley [mailto:jbottom...@parallels.com] > > > > On Fri, 2014-07-18 at 00:51 +, Elliott, Robert (Server Storage) > > wrote: > ... > > > > > > Also, in both sd_setup_flush_cmnd and sd_sync_cache:

RE: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-18 Thread Elliott, Robert (Server Storage)
> From: James Bottomley [mailto:jbottom...@parallels.com] > > On Fri, 2014-07-18 at 00:51 +, Elliott, Robert (Server Storage) > wrote: ... > > > > Also, in both sd_setup_flush_cmnd and sd_sync_cache: > > cmd->cmnd[0] = SYNCHRONIZE_CACHE; > > cmd->cmd_len = 10; > > > > SYNCHRONIZE

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-18 Thread h...@infradead.org
On Fri, Jul 18, 2014 at 10:12:38AM -0700, h...@infradead.org wrote: > This is what I plan to put in after it passes basic testing: And that one was on top of my previous version. One that applies against core-for-3.17 below: --- >From 8a79783e5f72ec034a724e16c1f46604bd97bf68 Mon Sep 17 00:00:00

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-18 Thread h...@infradead.org
This is what I plan to put in after it passes basic testing: --- >From bb617c9465b839d70ecbbc69002a20ccf5f935bd Mon Sep 17 00:00:00 2001 From: "K. Y. Srinivasan" Date: Fri, 18 Jul 2014 19:12:58 +0200 Subject: sd: fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout Commit ID: 7e66

RE: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-18 Thread KY Srinivasan
> -Original Message- > From: James Bottomley [mailto:jbottom...@parallels.com] > Sent: Friday, July 18, 2014 9:57 AM > To: KY Srinivasan > Cc: linux-ker...@vger.kernel.org; h...@infradead.org; a...@canonical.com; > de...@linuxdriverproject.org; micha...@cs.wisc.edu; ax...@kernel.dk; > lin

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-18 Thread James Bottomley
On Fri, 2014-07-18 at 10:00 -0700, Christoph Hellwig wrote: > On Wed, Jun 04, 2014 at 09:33:43AM -0700, K. Y. Srinivasan wrote: > > Commit ID: 7e660100d85af860e7ad763202fff717adcdaacd added code to derive the > > FLUSH_TIMEOUT from the basic I/O timeout. However, this patch did not use > > the > >

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-18 Thread h...@infradead.org
On Fri, Jul 18, 2014 at 04:57:13PM +, James Bottomley wrote: > Actually, no you didn't. The difference is in the derivation of the > timeout. Christoph's patch is absolute in terms of SD_TIMEOUT; yours is > relative to the queue timeout setting ... I thought there was a reason > for preferrin

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-18 Thread Christoph Hellwig
On Wed, Jun 04, 2014 at 09:33:43AM -0700, K. Y. Srinivasan wrote: > Commit ID: 7e660100d85af860e7ad763202fff717adcdaacd added code to derive the > FLUSH_TIMEOUT from the basic I/O timeout. However, this patch did not use the > basic I/O timeout of the device. Fix this bug. > > Signed-off-by: K. Y.

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-18 Thread James Bottomley
On Fri, 2014-07-18 at 16:44 +, KY Srinivasan wrote: > > > -Original Message- > > From: Christoph Hellwig (h...@infradead.org) [mailto:h...@infradead.org] > > Sent: Friday, July 18, 2014 8:11 AM > > To: KY Srinivasan > > Cc: Jens Axboe; James Bottomley; micha...@cs.wisc.edu; Christoph H

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread James Bottomley
On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote: > On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: > > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote: > > > We should prefer `const struct pci_device_id` over > > > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding styl

RE: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-18 Thread KY Srinivasan
> -Original Message- > From: Christoph Hellwig (h...@infradead.org) [mailto:h...@infradead.org] > Sent: Friday, July 18, 2014 8:11 AM > To: KY Srinivasan > Cc: Jens Axboe; James Bottomley; micha...@cs.wisc.edu; Christoph Hellwig > (h...@infradead.org); linux-s...@vger.kernel.org; > gre...

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread Greg KH
On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote: > > We should prefer `const struct pci_device_id` over > > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. > > This issue was reported by checkpatch. >

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread Keller, Jacob E
On Fri, 2014-07-18 at 09:28 -0700, James Bottomley wrote: > On Fri, 2014-07-18 at 17:26 +0200, Benoit Taine wrote: > > We should prefer `const struct pci_device_id` over > > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. > > This issue was reported by checkpatch. > > What kernel

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread John W. Linville
On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote: > We should prefer `const struct pci_device_id` over > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. > This issue was reported by checkpatch. Honestly, I prefer the macro -- it stands-out more. Maybe the style guide

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread James Bottomley
On Fri, 2014-07-18 at 17:26 +0200, Benoit Taine wrote: > We should prefer `const struct pci_device_id` over > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. > This issue was reported by checkpatch. What kernel coding style? checkpatch isn't the arbiter of style, if that's the o

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-18 Thread James Bottomley
On Fri, 2014-07-18 at 00:51 +, Elliott, Robert (Server Storage) wrote: > In sd_sync_cache: > rq->timeout *= SD_FLUSH_TIMEOUT_MULTIPLIER; > > Regardless of the baseline for the multiplication, a magic > number of 2 is too arbitrary. That might work for an > individual drive, but could b

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-18 Thread Lennox Wu
Score can provide dummy functions if HAS_IOMEM and NO_IOMEM will be removed, even if we indeed have no IOMEM. Best, Lennox 2014-07-18 18:51 GMT+08:00 Richard Weinberger : > Am 18.07.2014 12:44, schrieb Chen Gang: >> On 07/18/2014 03:35 PM, Richard Weinberger wrote: >>> Am 18.07.2014 02:36, schri

[PATCH 3/3] staging: vme: Add missing CR in printk messages in vme_pio2_core.c

2014-07-18 Thread Masanari Iida
This patch add missing CR in messages within vme_pio2_core.c Signed-off-by: Masanari Iida --- drivers/staging/vme/devices/vme_pio2_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/vme/devices/vme_pio2_core.c b/drivers/staging/vme/devices/vm

[PATCH 2/3] staging: vme: Add missing CR in error message

2014-07-18 Thread Masanari Iida
This patch adds missing CR in dev_err message. Signed-off-by: Masanari Iida --- drivers/staging/vme/devices/vme_pio2_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/vme/devices/vme_pio2_gpio.c b/drivers/staging/vme/devices/vme_pio2_gpio.c index 55c009c

[PATCH 1/3] staging: vme: Fix typo in vme_pio2_gpio.c

2014-07-18 Thread Masanari Iida
This patch fix spelling typo in printk message. Signed-off-by: Masanari Iida --- drivers/staging/vme/devices/vme_pio2_gpio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vme/devices/vme_pio2_gpio.c b/drivers/staging/vme/devices/vme_pio2_gpio.c index 2a

[PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread Benoit Taine
We should prefer `const struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes this change is as follows (http://coccinelle.lip6.fr/): // @@ identifier i; declarer

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-18 Thread Christoph Hellwig (h...@infradead.org)
On Fri, Jul 18, 2014 at 12:51:06AM +, Elliott, Robert (Server Storage) wrote: > SYNCHRONIZE CACHE (16) should be favored over SYNCHRONIZE > CACHE (10) unless SYNCHRONIZE CACHE (10) is not supported. I gues you mean (16) for the last occurance? What's the benefit of using SYNCHRONIZE CACHE (

Re: [PATCH 1/1] [SCSI] Fix a bug in deriving the FLUSH_TIMEOUT from the basic I/O timeout

2014-07-18 Thread Christoph Hellwig (h...@infradead.org)
On Thu, Jul 17, 2014 at 11:53:33PM +, KY Srinivasan wrote: > I still see this problem. There was talk of fixing it elsewhere. Well, what we have right not is entirely broken, given that the block layer doesn't initialize ->timeout on TYPE_FS requeuests. We either need to revert that initial c

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-18 Thread Richard Weinberger
On Fri, Jul 18, 2014 at 12:55 PM, Yue Zhang wrote: > From: Yue Zhang > > This patch addresses the comment from Olaf Hering and Greg KH > for a previous commit 3a494e710367 ("hyperv: Add handler for > RNDIS_STATUS_NETWORK_CHANGE event") > > In previous solution, the driver calls "network restart"

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-18 Thread Richard Weinberger
Am 18.07.2014 12:44, schrieb Chen Gang: > On 07/18/2014 03:35 PM, Richard Weinberger wrote: >> Am 18.07.2014 02:36, schrieb Chen Gang: >>> >>> On 07/18/2014 02:09 AM, Richard Weinberger wrote: Am 17.07.2014 12:48, schrieb Arnd Bergmann: > AFAICT, NO_IOMEM only has a real purpose on UML the

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-18 Thread Chen Gang
On 07/18/2014 03:35 PM, Richard Weinberger wrote: > Am 18.07.2014 02:36, schrieb Chen Gang: >> >> On 07/18/2014 02:09 AM, Richard Weinberger wrote: >>> Am 17.07.2014 12:48, schrieb Arnd Bergmann: AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take a shortcut here and

Re: [PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-18 Thread Varka Bhadram
On 07/18/2014 04:25 PM, Yue Zhang wrote: @@ -816,8 +816,21 @@ static void netvsc_link_change(struct work_struct *w) rtnl_unlock(); - if (refresh) - call_usermodehelper(argv[0], argv, envp, UMH_WAIT_EXEC); + if (refresh) { + /* +* Keep th

[PATCH] Hyperv: Trigger DHCP renew after host hibernation

2014-07-18 Thread Yue Zhang
From: Yue Zhang This patch addresses the comment from Olaf Hering and Greg KH for a previous commit 3a494e710367 ("hyperv: Add handler for RNDIS_STATUS_NETWORK_CHANGE event") In previous solution, the driver calls "network restart" to force a DHCP renew when the host is back from hibernation. I

Re: [PATCH] Staging: panel: fixed frivilous else statement warning

2014-07-18 Thread Willy Tarreau
On Thu, Jul 10, 2014 at 03:34:28AM -0700, Vincent Heuken wrote: > Fixed one instance of the following checkpatch.pl warning in > panel.c: > WARNING: else is not generally useful after a break or return > > Signed-off-by: Vincent Heuken Acked-By: Willy Tarreau Vincent, are you currently reviewi

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

2014-07-18 Thread Richard Weinberger
Am 18.07.2014 02:36, schrieb Chen Gang: > > On 07/18/2014 02:09 AM, Richard Weinberger wrote: >> Am 17.07.2014 12:48, schrieb Arnd Bergmann: >>> AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take >>> a shortcut here and make COMPILE_TEST depend on !UML? Getting random stuff

Re: [PATCH 0/2] mmc: rtsx: add support for async request

2014-07-18 Thread Lee Jones
Chris, Ulf, Sorry for the delay, things have been hectic. The following changes since commit cd3de83f147601356395b57a8673e9c5ff1e59d1: Linux 3.16-rc4 (2014-07-06 12:37:51 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git tags/mfd-mmc-v