On Fri, Jul 18, 2014 at 04:36:42AM +, Sharma, Sanjeev wrote:
> Done ! ,Please review now.
>
Looks ok.
regards,
dan carpenter
___
devel mailing list
de...@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-dev
Done ! ,Please review now.
Regards
Sanjeev Sharma
-Original Message-
From: Dan Carpenter [mailto:dan.carpen...@oracle.com]
Sent: Thursday, July 17, 2014 2:41 PM
To: Sharma, Sanjeev
Cc: gre...@linuxfoundation.org; de...@driverdev.osuosl.org; way...@gmail.com;
swetl...@google.com; linux-k
This patch will add an blank line after
declaration reported by checkpatch.pl script.
Signed-off-by: Sanjeev Sharma
---
drivers/staging/android/sw_sync.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/android/sw_sync.c
b/drivers/staging/android/sw_sync.c
index a76db3f..86
Good day
Private Message to you,
God spoke to me in spirit to share this with you. Please kindly sympathizes
with my current situation to assist execute this noble project. My name is
Isabella Caromel, I escaped tsunami disaster some time ago which affected my
spinal cord, my ear drum and claim
Fix C99 comment
Signed-off-by: Khoa Mai
---
drivers/staging/bcm/Qos.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index c5213b3..e3cbcb1 100644
--- a/drivers/staging/bcm/Qos.c
+++ b/drivers/staging/bcm/Qos.c
Switch and case should be in same indent level
Signed-off-by: Khoa Mai
---
drivers/staging/bcm/Qos.c | 40
1 file changed, 20 insertions(+), 20 deletions(-)
diff --git a/drivers/staging/bcm/Qos.c b/drivers/staging/bcm/Qos.c
index e3cbcb1..0eb78a8 100644
On Thu, Jul 17, 2014 at 01:58:15PM -0700, Greg Kroah-Hartman wrote:
> On Thu, Jul 17, 2014 at 11:40:04PM +0530, Himangi Saraogi wrote:
> > Hi,
> >
> > I have sent in a patch for adding devm_kasprintf
> > https://lkml.org/lkml/2014/7/
> > 16/667.
> > I will be updating this file and send in a patc
Hi, Mark.
Thanks for testing.
I am trying to solve this problem with config sample which is sent by you.
regards,
Daeseok Youn.
2014-07-17 22:27 GMT+09:00 Mark Hounschell :
> On 07/16/2014 09:35 PM, Daeseok Youn wrote:
>> When a configration file is parsed with dgap_parsefile(),
>> makes nodes
On Thu, Jul 17, 2014 at 09:30:38AM +0530, Kiran Padwal wrote:
> Checkpatch fix - Add missing blank line after variable declaration
>
> Signed-off-by: Kiran Padwal
> ---
> drivers/staging/gdm724x/gdm_lte.c |2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/staging/gdm724x/gdm_
On Thu, Jul 17, 2014 at 01:26:23AM +0300, Sam Asadi wrote:
> a 'quoted string split across lines' fixed while better use of
> English applied to the text.
>
> Signed-off-by: Sam Asadi
> ---
> drivers/staging/comedi/drivers/adl_pci9118.c |3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-
On Thu, Jul 17, 2014 at 12:27:27PM -0700, H Hartley Sweeten wrote:
> Where possible, convert all the pr_{level} messages to dev_{level}.
>
> H Hartley Sweeten (5):
> staging: comedi: usbduxfast: convert pr_err() to dev_err()
> staging: comedi: usbduxfast: convert pr_warn() to dev_warn()
> st
In sd_sync_cache:
rq->timeout *= SD_FLUSH_TIMEOUT_MULTIPLIER;
Regardless of the baseline for the multiplication, a magic
number of 2 is too arbitrary. That might work for an
individual drive, but could be far too short for a RAID
controller that runs into worst case error handling for
th
On 07/18/2014 02:09 AM, Richard Weinberger wrote:
> Am 17.07.2014 12:48, schrieb Arnd Bergmann:
>> AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take
>> a shortcut here and make COMPILE_TEST depend on !UML? Getting random stuff
>> to build on UML seems pointless to me and we
On 07/18/2014 05:05 AM, Arnd Bergmann wrote:
> On Thursday 17 July 2014 16:41:14 Chris Metcalf wrote:
>> On 7/17/2014 7:28 AM, Chen Gang wrote:
>>> On 07/17/2014 06:48 PM, Arnd Bergmann wrote:
AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take
a shortcut here and ma
On Sun, Jul 13, 2014 at 08:07:00PM -0700, Jeremiah Mahler wrote:
> Place 'else' on same line as closing brace '}' as per
> Documentation/CodingStyle. Fixes 1 error found by checkpatch.pl.
>
> Signed-off-by: Jeremiah Mahler
> ---
> drivers/staging/xillybus/xillybus_core.c | 3 +--
> 1 file chang
> -Original Message-
> From: driverdev-devel-boun...@linuxdriverproject.org [mailto:driverdev-
> devel-boun...@linuxdriverproject.org] On Behalf Of KY Srinivasan
> Sent: Friday, June 20, 2014 2:37 PM
> To: Jens Axboe; James Bottomley; micha...@cs.wisc.edu
> Cc: linux-s...@vger.kernel.org;
On Thu, Jul 17, 2014 at 11:40:04PM +0530, Himangi Saraogi wrote:
> Hi,
>
> I have sent in a patch for adding devm_kasprintf https://lkml.org/lkml/2014/7/
> 16/667.
> I will be updating this file and send in a patch once it is accepted. Was it
> the right thing
> to do to send the devm_kasprintf pa
On Thu, 17 Jul 2014, Lars-Peter Clausen wrote:
> On 07/17/2014 10:40 PM, Himangi Saraogi wrote:
> > This patch introduces the use of iio_device_register and does away with
> > the call to the corressponding unregister function in the probe and
> > remove functions of the driver respectively.
> >
On Thursday 17 July 2014 16:41:14 Chris Metcalf wrote:
> On 7/17/2014 7:28 AM, Chen Gang wrote:
> > On 07/17/2014 06:48 PM, Arnd Bergmann wrote:
> >> AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take
> >> a shortcut here and make COMPILE_TEST depend on !UML? Getting random s
From: Jes Sorensen
The value saved in RegBcnCtrlVal was never used. In addition the code
was highly endian broken, declaring it as a u32, then accessing it via
a u8 * later.
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 18 +-
drivers/stagi
From: Jes Sorensen
We use the MSR bits to define link state anyway, so no point having an
additional two sets of defines for the same thing.
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_ap.c | 8 +-
drivers/staging/rtl8723au/core/rtw_mlme_ext.c | 112 +
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
.../staging/rtl8723au/include/odm_RegDefine11AC.h | 49 --
drivers/staging/rtl8723au/include/odm_precomp.h| 1 -
2 files changed, 50 deletions(-)
delete mode 100644 drivers/staging/rtl8723au/include/odm_RegDefine11AC.
From: Raphael Silva
Some corrections were made to the code in order to conform to the
Kernel Coding Style.
Jes: Fix build problem
Signed-off-by: Raphael Silva
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_sta_mgt.c | 42 ++--
1 file changed, 27 in
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_wlan_util.c| 7 +--
drivers/staging/rtl8723au/hal/hal_com.c | 8
drivers/staging/rtl8723au/hal/usb_halinit.c | 2 +-
drivers/staging/rtl8723au/include/hal_com.h | 2 +-
d
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/odm.c | 8
drivers/staging/rtl8723au/hal/odm_HWConfig.c | 2 +-
drivers/staging/rtl8723au/include/odm.h | 4
3 files changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/stagin
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/core/rtw_ap.c | 2 +-
drivers/staging/rtl8723au/core/rtw_mlme_ext.c| 18 +-
drivers/staging/rtl8723au/core/rtw_sreset.c | 2 +-
drivers/staging/rtl8723au/core/rtw_wlan_util.c | 5
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/usb_halinit.c | 3 ---
drivers/staging/rtl8723au/include/rtl8723a_hal.h | 3 ---
2 files changed, 6 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c
b/drivers/staging/rtl8723au/hal/usb_h
From: Jes Sorensen
Reduce yet another duplicate implementation of set_media_status()
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/usb_halinit.c | 13 +
drivers/staging/rtl8723au/include/rtl8723a_spec.h | 8
2 files changed, 1 insertion(+), 20 deleti
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/usb_halinit.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c
b/drivers/staging/rtl8723au/hal/usb_halinit.c
index 4161409..0c760e5 100644
--- a/drivers/staging/r
From: Jes Sorensen
Greg,
Another round of code obfuscation removal, mostly getting rid of no-op
and unncessary wrappers.
Cheers,
Jes
Jes Sorensen (12):
staging: rtl8723au: Eliminate Set_MSR() wrapper call
staging: rtl8723au: Reduce number of duplicate defines for link state
staging: rtl
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/usb_halinit.c | 50 -
1 file changed, 50 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/usb_halinit.c
b/drivers/staging/rtl8723au/hal/usb_halinit.c
index 227a363..4161409 1006
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/odm.c | 142 +++---
drivers/staging/rtl8723au/include/odm.h | 4 -
drivers/staging/rtl8723au/include/odm_interface.h | 11 +-
3 files changed, 75 insertions(+), 82 deletio
From: Jes Sorensen
Signed-off-by: Jes Sorensen
---
drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
b/drivers/staging/rtl8723au/hal/rtl8723a_hal_init.c
index 5c4751c..8523908 100644
--- a/dr
On 07/17/2014 10:40 PM, Himangi Saraogi wrote:
This patch introduces the use of iio_device_register and does away with
the call to the corressponding unregister function in the probe and
remove functions of the driver respectively.
Signed-off-by: Himangi Saraogi
Acked-by: Julia Lawall
No, yo
On 7/17/2014 7:28 AM, Chen Gang wrote:
On 07/17/2014 06:48 PM, Arnd Bergmann wrote:
AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take
a shortcut here and make COMPILE_TEST depend on !UML? Getting random stuff
to build on UML seems pointless to me and we special-case it in
This patch introduces the use of iio_device_register and does away with
the call to the corressponding unregister function in the probe and
remove functions of the driver respectively.
Signed-off-by: Himangi Saraogi
Acked-by: Julia Lawall
---
drivers/staging/iio/accel/adis16203_core.c | 3 +--
Use dev_warn() to output the warning message.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/ni_pcimio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi/drivers/ni_pcimio.c
b/drivers/staging/
Where possible, convert all the pr_{level} messages to dev_{level}.
H Hartley Sweeten (5):
staging: comedi: usbduxfast: convert pr_err() to dev_err()
staging: comedi: usbduxfast: convert pr_warn() to dev_warn()
staging: comedi: cb_pcidas64: remove unused pr_fmt() macro
staging: comedi: ni_
There are a number of pr_{level} messages in this file that are used
to print kernel messages when the device pointer is not available for
a dev_{level} message.
Use pr_fmt() to ensure all of these messages have the module prefix.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-H
This function checks the cmd->chanlist to determine the scan mode
used to sample the analog inputs. All possible modes are checked
so the final pr_err() and return 0 can never be reached.
Tidy up the function a bit and remove the unreachable code.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Use dev_err() to output the error message and remove the unnecessary
pr_fmt() macro.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/usbduxfast.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/staging
This macro is not used. Remove it.
Signed-off-by: H Hartley Sweeten
Cc: Ian Abbott
Cc: Greg Kroah-Hartman
---
drivers/staging/comedi/drivers/cb_pcidas64.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c
b/drivers/staging/comedi/drivers/cb_pcid
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character.
All of the users of this function have been converted to use dev_err()
directly. Remove the now unused function.
Signed-off-by: H Hartl
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
The comedi_error() function is just a wrapper around dev_err() that adds
the dev->driver->driver_name prefix to the message and a terminating
new-line character. The addition of the driver_name is just added noise
and some of the users of comedi_error() add unnecessary additional new-line
character
Good Day,
It is my desire to introduce this business to you and hoping you will take
the opportunity for our mutual benefits. I contact you through this medium
now in order to provide the link for detail discussion. I will provide
more information with my personal resume for your acquaintance an
Am 17.07.2014 12:48, schrieb Arnd Bergmann:
> AFAICT, NO_IOMEM only has a real purpose on UML these days. Could we take
> a shortcut here and make COMPILE_TEST depend on !UML? Getting random stuff
> to build on UML seems pointless to me and we special-case it in a number of
> places already.
If UM
The kbuild test robot reported a build error on ARCH=arm about
implicit declaration of the functions 'kmalloc' and 'kfree'.
On ARCH=x86 the slab.h header is indirectly included by pci.h,
this does not occur on ARCH=arm.
Include slab.h directly instead of relying on some other header
to include it
These patches simplify the code in the visorchipset module, in preparation for
moving the module's proc entries to sysfs.
Benjamin Romer (2):
staging: unisys: simplify controlvm channel address function
staging: unisys: detect controlvm channel on module load
drivers/staging/unisys/visorchip
The controlvm channel is not removable from a guest after the guest starts,
so it makes no sense to constantly check for it. Move the channel address
discovery to visorchipset_init(), and remove all of the checks for the channel
address from the rest of the module, as the module will not load if th
There is no reason to have controlvm_get_channel_address() defined in a
separate file. Move it to visorchipset_main.c, remove the no-op functions
controlvm_init() and controlvm_deinit() from visorchipset_main.c, and remove
the controlvm.h and controlvm_direct.c files from the module.
Signed-off-by
Dropped some "< 0" and ">= 0" checks on unsigned int values.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=80501
Reported-by: David Binderman
Signed-off-by: Andrey Utkin
---
.../comedi/drivers/addi-data/hwdrv_apci3200.c| 20 ++--
1 file changed, 10 insertions(+),
[linux-3.16-rc5/drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:210]:
(style) Checking if unsigned variable 'val' is less than zero.
val = get_oneshot_mode(ipipeif->input);
if (val < 0) {
pr_err("ipipeif: links setup required");
return -EINVAL;
}
but
static int get
Removed dump_eth_packet() and helper functions called upon packet tx/rx.
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_wimax.c | 106
1 file changed, 106 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers/staging/gdm72x
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_sdio.c | 15 +++
drivers/staging/gdm72xx/gdm_usb.c | 10 ++
2 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_sdio.c
b/drivers/staging/gdm72xx/gdm_sdio.c
index 6a23bef..
The dedicated memory management routines have been replaced with devres API,
so the related part is removed from the doc.
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/README | 23 ---
1 files changed, 0 insertions(+), 23 deletions(-)
diff --git a/drivers/stagin
According to Documentation/CodingStyle, when one branch of an if-else
statement has multiple statements, both branches should be enclosed in curly
brackets.
Signed-off-by: Eli Billauer
---
drivers/staging/xillybus/xillybus_core.c |7 ---
1 files changed, 4 insertions(+), 3 deletions(-)
On 07/16/2014 09:35 PM, Daeseok Youn wrote:
> When a configration file is parsed with dgap_parsefile(),
> makes nodes for saving configrations for board.
>
> Making a node will allocate node memory and strings for saving
> configrations with kstrdup().
>
> So these are freed when dgap is unloaded
> "Christoph" == hch@infradead org writes:
Christoph> That's mostly because we don't support larger than 512 byte
Christoph> TRIM payloads yet..
I did add support for that a few years back but all hell broke loose and
we had to revert it. There were several drives that failed with more
than
On 07/16/2014 08:42 PM, DaeSeok Youn wrote:
2014-07-16 23:17 GMT+09:00 Mark Hounschell :
On 07/16/2014 05:26 AM, DaeSeok Youn wrote:
2014-07-16 8:50 GMT+09:00 Greg KH :
On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote:
Hi,
2014-07-16 0:29 GMT+09:00 Greg KH :
On Tue, Jul 15,
On 2014-07-16 17:36, Hartley Sweeten wrote:
On Wednesday, July 16, 2014 3:54 AM, Ian Abbott wrote:
On 2014-07-14 20:23, H Hartley Sweeten wrote:
The ni_mio_common.c file is included by a number of National Instruments
drivers to provide the "common" driver support. This series does some
more cl
On 07/17/2014 06:38 PM, Arnd Bergmann wrote:
> On Thursday 17 July 2014 17:29:31 Chen Gang wrote:
>>>
>>> COMPILE_TEST is a great tool in general, but it has its limits.
>>> In particular, the case for !CONFIG_IOMEM is completely obscure
>>> and we won't find any bugs by allowing more drivers to
On 07/17/2014 06:58 PM, Richard Weinberger wrote:
> Am 17.07.2014 12:28, schrieb Arnd Bergmann:
>> On Thursday 17 July 2014 11:26:57 Richard Weinberger wrote:
>>> Am 17.07.2014 11:20, schrieb Arnd Bergmann:
On Thursday 17 July 2014 09:27:58 Chen Gang wrote:
>
On 07/17/2014 06:48 PM, Arnd Bergmann wrote:
> On Thursday 17 July 2014 12:40:25 Lars-Peter Clausen wrote:
>> On 07/17/2014 11:20 AM, Arnd Bergmann wrote:
>>> On Thursday 17 July 2014 09:27:58 Chen Gang wrote:
gfp_t gfp_mask, unsigned int
order);
On Thursday 17 July 2014 12:58:55 Richard Weinberger wrote:
> > This is what I got upon trying earlier. I have not attempted to look into
> > why this is happening. Note this is on linux-next from yesterday,
> > not mainline as I incorrectly stated above.
> >
> > In file included from ../arch/um/i
On 07/17/2014 06:55 PM, Thierry Reding wrote:
> On Thu, Jul 17, 2014 at 12:33:32PM +0200, Arnd Bergmann wrote:
>> On Thursday 17 July 2014 11:56:58 Thierry Reding wrote:
>>> On Thu, Jul 17, 2014 at 11:20:36AM +0200, Arnd Bergmann wrote:
>>> [...]
score should set HAS_IO
Am 17.07.2014 12:28, schrieb Arnd Bergmann:
> On Thursday 17 July 2014 11:26:57 Richard Weinberger wrote:
>> Am 17.07.2014 11:20, schrieb Arnd Bergmann:
>>> On Thursday 17 July 2014 09:27:58 Chen Gang wrote:
gfp_t gfp_mask, unsigned int
order);
>>
On Thu, Jul 17, 2014 at 12:33:32PM +0200, Arnd Bergmann wrote:
> On Thursday 17 July 2014 11:56:58 Thierry Reding wrote:
> > On Thu, Jul 17, 2014 at 11:20:36AM +0200, Arnd Bergmann wrote:
> > [...]
> > > score should set HAS_IOMEM and doesn't
> > > even have public compilers
>
On Thursday 17 July 2014 12:40:25 Lars-Peter Clausen wrote:
> On 07/17/2014 11:20 AM, Arnd Bergmann wrote:
> > On Thursday 17 July 2014 09:27:58 Chen Gang wrote:
> >> gfp_t gfp_mask, unsigned int
> >> order);
> >> extern void devm_free_pages(struct devic
On 07/17/2014 11:20 AM, Arnd Bergmann wrote:
On Thursday 17 July 2014 09:27:58 Chen Gang wrote:
gfp_t gfp_mask, unsigned int order);
extern void devm_free_pages(struct device *dev, unsigned long addr);
+#ifdef CONFIG_HAS_IOMEM
void __iomem *devm_ior
On Thursday 17 July 2014 17:29:31 Chen Gang wrote:
> >
> > COMPILE_TEST is a great tool in general, but it has its limits.
> > In particular, the case for !CONFIG_IOMEM is completely obscure
> > and we won't find any bugs by allowing more drivers to be built
> > in those configurations, but attemp
On Thursday 17 July 2014 11:56:58 Thierry Reding wrote:
> On Thu, Jul 17, 2014 at 11:20:36AM +0200, Arnd Bergmann wrote:
> [...]
> > score should set HAS_IOMEM and doesn't
> > even have public compilers
>
> This begs an interesting question. Should it be made a requirement to
On Thursday 17 July 2014 11:26:57 Richard Weinberger wrote:
> Am 17.07.2014 11:20, schrieb Arnd Bergmann:
> > On Thursday 17 July 2014 09:27:58 Chen Gang wrote:
> >> gfp_t gfp_mask, unsigned int
> >> order);
> >> extern void devm_free_pages(struct device *
1 - 100 of 114 matches
Mail list logo
