[PATCH 1/1] staging: ion: Remove left over comment

Commit 2bb9f5034ec7 ("gpu: ion: Remove heapmask from client") removed the heap_type_mask parameter. Remove the associated kernel-doc comment too. Signed-off-by: Sachin Kamat Cc: Rebecca Schultz Zavin Cc: John Stultz --- drivers/staging/android/ion/ion.h |1 - 1 file changed, 1 deletion(-)

[PATCH] Staging: gdm724x: gdm_tty.c: fix missing blank line after variable declaration

Checkpatch fix - Add missing blank line after variable declaration Signed-off-by: Kiran Padwal --- drivers/staging/gdm724x/gdm_tty.c |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/gdm724x/gdm_tty.c b/drivers/staging/gdm724x/gdm_tty.c index fe47cd3..001348c 100644 --

[PATCH] Staging: gdm724x: gdm_lte.c: fix missing blank line after variable declaration

Checkpatch fix - Add missing blank line after variable declaration Signed-off-by: Kiran Padwal --- drivers/staging/gdm724x/gdm_lte.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c index 64c55b9..bc6d574 100644 --- a

Re: [PATCH] Staging: gdm724x: fix missing blank line after variable declaration

Hi, On Thu, Jul 17, 2014 at 2:00 AM, Greg KH wrote: > On Wed, Jul 16, 2014 at 04:55:23PM +0530, Kiran Padwal wrote: >> From: Kiran Padwal >> >> Checkpatch fix - Add missing blank line after variable declaration >> >> Signed-off-by:Kiran Padwal > > Minor nit, you need a ' ' after the ':'. > > Al

[PATCH V2] staging: rtl8192ee: Fix setting highest n rate

Commit 4fb6a37c3f94c1cb4b828bfcc4347771e1628f88 by Andrey Utkin and entitled "staging: rtl8192ee: "Correct bitmask in comparsion" fixed what appeared to be a typo. After consultation with the Realtek engineers, merely testing for a 2T2R device is sufficient to ensure that the TX MCS map will equal

Re: [PATCH 2/2] staging: comedi: addi_apci_1564: use addi_watchdog module to init watchdog subdevice

On Tue, Jul 15, 2014 at 5:14 AM, Ian Abbott wrote: > On 2014-07-15 05:00, Chase Southwood wrote: >> >> On Mon, Jul 14, 2014 at 4:22 AM, Ian Abbott wrote: >>> >>> On 2014-07-12 23:44, Chase Southwood wrote: Use the addi_watchdog module to provide support for the watchdog subdev

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

On 07/16/2014 06:27 PM, Chen Gang wrote: On 07/15/2014 10:38 PM, Chen Gang wrote: On 07/15/2014 09:11 AM, Chen Gang wrote: On 07/15/2014 08:53 AM, Guenter Roeck wrote: On 07/14/2014 05:34 PM, Chen Gang wrote: On 07/14/2014 05:22 PM, Chen Gang wrote: 在 2014年7月14日，下午4:57，Richard Weinberge

[PATCH] staging: dgap: introduce dgap_cleanup_nodes()

When a configration file is parsed with dgap_parsefile(), makes nodes for saving configrations for board. Making a node will allocate node memory and strings for saving configrations with kstrdup(). So these are freed when dgap is unloaded or failed to initialize. Signed-off-by: Daeseok Youn --

Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource'

On 07/15/2014 10:38 PM, Chen Gang wrote: > On 07/15/2014 09:11 AM, Chen Gang wrote: >> >> >> On 07/15/2014 08:53 AM, Guenter Roeck wrote: >>> On 07/14/2014 05:34 PM, Chen Gang wrote: On 07/14/2014 05:22 PM, Chen Gang wrote: > > 在 2014年7月14日，下午4:57，Richard Weinberger 写道： > >>

Re: How to replace control code in gdm72xx?

On Wed, Jul 16, 2014 at 1:40 PM, Greg KH wrote: > > On Wed, Jul 16, 2014 at 09:24:28PM +0100, Michalis Pappas wrote: > > Hi, > > > > I'm currently working on bringing the gdm72xx WiMAX driver out of > > staging. The driver currently uses two control channels: > > > > 1. The SIOCDEVPRIVATE ioctl to

Re: [PATCH 6/8 V2] staging: dgap: remove unneeded dgap_err()

2014-07-17 3:47 GMT+09:00 Greg KH : > On Wed, Jul 16, 2014 at 06:26:17PM +0900, DaeSeok Youn wrote: >> 2014-07-16 8:50 GMT+09:00 Greg KH : >> > On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote: >> >> Hi, >> >> >> >> 2014-07-16 0:29 GMT+09:00 Greg KH : >> >> > On Tue, Jul 15, 2014 at 06:

Re: [PATCH 6/8 V2] staging: dgap: remove unneeded dgap_err()

2014-07-16 23:17 GMT+09:00 Mark Hounschell : > On 07/16/2014 05:26 AM, DaeSeok Youn wrote: >> >> 2014-07-16 8:50 GMT+09:00 Greg KH : >> >>> On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote: Hi, 2014-07-16 0:29 GMT+09:00 Greg KH : > > On Tue, Jul 15, 2014 at 0

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

On Wed, 2014-07-16 at 15:57 -0700, Greg KH wrote: > On Wed, Jul 16, 2014 at 03:46:09PM -0700, Joe Perches wrote: > > On Wed, 2014-07-16 at 15:10 -0700, Greg KH wrote: > > > On Wed, Jul 16, 2014 at 11:03:06PM +0100, Michalis Pappas wrote: > > [] > > > > Ok, I agree on the ifdef stuff. My question wa

Re: [PATCH 7/8 RESEND] staging: dgap: introduce dgap_cleanup_nodes()

Hi, Mark Thanks for reply. 2014-07-16 21:39 GMT+09:00 Mark Hounschell : > On 07/15/2014 11:30 AM, Greg KH wrote: >> >> On Tue, Jul 15, 2014 at 06:14:25PM +0900, Daeseok Youn wrote: >>> >>> When a configration file is parsed with dgap_parsefile(), >>> makes nodes for saving configrations for board

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

On Wed, 2014-07-16 at 15:10 -0700, Greg KH wrote: > On Wed, Jul 16, 2014 at 11:03:06PM +0100, Michalis Pappas wrote: [] > > Ok, I agree on the ifdef stuff. My question was regarding your > > suggestion above to replace print_hex_debug() with dev_dbg() > > You want the device name/id/label to show

[PATCH] lustre: plain interger was used as NULL pointer

This patch fixes the following warnings found when running sparse: .../lproc_echo.c:43:11: warning: Using plain integer as NULL pointer .../lproc_echo.c:49:11: warning: Using plain integer as NULL pointer Signed-off-by: Josep Puigdemont --- drivers/staging/lustre/lustre/obdecho/lproc_echo.c | 4

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

On Wed, Jul 16, 2014 at 03:46:09PM -0700, Joe Perches wrote: > On Wed, 2014-07-16 at 15:10 -0700, Greg KH wrote: > > On Wed, Jul 16, 2014 at 11:03:06PM +0100, Michalis Pappas wrote: > [] > > > Ok, I agree on the ifdef stuff. My question was regarding your > > > suggestion above to replace print_hex

[PATCH 1/1] Staging: adl_pci9118: a style issue fixed

a 'quoted string split across lines' fixed while better use of English applied to the text. Signed-off-by: Sam Asadi --- drivers/staging/comedi/drivers/adl_pci9118.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/s

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

On Wed, Jul 16, 2014 at 11:03:06PM +0100, Michalis Pappas wrote: > On 07/16/2014 09:50 PM, Greg KH wrote: > > On Wed, Jul 16, 2014 at 09:40:18PM +0100, Michalis Pappas wrote: > >> On 07/09/2014 07:51 PM, Greg KH wrote: > diff --git a/drivers/staging/gdm72xx/gdm_sdio.c > b/drivers/staging

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

On 07/16/2014 09:50 PM, Greg KH wrote: > On Wed, Jul 16, 2014 at 09:40:18PM +0100, Michalis Pappas wrote: >> On 07/09/2014 07:51 PM, Greg KH wrote: diff --git a/drivers/staging/gdm72xx/gdm_sdio.c b/drivers/staging/gdm72xx/gdm_sdio.c index 9d2de6f..914fd75 100644 --- a/drivers/s

Re: [PATCH 03/32] staging: comedi: comedidev.h: checkpatch.pl cleanup (else after return)

On Wed, Jul 16, 2014 at 09:27:02PM +, Hartley Sweeten wrote: > On Wednesday, July 16, 2014 1:34 PM, Greg KH wrote: > > On Wed, Jul 16, 2014 at 10:43:14AM -0700, H Hartley Sweeten wrote: > >> Fix the checkpatch.pl warning in this file: > >> > >> WARNING: else is not generally useful after a bre

RE: [PATCH 03/32] staging: comedi: comedidev.h: checkpatch.pl cleanup (else after return)

On Wednesday, July 16, 2014 1:34 PM, Greg KH wrote: > On Wed, Jul 16, 2014 at 10:43:14AM -0700, H Hartley Sweeten wrote: >> Fix the checkpatch.pl warning in this file: >> >> WARNING: else is not generally useful after a break or return >> >> Also, for aesthetics, rename the comedi_subdevice param

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

On Wed, Jul 16, 2014 at 09:40:18PM +0100, Michalis Pappas wrote: > On 07/09/2014 07:51 PM, Greg KH wrote: > >> diff --git a/drivers/staging/gdm72xx/gdm_sdio.c > >> b/drivers/staging/gdm72xx/gdm_sdio.c > >> index 9d2de6f..914fd75 100644 > >> --- a/drivers/staging/gdm72xx/gdm_sdio.c > >> +++ b/drive

Re: How to replace control code in gdm72xx?

On Wed, Jul 16, 2014 at 09:24:28PM +0100, Michalis Pappas wrote: > Hi, > > I'm currently working on bringing the gdm72xx WiMAX driver out of > staging. The driver currently uses two control channels: > > 1. The SIOCDEVPRIVATE ioctl to send and receive state messages > > 2. A customly defined net

Re: [PATCH] staging: gdm72xx: conditionally compile debug code

On 07/09/2014 07:51 PM, Greg KH wrote: >> diff --git a/drivers/staging/gdm72xx/gdm_sdio.c >> b/drivers/staging/gdm72xx/gdm_sdio.c >> index 9d2de6f..914fd75 100644 >> --- a/drivers/staging/gdm72xx/gdm_sdio.c >> +++ b/drivers/staging/gdm72xx/gdm_sdio.c >> @@ -280,9 +280,11 @@ static void send_sdu(st

Re: [PATCH 01/32] staging: comedi: comedi_fops: checkpatch.pl cleanup (else after return)

On Wed, Jul 16, 2014 at 10:43:12AM -0700, H Hartley Sweeten wrote: > Fix the two checkpatch.pl warnings in this file: > > WARNING: else is not generally useful after a break or return > > Signed-off-by: H Hartley Sweeten > Cc: Ian Abbott > --- > drivers/staging/comedi/comedi_fops.c | 9 ---

Re: [PATCH 02/32] staging: comedi: comedi.h: checkpatch.pl cleanup (else after return)

On Wed, Jul 16, 2014 at 10:43:13AM -0700, H Hartley Sweeten wrote: > Fix the two checkpatch.pl warnings in this file: > > WARNING: else is not generally useful after a break or return > > Signed-off-by: H Hartley Sweeten > Cc: Ian Abbott > --- > drivers/staging/comedi/comedi.h | 8 >

Re: [PATCH 03/32] staging: comedi: comedidev.h: checkpatch.pl cleanup (else after return)

On Wed, Jul 16, 2014 at 10:43:14AM -0700, H Hartley Sweeten wrote: > Fix the checkpatch.pl warning in this file: > > WARNING: else is not generally useful after a break or return > > Also, for aesthetics, rename the comedi_subdevice parameter from > 'subd' to 's' since this is the norm for comedi

Re: [PATCH 0/2] Staging: Comedi: adl_pci9118: 2 style issues fixed

On Wed, Jul 16, 2014 at 06:22:58PM +0300, Sam Asadi wrote: > 2 style issues fixed: one misspelling & a quoted string split across lines. > > Sam Asadi (2): > Staging: comedi: adl_pci9118: a style issue fixed > Staging: comedi: adl_pci9118: fractured spelling fixed > > drivers/staging/comedi/

Re: [PATCH] Staging: gdm724x: fix missing blank line after variable declaration

On Wed, Jul 16, 2014 at 04:55:23PM +0530, Kiran Padwal wrote: > From: Kiran Padwal > > Checkpatch fix - Add missing blank line after variable declaration > > Signed-off-by:Kiran Padwal Minor nit, you need a ' ' after the ':'. Also, you sent me two different patches, with the same Subject: lin

Re: [PATCH] Staging: comedi: adl_pci9118: a style issue fixed

On Wed, Jul 16, 2014 at 03:24:12PM +0300, Sam Asadi wrote: > 'quoted string split across lines' warning in checkpatching fixed > by group whole string in one line. > > Signed-off-by: Sam Asadi > --- > drivers/staging/comedi/drivers/adl_pci9118.c |3 +-- > 1 file changed, 1 insertion(+), 2 de

How to replace control code in gdm72xx?

Hi, I'm currently working on bringing the gdm72xx WiMAX driver out of staging. The driver currently uses two control channels: 1. The SIOCDEVPRIVATE ioctl to send and receive state messages 2. A customly defined netlink protocol for passing messages verbatim to the device controller AFAIK both

[PATCH 3/3] Staging: adl_pci9118: a language issue fixed

For better use of English, 'mixtured' which is not right, replaced by 'mixed'. Signed-off-by: Sam Asadi --- drivers/staging/comedi/drivers/adl_pci9118.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/d

Re: [PATCH 01/15] staging: comedi: ni_daq_700: remove unnecessary enable and flush of ADC

On Wed, Jul 16, 2014 at 05:25:30PM +, Hartley Sweeten wrote: > On Wednesday, July 16, 2014 4:35 AM, Ian Abbott wrote: > > On 2014-07-15 01:20, H Hartley Sweeten wrote: > >> The ADC conversions are enabled and the FIFO is flushed by > >> daq700_ai_config() > >> when the driver is initially atta

[PATCH] staging: unisys: added virtpci info entry

This patch adds the virtpci debugfs directory and the info entry inside of it. Signed-off-by: Erik Arfvidson Signed-off-by: Benjamin Romer --- v6: Edit version description and add MAX_BUF documentation v5: Adjusted comments and formatting, remove info_debugfs_entry unused dentry structure v

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

> "James" == James Bottomley writes: James> Well, your judgement: is this situation (support for UNMAP but James> not for WRITE_SAME) in what is effectively a RAID driver (hv James> drivers count as RAID) just a silly Microsoft one off? I only recall seeing one or two devices that supported

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

On Wed, 2014-07-16 at 15:08 -0400, Martin K. Petersen wrote: > > "James" == James Bottomley writes: > > James> It's the code we identified in sd.c:read_capacity_16(): > > That's there to support devices that implement thin provisioning but > which predate the LBP VPD page. And thus have no w

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

> "Rob" == Elliott, Robert (Server Storage) writes: Rob> WRITE SAME with the UNMAP bit set to one (and a few other Rob> conditions) guarantees that the data is zeroed out, while the UNMAP Rob> command is just a hint. They're not fully interchangeable. Which Rob> semantics are implied by REQ

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

> "James" == James Bottomley writes: James> It's the code we identified in sd.c:read_capacity_16(): That's there to support devices that implement thin provisioning but which predate the LBP VPD page. And thus have no way to tell us their preferred command variant. James> If the inquiry sho

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

On Wed, 2014-07-16 at 14:45 -0400, Martin K. Petersen wrote: > > "James" == James Bottomley writes: > > >> I don't have a problem with a BLIST_PREFER_UNMAP flag or something > >> like that. But BLIST_TRY_VPD_PAGES seems more generally useful and it > >> does fix the problem at hand. That's wh

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

> "James" == James Bottomley writes: >> I don't have a problem with a BLIST_PREFER_UNMAP flag or something >> like that. But BLIST_TRY_VPD_PAGES seems more generally useful and it >> does fix the problem at hand. That's why I went that route. James> Hang on ... unless we apply Christoph or m

RE: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of James Bottomley > Sent: Wednesday, 16 July, 2014 1:02 PM > To: martin.peter...@oracle.com > Cc: linux-ker...@vger.kernel.org; h...@infradead.org; > de...@linuxdriverproj

Re: [PATCH 6/8 V2] staging: dgap: remove unneeded dgap_err()

On Wed, Jul 16, 2014 at 06:26:17PM +0900, DaeSeok Youn wrote: > 2014-07-16 8:50 GMT+09:00 Greg KH : > > On Wed, Jul 16, 2014 at 08:21:30AM +0900, DaeSeok Youn wrote: > >> Hi, > >> > >> 2014-07-16 0:29 GMT+09:00 Greg KH : > >> > On Tue, Jul 15, 2014 at 06:11:44PM +0900, Daeseok Youn wrote: > >> >> T

[PATCH 14/16] staging: comedi: ni_mio_common: checkpatch.pl cleanup (braces not necessary)

Fix the checkpatch.pl warnings: WARNING: braces {} are not necessary for single statement blocks WARNING: braces {} are not necessary for any arm of this statement Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 8 +++

[PATCH 04/16] staging: comedi: cb_pcidas64: remove 'volatile' from private data

As indicated by checkpatch.pl, "WARNING: Use of volatile is usually wrong: ...". The variables in the private data that are marked volatile don't need to be. Remove the volatile. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas

[PATCH 03/16] staging: comedi: amcc_s5933.h: checkpatch.pl cleanup (space prohibited)

Fix this checkpatch.pl warning: WARNING: space prohibited between function name and open parenthesis '(' Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amcc_s5933.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/d

[PATCH 12/16] staging: comedi: ni_660x: checkpatch.pl cleanup (trailing whitespace)

Fix the checkpatch.pl error: ERROR: trailing whitespace Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_660x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_660x.c b/drivers/s

[PATCH 06/16] staging: comedi: daqboard2000: checkpatch.pl cleanup (space before tab)

Fix these checkpatch.pl warnings: WARNING: please, no space before tabs Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/daqboard2000.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/comedi/d

[PATCH 16/16] staging: comedi: ni_labpc.h: checkpatch.pl cleanup (unnecessary space)

Fix the checkpatch.pl warning: WARNING: Unnecessary space before function pointer arguments Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_labpc.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/stag

[PATCH 13/16] staging: comedi: ni_660x: checkpatch.pl cleanup (space prohibited)

Fix the checkpatch.pl warning: WARNING: space prohibited before semicolon Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_660x.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers

[PATCH 00/16] staging: comedi: checkpatch.pl cleanup (pass 3)

More cleaning up of checkpatch.pl issues: WARNING: Missing a blank line after declarations WARNING: Possible switch case/default not preceeded by break or fallthrough comment WARNING: space prohibited between function name and open parenthesis '(' WARNING: Use of volatile is usually wrong: ... WA

[PATCH 01/16] staging: comedi: adv_pci_dio: checkpatch.pl cleanup (missing blank line)

Fix this checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci_dio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/comedi/drivers/adv_pci_d

[PATCH 05/16] staging: comedi: cb_pcidas64: remove 'volatile' from set_dac_range_bits() param

As indicated by checkpatch.pl, "WARNING: Use of volatile is usually wrong: ...". The 'bits' parameter to this function does not need to be volatile. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas64.c | 2 +- 1 file changed, 1

[PATCH 09/16] staging: comedi: me4000: checkpatch.pl cleanup (complex macro)

Fix the checkpatch.pl error: ERROR: Macros with complex values should be enclosed in parenthesis This define is not used in the driver. Just remove it. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/me4000.c | 1 - 1 file changed, 1

[PATCH 15/16] staging: comedi: ni_tio: checkpatch.pl cleanup (braces not necessary)

Fix the checkpatch.pl warnings: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 11/16] staging: comedi: pcl724: checkpatch.pl cleanup (foo*/foo *)

Fix the checkpatch.pl error: ERROR: "(foo*)" should be "(foo *)" Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcl730.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/pcl730.c b/dr

[PATCH 10/16] staging: comedi: serial2000: checkpatch.pl cleanup (kmalloc_array)

Fix the checkpatch.pl warning: WARNING: Prefer kmalloc_array over kmalloc with multiply Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/serial2002.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/st

[PATCH 07/16] staging: comedi: das16m1: remove 'volatile' from private data

As indicated by checkpatch.pl, "WARNING: Use of volatile is usually wrong: ...". The variables in the private data that are marked volatile don't need to be. Remove the volatile. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16m1.c

[PATCH 08/16] staging: comedi: das1800: remove 'volatile' from private data

As indicated by checkpatch.pl, "WARNING: Use of volatile is usually wrong: ...". The variables in the private data that are marked volatile don't need to be. Remove the volatile. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c

[PATCH 02/16] staging: comedi: adv_pci_dio: checkpatch.pl cleanup (fallthrough)

Fix these checkpatch.pl warnings: WARNING: Possible switch case/default not preceeded by break or fallthrough comment Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci_dio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

On Wed, 2014-07-16 at 13:47 -0400, Martin K. Petersen wrote: > > "Christoph" == hch@infradead org writes: > > Christoph> Oh, we actually have devices that support WRITE SAME with > Christoph> unmap, but not without? That's defintively a little strange. > > Yep :( > > There were several SSD

[PATCH 11/22] staging: comedi: jr3_pci: checkpatch.pl cleanup (missing blank line)

Fix checkpatch.pl warnings: WARNING: Missing a blank line after declarations Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/jr3_pci.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/comedi/drive

[PATCH 21/22] staging: comedi: mite: checkpatch.pl cleanup (missing blank line)

Fix the checkpatch.pl warnings: WARNING: Missing a blank line after declarations Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/mite.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/comedi/drivers/mite.c b/dri

[PATCH 19/22] staging: comedi: ni_pcidio: checkpatch.pl cleanup (missing blank line)

Fix the checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_pcidio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/comedi/drivers/ni_pcidio.

[PATCH 18/22] staging: comedi: ni_660x: checkpatch.pl cleanup (missing blank line)

Fix the checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_660x.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/comedi/drivers/ni_660x.c b/d

[PATCH 16/22] staging: comedi: pcmuio: checkpatch.pl cleanup (missing blank line)

Fix the checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/pcmuio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/comedi/drivers/pcmuio.c b/dri

[PATCH 13/22] staging: comedi: serial2000: checkpatch.pl cleanup (missing blank line)

Fix the checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/serial2002.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/comedi/drivers/serial200

[PATCH 15/22] staging: comedi: ni_at_a2150: checkpatch.pl cleanup (missing blank line)

Fix the checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_at_a2150.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/comedi/drivers/ni_at_a215

[PATCH 14/22] staging: comedi: serial2000: reduce indent level of serial2002_setup_subdevs()

Tidy up this function a bit to reduce the indent level. This also fixex the checkpatch.pl warning: WARNING: else is not generally useful after a break or return Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/serial2002.c | 102 ++

[PATCH 22/22] staging: comedi: ni_tio: checkpatch.pl cleanup (missing blank line)

Fix the checkpatch.pl warnings: WARNING: Missing a blank line after declarations Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/comedi/drivers/ni_tio.c b/dr

[PATCH 20/22] staging: comedi: ni_mio_common: checkpatch.pl cleanup (missing blank line)

Fix the checkpatch.pl warnings: WARNING: Missing a blank line after declarations Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/staging/comedi/d

[PATCH 12/22] staging: comedi: comedi_test: checkpatch.pl cleanup (break is not useful)

Fix the checkpatch.pl warning: WARNING: break is not useful after a goto or return Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/comedi_test.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/comedi

[PATCH 06/22] staging: comedi: cd_pcidas64: checkpatch.pl cleanup (void function return)

Fix the checkpatch.pl warning: WARNING: void function return statements are not generally useful Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas64.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/

[PATCH 17/22] staging: comedi: multiq3: checkpatch.pl cleanup (missing blank line)

Fix the checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/multiq3.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/dr

[PATCH 09/22] staging: comedi: dt2815: checkpatch.pl cleanup (missing blank line)

Fix checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt2815.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/comedi/drivers/dt2815.c b/drivers

[PATCH 10/22] staging: comedi: dt9812: checkpatch.pl cleanup (missing blank line)

Fix checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/dt9812.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/comedi/drivers/dt9812.c b/drivers

[PATCH 07/22] staging: comedi: das16: checkpatch.pl cleanup (missing blank line)

Fix thess checkpatch.pl warnings: WARNING: Missing a blank line after declarations Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das16.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/come

[PATCH 03/22] staging: comedi: amplc_pc236: checkpatch.pl cleanup (missing blank line)

Fix this checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_pc236.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/staging/comedi/drivers/amplc_pc2

[PATCH 08/22] staging: comedi: das1800: checkpatch.pl cleanup (void function return)

Fix the checkpatch.pl warning: WARNING: void function return statements are not generally useful Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c | 13 - 1 file changed, 13 deletions(-) diff --git a/drivers/stagin

[PATCH 02/22] staging: comedi: adv_pci1723: checkpatch.pl cleanup (missing blank line)

Fix this checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/adv_pci1723.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/com

[PATCH 05/22] staging: comedi: cb_pcidas64: checkpatch.pl cleanup (missing blank line)

Fix this checkpatch.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas64.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/comedi/drivers/cb_pc

[PATCH 04/22] staging: comedi: amplc_pci230: checkpatch.pl cleanup (void function return)

Fix the checkpatch.pl warning in this file: WARNING: void function return statements are not generally useful Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_pci230.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/sta

[PATCH 00/22] staging: comedi: checkpatch.pl cleanup (pass 2)

Continue cleaning up the checkpatch.pl issues. This pass gets the: WARNING: void function return statements are not generally useful WARNING: Missing a blank line after declarations It also fixes this one that was missed in the serial2000 driver: WARNING: else is not generally useful after a bre

[PATCH 01/22] staging: comedi: 8253.h: checkpatch.pl cleanup (void function return)

Fix the checkpatch.pl warning in this file: WARNING: void function return statements are not generally useful Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/8253.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/com

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

On Wed, Jul 16, 2014 at 01:47:35PM -0400, Martin K. Petersen wrote: > There were several SSDs that did not want to support wearing out flash > by writing gobs of zeroes and only support the UNMAP case. Given that SSDs usually aren't hard provisioned anyway that seems like an odd decision. But SAS

[PATCH 28/32] staging: comedi: ni_tiocmd: checkpatch.pl cleanup (break is not useful)

Fix the checkpatch.pl warning: WARNING: break is not useful after a goto or return Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tiocmd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/ni_tiocmd.

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

> "Christoph" == hch@infradead org writes: Christoph> Oh, we actually have devices that support WRITE SAME with Christoph> unmap, but not without? That's defintively a little strange. Yep :( There were several SSDs that did not want to support wearing out flash by writing gobs of zeroes an

[PATCH 17/32] staging: comedi: cb_pcidas64: checkpatch.pl cleanup (break not useful)

Fix the checkpatch.pl warnings: WARNING: break is not useful after a goto or return Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas64.c | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/comedi/driver

[PATCH 31/32] staging: comedi: ni_tio_internal.c: checkpatch.pl cleanup (break is not useful)

Fix the checkpatch.pl warning: WARNING: break is not useful after a goto or return Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_tio_internal.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/ni

[PATCH 16/32] staging: comedi: s526: checkpatch.pl cleanup (break not useful)

Fix the checkpatch.pl warning: WARNING: break is not useful after a goto or return Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/s526.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/s526.c b/drive

[PATCH 29/32] staging: comedi: ni_labpc: checkpatch.pl cleanup (else is not useful)

Fix the checkpatch.pl warning: WARNING: else is not generally useful after a break or return Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_labpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/sta

[PATCH 30/32] staging: comedi: das08: checkpatch.pl cleanup (break is not useful)

Fix the checkpatch.pl warning: WARNING: break is not useful after a goto or return Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das08.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/comedi/drivers/das08.c b/dri

[PATCH 05/32] staging: comedi: 8255: checkpatch.pl cleanup (else after return)

Fix the checkpatch.pl warning in this file: WARNING: else is not generally useful after a break or return Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/8255.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/driv

[PATCH 24/32] staging: comedi: usbdux: checkpatch.pl cleanup (else not useful)

Fix the checkpatch.pl warning: WARNING: else is not generally useful after a break or return Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/usbdux.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/driv

[PATCH 14/32] staging: comedi: das1800: checkpatch.pl cleanup (break not useful)

Fix the checkpatch.pl warnings: WARNING: break is not useful after a goto or return Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/das1800.c | 8 1 file changed, 8 deletions(-) diff --git a/drivers/staging/comedi/drivers/das

[PATCH 22/32] staging: comedi: ni_mio_common: checkpatch.pl cleanup (break not useful)

Fix the checkpatch.pl warning: WARNING: break is not useful after a goto or return Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_mio_common.c | 41 +- 1 file changed, 1 insertion(+), 40 deletions(-) diff -

[PATCH 10/32] staging: comedi: cb_pcidas64: checkpatch.pl cleanup (else after return)

Fix these checkpatch.pl warnings: WARNING: else is not generally useful after a break or return Also, remove an unnecessary trailing ';' at the end of a function. Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/cb_pcidas64.c | 20

[PATCH 07/32] staging: comedi: amplc_dio200_common: checkpatch.pl cleanup (else after return)

Fix these checkpatch.pl warnings: WARNING: else is not generally useful after a break or return Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/amplc_dio200_common.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff -

[PATCH 20/32] staging: comedi: ni_660x: checkpatch.pl cleanup (else not useful)

Fix the checkpatch.pl warning: WARNING: else is not generally useful after a break or return Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/ni_660x.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/stag

[PATCH 04/32] staging: comedi: 8255_pci: checkpatch.pl cleanup (else after return)

Fix the checkpatch.pl warning in this file: WARNING: else is not generally useful after a break or return Signed-off-by: H Hartley Sweeten Cc: Ian Abbott Cc: Greg Kroah-Hartman --- drivers/staging/comedi/drivers/8255_pci.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/

  1   2   >